GNU bug report logs - #71720
[PATCH] Do not prematurely truncate python eldoc string

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#71720: closed ([PATCH] Do not prematurely truncate python
 eldoc string)
Date: Thu, 27 Jun 2024 08:57:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 27 Jun 2024 11:56:31 +0300
with message-id <86pls269xc.fsf <at> gnu.org>
and subject line Re: bug#71720: [PATCH] Do not prematurely truncate python eldoc string
has caused the debbugs.gnu.org bug report #71720,
regarding [PATCH] Do not prematurely truncate python eldoc string
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
71720: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71720
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: James Thomas <jimjoe <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Do not prematurely truncate python eldoc string
Date: Sat, 22 Jun 2024 18:14:21 +0530

[Message part 3 (text/plain, inline)]

- emacs -Q
- C-x C-f test.py
- M-x run-python
- C-x o
- Type: print(

Only one line is shown, even with:

- M-x eldoc-doc-buffer.

[0001-Do-not-prematurely-truncate-python-eldoc-string.patch (text/x-patch, attachment)]

[Message part 5 (text/plain, inline)]

--

[Message part 6 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: James Thomas <jimjoe <at> gmx.net>
Cc: kobarity <at> gmail.com, 71720-done <at> debbugs.gnu.org
Subject: Re: bug#71720: [PATCH] Do not prematurely truncate python eldoc string
Date: Thu, 27 Jun 2024 11:56:31 +0300

> From: James Thomas <jimjoe <at> gmx.net>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  71720 <at> debbugs.gnu.org
> Date: Sun, 23 Jun 2024 08:32:19 +0530
> 
> kobarity wrote:
> 
> > James Thomas wrote:
> >> Eli Zaretskii wrote:
> >>
> >> >> Date: Sat, 22 Jun 2024 23:16:51 +0900
> >> >> From: kobarity <kobarity <at> gmail.com>
> >> >> Cc: 71720 <at> debbugs.gnu.org
> >> >>
> >> >> Eli Zaretskii wrote:
> >> >> >
> >> >> > kobarity, any comments?
> >> >>
> >> >> I agree with this fix.  For those who want the same behavior as
> >> >> before, setting eldoc-echo-area-use-multiline-p to nil should be
> >> >> sufficient.  It might be better to make this change known in etc/NEWS,
> >> >> though.
> >> >
> >> > Thanks.
> >> >
> >> > James, can you add a NEWS entry and resubmit?
> >>
> >> How about this?
> >
> >> +*** 'eldoc' no longer truncates to a single line by default.
> >> +Previously, the entire docstring was not available to eldoc, which made
> >> +'eldoc-echo-area-use-multiline-p' ineffective. The old behaviour may be
> >> +kept by setting that.
> >> +
> >
> > Thanks, I think the content is perfect, but from other examples, it
> > might be better to have two spaces after the period.
> 
> Fixed:

Thanks, installed on the emacs-30 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.