GNU bug report logs - #71720
[PATCH] Do not prematurely truncate python eldoc string

Previous Next

Package: emacs;

Reported by: James Thomas <jimjoe <at> gmx.net>

Date: Sat, 22 Jun 2024 12:45:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #26 received at 71720 <at> debbugs.gnu.org (full text, mbox):

From: kobarity <kobarity <at> gmail.com>
To: James Thomas <jimjoe <at> gmx.net>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 71720 <at> debbugs.gnu.org
Subject: Re: bug#71720: [PATCH] Do not prematurely truncate python eldoc string
Date: Sun, 23 Jun 2024 12:53:04 +0900
James Thomas wrote:
> kobarity wrote:
> 
> > James Thomas wrote:
> >> Eli Zaretskii wrote:
> >>
> >> >> Date: Sat, 22 Jun 2024 23:16:51 +0900
> >> >> From: kobarity <kobarity <at> gmail.com>
> >> >> Cc: 71720 <at> debbugs.gnu.org
> >> >>
> >> >> Eli Zaretskii wrote:
> >> >> >
> >> >> > kobarity, any comments?
> >> >>
> >> >> I agree with this fix.  For those who want the same behavior as
> >> >> before, setting eldoc-echo-area-use-multiline-p to nil should be
> >> >> sufficient.  It might be better to make this change known in etc/NEWS,
> >> >> though.
> >> >
> >> > Thanks.
> >> >
> >> > James, can you add a NEWS entry and resubmit?
> >>
> >> How about this?
> >
> >> +*** 'eldoc' no longer truncates to a single line by default.
> >> +Previously, the entire docstring was not available to eldoc, which made
> >> +'eldoc-echo-area-use-multiline-p' ineffective. The old behaviour may be
> >> +kept by setting that.
> >> +
> >
> > Thanks, I think the content is perfect, but from other examples, it
> > might be better to have two spaces after the period.
> 
> Fixed:

Thanks, it looks good to me.




This bug report was last modified 1 year and 57 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.