GNU bug report logs - #71720
[PATCH] Do not prematurely truncate python eldoc string

Previous Next

Full log

View this message in rfc822 format

From: kobarity <kobarity <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, James Thomas <jimjoe <at> gmx.net>
Cc: 71720 <at> debbugs.gnu.org
Subject: bug#71720: [PATCH] Do not prematurely truncate python eldoc string
Date: Sat, 22 Jun 2024 23:16:51 +0900

Eli Zaretskii wrote:
> 
> > Date: Sat, 22 Jun 2024 18:14:21 +0530
> > From:  James Thomas via "Bug reports for GNU Emacs,
> >  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> > 
> > - emacs -Q
> > - C-x C-f test.py
> > - M-x run-python
> > - C-x o
> > - Type: print(
> > 
> > Only one line is shown, even with:
> > 
> > - M-x eldoc-doc-buffer.
> > 
> > 
> > From 9fb4b45ef2c408ff76d5e145ea3c38eac60b4d16 Mon Sep 17 00:00:00 2001
> > From: James Thomas <jimjoe <at> gmx.net>
> > Date: Sat, 22 Jun 2024 17:57:00 +0530
> > Subject: [PATCH] Do not prematurely truncate python eldoc string
> > 
> > 'eldoc-echo-area-use-multiline-p' is there for that.
> > * lisp/progmodes/python.el (python-eldoc-setup-code):
> > Make the change.
> > ---
> >  lisp/progmodes/python.el | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
> > index bb2bf1731b4..a52e21f625e 100644
> > --- a/lisp/progmodes/python.el
> > +++ b/lisp/progmodes/python.el
> > @@ -5607,8 +5607,6 @@ python-eldoc-setup-code
> >                  doc = '{objtype} {name}{args}'.format(
> >                      objtype=objtype, name=name, args=args
> >                  )
> > -        else:
> > -            doc = doc.splitlines()[0]
> >      except:
> >          doc = ''
> >      return doc"
> > --
> > 2.43.0
> 
> kobarity, any comments?

I agree with this fix.  For those who want the same behavior as
before, setting eldoc-echo-area-use-multiline-p to nil should be
sufficient.  It might be better to make this change known in etc/NEWS,
though.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.