From unknown Sat Sep 20 08:45:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#71720 <71720@debbugs.gnu.org> To: bug#71720 <71720@debbugs.gnu.org> Subject: Status: [PATCH] Do not prematurely truncate python eldoc string Reply-To: bug#71720 <71720@debbugs.gnu.org> Date: Sat, 20 Sep 2025 15:45:08 +0000 retitle 71720 [PATCH] Do not prematurely truncate python eldoc string reassign 71720 emacs submitter 71720 James Thomas severity 71720 normal tag 71720 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 08:44:36 2024 Received: (at submit) by debbugs.gnu.org; 22 Jun 2024 12:44:36 +0000 Received: from localhost ([127.0.0.1]:44655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL06e-0000ri-4N for submit@debbugs.gnu.org; Sat, 22 Jun 2024 08:44:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:57684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL06b-0000rY-O2 for submit@debbugs.gnu.org; Sat, 22 Jun 2024 08:44:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sL06b-0002S7-7U for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 08:44:33 -0400 Received: from mout.gmx.net ([212.227.15.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sL06Z-00067c-Cb for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 08:44:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1719060266; x=1719665066; i=jimjoe@gmx.net; bh=FuUD4HAst021QRIFrU7K0ytRVClKVZrZ/cngRyKMUFY=; h=X-UI-Sender-Class:From:To:Subject:Date:Message-ID:MIME-Version: Content-Type:cc:content-transfer-encoding:content-type:date:from: message-id:mime-version:reply-to:subject:to; b=lzBZTeDpAXwx+XQr2ZcUu+iVTD/Y9Vx2TFb+jnCrs44t+bB2WQAvZNPyPcEfK46E 6HrlHSc5ihYtkJ57hz3fplzI9Z3IqMLoFtDtnlkRIQg2Git9XMykdUTuIKRExGOKm nmTPdMhj4FaAv5JOneSphlCc1slt1j1gEgUmpS31lnYJcLtlYPiZUsyfAqxdJZKv/ aEb4OKZU/VcmBRgs2ZqdUc39aeDzSVyZ7XuwW/udwbVOF0ni9VdFDdaWbKkk0Bob9 Wpe94l68a01dGANsTLnLf/S3IdpFdByTqBRabcPTjX/CfWyeLktJ8joMHF0h46elz 8iKU2eLVXZ2AZkN06w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-3493 ([117.242.203.20]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MBm1e-1sDL7d1sp2-0066TX for ; Sat, 22 Jun 2024 14:44:26 +0200 From: James Thomas To: bug-gnu-emacs@gnu.org Subject: [PATCH] Do not prematurely truncate python eldoc string Date: Sat, 22 Jun 2024 18:14:21 +0530 Message-ID: <86frt5xi3e.fsf@outlook.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:YF722rCcNLao7UyodmkgFcvrm8CDO9ZX5pipox139zuKIsE8hnd IdJ1JALRi1T0+yMl8K3k0laZxF4Y489cHA1NCgardvSIwSka+iP/UQYTv+EJzyywDhL+Zm4 +k5Im7ete//SnHptqkBAYcn3CSRVUC0dytlb1NJvc9wINW2ISWvRprrAPafrR95t8bbEYZR G7jt9Ttjclp//wS0wihNA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:RNJaLYvZKf0=;nw9aLgg51yhaQOAvTnfyo1yVBWt xskSYjBkdGMjPICqUHjeyErJjFDFi2zhR+6WYxsSDXxtJdnCkGveQgx4cf927OP3qJ0rGW2XK 4b6BWisRwV6zryELbSx/U/NkxDtXj0M9LIR2a6tooJ/YYCfZaGk4G0Wn6D07re0J9LmjnzZq3 K57SBgdVB2Ie5vT5wpRIoDDW6Ouj2e8Bqr4c41GcXs5wS2RobhrERORpQteTkmnvXxiCwAbv0 kJ95EEZhDiTosuKFAjHeR+BbHaYM3ltdrd6llyA7Kuxim2x21VFgp0IFOcSsMR9aoHmS5dF7V HSAW0GYuZRrW0eSYeLQXzM0SeyQdqX9LmHAp1odHF1l0vVnemh3n21fqk9snKLm6gRhNIhANY yFsiU+rWbBL24M2/bbz3cqpOzdliKb93KV0KW9Lo12M20M4kXaYNjwamBkWF3knd3GsCYo51A DfsvzvouFpWIFugr//1PfPGTS59j/+2N//VVEXZB9wlxcGSaK3OAu8GkwqcLgPNXkMdbqfeBm Vz9yM8CE3Anl6glqDf/Iy3LX5EDXFsNFIFs0KAPe49OHPbPD27mRSTD0fR3/caQeJGtt5owd9 O/rj7WWwIPjHWuYwA0asiJ/TxvfzhlQKXOh9wCsn2izutCPydQiMp7xVgfw4PowLdOeSNtW+o p42VRnsf3YAINTsKQJV+yJglY3EBAely63ZwTiYid2P0QAx6gu5sk6FKa26cBFiGcwABkXTq9 qyjCe//Ha8rqZjCuMQEKUcwhh8tJ0alSOWTR7ApMn8LEHJcb9azVp5BatIBasVo7/JN/AB1pn VEPLeUWJNxgBJyZ5Td7ueTOBq+ZinXJrC+JK+fitzoPNc= Received-SPF: pass client-ip=212.227.15.19; envelope-from=jimjoe@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain - emacs -Q - C-x C-f test.py - M-x run-python - C-x o - Type: print( Only one line is shown, even with: - M-x eldoc-doc-buffer. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Do-not-prematurely-truncate-python-eldoc-string.patch Content-Description: [PATCH] Do not prematurely truncate python eldoc string Content-Transfer-Encoding: quoted-printable =46rom 9fb4b45ef2c408ff76d5e145ea3c38eac60b4d16 Mon Sep 17 00:00:00 2001 From: James Thomas Date: Sat, 22 Jun 2024 17:57:00 +0530 Subject: [PATCH] Do not prematurely truncate python eldoc string 'eldoc-echo-area-use-multiline-p' is there for that. * lisp/progmodes/python.el (python-eldoc-setup-code): Make the change. =2D-- lisp/progmodes/python.el | 2 -- 1 file changed, 2 deletions(-) diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index bb2bf1731b4..a52e21f625e 100644 =2D-- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -5607,8 +5607,6 @@ python-eldoc-setup-code doc =3D '{objtype} {name}{args}'.format( objtype=3Dobjtype, name=3Dname, args=3Dargs ) - else: - doc =3D doc.splitlines()[0] except: doc =3D '' return doc" =2D- 2.43.0 --=-=-= Content-Type: text/plain -- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 09:03:15 2024 Received: (at 71720) by debbugs.gnu.org; 22 Jun 2024 13:03:16 +0000 Received: from localhost ([127.0.0.1]:44672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL0Oh-0004Ej-J1 for submit@debbugs.gnu.org; Sat, 22 Jun 2024 09:03:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL0Of-0004ES-VC for 71720@debbugs.gnu.org; Sat, 22 Jun 2024 09:03:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sL0Oa-0000XT-9u; Sat, 22 Jun 2024 09:03:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=o32Yk6Cq5igeL6Y/GghtTZhslpyVcU/viZZ8OlIYjg4=; b=Hx7jQHL1Y7jj mDruXnA0vqpXmY65tdg7kFwDjXGEC4AG1zjnVEatV1vdeyhXwlTiXFtYlpD574ba5jzFeVazCd0L3 YDPzBlozyCrNpBmV9DYKXxmgo+0E2qCDOBcI+Uygw4MjQb+PQkzB+UVyuDwqMh4sRqoVmABfIoM9b VBx22n5jpgOfytYLm3Ul7/h/zemK24qiLPN44uSZltfVjhktwJjkpA4LTHbZINLqcSC4OSapS9fYA MdqBcNr3otFbi26E9p2S1UAqXdwMaVPZBIwrzzcw+SZCAmHhKKFsHhasxUxhKcyJNqCEep4Fmf1EK Z+ErWBj0Vw+Sf5aAmneY+w==; Date: Sat, 22 Jun 2024 16:03:06 +0300 Message-Id: <86jzihgmet.fsf@gnu.org> From: Eli Zaretskii To: James Thomas , kobarity In-Reply-To: <86frt5xi3e.fsf@outlook.com> (bug-gnu-emacs@gnu.org) Subject: Re: bug#71720: [PATCH] Do not prematurely truncate python eldoc string References: <86frt5xi3e.fsf@outlook.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71720 Cc: 71720@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 22 Jun 2024 18:14:21 +0530 > From: James Thomas via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > - emacs -Q > - C-x C-f test.py > - M-x run-python > - C-x o > - Type: print( > > Only one line is shown, even with: > > - M-x eldoc-doc-buffer. > > > From 9fb4b45ef2c408ff76d5e145ea3c38eac60b4d16 Mon Sep 17 00:00:00 2001 > From: James Thomas > Date: Sat, 22 Jun 2024 17:57:00 +0530 > Subject: [PATCH] Do not prematurely truncate python eldoc string > > 'eldoc-echo-area-use-multiline-p' is there for that. > * lisp/progmodes/python.el (python-eldoc-setup-code): > Make the change. > --- > lisp/progmodes/python.el | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el > index bb2bf1731b4..a52e21f625e 100644 > --- a/lisp/progmodes/python.el > +++ b/lisp/progmodes/python.el > @@ -5607,8 +5607,6 @@ python-eldoc-setup-code > doc = '{objtype} {name}{args}'.format( > objtype=objtype, name=name, args=args > ) > - else: > - doc = doc.splitlines()[0] > except: > doc = '' > return doc" > -- > 2.43.0 kobarity, any comments? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 10:18:03 2024 Received: (at 71720) by debbugs.gnu.org; 22 Jun 2024 14:18:03 +0000 Received: from localhost ([127.0.0.1]:47560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL1Z4-0006zu-Ro for submit@debbugs.gnu.org; Sat, 22 Jun 2024 10:18:03 -0400 Received: from mail-pl1-f175.google.com ([209.85.214.175]:44342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL1Z3-0006zH-3o for 71720@debbugs.gnu.org; Sat, 22 Jun 2024 10:18:01 -0400 Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1f9c2847618so25271495ad.1 for <71720@debbugs.gnu.org>; Sat, 22 Jun 2024 07:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719065815; x=1719670615; darn=debbugs.gnu.org; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=QLrQ9EyhauWv6g7zWgeO+j7TXSVt5+4pGqU/bFRNZg8=; b=KIaGT5bj3xGpRtNYHutMhT1p8pgLyxpGvOxFswqFR4NcDjvp2DG+bVDN0cH4XUkIfc Bb4ATnmK3t1BATuQfvbevSPt0UdR1AXrgRQwf/DVCi4enntWp2zvq6SGsw+m12mKot4g mwTQ7/BtjZubHyUy+mfg1AMrfQRnCjJqhA682MNXzWqsk+64IjNu1sQD6RPp6RD0H108 cMfKrSunIcJn9HMBdSGEy67BFxWVpzcMPcVimY3sYlRlNgdrcCISPca8X16DN1vCsZ+o OcpVxGgIp4wKesFMnbDAa6TLTK1PseHnK5ajwr8BDBR1GGZtKKSZZd6fTKvyT6+x0dVi ee2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719065815; x=1719670615; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QLrQ9EyhauWv6g7zWgeO+j7TXSVt5+4pGqU/bFRNZg8=; b=U6OJMqt3R/kj8luTgiqVTOMpZsMpC0bCr+mrLuDQC8j5KxLKC9LlqH0r/1M8SPhCsa 1mGhtnYjmOIHz3KhAuu64JNqWiCRDN8CRfZhxvxTU16POCBzUmRsLLJFkwI6+42G/ndb B8yah1QL3eVMg2PSHoUBCOkjt5dQmKgMDpyofAV5BGMRxu0JaHM/GN6jXcFAeULRxprN gNOWHOT2AyaxXABQy2x5tZw/URV5YwAMHmcRxK+OQNHmjotyU0JBEXQHuolI9F2+kWfH u0RdQKugYnfTr5mhwRyuRxISXaJ3k8LmynBvAu1qIJZnOSzWOvBE3a3U49QSE/g3q05p vnYw== X-Gm-Message-State: AOJu0YxrLNUVeH3q+4GFmcm6wf/defIcSOP8WaO2hRrvRQnVes0tCViF ZrodVndb6mG3CsGeosILqDIdPVccoocDxSNHmRVd9s6/hdkNqSZY X-Google-Smtp-Source: AGHT+IGx/L1fMO+p0Iwhs0j74mwVv4rlwjqsBNh6BhV3mBNglb0o1DYBrCX6GyyUX7Bx4KL1R4yG7A== X-Received: by 2002:a17:902:dac9:b0:1fa:781:bb38 with SMTP id d9443c01a7336-1fa15937c43mr7342395ad.51.1719065815035; Sat, 22 Jun 2024 07:16:55 -0700 (PDT) Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9eb2f10fasm31501845ad.15.2024.06.22.07.16.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jun 2024 07:16:54 -0700 (PDT) Date: Sat, 22 Jun 2024 23:16:51 +0900 Message-ID: From: kobarity To: Eli Zaretskii , James Thomas Subject: Re: bug#71720: [PATCH] Do not prematurely truncate python eldoc string In-Reply-To: <86jzihgmet.fsf@gnu.org> References: <86frt5xi3e.fsf@outlook.com> <86jzihgmet.fsf@gnu.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71720 Cc: 71720@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii wrote: > > > Date: Sat, 22 Jun 2024 18:14:21 +0530 > > From: James Thomas via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > - emacs -Q > > - C-x C-f test.py > > - M-x run-python > > - C-x o > > - Type: print( > > > > Only one line is shown, even with: > > > > - M-x eldoc-doc-buffer. > > > > > > From 9fb4b45ef2c408ff76d5e145ea3c38eac60b4d16 Mon Sep 17 00:00:00 2001 > > From: James Thomas > > Date: Sat, 22 Jun 2024 17:57:00 +0530 > > Subject: [PATCH] Do not prematurely truncate python eldoc string > > > > 'eldoc-echo-area-use-multiline-p' is there for that. > > * lisp/progmodes/python.el (python-eldoc-setup-code): > > Make the change. > > --- > > lisp/progmodes/python.el | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el > > index bb2bf1731b4..a52e21f625e 100644 > > --- a/lisp/progmodes/python.el > > +++ b/lisp/progmodes/python.el > > @@ -5607,8 +5607,6 @@ python-eldoc-setup-code > > doc = '{objtype} {name}{args}'.format( > > objtype=objtype, name=name, args=args > > ) > > - else: > > - doc = doc.splitlines()[0] > > except: > > doc = '' > > return doc" > > -- > > 2.43.0 > > kobarity, any comments? I agree with this fix. For those who want the same behavior as before, setting eldoc-echo-area-use-multiline-p to nil should be sufficient. It might be better to make this change known in etc/NEWS, though. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 11:51:00 2024 Received: (at 71720) by debbugs.gnu.org; 22 Jun 2024 15:51:00 +0000 Received: from localhost ([127.0.0.1]:50435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL311-0001xF-Jn for submit@debbugs.gnu.org; Sat, 22 Jun 2024 11:51:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL30y-0001wq-Ou for 71720@debbugs.gnu.org; Sat, 22 Jun 2024 11:50:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sL30t-0005yo-Dr; Sat, 22 Jun 2024 11:50:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PSBNHXoLBRSMfA/aGoyZsfnE8z1TY+U7hvzRuHvj08s=; b=G4bYRWUeMDVp IrsX+A1rMy0pj2qyJq5LaClAE4dQZeiUFy6eklHyLcGFueIjV02YWWS8rC5aS4X8LeD7Sq/FUD0Cd d6rxm6MF+BzPNjqoD4J6yngsE9llItcyX14Frv0hKewu9OIE2NvwbayB2t4wXhkW1UN/XyZpf7gh+ 8xV2eLZKm8kJkwKcP93FtmQKwYJuERqtrT1Y/gtfgAR5NkVOV1IvUYur5wD5J4NFC6Vfb+HxCxtMb 2LAbGQRYd9DxjEOZNwdINPKmK0fhIt8hDQ7DPMpM3R2WFsHrW8KeWyPw+NJcTLVAJ+TWAuIAodF/t AN9g/J6vtYfeKuYPldtfGA==; Date: Sat, 22 Jun 2024 18:50:48 +0300 Message-Id: <86ed8pgenb.fsf@gnu.org> From: Eli Zaretskii To: kobarity In-Reply-To: (message from kobarity on Sat, 22 Jun 2024 23:16:51 +0900) Subject: Re: bug#71720: [PATCH] Do not prematurely truncate python eldoc string References: <86frt5xi3e.fsf@outlook.com> <86jzihgmet.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71720 Cc: 71720@debbugs.gnu.org, jimjoe@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 22 Jun 2024 23:16:51 +0900 > From: kobarity > Cc: 71720@debbugs.gnu.org > > Eli Zaretskii wrote: > > > > kobarity, any comments? > > I agree with this fix. For those who want the same behavior as > before, setting eldoc-echo-area-use-multiline-p to nil should be > sufficient. It might be better to make this change known in etc/NEWS, > though. Thanks. James, can you add a NEWS entry and resubmit? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 17:12:22 2024 Received: (at 71720) by debbugs.gnu.org; 22 Jun 2024 21:12:22 +0000 Received: from localhost ([127.0.0.1]:60460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL821-0004TW-SH for submit@debbugs.gnu.org; Sat, 22 Jun 2024 17:12:22 -0400 Received: from mout.gmx.net ([212.227.17.22]:37617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL81z-0004TB-Bs for 71720@debbugs.gnu.org; Sat, 22 Jun 2024 17:12:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1719090732; x=1719695532; i=jimjoe@gmx.net; bh=Hoyh7Yg8XB8YtN6Ot70s7COSVqyLFI+1SmxWSxoQ2Fw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=sJPdIHVYo+fnx+fSZsXfonsQjXB4eHf2E6N2XHORnAKkiJS1/JNnycKWeOVcJkPA P2/mSyIs97hc1d22K0wUHTeaw+9xNC4aAgE4OVdwP8OjP3PlIxqLvqVjgUxh5SSTE o2fPXRCQ5pv7UFCjVZS5hvR+ZPwyI0s2OSbXumRfRkT88iD59QbUucYef8wjsG8r2 Lm63eyP5bPzdaNV9WFvRkkNMnJVTCN2XLh5i0kqrGK4+1cNN0SA/W7aF9f+VcgjCI 1iXTNqvxoxBNBiBW4SchKBTZZDSmwVbaoFVnt7Mm8ZCbCcsCZvWXC4pCeuUMlos7a vJBnT6W0wXFsZ8ptwQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-3493 ([117.242.203.20]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MUGeB-1rtwG81pq7-00PpFp; Sat, 22 Jun 2024 23:12:12 +0200 From: James Thomas To: Eli Zaretskii Subject: Re: bug#71720: [PATCH] Do not prematurely truncate python eldoc string In-Reply-To: <86ed8pgenb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 22 Jun 2024 18:50:48 +0300") References: <86frt5xi3e.fsf@outlook.com> <86jzihgmet.fsf@gnu.org> <86ed8pgenb.fsf@gnu.org> Date: Sun, 23 Jun 2024 02:42:04 +0530 Message-ID: <86msncvg0r.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:JP0DAGsQML5le+9mVvTkQU8urbAvqTLGh78q8nUTn2di28kJGOg tccdP4196VTy+q+823y10wby8nxnLmAJFfJzSvReCwooyfzLAeKhUk0oVhH39Z2qLa7TMeh 96CBYuI5aQwn+OQQnHPMllvjXIdj0I5R+qewSoczFImED1ZcjLS18KxCLlRZyVPHsKVYHs3 mi/4gldafNNeB3cRNMADA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:c2bWmCH2sNc=;IMEG/q3BU8XTOZOJoPfB+dx7wIw 1srooe1qbaH7bBXkXhIiW3vMjss55DXIXzNvewPUtpHQUZGxDqMQvg4B1EJ89RBqH2BajoKkk J70jRQCv5uxgfMm4G2oA1F7eObgl98k3kEWcP6aBNq4PszKtc4A93y6+LNIgI0zkebkUI8LfS 5/qzuCP8oybAsdMGLaQY+nF7lXRj//vjdDM/IabGEXCBiN96pqEEZyBEbG20Id5/vfvUdy/Wc ufXncLBM35e6krOAhpODd/z13sBv5AmvsxGnvHuKep+NW9YGj3zd0RMFnQ655scu2D3UJG3Ti RmHqNio0FDlZYGqcjrgPUsanHn+KAkh8alt6txa1JX6PFoUQfvgyJzrIWlu6IijdBZ4dfbKCt ODEBYMh7Atvg8oL7jrBMXAeegZGeS+wVX0c9sTyF/V/SzkhN+0MsNvMuKOcvuYX0kIYtO5bac jJQeD5+eyszn444kuL6Gcl11441zRE3IQXKVZNEMuTJ51zN5d/s3q4z01pNr5SNGzKvnKTRF8 dXshTh/IkSpavWo5boj2jcNCtqvqqRDb4Q4MAsbXoEJUADe8lxBtrM6MdWMAAbeSejM8ZhBJD wN5Q/1I/1EiLBuzhdEE/hRIjord3bmTXcIjTYyL5ztQF3poaMFEgqHm7CwgxQk0Ank3LiVA58 +U7v57EirUnI/JkRT7qRGIrAg9ebpLj9R9RBclZzAfHUPKuzNclg8qNYohytMC3c9UGeRlWeQ O8IXLqPv+AQrl8H9rSZU4TANvWFs8PobwYOzQNrJx22dC/kHYlFZLhY/wKFmMV+9t7WHU6bAn ci55mscX+3DNtk7wMirhs6MHTobBDDFpZ6CJ2hLXeFYUg= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71720 Cc: kobarity , 71720@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Eli Zaretskii wrote: >> Date: Sat, 22 Jun 2024 23:16:51 +0900 >> From: kobarity >> Cc: 71720@debbugs.gnu.org >> >> Eli Zaretskii wrote: >> > >> > kobarity, any comments? >> >> I agree with this fix. For those who want the same behavior as >> before, setting eldoc-echo-area-use-multiline-p to nil should be >> sufficient. It might be better to make this change known in etc/NEWS, >> though. > > Thanks. > > James, can you add a NEWS entry and resubmit? How about this? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Do-not-prematurely-truncate-python-eldoc-string.patch Content-Description: [PATCH] Do not prematurely truncate python eldoc string Content-Transfer-Encoding: quoted-printable =46rom 905983647acc87c0e9c9b76fa7922d0288af20b9 Mon Sep 17 00:00:00 2001 From: James Thomas Date: Sat, 22 Jun 2024 17:57:00 +0530 Subject: [PATCH] Do not prematurely truncate python eldoc string 'eldoc-echo-area-use-multiline-p' is there for that. * lisp/progmodes/python.el (python-eldoc-setup-code): Make the change. =2D-- etc/NEWS | 5 +++++ lisp/progmodes/python.el | 2 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 2349cc0cacb..f810b3d04a3 100644 =2D-- a/etc/NEWS +++ b/etc/NEWS @@ -1499,6 +1499,11 @@ interactive Python interpreter specified by 'python= -interpreter'. It sends the python block delimited by 'python-nav-beginning-of-block' and 'python-nav-end-of-block' to the inferior Python process. +*** 'eldoc' no longer truncates to a single line by default. +Previously, the entire docstring was not available to eldoc, which made +'eldoc-echo-area-use-multiline-p' ineffective. The old behaviour may be +kept by setting that. + ** Inferior Python mode --- diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index bb2bf1731b4..a52e21f625e 100644 =2D-- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -5607,8 +5607,6 @@ python-eldoc-setup-code doc =3D '{objtype} {name}{args}'.format( objtype=3Dobjtype, name=3Dname, args=3Dargs ) - else: - doc =3D doc.splitlines()[0] except: doc =3D '' return doc" =2D- 2.43.0 --=-=-= Content-Type: text/plain -- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 20:49:09 2024 Received: (at 71720) by debbugs.gnu.org; 23 Jun 2024 00:49:09 +0000 Received: from localhost ([127.0.0.1]:37874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLBPp-0005uJ-Jz for submit@debbugs.gnu.org; Sat, 22 Jun 2024 20:49:09 -0400 Received: from mail-oa1-f49.google.com ([209.85.160.49]:61680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLBPn-0005tr-Ox for 71720@debbugs.gnu.org; Sat, 22 Jun 2024 20:49:08 -0400 Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-259884ef4ddso1540414fac.2 for <71720@debbugs.gnu.org>; Sat, 22 Jun 2024 17:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719103682; x=1719708482; darn=debbugs.gnu.org; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=DX8nY+TqU4lRqxQPCfxbNXC3cDAe0cKtkCwoaZ6kbeA=; b=cqbwtf3V6owX08jGxU6Lfjn4Ysg/LGoxLJmcnRJBFfuMELkkBS0AtJERtulVbJ0Icz cb+Dyb4aqWe1VpS0zcdf2pr9n0kwsts0b/rNzmAXHCo3NyeZC+4mblyqymhtJtQ5d3Pz 5Pol8C5K/Qv+F+VcyTe3127cGbNxB1Q74C5j6FNzMv6Z5ho2Ke/RFAB6aQe2nWVN+un1 0I3axomh4s2NbVc9C72HPPAwPefuyuaZyMQhh2V/nDWcONDwhJ+1DaxOt7TA1DpLSwCI BiVcKqmDyjUJi8qTD6faalxLVf8TxYFgQ1zMpiQwrZ0eEVYVWU3IL2XHQ981JMQXoV1t UAUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719103682; x=1719708482; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DX8nY+TqU4lRqxQPCfxbNXC3cDAe0cKtkCwoaZ6kbeA=; b=LeYMEXLQJhJpnLL5EPXOnZ1/cUo4XZ0kBcJgilGHwJUv+tuA6I74/sc16C4+cuZVfq bQdOSBCXVfePH+ygVwoTXw0CpacZkCIXNq9UfgstErm+/2Cf2nkhFtj923GDrlgNJZoD WhZNTTIqQqW0WPCnHEMqAE3N4fRFY8NQ6GwWUakO2LnqDGZ0Byouqfb5cKCzR5s80+of 3y++F8IyNg7i4PfhtWNf3q/w8v56qojKtP5Uw2CytfmSvO2wZjheVxpekTNKZhpV9rfK 2nOMzF6CK+aAoDmzygtmqckhG8KavxKkXAQik7sqZ2mF0T1SCbfu3UT5OlSnUYNZMeF2 YB9g== X-Forwarded-Encrypted: i=1; AJvYcCUEef3moLCnSJoDYCgpk9eOYlFXb6H9X61EsHlNQQ1WhR5If4j+VGQWX2rvRV2bqntLgumniBG+JoyOvXUWMkVn3zqN41Q= X-Gm-Message-State: AOJu0YyuhsMn2Annrru1lbSlX+2sVaKy4gcpOu0NR8hQCpS0Yy0yWDUr foVx4XmmVk8ahBYOydlJK7Yt+mW8hz1MvskPZFgen/YlK9/iKksh X-Google-Smtp-Source: AGHT+IHjZEaM9U+oyFe1neaE/+JhMRXYgrPPhuQja2lhPM1ccBFen4mtWaZlGfhq3GpC069f/iHtmQ== X-Received: by 2002:a05:6870:d20a:b0:254:a2c2:d3cc with SMTP id 586e51a60fabf-25d06bd771fmr1118105fac.19.1719103681667; Sat, 22 Jun 2024 17:48:01 -0700 (PDT) Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7065129969bsm3676247b3a.156.2024.06.22.17.48.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jun 2024 17:48:01 -0700 (PDT) Date: Sun, 23 Jun 2024 09:47:58 +0900 Message-ID: From: kobarity To: James Thomas Subject: Re: bug#71720: [PATCH] Do not prematurely truncate python eldoc string In-Reply-To: <86msncvg0r.fsf@gmx.net> References: <86frt5xi3e.fsf@outlook.com> <86jzihgmet.fsf@gnu.org> <86ed8pgenb.fsf@gnu.org> <86msncvg0r.fsf@gmx.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71720 Cc: Eli Zaretskii , 71720@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) James Thomas wrote: > Eli Zaretskii wrote: > > >> Date: Sat, 22 Jun 2024 23:16:51 +0900 > >> From: kobarity > >> Cc: 71720@debbugs.gnu.org > >> > >> Eli Zaretskii wrote: > >> > > >> > kobarity, any comments? > >> > >> I agree with this fix. For those who want the same behavior as > >> before, setting eldoc-echo-area-use-multiline-p to nil should be > >> sufficient. It might be better to make this change known in etc/NEWS, > >> though. > > > > Thanks. > > > > James, can you add a NEWS entry and resubmit? > > How about this? > +*** 'eldoc' no longer truncates to a single line by default. > +Previously, the entire docstring was not available to eldoc, which made > +'eldoc-echo-area-use-multiline-p' ineffective. The old behaviour may be > +kept by setting that. > + Thanks, I think the content is perfect, but from other examples, it might be better to have two spaces after the period. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 23:02:40 2024 Received: (at 71720) by debbugs.gnu.org; 23 Jun 2024 03:02:40 +0000 Received: from localhost ([127.0.0.1]:41323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLDV2-0001mc-0C for submit@debbugs.gnu.org; Sat, 22 Jun 2024 23:02:40 -0400 Received: from mout.gmx.net ([212.227.15.18]:52925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLDV0-0001mM-1R for 71720@debbugs.gnu.org; Sat, 22 Jun 2024 23:02:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1719111748; x=1719716548; i=jimjoe@gmx.net; bh=FTFNQufGJiLdwETlX1LUNGb5XEGKl+UKdNkc0jMi36Y=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=IxLGft3S8eU9/u0HYzu/BeTaN/RTulD2nab7mydl9ycdXR4s5yalf1iJPbRH84i5 jzh1VrQCyaZdt8/Jyp+JIQWNOIFp99Flmxy3GB2BZ5/MD6QL+7RkWnbVmXQrX04ox Sl3rEktJbg7DMrXg3VobXg6VaRwFdidIbNlh6tP5Eu+JcxW5i6+2leeRq242SOoMt /9Z2EkMYeIy5xY4WHJ6XtVF8SFv5hxTfwNcZmjQAwEnjI2qXnLQWuDWhsii9wXs32 2B7LKRtyBm1hGDXnv0sdcahEV+uu/t5tk/XYUWTMqz2shOBB22hMNzXvDyeoGeTpS 0kd5JVUN1woe4CS+vw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-3493 ([117.242.203.20]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MSKyI-1rx8713SCe-00Mcra; Sun, 23 Jun 2024 05:02:28 +0200 From: James Thomas To: kobarity Subject: Re: bug#71720: [PATCH] Do not prematurely truncate python eldoc string In-Reply-To: (kobarity@gmail.com's message of "Sun, 23 Jun 2024 09:47:58 +0900") References: <86frt5xi3e.fsf@outlook.com> <86jzihgmet.fsf@gnu.org> <86ed8pgenb.fsf@gnu.org> <86msncvg0r.fsf@gmx.net> Date: Sun, 23 Jun 2024 08:32:19 +0530 Message-ID: <86bk3s9xac.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:OflyxVS6KleoCafiTZHLRe1QpQ8upjQOB2hpT3Ea493EjbecmvF PZ5AV0pGA1rNHgpbH6zfe3XCrxOQy1TTBSXs1CB6GkvJS7uoc0ouxI5zHQ0hyXKp2cdnNtX 7rAi0H0B3gHqyvnm1uXTpevXKiy/IdQQQOalqhWEFCEwVDsRWj0q09Ua45MCFqNwU8I/bbJ drYzUGmMdNWT0F4GGM/zQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:zM6ilTJOm6Q=;A6KsAZ89o8ltAaONtDYpl0R+OdB NTuUg10tJ31RiZTf89iG1n65znBI0SNtV23KlwgW2fQeoohFwr9fL7AwAD54kiANlpmqPAxTN fhFcxbVLCPL9I1HVuIJeueOjHfI0tTnUyMG/RwwVOrcl8c/CAWk6hNJesUZ4V7/mbBDpH31KV eHFRB9lNa14+o1PA+oIJcxvknjZr89rNHPW2QTYzWM8HJNOSFmLAHSF5iTUAzJBtE2m6VpzR/ YdWl8jA5DufHFSr8Z2hl4KzXApxbdvcepNs7aptk5m5eb6xG74jgaO27OudiiffzIQbVmSpF/ /gla+ag6KV424rpK+Yw9YmovPnFfVrqQd3iQZAPaPbHWfcpLOzhtttZ2Q7MAvVi2CxEZ601Mo QODwZY+pMCG8w7q36SfQRruoQ+WnIY8MZp5LmSOnKKG+scN0RUrT1JlNWnAwsLkSR/02PPknZ Bu/1Pk7w+nFedSFMcJJbKf1UwoyRS5wlp1W74TJRS6bBBSqAYE6TZrqOMJXgb3SSU3kENZr0L HrSJepSObZJBXaqFtn0KDFEUvK+T0Mixqft/DHsO0VFmAtZYjhCKdfkdbD1OAxmayrXR+Sozo Py+mvXDpXIKmXersVLQ2v4kdAyPeWR4OWWYT1YfKpU1PyyuxXWRuwYy1IKCm9slvib4aNhOgt 1AC1QaJVfIvm7tPNlnpiaJFoLB0XAy5FGpv96dLE/Yyt5vt16tumG750ozelryIh/xAAr1XqI T8P14dfsBfjBDaDjHcbBgaQ0G03k9Ko2q3/QJVzIfk4QkGk/o70oBQpMaGgkrdvMg/usCsCQQ fbvDA3XoJ5A+Svqi1aFtWMsGVSCC8fVHFJ7UpkgYoQV48= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71720 Cc: Eli Zaretskii , 71720@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable kobarity wrote: > James Thomas wrote: >> Eli Zaretskii wrote: >> >> >> Date: Sat, 22 Jun 2024 23:16:51 +0900 >> >> From: kobarity >> >> Cc: 71720@debbugs.gnu.org >> >> >> >> Eli Zaretskii wrote: >> >> > >> >> > kobarity, any comments? >> >> >> >> I agree with this fix. For those who want the same behavior as >> >> before, setting eldoc-echo-area-use-multiline-p to nil should be >> >> sufficient. It might be better to make this change known in etc/NEW= S, >> >> though. >> > >> > Thanks. >> > >> > James, can you add a NEWS entry and resubmit? >> >> How about this? > >> +*** 'eldoc' no longer truncates to a single line by default. >> +Previously, the entire docstring was not available to eldoc, which mad= e >> +'eldoc-echo-area-use-multiline-p' ineffective. The old behaviour may b= e >> +kept by setting that. >> + > > Thanks, I think the content is perfect, but from other examples, it > might be better to have two spaces after the period. Fixed: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Do-not-prematurely-truncate-python-eldoc-string.patch Content-Description: [PATCH] Do not prematurely truncate python eldoc string Content-Transfer-Encoding: quoted-printable =46rom f91a94aca5119ebde21e24392b0d46d44dd9e078 Mon Sep 17 00:00:00 2001 From: James Thomas Date: Sat, 22 Jun 2024 17:57:00 +0530 Subject: [PATCH] Do not prematurely truncate python eldoc string 'eldoc-echo-area-use-multiline-p' is there for that. * lisp/progmodes/python.el (python-eldoc-setup-code): Make the change. =2D-- etc/NEWS | 5 +++++ lisp/progmodes/python.el | 2 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 2349cc0cacb..201ef46bac5 100644 =2D-- a/etc/NEWS +++ b/etc/NEWS @@ -1499,6 +1499,11 @@ interactive Python interpreter specified by 'python= -interpreter'. It sends the python block delimited by 'python-nav-beginning-of-block' and 'python-nav-end-of-block' to the inferior Python process. +*** 'eldoc' no longer truncates to a single line by default. +Previously, the entire docstring was not available to eldoc, which made +'eldoc-echo-area-use-multiline-p' ineffective. The old behaviour may be +kept by setting that. + ** Inferior Python mode --- diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index bb2bf1731b4..a52e21f625e 100644 =2D-- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -5607,8 +5607,6 @@ python-eldoc-setup-code doc =3D '{objtype} {name}{args}'.format( objtype=3Dobjtype, name=3Dname, args=3Dargs ) - else: - doc =3D doc.splitlines()[0] except: doc =3D '' return doc" =2D- 2.43.0 --=-=-= Content-Type: text/plain -- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 23:54:16 2024 Received: (at 71720) by debbugs.gnu.org; 23 Jun 2024 03:54:16 +0000 Received: from localhost ([127.0.0.1]:42658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLEIx-0003MQ-TJ for submit@debbugs.gnu.org; Sat, 22 Jun 2024 23:54:16 -0400 Received: from mail-pl1-f179.google.com ([209.85.214.179]:55783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLEIv-0003M9-Ug for 71720@debbugs.gnu.org; Sat, 22 Jun 2024 23:54:15 -0400 Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1f9aeb96b93so23801795ad.3 for <71720@debbugs.gnu.org>; Sat, 22 Jun 2024 20:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719114788; x=1719719588; darn=debbugs.gnu.org; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=qfFJDVQvxSTrX7M7CLhH28PJTOkEGnck8rR5mHDxU3M=; b=HQ2NDyJ6ME4i39rnjuVsUQLRZ3Svqnd/QaUvTfzxZdGJKVGyOwFElIPXop2tzIGk+I 0k5FjdZ817nd0Eq1KrQI5QQ76Bhrr2AJ5HRYE5DX6tKw+D7f3H2YNoAmjqmuHfivaIj4 I3ngkunQOiSrUVN/c7h56Hi/1jQ18zlMuwWDbaRCLKSIJoGdT/Rq7ik3nELBy7hvc9Wu HkGmdWSuClLwSL6gEIJlcCY9zXbhUTdMr1BS5oB3r0Dppb2vO2rW2hM2lWBYac6uxseB bpUJFQQa+EeDAL7uO+plKvOZF9ycy8QGSfN4DsInshLYPPiXezSlmqN6QNhofdrcmpi+ 92KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719114788; x=1719719588; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qfFJDVQvxSTrX7M7CLhH28PJTOkEGnck8rR5mHDxU3M=; b=HWM67nZ87JTBHm+mDxS26ehixyygNNEieSIIi/wNMQQ6bZvHAC8mRqrN7IBJTmBm3I 4eQ9sImgKtBpTi8jwvfeDgDk534t3w6jyWMiWy2YJxpFlNGm1Nt1jvwS+h5QXxQJgGQ/ Ml0zynLH6xyG1Y2csZnaRkveYpABl1AbgkFZN97FbihQ+nXwjuOb94KqEbZudaxQEtHV a2lJA9vQ+YW3kDWtso+u5KldSG7hHwtVkPKunZbCn0bPvLMrwQXRXxxN+02EnzU32hZY +a/ItX2VjnHu67JuHt/NYmhxl5+P6HnHG9coocJp0V1vUvL0MjQGrmfWtKEuslLSPGtF 5bkA== X-Gm-Message-State: AOJu0YzPmU73R1b1kOOdZcbVGeaUf1sbrNlF+M/IyYvW/ubjqZJAJQr8 q8Od8BUjckceCBYohOaiQRKRjztnWCu3Odz35/n0CZIQ4xietY2w X-Google-Smtp-Source: AGHT+IFrvlyjoo6fuA4nUVK1OtyYH6WhpQGJCIsxyRhvqDCs4w7uJrl5CD6/hvWavlyeSCYeI6tEPg== X-Received: by 2002:a17:902:f70f:b0:1fa:2b89:f53f with SMTP id d9443c01a7336-1fa2b89f7a7mr8395265ad.52.1719114787489; Sat, 22 Jun 2024 20:53:07 -0700 (PDT) Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9ebbb5d03sm38326265ad.258.2024.06.22.20.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jun 2024 20:53:07 -0700 (PDT) Date: Sun, 23 Jun 2024 12:53:04 +0900 Message-ID: From: kobarity To: James Thomas , Eli Zaretskii Subject: Re: bug#71720: [PATCH] Do not prematurely truncate python eldoc string In-Reply-To: <86bk3s9xac.fsf@gmx.net> References: <86frt5xi3e.fsf@outlook.com> <86jzihgmet.fsf@gnu.org> <86ed8pgenb.fsf@gnu.org> <86msncvg0r.fsf@gmx.net> <86bk3s9xac.fsf@gmx.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71720 Cc: 71720@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) James Thomas wrote: > kobarity wrote: > > > James Thomas wrote: > >> Eli Zaretskii wrote: > >> > >> >> Date: Sat, 22 Jun 2024 23:16:51 +0900 > >> >> From: kobarity > >> >> Cc: 71720@debbugs.gnu.org > >> >> > >> >> Eli Zaretskii wrote: > >> >> > > >> >> > kobarity, any comments? > >> >> > >> >> I agree with this fix. For those who want the same behavior as > >> >> before, setting eldoc-echo-area-use-multiline-p to nil should be > >> >> sufficient. It might be better to make this change known in etc/NEWS, > >> >> though. > >> > > >> > Thanks. > >> > > >> > James, can you add a NEWS entry and resubmit? > >> > >> How about this? > > > >> +*** 'eldoc' no longer truncates to a single line by default. > >> +Previously, the entire docstring was not available to eldoc, which made > >> +'eldoc-echo-area-use-multiline-p' ineffective. The old behaviour may be > >> +kept by setting that. > >> + > > > > Thanks, I think the content is perfect, but from other examples, it > > might be better to have two spaces after the period. > > Fixed: Thanks, it looks good to me. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 27 04:56:46 2024 Received: (at 71720-done) by debbugs.gnu.org; 27 Jun 2024 08:56:46 +0000 Received: from localhost ([127.0.0.1]:40966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMkvt-00085F-Qb for submit@debbugs.gnu.org; Thu, 27 Jun 2024 04:56:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMkvr-000852-WE for 71720-done@debbugs.gnu.org; Thu, 27 Jun 2024 04:56:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMkvj-0008Ku-MB; Thu, 27 Jun 2024 04:56:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Bk1gg5FQBBPfDf82BCr4twhY5YykP1/ZiLMfeShbL5Q=; b=DgRItRe0ZVzm HosOAoP00pQXF3FT2vgtFcyt62nEK3RHeaXCjKG3knNoqjaCrlgV3ccEMzWrQMo7shmLZbHPemmwI aR4YvxbQ6AhBjv0T/pfSqt1FsXYXuXevh+sEx30PN8ydl1gvEiV36D+6iwxYmL64NExB7MZusqMPg /ordi74aYsrC4x7OIMTt2unW1XWe5xgFJEpagvOfrUGP4eDcL+tSTCoWIoocSZ+6jsByzLbz7Aq5y XMqKkq8U8aSdD/K3Ib/KwVwiJbf6opWY5o11jj4m0B81h6YGAfTc6gQpaE6/HR/SV3vBdzC873yyE 0sGh3G5ME64Rvgyb5jNicw==; Date: Thu, 27 Jun 2024 11:56:31 +0300 Message-Id: <86pls269xc.fsf@gnu.org> From: Eli Zaretskii To: James Thomas In-Reply-To: <86bk3s9xac.fsf@gmx.net> (message from James Thomas on Sun, 23 Jun 2024 08:32:19 +0530) Subject: Re: bug#71720: [PATCH] Do not prematurely truncate python eldoc string References: <86frt5xi3e.fsf@outlook.com> <86jzihgmet.fsf@gnu.org> <86ed8pgenb.fsf@gnu.org> <86msncvg0r.fsf@gmx.net> <86bk3s9xac.fsf@gmx.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71720-done Cc: kobarity@gmail.com, 71720-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: James Thomas > Cc: Eli Zaretskii , 71720@debbugs.gnu.org > Date: Sun, 23 Jun 2024 08:32:19 +0530 > > kobarity wrote: > > > James Thomas wrote: > >> Eli Zaretskii wrote: > >> > >> >> Date: Sat, 22 Jun 2024 23:16:51 +0900 > >> >> From: kobarity > >> >> Cc: 71720@debbugs.gnu.org > >> >> > >> >> Eli Zaretskii wrote: > >> >> > > >> >> > kobarity, any comments? > >> >> > >> >> I agree with this fix. For those who want the same behavior as > >> >> before, setting eldoc-echo-area-use-multiline-p to nil should be > >> >> sufficient. It might be better to make this change known in etc/NEWS, > >> >> though. > >> > > >> > Thanks. > >> > > >> > James, can you add a NEWS entry and resubmit? > >> > >> How about this? > > > >> +*** 'eldoc' no longer truncates to a single line by default. > >> +Previously, the entire docstring was not available to eldoc, which made > >> +'eldoc-echo-area-use-multiline-p' ineffective. The old behaviour may be > >> +kept by setting that. > >> + > > > > Thanks, I think the content is perfect, but from other examples, it > > might be better to have two spaces after the period. > > Fixed: Thanks, installed on the emacs-30 branch, and closing the bug. From unknown Sat Sep 20 08:45:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 25 Jul 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator