Subject: bug#71720: closed (Re: bug#71720: [PATCH] Do not prematurely truncate python eldoc string)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 27 Jun 2024 08:57:01 +0000

Your bug report

#71720: [PATCH] Do not prematurely truncate python eldoc string

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
71720: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71720
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#71720: [PATCH] Do not prematurely truncate python eldoc string
From: Eli Zaretskii <[email-masked]>
To: James Thomas <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Thu, 27 Jun 2024 11:56:31 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: James Thomas <[email-masked]>
> Cc: Eli Zaretskii <[email-masked]>,  [email-masked]
> Date: Sun, 23 Jun 2024 08:32:19 +0530
> 
> kobarity wrote:
> 
> > James Thomas wrote:
> >> Eli Zaretskii wrote:
> >>
> >> >> Date: Sat, 22 Jun 2024 23:16:51 +0900
> >> >> From: kobarity <[email-masked]>
> >> >> Cc: [email-masked]
> >> >>
> >> >> Eli Zaretskii wrote:
> >> >> >
> >> >> > kobarity, any comments?
> >> >>
> >> >> I agree with this fix.  For those who want the same behavior as
> >> >> before, setting eldoc-echo-area-use-multiline-p to nil should be
> >> >> sufficient.  It might be better to make this change known in etc/NEWS,
> >> >> though.
> >> >
> >> > Thanks.
> >> >
> >> > James, can you add a NEWS entry and resubmit?
> >>
> >> How about this?
> >
> >> +*** 'eldoc' no longer truncates to a single line by default.
> >> +Previously, the entire docstring was not available to eldoc, which made
> >> +'eldoc-echo-area-use-multiline-p' ineffective. The old behaviour may be
> >> +kept by setting that.
> >> +
> >
> > Thanks, I think the content is perfect, but from other examples, it
> > might be better to have two spaces after the period.
> 
> Fixed:

Thanks, installed on the emacs-30 branch, and closing the bug.

Subject: [PATCH] Do not prematurely truncate python eldoc string
From: James Thomas <[email-masked]>
To: [email-masked]
Date: Sat, 22 Jun 2024 18:14:21 +0530
List-Id: <debbugs-submit.debbugs.gnu.org>

- emacs -Q
- C-x C-f test.py
- M-x run-python
- C-x o
- Type: print(

Only one line is shown, even with:

- M-x eldoc-doc-buffer.

From 9fb4b45ef2c408ff76d5e145ea3c38eac60b4d16 Mon Sep 17 00:00:00 2001
From: James Thomas <[email-masked]>
Date: Sat, 22 Jun 2024 17:57:00 +0530
Subject: [PATCH] Do not prematurely truncate python eldoc string

'eldoc-echo-area-use-multiline-p' is there for that.
* lisp/progmodes/python.el (python-eldoc-setup-code):
Make the change.
---
 lisp/progmodes/python.el | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
index bb2bf1731b4..a52e21f625e 100644
--- a/lisp/progmodes/python.el
+++ b/lisp/progmodes/python.el
@@ -5607,8 +5607,6 @@ python-eldoc-setup-code
                 doc = '{objtype} {name}{args}'.format(
                     objtype=objtype, name=name, args=args
                 )
-        else:
-            doc = doc.splitlines()[0]
     except:
         doc = ''
     return doc"
--
2.43.0

--