GNU bug report logs - #71716
[PATCH] Add new completion-preview-insert-{word,sexp} commands

Previous Next

Full log

View this message in rfc822 format

From: Jules Tamagnan <jtamagnan <at> gmail.com>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: 71716 <at> debbugs.gnu.org
Subject: bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands
Date: Thu, 27 Jun 2024 22:49:02 -0700

Eshel Yaron <me <at> eshelyaron.com> writes:

> Thank you, pushed to master as commit b3017e7c252, after some tweaks to
> the commit message.  I've also pushed a follow up commit (9cb2a204088)
> with some minor refinements, see the commit message for details.  One
> notable change is that completion-preview-partial-insert does not force
> point to the position of the preview overlay ("end") before calling the
> motion function.  This makes completion-preview-insert-word behave more
> like forward-word when point is in the middle of a multi-word symbol,
> with the completion preview at the end of that symbol.  I've added
> another test case that demonstrates this behavior.
>
> Could you please give it a try to make sure that everything still works
> as you expect?
>
> Thanks,
>
> Eshel

I've taken this change around the block since yesterday and everything
seems to be working exactly as I would expect it to. I've also reviewed
the cleanup that you did and tried to take some notes, especially on the
commit message. Thanks again for all of the work that you put into
creating this packaging in the first place, helping me through my
change, and cleaning up the rough edges in the aftermath.

Best,
Jules

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.