From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 21 15:12:59 2024 Received: (at submit) by debbugs.gnu.org; 21 Jun 2024 19:13:00 +0000 Received: from localhost ([127.0.0.1]:43816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKjgx-0005PR-5W for submit@debbugs.gnu.org; Fri, 21 Jun 2024 15:12:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:57290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKikj-0003KE-2S for submit@debbugs.gnu.org; Fri, 21 Jun 2024 14:12:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKika-0003s3-Kh for bug-gnu-emacs@gnu.org; Fri, 21 Jun 2024 14:12:47 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKikZ-0006VI-50 for bug-gnu-emacs@gnu.org; Fri, 21 Jun 2024 14:12:40 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-361785bfa71so1851781f8f.2 for ; Fri, 21 Jun 2024 11:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718993556; x=1719598356; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=NKZgkbuRcS6z46IL/JO9mmLUhV4ufdDXEZO16Gdfn3g=; b=FR+JEpOE4EFZYg7LmZsp23M2KBEfw94mGFpal/ml6X7lS/hVDNs6D4LOjLTyROchbA GncR8EgR/ZAwB7BiguNmQ2poy/sdZgP0neUUarKfgO+l89sMOX2xQ88qd9wpW9ywCNiR xJPlJVfKeCUWCRK7YJG2P/Enc/Cmc/oDsmjxdXeLkOYiMvSHtmoF0NIjbXljgKPbtF+7 YuZWAnYpw03vsMJK+9dd9mqXWyPKadnQRwYplQvGoHumVztHllYe8x8wqcrIReJncDHT 6UTDGwuiWhLHFBvdcGCkK4D8rTlRFynjjtiY5iKVP0ovahsALXrio+VhxbeXYy+SywJB bOfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718993556; x=1719598356; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NKZgkbuRcS6z46IL/JO9mmLUhV4ufdDXEZO16Gdfn3g=; b=ciwx0VoGhvPU+mizY0w0mN3xxlF2/fvR+nK+5I4BzPfRbAJP/DiopgTclHqfKVs2Xl 2ffRll1Tdue0/zHudimCry1vXYAhe34yONKocqOVmTdDrx2uUbKXZE5Bczh3sCe4Fg6z GtiVBTKBv3+TXIVeb5RFxXS50+WILAs6yq4/IiKbN4+leR3DcppPN2ZkbmgPGGOGk3wD I838CAeo1cUC3X3T0GJEY4p9EkhqIPrXnMJcCNQJwnl1iigzdGHrSQFAhaZc7v4jVGG8 JugOoDBMBdNjAZcl2DN0Ug+aZAtVOE3v5A1x620W6IZwr392r9wRMoafDYSL7Y4Cx4zN 7grw== X-Gm-Message-State: AOJu0Ywn9B00opyPEJeZrjrQZnpSc0lC45EK60wzbtjMEb78EDxUjeSK H1KR8iJuZ9IbA/zhFda1q8SJ4ZZQookuDYKPDzJ/M71UJSIIfdDUuIJw4vo2A6VjW8qunXoAe9o TbP9WYDjm0JuHApzLJqyHF5qCNaSveRMB X-Google-Smtp-Source: AGHT+IFa54D+yrMxemgltchT/iVltcitRHqvV5IJyxQuGyYuLqGyRZc52bCcjP/AAOtkhCmBN3/7dbToc6yT40nNIPo= X-Received: by 2002:a05:6000:1104:b0:360:9910:6f5 with SMTP id ffacd0b85a97d-363191d9819mr6122821f8f.46.1718993555649; Fri, 21 Jun 2024 11:12:35 -0700 (PDT) MIME-Version: 1.0 From: Iurie Marian Date: Fri, 21 Jun 2024 20:12:24 +0200 Message-ID: Subject: Fix recent change in tramp-sh-handle-make-process To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000419871061b6a60d0" Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=marian.iurie@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 21 Jun 2024 15:12:57 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000419871061b6a60d0 Content-Type: multipart/alternative; boundary="000000000000419870061b6a60ce" --000000000000419870061b6a60ce Content-Type: text/plain; charset="UTF-8" tramp-sh-handle-make-process is failing when `:stderr' argument is used. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2024-06-21 built on rrouwprlc0222 Repository revision: e7123edfe7f7abc9043429dfb3f84941f83d6565 Repository branch: master System Description: Ubuntu 24.04 LTS --000000000000419870061b6a60ce Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
tramp-sh-handle-make-process is failing when `:stderr'= argument is used.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linu= x-gnu, GTK+ Version
=C2=A03.24.41, cairo version 1.18.0) of 2024-06-21 b= uilt on rrouwprlc0222
Repository revision: e7123edfe7f7abc9043429dfb3f84= 941f83d6565
Repository branch: master
System Description: Ubuntu 24.0= 4 LTS


--000000000000419870061b6a60ce-- --000000000000419871061b6a60d0 Content-Type: text/x-patch; charset="US-ASCII"; name="tramp-sh-handle-make-process.patch" Content-Disposition: attachment; filename="tramp-sh-handle-make-process.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lxp0d5tw0 ZGlmZiAtLWdpdCBhL2xpc3AvbmV0L3RyYW1wLXNoLmVsIGIvbGlzcC9uZXQvdHJhbXAtc2guZWwK aW5kZXggYmNlN2MzMjNkYWQuLjY4MDE4Mjk4YjY4IDEwMDY0NAotLS0gYS9saXNwL25ldC90cmFt cC1zaC5lbAorKysgYi9saXNwL25ldC90cmFtcC1zaC5lbApAQCAtMjk2OSw2ICsyOTY5LDcgQEAg dHJhbXAtc2gtaGFuZGxlLW1ha2UtcHJvY2VzcwogICAgICAgKGxldCogKChwcm9ncmFtIChjYXIg Y29tbWFuZCkpCiAJICAgICAoYXJncyAoY2RyIGNvbW1hbmQpKQogCSAgICAgOzsgU1RERVJSIGNh biBhbHNvIGJlIGEgZmlsZSBuYW1lLgorICAgICAgICAgICAgIChzdGRlcnIgKHBsaXN0LWdldCBh cmdzIDpzdGRlcnIpKQogCSAgICAgKHRtcHN0ZGVycgogCSAgICAgIChhbmQgc3RkZXJyCiAJCSAg ICh0cmFtcC11bnF1b3RlLWZpbGUtbG9jYWwtbmFtZQo= --000000000000419871061b6a60d0-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 21 15:21:49 2024 Received: (at 71709) by debbugs.gnu.org; 21 Jun 2024 19:21:50 +0000 Received: from localhost ([127.0.0.1]:43852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKjpV-0008TN-Jj for submit@debbugs.gnu.org; Fri, 21 Jun 2024 15:21:49 -0400 Received: from mout.gmx.net ([212.227.17.20]:58165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKjpS-0008T4-R9 for 71709@debbugs.gnu.org; Fri, 21 Jun 2024 15:21:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1718997698; x=1719602498; i=michael.albinus@gmx.de; bh=mFZezT3WNgPhVYvZjWFxXwc4Y+YQTxN5KAhftsXSVfQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=pLzauOUQGblSN2GJzPaRZJgcrO375GQU6fTOsPHXkp9QeLFTRjWbUNmsUvIbPH59 MRMQIak3PVe+N01U9ilQrlTJkMlRuKfenlKYXOfAtyq1Jdn4SMKEG5XlZCAtRJivD 3vDjFe3CoS8ySuyuVovAQhvLQWDO5N2nGGBZ9MuSVa2w/L8/+q3liWvjspgQdJSOV PF4MEJ0qVC9ajLAG7jU8CCYcd0YuXzyUTQFoltWv7ZX8D8ksKD+nJjymAPz9MXBtW joJvWLihLKbutdD50qLoudd7JitH5MBleOW0lXK089PF7UYXpKCpM8UuPFUimgpdw BxvGhsre+xIlwnrsEA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N5mKJ-1sRQl737jH-0144Ud; Fri, 21 Jun 2024 21:21:38 +0200 From: Michael Albinus To: Iurie Marian Subject: Re: bug#71709: Fix recent change in tramp-sh-handle-make-process In-Reply-To: (Iurie Marian's message of "Fri, 21 Jun 2024 20:12:24 +0200") References: Date: Fri, 21 Jun 2024 21:21:36 +0200 Message-ID: <87msneqeyn.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:kSFMeQGbbG756DY7+56Ok3dEWMjkvt4+ntiRck4nEVQYwxqHT0/ 0pibnql5bF9DXPb/KTptEL8mjSrCBiT0RYBty1zd63f4goQP05MharI05Ih417nAFfjCKi8 fesnnRJxM8LJPUm4hb6qK/4BpZvGVJsDTE1mkeAO4xFr9Gvrc5OQDq9dy1JzcS+06/XEQhC LVVgiBM/HgcKxHS0QabaA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:tQ5ZdiTQvSw=;R+Xzicbrd6PEbi/TrjA8X6EVktK 6BQXcuDowzVjqNJLyU8cJYFCavtZTyfgqJ9SnP528zs0Hl90Avc3f/6ITumy79OSAuIV9+ZgW F+RGU/v9EUrPN87kXMRmJzePvHGTXPkkQ3mUoxtASc5ztn+DFRJVhNJl2HrwVZFffrSG/XWEF OKXhGkH3eWXapGn6fn+bVm2+cjkNjxRjQ3LqcmNsNQ9O2SA9twlwJy8AW9eEbWz2ukWHcKDZR KIvQYe0QlCfsAvMjUgZD/Jp3XDfIOYf8By8E/tIw2eXvIFMz1gIHj9jWMGWP+COoQspfzFWI0 Aq63CmuANB6NfNndZ8Cv3ZJ2HY5mt+sUPoOXGxcPAOE+nQ+VVr4z9mDdjHAPDQxglp/j3pZWk cQNv/9/P9tNEqbbhKR0Or3ClxRXtIzx1K/y0hp25+JocSy1TOSIfgTg6f7KrhrT7T2HRvkhUf NL9Bl5P5GwN509xJG5+IJrdH7eyNun3ERkX/1JVGEnUWSJWvLdooM0bU5X/2HH4TPSVL6fkpD FaJ8l/QU4SaxPr5N7mvNMdRE+uGYpkdigYB/DwQyNGuplWlEwyC4GI9GzU7XnbEgjcjhoguac 2RE1IIEw3WpfUCDtSyhPqtzIV3NHDcabUPipyYWMgsnmyzTL/zTODlRRQtLwQ+8FQFk8LZ/pz feEvKk1KofjCE7K9VSZYQSF0VoaEufQc4KSiTYxM2umH2ZG20e/+qh50/iLLyNZlJ/84maGbl EfLEWUez9Rwajsq0Ct9dPtNA2un8AXIFmTP6PwJeTk3yYkEUmhLZk7+rnC+5/YzuZPMIC4T8k ipQgBAuE2TDAHh4ySD3w/HBc6T4oZk/A1obEuBnkuAsug= X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Iurie Marian writes: Hi, > tramp-sh-handle-make-process is failing when `:stderr' argument is > used. > > In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > 3.24.41, cairo version 1.18.0) of 2024-06-21 built o [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.155 listed in zen.spamhaus.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 71709 Cc: 71709@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Iurie Marian writes: Hi, > tramp-sh-handle-make-process is failing when `:stderr' argument is > used. > > In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > 3.24.41, cairo version 1.18.0) of 2024-06-21 built o [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.155 listed in zen.spamhaus.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Iurie Marian writes: Hi, > tramp-sh-handle-make-process is failing when `:stderr' argument is > used. > > In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > 3.24.41, cairo version 1.18.0) of 2024-06-21 built on rrouwprlc0222 > Repository revision: e7123edfe7f7abc9043429dfb3f84941f83d6565 > Repository branch: master > System Description: Ubuntu 24.04 LTS > > diff --git a/lisp/net/tramp-sh.el b/lisp/net/tramp-sh.el > index bce7c323dad..68018298b68 100644 > --- a/lisp/net/tramp-sh.el > +++ b/lisp/net/tramp-sh.el > @@ -2969,6 +2969,7 @@ tramp-sh-handle-make-process > (let* ((program (car command)) > (args (cdr command)) > ;; STDERR can also be a file name. > + (stderr (plist-get args :stderr)) > (tmpstderr > (and stderr > (tramp-unquote-file-local-name Why that? stderr is extracted from args in tramp-skeleton-make-process. Do you get an error which shows the problem? Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 03:10:59 2024 Received: (at 71709) by debbugs.gnu.org; 22 Jun 2024 07:10:59 +0000 Received: from localhost ([127.0.0.1]:44193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKutm-0005pv-H4 for submit@debbugs.gnu.org; Sat, 22 Jun 2024 03:10:59 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:46440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKlWZ-0005WC-VM for 71709@debbugs.gnu.org; Fri, 21 Jun 2024 17:10:24 -0400 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-364a39824baso1819393f8f.1 for <71709@debbugs.gnu.org>; Fri, 21 Jun 2024 14:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719004158; x=1719608958; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mFF+tZLqt/oYIwwTnkvFnb0bcxITH6vN1nuKwvweNls=; b=kWJ+l5YYv83Xnzf1g1DZydXhWHViTmZtygR3OZjEnhZvT1VyhkBLv3wE0YMqWG0ddB ckczYYQ+NWgZcJ7bXIXLwzR5F8rtJc+t/YYttBz2jOfU0oROZbE+akrWGKR+oR9+aBBL 37qIvyVoZoHmbg2zotJCd2TofAy/lrHie9m/fa5Y6Skmfvp4M1oeUkz4Gs8ry+9zA0db ZK8lMYvbeljtybT8g+EWl84WOvX6nLZxAwPwLrZ5wmBtqfRYyo11yHCwbQqJdbnwrThV Nl2Mc/PLOG74DaS1fqntnkEkJw9T6sS368D4pUs0D7MUtIRNEh9ZTH+c4nXOgR5RXILZ D6rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719004158; x=1719608958; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mFF+tZLqt/oYIwwTnkvFnb0bcxITH6vN1nuKwvweNls=; b=QKmbkqQWTXSr50Q9rgzPrlpmSAulAQUUWJtAyrzB2KHcIvTz414bL/w8+X5BTWclXG SPhD50JLawFOPpDILS/w+mpgtdhb+gTsIGE3fhqcKShVr2L1BPdYXu7yhXtXdFCAiswi NutOLxsoURh+bDOZwi4vFcUJIrMg3eYQvhE5SEcJ6U9vTQlMidh42ZTGfUpQvyqrms3N KXPJhYnQcuoFXUO9LQHo0A/SVMNg9pc6DCfN/c7fX3KEfdq0JrLvO6kACQdWCyiMhCKG CLGKZ+t8G8YqRtjBGuRlG9tDxTorRDFCh3zawTgTkGFKOC3crGqiYnH/HDGFyhsyuzot PU/A== X-Gm-Message-State: AOJu0Yw3U4wPtjPblV106BcrtdqfjZelC8z9Q9bhSn9H7BiOdqhRkc5v f5pQgjj+HTeld6huTmpLx4htlzglSpTLksej0s0KPfTvvOcWFps63zWJrf7QPKDqTZNkEoAH0uG 7F+ggqq1GklTEE5Vy4FBq0mq/leg= X-Google-Smtp-Source: AGHT+IFDo3mryK7NkCofIibRLVyLLXvx8sRYLJOWoTDp35vR+5vkrTSs/BaZT+s/sPjeg+tGqwnE8gUzHEqjEhRfAcU= X-Received: by 2002:a05:600c:1d08:b0:422:4fcd:d4b3 with SMTP id 5b1f17b1804b1-4247529f03cmr69097595e9.37.1719004158423; Fri, 21 Jun 2024 14:09:18 -0700 (PDT) MIME-Version: 1.0 References: <87msneqeyn.fsf@gmx.de> In-Reply-To: <87msneqeyn.fsf@gmx.de> From: Iurie Marian Date: Fri, 21 Jun 2024 23:09:07 +0200 Message-ID: Subject: Re: bug#71709: Fix recent change in tramp-sh-handle-make-process To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71709 X-Mailman-Approved-At: Sat, 22 Jun 2024 03:10:57 -0400 Cc: 71709@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Michael, Yes, you are right, of course :) Okay, I didn't notice that `stderr' is extracted earlier. ----- After updating emacs today I got strange errors while running consult-find in a remote container, for example: ``` /usr/bin/cat: /tmp/tramp.gBbQP1: No such file or directory /usr/bin/cat: /tmp/tramp.SWKx2Y: No such file or directory ``` I checked the consult-find (which also points out to a "tramp bug"), then I checked the tramp's latest changes and applied that one-line from the patch, which fixed my issue. (In fact that line `(stderr (plist-get args :stderr))' actually nullifies the `stderr', so probably that's why it worked and I had a feeling that it is a solution) Please see below: * consult-find: https://github.com/minad/consult/blob/main/consult.el#L4965 * consult--async-process: https://github.com/minad/consult/blob/main/consult.el#L2287C1-L2296C69 I guess, to reproduce the issue, it's enough to invoke `make-process' on a remote location and with a non-nil `:stderr' argument (a buffer in `consult-find''s case). Kind Regards, Iurie On Fri, 21 Jun 2024 at 21:21, Michael Albinus wrote: > > Iurie Marian writes: > > Hi, > > > tramp-sh-handle-make-process is failing when `:stderr' argument is > > used. > > > > In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > > 3.24.41, cairo version 1.18.0) of 2024-06-21 built on rrouwprlc0222 > > Repository revision: e7123edfe7f7abc9043429dfb3f84941f83d6565 > > Repository branch: master > > System Description: Ubuntu 24.04 LTS > > > > diff --git a/lisp/net/tramp-sh.el b/lisp/net/tramp-sh.el > > index bce7c323dad..68018298b68 100644 > > --- a/lisp/net/tramp-sh.el > > +++ b/lisp/net/tramp-sh.el > > @@ -2969,6 +2969,7 @@ tramp-sh-handle-make-process > > (let* ((program (car command)) > > (args (cdr command)) > > ;; STDERR can also be a file name. > > + (stderr (plist-get args :stderr)) > > (tmpstderr > > (and stderr > > (tramp-unquote-file-local-name > > Why that? stderr is extracted from args in tramp-skeleton-make-process. > > Do you get an error which shows the problem? > > Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 03:31:34 2024 Received: (at 71709) by debbugs.gnu.org; 22 Jun 2024 07:31:35 +0000 Received: from localhost ([127.0.0.1]:44214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKvDi-0006Md-K9 for submit@debbugs.gnu.org; Sat, 22 Jun 2024 03:31:34 -0400 Received: from mout.gmx.net ([212.227.15.18]:60375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKvDe-0006MA-3j for 71709@debbugs.gnu.org; Sat, 22 Jun 2024 03:31:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1719041484; x=1719646284; i=michael.albinus@gmx.de; bh=qrsa6dx6nYBoeKZ1jZCkqOyUeFIOJzUCadX/jjTtYQ8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=fhplKcIalU1i12PLQ4fDGWb2f2sl0iqDHc0ogyyMgXg4gSqJJ+bAVykfJJD+/i5k 14nVzCKrL1LrcJ/kb5hqAHP6PGCSYkr+VMWMofvkUYi8DslP8Zr68i486BlKiu0LN KSL2QgQ0Cf6HIKnn+xTWWP74DSQ1M/fUAoj6GrQju3sU+tvEOHDTpk1aNkPKM3ma/ ps9yCFFUXEbSAsfIpCPuHYgsn1rysi6tWzNZ4p7vt4z9CzPuUjOP5ETqqb1lfxJnR MqEbBEvAuEBwyee+kAOUEErPYHFe/niOyNbBAcN2P7ESKtlxD9adaTxMtgnH0/mSu datO8MfVbCi/gRXfSw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N7QxL-1sQhPC3pLp-00sxr3; Sat, 22 Jun 2024 09:31:24 +0200 From: Michael Albinus To: Iurie Marian Subject: Re: bug#71709: Fix recent change in tramp-sh-handle-make-process In-Reply-To: (Iurie Marian's message of "Fri, 21 Jun 2024 23:09:07 +0200") References: <87msneqeyn.fsf@gmx.de> Date: Sat, 22 Jun 2024 09:31:21 +0200 Message-ID: <87iky1qvqu.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:cBnRe/yv8F+kQI2xwg0bW2xd/p/CB+X8t6WmFM2Kxg6xBi7gcKl 0GMtqU22/S43NRF9D5ZImn101caCiaFP/4Z3sr7xUqT3l8RDYRWqgY3JdM8UxQA+CuyRX7K g3G1rgVEScQMsGuLSKCjPM7X4uXvh7x0XL6+kFTAS4huTrUDKTfWyVP3ZtoAPzD9jEvjzMa Jp4xAfav7BB+daBkfkpxw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ZqzjX/I9MVg=;ENqlgLHWBmk8+fk6V43UWzdMB/X 2WY1Z2PE5qE74huIn6qVrX8Ls4M/+DnM60MnawHLsBdVz87TpMWDhEXePdRWWyfzguR86p5k0 bxaZJU9cg6AljAzAx/6I+66fV6M7R64FDimUYnYv6QHFZcWAZZcXp6O3In8zNW9UWyU6RKjZo eKIBi9OVb1WMAL2YTZm6/rbeCNT98+gnI9zUvPkTJQp+GxnbBdkHDbt8JT2dXsBEP6Eor3My2 6monePqwWaURiwX0AImYqcl7g0MKMMKjfq6xclSynbsYpa7HmWH1M7tQB6eBD43AjkKln7XRZ I2yQ/jjmtVQUKcv+Z0U7j3TCM4KRoX+c7ncDird1Tk1dkRPDANNgdGhTQ6qc6m6pN6KEUjtdb X+roookVBBE+qW2BPhuQC7aaF0uoOU5dOC3Nz1cOBxL0jW08cnlocv2BV2qme7+vWpfw1WGbH O104uQbmMuhKr2DlbAn3zLANEclQITVY2rO//Zz+JsugfmImGlkosirvG7tqOwWuILy1xOxtP VMj0WGxagzPbm72Ece1u8jODahdZ0MMKL+zmqAivlM+GOEMdG1ta7GZMVDmnWth/EMF/vnTJR McB6hkegRAGAIkWqHy9ta2hlDm5aI5VYDUnrhv0DydM2KheTl+SVqRJ1v9DfAnCuPC3IeIuR5 z+Qzzq/L4+Oko+rUBKaH/cqXOjr/ZLLGX4J+UH6Y3psXkUEHFHDwf6QOXVbBJJ50fD8DW8j1b 3NTR1/sJLaqc4DuXN+MsGuzl+62DYOoQY/b4JJSMGhDvCKur598w4ESfB2XRnr1iuN6WeoM6c +RQXS2BcFX3E15yQeBpIgOSpQnRzXmwS2zFcU0v2VHrbQ= X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Iurie Marian writes: > Hello Michael, Hi Iurie, Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.155 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.18 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.18 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 71709 Cc: 71709@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Iurie Marian writes: > Hello Michael, Hi Iurie, Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.155 listed in zen.spamhaus.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.18 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.18 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Iurie Marian writes: > Hello Michael, Hi Iurie, > After updating emacs today I got strange errors while running > consult-find in a remote container, for example: > ``` > /usr/bin/cat: /tmp/tramp.gBbQP1: No such file or directory > /usr/bin/cat: /tmp/tramp.SWKx2Y: No such file or directory > ``` > > I checked the consult-find (which also points out to a "tramp bug"), > then I checked the tramp's latest changes and applied that one-line > from the patch, which fixed my issue. > (In fact that line `(stderr (plist-get args :stderr))' actually > nullifies the `stderr', so probably that's why it worked and I had a > feeling that it is a solution) > > Please see below: > * consult-find: https://github.com/minad/consult/blob/main/consult.el#L4965 > * consult--async-process: > https://github.com/minad/consult/blob/main/consult.el#L2287C1-L2296C69 Sorry, I don't use consult, and I don't know its code. If we want to hunt a Tramp bug, we should run a use case with vanilla Emacs, invoking Tramp's remote make-process. > I guess, to reproduce the issue, it's enough to invoke `make-process' > on a remote location and with a non-nil `:stderr' argument (a buffer > in `consult-find''s case). Tramp has a very comprehensive test library, see .../test/lisp/net/tramp-tests.el The test case tramp-test30-make-process runs extensive tests over make-process, including a non-empty stderr. And of course, I always run the whole testsuite before I commit serious Tramp changes. So pls show a recipe how to reproduce the problem, starting with 'emacs -Q'. And pls contact the consult author(s); they might report a Tramp problem when they detect such. > Kind Regards, > Iurie Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 07:13:14 2024 Received: (at 71709) by debbugs.gnu.org; 22 Jun 2024 11:13:14 +0000 Received: from localhost ([127.0.0.1]:44565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKygD-00048S-MB for submit@debbugs.gnu.org; Sat, 22 Jun 2024 07:13:14 -0400 Received: from mail-lj1-f172.google.com ([209.85.208.172]:46472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKwmS-0000si-8z for 71709@debbugs.gnu.org; Sat, 22 Jun 2024 05:11:34 -0400 Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2ebeefb9a6eso27305781fa.1 for <71709@debbugs.gnu.org>; Sat, 22 Jun 2024 02:11:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719047426; x=1719652226; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HZbJpgMKkA2UNwbCs3cbfEUqfpMFkoW7nEdKo5F6TkM=; b=Po4S5ecerKjaNawaO3wwts+DEVoCseA3WIiy9DDTabuopqQ4QkOaRWArLLE4vrdA6Y 7oVVsajZGmfyWRajMsooiXppZU9trhr9SiA/MKNXR8Xzq0soJWkv2I5wy4bHHYrlSVFE dOWvYACSQL8Zlqgj1wwU2FzElFfZ/HWZxn6eJO/v8JShc5rFgL4T0nEzS+0rCx092OXR t3bbML7kO2Hiv4It0jAQ/LxXG5Ly2dJg17oTcFMDD5w4IcwRQd+DbEpDdf/D1Nm3u8vo kpr4iiopN3gDids3Roz1qnMHBXaRehUjWABv7lktOW41l+zKx3p37MvfIpo6aXrQR6oO qH7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719047426; x=1719652226; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HZbJpgMKkA2UNwbCs3cbfEUqfpMFkoW7nEdKo5F6TkM=; b=jaIHOZyyI+7xFUkH0DHuME9v7XFgtxhJpzzCO9B9I166pr4HBLTRCtplVRCEta/Bn8 qeaynj1FzpvWY+SZf77c2/QG16bb1SJccoeSclTD3mw+MFIdJeDYLMgMEAQERAijg1EM GW2es0bHLFjTG9jD4ifnhX6Hz0Z7pyF+0SwwU2LxLKAyu/62Uh0dOWn9OFYkqXlFQ06Z dVAvFNMLLfYi9A7j/4l/tJaPOICWlFOYY+p/3tvwIrTwpLy4LHQzbny6Fc3olSXDLxuy HTnxFcXyZ6ApVRVdkPj/vqqzs5EPkQwPGKb+jnYsqwUNJBHsXR+ltJQhVYdVRmJ4+sd1 auqw== X-Gm-Message-State: AOJu0Yzi8T6Bc+YYQ+JoNZX1IQCFz3Sjyg5Af8bA4+KMGmNm+cmI4hGI sg+nqGiQDrcslVYB17Wna1ETqtgiHR4gb2dSWe3ooDnBK3zsaXICkfW7/aRqfHsynsMZ2EXANSd RxMNkbKXGNBkvDJzFmcA6yoFvTTI= X-Google-Smtp-Source: AGHT+IEtFh5dosQyLnXoA6W8OWsRvje+kOlHVKmiZSzWul4gSxyhQwBTQmyb0+ibl1JjA5TCQ6wWJCvmpoDmZ749C1c= X-Received: by 2002:ac2:4471:0:b0:52c:86eb:a2e6 with SMTP id 2adb3069b0e04-52ce063d744mr33007e87.4.1719047426252; Sat, 22 Jun 2024 02:10:26 -0700 (PDT) MIME-Version: 1.0 References: <87msneqeyn.fsf@gmx.de> <87iky1qvqu.fsf@gmx.de> In-Reply-To: <87iky1qvqu.fsf@gmx.de> From: Iurie Marian Date: Sat, 22 Jun 2024 11:10:15 +0200 Message-ID: Subject: Re: bug#71709: Fix recent change in tramp-sh-handle-make-process To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71709 X-Mailman-Approved-At: Sat, 22 Jun 2024 07:13:09 -0400 Cc: 71709@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Michael, Could you please try the below snippet? Evaluate it in a local and _remote_ buffer. ``` ;; -*- lexical-binding: t; -*- (let ((.test-buffer (get-buffer-create "*test buffer*")) (.remote? (file-remote-p default-directory))) (with-current-buffer .test-buffer (goto-char (max-char)) (insert "====================\n") (insert (if .remote? "Remote:\n" "Local :\n"))) (make-process :file-handler t :connection-type 'pipe :name "test proc" :stderr .test-buffer :noquery t :command (list "echo" "Hello!") :filter (lambda (proc str) (with-current-buffer .test-buffer (goto-char (max-char)) (insert "test proc output: " str))))) ``` I get the below output: ``` ==================== Local : Process test proc stderr finished test proc output: Hello! ==================== Remote: /usr/bin/cat: /tmp/tramp.J0RZDc: No such file or directory ``` I would expect "Hello!" output from _remote_ as well. Isn't it? It seems that the process is not executed and the output "/usr/bin/cat: /tmp/tramp.J0RZDc: No such file or directory" is from stderr. Kind Regards, Iurie On Sat, 22 Jun 2024 at 09:31, Michael Albinus wrote: > > Iurie Marian writes: > > > Hello Michael, > > Hi Iurie, > > > After updating emacs today I got strange errors while running > > consult-find in a remote container, for example: > > ``` > > /usr/bin/cat: /tmp/tramp.gBbQP1: No such file or directory > > /usr/bin/cat: /tmp/tramp.SWKx2Y: No such file or directory > > ``` > > > > I checked the consult-find (which also points out to a "tramp bug"), > > then I checked the tramp's latest changes and applied that one-line > > from the patch, which fixed my issue. > > (In fact that line `(stderr (plist-get args :stderr))' actually > > nullifies the `stderr', so probably that's why it worked and I had a > > feeling that it is a solution) > > > > Please see below: > > * consult-find: https://github.com/minad/consult/blob/main/consult.el#L4965 > > * consult--async-process: > > https://github.com/minad/consult/blob/main/consult.el#L2287C1-L2296C69 > > Sorry, I don't use consult, and I don't know its code. If we want to > hunt a Tramp bug, we should run a use case with vanilla Emacs, invoking > Tramp's remote make-process. > > > I guess, to reproduce the issue, it's enough to invoke `make-process' > > on a remote location and with a non-nil `:stderr' argument (a buffer > > in `consult-find''s case). > > Tramp has a very comprehensive test library, see .../test/lisp/net/tramp-tests.el > The test case tramp-test30-make-process runs extensive tests over > make-process, including a non-empty stderr. And of course, I always run > the whole testsuite before I commit serious Tramp changes. > > So pls show a recipe how to reproduce the problem, starting with 'emacs > -Q'. And pls contact the consult author(s); they might report a Tramp > problem when they detect such. > > > Kind Regards, > > Iurie > > Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 07:13:14 2024 Received: (at 71709) by debbugs.gnu.org; 22 Jun 2024 11:13:15 +0000 Received: from localhost ([127.0.0.1]:44567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKygE-00048Z-CO for submit@debbugs.gnu.org; Sat, 22 Jun 2024 07:13:14 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:56546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKwuC-00016l-Mp for 71709@debbugs.gnu.org; Sat, 22 Jun 2024 05:19:33 -0400 Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-364a3d5d901so1999836f8f.0 for <71709@debbugs.gnu.org>; Sat, 22 Jun 2024 02:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719047907; x=1719652707; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QfE42POmn4ewc6oeh6W0GLzxZBiIpjQvBmuL00thMMg=; b=Z/tY7ksnLyLSFppP4XSDR/BbN+ikDrCS9RQsEhILpvJEjhp2tcX2ze3DTs3paKmXha eHOj/9Qlp6CVFWWIF1JADZi/gzxajl9vIzDqlcTS0HEeTAueZa+LMtmZCeIndnR5eM6L U0b7mktOsxuwVH2PIPOVC73aDNNwxyh8fCZXYw8vQ2ek7CsAUDJKWBFl65dVQNM5IbYj bP4hmqcpFGg01h82kB7u0hXHuoclnvkUIkdE40akFM8sgskZOyVbgj2AEPhcoZAArtF3 DE/taNSmkXfftAkUhkHV4NVHUkjP6aZkCDyeP95wm5hmgh/zix58cGqCAE5i6ESz+sqG xfvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719047907; x=1719652707; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QfE42POmn4ewc6oeh6W0GLzxZBiIpjQvBmuL00thMMg=; b=H3sj9GCeiv4ioKnTRU6Fozcs0PANmFlOXFJbbXKsiQGzMSSWqV9VLMisrwEK0NdFCU RzhDdiTr/VSae86yGpGFefoyKuBY1SlzXjXIOg55XkBu6ZmQkbUS0Sd4BcdmnF6tUAQ9 kZ/F3NV5FSPA83YR1x7NXVYzarbWfnat1/kzXyeU6Ntm1bEadMAcf5Q2NgIrKcbuEp3F W6gJoVV8DUyZrHDep90l/dmtfP3OU9F12+ArbkYORfyFhrJMKXbFiVPL8mfHQXBRqIfv HI4ujL38i+goJkEEKfPQmJEgU0i1h3mbU+jZeOnnvwyMDvhKCPQM3cCbCC1x5+T74Z+D ksUA== X-Gm-Message-State: AOJu0YwdmepNR6Qu1WlF7aaJyjSQ/Az3GIKjJzWIQrqEmRWZ2a+k2h7l MJpit34KtRhC/udRwa5kp7oyQDkpNLQXX1QGOum2h+7EEPG3lQHK8dDr3s8aQuvk/tlwEVLQeeU aNALg+4bc4Nh5z0WDRxTp1GJa+JhmbGbA95U= X-Google-Smtp-Source: AGHT+IGVQM/N1QQjbwnJN2jXgJfwZraxgyfaVQDQFHA7uhKDwd/H6qrJCX8jpatge7t+bYswQxJ+XdQykSDslMLJrNU= X-Received: by 2002:a5d:6152:0:b0:360:81a1:5b63 with SMTP id ffacd0b85a97d-363170eca61mr7709147f8f.13.1719047906926; Sat, 22 Jun 2024 02:18:26 -0700 (PDT) MIME-Version: 1.0 References: <87msneqeyn.fsf@gmx.de> <87iky1qvqu.fsf@gmx.de> In-Reply-To: From: Iurie Marian Date: Sat, 22 Jun 2024 11:18:16 +0200 Message-ID: Subject: Re: bug#71709: Fix recent change in tramp-sh-handle-make-process To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71709 X-Mailman-Approved-At: Sat, 22 Jun 2024 07:13:09 -0400 Cc: 71709@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Might it be related to the ~:connection-type 'pipe~? If I remove it I get the expected results. Many thanks Iurie On Sat, 22 Jun 2024 at 11:10, Iurie Marian wrote: > > Hello Michael, > > Could you please try the below snippet? > Evaluate it in a local and _remote_ buffer. > ``` > ;; -*- lexical-binding: t; -*- > > (let ((.test-buffer (get-buffer-create "*test buffer*")) > (.remote? (file-remote-p default-directory))) > (with-current-buffer .test-buffer > (goto-char (max-char)) > (insert "====================\n") > (insert (if .remote? "Remote:\n" "Local :\n"))) > > (make-process :file-handler t > :connection-type 'pipe > :name "test proc" > :stderr .test-buffer > :noquery t > :command (list "echo" "Hello!") > :filter (lambda (proc str) > (with-current-buffer .test-buffer > (goto-char (max-char)) > (insert "test proc output: " str))))) > ``` > > I get the below output: > ``` > ==================== > Local : > > Process test proc stderr finished > test proc output: Hello! > ==================== > Remote: > /usr/bin/cat: /tmp/tramp.J0RZDc: No such file or directory > ``` > > I would expect "Hello!" output from _remote_ as well. Isn't it? > It seems that the process is not executed and the output > "/usr/bin/cat: /tmp/tramp.J0RZDc: No such file or directory" is from > stderr. > > Kind Regards, > Iurie > > > On Sat, 22 Jun 2024 at 09:31, Michael Albinus wrote: > > > > Iurie Marian writes: > > > > > Hello Michael, > > > > Hi Iurie, > > > > > After updating emacs today I got strange errors while running > > > consult-find in a remote container, for example: > > > ``` > > > /usr/bin/cat: /tmp/tramp.gBbQP1: No such file or directory > > > /usr/bin/cat: /tmp/tramp.SWKx2Y: No such file or directory > > > ``` > > > > > > I checked the consult-find (which also points out to a "tramp bug"), > > > then I checked the tramp's latest changes and applied that one-line > > > from the patch, which fixed my issue. > > > (In fact that line `(stderr (plist-get args :stderr))' actually > > > nullifies the `stderr', so probably that's why it worked and I had a > > > feeling that it is a solution) > > > > > > Please see below: > > > * consult-find: https://github.com/minad/consult/blob/main/consult.el#L4965 > > > * consult--async-process: > > > https://github.com/minad/consult/blob/main/consult.el#L2287C1-L2296C69 > > > > Sorry, I don't use consult, and I don't know its code. If we want to > > hunt a Tramp bug, we should run a use case with vanilla Emacs, invoking > > Tramp's remote make-process. > > > > > I guess, to reproduce the issue, it's enough to invoke `make-process' > > > on a remote location and with a non-nil `:stderr' argument (a buffer > > > in `consult-find''s case). > > > > Tramp has a very comprehensive test library, see .../test/lisp/net/tramp-tests.el > > The test case tramp-test30-make-process runs extensive tests over > > make-process, including a non-empty stderr. And of course, I always run > > the whole testsuite before I commit serious Tramp changes. > > > > So pls show a recipe how to reproduce the problem, starting with 'emacs > > -Q'. And pls contact the consult author(s); they might report a Tramp > > problem when they detect such. > > > > > Kind Regards, > > > Iurie > > > > Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 07:13:15 2024 Received: (at 71709) by debbugs.gnu.org; 22 Jun 2024 11:13:15 +0000 Received: from localhost ([127.0.0.1]:44569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKygE-00048h-SE for submit@debbugs.gnu.org; Sat, 22 Jun 2024 07:13:15 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:42196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKwzG-0001F4-Ea for 71709@debbugs.gnu.org; Sat, 22 Jun 2024 05:24:47 -0400 Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3632a6437d7so1606530f8f.0 for <71709@debbugs.gnu.org>; Sat, 22 Jun 2024 02:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719048221; x=1719653021; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NZzq6zsHImX2hPa1WTeYgPEDFfv23yviohcppsHlrDM=; b=OEGMJJBPbhYLJktQupEuD7W8cys6x5KQB/BU/zHuKhqvkLylvKJ0QaBGFyc18S7fL+ EBjx/yu0Va47OQR6sYDu9mgngBpB+qHU8gltMeEVk5stE/YM2XbKZbRxwwWFULJ8PHjh Y47287mFsR+FSTsePzQk4sMLX6r3pVaRFryhjShIV+NUKkx7XredxxIKzGZpKoMz7amk 9kp2umryPTS9HqDLEw79lFEMjYAgxDzcL8G338fi1Cia6Wdf1VzckkFTo53apmeUlVWa kTjWhY6As18J25z9oBmXwG4saGbFL/ldMRm1IGI3i6V8iwh60+6ynzlhqRkOj+Mc2Lp6 GCMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719048221; x=1719653021; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NZzq6zsHImX2hPa1WTeYgPEDFfv23yviohcppsHlrDM=; b=wIBOFVB+uPwcB1AH21O/VtMXN5IXmHInry9dfbLRqAIgXjqDsaayGIaZMPkTntAGc7 6+hns7/DyMn4AeIH6u3x4My6Yo+gc1MTEHCOJP3Gzp17/KKSms2JUafEXOXei4au9tHU ogFwCuT4OQr5yJGWQlYAv5tVQ/k8vmww83SwKaPq/sAdATiIdPo2nbXMJkAe7btjIzCx RJ2tKcb6BjRd7UDl3XVcoq8B3qxNpq0vyzXM/IfiZL17s4q333CFLm/UJw6yNY0RLdu/ r0J900RU0yJYjiUn7itzW4eRDL7J/l0J3ze5CKQzuAdSnrGkBO2aIf5voB2b7AhZlSR5 4z+w== X-Gm-Message-State: AOJu0YyN4E/rwoil1zQRwEqsxzy/NDzdmConXC/ulBc1svvSeU2gjRw4 Y0sR0O3MwcGgDgJIexuWDvWDqgiLWxxmhmeK41ba/KRWEVmA6I0vAol/W/WolXJAy6pRdA66XLH s6N4kE9t2swagZSpBvQa0434uoj/8R/kA90Q= X-Google-Smtp-Source: AGHT+IFF6P3tQni6rWHeSyFdEtAovmeyd1+Z3ZedhbDgKt4C2Df/yfxi85eDpdP80lPDDufmA/p//YrdNqObxSXeqSA= X-Received: by 2002:a5d:68c6:0:b0:362:26d:613 with SMTP id ffacd0b85a97d-366e3266613mr752128f8f.8.1719048220839; Sat, 22 Jun 2024 02:23:40 -0700 (PDT) MIME-Version: 1.0 References: <87msneqeyn.fsf@gmx.de> <87iky1qvqu.fsf@gmx.de> In-Reply-To: From: Iurie Marian Date: Sat, 22 Jun 2024 11:23:30 +0200 Message-ID: Subject: Re: bug#71709: Fix recent change in tramp-sh-handle-make-process To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71709 X-Mailman-Approved-At: Sat, 22 Jun 2024 07:13:10 -0400 Cc: 71709@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sorry, it's the ~:file-handler t~, not the connection-type. Thanks Iurie On Sat, 22 Jun 2024 at 11:18, Iurie Marian wrote: > > Might it be related to the ~:connection-type 'pipe~? > If I remove it I get the expected results. > > Many thanks > Iurie > > On Sat, 22 Jun 2024 at 11:10, Iurie Marian wrote: > > > > Hello Michael, > > > > Could you please try the below snippet? > > Evaluate it in a local and _remote_ buffer. > > ``` > > ;; -*- lexical-binding: t; -*- > > > > (let ((.test-buffer (get-buffer-create "*test buffer*")) > > (.remote? (file-remote-p default-directory))) > > (with-current-buffer .test-buffer > > (goto-char (max-char)) > > (insert "====================\n") > > (insert (if .remote? "Remote:\n" "Local :\n"))) > > > > (make-process :file-handler t > > :connection-type 'pipe > > :name "test proc" > > :stderr .test-buffer > > :noquery t > > :command (list "echo" "Hello!") > > :filter (lambda (proc str) > > (with-current-buffer .test-buffer > > (goto-char (max-char)) > > (insert "test proc output: " str))))) > > ``` > > > > I get the below output: > > ``` > > ==================== > > Local : > > > > Process test proc stderr finished > > test proc output: Hello! > > ==================== > > Remote: > > /usr/bin/cat: /tmp/tramp.J0RZDc: No such file or directory > > ``` > > > > I would expect "Hello!" output from _remote_ as well. Isn't it? > > It seems that the process is not executed and the output > > "/usr/bin/cat: /tmp/tramp.J0RZDc: No such file or directory" is from > > stderr. > > > > Kind Regards, > > Iurie > > > > > > On Sat, 22 Jun 2024 at 09:31, Michael Albinus wrote: > > > > > > Iurie Marian writes: > > > > > > > Hello Michael, > > > > > > Hi Iurie, > > > > > > > After updating emacs today I got strange errors while running > > > > consult-find in a remote container, for example: > > > > ``` > > > > /usr/bin/cat: /tmp/tramp.gBbQP1: No such file or directory > > > > /usr/bin/cat: /tmp/tramp.SWKx2Y: No such file or directory > > > > ``` > > > > > > > > I checked the consult-find (which also points out to a "tramp bug"), > > > > then I checked the tramp's latest changes and applied that one-line > > > > from the patch, which fixed my issue. > > > > (In fact that line `(stderr (plist-get args :stderr))' actually > > > > nullifies the `stderr', so probably that's why it worked and I had a > > > > feeling that it is a solution) > > > > > > > > Please see below: > > > > * consult-find: https://github.com/minad/consult/blob/main/consult.el#L4965 > > > > * consult--async-process: > > > > https://github.com/minad/consult/blob/main/consult.el#L2287C1-L2296C69 > > > > > > Sorry, I don't use consult, and I don't know its code. If we want to > > > hunt a Tramp bug, we should run a use case with vanilla Emacs, invoking > > > Tramp's remote make-process. > > > > > > > I guess, to reproduce the issue, it's enough to invoke `make-process' > > > > on a remote location and with a non-nil `:stderr' argument (a buffer > > > > in `consult-find''s case). > > > > > > Tramp has a very comprehensive test library, see .../test/lisp/net/tramp-tests.el > > > The test case tramp-test30-make-process runs extensive tests over > > > make-process, including a non-empty stderr. And of course, I always run > > > the whole testsuite before I commit serious Tramp changes. > > > > > > So pls show a recipe how to reproduce the problem, starting with 'emacs > > > -Q'. And pls contact the consult author(s); they might report a Tramp > > > problem when they detect such. > > > > > > > Kind Regards, > > > > Iurie > > > > > > Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 07:18:15 2024 Received: (at 71709) by debbugs.gnu.org; 22 Jun 2024 11:18:15 +0000 Received: from localhost ([127.0.0.1]:44581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKyl4-0004Ib-Tz for submit@debbugs.gnu.org; Sat, 22 Jun 2024 07:18:15 -0400 Received: from mout.gmx.net ([212.227.15.19]:51683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKyl2-0004IL-JP for 71709@debbugs.gnu.org; Sat, 22 Jun 2024 07:18:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1719055086; x=1719659886; i=michael.albinus@gmx.de; bh=XH5GtLbpRj9BZF94xMO8J2nY9HOUupSFSGlYr9XXISA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=oy3CRVK2vIaj0nVMHZfZGKS9QiBSj0MmLRJgXbJR+ITqAPmyv6+T1z3aGDup07nv +yBXTyLw9Fpqw6sv7EBi6HHtYM7Givd+cERRAYBfMvy3olDf16GZgiKkVYNuNN9fj vklzfuCO3lcwObhMZTfSt9+Nz3SPSeWX8zYXKUFs3J5+Y8flKH31KX3Aa1aeVXTfd UvKvFpw/Ybsq8X9ayCkmipoTwMiI4dAv5EetgTSXnKOnuhFC9uN4ev5uA9togs/oB /4g893tmYbnHSSPfnzDryU45rCPwbp64L7PPFGIBydok+CBTwlrNfg56nrUEF6Br/ jA/Is5sIODcoi6etaw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MuDXz-1sdtgJ0nKn-016974; Sat, 22 Jun 2024 13:18:06 +0200 From: Michael Albinus To: Iurie Marian Subject: Re: bug#71709: Fix recent change in tramp-sh-handle-make-process In-Reply-To: (Iurie Marian's message of "Sat, 22 Jun 2024 11:10:15 +0200") References: <87msneqeyn.fsf@gmx.de> <87iky1qvqu.fsf@gmx.de> Date: Sat, 22 Jun 2024 13:18:05 +0200 Message-ID: <877cehql8y.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:/50qtoj7eyh8ozGWiIHFaeJKlmK6YyKf/9YE6zRMvGF1TBABcOc NTBRWK/TIQJwGYlfomSXBrBwuQ9abq2gw/9jeXyiHA0cJw6w+XbHrmVxH15Vwa+jPZwP7lY fneE0fd1W31N3YxlWpcKDsJ7jCuHdhQB8jWwpgJdfyb72RARnR53kRmwDIp93mWDuJ2+CWl 7DtSJBBGoPTJb75LuGXBA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:bA05j6Rb+hY=;SNAQ+kk2Uxg+l+k5NyqRrtkDZMV uFraX812ydqeazQuJ4uPM81bKexwq/t87h6bSAL/byaxsW0THeCkML+4sz6XUnS3GSlYpJW+R I4loVpU/zdMMbeZtMZx1VR1u0m7NHdVjfdEwWqZ+c1GMmVys93GqASjphuKORo1sRRx0bU1Ac ZjbEvboOEQQrB2d2zCbTw+a5WzZb0r+Rn5IbG7p4ZB0ghMoA1rIoGEiQNnX79NCXCMnOI8m40 oGEceCuxHqbRfdKUEnMFxgY3CRvH2XmU+ThPD9ejL1Vydcugbxyxl/JFyB8VxP5HnwJV7XmNR i2MbooKKP3DZljMuvlDkLLcFToXVoBqagLL9HcCjVPWiJNWyye5hHOGlUP+1YcV7dvgBXG1qw tszBrsCCUVmc97iwJmiSZm5TduxZgruAoNfqKpvLWOSJeE5v4UvLgBqdJYnyQQ/u8bhdDtRrM Ux1j1w3s9B4ZrPNw78vBV5/tCzTxFHh56ehrbkw1nxWtyWs8uglU0eB3iMfXHzOCTQ+Hgve7g 3S1R6fjs3Sa8144BQil2D+wbFU8RfPKaSEFhcg/lMsnb+zYDK1GKZ8CobCXywAjQ30ZiopizQ hOXKJGp7asZY8OKmyLRfvoDB/n+B+TaFwqp2nDlRBP8RaEpTaynZf3ANasrw6Etl7EOCoW8N/ fZ+fKYMz38sjaMTqV+rCkDbdhYjykR2/Yd8+gXcZXGt2/GVtPfvZ5m065qGfybYSWXFfvv7P9 LBv029tHQ9xAZ8Oi7FZn73q8/JQNdZJUbOkTLHPyo4ZQ32engwsQlmzyx6upnYdOVhY6bS1z7 /WzhpizNL23l+MutNfzWy2PBuOFNySNqfMaom0rA/0sNo= X-Spam-Score: 2.8 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Iurie Marian writes: > Hello Michael, Hi Iurie, Content analysis details: (2.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.155 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.19 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.15.19 listed in wl.mailspike.net] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 71709 Cc: 71709@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Iurie Marian writes: > Hello Michael, Hi Iurie, Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.155 listed in zen.spamhaus.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.15.19 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.19 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Iurie Marian writes: > Hello Michael, Hi Iurie, > Could you please try the below snippet? > Evaluate it in a local and _remote_ buffer. > ``` > ;; -*- lexical-binding: t; -*- > > (let ((.test-buffer (get-buffer-create "*test buffer*")) > (.remote? (file-remote-p default-directory))) > (with-current-buffer .test-buffer > (goto-char (max-char)) > (insert "====================\n") > (insert (if .remote? "Remote:\n" "Local :\n"))) > > (make-process :file-handler t > :connection-type 'pipe > :name "test proc" > :stderr .test-buffer > :noquery t > :command (list "echo" "Hello!") > :filter (lambda (proc str) > (with-current-buffer .test-buffer > (goto-char (max-char)) > (insert "test proc output: " str))))) > ``` > > I get the below output: > ``` > ==================== > Local : > > Process test proc stderr finished > test proc output: Hello! > ==================== > Remote: > /usr/bin/cat: /tmp/tramp.J0RZDc: No such file or directory > ``` > > I would expect "Hello!" output from _remote_ as well. Isn't it? > It seems that the process is not executed and the output > "/usr/bin/cat: /tmp/tramp.J0RZDc: No such file or directory" is from > stderr. Thanks for the recipe. I've played with it. Most cases, it works as expected, but sometimes I see a similar error. Looks like a race condition. I'll debug further. > Kind Regards, > Iurie Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 08:02:51 2024 Received: (at 71709) by debbugs.gnu.org; 22 Jun 2024 12:02:51 +0000 Received: from localhost ([127.0.0.1]:44637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKzSF-0008Io-Fi for submit@debbugs.gnu.org; Sat, 22 Jun 2024 08:02:51 -0400 Received: from mout.gmx.net ([212.227.17.21]:53567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKzSD-0008IZ-MC for 71709@debbugs.gnu.org; Sat, 22 Jun 2024 08:02:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1719057763; x=1719662563; i=michael.albinus@gmx.de; bh=Z23FLuWvZ3G1dgT02aXMNmqS8qNY0OBTo2v1gDMiSe0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=UOCDMCvxx4+KIDRs1m2fVWh7wX+awwaCpZz7V8RYLyFesD9DQeon+UZMCOD+T8Dq g1bTFMrhg6v0qAaW5RlCeb5mJBV70X+JvSLjyknqVVvZY0805DX4qy2xlKwgQJtFB T8LJpSSFdwZeb+hBKuklMczOjjcaG2aFv9ei7xMal0fEA71GNvZJF7pOPIh51EcDR IgGoBzymQRWeOh7MvFwTElqle2NtEuiYHHunIV2qGwKUS+qSWps4HlWiRP4fQXS9n J1KIBvCi4y6QH6z4rj116qkM9PlfsyjlC708V+FurjFqRiAptbDkuliE2CBrwyYbe kdS55TY39qtUITj6yg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M2wKq-1sM4qt12Oy-00Dth1; Sat, 22 Jun 2024 14:02:43 +0200 From: Michael Albinus To: Iurie Marian Subject: Re: bug#71709: Fix recent change in tramp-sh-handle-make-process In-Reply-To: <877cehql8y.fsf@gmx.de> (Michael Albinus's message of "Sat, 22 Jun 2024 13:18:05 +0200") References: <87msneqeyn.fsf@gmx.de> <87iky1qvqu.fsf@gmx.de> <877cehql8y.fsf@gmx.de> Date: Sat, 22 Jun 2024 14:02:42 +0200 Message-ID: <87zfrdp4m5.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:X4ayIF9Vba/FogSCcNLytq8VOh5hNLkZhle+xHf1Vi+QSEE0np6 PDHFBYbyUHW9mQkQo59LrgpmQQ5+vyJsVrR7qfmWChGKvztWhfRSo5qbHX4hWaGshXDIvKg SQU2zDadjY6OyxR+ZhLIH/LZzHnv7DcPH7gZ/JrIzn9hsPogZ+n20Cxy/XHfMEQaGLL3nfB m6BxfbVVWpXoDY1rjw3mQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:PMYiCSlRrbE=;phBsqDgA7fE4ED/IwrfoW0cuyXm tJqNyREizZt+EVS60SfxNwVgRjwusJVixBPZGl+hmvA2Tk1+ZTnqARPelzQzEVP0ojPOXAG8R daV1OkPByDa8Ugs1dho2b2KTNlfoxEwd6baSR1/4NjS2Po68JDZ6NUYAKXB1u6NesM9dJDQ+d hT1M5PoWF37tp7isW3vUdHj0lQHcSg/XQrQccmPuGJ/XIbCqnn3plTWyylKruWCQXjaCmlxKl HizG1eum6a6nFLW8RJ1JxHAWCxo7qfzuEEz6yhkOecJJfXYx2dRbC05Bu9sJEM2fUc/wZ7gcS BoTSM6cQgpsQFScHtAF0GqrfmOx5YZFVIlX0koQ4DjhIPbLr8T5HTm88vNUsvq/FXIPIf1USU RVSvzelt1EVKSx82S/jkW+hqGktVraJVylAV22n5XroCzrM1rBZLQMI5HnFfRtVYgvgd0Aa9h 6tpQZaMobO2CRhPugk0c4frk6qfrKF/AhR3kaw6SC+DwnRMksItN29Hqk+bokRpnk8HQNbWRA TOPloF+z2pgcXaTk/8DgAPefRzsvY3xBMX9V+/tJ8rOjj1NDo2Z9L4Hm17IVSnbCIXCdEUua/ XBqCNCLzS6kwQ6CqK0Ao3TwOkP3rN+rJ1CWYT9gB6nfm3QLcXM/72mvm9OGNGhq4dWkH5xYlf CymS60pkc+Y5q59uDyLaDJQUyG3jGYl5mJU6XJsRsXXKKIn2thYJUq1Z+3af4uVCt4ugtCYp4 217/L+8QUsOn5zae68v+zcUAQG01EC4wIpnqhyrZ5XQ+SebCFUXjigm5HeMFz6iAY1r/+/dYc q20jWzygKoa6wAGJlmJeBj34x1TFMenhiYgG6OpBgG8Zs= X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Michael Albinus writes: Hi Iurie, > Thanks for the recipe. I've played with it. Most cases, it works as > expected, but sometimes I see a similar error. Looks like a race > condition. I'll debug further. Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.21 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.17.21 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.155 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 71709 Cc: 71709@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Michael Albinus writes: Hi Iurie, > Thanks for the recipe. I've played with it. Most cases, it works as > expected, but sometimes I see a similar error. Looks like a race > condition. I'll debug further. Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.155 listed in zen.spamhaus.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.17.21 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.21 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain Michael Albinus writes: Hi Iurie, > Thanks for the recipe. I've played with it. Most cases, it works as > expected, but sometimes I see a similar error. Looks like a race > condition. I'll debug further. Well, I've found something suspicious in the code. Could you, pls, apply the appended patch to tramp.el in your Emacs Lisp directory? Since it changes a macro, you must remove all tramp*.elc files, and run 'make' afzerwards. >> Kind Regards, >> Iurie Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable diff --git a/lisp/tramp.el b/lisp/tramp.el index d9db17ea..f97ed66c 100644 =2D-- a/lisp/tramp.el +++ b/lisp/tramp.el @@ -3594,8 +3594,7 @@ that a stederr file is supported. BODY is the backe= nd specific code." (not (tramp-equal-remote default-directory stderr))) (signal 'file-error (list "Wrong stderr" stderr))) - (let ((default-directory tramp-compat-temporary-file-directory) - (name (tramp-get-unique-process-name name)) + (let ((name (tramp-get-unique-process-name name)) (buffer (if buffer (get-buffer-create buffer) @@ -5058,7 +5057,8 @@ should be set connection-local.") ;; Check for `tramp-sh-file-name-handler' and ;; `adb-file-name-handler-p', because something is different ;; between tramp-sh.el, and tramp-adb.el or tramp-sshfs.el. - (let* ((sh-file-name-handler-p (tramp-sh-file-name-handler-p v)) + (let* ((default-directory tramp-compat-temporary-file-directory) + (sh-file-name-handler-p (tramp-sh-file-name-handler-p v)) (adb-file-name-handler-p (tramp-adb-file-name-p v)) (env (mapcar (lambda (elt) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 13:05:27 2024 Received: (at 71709) by debbugs.gnu.org; 22 Jun 2024 17:05:27 +0000 Received: from localhost ([127.0.0.1]:52924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL4B4-0004kL-TK for submit@debbugs.gnu.org; Sat, 22 Jun 2024 13:05:27 -0400 Received: from mout.gmx.net ([212.227.15.18]:56939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL4B2-0004js-5n for 71709@debbugs.gnu.org; Sat, 22 Jun 2024 13:05:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1719075917; x=1719680717; i=michael.albinus@gmx.de; bh=2nqH9QltyyuYWMtZLpPXxpfAvVKOnMXZaQvKtcSTdlA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=ft/y0epcUeEgCauErdLlesPDNMmQyFikp+1EEzMp+PyLFdEv3ulmJ/RyaUgysrYk tQjyqE4CMmJ5KymewSioOXHua5ioza4S9O36H96E16aFe7TbQlKjdCR/6rzEHdlSu 4Mj7OR4VTu6UT2G1UH+OEwzOCqzu1SWy8NO+UmaCECdODGKUmkXgnuU7ul6FF1h7w /bfMTCW13N7Ly8XCzr97+49Zs27I6zQgRdi4zI8rT2o5BFkBS8FAU3s6Qn73O8PI8 bbZGhXlEs9v6HLdSfHik9CeKLvQqdLht6MtlkLGjkGY71WFLFAIlGWQ36EMxIV5iy vTjnMnrPZRhlsScUiA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MYvY2-1rqO9V1lyq-00WdFu; Sat, 22 Jun 2024 19:05:17 +0200 From: Michael Albinus To: Iurie Marian Subject: Re: bug#71709: Fix recent change in tramp-sh-handle-make-process In-Reply-To: (Iurie Marian's message of "Sat, 22 Jun 2024 18:52:01 +0200") References: <87msneqeyn.fsf@gmx.de> <87iky1qvqu.fsf@gmx.de> <877cehql8y.fsf@gmx.de> <87zfrdp4m5.fsf@gmx.de> Date: Sat, 22 Jun 2024 19:05:14 +0200 Message-ID: <87v820q56d.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:HCEIFn1jeZtcYc5U6T751cFOJSODqlYE3u3G4VvsNG9ee2eov/k 2+p+wNy0G19/Btkd2D+DyDIyy1L/aLyB/33syda7UDxlsMBVXxaUoTCECBkGZhGKAA4SNpQ 45hkerRJ7nt1ONCqih9kqkXwwhGX+62xRt/kpIxp4FYJIOKR+QJ/qu4NWJB3pilBwq10aCB i50OAYYNxo73+lp0ODMyQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:AtibmRku4Yo=;F0bOuCwwWI0aez28ihilvKgNeUy TyhpGV49QUQxuZYW6zb5Mqnx7J5kxGuib5Msjk2C6MMbon4NeCsdoQWNVWYpfcm2gEljITSxH gOA13MIFpCm8hx48jjYRZRmKNxUHo2gqIefGOrJs1BwGC3bzVgkpV4CEEnFsxLyHhpCn54jUs WqDhMWrBadzqP/5AK+/tb0KHLtNAZJLrKihhzLeaiKB4Z4n6m1k2LGgeYKuFwM8RZ7Qcq0vXj iRMtQnzQi3bq/VkEilmjLvNo/jmmzAC7/SDhMbN3F/1uJNvrjjyMHcW0g2mGi9QoroY2xHdmS LeV6LxFyoNeItujietTZzKmmKo79mghu8O5Va22yYuwY4zBseN2nIyixjES04eWFNazsNPFfs 9wvSuSsHQBm3bT2ORCyVaCOLtH2WJsxM09lRgYlKIY3bYoiitJhN6FVcRODmaywH7hPgM597S aPsVulvWVklxotNVTrGVzzcXwJyqrGq3bt4PzJil+8MJL/wEIOEEDl8cJYPeIUhMr8Y6emtbO 9F+lG3wr5WuNqaGv8ttfcie7UTdVFchDNH+WbRN6rl1XFvCNoBYYBoN1/R3nJNsgKRWTjMEW8 Rn0rh25uCnewFpOjEErVR0J0MKwTooDF27EmKsT2Cr/adCC87lxr3JNcbC149Uq+u8hn3iTX8 u7HqEMOSUILqkvbHBkaXzbCxpO6E3NXaPJ9ppbn1NusjcP8bOFRkRPP7MbPug32OsXmxxstuu vg9kNwPZhECF6/L0uJxJagokh17mhIfZjC5JOfaqloBQobPgJAf6m0vZJ/qD9awzpqe+FaHMq Mbq8IF3pUgpApffRfMqeQfR2uE3z99VhQDyMP0gZoQOoc= X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Iurie Marian writes: Hi Iurie, > Unfortunately, the patch doesn't help. > By the way, this is what I noticed: > * the issue seems to occur more often in a docker container > * over /ssh it is working well, or at least it never occu [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.155 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.18 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.18 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 71709 Cc: 71709@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Iurie Marian writes: Hi Iurie, > Unfortunately, the patch doesn't help. > By the way, this is what I noticed: > * the issue seems to occur more often in a docker container > * over /ssh it is working well, or at least it never occu [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.155 listed in zen.spamhaus.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.18 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.18 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Iurie Marian writes: Hi Iurie, > Unfortunately, the patch doesn't help. > By the way, this is what I noticed: > * the issue seems to occur more often in a docker container > * over /ssh it is working well, or at least it never occurred > * the temporary buffers like ~/tmp/tramp.J0RZDc~ are actually created on remote > * after repetitive tests I noticed that it doesn't reproduce anymore > and I added a line to print the default-directory right before > `make-process` for stderr: ~lisp/net/tramp-sh.el:3057~ > - when it fails, the default-directory is on local host > - when it succeeds - it's on remote (where I guess it finds that > temporary file) But this was exactly the change I have sent to you: preserve proper default-directory. > * on emacs restart it starts reproducing again > * once it starts working, it never reproduces again until emacs restart > > It looks like it has something to do with `stderr` process execution > environment. Yes. Did you apply the change as I have said? That means - Patch tramp.el inside the emacs tree - Remove all compiled Tramp files, like 'rm lisp/net/tramp*.elc' - Recompile EWmacs by calling 'make'. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 13:31:06 2024 Received: (at 71709) by debbugs.gnu.org; 22 Jun 2024 17:31:07 +0000 Received: from localhost ([127.0.0.1]:53804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL4Zu-0005dp-4g for submit@debbugs.gnu.org; Sat, 22 Jun 2024 13:31:06 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:45189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL3zK-0004CN-Hn for 71709@debbugs.gnu.org; Sat, 22 Jun 2024 12:53:19 -0400 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4217990f997so22299275e9.2 for <71709@debbugs.gnu.org>; Sat, 22 Jun 2024 09:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719075133; x=1719679933; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gouT8AtXzYRxAF40dJYuDYxknuV84uswThw95WMj/pc=; b=RqVyKmKMC6TUVt0RZj6YjupjQdDRgEPQvYjKMbWrucv7dAy0kkULoAdbVBJlnKSA6F SpazzvlN/rBEHrwqCWMpFfh7A5q/YdLpSjk8/YP/ZtI0hIfY3JgudzvOY9HquZsP5p++ 5SeXCB8OUTStaXuvUXanqgJnwI5lYzR0BWCaxpJSgn3mz4WWzKx1y6qh5yHZtOYA3zdr ToOQ+vVBeUPYfVRd2FDmk2Nk2NAoBu5JzGWepZGP5+TfRd7lZY9I0FxCcJNZGZmbVq+w d3eRyVJn625YrvhPj/Fx+z/NRFm+EK1ZhVMzxbvr1n7LGQ7FJZf5C66P9k3n+tfVKGTf siSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719075133; x=1719679933; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gouT8AtXzYRxAF40dJYuDYxknuV84uswThw95WMj/pc=; b=GlTAvMDG9iuic6bbTnP7oP3+tqD7G80nqSB243e/5cY4FBJbcSolSiUkMeDcSxZ3gu xrQZKVpp1kS2SMFJYOySULNuJZYR/w1uNy6mariscm4ydcNdYKbJFmuT6rf7cBOcWxnD 5WUkkLWE8/9eghCGwSddDhlITP+41Zjh8ChI0N81+HS2phw7NV2MVB2GwF1MaKgrtrto W2PX47l8bB12u5+50EBNXcL033RiumnmcZ5g/oLFqpVkzraRPC9jO8MLV5W9cxVk/7Uu cpZWKbkpWjRbhDx7y/M18aYF3YcFkRoS1rGt0oFQGmm9JIALC8A8K/djq9EKovUkGLPh 5BKg== X-Gm-Message-State: AOJu0Yy+mYg4sVqUwGk9ytsYlHJMwtAwD7vo9zjXvAvGip/ea4LM98GV d/TJV5aMcPe5O9MZfY9kTWyfSH54nLxa+1j7Cpar5JtnzuxnJqgLVcUctu+gjUh7Ee/Y4S3KxYN CGTjnyu6HEMWAkwDr6AEQG6J3Ekwr0pQl8QY= X-Google-Smtp-Source: AGHT+IEJEeSZUDwaRkiGmOv9eAIikUpK7sfC9wpOuQKR6ePC75EpxQnXknr2Z44bmvxrdxEXyYFkw0FwSvNjlwr7CsI= X-Received: by 2002:a05:600c:138e:b0:424:7bcf:2486 with SMTP id 5b1f17b1804b1-42489e3708fmr9275825e9.4.1719075132649; Sat, 22 Jun 2024 09:52:12 -0700 (PDT) MIME-Version: 1.0 References: <87msneqeyn.fsf@gmx.de> <87iky1qvqu.fsf@gmx.de> <877cehql8y.fsf@gmx.de> <87zfrdp4m5.fsf@gmx.de> In-Reply-To: <87zfrdp4m5.fsf@gmx.de> From: Iurie Marian Date: Sat, 22 Jun 2024 18:52:01 +0200 Message-ID: Subject: Re: bug#71709: Fix recent change in tramp-sh-handle-make-process To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71709 X-Mailman-Approved-At: Sat, 22 Jun 2024 13:31:05 -0400 Cc: 71709@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Unfortunately, the patch doesn't help. By the way, this is what I noticed: * the issue seems to occur more often in a docker container * over /ssh it is working well, or at least it never occurred * the temporary buffers like ~/tmp/tramp.J0RZDc~ are actually created on remote * after repetitive tests I noticed that it doesn't reproduce anymore and I added a line to print the default-directory right before `make-process` for stderr: ~lisp/net/tramp-sh.el:3057~ - when it fails, the default-directory is on local host - when it succeeds - it's on remote (where I guess it finds that temporary file) * on emacs restart it starts reproducing again * once it starts working, it never reproduces again until emacs restart It looks like it has something to do with `stderr` process execution environment. On Sat, 22 Jun 2024 at 14:02, Michael Albinus wrote: > > Michael Albinus writes: > > Hi Iurie, > > > Thanks for the recipe. I've played with it. Most cases, it works as > > expected, but sometimes I see a similar error. Looks like a race > > condition. I'll debug further. > > Well, I've found something suspicious in the code. Could you, pls, apply > the appended patch to tramp.el in your Emacs Lisp directory? Since it > changes a macro, you must remove all tramp*.elc files, and run 'make' > afzerwards. > > >> Kind Regards, > >> Iurie > > Best regards, Michael. > From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 13:31:07 2024 Received: (at 71709) by debbugs.gnu.org; 22 Jun 2024 17:31:07 +0000 Received: from localhost ([127.0.0.1]:53806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL4Zu-0005ds-Qx for submit@debbugs.gnu.org; Sat, 22 Jun 2024 13:31:07 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:56437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL4Xe-0005XB-GI for 71709@debbugs.gnu.org; Sat, 22 Jun 2024 13:28:47 -0400 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-364a3d5d901so2138268f8f.0 for <71709@debbugs.gnu.org>; Sat, 22 Jun 2024 10:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719077261; x=1719682061; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xHlvpIK/WRNgsyMTCAOEcBXvvqPRqyt1YyAkhnXujeY=; b=ZieK78u6YvA0QZSUxjZ+a1pc2fC7bsASPJn4nmM23C7A7VHPu1cz0itzfjmlL3qDdf ixAPlUmWMn0uvNCdRPRf02wDmEqsCd18SeHrUpzKS2dE/mwthOzSFrNGVj2Q1zwL5b+5 QOoFTWFC6bKlb6wt253cjwoOHTJsbpR2SuIa9FW4tLmqKgpgkaLT38iX2rdEFn7Px/Ch abq5zlEXUIZUqEkcJEztugO2Gk9wuK/XY0A4qUoouF9E/TWNQywfghtdk/FRQaFiOlto 9Fj5i2hxoSxXsN5HV7pIffgiIGOzph0hhOFXaw+Z7F8ujx+KpYE8aq8NzJy2mAb0xnlP TD7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719077261; x=1719682061; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xHlvpIK/WRNgsyMTCAOEcBXvvqPRqyt1YyAkhnXujeY=; b=pMNiMrbyYcGH/ZMs4s8lpxn6M0Apx/NavOgbsvnSk+mChuXStp+6UjcN6nfrwyZrDa 4csoO6mrYmrwCGNWbWSgPIYT0q1dX4mbdxpprSuMSdXgvPcl+6jLtso5qQxEYoKlKFoJ LIbdKRVqv0Ga5h48DmiigSPH66WW20WBu13WwVNQW5QBO5VEZvX7EXz2RsGM5tRLt458 K5LZVmrhjQPrjGlZz3QZJnjpEn7uvHFsg2DpEJ7mwQFcD3K4WjGCtwFncc5k4O7t9Q+I v2guUS28zHyqzRyIFu+6qT5XdAuD6oCi0kCjqqFojPkaH5d+3YT4+1XWCY9SntChzFd6 aMFw== X-Gm-Message-State: AOJu0Yy9hOInbTCDovxIUo1oTh8tOEL9cQbkWUNcQGXxRklYx8iSCWoD HBy8CyUA4bnL/L8+jUp/9lxcBf4yjxDJlEz604EQP/WjfJ7s/OMduPUQVvA8hy1+ItOGWjg+3wn 92U6i1MZJs0KDUaGbxQZGLUMgj8U= X-Google-Smtp-Source: AGHT+IEMPnGfku2JrwQR08y9iyoBNuaPzGULAaILB12v75PlPcoJqAPgqndZSHTGuR9zGMy3zuw3AfXieQPr1f2Gz+0= X-Received: by 2002:a5d:6650:0:b0:366:ea15:d833 with SMTP id ffacd0b85a97d-366ea15dd6fmr34936f8f.46.1719077260473; Sat, 22 Jun 2024 10:27:40 -0700 (PDT) MIME-Version: 1.0 References: <87msneqeyn.fsf@gmx.de> <87iky1qvqu.fsf@gmx.de> <877cehql8y.fsf@gmx.de> <87zfrdp4m5.fsf@gmx.de> <87v820q56d.fsf@gmx.de> In-Reply-To: <87v820q56d.fsf@gmx.de> From: Iurie Marian Date: Sat, 22 Jun 2024 19:27:29 +0200 Message-ID: Subject: Re: bug#71709: Fix recent change in tramp-sh-handle-make-process To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71709 X-Mailman-Approved-At: Sat, 22 Jun 2024 13:31:05 -0400 Cc: 71709@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alright, yes last time I've only applied the patch in *.el file and evaluated the buffer :D I've recompiled from scratch and it works as expected! :) Many thanks! Iurie On Sat, 22 Jun 2024 at 19:05, Michael Albinus wrote: > > Iurie Marian writes: > > Hi Iurie, > > > Unfortunately, the patch doesn't help. > > By the way, this is what I noticed: > > * the issue seems to occur more often in a docker container > > * over /ssh it is working well, or at least it never occurred > > * the temporary buffers like ~/tmp/tramp.J0RZDc~ are actually created on remote > > * after repetitive tests I noticed that it doesn't reproduce anymore > > and I added a line to print the default-directory right before > > `make-process` for stderr: ~lisp/net/tramp-sh.el:3057~ > > - when it fails, the default-directory is on local host > > - when it succeeds - it's on remote (where I guess it finds that > > temporary file) > > But this was exactly the change I have sent to you: preserve proper default-directory. > > > * on emacs restart it starts reproducing again > > * once it starts working, it never reproduces again until emacs restart > > > > It looks like it has something to do with `stderr` process execution > > environment. > > Yes. Did you apply the change as I have said? That means > > - Patch tramp.el inside the emacs tree > - Remove all compiled Tramp files, like 'rm lisp/net/tramp*.elc' > - Recompile EWmacs by calling 'make'. > > Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 13:55:12 2024 Received: (at 71709-done) by debbugs.gnu.org; 22 Jun 2024 17:55:12 +0000 Received: from localhost ([127.0.0.1]:54597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL4xE-0006ST-4P for submit@debbugs.gnu.org; Sat, 22 Jun 2024 13:55:12 -0400 Received: from mout.gmx.net ([212.227.17.22]:46787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL4x9-0006S6-Ug for 71709-done@debbugs.gnu.org; Sat, 22 Jun 2024 13:55:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1719078899; x=1719683699; i=michael.albinus@gmx.de; bh=uQG9E3uwjZQkzPTGl20P/f/7p4zh6bmSzogfq4/d6kM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=l11mUKvUD7qPPTX/VZRTi6Zlg8Y5spQugvkdDT1F8DeTBuYOT4VZpQU2VmZ8W9N5 +xlVbKORbgUEJMbBHSy1PaA7VmaOtJhY2xhWqp5+3zQnh82edydsA8I6bx0qsiUa0 dMo/DXVaoDsT4bq0NAS9zo7wD7ElLood09TJdjax3Iu4kB18IUz7Ef8Cvgz6xfJE/ WB0MEAktmZZu8SqG9pE2ZsrI22SbWxQ+IP7bULsZhd0ndVH9LvdpEbJGXsRWaZlb1 BqWP6otEszs16FprItf7fUrHupicxOt0NrTg61SSKapF0Mz6hqUHOY53Ih2RRNdCe btSkuZg3uaIOX3OyVw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MCbIx-1sBUA541DP-00B9qV; Sat, 22 Jun 2024 19:54:59 +0200 From: Michael Albinus To: Iurie Marian Subject: Re: bug#71709: Fix recent change in tramp-sh-handle-make-process In-Reply-To: (Iurie Marian's message of "Sat, 22 Jun 2024 19:27:29 +0200") References: <87msneqeyn.fsf@gmx.de> <87iky1qvqu.fsf@gmx.de> <877cehql8y.fsf@gmx.de> <87zfrdp4m5.fsf@gmx.de> <87v820q56d.fsf@gmx.de> Date: Sat, 22 Jun 2024 19:54:58 +0200 Message-ID: <87jzigq2vh.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:DJS94bCRN0J2hHyfOhereNALk8Lp2/+q7EoqL9wzpxwEohG6EAK kA3mv63QZGusoywvN3M7+quO/4LedwxZ1dhq3nUOAkFeR1fxtNqeTfbGeQSCbxuw9WUCMWn nonGv6L2NCPW4n7kdMJETBlU1rkgRZ0n4pTv2tWPiw6Av0W/R/N/4kTWSrqHKb95r5rY687 2CvMHgQGS1JkSXVyq4dFQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:OLLXrfiQXWw=;Lj6Dh9M2yobT21FtDUldrMpae3e BzoLmRUxGoIqn8vpznmXxJ7vNgVrHgJJy7CZt6BGw2ewyT82MBM9wf64Da35vDxrCa5sgQyj3 X7Z3HzZymKwES7Ysz38C2uOKbQDZR54oavQWYP0+p5bWt3V9f/K0JvhFzc899695V7eGDbS5/ VGaSljNC1kPoY7d1iUvGRmvGRT8c6y5fUYlSWAVdZqN6nOqC4BF6xfVnc7HZMfKhxRTa8cm5/ I4VSc/COn1F/A34PzpddA8aFcOxZLiVezsGb/Ih4ltHUZwZYIDKt1QyM80LSdWfRKgNr63+3B u/rzE6ozqxx0alMSIvK4AeGrRQcvomG3UJc7CX6X04kD3EwTwKIMBHMkXWs46DRMPw3+5C9af uCvxElVAktsiA2ooW0MMYuZX8Td18Tl2l4MQZI2Lr5RBMcpZRoRTMC6iEAXYUUO1T/4e5OqRx eHtkGy+/YsArkar6NaTI716odqpzIV+5Rqo7NrxxCN8PL/d31M2li60BnvWGYxNIRyLImYUg5 mZ8P6Ptfja3mqiDnSUTHIRTfI9oWUFGr8HK876rLGGzyJ3INbwVxf1EEyPpagbVANp3YdOpsO 7DTEbK6m9SdpIjw0YzXUGCQqw8DCjOiCBjUrymedjqkwKASqlYHhlljfKL8khCz6D5FMf23OY EmW5fJo3vC8WrtxeR7Y3OvIdn5JYd7AYkOS/dqCoOl1z99gFffNYBoY4KRozIjXUG+YJHOerR bay3dNJ++bJpj98Ij2OY7aT4GKI5xx6pwIyaHsYgfyIz3X1X4lrag3k5S6VgwQzJ1wSGiHrJb hPvQ3nCE+Dlutbklu/55aHGO/dLObxb3K5fI6lVjIrQvo= X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Version: 30.1 Iurie Marian writes: Hi Iurie, Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.155 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.22 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.17.22 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 71709-done Cc: 71709-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Version: 30.1 Iurie Marian writes: Hi Iurie, Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.155 listed in zen.spamhaus.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.17.22 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.22 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Version: 30.1 Iurie Marian writes: Hi Iurie, > Alright, yes last time I've only applied the patch in *.el file and > evaluated the buffer :D > > I've recompiled from scratch and it works as expected! :) Thanks for the feedback, so we've got it. Thanks also for your testing. I've pushed the patch to the repositories, closing the bug. > Many thanks! > Iurie Best regards, Michael. From unknown Sun Aug 10 02:41:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 21 Jul 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator