GNU bug report logs - #71701
[PATCH]: Update sbcl-fset to 1.4.0

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71701 in the body.
You can then email your comments to 71701 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: André A. Gomes <andremegafone <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH]: Update sbcl-fset to 1.4.0 
Date: Fri, 21 Jun 2024 15:22:46 +0300

[Message part 1 (text/plain, inline)]

Attached, thanks.

-- 
André A. Gomes
"You cannot even find the ruins..."

[0001-gnu-sbcl-fset-Update-to-1.4.0.patch (text/x-patch, attachment)]

Message #8 received at 71701 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: 71701 <at> debbugs.gnu.org
Cc: andremegafone <at> gmail.com
Subject: Re: [PATCH]: Update sbcl-fset to 1.4.0
Date: Fri, 21 Jun 2024 21:29:11 +0000

Hi André,

Thanks for the patch.

When I try to apply your patch I get the below error.

Would you mind sharing how you sent the patch so I can debug this issue a bit.

Did you use git send-email or something else?

Thanks!

jgart


jgart <at> unknown1ee35e825799:~/Code/guix-latest [env]$ mumi am -- -s -S
Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Backtrace:
           2 (primitive-load "/gnu/store/p3xfvin2a76618144l39i4nn17a…")
In srfi/srfi-1.scm:
    634:9  1 (for-each #<procedure 7fd6f46c69c0 at mumi/client.scm:…> …)
In mumi/client.scm:
   249:12  0 (call-with-output-pipe* _ _ . _)

mumi/client.scm:249:12: In procedure call-with-output-pipe*:
Command invocation failed failed ("git" "am" "-s" "-S")

Message #11 received at 71701 <at> debbugs.gnu.org (full text, mbox):

From: André A. Gomes <andremegafone <at> gmail.com>
To: "jgart" <jgart <at> dismail.de>
Cc: glv <at> posteo.net, 71701 <at> debbugs.gnu.org
Subject: Re: [PATCH]: Update sbcl-fset to 1.4.0
Date: Tue, 25 Jun 2024 13:19:42 +0300

"jgart" <jgart <at> dismail.de> writes:

> When I try to apply your patch I get the below error.
>
> Would you mind sharing how you sent the patch so I can debug this issue a bit.
>
> Did you use git send-email or something else?

Hi jgart,

I sent the patch as an email attachment.  I am not very comfortable
doing it via git send-email but can look into it if it's a hard
requirement.

Usually Guillaume tests my patches since I mainly contribute to the lisp
effort, and it has been working for him.

Thanks.


-- 
André A. Gomes
"You cannot even find the ruins..."

Message #14 received at 71701 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "André A. Gomes" <andremegafone <at> gmail.com>,
 71701 <at> debbugs.gnu.org
Cc: Guillaume Le Vaillant <glv <at> posteo.net>
Subject: Re: [PATCH]: Update sbcl-fset to 1.4.0
Date: Tue, 25 Jun 2024 16:35:40 +0000

> I sent the patch as an email attachment. I am not very comfortable
> 
> doing it via git send-email but can look into it if it's a hard requirement.

It's currently not a hard requirement but it makes my job harder for my workflow of using the `mumi am` tool to apply patches.

I'll let Guillaume review this one if Guillaume is able to. It would be much appreciated.

In the meantime, I'll try to work on getting `mumi am` to accept and support email-sent patches if I am going to review patches like this one in the future that don't apply via `mumi am`.

Thanks for the report and for your contribution.

all the best,

jgart

Message #19 received at 71701-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: André A. Gomes <andremegafone <at> gmail.com>
Cc: jgart <jgart <at> dismail.de>, 71701-done <at> debbugs.gnu.org
Subject: Re: [PATCH]: Update sbcl-fset to 1.4.0
Date: Wed, 26 Jun 2024 09:09:05 +0000

[Message part 1 (text/plain, inline)]

Patch applied as c32b31ecfcb7e6c51bfe457cce70d7b6b36b9cca with
a completed commit message.
Thanks.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.