GNU bug report logs - #71666
30.0.50; [PATCH] Fix zooming images with SHR

Previous Next

Package: emacs;

Reported by: Jim Porter <jporterbugs <at> gmail.com>

Date: Thu, 20 Jun 2024 04:48:02 UTC

Severity: normal

Tags: patch

Merged with 63344

Found in versions 29.0.90, 30.0.50

Done: Jim Porter <jporterbugs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#71666: closed (30.0.50; [PATCH] Fix zooming images with SHR)
Date: Thu, 04 Jul 2024 19:20:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 4 Jul 2024 12:18:08 -0700
with message-id <4aefa1e3-6d43-2a0b-fe67-812e25df52d4 <at> gmail.com>
and subject line Re: bug#71666: 30.0.50; [PATCH] Fix zooming images with SHR
has caused the debbugs.gnu.org bug report #71666,
regarding 30.0.50; [PATCH] Fix zooming images with SHR
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
71666: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71666
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Fix zooming images with SHR
Date: Wed, 19 Jun 2024 21:47:26 -0700
[Message part 3 (text/plain, inline)]
To reproduce this, start from "emacs -Q -f eww" and then go to fsf.org. 
Move point over one of the larger images on the page, like the ones that 
say "Featured" above them, and press Z ('shr-zoom-image'). The result is 
that the image is duplicated, and the first slice gets pushed up onto 
the previous line.

Attached is a patch to fix this, with regression tests.
[0001-Fix-zooming-images-in-SHR.patch (text/plain, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Jim Porter <jporterbugs <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 71666-done <at> debbugs.gnu.org
Subject: Re: bug#71666: 30.0.50; [PATCH] Fix zooming images with SHR
Date: Thu, 4 Jul 2024 12:18:08 -0700
On 6/28/2024 8:39 PM, Stefan Kangas wrote:
> OK, thanks.  I had missed some necessary context here.  If they're not
> regressions from Emacs 29, you're right that they belong on master.

Pushed to the master branch as f91387cce8f, and closing this bug now.


This bug report was last modified 1 year and 34 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.