From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 20 00:47:46 2024 Received: (at submit) by debbugs.gnu.org; 20 Jun 2024 04:47:46 +0000 Received: from localhost ([127.0.0.1]:43119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK9i5-00005z-1a for submit@debbugs.gnu.org; Thu, 20 Jun 2024 00:47:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:52592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK9i2-00005o-LL for submit@debbugs.gnu.org; Thu, 20 Jun 2024 00:47:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sK9hw-00079e-RB for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 00:47:37 -0400 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sK9ht-0000RE-Kz for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 00:47:36 -0400 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-70625e8860cso405796b3a.2 for ; Wed, 19 Jun 2024 21:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718858848; x=1719463648; darn=gnu.org; h=subject:from:to:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=NuvbqBcbDOanOUycMHwLsWAc1pbPA3RRSDWxZZyh5m0=; b=DaW8OsddnkPXsuZ7hmzChyMHZrzKR6Y631xXeF5Ym7zDP/DqQ32SQCK/XL5xUJeD2k w9w6ajOPYN8SjD/fAIGccSzv7baG5f4nC2W4Qhml1qEa1ja+ffBUDrU6VqMIkekV41cf +YxR4bgnmCM9BC/SW9lcujRMY4JI4ojvsm6vPqEO+GphTiRwvhXKUt7pErxKJ0yRS7F7 FixzetesKwQFe0Zu9tMiIZjWt1REc1u9HJbTQyVztYbc6LYNK3SB+mB2kFMTb403y/yg tbI9R5qwtM3vVtLwUuaxIlxJpoFwATqi4gc/UyLXSMbFAirblqrb6pS4tpCRDNvpPPCF yrJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718858848; x=1719463648; h=subject:from:to:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NuvbqBcbDOanOUycMHwLsWAc1pbPA3RRSDWxZZyh5m0=; b=HU2FEJcf4a7IOLNYDH5OoTXgH0xcg1zz5wltu/+dJgQ00qMeHjvC9mIa7+CRQSgTGj rMbkgBmtWQJUKO7Da++fePctmiTJdRB7oT+qq7qf47qm6icFmWmouapD5illEWSsO6Vq vEVte5XWtQoHF/S5+qS5DbD0rrVopFATnYWFwD623LEYZUE+E946Yswne2yrfOJpAWTo m573ygXBiqBOviR2Eb9imput11+chTLZY7ah9ZZM1ntRWSazB9KozyBrX0kmLxArvwPo ct0lfMBO8SNV+ym7C7tWoFF3WrzTiz4Uo2sbpsoX9YC83+VmUmcd/cFL1OFy876M9CDs ObSg== X-Gm-Message-State: AOJu0Yy3YQkLniZHfkUFfRB98Hk7mKIx4wO3mPG5hHsGbhkJv6LKalil pb+WH5GbVhGt/cLw/8Mu/ZnAco7OTsrNE84roKC3EdB7QhKozTzhH79W4Q== X-Google-Smtp-Source: AGHT+IFTpKBukeI52Z5ORjupKVGVGRc3bE7wqzOAD5ZRxxhCEvlrfxJwyHIPEWlE1QQ3E+gyGd9B+Q== X-Received: by 2002:a05:6a00:2e05:b0:705:95ce:cfd3 with SMTP id d2e1a72fcca58-70629cf66c7mr6187789b3a.31.1718858847738; Wed, 19 Jun 2024 21:47:27 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-705ccb8d7f9sm11433310b3a.194.2024.06.19.21.47.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jun 2024 21:47:27 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------QJlqmnJouEiSfHGX4bewtGMy" Message-ID: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> Date: Wed, 19 Jun 2024 21:47:26 -0700 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Jim Porter Subject: 30.0.50; [PATCH] Fix zooming images with SHR Received-SPF: pass client-ip=2607:f8b0:4864:20::433; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------QJlqmnJouEiSfHGX4bewtGMy Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To reproduce this, start from "emacs -Q -f eww" and then go to fsf.org. Move point over one of the larger images on the page, like the ones that say "Featured" above them, and press Z ('shr-zoom-image'). The result is that the image is duplicated, and the first slice gets pushed up onto the previous line. Attached is a patch to fix this, with regression tests. --------------QJlqmnJouEiSfHGX4bewtGMy Content-Type: text/plain; charset=UTF-8; name="0001-Fix-zooming-images-in-SHR.patch" Content-Disposition: attachment; filename="0001-Fix-zooming-images-in-SHR.patch" Content-Transfer-Encoding: base64 RnJvbSAwOWUyNTk4MTcwMGEzNDAwMWUzZWRjYWI2ZjhjYzNlYjBhNzE1ZDEyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgMTkgSnVuIDIwMjQgMjA6NTk6NTkgLTA3MDAKU3ViamVjdDogW1BB VENIXSBGaXggem9vbWluZyBpbWFnZXMgaW4gU0hSCgpQcmV2aW91c2x5LCBmb3IgaW1hZ2Vz IHdpdGggbm8gYWx0LXRleHQsIHRoZSB6b29tZWQgaW1hZ2Ugd291bGRuJ3QgZ2V0CnByb3Bl cmx5IGluc2VydGVkLiAgRm9yIGltYWdlcyB3aXRoIGFsdC10ZXh0LCBib3RoIHRoZSB6b29t ZWQgYW5kCnVuem9vbWVkIGltYWdlIHdvdWxkIGJlIGRpc3BsYXllZCBhdCBvbmNlLgoKKiBs aXNwL25ldC9zaHIuZWwgKHNoci16b29tLWltYWdlKTogUmVpbXBsZW1lbnQgdXNpbmcKJ25l eHQvcHJldmlvdXMtc2luZ2xlLXByb3BlcnR5LWNoYW5nZScsIGFuZCBkb24ndCBib3RoZXIg ZGVsZXRpbmcgYW55IG9mCnRoZSB0ZXh0Lgooc2hyLWltYWdlLWZldGNoZWQpOiBEb24ndCBn aXZlIHNsaWNlZCBpbWFnZXMgYSBmYWNlLgooc2hyLXB1dC1pbWFnZSk6IEVuc3VyZSB3ZSBh bHdheXMgaGF2ZSBhIG5vbi1lbXB0eSBzdHJpbmcgdG8gcHV0IHRoZQppbWFnZSBvbi4gIEZv ciBzbGljZWQgaW1hZ2VzLCBqdXN0IHVzZSAiKiIsIHNpbmNlIHdlJ2xsIHJlcGVhdCBpdCwg c28gd2UKY2FuJ3QgcHJlc2VydmUgdGhlIG9yaWdpbmFsIGJ1ZmZlciB0ZXh0IGV4YWN0bHkg YW55d2F5Lgooc2hyLXRhZy1pbWcpOiBNb3ZlIHRoZSBwbGFjZWhvbGRlciBzcGFjZSBpbnNl cnRpb24gd2hlcmUgaXQgc2hvdWxkIGJlCmFuZCBleHBsYWluIHdoYXQgaXQncyBkb2luZy4K CiogdGVzdC9saXNwL25ldC9zaHItdGVzdHMuZWwgKHNoci10ZXN0LS1tYXgtd2FpdC10aW1l KQooc2hyLXRlc3Qtd2FpdC1mb3IpOiBOZXcgaGVscGVyIGZ1bmN0aW9ucy4KKHNoci10ZXN0 L3pvb20taW1hZ2UpOiBOZXcgdGVzdC4KLS0tCiBsaXNwL25ldC9zaHIuZWwgICAgICAgICAg ICB8IDk4ICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCiB0ZXN0L2xp c3AvbmV0L3Noci10ZXN0cy5lbCB8IDU4ICsrKysrKysrKysrKysrKysrKysrKysKIDIgZmls ZXMgY2hhbmdlZCwgMTA5IGluc2VydGlvbnMoKyksIDQ3IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2xpc3AvbmV0L3Noci5lbCBiL2xpc3AvbmV0L3Noci5lbAppbmRleCAxNGIzZjdh YTE2My4uYTkyNTI2YTllNGUgMTAwNjQ0Ci0tLSBhL2xpc3AvbmV0L3Noci5lbAorKysgYi9s aXNwL25ldC9zaHIuZWwKQEAgLTYwMCwzOCArNjAwLDM0IEBAIHNoci1pbnNlcnQtaW1hZ2UK IAkJICAgIHQpKSkpCiAKIChkZWZ1biBzaHItem9vbS1pbWFnZSAoKQotICAiVG9nZ2xlIHRo ZSBpbWFnZSBzaXplLgotVGhlIHNpemUgd2lsbCBiZSByb3RhdGVkIGJldHdlZW4gdGhlIGRl ZmF1bHQgc2l6ZSwgdGhlIG9yaWdpbmFsCi1zaXplLCBhbmQgZnVsbC1idWZmZXIgc2l6ZS4i CisgICJDeWNsZSB0aGUgaW1hZ2Ugc2l6ZS4KK1RoZSBzaXplIHdpbGwgY3ljbGUgdGhyb3Vn aCB0aGUgZGVmYXVsdCBzaXplLCB0aGUgb3JpZ2luYWwgc2l6ZSwgYW5kCitmdWxsLWJ1ZmZl ciBzaXplLiIKICAgKGludGVyYWN0aXZlKQotICAobGV0ICgodXJsIChnZXQtdGV4dC1wcm9w ZXJ0eSAocG9pbnQpICdpbWFnZS11cmwpKQotCShzaXplIChnZXQtdGV4dC1wcm9wZXJ0eSAo cG9pbnQpICdpbWFnZS1zaXplKSkKLQkoYnVmZmVyLXJlYWQtb25seSBuaWwpKQorICAobGV0 ICgodXJsIChnZXQtdGV4dC1wcm9wZXJ0eSAocG9pbnQpICdpbWFnZS11cmwpKSkKICAgICAo aWYgKG5vdCB1cmwpCiAJKG1lc3NhZ2UgIk5vIGltYWdlIHVuZGVyIHBvaW50IikKLSAgICAg IDs7IERlbGV0ZSB0aGUgb2xkIHBpY3R1cmUuCi0gICAgICAod2hpbGUgKGdldC10ZXh0LXBy b3BlcnR5IChwb2ludCkgJ2ltYWdlLXVybCkKLQkoZm9yd2FyZC1jaGFyIC0xKSkKLSAgICAg IChmb3J3YXJkLWNoYXIgMSkKLSAgICAgIChsZXQgKChzdGFydCAocG9pbnQpKSkKLQkod2hp bGUgKGdldC10ZXh0LXByb3BlcnR5IChwb2ludCkgJ2ltYWdlLXVybCkKLQkgIChmb3J3YXJk LWNoYXIgMSkpCi0JKGZvcndhcmQtY2hhciAtMSkKLQkocHV0LXRleHQtcHJvcGVydHkgc3Rh cnQgKHBvaW50KSAnZGlzcGxheSBuaWwpCi0JKHdoZW4gKD4gKC0gKHBvaW50KSBzdGFydCkg MikKLQkgIChkZWxldGUtcmVnaW9uIHN0YXJ0ICgxLSAocG9pbnQpKSkpKQotICAgICAgKG1l c3NhZ2UgIkluc2VydGluZyAlcy4uLiIgdXJsKQotICAgICAgKHVybC1yZXRyaWV2ZSB1cmwg IydzaHItaW1hZ2UtZmV0Y2hlZAotCQkgICAgKGxpc3QgKGN1cnJlbnQtYnVmZmVyKSAoMS0g KHBvaW50KSkgKHBvaW50LW1hcmtlcikKLQkJCSAgKGxpc3QgKGNvbnMgJ3NpemUKLQkJCQkg ICAgICAoY29uZCAoKG9yIChlcSBzaXplICdkZWZhdWx0KQotCQkJCQkJIChudWxsIHNpemUp KQotCQkJCQkgICAgICdvcmlnaW5hbCkKLQkJCQkJICAgICgoZXEgc2l6ZSAnb3JpZ2luYWwp Ci0JCQkJCSAgICAgJ2Z1bGwpCi0JCQkJCSAgICAoKGVxIHNpemUgJ2Z1bGwpCi0JCQkJCSAg ICAgJ2RlZmF1bHQpKSkpKQotCQkgICAgdCkpKSkKKyAgICAgIChsZXQqICgoZW5kIChvciAo bmV4dC1zaW5nbGUtcHJvcGVydHktY2hhbmdlIChwb2ludCkgJ2ltYWdlLXVybCkKKyAgICAg ICAgICAgICAgICAgICAgICAocG9pbnQtbWF4KSkpCisgICAgICAgICAgICAgKHN0YXJ0IChv ciAocHJldmlvdXMtc2luZ2xlLXByb3BlcnR5LWNoYW5nZSBlbmQgJ2ltYWdlLXVybCkKKyAg ICAgICAgICAgICAgICAgICAgICAgIChwb2ludC1taW4pKSkKKyAgICAgICAgICAgICAoc2l6 ZSAoZ2V0LXRleHQtcHJvcGVydHkgKHBvaW50KSAnaW1hZ2Utc2l6ZSkpCisgICAgICAgICAg ICAgKG5leHQtc2l6ZSAoY29uZCAoKG9yIChlcSBzaXplICdkZWZhdWx0KQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAobnVsbCBzaXplKSkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAnb3JpZ2luYWwpCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoKGVxIHNpemUgJ29yaWdpbmFsKQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICdmdWxsKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKChlcSBzaXplICdm dWxsKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdkZWZhdWx0KSkpCisgICAg ICAgICAgICAgKGJ1ZmZlci1yZWFkLW9ubHkgbmlsKSkKKyAgICAgICAgOzsgRGVsZXRlIHRo ZSBvbGQgcGljdHVyZS4KKyAgICAgICAgKHB1dC10ZXh0LXByb3BlcnR5IHN0YXJ0IGVuZCAn ZGlzcGxheSBuaWwpCisgICAgICAgIChtZXNzYWdlICJJbnNlcnRpbmcgJXMuLi4iIHVybCkK KyAgICAgICAgKHVybC1yZXRyaWV2ZSB1cmwgIydzaHItaW1hZ2UtZmV0Y2hlZAorICAgICAg ICAgICAgICAgICAgICAgIGAoLChjdXJyZW50LWJ1ZmZlcikgLHN0YXJ0CisgICAgICAgICAg ICAgICAgICAgICAgICAsKHNldC1tYXJrZXIgKG1ha2UtbWFya2VyKSBlbmQpCisgICAgICAg ICAgICAgICAgICAgICAgICAoKHNpemUgLiAsbmV4dC1zaXplKSkpCisgICAgICAgICAgICAg ICAgICAgICAgdCkpKSkpCiAKIDs7OyBVdGlsaXR5IGZ1bmN0aW9ucy4KIApAQCAtMTA3Mywx MSArMTA2OSwxOSBAQCBzaHItaW1hZ2UtZmV0Y2hlZAogCQkgIChkZWxldGUtcmVnaW9uIHN0 YXJ0IGVuZCkKIAkJICAoZ290by1jaGFyIHN0YXJ0KQogCQkgIChmdW5jYWxsIHNoci1wdXQt aW1hZ2UtZnVuY3Rpb24gZGF0YSBhbHQgZmxhZ3MpCi0JCSAgKHdoaWxlIHByb3BlcnRpZXMK LQkJICAgIChsZXQgKCh0eXBlIChwb3AgcHJvcGVydGllcykpCi0JCQkgICh2YWx1ZSAocG9w IHByb3BlcnRpZXMpKSkKLQkJICAgICAgKHVubGVzcyAobWVtcSB0eXBlICcoZGlzcGxheSBp bWFnZS1zaXplKSkKLQkJCShwdXQtdGV4dC1wcm9wZXJ0eSBzdGFydCAocG9pbnQpIHR5cGUg dmFsdWUpKSkpKSkpKSkpKQorICAgICAgICAgICAgICAgICAgKGxldCAoKHNsaWNlZC1pbWFn ZSAoYXNzcSAnc2xpY2UgKGdldC10ZXh0LXByb3BlcnR5CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhcnQgJ2Rpc3BsYXkpKSkpCisg ICAgICAgICAgICAgICAgICAgICh3aGlsZSBwcm9wZXJ0aWVzCisgICAgICAgICAgICAgICAg ICAgICAgKGxldCAoKHR5cGUgKHBvcCBwcm9wZXJ0aWVzKSkKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAodmFsdWUgKHBvcCBwcm9wZXJ0aWVzKSkpCisgICAgICAgICAgICAgICAg ICAgICAgICAodW5sZXNzIChvciAobWVtcSB0eXBlICcoZGlzcGxheSBpbWFnZS1zaXplKSkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IFNsaWNlZCBpbWFnZXMg c2hvdWxkbid0IGhhdmUgYQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg OzsgZmFjZTsgaWYgdGhlIGltYWdlcyBpcyBhIGxpbmssCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICA7OyB3ZSdkIGdldCB1bmRlcmxpbmVzIG9uIGV2ZXJ5CisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBzbGljZSEKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChhbmQgc2xpY2VkLWltYWdlIChlcSB0eXBlICdm YWNlKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eQor ICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhcnQgKHBvaW50KSB0eXBlIHZhbHVlKSkp KSkpKSkpKSkpCiAgICAgKGtpbGwtYnVmZmVyIGltYWdlLWJ1ZmZlcikpKQogCiAoZGVmdW4g c2hyLWltYWdlLWZyb20tZGF0YSAoZGF0YSkKQEAgLTExNDQsNyArMTE0OCw4IEBAIHNoci1w dXQtaW1hZ2UKICAgICAgICAgICA7OyBwdXR0aW5nIGFueSBzcGFjZSBhZnRlciBpbmxpbmUg aW1hZ2VzLgogICAgICAgICAgIDs7IEFMVCBtYXkgYmUgbmlsIHdoZW4gdmlzaXRpbmcgaW1h Z2UgVVJMcyBpbiBld3cKICAgICAgICAgICA7OyAoYnVnIzY3NzY0KS4KLQkgIChzZXRxIGFs dCAoaWYgYWx0IChzdHJpbmctdHJpbSBhbHQpICIqIikpCisgICAgICAgICAgKHNldHEgYWx0 IChzdHJpbmctdHJpbSAob3IgYWx0ICIiKSkpCisgICAgICAgICAgKHdoZW4gKGxlbmd0aD0g YWx0IDApIChzZXRxIGFsdCAiKiIpKQogCSAgOzsgV2hlbiBpbnNlcnRpbmcgYmlnLWlzaCBw aWN0dXJlcywgcHV0IHRoZW0gYXQgdGhlCiAJICA7OyBiZWdpbm5pbmcgb2YgdGhlIGxpbmUu CiAJICAobGV0ICgoaW5saW5lIChzaHItLWlubGluZS1pbWFnZS1wIGltYWdlKSkpCkBAIC0x MTUzLDcgKzExNTgsMTEgQEAgc2hyLXB1dC1pbWFnZQogCQkoaW5zZXJ0ICJcbiIpKQogCSAg ICAobGV0ICgoaW1hZ2UtcG9zIChwb2ludCkpKQogCSAgICAgIChpZiAoZXEgc2l6ZSAnb3Jp Z2luYWwpCi0JCSAgKGluc2VydC1zbGljZWQtaW1hZ2UgaW1hZ2UgYWx0IG5pbCAyMCAxKQor ICAgICAgICAgICAgICAgICAgOzsgTm9ybWFsbHksIHdlIHRyeSB0byBrZWVwIHRoZSBidWZm ZXIgdGV4dCB0aGUgc2FtZQorICAgICAgICAgICAgICAgICAgOzsgYnkgcHJlc2VydmluZyBB TFQuICBXaXRoIGEgc2xpY2VkIGltYWdlLCB3ZSBoYXZlIHRvCisgICAgICAgICAgICAgICAg ICA7OyByZXBlYXQgdGhlIHRleHQgZm9yIGVhY2ggbGluZSwgc28gd2UgY2FuJ3QgZG8gdGhh dC4KKyAgICAgICAgICAgICAgICAgIDs7IEp1c3QgdXNlICIqIiBmb3IgdGhlIHN0cmluZyB0 byBpbnNlcnQgaW5zdGVhZC4KKyAgICAgICAgICAgICAgICAgIChpbnNlcnQtc2xpY2VkLWlt YWdlIGltYWdlICIqIiBuaWwgMjAgMSkKIAkJKGluc2VydC1pbWFnZSBpbWFnZSBhbHQpKQog CSAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eSBzdGFydCAocG9pbnQpICdpbWFnZS1zaXplIHNp emUpCiAJICAgICAgKHdoZW4gKGFuZCAobm90IGlubGluZSkgc2hyLW1heC1pbmxpbmUtaW1h Z2Utc2l6ZSkKQEAgLTE4NTQsMTcgKzE4NjMsMTIgQEAgc2hyLXRhZy1pbWcKIAkgICAgKGxl dCAoKGZpbGUgKHVybC1jYWNoZS1jcmVhdGUtZmlsZW5hbWUgdXJsKSkpCiAJICAgICAgKHdo ZW4gKGZpbGUtZXhpc3RzLXAgZmlsZSkKIAkJKGRlbGV0ZS1maWxlIGZpbGUpKSkpCi0gICAg ICAgICAgKHdoZW4gKGltYWdlLXR5cGUtYXZhaWxhYmxlLXAgJ3N2ZykKLSAgICAgICAgICAg IChpbnNlcnQtaW1hZ2UKLSAgICAgICAgICAgICAoc2hyLW1ha2UtcGxhY2Vob2xkZXItaW1h Z2UgZG9tKQotICAgICAgICAgICAgIChvciAoc3RyaW5nLXRyaW0gYWx0KSAiIikpKQotCSAg OzsgUGFyYWRveGljYWxseSB0aGlzIHNwYWNlIGNhdXNlcyBzaHIgbm90IHRvIGluc2VydCBz cGFjZXMgYWZ0ZXIKLQkgIDs7IGlubGluZSBpbWFnZXMuIFNpbmNlIHRoZSBpbWFnZSBpcyB0 ZW1wb3JhcnkgaXQgc2VlbSBsaWtlIHRoZXJlCi0JICA7OyBzaG91bGQgYmUgbm8gZG93bnNp ZGUgdG8gbm90IGluc2VydGluZyBpdCBidXQgc2luY2UgSSBkb24ndAotCSAgOzsgdW5kZXJz dGFuZCB0aGUgY29kZSB3ZWxsIGFuZCBmb3IgdGhlIHNha2Ugb2YgYmFja3dhcmQgY29tcGF0 aWJpbGl0eQotCSAgOzsgd2UgcHJlc2VydmUgaXQgdW5sZXNzIHVzZXIgaGFzIHNldCBgc2hy LW1heC1pbmxpbmUtaW1hZ2Utc2l6ZScuCi0gICAgICAgICAgKHVubGVzcyBzaHItbWF4LWlu bGluZS1pbWFnZS1zaXplCi0JICAgICAgKGluc2VydCAiICIpKQorICAgICAgICAgIChpZiAo aW1hZ2UtdHlwZS1hdmFpbGFibGUtcCAnc3ZnKQorICAgICAgICAgICAgICAoaW5zZXJ0LWlt YWdlCisgICAgICAgICAgICAgICAoc2hyLW1ha2UtcGxhY2Vob2xkZXItaW1hZ2UgZG9tKQor ICAgICAgICAgICAgICAgKG9yIChzdHJpbmctdHJpbSBhbHQpICIiKSkKKyAgICAgICAgICAg IDs7IE5vIFNWRyBzdXBwb3J0LiAgSnVzdCB1c2UgYSBzcGFjZSBhcyBvdXIgcGxhY2Vob2xk ZXIuCisgICAgICAgICAgICAoaW5zZXJ0ICIgIikpCiAJICAodXJsLXF1ZXVlLXJldHJpZXZl CiAgICAgICAgICAgIHVybCAjJ3Noci1pbWFnZS1mZXRjaGVkCiAJICAgKGxpc3QgKGN1cnJl bnQtYnVmZmVyKSBzdGFydCAoc2V0LW1hcmtlciAobWFrZS1tYXJrZXIpIChwb2ludCkpCmRp ZmYgLS1naXQgYS90ZXN0L2xpc3AvbmV0L3Noci10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9uZXQv c2hyLXRlc3RzLmVsCmluZGV4IDE3MTM4MDUzNDUwLi44NGQwMzA1OGRjOCAxMDA2NDQKLS0t IGEvdGVzdC9saXNwL25ldC9zaHItdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL25ldC9zaHIt dGVzdHMuZWwKQEAgLTI5LDYgKzI5LDIyIEBACiAKIChkZWNsYXJlLWZ1bmN0aW9uIGxpYnht bC1wYXJzZS1odG1sLXJlZ2lvbiAieG1sLmMiKQogCisoZGVmdmFyIHNoci10ZXN0LS1tYXgt d2FpdC10aW1lIDUKKyAgIlRoZSBtYXhpbXVtIGFtb3VudCBvZiB0aW1lIHRvIHdhaXQgZm9y IGEgY29uZGl0aW9uIHRvIHJlc29sdmUsIGluIHNlY29uZHMuCitTZWUgYHNoci10ZXN0LXdh aXQtZm9yJy4iKQorCisoZGVmdW4gc2hyLXRlc3Qtd2FpdC1mb3IgKHByZWRpY2F0ZSAmb3B0 aW9uYWwgbWVzc2FnZSkKKyAgIldhaXQgdW50aWwgUFJFRElDQVRFIHJldHVybnMgbm9uLW5p bC4KK0lmIHRoaXMgdGFrZXMgbG9uZ2VyIHRoYW4gYHNoci10ZXN0LS1tYXgtd2FpdC10aW1l JywgcmFpc2UgYW4gZXJyb3IuCitNRVNTQUdFIGlzIGFuIG9wdGlvbmFsIG1lc3NhZ2UgdG8g dXNlIGlmIHRoaXMgdGltZXMgb3V0LiIKKyAgKGxldCAoKHN0YXJ0IChjdXJyZW50LXRpbWUp KQorICAgICAgICAobWVzc2FnZSAob3IgbWVzc2FnZSAidGltZWQgb3V0IHdhaXRpbmcgZm9y IGNvbmRpdGlvbiIpKSkKKyAgICAod2hpbGUgKG5vdCAoZnVuY2FsbCBwcmVkaWNhdGUpKQor ICAgICAgKHdoZW4gKD4gKGZsb2F0LXRpbWUgKHRpbWUtc2luY2Ugc3RhcnQpKQorICAgICAg ICAgICAgICAgc2hyLXRlc3QtLW1heC13YWl0LXRpbWUpCisgICAgICAgIChlcnJvciBtZXNz YWdlKSkKKyAgICAgIChzaXQtZm9yIDAuMSkpKSkKKwogKGRlZnVuIHNoci10ZXN0LS1yZW5k ZXJpbmctY2hlY2sgKG5hbWUgJm9wdGlvbmFsIGNvbnRleHQpCiAgICJSZW5kZXIgTkFNRS5o dG1sIGFuZCBjb21wYXJlIGl0IHRvIE5BTUUudHh0LgogUmFpc2UgYSB0ZXN0IGZhaWx1cmUg aWYgdGhlIHJlbmRlcmVkIGJ1ZmZlciBkb2VzIG5vdCBtYXRjaCBOQU1FLnR4dC4KQEAgLTY4 LDYgKzg0LDggQEAgc2hyLXRlc3QtLXJlbmRlcmluZy1leHRyYS1jb25maWdzCiBUaGUgYHJl bmRlcmluZycgdGVzdGNhc2Ugd2lsbCB0ZXN0IE5BTUUgb25jZSB3aXRob3V0IGFsdGVyaW5n IGFueQogc2V0dGluZ3MsIHRoZW4gb25jZSBtb3JlIGZvciBlYWNoIChPUFRJT04gLiBWQUxV RSkgcGFpci4iKQogCis7OzsgVGVzdHM6CisKIChlcnQtZGVmdGVzdCByZW5kZXJpbmcgKCkK ICAgKHNraXAtdW5sZXNzIChmYm91bmRwICdsaWJ4bWwtcGFyc2UtaHRtbC1yZWdpb24pKQog ICAoZG9saXN0IChmaWxlIChkaXJlY3RvcnktZmlsZXMgKGVydC1yZXNvdXJjZS1kaXJlY3Rv cnkpIG5pbCAiXFwuaHRtbFxcJyIpKQpAQCAtMTE0LDYgKzEzMiw0NiBAQCBzaHItc3Jjc2V0 CiAgIChzaG91bGQgKGVxdWFsIChzaHItLXBhcnNlLXNyY3NldCAiaHR0cHM6Ly9leGFtcGxl Lm9yZy8xLDJcblxuIDEwdyAsIGh0dHBzOi8vZXhhbXBsZS5vcmcvMiAyMHcgICAgICAiKQog CSAgICAgICAgICcoKCJodHRwczovL2V4YW1wbGUub3JnLzIiIDIwKSAoImh0dHBzOi8vZXhh bXBsZS5vcmcvMSwyIiAxMCkpKSkpCiAKKyhlcnQtZGVmdGVzdCBzaHItdGVzdC96b29tLWlt YWdlICgpCisgICJUZXN0IHRoYXQgYHNoci16b29tLWltYWdlJyBwcm9wZXJseSByZXBsYWNl cyB0aGUgb3JpZ2luYWwgaW1hZ2UuIgorICAobGV0ICgoaW1hZ2UgKGV4cGFuZC1maWxlLW5h bWUgImRhdGEvaW1hZ2UvYmxhbmstMTAweDIwMC5wbmciCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoZ2V0ZW52ICJFTUFDU19URVNUX0RJUkVDVE9SWSIpKSkpCisgICAg KGRvbGlzdCAoYWx0ICcobmlsICIiICJub3RoaW5nIHRvIHNlZSBoZXJlIikpCisgICAgICAo d2l0aC10ZW1wLWJ1ZmZlcgorICAgICAgICAoZXJ0LWluZm8gKChmb3JtYXQgImltYWdlIHdp dGggYWx0PSVTIiBhbHQpKQorICAgICAgICAgIChsZXQgKChhdHRycyAoaWYgYWx0IChmb3Jt YXQgIiBhbHQ9XCIlc1wiIiBhbHQpICIiKSkpCisgICAgICAgICAgICAoaW5zZXJ0IChmb3Jt YXQgIjxpbWcgc3JjPVwiZmlsZTovLyVzXCIgJXMiIGltYWdlIGF0dHJzKSkpCisgICAgICAg ICAgKGNsLWxldGYqICg7OyBQcmV0ZW5kIHdlJ3JlIGEgZ3JhcGhpY2FsIGRpc3BsYXkuCisg ICAgICAgICAgICAgICAgICAgICAoKHN5bWJvbC1mdW5jdGlvbiAnZGlzcGxheS1ncmFwaGlj LXApICMnYWx3YXlzKQorICAgICAgICAgICAgICAgICAgICAgKChzeW1ib2wtZnVuY3Rpb24g J3VybC1xdWV1ZS1yZXRyaWV2ZSkKKyAgICAgICAgICAgICAgICAgICAgICAobGFtYmRhICgm cmVzdCBhcmdzKQorICAgICAgICAgICAgICAgICAgICAgICAgKGFwcGx5ICMncnVuLWF0LXRp bWUgMCBuaWwgIyd1cmwtcmV0cmlldmUgYXJncykpKQorICAgICAgICAgICAgICAgICAgICAg KHB1dC1pbWFnZS1jYWxscyAwKQorICAgICAgICAgICAgICAgICAgICAgKHNoci1wdXQtaW1h Z2UtZnVuY3Rpb24KKyAgICAgICAgICAgICAgICAgICAgICAobGFtYmRhICgmcmVzdCBhcmdz KQorICAgICAgICAgICAgICAgICAgICAgICAgKGNsLWluY2YgcHV0LWltYWdlLWNhbGxzKQor ICAgICAgICAgICAgICAgICAgICAgICAgKGFwcGx5ICMnc2hyLXB1dC1pbWFnZSBhcmdzKSkp CisgICAgICAgICAgICAgICAgICAgICAoc2hyLXdpZHRoIDgwKQorICAgICAgICAgICAgICAg ICAgICAgKHNoci11c2UtZm9udHMgbmlsKQorICAgICAgICAgICAgICAgICAgICAgKHNoci1p bWFnZS1hbmltYXRlIG5pbCkKKyAgICAgICAgICAgICAgICAgICAgIChkb20gKGxpYnhtbC1w YXJzZS1odG1sLXJlZ2lvbiAocG9pbnQtbWluKSAocG9pbnQtbWF4KSkpKQorICAgICAgICAg ICAgOzsgUmVuZGVyIHRoZSBkb2N1bWVudC4KKyAgICAgICAgICAgIChlcmFzZS1idWZmZXIp CisgICAgICAgICAgICAoc2hyLWluc2VydC1kb2N1bWVudCBkb20pCisgICAgICAgICAgICAo c2hyLXRlc3Qtd2FpdC1mb3IgKGxhbWJkYSAoKSAoPSBwdXQtaW1hZ2UtY2FsbHMgMSkpKQor ICAgICAgICAgICAgOzsgTm93IHpvb20gdGhlIGltYWdlLgorICAgICAgICAgICAgKGdvdG8t Y2hhciAocG9pbnQtbWluKSkKKyAgICAgICAgICAgIChzaHItem9vbS1pbWFnZSkKKyAgICAg ICAgICAgIChzaHItdGVzdC13YWl0LWZvciAobGFtYmRhICgpICg9IHB1dC1pbWFnZS1jYWxs cyAyKSkpCisgICAgICAgICAgICA7OyBDaGVjayB0aGF0IHdlIGdvdCBhIHNsaWNlZCBpbWFn ZS4KKyAgICAgICAgICAgIChsZXQgKChzbGljZS1jb3VudCAwKSkKKyAgICAgICAgICAgICAg KGdvdG8tY2hhciAocG9pbnQtbWluKSkKKyAgICAgICAgICAgICAgKHdoaWxlLWxldCAoKHBv cyAobmV4dC1zaW5nbGUtcHJvcGVydHktY2hhbmdlIChwb2ludCkgJ2Rpc3BsYXkpKSkKKyAg ICAgICAgICAgICAgICAod2hlbi1sZXQgKChkaXNwbGF5IChnZXQtdGV4dC1wcm9wZXJ0eSBw b3MgJ2Rpc3BsYXkpKSkKKyAgICAgICAgICAgICAgICAgIChjbC1pbmNmIHNsaWNlLWNvdW50 KSkKKyAgICAgICAgICAgICAgICAoZ290by1jaGFyIHBvcykpCisgICAgICAgICAgICAgIChz aG91bGQgKD4gc2xpY2UtY291bnQgMSkpKSkpKSkpKQorCiAocmVxdWlyZSAnc2hyKQogCiA7 Ozsgc2hyLXRlc3RzLmVsIGVuZHMgaGVyZQotLSAKMi4yNS4xCgo= --------------QJlqmnJouEiSfHGX4bewtGMy-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 05:12:02 2024 Received: (at 71666) by debbugs.gnu.org; 22 Jun 2024 09:12:02 +0000 Received: from localhost ([127.0.0.1]:44418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKwmw-0000uR-1F for submit@debbugs.gnu.org; Sat, 22 Jun 2024 05:12:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKwmt-0000u7-EN for 71666@debbugs.gnu.org; Sat, 22 Jun 2024 05:12:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKwmn-0004de-Mz; Sat, 22 Jun 2024 05:11:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CjDgvh7hKb1Jl3Y1MzPl5rjFrdANxwF0xMB3ybRhFUA=; b=FCHscS0EradQ q7it/dfYHpI0jhx/cPeW+npnW94FEOg3sCQPk6DI9zxP0cg+6jV29rkUbONFy/9aQM1JhMQlYV8a7 JydaNat7/OoUg7nTAhOtj3fK9Y43eNdctVg8rJOUSIoowhPsAdP4btEkBE8Ds1rq7PSZ4FBTPbZOn A1k7pyOqzDHF45zgpPhnuLDY2HmEIsitT+Z0fhcs/CcfVExxY95AHGvQh0suhizn/I2wBHz9hjKJ+ L7bqx4OhsqV2C6/YxF6Pe1FnbuAAe9UwhPjR29/Un8pN3sIshrQTXz/9Gnbj1tUQj7vBSeYiV2dUF +FOaoxu/1i9/8gpH9+Avkw==; Date: Sat, 22 Jun 2024 12:11:45 +0300 Message-Id: <86frt5ibou.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> (message from Jim Porter on Wed, 19 Jun 2024 21:47:26 -0700) Subject: Re: bug#71666: 30.0.50; [PATCH] Fix zooming images with SHR References: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71666 Cc: 71666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 19 Jun 2024 21:47:26 -0700 > From: Jim Porter > > To reproduce this, start from "emacs -Q -f eww" and then go to fsf.org. > Move point over one of the larger images on the page, like the ones that > say "Featured" above them, and press Z ('shr-zoom-image'). The result is > that the image is duplicated, and the first slice gets pushed up onto > the previous line. > > Attached is a patch to fix this, with regression tests. I tried the recipe and the patch. While the patches shr behaves better than the unpatched, I don't see the image being zoomed, it stays at its original size. Do I need some optional library or external program for the zoom to happen? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 16:23:04 2024 Received: (at 71666) by debbugs.gnu.org; 22 Jun 2024 20:23:04 +0000 Received: from localhost ([127.0.0.1]:59161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL7GJ-0002v7-J0 for submit@debbugs.gnu.org; Sat, 22 Jun 2024 16:23:04 -0400 Received: from mail-oi1-f172.google.com ([209.85.167.172]:60915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL7GH-0002uG-Hb for 71666@debbugs.gnu.org; Sat, 22 Jun 2024 16:23:01 -0400 Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3d22378c59eso1750177b6e.1 for <71666@debbugs.gnu.org>; Sat, 22 Jun 2024 13:23:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719087716; x=1719692516; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=UOFaiIbnBBuaNeZbWE/GRG7JaYqzX0ouJo+CkVw6DXA=; b=bR2NFSMCd87N1BuBmt7gFhtWJ299T3YR+jfsZ/1jZ5EH7fbJd4mdpM+ukyHHicw9gD /9lrjvbIN1d2uSOuHR3ltQ0gt2bZ82XI9BJf5VgLcRBeirFvbJDdlU0c0K5SX7vH3+h3 lZNTUVbgErB1JsQ5Tg+r7TWKav/r3PsJdy/idPZTdsZVy06OXOvgZ+CG0hL88xOqkadm n043CD2eTbEsIFlQukvD9EoV+1bZiYE94FDxBZTkzu8Yqn0oXoAssfCP7MUipWZgknvJ elM1MG5BzCGGznyLf0s/MBX6bt0hj1HQqjkS6nX3krcmeWlZzhLd3irg+swkym8CGSYd /TfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719087716; x=1719692516; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UOFaiIbnBBuaNeZbWE/GRG7JaYqzX0ouJo+CkVw6DXA=; b=S7x2ld9Qi/JRgFjOrkR2z4LMH3GqZ4H3N0flDqR5uhVPTEXNL7Bx2BwmRKxz1O+quh xCs26mUTLsEC2lze07iBQi7AVetEuZs+MoXp09SrO6yxisOoOFlBMH66ARDWKb4nCUfd UgXmCweidZclRtOGip1Uq+NNoQ+/tjuYS6bTf/OWFfZ93A+FEGBomhV4ftizNmOCyHqy Y4x5y/1HXsTcbz3KYz254b8wMK8GeRWTA1aVaTqCywR0EjT5TBERSDciprd9KxeQwqPZ 8lO+EZnrP2CG0dYGCBPn6lMX89BS/DaydVwi8F/xNYzYBzoCsc0+58JZeLfwBm8RJ6y6 D/lQ== X-Gm-Message-State: AOJu0Yw7Fun25B4EBKH7uUttO2q7Ziv7FEC/Ig0iyiXZhQLF1TLLv3C8 o/izaaVDA2kSogyxp6thPD1gvHRdhlJxplOyCQ1gr+h4wyvdnttB X-Google-Smtp-Source: AGHT+IHkImwyFgs7s3T1/sDFUXc/l4N51N7UHScJab+mSeqkBiZ5GloX86KIMnRbwwYl7lly2wKesw== X-Received: by 2002:a05:6808:1797:b0:3d2:1a29:c77f with SMTP id 5614622812f47-3d545a6e574mr1084800b6e.43.1719087714699; Sat, 22 Jun 2024 13:21:54 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-706771da083sm67864b3a.52.2024.06.22.13.21.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Jun 2024 13:21:54 -0700 (PDT) Message-ID: Date: Sat, 22 Jun 2024 13:21:53 -0700 MIME-Version: 1.0 Subject: Re: bug#71666: 30.0.50; [PATCH] Fix zooming images with SHR Content-Language: en-US To: Eli Zaretskii References: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> <86frt5ibou.fsf@gnu.org> From: Jim Porter In-Reply-To: <86frt5ibou.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71666 Cc: 71666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 6/22/2024 2:11 AM, Eli Zaretskii wrote: > I tried the recipe and the patch. While the patches shr behaves > better than the unpatched, I don't see the image being zoomed, it > stays at its original size. Do I need some optional library or > external program for the zoom to happen? Ah right, that would have been helpful for me to mention in the original message: by default, SHR scales down images that are more than 70% of the width (or height) of the window. So if you narrow your window to 40 columns or so and reload the page in EWW, the larger images should be scaled down. Then putting point on one and pressing "z" should scale it up to the original size. Pressing "z" again should scale the image back down. As an aside, there are actually *three* states for image scaling in SHR: default, original, and full, and 'shr-zoom-image' cycles through them in that order. As far as I can tell from the code, "default" and "full" are the same though. I haven't figured out whether that's a bug (and if so, what the bug is), or whether I'm just misunderstanding something. I'll try to fix that later (if only by adding documentation), once I know what's going on. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 19:06:02 2024 Received: (at 71666) by debbugs.gnu.org; 22 Jun 2024 23:06:02 +0000 Received: from localhost ([127.0.0.1]:35256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL9o1-000808-Qh for submit@debbugs.gnu.org; Sat, 22 Jun 2024 19:06:02 -0400 Received: from mail-pj1-f47.google.com ([209.85.216.47]:53341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL9nz-0007zc-Gr for 71666@debbugs.gnu.org; Sat, 22 Jun 2024 19:06:00 -0400 Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2c84e789065so374999a91.2 for <71666@debbugs.gnu.org>; Sat, 22 Jun 2024 16:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719097493; x=1719702293; darn=debbugs.gnu.org; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=1xXMOSrnpDC8bPilN7uqgBUDZ8SGApNW/UPQdb6L5is=; b=jwpvlCZoMrZLPCdTPSuPnL2S5s0ZRvRMwQ+KHQvcNWpUWY4avU6TJdt3C2Bch6bldd fHXivH4qAb6c43Gp4+/n7oLMqRXH/jSw09spF75ZPv3wfSWqeNxqBKrSyxr/yecFZuNd R30EE+5Nl40uFDNqameD1tpRRjVPwAmWSa9pXnxcW+pHEqcje2M0q8q9EoQGaXsRcFpu vDvsAVqbOl4wnmgk2vb2S4zYrZ+/NaTTTni3K9RK7xRr5qSrgEzV5bYQNQaaD0iITZSr zJqR3FORqf7BhgjptbdMcolHfSHRC+zcDeZF5m8xc0PNnGDrEckVJkiGg7A469avcyBS 3w5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719097493; x=1719702293; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=1xXMOSrnpDC8bPilN7uqgBUDZ8SGApNW/UPQdb6L5is=; b=g0jke1BbinxkYUh9wZVWjrO8V/+IBfnSSMvWSWaOdN8mOB0HOrgf/EJHAJqTLmbVw3 oK5fA0L4ZgXQVzzdFU1iyN/PO1POSsVQDjAuYxKqvNrGQ0G+J4i45wREh1eSJGdVl5DR CpHBWVsUrczAB5u6cRcNtlAITDFMAS+Cpyipun2C0gpDA7cB1W3CRatTkGXqt2agfX43 l+Aa2bmZ32yt5fVUPPJJUAAicoOcYRbxNCvBzt+KG4jB+HHHsv3jLXzU9GSybanHozRm Emvi7ClsFbNkPptLl25h/pX37PJTW5m9ctPOtBz0InULnsIsa6cx8IKr+roSv7A/tp63 UfIQ== X-Gm-Message-State: AOJu0Yz1jwkB66gkCfod6+FEBPsyQj+LJDrbcpGPkbCTu23yx1WN5th0 n/DdyiBn/HygTLxbcIPvthEzViZ3ofi/h5i05AmfwmR60mPE9PNU X-Google-Smtp-Source: AGHT+IFz6+YGTZwsIo3eg3xeWwialzV3Yh7d/i4ormPM+hmbL2JhvnR0XpWOnNkRR587MVGevcnUGA== X-Received: by 2002:a17:90a:fa96:b0:2c7:bade:25be with SMTP id 98e67ed59e1d1-2c8612a2294mr532749a91.14.1719097493314; Sat, 22 Jun 2024 16:04:53 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f9ebbb29c6sm35825925ad.263.2024.06.22.16.04.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Jun 2024 16:04:52 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------xpVgfLQeI8TlA79BiaUkTb50" Message-ID: <7ee8d7ac-93d5-4ce3-488a-2ece09f659b7@gmail.com> Date: Sat, 22 Jun 2024 16:04:51 -0700 MIME-Version: 1.0 Subject: Re: bug#71666: 30.0.50; [PATCH] Fix zooming images with SHR Content-Language: en-US From: Jim Porter To: Eli Zaretskii References: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> <86frt5ibou.fsf@gnu.org> In-Reply-To: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71666 Cc: 71666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------xpVgfLQeI8TlA79BiaUkTb50 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Here's an improved patch with a better regression test. --------------xpVgfLQeI8TlA79BiaUkTb50 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-zooming-images-in-SHR.patch" Content-Disposition: attachment; filename="0001-Fix-zooming-images-in-SHR.patch" Content-Transfer-Encoding: base64 RnJvbSAzYzdkMjhiNTk0ODgzZjVkOTM5ZjVhYzI1MWM3Mzc1MGM4MGRiOTI3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgMTkgSnVuIDIwMjQgMjA6NTk6NTkgLTA3MDAKU3ViamVjdDogW1BB VENIXSBGaXggem9vbWluZyBpbWFnZXMgaW4gU0hSCgpQcmV2aW91c2x5LCBmb3IgaW1hZ2Vz IHdpdGggbm8gYWx0LXRleHQsIHRoZSB6b29tZWQgaW1hZ2Ugd291bGRuJ3QgZ2V0CnByb3Bl cmx5IGluc2VydGVkLiAgRm9yIGltYWdlcyB3aXRoIGFsdC10ZXh0LCBib3RoIHRoZSB6b29t ZWQgYW5kCnVuem9vbWVkIGltYWdlIHdvdWxkIGJlIGRpc3BsYXllZCBhdCBvbmNlIChidWcj NzE2NjYpLgoKKiBsaXNwL25ldC9zaHIuZWwgKHNoci16b29tLWltYWdlKTogUmVpbXBsZW1l bnQgdXNpbmcKJ25leHQvcHJldmlvdXMtc2luZ2xlLXByb3BlcnR5LWNoYW5nZScsIGFuZCBk b24ndCBib3RoZXIgZGVsZXRpbmcgYW55IG9mCnRoZSB0ZXh0Lgooc2hyLWltYWdlLWZldGNo ZWQpOiBEb24ndCBnaXZlIHNsaWNlZCBpbWFnZXMgYSBmYWNlLgooc2hyLXB1dC1pbWFnZSk6 IEVuc3VyZSB3ZSBhbHdheXMgaGF2ZSBhIG5vbi1lbXB0eSBzdHJpbmcgdG8gcHV0IHRoZQpp bWFnZSBvbi4gIEZvciBzbGljZWQgaW1hZ2VzLCBqdXN0IHVzZSAiKiIsIHNpbmNlIHdlJ2xs IHJlcGVhdCBpdCwgc28gd2UKY2FuJ3QgcHJlc2VydmUgdGhlIG9yaWdpbmFsIGJ1ZmZlciB0 ZXh0IGV4YWN0bHkgYW55d2F5Lgooc2hyLXRhZy1pbWcpOiBNb3ZlIHRoZSBwbGFjZWhvbGRl ciBzcGFjZSBpbnNlcnRpb24gd2hlcmUgaXQgc2hvdWxkIGJlCmFuZCBleHBsYWluIHdoYXQg aXQncyBkb2luZy4KCiogdGVzdC9saXNwL25ldC9zaHItdGVzdHMuZWwgKHNoci10ZXN0LS1t YXgtd2FpdC10aW1lKQooc2hyLXRlc3Qtd2FpdC1mb3IpOiBOZXcgaGVscGVyIGZ1bmN0aW9u cy4KKHNoci10ZXN0L3pvb20taW1hZ2UpOiBOZXcgdGVzdC4KLS0tCiBsaXNwL25ldC9zaHIu ZWwgICAgICAgICAgICB8IDk4ICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0tCiB0ZXN0L2xpc3AvbmV0L3Noci10ZXN0cy5lbCB8IDYyICsrKysrKysrKysrKysrKysr KysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxMTMgaW5zZXJ0aW9ucygrKSwgNDcgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9uZXQvc2hyLmVsIGIvbGlzcC9uZXQvc2hyLmVs CmluZGV4IDE0YjNmN2FhMTYzLi5lMGUxOWE1ZjA1OCAxMDA2NDQKLS0tIGEvbGlzcC9uZXQv c2hyLmVsCisrKyBiL2xpc3AvbmV0L3Noci5lbApAQCAtNjAwLDM4ICs2MDAsMzQgQEAgc2hy LWluc2VydC1pbWFnZQogCQkgICAgdCkpKSkKIAogKGRlZnVuIHNoci16b29tLWltYWdlICgp Ci0gICJUb2dnbGUgdGhlIGltYWdlIHNpemUuCi1UaGUgc2l6ZSB3aWxsIGJlIHJvdGF0ZWQg YmV0d2VlbiB0aGUgZGVmYXVsdCBzaXplLCB0aGUgb3JpZ2luYWwKLXNpemUsIGFuZCBmdWxs LWJ1ZmZlciBzaXplLiIKKyAgIkN5Y2xlIHRoZSBpbWFnZSBzaXplLgorVGhlIHNpemUgd2ls bCBjeWNsZSB0aHJvdWdoIHRoZSBkZWZhdWx0IHNpemUsIHRoZSBvcmlnaW5hbCBzaXplLCBh bmQKK2Z1bGwtYnVmZmVyIHNpemUuIgogICAoaW50ZXJhY3RpdmUpCi0gIChsZXQgKCh1cmwg KGdldC10ZXh0LXByb3BlcnR5IChwb2ludCkgJ2ltYWdlLXVybCkpCi0JKHNpemUgKGdldC10 ZXh0LXByb3BlcnR5IChwb2ludCkgJ2ltYWdlLXNpemUpKQotCShidWZmZXItcmVhZC1vbmx5 IG5pbCkpCisgIChsZXQgKCh1cmwgKGdldC10ZXh0LXByb3BlcnR5IChwb2ludCkgJ2ltYWdl LXVybCkpKQogICAgIChpZiAobm90IHVybCkKIAkobWVzc2FnZSAiTm8gaW1hZ2UgdW5kZXIg cG9pbnQiKQotICAgICAgOzsgRGVsZXRlIHRoZSBvbGQgcGljdHVyZS4KLSAgICAgICh3aGls ZSAoZ2V0LXRleHQtcHJvcGVydHkgKHBvaW50KSAnaW1hZ2UtdXJsKQotCShmb3J3YXJkLWNo YXIgLTEpKQotICAgICAgKGZvcndhcmQtY2hhciAxKQotICAgICAgKGxldCAoKHN0YXJ0IChw b2ludCkpKQotCSh3aGlsZSAoZ2V0LXRleHQtcHJvcGVydHkgKHBvaW50KSAnaW1hZ2UtdXJs KQotCSAgKGZvcndhcmQtY2hhciAxKSkKLQkoZm9yd2FyZC1jaGFyIC0xKQotCShwdXQtdGV4 dC1wcm9wZXJ0eSBzdGFydCAocG9pbnQpICdkaXNwbGF5IG5pbCkKLQkod2hlbiAoPiAoLSAo cG9pbnQpIHN0YXJ0KSAyKQotCSAgKGRlbGV0ZS1yZWdpb24gc3RhcnQgKDEtIChwb2ludCkp KSkpCi0gICAgICAobWVzc2FnZSAiSW5zZXJ0aW5nICVzLi4uIiB1cmwpCi0gICAgICAodXJs LXJldHJpZXZlIHVybCAjJ3Noci1pbWFnZS1mZXRjaGVkCi0JCSAgICAobGlzdCAoY3VycmVu dC1idWZmZXIpICgxLSAocG9pbnQpKSAocG9pbnQtbWFya2VyKQotCQkJICAobGlzdCAoY29u cyAnc2l6ZQotCQkJCSAgICAgIChjb25kICgob3IgKGVxIHNpemUgJ2RlZmF1bHQpCi0JCQkJ CQkgKG51bGwgc2l6ZSkpCi0JCQkJCSAgICAgJ29yaWdpbmFsKQotCQkJCQkgICAgKChlcSBz aXplICdvcmlnaW5hbCkKLQkJCQkJICAgICAnZnVsbCkKLQkJCQkJICAgICgoZXEgc2l6ZSAn ZnVsbCkKLQkJCQkJICAgICAnZGVmYXVsdCkpKSkpCi0JCSAgICB0KSkpKQorICAgICAgKGxl dCogKChlbmQgKG9yIChuZXh0LXNpbmdsZS1wcm9wZXJ0eS1jaGFuZ2UgKHBvaW50KSAnaW1h Z2UtdXJsKQorICAgICAgICAgICAgICAgICAgICAgIChwb2ludC1tYXgpKSkKKyAgICAgICAg ICAgICAoc3RhcnQgKG9yIChwcmV2aW91cy1zaW5nbGUtcHJvcGVydHktY2hhbmdlIGVuZCAn aW1hZ2UtdXJsKQorICAgICAgICAgICAgICAgICAgICAgICAgKHBvaW50LW1pbikpKQorICAg ICAgICAgICAgIChzaXplIChnZXQtdGV4dC1wcm9wZXJ0eSAocG9pbnQpICdpbWFnZS1zaXpl KSkKKyAgICAgICAgICAgICAobmV4dC1zaXplIChjb25kICgob3IgKGVxIHNpemUgJ2RlZmF1 bHQpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChudWxsIHNpemUpKQor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdvcmlnaW5hbCkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICgoZXEgc2l6ZSAnb3JpZ2luYWwpCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJ2Z1bGwpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAoKGVxIHNpemUgJ2Z1bGwpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2Rl ZmF1bHQpKSkKKyAgICAgICAgICAgICAoYnVmZmVyLXJlYWQtb25seSBuaWwpKQorICAgICAg ICA7OyBEZWxldGUgdGhlIG9sZCBwaWN0dXJlLgorICAgICAgICAocHV0LXRleHQtcHJvcGVy dHkgc3RhcnQgZW5kICdkaXNwbGF5IG5pbCkKKyAgICAgICAgKG1lc3NhZ2UgIkluc2VydGlu ZyAlcy4uLiIgdXJsKQorICAgICAgICAodXJsLXJldHJpZXZlIHVybCAjJ3Noci1pbWFnZS1m ZXRjaGVkCisgICAgICAgICAgICAgICAgICAgICAgYCgsKGN1cnJlbnQtYnVmZmVyKSAsc3Rh cnQKKyAgICAgICAgICAgICAgICAgICAgICAgICwoc2V0LW1hcmtlciAobWFrZS1tYXJrZXIp IGVuZCkKKyAgICAgICAgICAgICAgICAgICAgICAgICgoc2l6ZSAuICxuZXh0LXNpemUpKSkK KyAgICAgICAgICAgICAgICAgICAgICB0KSkpKSkKIAogOzs7IFV0aWxpdHkgZnVuY3Rpb25z LgogCkBAIC0xMDczLDExICsxMDY5LDE5IEBAIHNoci1pbWFnZS1mZXRjaGVkCiAJCSAgKGRl bGV0ZS1yZWdpb24gc3RhcnQgZW5kKQogCQkgIChnb3RvLWNoYXIgc3RhcnQpCiAJCSAgKGZ1 bmNhbGwgc2hyLXB1dC1pbWFnZS1mdW5jdGlvbiBkYXRhIGFsdCBmbGFncykKLQkJICAod2hp bGUgcHJvcGVydGllcwotCQkgICAgKGxldCAoKHR5cGUgKHBvcCBwcm9wZXJ0aWVzKSkKLQkJ CSAgKHZhbHVlIChwb3AgcHJvcGVydGllcykpKQotCQkgICAgICAodW5sZXNzIChtZW1xIHR5 cGUgJyhkaXNwbGF5IGltYWdlLXNpemUpKQotCQkJKHB1dC10ZXh0LXByb3BlcnR5IHN0YXJ0 IChwb2ludCkgdHlwZSB2YWx1ZSkpKSkpKSkpKSkpCisgICAgICAgICAgICAgICAgICAobGV0 ICgoc2xpY2VkLWltYWdlIChhc3NxICdzbGljZSAoZ2V0LXRleHQtcHJvcGVydHkKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGFydCAn ZGlzcGxheSkpKSkKKyAgICAgICAgICAgICAgICAgICAgKHdoaWxlIHByb3BlcnRpZXMKKyAg ICAgICAgICAgICAgICAgICAgICAobGV0ICgodHlwZSAocG9wIHByb3BlcnRpZXMpKQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICh2YWx1ZSAocG9wIHByb3BlcnRpZXMpKSkKKyAg ICAgICAgICAgICAgICAgICAgICAgICh1bmxlc3MgKG9yIChtZW1xIHR5cGUgJyhkaXNwbGF5 IGltYWdlLXNpemUpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsg U2xpY2VkIGltYWdlcyBzaG91bGRuJ3QgaGF2ZSBhCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICA7OyBmYWNlOyBpZiB0aGUgaW1hZ2UgaXMgYSBsaW5rLAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgd2UnZCBnZXQgdW5kZXJsaW5lcyBv biBldmVyeQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgc2xpY2Uh CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYW5kIHNsaWNlZC1pbWFn ZSAoZXEgdHlwZSAnZmFjZSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAocHV0LXRl eHQtcHJvcGVydHkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXJ0IChwb2ludCkg dHlwZSB2YWx1ZSkpKSkpKSkpKSkpKQogICAgIChraWxsLWJ1ZmZlciBpbWFnZS1idWZmZXIp KSkKIAogKGRlZnVuIHNoci1pbWFnZS1mcm9tLWRhdGEgKGRhdGEpCkBAIC0xMTQ0LDcgKzEx NDgsOCBAQCBzaHItcHV0LWltYWdlCiAgICAgICAgICAgOzsgcHV0dGluZyBhbnkgc3BhY2Ug YWZ0ZXIgaW5saW5lIGltYWdlcy4KICAgICAgICAgICA7OyBBTFQgbWF5IGJlIG5pbCB3aGVu IHZpc2l0aW5nIGltYWdlIFVSTHMgaW4gZXd3CiAgICAgICAgICAgOzsgKGJ1ZyM2Nzc2NCku Ci0JICAoc2V0cSBhbHQgKGlmIGFsdCAoc3RyaW5nLXRyaW0gYWx0KSAiKiIpKQorICAgICAg ICAgIChzZXRxIGFsdCAoc3RyaW5nLXRyaW0gKG9yIGFsdCAiIikpKQorICAgICAgICAgICh3 aGVuIChsZW5ndGg9IGFsdCAwKSAoc2V0cSBhbHQgIioiKSkKIAkgIDs7IFdoZW4gaW5zZXJ0 aW5nIGJpZy1pc2ggcGljdHVyZXMsIHB1dCB0aGVtIGF0IHRoZQogCSAgOzsgYmVnaW5uaW5n IG9mIHRoZSBsaW5lLgogCSAgKGxldCAoKGlubGluZSAoc2hyLS1pbmxpbmUtaW1hZ2UtcCBp bWFnZSkpKQpAQCAtMTE1Myw3ICsxMTU4LDExIEBAIHNoci1wdXQtaW1hZ2UKIAkJKGluc2Vy dCAiXG4iKSkKIAkgICAgKGxldCAoKGltYWdlLXBvcyAocG9pbnQpKSkKIAkgICAgICAoaWYg KGVxIHNpemUgJ29yaWdpbmFsKQotCQkgIChpbnNlcnQtc2xpY2VkLWltYWdlIGltYWdlIGFs dCBuaWwgMjAgMSkKKyAgICAgICAgICAgICAgICAgIDs7IE5vcm1hbGx5LCB3ZSB0cnkgdG8g a2VlcCB0aGUgYnVmZmVyIHRleHQgdGhlIHNhbWUKKyAgICAgICAgICAgICAgICAgIDs7IGJ5 IHByZXNlcnZpbmcgQUxULiAgV2l0aCBhIHNsaWNlZCBpbWFnZSwgd2UgaGF2ZSB0bworICAg ICAgICAgICAgICAgICAgOzsgcmVwZWF0IHRoZSB0ZXh0IGZvciBlYWNoIGxpbmUsIHNvIHdl IGNhbid0IGRvIHRoYXQuCisgICAgICAgICAgICAgICAgICA7OyBKdXN0IHVzZSAiKiIgZm9y IHRoZSBzdHJpbmcgdG8gaW5zZXJ0IGluc3RlYWQuCisgICAgICAgICAgICAgICAgICAoaW5z ZXJ0LXNsaWNlZC1pbWFnZSBpbWFnZSAiKiIgbmlsIDIwIDEpCiAJCShpbnNlcnQtaW1hZ2Ug aW1hZ2UgYWx0KSkKIAkgICAgICAocHV0LXRleHQtcHJvcGVydHkgc3RhcnQgKHBvaW50KSAn aW1hZ2Utc2l6ZSBzaXplKQogCSAgICAgICh3aGVuIChhbmQgKG5vdCBpbmxpbmUpIHNoci1t YXgtaW5saW5lLWltYWdlLXNpemUpCkBAIC0xODU0LDE3ICsxODYzLDEyIEBAIHNoci10YWct aW1nCiAJICAgIChsZXQgKChmaWxlICh1cmwtY2FjaGUtY3JlYXRlLWZpbGVuYW1lIHVybCkp KQogCSAgICAgICh3aGVuIChmaWxlLWV4aXN0cy1wIGZpbGUpCiAJCShkZWxldGUtZmlsZSBm aWxlKSkpKQotICAgICAgICAgICh3aGVuIChpbWFnZS10eXBlLWF2YWlsYWJsZS1wICdzdmcp Ci0gICAgICAgICAgICAoaW5zZXJ0LWltYWdlCi0gICAgICAgICAgICAgKHNoci1tYWtlLXBs YWNlaG9sZGVyLWltYWdlIGRvbSkKLSAgICAgICAgICAgICAob3IgKHN0cmluZy10cmltIGFs dCkgIiIpKSkKLQkgIDs7IFBhcmFkb3hpY2FsbHkgdGhpcyBzcGFjZSBjYXVzZXMgc2hyIG5v dCB0byBpbnNlcnQgc3BhY2VzIGFmdGVyCi0JICA7OyBpbmxpbmUgaW1hZ2VzLiBTaW5jZSB0 aGUgaW1hZ2UgaXMgdGVtcG9yYXJ5IGl0IHNlZW0gbGlrZSB0aGVyZQotCSAgOzsgc2hvdWxk IGJlIG5vIGRvd25zaWRlIHRvIG5vdCBpbnNlcnRpbmcgaXQgYnV0IHNpbmNlIEkgZG9uJ3QK LQkgIDs7IHVuZGVyc3RhbmQgdGhlIGNvZGUgd2VsbCBhbmQgZm9yIHRoZSBzYWtlIG9mIGJh Y2t3YXJkIGNvbXBhdGliaWxpdHkKLQkgIDs7IHdlIHByZXNlcnZlIGl0IHVubGVzcyB1c2Vy IGhhcyBzZXQgYHNoci1tYXgtaW5saW5lLWltYWdlLXNpemUnLgotICAgICAgICAgICh1bmxl c3Mgc2hyLW1heC1pbmxpbmUtaW1hZ2Utc2l6ZQotCSAgICAgIChpbnNlcnQgIiAiKSkKKyAg ICAgICAgICAoaWYgKGltYWdlLXR5cGUtYXZhaWxhYmxlLXAgJ3N2ZykKKyAgICAgICAgICAg ICAgKGluc2VydC1pbWFnZQorICAgICAgICAgICAgICAgKHNoci1tYWtlLXBsYWNlaG9sZGVy LWltYWdlIGRvbSkKKyAgICAgICAgICAgICAgIChvciAoc3RyaW5nLXRyaW0gYWx0KSAiIikp CisgICAgICAgICAgICA7OyBObyBTVkcgc3VwcG9ydC4gIEp1c3QgdXNlIGEgc3BhY2UgYXMg b3VyIHBsYWNlaG9sZGVyLgorICAgICAgICAgICAgKGluc2VydCAiICIpKQogCSAgKHVybC1x dWV1ZS1yZXRyaWV2ZQogICAgICAgICAgICB1cmwgIydzaHItaW1hZ2UtZmV0Y2hlZAogCSAg IChsaXN0IChjdXJyZW50LWJ1ZmZlcikgc3RhcnQgKHNldC1tYXJrZXIgKG1ha2UtbWFya2Vy KSAocG9pbnQpKQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL25ldC9zaHItdGVzdHMuZWwgYi90 ZXN0L2xpc3AvbmV0L3Noci10ZXN0cy5lbAppbmRleCAxNzEzODA1MzQ1MC4uYjJlY2UzMDQ5 YTEgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9uZXQvc2hyLXRlc3RzLmVsCisrKyBiL3Rlc3Qv bGlzcC9uZXQvc2hyLXRlc3RzLmVsCkBAIC0yOSw2ICsyOSwyMiBAQAogCiAoZGVjbGFyZS1m dW5jdGlvbiBsaWJ4bWwtcGFyc2UtaHRtbC1yZWdpb24gInhtbC5jIikKIAorKGRlZnZhciBz aHItdGVzdC0tbWF4LXdhaXQtdGltZSA1CisgICJUaGUgbWF4aW11bSBhbW91bnQgb2YgdGlt ZSB0byB3YWl0IGZvciBhIGNvbmRpdGlvbiB0byByZXNvbHZlLCBpbiBzZWNvbmRzLgorU2Vl IGBzaHItdGVzdC13YWl0LWZvcicuIikKKworKGRlZnVuIHNoci10ZXN0LXdhaXQtZm9yIChw cmVkaWNhdGUgJm9wdGlvbmFsIG1lc3NhZ2UpCisgICJXYWl0IHVudGlsIFBSRURJQ0FURSBy ZXR1cm5zIG5vbi1uaWwuCitJZiB0aGlzIHRha2VzIGxvbmdlciB0aGFuIGBzaHItdGVzdC0t bWF4LXdhaXQtdGltZScsIHJhaXNlIGFuIGVycm9yLgorTUVTU0FHRSBpcyBhbiBvcHRpb25h bCBtZXNzYWdlIHRvIHVzZSBpZiB0aGlzIHRpbWVzIG91dC4iCisgIChsZXQgKChzdGFydCAo Y3VycmVudC10aW1lKSkKKyAgICAgICAgKG1lc3NhZ2UgKG9yIG1lc3NhZ2UgInRpbWVkIG91 dCB3YWl0aW5nIGZvciBjb25kaXRpb24iKSkpCisgICAgKHdoaWxlIChub3QgKGZ1bmNhbGwg cHJlZGljYXRlKSkKKyAgICAgICh3aGVuICg+IChmbG9hdC10aW1lICh0aW1lLXNpbmNlIHN0 YXJ0KSkKKyAgICAgICAgICAgICAgIHNoci10ZXN0LS1tYXgtd2FpdC10aW1lKQorICAgICAg ICAoZXJyb3IgbWVzc2FnZSkpCisgICAgICAoc2l0LWZvciAwLjEpKSkpCisKIChkZWZ1biBz aHItdGVzdC0tcmVuZGVyaW5nLWNoZWNrIChuYW1lICZvcHRpb25hbCBjb250ZXh0KQogICAi UmVuZGVyIE5BTUUuaHRtbCBhbmQgY29tcGFyZSBpdCB0byBOQU1FLnR4dC4KIFJhaXNlIGEg dGVzdCBmYWlsdXJlIGlmIHRoZSByZW5kZXJlZCBidWZmZXIgZG9lcyBub3QgbWF0Y2ggTkFN RS50eHQuCkBAIC02OCw2ICs4NCw4IEBAIHNoci10ZXN0LS1yZW5kZXJpbmctZXh0cmEtY29u ZmlncwogVGhlIGByZW5kZXJpbmcnIHRlc3RjYXNlIHdpbGwgdGVzdCBOQU1FIG9uY2Ugd2l0 aG91dCBhbHRlcmluZyBhbnkKIHNldHRpbmdzLCB0aGVuIG9uY2UgbW9yZSBmb3IgZWFjaCAo T1BUSU9OIC4gVkFMVUUpIHBhaXIuIikKIAorOzs7IFRlc3RzOgorCiAoZXJ0LWRlZnRlc3Qg cmVuZGVyaW5nICgpCiAgIChza2lwLXVubGVzcyAoZmJvdW5kcCAnbGlieG1sLXBhcnNlLWh0 bWwtcmVnaW9uKSkKICAgKGRvbGlzdCAoZmlsZSAoZGlyZWN0b3J5LWZpbGVzIChlcnQtcmVz b3VyY2UtZGlyZWN0b3J5KSBuaWwgIlxcLmh0bWxcXCciKSkKQEAgLTExNCw2ICsxMzIsNTAg QEAgc2hyLXNyY3NldAogICAoc2hvdWxkIChlcXVhbCAoc2hyLS1wYXJzZS1zcmNzZXQgImh0 dHBzOi8vZXhhbXBsZS5vcmcvMSwyXG5cbiAxMHcgLCBodHRwczovL2V4YW1wbGUub3JnLzIg MjB3ICAgICAgIikKIAkgICAgICAgICAnKCgiaHR0cHM6Ly9leGFtcGxlLm9yZy8yIiAyMCkg KCJodHRwczovL2V4YW1wbGUub3JnLzEsMiIgMTApKSkpKQogCisoZXJ0LWRlZnRlc3Qgc2hy LXRlc3Qvem9vbS1pbWFnZSAoKQorICAiVGVzdCB0aGF0IGBzaHItem9vbS1pbWFnZScgcHJv cGVybHkgcmVwbGFjZXMgdGhlIG9yaWdpbmFsIGltYWdlLiIKKyAgKGxldCAoKGltYWdlIChl eHBhbmQtZmlsZS1uYW1lICJkYXRhL2ltYWdlL2JsYW5rLTEwMHgyMDAucG5nIgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGdldGVudiAiRU1BQ1NfVEVTVF9ESVJFQ1RP UlkiKSkpKQorICAgIChkb2xpc3QgKGFsdCAnKG5pbCAiIiAibm90aGluZyB0byBzZWUgaGVy ZSIpKQorICAgICAgKHdpdGgtdGVtcC1idWZmZXIKKyAgICAgICAgKGVydC1pbmZvICgoZm9y bWF0ICJpbWFnZSB3aXRoIGFsdD0lUyIgYWx0KSkKKyAgICAgICAgICAobGV0ICgoYXR0cnMg KGlmIGFsdCAoZm9ybWF0ICIgYWx0PVwiJXNcIiIgYWx0KSAiIikpKQorICAgICAgICAgICAg KGluc2VydCAoZm9ybWF0ICI8aW1nIHNyYz1cImZpbGU6Ly8lc1wiICVzIiBpbWFnZSBhdHRy cykpKQorICAgICAgICAgIChjbC1sZXRmKiAoOzsgUHJldGVuZCB3ZSdyZSBhIGdyYXBoaWNh bCBkaXNwbGF5LgorICAgICAgICAgICAgICAgICAgICAgKChzeW1ib2wtZnVuY3Rpb24gJ2Rp c3BsYXktZ3JhcGhpYy1wKSAjJ2Fsd2F5cykKKyAgICAgICAgICAgICAgICAgICAgICgoc3lt Ym9sLWZ1bmN0aW9uICd1cmwtcXVldWUtcmV0cmlldmUpCisgICAgICAgICAgICAgICAgICAg ICAgKGxhbWJkYSAoJnJlc3QgYXJncykKKyAgICAgICAgICAgICAgICAgICAgICAgIChhcHBs eSAjJ3J1bi1hdC10aW1lIDAgbmlsICMndXJsLXJldHJpZXZlIGFyZ3MpKSkKKyAgICAgICAg ICAgICAgICAgICAgIChwdXQtaW1hZ2UtY2FsbHMgMCkKKyAgICAgICAgICAgICAgICAgICAg IChzaHItcHV0LWltYWdlLWZ1bmN0aW9uCisgICAgICAgICAgICAgICAgICAgICAgKGxhbWJk YSAoJnJlc3QgYXJncykKKyAgICAgICAgICAgICAgICAgICAgICAgIChjbC1pbmNmIHB1dC1p bWFnZS1jYWxscykKKyAgICAgICAgICAgICAgICAgICAgICAgIChhcHBseSAjJ3Noci1wdXQt aW1hZ2UgYXJncykpKQorICAgICAgICAgICAgICAgICAgICAgKHNoci13aWR0aCA4MCkKKyAg ICAgICAgICAgICAgICAgICAgIChzaHItdXNlLWZvbnRzIG5pbCkKKyAgICAgICAgICAgICAg ICAgICAgIChzaHItaW1hZ2UtYW5pbWF0ZSBuaWwpCisgICAgICAgICAgICAgICAgICAgICAo ZG9tIChsaWJ4bWwtcGFyc2UtaHRtbC1yZWdpb24gKHBvaW50LW1pbikgKHBvaW50LW1heCkp KSkKKyAgICAgICAgICAgIDs7IFJlbmRlciB0aGUgZG9jdW1lbnQuCisgICAgICAgICAgICAo ZXJhc2UtYnVmZmVyKQorICAgICAgICAgICAgKHNoci1pbnNlcnQtZG9jdW1lbnQgZG9tKQor ICAgICAgICAgICAgKHNoci10ZXN0LXdhaXQtZm9yIChsYW1iZGEgKCkgKD0gcHV0LWltYWdl LWNhbGxzIDEpKSkKKyAgICAgICAgICAgIDs7IE5vdyB6b29tIHRoZSBpbWFnZS4KKyAgICAg ICAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCisgICAgICAgICAgICAoc2hyLXpvb20t aW1hZ2UpCisgICAgICAgICAgICAoc2hyLXRlc3Qtd2FpdC1mb3IgKGxhbWJkYSAoKSAoPSBw dXQtaW1hZ2UtY2FsbHMgMikpKQorICAgICAgICAgICAgOzsgQ2hlY2sgdGhhdCB3ZSBnb3Qg YSBzbGljZWQgaW1hZ2UuCisgICAgICAgICAgICAobGV0ICgoc2xpY2UtY291bnQgMCkpCisg ICAgICAgICAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCisgICAgICAgICAgICAgICh3 aGlsZS1sZXQgKChwb3MgKG5leHQtc2luZ2xlLXByb3BlcnR5LWNoYW5nZSAocG9pbnQpICdk aXNwbGF5KSkpCisgICAgICAgICAgICAgICAgKHdoZW4tbGV0ICgoZGlzcGxheSAoZ2V0LXRl eHQtcHJvcGVydHkgcG9zICdkaXNwbGF5KSkpCisgICAgICAgICAgICAgICAgICA7OyBJZiB0 aGlzIGlzIG5pbCwgd2UgZm91bmQgYSBub24tc2xpY2VkIGltYWdlLCBidXQgd2UKKyAgICAg ICAgICAgICAgICAgIDs7IHNob3VsZCBoYXZlIHJlcGxhY2VkIHRoYXQhCisgICAgICAgICAg ICAgICAgICAoc2hvdWxkIChhc3NxICdzbGljZSBkaXNwbGF5KSkKKyAgICAgICAgICAgICAg ICAgIChjbC1pbmNmIHNsaWNlLWNvdW50KSkKKyAgICAgICAgICAgICAgICAoZ290by1jaGFy IHBvcykpCisgICAgICAgICAgICAgIDs7IE1ha2Ugc3VyZSB3ZSBhY3R1YWxseSBzYXcgYSBz bGljZS4KKyAgICAgICAgICAgICAgKHNob3VsZCAoPiBzbGljZS1jb3VudCAxKSkpKSkpKSkp CisKIChyZXF1aXJlICdzaHIpCiAKIDs7OyBzaHItdGVzdHMuZWwgZW5kcyBoZXJlCi0tIAoy LjI1LjEKCg== --------------xpVgfLQeI8TlA79BiaUkTb50-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 00:44:20 2024 Received: (at 71666) by debbugs.gnu.org; 23 Jun 2024 04:44:20 +0000 Received: from localhost ([127.0.0.1]:43999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLF5P-0004xA-TO for submit@debbugs.gnu.org; Sun, 23 Jun 2024 00:44:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLF5N-0004ws-Of for 71666@debbugs.gnu.org; Sun, 23 Jun 2024 00:44:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLF5H-0005u0-SV; Sun, 23 Jun 2024 00:44:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ItY7cBYDKXPiUatbeQ+Xlq+MbxZxBvTu9LPL9HPbL9Q=; b=i77F/T4tnzFm qhXBpI9BXL66dOM/5k+wTT9krrc0jlsUAX70I26INztfh+TXaFwyUbQQ4axXPydVFvNHvDyRRlESC GUSp6F9E7eUsyf6W1Uq/Pnm6h3mKYAyV3wJzGDhnV0FlnMNpJB5AS8cUcHVweJolGVWXU1awVCh/o dtu78/BWtBn5UFQWHsU444lbmDv5jqJBysAuykW+FvmpvuJmi87HODLNQhRLHTRlqjTaSfGMZpzyt rlkZwUTikF/dWXipBTJUbCp8uIxFG8X6oUQirW01hBjfi46jueuJoltLeUcXujuQt/5VbAP0+eCta 0xjGnkYARoR6ndQ8s0+zWw==; Date: Sun, 23 Jun 2024 07:44:09 +0300 Message-Id: <86o77sfeue.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Sat, 22 Jun 2024 13:21:53 -0700) Subject: Re: bug#71666: 30.0.50; [PATCH] Fix zooming images with SHR References: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> <86frt5ibou.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71666 Cc: 71666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 22 Jun 2024 13:21:53 -0700 > Cc: 71666@debbugs.gnu.org > From: Jim Porter > > On 6/22/2024 2:11 AM, Eli Zaretskii wrote: > > I tried the recipe and the patch. While the patches shr behaves > > better than the unpatched, I don't see the image being zoomed, it > > stays at its original size. Do I need some optional library or > > external program for the zoom to happen? > > Ah right, that would have been helpful for me to mention in the original > message: by default, SHR scales down images that are more than 70% of > the width (or height) of the window. So if you narrow your window to 40 > columns or so and reload the page in EWW, the larger images should be > scaled down. Then putting point on one and pressing "z" should scale it > up to the original size. Pressing "z" again should scale the image back > down. OK, then feel free to install, and thanks. > As an aside, there are actually *three* states for image scaling in SHR: > default, original, and full, and 'shr-zoom-image' cycles through them in > that order. As far as I can tell from the code, "default" and "full" are > the same though. I haven't figured out whether that's a bug (and if so, > what the bug is), or whether I'm just misunderstanding something. I'll > try to fix that later (if only by adding documentation), once I know > what's going on. I must say this kind of dwim-ish operation that looks like no-op in too many "normal" cases looks very strange to me. How does it make sense to have features that only appear to do something in rare cases? Doesn't that cause user bewilderment (like I was surprised above), and cause users to think we have a bug? Should we perhaps adjust the heuristics and its parameters to make this not no-op in more cases? Or at least show a message in echo area explaining why the image was not zoomed-in when we decide not to? For example, in the case above, why would it not make sense to enlarge the image when the user presses 'z' even if it was not scaled down initially? Doesn't principle of least surprise count anymore? From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 02:15:25 2024 Received: (at 71666) by debbugs.gnu.org; 23 Jun 2024 06:15:25 +0000 Received: from localhost ([127.0.0.1]:46347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLGVZ-0002eG-5u for submit@debbugs.gnu.org; Sun, 23 Jun 2024 02:15:25 -0400 Received: from mail-pf1-f172.google.com ([209.85.210.172]:59526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLGVX-0002dx-GX for 71666@debbugs.gnu.org; Sun, 23 Jun 2024 02:15:23 -0400 Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7066c9741fbso714524b3a.2 for <71666@debbugs.gnu.org>; Sat, 22 Jun 2024 23:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719123257; x=1719728057; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=5mpWcQ7bP3U0wFvn5L722swv+/J7r2teOOqseZht+38=; b=GCM4G9MsWON0320zNNNbVLZYCpCe1JMF1Nwz/7e3HONRJQqxSWEWXyKXfscJQq6lT6 NlYRnLBZqKMGY4FuqgAEBdHnfNV17sclJe0PPg5OnkCWj5fETJIvY8IPGUzatN3Lc2PQ ozEiVt12e1KhPWe4YEOfz7EmFUaAXsMlRKNgruSHv//DDx//Vn626CGWae1ClSCRmaLV JdjzOuRwvrCK/xWRcCoKdMqK6Kmpp28bDIB5/rEkIaOyAi/OVrXU3Z7BXFDJBi/vBoVO 1RJ9IvK/eIeY+IrjX877nAHb0nWAXrbt3v+1BuX5THiP1bWhdTFeIXZikjdKN6SCmMBD 2AgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719123257; x=1719728057; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5mpWcQ7bP3U0wFvn5L722swv+/J7r2teOOqseZht+38=; b=HQyBpCKzCvzuqg5n/eURqxuX+BQoFd0yw4uGqUrCkCDyduo7yvImzOhmyQ37nNSFD9 cXgcDPnrYTiJUWMO5r7zSF6uSckLv3AT1VDkogRjY45qRNZNR+xtwKN6TOsNWiDXaP+u 7HKPysxfnc0myIJ1D3BDmbGxM3RxtZcVkSLToWUz4dBlUZpTnZ6sslLBfxV3T3naEoN7 /zQ/wEXKsiwxfloWWNxhQdvpt4KzwEGgh5elhAVeiaRO4Fozx/4IJ+80m6qZuF5aifHd HGt+Ahr3sfFmAK+smW8/8hgGUp3I0pjFOdDnhPVL3WfZcqCSbsFMqbFYJ6L6IObdvgiR klQA== X-Gm-Message-State: AOJu0YzC0Sw8/2bPFIEQruPWOcsAQVsNGwmSrDrT2RCdSLlHXt+2ZHo+ ZPlifKCeYr67HQ1TypKBRP0XopoGYFZ/scnNG/EURkPho5gQi9rx X-Google-Smtp-Source: AGHT+IF+8/7CL8fSHAozhmWtXY/8StiC4pHoKE1JKFZ3g+TpGbch466qZTjnJ92j0smB1uxj7TUyVg== X-Received: by 2002:a05:6a20:bc9e:b0:1b5:4c70:d682 with SMTP id adf61e73a8af0-1bcf7e3283fmr1406381637.6.1719123256376; Sat, 22 Jun 2024 23:14:16 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-2c7e53e07absm6331818a91.18.2024.06.22.23.14.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Jun 2024 23:14:16 -0700 (PDT) Message-ID: <14b4d89a-4947-c8e5-9216-adf201875c21@gmail.com> Date: Sat, 22 Jun 2024 23:14:16 -0700 MIME-Version: 1.0 Subject: Re: bug#71666: 30.0.50; [PATCH] Fix zooming images with SHR Content-Language: en-US To: Eli Zaretskii References: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> <86frt5ibou.fsf@gnu.org> <86o77sfeue.fsf@gnu.org> From: Jim Porter In-Reply-To: <86o77sfeue.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71666 Cc: 71666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 6/22/2024 9:44 PM, Eli Zaretskii wrote: > OK, then feel free to install, and thanks. Thanks. Merged to the master branch as 5f9b5803bea. I made one small improvement to the code to use overlays for preventing image slices from being underlined. That makes the code a bit cleaner, and should make future improvements in this area easier. > I must say this kind of dwim-ish operation that looks like no-op in > too many "normal" cases looks very strange to me. How does it make > sense to have features that only appear to do something in rare cases? > Doesn't that cause user bewilderment (like I was surprised above), and > cause users to think we have a bug? Should we perhaps adjust the > heuristics and its parameters to make this not no-op in more cases? > Or at least show a message in echo area explaining why the image was > not zoomed-in when we decide not to? For example, in the case above, > why would it not make sense to enlarge the image when the user presses > 'z' even if it was not scaled down initially? Doesn't principle of > least surprise count anymore? I agree completely, and I'm working on a patch to that effect. :) I think the problem you mention is a combination of some bugs I'm working on fixing now, and like you say, 'shr-zoom-image' not providing enough feedback about what's happening. It just says it's fetching the image (this is also probably a bug; why fetch the image from the web when we're just resizing it?). Since I'm most of the way done with this additional patch, I'll leave this bug open for now. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 18:26:00 2024 Received: (at 71666) by debbugs.gnu.org; 23 Jun 2024 22:26:00 +0000 Received: from localhost ([127.0.0.1]:54301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLVeo-0004Ad-DO for submit@debbugs.gnu.org; Sun, 23 Jun 2024 18:26:00 -0400 Received: from mail-pl1-f171.google.com ([209.85.214.171]:60885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLVel-0004AH-K8 for 71666@debbugs.gnu.org; Sun, 23 Jun 2024 18:25:57 -0400 Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1f9b52ef481so30293505ad.1 for <71666@debbugs.gnu.org>; Sun, 23 Jun 2024 15:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719181489; x=1719786289; darn=debbugs.gnu.org; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=XtiuSPPJ5tdIPAe7Fltk+aMr77GFyMLuBEFGoewhQ9k=; b=QdKWy4IgVWtUoTJ/C4fRK4uakAcdkyg8UxO3zhlJAEgKBa1O5EtVlZJZ/qCMuXHZ99 EH9jd5M+jJe2/dXiocHaSaQ3PmETk7kqUhi97GXH2SO8MqFcJCXI217K1+/8K9LQre+0 F7P2EHlH4DwvCQwC+8UAjg733exoBptNZIzHV3F+YcSyCRalclK7c5fgG+rwUEcxqLGD AiRiiw4tmpuH9KD1MDBzRHh1aBW20h5X3Lga6/hBde7DdFz+Ox8kMSQt/1VqdF8kSOOl jegAQWbM3l+any7zLth6sKGbd9aRk7VkjMGQJ6OdzdXlUj9jE/i7HdvrqOetQGqhb4qR gPuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719181489; x=1719786289; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XtiuSPPJ5tdIPAe7Fltk+aMr77GFyMLuBEFGoewhQ9k=; b=nz2csW6DKphbPVPv2A29F6NrUFz4AII7tfR1x8Dkh+QZEN110sxtF2VNMGc6q4x0Cy qnG8t4k8Uyd8vgQAdTlP3tPJGIJIsuB1ad7yve1fQBZGtjPb+Y+JpRgNbpwjtCVhtb4R n81u7t3mqgLmLwP1lJjWgomuMIPc3Wk457iBHr/4vWCvrQzJGkl1/t5rfFwkLbyj+TMn UY1E6GcR6TUrvWOKsVD5QPPnkco95DbJiIzTj/9QH/H0J25i2C2wI99SfiXdsKbuX5jL TN2E8jARPmK3XF/LLlTL6Fii2i4V2YCfmDlYCsOqF5WvXMRGZn5C6I6p/RHoVY8a8Dnz A9gw== X-Gm-Message-State: AOJu0Yza+DtBLJIEzn5Po1rnNGn1eIKUBI19BV9iR9i2bMuv8o5dH7ml 6+SJ60fPLaJ2YgDkKR1X1HBQXUmdB5Isn7fapcM/6TlX/ZI45D4u X-Google-Smtp-Source: AGHT+IEZNRX9TwaC0cgf0V2oicpMJrJ1qkusxHvHJjfFbGZ6mVDFY/xVLpr7V9zwRaeWJXoTOnlWvw== X-Received: by 2002:a17:902:c40e:b0:1f9:db1e:ef9d with SMTP id d9443c01a7336-1fa23f1d540mr33574025ad.49.1719181488933; Sun, 23 Jun 2024 15:24:48 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f9eb3c5d29sm49461455ad.154.2024.06.23.15.24.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Jun 2024 15:24:48 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------nnNzqGvYBJRrCg7j6NO56LV9" Message-ID: <88f17922-a833-ea6f-6d5e-bd01261b9068@gmail.com> Date: Sun, 23 Jun 2024 15:24:47 -0700 MIME-Version: 1.0 Subject: Re: bug#71666: 30.0.50; [PATCH] Fix zooming images with SHR Content-Language: en-US From: Jim Porter To: Eli Zaretskii References: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> <86frt5ibou.fsf@gnu.org> <86o77sfeue.fsf@gnu.org> <14b4d89a-4947-c8e5-9216-adf201875c21@gmail.com> In-Reply-To: <14b4d89a-4947-c8e5-9216-adf201875c21@gmail.com> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71666 Cc: 71666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------nnNzqGvYBJRrCg7j6NO56LV9 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/22/2024 11:14 PM, Jim Porter wrote: > I agree completely, and I'm working on a patch to that effect. :) > > I think the problem you mention is a combination of some bugs I'm > working on fixing now, and like you say, 'shr-zoom-image' not providing > enough feedback about what's happening. It just says it's fetching the > image (this is also probably a bug; why fetch the image from the web > when we're just resizing it?). > > Since I'm most of the way done with this additional patch, I'll leave > this bug open for now. This ended up fairly complex, so I've split the patch into sub-parts to (I hope) make the changes easier to follow. There are four distinct, but related, improvements here: 1. Previously, SHR sliced images whenever you requested "original" zoom. But it would really be useful to slice images based on the size they'll be displayed at: a tiny image at "original" zoom doesn't need sliced, but a tall image at default zoom would benefit from slicing. So now SHR checks the height of the image to determine when to slice (you can also turn off slicing entirely, since you don't need it if you use 'pixel-scroll-precision-mode'). 2. When zooming, SHR lost track of the width and height of the image specified in the HTML like . I fixed that, and also cleaned up a bit of the code where we had a list that was simultaneously an alist and a plist (I converted it to a plist since more code used that form). 3. After much archaeology through old Gnus commits, I think I understand what each zoom level does, so I've fixed them. I've also added a new zoom level that zooms to the image's default size, ignoring HTML attributes. That's how the default and "full" zoom levels worked before my fix, so if someone wants the old behavior (I'd probably use it), there it is. I also made 'shr-zoom-image' display a message telling users the new zoom level. 4. Finally, every time you called 'shr-zoom-image', it would reload the image from the web. That shouldn't be necessary since there's a local cache. Now we use the cache when possible; easy enough. --------------nnNzqGvYBJRrCg7j6NO56LV9 Content-Type: text/plain; charset=UTF-8; name="0001-Slice-images-based-on-their-height-in-SHR-not-their-.patch" Content-Disposition: attachment; filename*0="0001-Slice-images-based-on-their-height-in-SHR-not-their-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA5Y2NjNWMzZjU3NjdjYzQ5Mzk4NjlkMTExNmQ4ZmM2NTBhODE3NzU2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjMgSnVuIDIwMjQgMTI6MTg6NTcgLTA3MDAKU3ViamVjdDogW1BB VENIIDEvNF0gU2xpY2UgaW1hZ2VzIGJhc2VkIG9uIHRoZWlyIGhlaWdodCBpbiBTSFIsIG5v dCB0aGVpciB6b29tCiBsZXZlbAoKKiBsaXNwL25ldC9zaHIuZWwgKHNoci1zbGljZWQtaW1h Z2UtcHJvcG9ydGlvbik6IE5ldyBvcHRpb24uLi4KKHNoci1wdXQtaW1hZ2UpOiAuLi4gdXNl IGl0LiAgQ29tcHV0ZSB0aGUgbnVtYmVyIG9mIHNsaWNlcyBpbiByZWxhdGlvbgp0byB0aGUg aW1hZ2UgaGVpZ2h0OyB0aGlzIHdheSwgZWFjaCBzbGljZSBpcyByb3VnaGx5IHRoZSBoZWln aHQgb2YgYQpsaW5lIG9mIG9yZGluYXJ5IHRleHQuCgoqIHRlc3QvbGlzcC9uZXQvc2hyLXRl c3RzLmVsIChzaHItdGVzdC96b29tLWltYWdlKTogVXBkYXRlIHRlc3QsIHNpbmNlCnpvb21p bmcgbm8gbG9uZ2VyIG5lY2Vzc2FyaWx5IHRyaWdnZXJzIHNsaWNpbmcuCgoqIGRvYy9taXNj L2V3dy50ZXhpIChBZHZhbmNlZCk6IERvY3VtZW50ICdzaHItc2xpY2VkLWltYWdlLXByb3Bv cnRpb24nLgoKKiBldGMvTkVXUzogQW5ub3VuY2UgdGhpcyBjaGFuZ2UuCi0tLQogZG9jL21p c2MvZXd3LnRleGkgICAgICAgICAgfCAgOSArKysrKysrKysKIGV0Yy9ORVdTICAgICAgICAg ICAgICAgICAgIHwgMTEgKysrKysrKysrKysKIGxpc3AvbmV0L3Noci5lbCAgICAgICAgICAg IHwgMjggKysrKysrKysrKysrKysrKysrKysrKysrKy0tLQogdGVzdC9saXNwL25ldC9zaHIt dGVzdHMuZWwgfCAxNSArKysrKystLS0tLS0tLS0KIDQgZmlsZXMgY2hhbmdlZCwgNTEgaW5z ZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL21pc2MvZXd3 LnRleGkgYi9kb2MvbWlzYy9ld3cudGV4aQppbmRleCBlZWM2YjNjMzI5OS4uNWFlMTBiM2Y3 YjcgMTAwNjQ0Ci0tLSBhL2RvYy9taXNjL2V3dy50ZXhpCisrKyBiL2RvYy9taXNjL2V3dy50 ZXhpCkBAIC0zNzMsNiArMzczLDE1IEBAIEFkdmFuY2VkCiBAY29kZXtzaHItaW5oaWJpdC1p bWFnZXN9LiAgSWYgdGhpcyB2YXJpYWJsZSBpcyBAY29kZXtuaWx9LCBkaXNwbGF5CiB0aGUg YGBBTFQnJyB0ZXh0IG9mIGltYWdlcyBpbnN0ZWFkLgogCitAdmluZGV4IHNoci1zbGljZWQt aW1hZ2UtcHJvcG9ydGlvbgorICBUbyBtYWtlIHNjcm9sbGluZyB1cC9kb3duIHBhc3QgaW1h Z2VzIG1vcmUgaW50dWl0aXR2ZSwgRVdXIHNwbGl0cworbGFyZ2UgaW1hZ2VzIGludG8gc2V2 ZXJhbCByb3dzLiAgVGhpcyB3YXksIHlvdSBjYW4gc2Nyb2xsIGluZGl2aWR1YWxseQorcGFz dCBlYWNoIHNsaWNlLCBpbnN0ZWFkIG9mIGp1bXBpbmcgcGFzdCB0aGUgZW50aXJlIGltYWdl LiAgRVdXIHNsaWNlcworaW1hZ2VzIHRoYXQgdGFrZSB1cCBtb3JlIHRoYW4gQGNvZGV7c2hy LXNsaWNlZC1pbWFnZS1wcm9wb3J0aW9ufSBvZiB0aGUKK2hlaWdodCBvZiB0aGUgd2luZG93 IHRoZXkgYXJlIGRpc3BsYXllZCBpbi4gIEZvciBleGFtcGxlLCBhIHZhbHVlIG9mIDAuNwor bWVhbnMgdGhhdCBpbWFnZXMgYXJlIGFsbG93ZWQgdG8gdGFrZSB1cCA3MCUgb2YgdGhlIGhl aWdodCBvZiB0aGUgd2luZG93CitiZWZvcmUgYmVpbmcgc2xpY2VkLgorCiBAdmluZGV4IHNo ci1jb2xvci12aXNpYmxlLWRpc3RhbmNlLW1pbgogQHZpbmRleCBzaHItY29sb3ItdmlzaWJs ZS1sdW1pbmFuY2UtbWluCiBAY2luZGV4IENvbnRyYXN0CmRpZmYgLS1naXQgYS9ldGMvTkVX UyBiL2V0Yy9ORVdTCmluZGV4IGFmMzJhOTNkOWM0Li4zZjQ5NjlkYTg3MyAxMDA2NDQKLS0t IGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTM2LDYgKzM2LDE3IEBAIGFwcGxpZXMs IGFuZCBwbGVhc2UgYWxzbyB1cGRhdGUgZG9jc3RyaW5ncyBhcyBuZWVkZWQuCiAMCiAqIENo YW5nZXMgaW4gU3BlY2lhbGl6ZWQgTW9kZXMgYW5kIFBhY2thZ2VzIGluIEVtYWNzIDMxLjEK IAorKiogU0hSCisKKysrKworKioqIFNIUiBub3cgc2xpY2VzIGxhcmdlIGltYWdlcyBpbnRv IHJvd3MgYnkgZGVmYXVsdC4KK1NsaWNlZCBpbWFnZXMgYWxsb3cgZm9yIG1vcmUgaW50dWl0 aXZlIHNjcm9sbGluZyB1cC9kb3duIGJ5IGxldHRpbmcgeW91CitzY3JvbGwgcGFzdCBlYWNo IHNsaWNlLCBpbnN0ZWFkIG9mIGp1bXBpbmcgcGFzdCB0aGUgZW50aXJlIGltYWdlLgorUHJl dmlvdXNseSwgU0hSIG9ubHkgc2xpY2VkIGltYWdlcyB3aGVuIHpvb21lZCB0byB0aGVpciBv cmlnaW5hbCBzaXplLgorWW91IGNhbiBzZXQgdGhlIG1heGltdW0gc2l6ZSBmb3IgdW5zbGlj ZWQgaW1hZ2VzIHdpdGggdGhlIG9wdGlvbgorJ3Noci1zbGljZWQtaW1hZ2UtcHJvcG9ydGlv bicuICBGb3IgbW9yZSBpbmZvcm1hdGlvbiwgc2VlIHRoZSAiKGV3dykKK0FkdmFuY2VkIiBu b2RlIGluIHRoZSBFV1cgbWFudWFsLgorCiAMCiAqIE5ldyBNb2RlcyBhbmQgUGFja2FnZXMg aW4gRW1hY3MgMzEuMQogCmRpZmYgLS1naXQgYS9saXNwL25ldC9zaHIuZWwgYi9saXNwL25l dC9zaHIuZWwKaW5kZXggM2RhZGNiOWEwOWIuLjUxNTc2OGUwMzVmIDEwMDY0NAotLS0gYS9s aXNwL25ldC9zaHIuZWwKKysrIGIvbGlzcC9uZXQvc2hyLmVsCkBAIC01OCw2ICs1OCwyMCBA QCBzaHItbWF4LWltYWdlLXByb3BvcnRpb24KICAgOnZlcnNpb24gIjI0LjEiCiAgIDp0eXBl ICdmbG9hdCkKIAorKGRlZmN1c3RvbSBzaHItc2xpY2VkLWltYWdlLXByb3BvcnRpb24gMC4z CisgICJIb3cgdGFsbCBpbWFnZXMgY2FuIGJlIGJlZm9yZSBzbGljaW5nIGluIHJlbGF0aW9u IHRvIHRoZSB3aW5kb3cgdGhleSdyZSBpbi4KK0EgdmFsdWUgb2YgMC43IG1lYW5zIHRoYXQg aW1hZ2VzIGFyZSBhbGxvd2VkIHRvIHRha2UgdXAgNzAlIG9mIHRoZQoraGVpZ2h0IG9mIHRo ZSB3aW5kb3cgYmVmb3JlIGJlaW5nIHNsaWNlZCBieSBgaW5zZXJ0LXNsaWNlZC1pbWFnZScu ICBJZgorbmlsLCBuZXZlciBzbGljZSBpbWFnZXMuCisKK1NsaWNlZCBpbWFnZXMgYWxsb3cg Zm9yIG1vcmUgaW50dWl0aXZlIHNjcm9sbGluZyB1cC9kb3duIGJ5IGxldHRpbmcgeW91Citz Y3JvbGwgcGFzdCBlYWNoIHNsaWNlLCBpbnN0ZWFkIG9mIGp1bXBpbmcgcGFzdCB0aGUgZW50 aXJlIGltYWdlLgorQWx0ZXJuYXRlbHksIHlvdSBjYW4gdXNlIGBwaXhlbC1zY3JvbGwtcHJl Y2lzaW9uLW1vZGUnIHRvIHNjcm9sbAorcGl4ZWwtd2lzZSBwYXN0IGltYWdlcywgaW4gd2hp Y2ggY2FzZSB5b3UgY2FuIHNldCB0aGlzIG9wdGlvbiB0byBuaWwuIgorICA6dmVyc2lvbiAi MzEuMSIKKyAgOnR5cGUgJyhjaG9pY2UgKGNvbnN0IDp0YWcgIk5ldmVyIHNsaWNlIGltYWdl cyIpCisgICAgICAgICAgICAgICAgIGZsb2F0KSkKKwogKGRlZmN1c3RvbSBzaHItYWxsb3dl ZC1pbWFnZXMgbmlsCiAgICJJZiBub24tbmlsLCBvbmx5IGltYWdlcyB0aGF0IG1hdGNoIHRo aXMgcmVnZXhwIGFyZSBkaXNwbGF5ZWQuCiBJZiBuaWwsIGFsbCBVUkxzIGFyZSBhbGxvd2Vk LiAgQWxzbyBzZWUgYHNoci1ibG9ja2VkLWltYWdlcycuIgpAQCAtMTE1NywxNCArMTE3MSwy MiBAQCBzaHItcHV0LWltYWdlCiAJICAgICh3aGVuIChhbmQgKD4gKGN1cnJlbnQtY29sdW1u KSAwKQogCQkgICAgIChub3QgaW5saW5lKSkKIAkJKGluc2VydCAiXG4iKSkKLQkgICAgKGxl dCAoKGltYWdlLXBvcyAocG9pbnQpKSkKLQkgICAgICAoaWYgKGVxIHNpemUgJ29yaWdpbmFs KQorCSAgICAobGV0ICgoaW1hZ2UtcG9zIChwb2ludCkpCisgICAgICAgICAgICAgICAgICBp bWFnZS1oZWlnaHQgYm9keS1oZWlnaHQpCisJICAgICAgKGlmIChhbmQgc2hyLXNsaWNlZC1p bWFnZS1wcm9wb3J0aW9uCisgICAgICAgICAgICAgICAgICAgICAgIChzZXRxIGltYWdlLWhl aWdodCAoY2RyIChpbWFnZS1zaXplIGltYWdlIHQpKQorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBib2R5LWhlaWdodCAod2luZG93LWJvZHktaGVpZ2h0CisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZ2V0LWJ1ZmZlci13aW5kb3cgKGN1cnJl bnQtYnVmZmVyKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHQpKQorICAgICAgICAgICAgICAgICAgICAgICAoPiAoLyBpbWFnZS1oZWlnaHQgYm9keS1o ZWlnaHQgMS4wKQorICAgICAgICAgICAgICAgICAgICAgICAgICBzaHItc2xpY2VkLWltYWdl LXByb3BvcnRpb24pKQogICAgICAgICAgICAgICAgICAgOzsgTm9ybWFsbHksIHdlIHRyeSB0 byBrZWVwIHRoZSBidWZmZXIgdGV4dCB0aGUgc2FtZQogICAgICAgICAgICAgICAgICAgOzsg YnkgcHJlc2VydmluZyBBTFQuICBXaXRoIGEgc2xpY2VkIGltYWdlLCB3ZSBoYXZlIHRvCiAg ICAgICAgICAgICAgICAgICA7OyByZXBlYXQgdGhlIHRleHQgZm9yIGVhY2ggbGluZSwgc28g d2UgY2FuJ3QgZG8gdGhhdC4KICAgICAgICAgICAgICAgICAgIDs7IEp1c3QgdXNlICIqIiBm b3IgdGhlIHN0cmluZyB0byBpbnNlcnQgaW5zdGVhZC4KICAgICAgICAgICAgICAgICAgIChw cm9nbgotICAgICAgICAgICAgICAgICAgICAoaW5zZXJ0LXNsaWNlZC1pbWFnZSBpbWFnZSAi KiIgbmlsIDIwIDEpCisgICAgICAgICAgICAgICAgICAgIChpbnNlcnQtc2xpY2VkLWltYWdl CisgICAgICAgICAgICAgICAgICAgICBpbWFnZSAiKiIgbmlsICgvIGltYWdlLWhlaWdodCAo ZGVmYXVsdC1saW5lLWhlaWdodCkpIDEpCiAgICAgICAgICAgICAgICAgICAgIChsZXQgKChv dmVybGF5IChtYWtlLW92ZXJsYXkgc3RhcnQgKHBvaW50KSkpKQogICAgICAgICAgICAgICAg ICAgICAgIDs7IEF2b2lkIGRpc3BsYXlpbmcgdW5zaWdodGx5IGRlY29yYXRpb25zIG9uIHRo ZQogICAgICAgICAgICAgICAgICAgICAgIDs7IGltYWdlIHNsaWNlcy4KZGlmZiAtLWdpdCBh L3Rlc3QvbGlzcC9uZXQvc2hyLXRlc3RzLmVsIGIvdGVzdC9saXNwL25ldC9zaHItdGVzdHMu ZWwKaW5kZXggYjY1NTI2NzRiMjcuLjcwMWU3M2RjNGZlIDEwMDY0NAotLS0gYS90ZXN0L2xp c3AvbmV0L3Noci10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvbmV0L3Noci10ZXN0cy5lbApA QCAtMTU0LDYgKzE1NCw3IEBAIHNoci10ZXN0L3pvb20taW1hZ2UKICAgICAgICAgICAgICAg ICAgICAgIChzaHItd2lkdGggODApCiAgICAgICAgICAgICAgICAgICAgICAoc2hyLXVzZS1m b250cyBuaWwpCiAgICAgICAgICAgICAgICAgICAgICAoc2hyLWltYWdlLWFuaW1hdGUgbmls KQorICAgICAgICAgICAgICAgICAgICAgKHNoci1zbGljZWQtaW1hZ2UtcHJvcG9ydGlvbiBu aWwpCiAgICAgICAgICAgICAgICAgICAgICAoaW5oaWJpdC1tZXNzYWdlIHQpCiAgICAgICAg ICAgICAgICAgICAgICAoZG9tIChsaWJ4bWwtcGFyc2UtaHRtbC1yZWdpb24gKHBvaW50LW1p bikgKHBvaW50LW1heCkpKSkKICAgICAgICAgICAgIDs7IFJlbmRlciB0aGUgZG9jdW1lbnQu CkBAIC0xNjQsMTkgKzE2NSwxNSBAQCBzaHItdGVzdC96b29tLWltYWdlCiAgICAgICAgICAg ICAoZ290by1jaGFyIChwb2ludC1taW4pKQogICAgICAgICAgICAgKHNoci16b29tLWltYWdl KQogICAgICAgICAgICAgKHNoci10ZXN0LXdhaXQtZm9yIChsYW1iZGEgKCkgKD0gcHV0LWlt YWdlLWNhbGxzIDIpKSkKLSAgICAgICAgICAgIDs7IENoZWNrIHRoYXQgd2UgZ290IGEgc2xp Y2VkIGltYWdlLgotICAgICAgICAgICAgKGxldCAoKHNsaWNlLWNvdW50IDApKQorICAgICAg ICAgICAgOzsgQ2hlY2sgdGhhdCB3ZSBoYXZlIGEgc2luZ2xlIGltYWdlIGF0IG9yaWdpbmFs IHNpemUuCisgICAgICAgICAgICAobGV0IChpbWFnZS1zaXplcykKICAgICAgICAgICAgICAg KGdvdG8tY2hhciAocG9pbnQtbWluKSkKICAgICAgICAgICAgICAgKHdoaWxlICg8IChwb2lu dCkgKHBvaW50LW1heCkpCi0gICAgICAgICAgICAgICAgKHdoZW4tbGV0ICgoZGlzcGxheSAo Z2V0LXRleHQtcHJvcGVydHkgKHBvaW50KSAnZGlzcGxheSkpKQotICAgICAgICAgICAgICAg ICAgOzsgSWYgdGhpcyBpcyBuaWwsIHdlIGZvdW5kIGEgbm9uLXNsaWNlZCBpbWFnZSwgYnV0 IHdlCi0gICAgICAgICAgICAgICAgICA7OyBzaG91bGQgaGF2ZSByZXBsYWNlZCB0aGF0IQot ICAgICAgICAgICAgICAgICAgKHNob3VsZCAoYXNzcSAnc2xpY2UgZGlzcGxheSkpCi0gICAg ICAgICAgICAgICAgICAoY2wtaW5jZiBzbGljZS1jb3VudCkpCisgICAgICAgICAgICAgICAg KHdoZW4gKGdldC10ZXh0LXByb3BlcnR5IChwb2ludCkgJ2Rpc3BsYXkpCisgICAgICAgICAg ICAgICAgICAocHVzaCAoZ2V0LXRleHQtcHJvcGVydHkgKHBvaW50KSAnaW1hZ2Utc2l6ZSkg aW1hZ2Utc2l6ZXMpKQogICAgICAgICAgICAgICAgIChnb3RvLWNoYXIgKG9yIChuZXh0LXNp bmdsZS1wcm9wZXJ0eS1jaGFuZ2UgKHBvaW50KSAnZGlzcGxheSkKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAocG9pbnQtbWF4KSkpKQotICAgICAgICAgICAgICA7OyBNYWtl IHN1cmUgd2UgYWN0dWFsbHkgc2F3IGEgc2xpY2UuCi0gICAgICAgICAgICAgIChzaG91bGQg KD4gc2xpY2UtY291bnQgMSkpKSkpKSkpKQorICAgICAgICAgICAgICAoc2hvdWxkIChlcXVh bCBpbWFnZS1zaXplcyAnKG9yaWdpbmFsKSkpKSkpKSkpKQogCiAocmVxdWlyZSAnc2hyKQog Ci0tIAoyLjI1LjEKCg== --------------nnNzqGvYBJRrCg7j6NO56LV9 Content-Type: text/plain; charset=UTF-8; name="0002-In-SHR-keep-track-of-image-sizes-as-specified-by-the.patch" Content-Disposition: attachment; filename*0="0002-In-SHR-keep-track-of-image-sizes-as-specified-by-the.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBmMTRjNTkxZWZkZWRmMzEyYzBlMWVkNjUyN2JhMGZkZDQ1OTNkMjZkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjMgSnVuIDIwMjQgMTI6MjU6MjUgLTA3MDAKU3ViamVjdDogW1BB VENIIDIvNF0gSW4gU0hSLCBrZWVwIHRyYWNrIG9mIGltYWdlIHNpemVzIGFzIHNwZWNpZmll ZCBieSB0aGUKIEhUTUwKClByZXZpb3VzbHksIHRoZXNlIHZhbHVlcyBnb3QgbG9zdCB3aGVu IHpvb21pbmcgdGhlIGltYWdlLgoKKiBsaXNwL25ldC9zaHIuZWwgKHNoci10YWctaW1nKTog U2V0ICdpbWFnZS1kb20tc2l6ZScuLi4KKHNoci16b29tLWltYWdlKTogLi4uIHVzZSBpdC4g IFJlbmFtZSAnc2l6ZScgdG8gJ3pvb20nLgooc2hyLWltYWdlLWZldGNoZWQpOiBSZW5hbWUg J2ltYWdlLXNpemUnIHRvICdpbWFnZS16b29tJy4KKHNoci1wdXQtaW1hZ2UpOiBBY2NlcHQg dGhlIHpvb20gbGV2ZWwgYXMgJzp6b29tJyBhbmQgZG9jdW1lbnQgaXQuClByZXZpb3VzbHks IEZMQUdTIHdhcyBhIG1peCBvZiBhbGlzdCBhbmQgcGxpc3QoISkuCgoqIHRlc3QvbGlzcC9u ZXQvc2hyLXRlc3RzLmVsIChzaHItdGVzdC96b29tLWltYWdlKTogUmVuYW1lICJzaXplIiB0 bwoiem9vbSIuCi0tLQogbGlzcC9uZXQvc2hyLmVsICAgICAgICAgICAgfCAzOCArKysrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQogdGVzdC9saXNwL25ldC9zaHItdGVz dHMuZWwgfCAgNiArKystLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwg MTUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9uZXQvc2hyLmVsIGIvbGlzcC9u ZXQvc2hyLmVsCmluZGV4IDUxNTc2OGUwMzVmLi5hZjg3MWQ3MDk2ZSAxMDA2NDQKLS0tIGEv bGlzcC9uZXQvc2hyLmVsCisrKyBiL2xpc3AvbmV0L3Noci5lbApAQCAtNjMzLDEzICs2MzMs MTQgQEAgc2hyLXpvb20taW1hZ2UKICAgICAgICAgICAgICAgICAgICAgICAocG9pbnQtbWF4 KSkpCiAgICAgICAgICAgICAgKHN0YXJ0IChvciAocHJldmlvdXMtc2luZ2xlLXByb3BlcnR5 LWNoYW5nZSBlbmQgJ2ltYWdlLXVybCkKICAgICAgICAgICAgICAgICAgICAgICAgIChwb2lu dC1taW4pKSkKLSAgICAgICAgICAgICAoc2l6ZSAoZ2V0LXRleHQtcHJvcGVydHkgKHBvaW50 KSAnaW1hZ2Utc2l6ZSkpCi0gICAgICAgICAgICAgKG5leHQtc2l6ZSAoY29uZCAoKG9yIChl cSBzaXplICdkZWZhdWx0KQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo bnVsbCBzaXplKSkKKyAgICAgICAgICAgICAoZG9tLXNpemUgKGdldC10ZXh0LXByb3BlcnR5 IChwb2ludCkgJ2ltYWdlLWRvbS1zaXplKSkKKyAgICAgICAgICAgICAoem9vbSAoZ2V0LXRl eHQtcHJvcGVydHkgKHBvaW50KSAnaW1hZ2Utem9vbSkpCisgICAgICAgICAgICAgKG5leHQt em9vbSAoY29uZCAoKG9yIChlcSB6b29tICdkZWZhdWx0KQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAobnVsbCB6b29tKSkKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAnb3JpZ2luYWwpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoKGVx IHNpemUgJ29yaWdpbmFsKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKChlcSB6 b29tICdvcmlnaW5hbCkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnZnVsbCkK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgoZXEgc2l6ZSAnZnVsbCkKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICgoZXEgem9vbSAnZnVsbCkKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAnZGVmYXVsdCkpKQogICAgICAgICAgICAgIChidWZmZXIt cmVhZC1vbmx5IG5pbCkpCiAgICAgICAgIDs7IERlbGV0ZSB0aGUgb2xkIHBpY3R1cmUuCkBA IC02NDgsNyArNjQ5LDkgQEAgc2hyLXpvb20taW1hZ2UKICAgICAgICAgKHVybC1yZXRyaWV2 ZSB1cmwgIydzaHItaW1hZ2UtZmV0Y2hlZAogICAgICAgICAgICAgICAgICAgICAgIGAoLChj dXJyZW50LWJ1ZmZlcikgLHN0YXJ0CiAgICAgICAgICAgICAgICAgICAgICAgICAsKHNldC1t YXJrZXIgKG1ha2UtbWFya2VyKSBlbmQpCi0gICAgICAgICAgICAgICAgICAgICAgICAoKHNp emUgLiAsbmV4dC1zaXplKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAoOnpvb20gICAs bmV4dC16b29tCisgICAgICAgICAgICAgICAgICAgICAgICAgOndpZHRoICAsKGNhciBkb20t c2l6ZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICA6aGVpZ2h0ICwoY2RyIGRvbS1zaXpl KSkpCiAgICAgICAgICAgICAgICAgICAgICAgdCkpKSkpCiAKIDs7OyBVdGlsaXR5IGZ1bmN0 aW9ucy4KQEAgLTEwOTUsNyArMTA5OCw3IEBAIHNoci1pbWFnZS1mZXRjaGVkCiAJCSAgKHdo aWxlIHByb3BlcnRpZXMKIAkJICAgIChsZXQgKCh0eXBlIChwb3AgcHJvcGVydGllcykpCiAJ CQkgICh2YWx1ZSAocG9wIHByb3BlcnRpZXMpKSkKLQkJICAgICAgKHVubGVzcyAobWVtcSB0 eXBlICcoZGlzcGxheSBpbWFnZS1zaXplKSkKKwkJICAgICAgKHVubGVzcyAobWVtcSB0eXBl ICcoZGlzcGxheSBpbWFnZS16b29tKSkKIAkJCShwdXQtdGV4dC1wcm9wZXJ0eSBzdGFydCAo cG9pbnQpIHR5cGUgdmFsdWUpKSkpKSkpKSkpKQogICAgIChraWxsLWJ1ZmZlciBpbWFnZS1i dWZmZXIpKSkKIApAQCAtMTEzMiw5ICsxMTM1LDE5IEBAIHNoci0taW5saW5lLWltYWdlLXAK IChkZWZ1biBzaHItcHV0LWltYWdlIChzcGVjIGFsdCAmb3B0aW9uYWwgZmxhZ3MpCiAgICJJ bnNlcnQgaW1hZ2UgU1BFQyB3aXRoIGEgc3RyaW5nIEFMVC4gIFJldHVybiBpbWFnZS4KIFNQ RUMgaXMgZWl0aGVyIGFuIGltYWdlIGRhdGEgYmxvYiwgb3IgYSBsaXN0IHdoZXJlIHRoZSBm aXJzdAotZWxlbWVudCBpcyB0aGUgZGF0YSBibG9iIGFuZCB0aGUgc2Vjb25kIGVsZW1lbnQg aXMgdGhlIGNvbnRlbnQtdHlwZS4iCitlbGVtZW50IGlzIHRoZSBkYXRhIGJsb2IgYW5kIHRo ZSBzZWNvbmQgZWxlbWVudCBpcyB0aGUgY29udGVudC10eXBlLgorCitGTEFHUyBpcyBhIHBy b3BlcnR5IGxpc3Qgc3BlY2lmeWluZyBvcHRpb25hbCBwYXJhbWV0ZXJzIGZvciB0aGUgaW1h Z2UuCitZb3UgY2FuIHNwZWNpZnkgdGhlIGZvbGxvd2luZyBvcHRpb25hbCBwcm9wZXJ0aWVz OgorCisqIGA6em9vbSc6IFRoZSB6b29tIGxldmVsIGZvciB0aGUgaW1hZ2UuICBPbmUgb2Yg YGRlZmF1bHQnLCBgb3JpZ2luYWwnLAorICBvciBgZnVsbCcuCisqIGA6d2lkdGgnOiBUaGUg d2lkdGggb2YgdGhlIGltYWdlIGFzIHNwZWNpZmllZCBieSB0aGUgSFRNTCBcIndpZHRoXCIK KyAgYXR0cmlidXRlLgorKiBgOmhlaWdodCc6IFRoZSBoZWlnaHQgb2YgdGhlIGltYWdlIGFz IHNwZWNpZmllZCBieSB0aGUgSFRNTAorICBcImhlaWdodFwiIGF0dHJpYnV0ZS4iCiAgIChp ZiAoZGlzcGxheS1ncmFwaGljLXApCi0gICAgICAobGV0KiAoKHNpemUgKGNkciAoYXNzcSAn c2l6ZSBmbGFncykpKQorICAgICAgKGxldCogKCh6b29tIChwbGlzdC1nZXQgZmxhZ3MgOnpv b20pKQogCSAgICAgKGRhdGEgKGlmIChjb25zcCBzcGVjKQogCQkgICAgICAgKGNhciBzcGVj KQogCQkgICAgIHNwZWMpKQpAQCAtMTE0MiwxMyArMTE1NSwxMyBAQCBzaHItcHV0LWltYWdl CiAJCQkJKGNhZHIgc3BlYykpKQogCSAgICAgKHN0YXJ0IChwb2ludCkpCiAJICAgICAoaW1h Z2UgKGNvbmQKLQkJICAgICAoKGVxIHNpemUgJ29yaWdpbmFsKQorCQkgICAgICgoZXEgem9v bSAnb3JpZ2luYWwpCiAJCSAgICAgIChjcmVhdGUtaW1hZ2UgZGF0YSBuaWwgdCA6YXNjZW50 IHNoci1pbWFnZS1hc2NlbnQKIAkJCQkgICAgOmZvcm1hdCBjb250ZW50LXR5cGUpKQogCQkg ICAgICgoZXEgY29udGVudC10eXBlICdpbWFnZS9zdmcreG1sKQogICAgICAgICAgICAgICAg ICAgICAgICh3aGVuIChpbWFnZS10eXBlLWF2YWlsYWJsZS1wICdzdmcpCiAJCSAgICAgICAg KGNyZWF0ZS1pbWFnZSBkYXRhICdzdmcgdCA6YXNjZW50IHNoci1pbWFnZS1hc2NlbnQpKSkK LQkJICAgICAoKGVxIHNpemUgJ2Z1bGwpCisJCSAgICAgKChlcSB6b29tICdmdWxsKQogCQkg ICAgICAoaWdub3JlLWVycm9ycwogCQkJKHNoci1yZXNjYWxlLWltYWdlIGRhdGEgY29udGVu dC10eXBlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHBs aXN0LWdldCBmbGFncyA6d2lkdGgpCkBAIC0xMTkyLDcgKzEyMDUsNyBAQCBzaHItcHV0LWlt YWdlCiAgICAgICAgICAgICAgICAgICAgICAgOzsgaW1hZ2Ugc2xpY2VzLgogICAgICAgICAg ICAgICAgICAgICAgIChvdmVybGF5LXB1dCBvdmVybGF5ICdmYWNlICdzaHItc2xpY2VkLWlt YWdlKSkpCiAJCShpbnNlcnQtaW1hZ2UgaW1hZ2UgYWx0KSkKLQkgICAgICAocHV0LXRleHQt cHJvcGVydHkgc3RhcnQgKHBvaW50KSAnaW1hZ2Utc2l6ZSBzaXplKQorCSAgICAgIChwdXQt dGV4dC1wcm9wZXJ0eSBzdGFydCAocG9pbnQpICdpbWFnZS16b29tIHpvb20pCiAJICAgICAg KHdoZW4gKGFuZCAobm90IGlubGluZSkgc2hyLW1heC1pbmxpbmUtaW1hZ2Utc2l6ZSkKIAkJ KGluc2VydCAiXG4iKSkKIAkgICAgICAod2hlbiAoYW5kIHNoci1pbWFnZS1hbmltYXRlCkBA IC0xOTA3LDYgKzE5MjAsNyBAQCBzaHItdGFnLWltZwogCSAgKHB1dC10ZXh0LXByb3BlcnR5 IHN0YXJ0IChwb2ludCkgJ2tleW1hcCBzaHItaW1hZ2UtbWFwKQogCSAgKHB1dC10ZXh0LXBy b3BlcnR5IHN0YXJ0IChwb2ludCkgJ3Noci1hbHQgYWx0KQogCSAgKHB1dC10ZXh0LXByb3Bl cnR5IHN0YXJ0IChwb2ludCkgJ2ltYWdlLXVybCB1cmwpCisJICAocHV0LXRleHQtcHJvcGVy dHkgc3RhcnQgKHBvaW50KSAnaW1hZ2UtZG9tLXNpemUgKGNvbnMgd2lkdGggaGVpZ2h0KSkK IAkgIChwdXQtdGV4dC1wcm9wZXJ0eSBzdGFydCAocG9pbnQpICdpbWFnZS1kaXNwbGF5ZXIK IAkJCSAgICAgKHNoci1pbWFnZS1kaXNwbGF5ZXIgc2hyLWNvbnRlbnQtZnVuY3Rpb24pKQog CSAgKHB1dC10ZXh0LXByb3BlcnR5IHN0YXJ0IChwb2ludCkgJ2hlbHAtZWNobwpkaWZmIC0t Z2l0IGEvdGVzdC9saXNwL25ldC9zaHItdGVzdHMuZWwgYi90ZXN0L2xpc3AvbmV0L3Noci10 ZXN0cy5lbAppbmRleCA3MDFlNzNkYzRmZS4uNTQyZTk0MGE0YjkgMTAwNjQ0Ci0tLSBhL3Rl c3QvbGlzcC9uZXQvc2hyLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9uZXQvc2hyLXRlc3Rz LmVsCkBAIC0xNjYsMTQgKzE2NiwxNCBAQCBzaHItdGVzdC96b29tLWltYWdlCiAgICAgICAg ICAgICAoc2hyLXpvb20taW1hZ2UpCiAgICAgICAgICAgICAoc2hyLXRlc3Qtd2FpdC1mb3Ig KGxhbWJkYSAoKSAoPSBwdXQtaW1hZ2UtY2FsbHMgMikpKQogICAgICAgICAgICAgOzsgQ2hl Y2sgdGhhdCB3ZSBoYXZlIGEgc2luZ2xlIGltYWdlIGF0IG9yaWdpbmFsIHNpemUuCi0gICAg ICAgICAgICAobGV0IChpbWFnZS1zaXplcykKKyAgICAgICAgICAgIChsZXQgKGltYWdlLXpv b21zKQogICAgICAgICAgICAgICAoZ290by1jaGFyIChwb2ludC1taW4pKQogICAgICAgICAg ICAgICAod2hpbGUgKDwgKHBvaW50KSAocG9pbnQtbWF4KSkKICAgICAgICAgICAgICAgICAo d2hlbiAoZ2V0LXRleHQtcHJvcGVydHkgKHBvaW50KSAnZGlzcGxheSkKLSAgICAgICAgICAg ICAgICAgIChwdXNoIChnZXQtdGV4dC1wcm9wZXJ0eSAocG9pbnQpICdpbWFnZS1zaXplKSBp bWFnZS1zaXplcykpCisgICAgICAgICAgICAgICAgICAocHVzaCAoZ2V0LXRleHQtcHJvcGVy dHkgKHBvaW50KSAnaW1hZ2Utem9vbSkgaW1hZ2Utem9vbXMpKQogICAgICAgICAgICAgICAg IChnb3RvLWNoYXIgKG9yIChuZXh0LXNpbmdsZS1wcm9wZXJ0eS1jaGFuZ2UgKHBvaW50KSAn ZGlzcGxheSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAocG9pbnQtbWF4KSkp KQotICAgICAgICAgICAgICAoc2hvdWxkIChlcXVhbCBpbWFnZS1zaXplcyAnKG9yaWdpbmFs KSkpKSkpKSkpKQorICAgICAgICAgICAgICAoc2hvdWxkIChlcXVhbCBpbWFnZS16b29tcyAn KG9yaWdpbmFsKSkpKSkpKSkpKQogCiAocmVxdWlyZSAnc2hyKQogCi0tIAoyLjI1LjEKCg== --------------nnNzqGvYBJRrCg7j6NO56LV9 Content-Type: text/plain; charset=UTF-8; name="0003-Fix-the-different-image-zoom-levels-in-SHR-to-work-a.patch" Content-Disposition: attachment; filename*0="0003-Fix-the-different-image-zoom-levels-in-SHR-to-work-a.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAwNzY3ZGNlNWI5MzFmNjUzZTFkNzQyYzFiMWI3YzI1NzVjOGQ5ZTQyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjMgSnVuIDIwMjQgMTQ6NDg6MzIgLTA3MDAKU3ViamVjdDogW1BB VENIIDMvNF0gRml4IHRoZSBkaWZmZXJlbnQgaW1hZ2Ugem9vbSBsZXZlbHMgaW4gU0hSIHRv IHdvcmsgYXMKIGV4cGVjdGVkCgoqIGxpc3AvbmV0L3Noci5lbCAoc2hyLWltYWdlLXpvb20t bGV2ZWxzKTogTmV3IG9wdGlvbi4KKHNoci1pbWFnZS16b29tLWxldmVsLWFsaXN0KTogTmV3 IHZhcmlhYmxlLgooc2hyLXpvb20taW1hZ2UpOiBUYWtlIFBPU0lUSU9OIGFuZCBaT09NLUxF VkVMIGFyZ3VtZW50cy4gIENvbnN1bHQKJ3Noci1pbWFnZS16b29tLWxldmVscycuCihzaHIt cHV0LWltYWdlKTogVXNlICdzaHItaW1hZ2Utem9vbS1sZXZlbC1hbGlzdCcuCihzaHItcmVz Y2FsZS1pbWFnZSk6IE9ubHkgcmVzZXQgd2lkdGggKm9yKiBoZWlnaHQgd2hlbiBlaXRoZXIg aXMgdG9vCmxhcmdlLgooc2hyLS1pbWFnZS16b29tLW9yaWdpbmFsLXNpemUsIHNoci0taW1h Z2Utem9vbS1pbWFnZS1zaXplKQooc2hyLS1pbWFnZS16b29tLWZpbGwtaGVpZ2h0KTogTmV3 IGZ1bmN0aW9ucy4KCiogZXRjL05FV1M6IEFubm91bmNlIHRoaXMgY2hhbmdlLgotLS0KIGV0 Yy9ORVdTICAgICAgICB8ICAgNSArKwogbGlzcC9uZXQvc2hyLmVsIHwgMTM5ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFu Z2VkLCA5MyBpbnNlcnRpb25zKCspLCA1MSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9l dGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IDNmNDk2OWRhODczLi43YmZiMTM3OTU3NCAxMDA2 NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTQ3LDYgKzQ3LDExIEBAIFlv dSBjYW4gc2V0IHRoZSBtYXhpbXVtIHNpemUgZm9yIHVuc2xpY2VkIGltYWdlcyB3aXRoIHRo ZSBvcHRpb24KICdzaHItc2xpY2VkLWltYWdlLXByb3BvcnRpb24nLiAgRm9yIG1vcmUgaW5m b3JtYXRpb24sIHNlZSB0aGUgIihld3cpCiBBZHZhbmNlZCIgbm9kZSBpbiB0aGUgRVdXIG1h bnVhbC4KIAorLS0tCisqKiogWW91IGNhbiBub3cgY3VzdG9taXplIHRoZSBpbWFnZSB6b29t IGxldmVscyB0byBjeWNsZSB0aHJvdWdoLgorQnkgY3VzdG9taXppbmcgJ3Noci1pbWFnZS16 b29tLWxldmVscycsIHlvdSBjYW4gY2hhbmdlIHRoZSBsaXN0IG9mIHpvb20KK2xldmVscyB0 aGF0IFNIUiBjeWNsZXMgdGhyb3VnaCB3aGVuIGNhbGxpbmcgJ3Noci16b29tLWltYWdlJy4K KwogDAogKiBOZXcgTW9kZXMgYW5kIFBhY2thZ2VzIGluIEVtYWNzIDMxLjEKIApkaWZmIC0t Z2l0IGEvbGlzcC9uZXQvc2hyLmVsIGIvbGlzcC9uZXQvc2hyLmVsCmluZGV4IGFmODcxZDcw OTZlLi41OWRkMmMwMzJlZCAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvc2hyLmVsCisrKyBiL2xp c3AvbmV0L3Noci5lbApAQCAtMjE5LDYgKzIxOSwyNSBAQCBzaHItbWF4LWlubGluZS1pbWFn ZS1zaXplCiAgIDp2ZXJzaW9uICIzMC4xIgogICA6dHlwZSAnKGNob2ljZSAoY29uc3Qgbmls KSAoY29ucyBudW1iZXIgbnVtYmVyKSkpCiAKKyhkZWZjdXN0b20gc2hyLWltYWdlLXpvb20t bGV2ZWxzICcoZml0IG9yaWdpbmFsIGZpbGwtaGVpZ2h0KQorICAiQSBsaXN0IG9mIGltYWdl IHpvb20gbGV2ZWxzIHRvIGN5Y2xlIHRocm91Z2ggd2l0aCBgc2hyLXpvb20taW1hZ2UnLgor VGhlIGZpcnN0IGVsZW1lbnQgaW4gdGhlIGxpc3QgaXMgdGhlIGluaXRpYWwgem9vbSBsZXZl bC4gIEVhY2ggZWxlbWVudAorY2FuIGJlIG9uZSBvZiB0aGUgZm9sbG93aW5nIHN5bWJvbHM6 CisKKyogYGZpdCc6IERpc3BsYXkgdGhlIGltYWdlIGF0IGl0cyBvcmlnaW5hbCBzaXplIGFz IHJlcXVlc3RlZCBieSB0aGUKKyAgcGFnZSwgc2hyaW5raW5nIGl0IHRvIGZpdCBpbiB0aGUg Y3VycmVudCB3aW5kb3cgaWYgbmVjZXNzYXJ5LgorKiBgb3JpZ2luYWwnOiBEaXNwbGF5IHRo ZSBpbWFnZSBhdCBpdHMgb3JpZ2luYWwgc2l6ZSBhcyByZXF1ZXN0ZWQgYnkgdGhlCisgIHBh Z2UuCisqIGBpbWFnZSc6IERpc3BsYXkgdGhlIGltYWdlIGF0IGl0cyBmdWxsIHNpemUgKGln bm9yaW5nIHRoZSB3aWR0aC9oZWlnaHQKKyAgc3BlY2lmaWVkIGJ5IHRoZSBIVE1MKS4KKyog YGZpbGwtaGVpZ2h0JzogRGlzcGxheSB0aGUgaW1hZ2Ugem9vbWVkIHRvIGZpbGwgdGhlIGhl aWdodCBvZiB0aGUKK2N1cnJlbnQgd2luZG93LiIKKyAgOnZlcnNpb24gIjMxLjEiCisgIDp0 eXBlICcoc2V0IChjaG9pY2UgKGNvbnN0IDp0YWcgIkZpdCB0byB3aW5kb3cgc2l6ZSIgZml0 KQorICAgICAgICAgICAgICAgICAgICAgIChjb25zdCA6dGFnICJPcmlnaW5hbCBzaXplIiBv cmlnaW5hbCkKKyAgICAgICAgICAgICAgICAgICAgICAoY29uc3QgOnRhZyAiRnVsbCBpbWFn ZSBzaXplIiBpbWFnZSkKKyAgICAgICAgICAgICAgICAgICAgICAoY29uc3QgOnRhZyAiRmls bCB3aW5kb3cgaGVpZ2h0IiBmaWxsLWhlaWdodCkpKSkKKwogKGRlZnZhciBzaHItY29udGVu dC1mdW5jdGlvbiBuaWwKICAgIklmIGJvdW5kLCB0aGlzIHNob3VsZCBiZSBhIGZ1bmN0aW9u IHRoYXQgd2lsbCByZXR1cm4gdGhlIGNvbnRlbnQuCiBUaGlzIGlzIHVzZWQgZm9yIGNpZDog VVJMcywgYW5kIHRoZSBmdW5jdGlvbiBpcyBjYWxsZWQgd2l0aCB0aGUKQEAgLTYyMSwzNSAr NjQwLDUyIEBAIHNoci1pbnNlcnQtaW1hZ2UKIAkJICAgIChsaXN0IChjdXJyZW50LWJ1ZmZl cikgKDEtIChwb2ludCkpIChwb2ludC1tYXJrZXIpKQogCQkgICAgdCkpKSkKIAotKGRlZnVu IHNoci16b29tLWltYWdlICgpCi0gICJDeWNsZSB0aGUgaW1hZ2Ugc2l6ZS4KKyhkZWZ2YXIg c2hyLWltYWdlLXpvb20tbGV2ZWwtYWxpc3QKKyAgYCgoZml0ICAgICAgICAgIlpvb20gdG8g Zml0IiAgICAgICAgICAgICAgICBzaHItcmVzY2FsZS1pbWFnZSkKKyAgICAob3JpZ2luYWwg ICAgIlpvb20gdG8gb3JpZ2luYWwgc2l6ZSIgICAgICBzaHItLWltYWdlLXpvb20tb3JpZ2lu YWwtc2l6ZSkKKyAgICAoaW1hZ2UgICAgICAgIlpvb20gdG8gZnVsbCBpbWFnZSBzaXplIiAg ICBzaHItLWltYWdlLXpvb20taW1hZ2Utc2l6ZSkKKyAgICAoZmlsbC1oZWlnaHQgIlpvb20g dG8gZmlsbCB3aW5kb3cgaGVpZ2h0IiBzaHItLWltYWdlLXpvb20tZmlsbC1oZWlnaHQpKQor ICAiQW4gYWxpc3Qgb2YgcG9zc2libGUgaW1hZ2Ugem9vbSBsZXZlbHMuCitFYWNoIGVsZW1l bnQgaXMgb2YgdGhlIGZvcm0gKFNZTUJPTCBERVNDIEZVTkNUSU9OKS4gIFNZTUJPTCBpcyB0 aGUKK3N5bWJvbCBpZGVudGlmeWluZyB0aGlzIGxldmVsLCBhcyB1c2VkIGJ5IGBzaHItaW1h Z2Utem9vbS1sZXZlbHMnICh3aGljaAorc2VlKS4gIERFU0MgaXMgYSBzdHJpbmcgZGVzY3Jp YmluZyB0aGUgbGV2ZWwuCisKK0ZVTkNUSU9OIGlzIGEgZnVuY3Rpb24gdGhhdCByZXR1cm5z IGEgcHJvcGVybHktem9vbWVkIGltYWdlOyBpdCB0YWtlcwordGhlIGZvbGxvd2luZyBhcmd1 bWVudHM6CisKKyogREFUQTogVGhlIGltYWdlIGRhdGEgaW4gc3RyaW5nIGZvcm0uCisqIENP TlRFTlQtVFlQRTogVGhlIGNvbnRlbnQtdHlwZSBvZiB0aGUgaW1hZ2UsIGlmIGFueS4KKyog V0lEVEg6IFRoZSB3aWR0aCBhcyBzcGVjaWZpZWQgYnkgdGhlIEhUTUwgXCJ3aWR0aFwiIGF0 dHJpYnV0ZSwgaWYgYW55LgorKiBIRUlHSFQ6IFRoZSBoZWlnaHQgYXMgc3BlY2lmaWVkIGJ5 IHRoZSBIVE1MIFwiaGVpZ2h0XCIgYXR0cmlidXRlLCBpZgorICBhbnkuIikKKworKGRlZnVu IHNoci16b29tLWltYWdlICgmb3B0aW9uYWwgcG9zaXRpb24gem9vbS1sZXZlbCkKKyAgIkNo YW5nZSB0aGUgem9vbSBsZXZlbCBvZiB0aGUgaW1hZ2UgYXQgUE9TSVRJT04uCisKIFRoZSBz aXplIHdpbGwgY3ljbGUgdGhyb3VnaCB0aGUgZGVmYXVsdCBzaXplLCB0aGUgb3JpZ2luYWwg c2l6ZSwgYW5kCiBmdWxsLWJ1ZmZlciBzaXplLiIKLSAgKGludGVyYWN0aXZlKQotICAobGV0 ICgodXJsIChnZXQtdGV4dC1wcm9wZXJ0eSAocG9pbnQpICdpbWFnZS11cmwpKSkKKyAgKGlu dGVyYWN0aXZlICJkIikKKyAgKHVubGVzcyBwb3NpdGlvbiAoc2V0cSBwb3NpdGlvbiAocG9p bnQpKSkKKyAgKGxldCAoKHVybCAoZ2V0LXRleHQtcHJvcGVydHkgcG9zaXRpb24gJ2ltYWdl LXVybCkpKQogICAgIChpZiAobm90IHVybCkKIAkobWVzc2FnZSAiTm8gaW1hZ2UgdW5kZXIg cG9pbnQiKQotICAgICAgKGxldCogKChlbmQgKG9yIChuZXh0LXNpbmdsZS1wcm9wZXJ0eS1j aGFuZ2UgKHBvaW50KSAnaW1hZ2UtdXJsKQorICAgICAgKHVubGVzcyB6b29tLWxldmVsCisg ICAgICAgIChsZXQgKChsYXN0LXpvb20gKGdldC10ZXh0LXByb3BlcnR5IHBvc2l0aW9uICdp bWFnZS16b29tKSkpCisgICAgICAgICAgKHNldHEgem9vbS1sZXZlbCAob3IgKGNhZHIgKG1l bXEgbGFzdC16b29tIHNoci1pbWFnZS16b29tLWxldmVscykpCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKGNhciBzaHItaW1hZ2Utem9vbS1sZXZlbHMpKSkpKQorICAgICAg KGxldCogKChlbmQgKG9yIChuZXh0LXNpbmdsZS1wcm9wZXJ0eS1jaGFuZ2UgcG9zaXRpb24g J2ltYWdlLXVybCkKICAgICAgICAgICAgICAgICAgICAgICAocG9pbnQtbWF4KSkpCiAgICAg ICAgICAgICAgKHN0YXJ0IChvciAocHJldmlvdXMtc2luZ2xlLXByb3BlcnR5LWNoYW5nZSBl bmQgJ2ltYWdlLXVybCkKICAgICAgICAgICAgICAgICAgICAgICAgIChwb2ludC1taW4pKSkK LSAgICAgICAgICAgICAoZG9tLXNpemUgKGdldC10ZXh0LXByb3BlcnR5IChwb2ludCkgJ2lt YWdlLWRvbS1zaXplKSkKLSAgICAgICAgICAgICAoem9vbSAoZ2V0LXRleHQtcHJvcGVydHkg KHBvaW50KSAnaW1hZ2Utem9vbSkpCi0gICAgICAgICAgICAgKG5leHQtem9vbSAoY29uZCAo KG9yIChlcSB6b29tICdkZWZhdWx0KQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAobnVsbCB6b29tKSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnb3Jp Z2luYWwpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoKGVxIHpvb20gJ29yaWdp bmFsKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdmdWxsKQotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKChlcSB6b29tICdmdWxsKQotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICdkZWZhdWx0KSkpCisgICAgICAgICAgICAgKGRvbS1zaXplIChn ZXQtdGV4dC1wcm9wZXJ0eSBwb3NpdGlvbiAnaW1hZ2UtZG9tLXNpemUpKQogICAgICAgICAg ICAgIChidWZmZXItcmVhZC1vbmx5IG5pbCkpCiAgICAgICAgIDs7IERlbGV0ZSB0aGUgb2xk IHBpY3R1cmUuCiAgICAgICAgIChwdXQtdGV4dC1wcm9wZXJ0eSBzdGFydCBlbmQgJ2Rpc3Bs YXkgbmlsKQotICAgICAgICAobWVzc2FnZSAiSW5zZXJ0aW5nICVzLi4uIiB1cmwpCisgICAg ICAgIChtZXNzYWdlICIlcyIgKGNhZHIgKGFzc3Egem9vbS1sZXZlbCBzaHItaW1hZ2Utem9v bS1sZXZlbC1hbGlzdCkpKQogICAgICAgICAodXJsLXJldHJpZXZlIHVybCAjJ3Noci1pbWFn ZS1mZXRjaGVkCiAgICAgICAgICAgICAgICAgICAgICAgYCgsKGN1cnJlbnQtYnVmZmVyKSAs c3RhcnQKICAgICAgICAgICAgICAgICAgICAgICAgICwoc2V0LW1hcmtlciAobWFrZS1tYXJr ZXIpIGVuZCkKLSAgICAgICAgICAgICAgICAgICAgICAgICg6em9vbSAgICxuZXh0LXpvb20K KyAgICAgICAgICAgICAgICAgICAgICAgICg6em9vbSAgICx6b29tLWxldmVsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgOndpZHRoICAsKGNhciBkb20tc2l6ZSkKICAgICAgICAgICAg ICAgICAgICAgICAgICA6aGVpZ2h0ICwoY2RyIGRvbS1zaXplKSkpCiAgICAgICAgICAgICAg ICAgICAgICAgdCkpKSkpCkBAIC0xMTQ3LDcgKzExODMsOSBAQCBzaHItcHV0LWltYWdlCiAq IGA6aGVpZ2h0JzogVGhlIGhlaWdodCBvZiB0aGUgaW1hZ2UgYXMgc3BlY2lmaWVkIGJ5IHRo ZSBIVE1MCiAgIFwiaGVpZ2h0XCIgYXR0cmlidXRlLiIKICAgKGlmIChkaXNwbGF5LWdyYXBo aWMtcCkKLSAgICAgIChsZXQqICgoem9vbSAocGxpc3QtZ2V0IGZsYWdzIDp6b29tKSkKKyAg ICAgIChsZXQqICgoem9vbSAob3IgKHBsaXN0LWdldCBmbGFncyA6em9vbSkKKyAgICAgICAg ICAgICAgICAgICAgICAgKGNhciBzaHItaW1hZ2Utem9vbS1sZXZlbHMpKSkKKyAgICAgICAg ICAgICAoem9vbS1mdW5jdGlvbiAobnRoIDIgKGFzc3Egem9vbSBzaHItaW1hZ2Utem9vbS1s ZXZlbC1hbGlzdCkpKQogCSAgICAgKGRhdGEgKGlmIChjb25zcCBzcGVjKQogCQkgICAgICAg KGNhciBzcGVjKQogCQkgICAgIHNwZWMpKQpAQCAtMTE1NSwyMiArMTE5MywxNSBAQCBzaHIt cHV0LWltYWdlCiAJCQkJKGNhZHIgc3BlYykpKQogCSAgICAgKHN0YXJ0IChwb2ludCkpCiAJ ICAgICAoaW1hZ2UgKGNvbmQKLQkJICAgICAoKGVxIHpvb20gJ29yaWdpbmFsKQotCQkgICAg ICAoY3JlYXRlLWltYWdlIGRhdGEgbmlsIHQgOmFzY2VudCBzaHItaW1hZ2UtYXNjZW50Ci0J CQkJICAgIDpmb3JtYXQgY29udGVudC10eXBlKSkKIAkJICAgICAoKGVxIGNvbnRlbnQtdHlw ZSAnaW1hZ2Uvc3ZnK3htbCkKICAgICAgICAgICAgICAgICAgICAgICAod2hlbiAoaW1hZ2Ut dHlwZS1hdmFpbGFibGUtcCAnc3ZnKQogCQkgICAgICAgIChjcmVhdGUtaW1hZ2UgZGF0YSAn c3ZnIHQgOmFzY2VudCBzaHItaW1hZ2UtYXNjZW50KSkpCi0JCSAgICAgKChlcSB6b29tICdm dWxsKQotCQkgICAgICAoaWdub3JlLWVycm9ycwotCQkJKHNoci1yZXNjYWxlLWltYWdlIGRh dGEgY29udGVudC10eXBlCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKHBsaXN0LWdldCBmbGFncyA6d2lkdGgpCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKHBsaXN0LWdldCBmbGFncyA6aGVpZ2h0KSkpKQotCQkg ICAgICh0Ci0JCSAgICAgIChpZ25vcmUtZXJyb3JzCi0JCQkoc2hyLXJlc2NhbGUtaW1hZ2Ug ZGF0YSBjb250ZW50LXR5cGUKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAocGxpc3QtZ2V0IGZsYWdzIDp3aWR0aCkKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAocGxpc3QtZ2V0IGZsYWdzIDpoZWlnaHQpKSkpKSkp CisgICAgICAgICAgICAgICAgICAgICAoem9vbS1mdW5jdGlvbgorICAgICAgICAgICAgICAg ICAgICAgIChpZ25vcmUtZXJyb3JzCisgICAgICAgICAgICAgICAgICAgICAgICAoZnVuY2Fs bCB6b29tLWZ1bmN0aW9uIGRhdGEgY29udGVudC10eXBlCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAocGxpc3QtZ2V0IGZsYWdzIDp3aWR0aCkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChwbGlzdC1nZXQgZmxhZ3MgOmhlaWdodCkpKSkKKyAgICAg ICAgICAgICAgICAgICAgICh0IChlcnJvciAiVW5yZWNvZ25pemVkIHpvb20gbGV2ZWwgJXMi IHpvb20pKSkpKQogICAgICAgICAod2hlbiBpbWFnZQogICAgICAgICAgIDs7IFRoZSB0cmFp bGluZyBzcGFjZSBjYW4gY29uZnVzZSBzaHItaW5zZXJ0IGludG8gbm90CiAgICAgICAgICAg OzsgcHV0dGluZyBhbnkgc3BhY2UgYWZ0ZXIgaW5saW5lIGltYWdlcy4KQEAgLTEyNDMsMjcg KzEyNzQsMzMgQEAgc2hyLXJlc2NhbGUtaW1hZ2UKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIChvciBtYXgtaGVpZ2h0CiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKC0gKG50aCAzIGVkZ2VzKSAobnRoIDEgZWRnZXMpKSkpKSkKICAg ICAgICAgICAgKHNjYWxpbmcgKGltYWdlLWNvbXB1dGUtc2NhbGluZy1mYWN0b3IgaW1hZ2Ut c2NhbGluZy1mYWN0b3IpKSkKLSAgICAgICh3aGVuIChvciAoYW5kIHdpZHRoCi0gICAgICAg ICAgICAgICAgICAgICAoPiB3aWR0aCBtYXgtd2lkdGgpKQotICAgICAgICAgICAgICAgIChh bmQgaGVpZ2h0Ci0gICAgICAgICAgICAgICAgICAgICAoPiBoZWlnaHQgbWF4LWhlaWdodCkp KQotICAgICAgICAoc2V0cSB3aWR0aCBuaWwKLSAgICAgICAgICAgICAgaGVpZ2h0IG5pbCkp Ci0gICAgICAoaWYgKGFuZCB3aWR0aCBoZWlnaHQKLSAgICAgICAgICAgICAgICg8ICgqIHdp ZHRoIHNjYWxpbmcpIG1heC13aWR0aCkKLSAgICAgICAgICAgICAgICg8ICgqIGhlaWdodCBz Y2FsaW5nKSBtYXgtaGVpZ2h0KSkKLSAgICAgICAgICAoY3JlYXRlLWltYWdlCi0gICAgICAg ICAgIGRhdGEgKHNoci0taW1hZ2UtdHlwZSkgdAotICAgICAgICAgICA6YXNjZW50IHNoci1p bWFnZS1hc2NlbnQKLSAgICAgICAgICAgOndpZHRoIHdpZHRoCi0gICAgICAgICAgIDpoZWln aHQgaGVpZ2h0Ci0gICAgICAgICAgIDpmb3JtYXQgY29udGVudC10eXBlKQotICAgICAgICAo Y3JlYXRlLWltYWdlCi0gICAgICAgICBkYXRhIChzaHItLWltYWdlLXR5cGUpIHQKLSAgICAg ICAgIDphc2NlbnQgc2hyLWltYWdlLWFzY2VudAotICAgICAgICAgOm1heC13aWR0aCBtYXgt d2lkdGgKLSAgICAgICAgIDptYXgtaGVpZ2h0IG1heC1oZWlnaHQKLSAgICAgICAgIDpmb3Jt YXQgY29udGVudC10eXBlKSkpKSkKKyAgICAgICh3aGVuIChhbmQgd2lkdGggKD4gKCogd2lk dGggc2NhbGluZykgbWF4LXdpZHRoKSkKKyAgICAgICAgKHNldHEgd2lkdGggbmlsKSkKKyAg ICAgICh3aGVuIChhbmQgaGVpZ2h0ICg+ICgqIGhlaWdodCBzY2FsaW5nKSBtYXgtaGVpZ2h0 KSkKKyAgICAgICAgKHNldHEgaGVpZ2h0IG5pbCkpCisgICAgICAoY3JlYXRlLWltYWdlCisg ICAgICAgZGF0YSAoc2hyLS1pbWFnZS10eXBlKSB0CisgICAgICAgOmFzY2VudCBzaHItaW1h Z2UtYXNjZW50CisgICAgICAgOndpZHRoIHdpZHRoCisgICAgICAgOmhlaWdodCBoZWlnaHQK KyAgICAgICA6bWF4LXdpZHRoIG1heC13aWR0aAorICAgICAgIDptYXgtaGVpZ2h0IG1heC1o ZWlnaHQKKyAgICAgICA6Zm9ybWF0IGNvbnRlbnQtdHlwZSkpKSkKKworKGRlZnVuIHNoci0t aW1hZ2Utem9vbS1vcmlnaW5hbC1zaXplIChkYXRhIGNvbnRlbnQtdHlwZSB3aWR0aCBoZWln aHQpCisgIChjcmVhdGUtaW1hZ2UgZGF0YSAoc2hyLS1pbWFnZS10eXBlKSB0IDphc2NlbnQg c2hyLWltYWdlLWFzY2VudAorICAgICAgICAgICAgICAgIDp3aWR0aCB3aWR0aCA6aGVpZ2h0 IGhlaWdodCA6Zm9ybWF0IGNvbnRlbnQtdHlwZSkpCisKKyhkZWZ1biBzaHItLWltYWdlLXpv b20taW1hZ2Utc2l6ZSAoZGF0YSBjb250ZW50LXR5cGUgX3dpZHRoIF9oZWlnaHQpCisgIChj cmVhdGUtaW1hZ2UgZGF0YSBuaWwgdCA6YXNjZW50IHNoci1pbWFnZS1hc2NlbnQgOmZvcm1h dCBjb250ZW50LXR5cGUpKQorCisoZGVmdW4gc2hyLS1pbWFnZS16b29tLWZpbGwtaGVpZ2h0 IChkYXRhIGNvbnRlbnQtdHlwZSBfd2lkdGggX2hlaWdodCkKKyAgKGxldCogKChlZGdlcyAo d2luZG93LWluc2lkZS1waXhlbC1lZGdlcworICAgICAgICAgICAgICAgICAoZ2V0LWJ1ZmZl ci13aW5kb3cgKGN1cnJlbnQtYnVmZmVyKSkpKQorICAgICAgICAgKGhlaWdodCAodHJ1bmNh dGUgKCogc2hyLW1heC1pbWFnZS1wcm9wb3J0aW9uCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAoLSAobnRoIDMgZWRnZXMpIChudGggMSBlZGdlcykpKSkpKQorICAgIChjcmVh dGUtaW1hZ2UgZGF0YSAoc2hyLS1pbWFnZS10eXBlKSB0IDphc2NlbnQgc2hyLWltYWdlLWFz Y2VudAorICAgICAgICAgICAgICAgICAgOmhlaWdodCBoZWlnaHQgOmZvcm1hdCBjb250ZW50 LXR5cGUpKSkKIAogOzsgdXJsLWNhY2hlLWV4dHJhY3QgYXV0b2xvYWRzIHVybC1jYWNoZS4K IChkZWNsYXJlLWZ1bmN0aW9uIHVybC1jYWNoZS1jcmVhdGUtZmlsZW5hbWUgInVybC1jYWNo ZSIgKHVybCkpCi0tIAoyLjI1LjEKCg== --------------nnNzqGvYBJRrCg7j6NO56LV9 Content-Type: text/plain; charset=UTF-8; name="0004-In-SHR-load-from-URL-cache-if-possible-when-zooming-.patch" Content-Disposition: attachment; filename*0="0004-In-SHR-load-from-URL-cache-if-possible-when-zooming-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBkMzVkZDRhYzA3YjQ2MDY4ZmQzMDY2OTFjMjU1NDRjNGFmN2EzNGQwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjMgSnVuIDIwMjQgMTQ6NTM6NDkgLTA3MDAKU3ViamVjdDogW1BB VENIIDQvNF0gSW4gU0hSLCBsb2FkIGZyb20gVVJMIGNhY2hlIGlmIHBvc3NpYmxlIHdoZW4g em9vbWluZwogaW1hZ2VzCgoqIGxpc3AvbmV0L3Noci5lbCAoc2hyLXJlcGxhY2UtaW1hZ2Up OiBOZXcgZnVuY3Rpb24gZXh0cmFjdGVkIGZyb20uLi4KKHNoci1pbWFnZS1mZXRjaGVkKTog Li4uIGhlcmUuCihzaHItem9vbS1pbWFnZSk6IENoZWNrIFVSTCBjYWNoZSBhbmQgY2FsbCAn c2hyLXJlcGxhY2UtaW1hZ2UnIGlmIHdlCmNhbi4KLS0tCiBsaXNwL25ldC9zaHIuZWwgfCA1 NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAx IGZpbGUgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygrKSwgMjQgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvbGlzcC9uZXQvc2hyLmVsIGIvbGlzcC9uZXQvc2hyLmVsCmluZGV4IDU5ZGQy YzAzMmVkLi5mMDE3NjE4NzRiZiAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvc2hyLmVsCisrKyBi L2xpc3AvbmV0L3Noci5lbApAQCAtNjc4LDE3ICs2NzgsMjIgQEAgc2hyLXpvb20taW1hZ2UK ICAgICAgICAgICAgICAoc3RhcnQgKG9yIChwcmV2aW91cy1zaW5nbGUtcHJvcGVydHktY2hh bmdlIGVuZCAnaW1hZ2UtdXJsKQogICAgICAgICAgICAgICAgICAgICAgICAgKHBvaW50LW1p bikpKQogICAgICAgICAgICAgIChkb20tc2l6ZSAoZ2V0LXRleHQtcHJvcGVydHkgcG9zaXRp b24gJ2ltYWdlLWRvbS1zaXplKSkKKyAgICAgICAgICAgICAoZmxhZ3MgYCggOnpvb20gICAs em9vbS1sZXZlbAorICAgICAgICAgICAgICAgICAgICAgICA6d2lkdGggICwoY2FyIGRvbS1z aXplKQorICAgICAgICAgICAgICAgICAgICAgICA6aGVpZ2h0ICwoY2RyIGRvbS1zaXplKSkp CiAgICAgICAgICAgICAgKGJ1ZmZlci1yZWFkLW9ubHkgbmlsKSkKICAgICAgICAgOzsgRGVs ZXRlIHRoZSBvbGQgcGljdHVyZS4KICAgICAgICAgKHB1dC10ZXh0LXByb3BlcnR5IHN0YXJ0 IGVuZCAnZGlzcGxheSBuaWwpCiAgICAgICAgIChtZXNzYWdlICIlcyIgKGNhZHIgKGFzc3Eg em9vbS1sZXZlbCBzaHItaW1hZ2Utem9vbS1sZXZlbC1hbGlzdCkpKQotICAgICAgICAodXJs LXJldHJpZXZlIHVybCAjJ3Noci1pbWFnZS1mZXRjaGVkCi0gICAgICAgICAgICAgICAgICAg ICAgYCgsKGN1cnJlbnQtYnVmZmVyKSAsc3RhcnQKLSAgICAgICAgICAgICAgICAgICAgICAg ICwoc2V0LW1hcmtlciAobWFrZS1tYXJrZXIpIGVuZCkKLSAgICAgICAgICAgICAgICAgICAg ICAgICg6em9vbSAgICx6b29tLWxldmVsCi0gICAgICAgICAgICAgICAgICAgICAgICAgOndp ZHRoICAsKGNhciBkb20tc2l6ZSkKLSAgICAgICAgICAgICAgICAgICAgICAgICA6aGVpZ2h0 ICwoY2RyIGRvbS1zaXplKSkpCi0gICAgICAgICAgICAgICAgICAgICAgdCkpKSkpCisgICAg ICAgIChpZiAoYW5kIChub3Qgc2hyLWlnbm9yZS1jYWNoZSkKKyAgICAgICAgICAgICAgICAg KHVybC1pcy1jYWNoZWQgdXJsKSkKKyAgICAgICAgICAgIChzaHItcmVwbGFjZS1pbWFnZSAo c2hyLWdldC1pbWFnZS1kYXRhIHVybCkgc3RhcnQKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAoc2V0LW1hcmtlciAobWFrZS1tYXJrZXIpIGVuZCkgZmxhZ3MpCisgICAgICAg ICAgKHVybC1yZXRyaWV2ZSB1cmwgIydzaHItaW1hZ2UtZmV0Y2hlZAorICAgICAgICAgICAg ICAgICAgICAgICAgYCgsKGN1cnJlbnQtYnVmZmVyKSAsc3RhcnQKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgLChzZXQtbWFya2VyIChtYWtlLW1hcmtlcikgZW5kKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAsZmxhZ3MpCisgICAgICAgICAgICAgICAgICAgICAgICB0KSkp KSkpCiAKIDs7OyBVdGlsaXR5IGZ1bmN0aW9ucy4KIApAQCAtMTEwOSw2ICsxMTE0LDI1IEBA IHNoci1zdG9yZS1jb250ZW50cwogCQkgICAgKGV4cGFuZC1maWxlLW5hbWUgKGZpbGUtbmFt ZS1ub25kaXJlY3RvcnkgdXJsKQogCQkJCSAgICAgIGRpcmVjdG9yeSkpKSkpCiAKKyhkZWZ1 biBzaHItcmVwbGFjZS1pbWFnZSAoZGF0YSBzdGFydCBlbmQgJm9wdGlvbmFsIGZsYWdzKQor ICAoc2F2ZS1leGN1cnNpb24KKyAgICAoc2F2ZS1yZXN0cmljdGlvbgorICAgICAgKHdpZGVu KQorICAgICAgKGxldCAoKGFsdCAoYnVmZmVyLXN1YnN0cmluZyBzdGFydCBlbmQpKQorCSAg ICAocHJvcGVydGllcyAodGV4dC1wcm9wZXJ0aWVzLWF0IHN0YXJ0KSkKKyAgICAgICAgICAg IDs7IFdlIGRvbid0IHdhbnQgdG8gcmVjb3JkIHRoZXNlIGNoYW5nZXMuCisgICAgICAgICAg ICAoYnVmZmVyLXVuZG8tbGlzdCB0KQorCSAgICAoaW5oaWJpdC1yZWFkLW9ubHkgdCkpCisg ICAgICAgIChyZW1vdmUtb3ZlcmxheXMgc3RhcnQgZW5kKQorCShkZWxldGUtcmVnaW9uIHN0 YXJ0IGVuZCkKKwkoZ290by1jaGFyIHN0YXJ0KQorCShmdW5jYWxsIHNoci1wdXQtaW1hZ2Ut ZnVuY3Rpb24gZGF0YSBhbHQgZmxhZ3MpCisJKHdoaWxlIHByb3BlcnRpZXMKKwkgIChsZXQg KCh0eXBlIChwb3AgcHJvcGVydGllcykpCisJCSh2YWx1ZSAocG9wIHByb3BlcnRpZXMpKSkK KwkgICAgKHVubGVzcyAobWVtcSB0eXBlICcoZGlzcGxheSBpbWFnZS16b29tKSkKKwkgICAg ICAocHV0LXRleHQtcHJvcGVydHkgc3RhcnQgKHBvaW50KSB0eXBlIHZhbHVlKSkpKSkpKSkK KwogKGRlZnVuIHNoci1pbWFnZS1mZXRjaGVkIChzdGF0dXMgYnVmZmVyIHN0YXJ0IGVuZCAm b3B0aW9uYWwgZmxhZ3MpCiAgIChsZXQgKChpbWFnZS1idWZmZXIgKGN1cnJlbnQtYnVmZmVy KSkpCiAgICAgKHdoZW4gKGFuZCAoYnVmZmVyLW5hbWUgYnVmZmVyKQpAQCAtMTExOSwyMyAr MTE0Myw3IEBAIHNoci1pbWFnZS1mZXRjaGVkCiAJCShzZWFyY2gtZm9yd2FyZCAiXHJcblxy XG4iIG5pbCB0KSkKIAkobGV0ICgoZGF0YSAoc2hyLXBhcnNlLWltYWdlLWRhdGEpKSkKIAkg ICh3aXRoLWN1cnJlbnQtYnVmZmVyIGJ1ZmZlcgotCSAgICAoc2F2ZS1leGN1cnNpb24KLQkg ICAgICAoc2F2ZS1yZXN0cmljdGlvbgotCQkod2lkZW4pCi0JCShsZXQgKChhbHQgKGJ1ZmZl ci1zdWJzdHJpbmcgc3RhcnQgZW5kKSkKLQkJICAgICAgKHByb3BlcnRpZXMgKHRleHQtcHJv cGVydGllcy1hdCBzdGFydCkpCi0gICAgICAgICAgICAgICAgICAgICAgOzsgV2UgZG9uJ3Qg d2FudCB0byByZWNvcmQgdGhlc2UgY2hhbmdlcy4KLSAgICAgICAgICAgICAgICAgICAgICAo YnVmZmVyLXVuZG8tbGlzdCB0KQotCQkgICAgICAoaW5oaWJpdC1yZWFkLW9ubHkgdCkpCi0g ICAgICAgICAgICAgICAgICAocmVtb3ZlLW92ZXJsYXlzIHN0YXJ0IGVuZCkKLQkJICAoZGVs ZXRlLXJlZ2lvbiBzdGFydCBlbmQpCi0JCSAgKGdvdG8tY2hhciBzdGFydCkKLQkJICAoZnVu Y2FsbCBzaHItcHV0LWltYWdlLWZ1bmN0aW9uIGRhdGEgYWx0IGZsYWdzKQotCQkgICh3aGls ZSBwcm9wZXJ0aWVzCi0JCSAgICAobGV0ICgodHlwZSAocG9wIHByb3BlcnRpZXMpKQotCQkJ ICAodmFsdWUgKHBvcCBwcm9wZXJ0aWVzKSkpCi0JCSAgICAgICh1bmxlc3MgKG1lbXEgdHlw ZSAnKGRpc3BsYXkgaW1hZ2Utem9vbSkpCi0JCQkocHV0LXRleHQtcHJvcGVydHkgc3RhcnQg KHBvaW50KSB0eXBlIHZhbHVlKSkpKSkpKSkpKSkKKwkgICAgKHNoci1yZXBsYWNlLWltYWdl IGRhdGEgc3RhcnQgZW5kIGZsYWdzKSkpKSkKICAgICAoa2lsbC1idWZmZXIgaW1hZ2UtYnVm ZmVyKSkpCiAKIChkZWZ1biBzaHItaW1hZ2UtZnJvbS1kYXRhIChkYXRhKQotLSAKMi4yNS4x Cgo= --------------nnNzqGvYBJRrCg7j6NO56LV9-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 28 21:42:47 2024 Received: (at 71666) by debbugs.gnu.org; 29 Jun 2024 01:42:47 +0000 Received: from localhost ([127.0.0.1]:36454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNN71-0005ZZ-0A for submit@debbugs.gnu.org; Fri, 28 Jun 2024 21:42:47 -0400 Received: from mail-oi1-f180.google.com ([209.85.167.180]:57427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNN6z-0005ZH-56 for 71666@debbugs.gnu.org; Fri, 28 Jun 2024 21:42:45 -0400 Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-3d55ed47cc6so724621b6e.2 for <71666@debbugs.gnu.org>; Fri, 28 Jun 2024 18:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719625299; x=1720230099; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=iWqDj8ssS9R0Zkgo8d1VsH4OGb1NdG6Lv0uBWrQeNX0=; b=GURuxOWZ3gSkY50XrFcl+IWpOBvK0GUmA55WC0Xm0ldA6NkXO6TIu0330gu9c288Iu 2tSjlQ5MZu3W+ZmkziQ7ZUVmmYUp3upDPD7gTiqrWX878eo2V+KylrgNkfjT/kdAcjsN 3pFTPefR5k+iajzheX9QsCUBk21d4LKcYWDUH4Pttea6FpJXsreE6sIKV4x0BipT+Xni gcPtEviEpbb6wSTj2PsdpsGOr9n5uCXxsVocXaxgyPk6ge+EHopJXh9qF+loR6KbW0// 9R8K9NhtaMItRhs/83AoV7IpYlip2mUnMqFxNojVJwOdMu+5lcyQr1Md8OJnW19ia/oI UDBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719625299; x=1720230099; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:mime-version:date:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=iWqDj8ssS9R0Zkgo8d1VsH4OGb1NdG6Lv0uBWrQeNX0=; b=fdkt4jR7mXqinVLrxZ3Ur9OijfZfmUE/3lxzengTpiT/dHklTKKby8DYYWGEjR3pa5 dxNlv9eHRgJLHhqGnEw/skO5ZymQlh4g9PScfOcjkf7FduP+PNgR5t//iztBYbew3dui EkEtO+qYYCWAGoLUuCUZcYfrAVML8EGo+vUMDeOO/1ToWC7+6WhNo+GmAz2HkjJhy/dK JfCRQ1pLjNQ9NzR8ggpOdDYPqXQZNY2cI9nwBiPGMgaa9ojjuslMvG4oalcfbRuq10bW 7LWxYlPYzh6FOgt43tclMCnfhLiBCcEdPlbc2swDYl6pCct8vbBNllSsw/Z24O7uVi+W tJlg== X-Gm-Message-State: AOJu0Yxlkx/IlSKUC31JRlKI8zEvCuAZ5eYdz45GyxgwX1GP7GkXIBEj zv/BhXzGasjYj0iaPLEmRD/hVWzl5N5HFSnMJOPxBMW0mdQ+N6UH X-Google-Smtp-Source: AGHT+IEgZhbKTj1be4cjGDIwlcCX4Rsa7tdYRe7U53Ox9rjponHptv0kYSBZzDGeOrm+SOHUnBnBXQ== X-Received: by 2002:a05:6808:d48:b0:3d2:14b5:adf8 with SMTP id 5614622812f47-3d5459580f6mr22847794b6e.5.1719625299405; Fri, 28 Jun 2024 18:41:39 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-708044adb98sm2333229b3a.172.2024.06.28.18.41.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jun 2024 18:41:38 -0700 (PDT) Message-ID: Date: Fri, 28 Jun 2024 18:41:38 -0700 MIME-Version: 1.0 Subject: Re: bug#71666: 30.0.50; [PATCH] Fix zooming images with SHR From: Jim Porter To: Eli Zaretskii References: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> <86frt5ibou.fsf@gnu.org> <86o77sfeue.fsf@gnu.org> <14b4d89a-4947-c8e5-9216-adf201875c21@gmail.com> <88f17922-a833-ea6f-6d5e-bd01261b9068@gmail.com> Content-Language: en-US In-Reply-To: <88f17922-a833-ea6f-6d5e-bd01261b9068@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71666 Cc: 71666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 6/23/2024 3:24 PM, Jim Porter wrote: > This ended up fairly complex, so I've split the patch into sub-parts to > (I hope) make the changes easier to follow. There are four distinct, but > related, improvements here: Assuming there are no comments/concerns, I'll merge this to the master branch in the next few days. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 28 23:09:43 2024 Received: (at 71666) by debbugs.gnu.org; 29 Jun 2024 03:09:43 +0000 Received: from localhost ([127.0.0.1]:36545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNOT8-0007n1-O2 for submit@debbugs.gnu.org; Fri, 28 Jun 2024 23:09:42 -0400 Received: from mail-ed1-f50.google.com ([209.85.208.50]:49386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNOT6-0007mr-Ed for 71666@debbugs.gnu.org; Fri, 28 Jun 2024 23:09:41 -0400 Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5854ac817afso1531702a12.2 for <71666@debbugs.gnu.org>; Fri, 28 Jun 2024 20:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719630520; x=1720235320; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=TtlLseUCNeTMp54YNzlq9mMilVtJpqrc61+wwywd9Zs=; b=LzIKSv5J18c6wC9d/kwrvkTo4pnIwjBj7k3jfoYXWTjE0ZWs2QfLVQJdypYT94qQJP z2O6cQp1E6JmCq4XybwslGPtefRia0NAjgAvg2LghtBUQq8hvDlbpTkB41RU+5QeRJqM Gj+k2nVHdLS3/TTtDw/H4sRSNxEqnSowcanNV2A50x8Jk1i4Ee9o3abnI3G1YliW91Nv W4Qsts0GnufKGf+91F1rEa5yi2saDchoTeR2NXBDVZDoTqqCrUw4/DU8yoSdXrRLjIUS CD/ozKthFbm/iNxb5OOxs4PQtCVmqcjGf3QCHb9RAZ/WNcKqUBUItyn8GTsA8J8q2xCT Z8Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719630520; x=1720235320; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TtlLseUCNeTMp54YNzlq9mMilVtJpqrc61+wwywd9Zs=; b=tXVtXxo4XJolRKIkqT0Ukx/tPsklXXDAjE9HqRar5I/PvqzAIzE92meMO/TI8C3l3S NWJZBIG2BbOGKVfA4Ohq24dPlg3yOLtb89VjbCHbxg1wbgZ0ppP2E28S5boZu10r80tm DanRtcCASXWdRf0LDqkHGpPOwrV7pGOcQeI71AFVlhGXcv3sHSLq6U5CeOnmj312to+i AYVC847lQVLbTF7pFuK+QvX2khkSjuss6KvAVdGoUnNHyEkNpYcz/FEP0i9AJXLKxdxj vpI026Nrbp0dXaRpjF7dq5XH3aHUjUV9h0UzPmjT5JrUNqxhqdOdIuH8UVoMJtf6/+1s 8eyQ== X-Gm-Message-State: AOJu0YxZGubHa277ljBVb+3PihvAaNPFd18nwuA1FG6VtE7WbfQ+g89K A4yRrXuYkpcSA0/x/WV/Fr5akpbbQgv19XT/YGB2o8DQG3l2LsDrQn30oZTLmtmpuqD4K2OgvHn N51R+NEqHLx2KqsFDa7puk69+cK0= X-Google-Smtp-Source: AGHT+IF0ozqwHqa1aau9oKqgeCnVr40J/t8DFY8GOeAtQZuDYmdAeDJT0cwu2+c3axC/AdwfUeNOa+UVBL8/2ehrp1A= X-Received: by 2002:a05:6402:2546:b0:587:2fa6:496a with SMTP id 4fb4d7f45d1cf-5872fa64dfbmr603796a12.15.1719630520059; Fri, 28 Jun 2024 20:08:40 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 28 Jun 2024 20:08:39 -0700 From: Stefan Kangas In-Reply-To: References: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> <86frt5ibou.fsf@gnu.org> <86o77sfeue.fsf@gnu.org> <14b4d89a-4947-c8e5-9216-adf201875c21@gmail.com> <88f17922-a833-ea6f-6d5e-bd01261b9068@gmail.com> MIME-Version: 1.0 Date: Fri, 28 Jun 2024 20:08:39 -0700 Message-ID: Subject: Re: bug#71666: 30.0.50; [PATCH] Fix zooming images with SHR To: Jim Porter , Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71666 Cc: 71666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jim Porter writes: > On 6/23/2024 3:24 PM, Jim Porter wrote: >> This ended up fairly complex, so I've split the patch into sub-parts to >> (I hope) make the changes easier to follow. There are four distinct, but >> related, improvements here: > > Assuming there are no comments/concerns, I'll merge this to the master > branch in the next few days. This is a regression, right? So should it not go to emacs-30? From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 28 23:32:39 2024 Received: (at 71666) by debbugs.gnu.org; 29 Jun 2024 03:32:39 +0000 Received: from localhost ([127.0.0.1]:36566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNOpK-0008Oy-O8 for submit@debbugs.gnu.org; Fri, 28 Jun 2024 23:32:39 -0400 Received: from mail-pl1-f182.google.com ([209.85.214.182]:58573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNOpJ-0008Om-AB for 71666@debbugs.gnu.org; Fri, 28 Jun 2024 23:32:37 -0400 Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1f9d9b57b90so9366405ad.0 for <71666@debbugs.gnu.org>; Fri, 28 Jun 2024 20:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719631892; x=1720236692; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=Kh2Nu9yI3uhSrRgp8Y429YreDWshoQGLkwGBcPRQ/V0=; b=ZOiscU8q6uYbI+j7+FnDLtx6nbK3FamhjhuIvGfjHra9ynrXYPXgwj6E5HBWBtjNpL yc2psiUBIOp2Dbcdb8XNBdmP/GtGIUBFCwoLnwjxRHSlAH8ssUZOon/6khqJROiv384R Z4rWnj6Om1u9Um0kTUzi6c0I3ZuBewIUoXgqwSKygnfd7hRs/qcmtHE1MYciN9QjwZlA cce0ovsy93OMPA1XQKRNOMKaCgyvgkIJcuCQlFpxor+3mK9cH01Mzw7aw++7qjTaqzRQ 9tWxDpP5EvLO2lbfk/2DuQ42+iT3s6hE/swvU3I3mAFI/omi73ln0y+nDTpfKQ+faUDW IYWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719631892; x=1720236692; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kh2Nu9yI3uhSrRgp8Y429YreDWshoQGLkwGBcPRQ/V0=; b=QRTqMkWVtm3xO/kwBWAZID0AquE5uF/jm1G88J0T0sPJ5GPC5UPyySGUsA9O0+QLVC NTfu8V1s0fWSlc9yGKXA09bjswwayba0mynTWxh1rX+wdv4a4qtcBflT1+iiaTJICToq o+SnMUOk6GrnYV36Cn3ncuxapvuGjJAf7ObplQyGPnqTtA8gw7WWlrzWMSHuWcEwkN45 oIt9hLDgClsP0hTvo21yW07+w3gfNLI/vB7fPtQrVAKeB5bX/vIgq91pUXFDeUROyKKb 9f43i446Q5A66jZjWvCnmGFFwyovaS9W4hb5C08ZA0MMG1rD79b+bWSPPbQxmAodT4iR N/Xw== X-Gm-Message-State: AOJu0YwCvGsBUdhNfVu3kJzIWHMnHBDWHv4MfiNPotkUwpN2HkjydPso mzhoFSHkfgfdrwakxMtZti9YCwjBI8jTsj5VfugeNj7CABfMuqHA X-Google-Smtp-Source: AGHT+IH/WM9N3gX4gD1UcXnAy83zBHoXF8v2HEEh/rgGpQGJNt0z0wXKBkbxhH4c3pRF7EAodeN1pw== X-Received: by 2002:a17:902:e810:b0:1fa:7f7e:2e0a with SMTP id d9443c01a7336-1fa7f7e3232mr121866725ad.65.1719631891837; Fri, 28 Jun 2024 20:31:31 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1fac11d8be9sm22782925ad.113.2024.06.28.20.31.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jun 2024 20:31:31 -0700 (PDT) Message-ID: Date: Fri, 28 Jun 2024 20:31:31 -0700 MIME-Version: 1.0 Subject: Re: bug#71666: 30.0.50; [PATCH] Fix zooming images with SHR Content-Language: en-US To: Stefan Kangas , Eli Zaretskii References: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> <86frt5ibou.fsf@gnu.org> <86o77sfeue.fsf@gnu.org> <14b4d89a-4947-c8e5-9216-adf201875c21@gmail.com> <88f17922-a833-ea6f-6d5e-bd01261b9068@gmail.com> From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71666 Cc: 71666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 6/28/2024 8:08 PM, Stefan Kangas wrote: > Jim Porter writes: > >> Assuming there are no comments/concerns, I'll merge this to the master >> branch in the next few days. > > This is a regression, right? So should it not go to emacs-30? The initial bug report is fixed on emacs-30, but then based on Eli's message (and some further examination of the code on my part), I found some more closely-related issues. One of these issues (#3 - the "full" zoom level didn't zoom to the full window height) is a regression, but it regressed over a decade ago as far as I can tell, so I'd lean towards keeping the current behavior on emacs-30. That way, if I misunderstood what the regression was, we have plenty of time in the 31 release cycle to address that. (After searching, I now see that this particular regression was filed previously as bug#63344.) The other changes aren't so much regressions as they are long-standing bugs or limitations of the image-zooming code. Of course, if you and Eli prefer that I merge some or all of these patches to the release branch, I don't mind. But they seemed a bit risky to me. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 28 23:40:32 2024 Received: (at 71666) by debbugs.gnu.org; 29 Jun 2024 03:40:32 +0000 Received: from localhost ([127.0.0.1]:36580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNOwy-0000AQ-0r for submit@debbugs.gnu.org; Fri, 28 Jun 2024 23:40:32 -0400 Received: from mail-lj1-f171.google.com ([209.85.208.171]:44319) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNOww-0000AD-JE for 71666@debbugs.gnu.org; Fri, 28 Jun 2024 23:40:31 -0400 Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2ec6635aa43so12132881fa.1 for <71666@debbugs.gnu.org>; Fri, 28 Jun 2024 20:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719632365; x=1720237165; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=BZF1an/Fj8GfS4G46KEnPttHSWYJdxJXOE1jsSCkEcU=; b=cMEXAIrh+Pu70879Boc9/vm/L/AbqgeGrwGRocdrNUvtQcCrFuxsBD/UBBP9ALCGgb lqTCN+EiPihP1cRY2DgzWSgbo65UudkH7fIXIqViPs5Za7pa+2oEsbocFw7rzSndcLPQ B73tKYUkObVtyUEBYSVKNjtj9JUdHmyoqjqVYzNDemRfjYiySt4GW6s0hTBwjR9xK65c l3V3Opuvsj/JCzu9tD3mwFeG/KM2K6vsnfpEN6BrXgxJq2isIehkFKaDx9nc/OxkcJ5S J9sK9cEbNjketBPoGB/YPe9dVGWdj5QpEs+g+PNb39UP5qnshMSZDW4z1uGMo/8347Q6 JBcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719632365; x=1720237165; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BZF1an/Fj8GfS4G46KEnPttHSWYJdxJXOE1jsSCkEcU=; b=QyAJjvbgbNH0vox+ZAc3sW2JIfCPeRiwGV9HoIzITaaO7yszXwTvwXufnOxW/O7lc2 deX7VT4HYuq+h6UcAmSxqOCe/VRI8zR7kECN5UFFTaiioHiH+FWmoAm3Wdvj1RkOX2NZ wlWeYa/3bsH6FLLLb8rIB0OXszz1+4V1HmxwCpeXXGDp2iztfQNB26XNftZ7xLPRSmDD Zv435X/mUv+dCcHyhvJxeqiYkw1J4GPCKCFE+c0j5i5uF/B8Qfltb26rMFwTOo9KNFH5 +KuMQRrCKQSTVlu92amxCU2IWjJVEVmegOwuT8V6Ta6vTMdgInzWpzehwzuqEvDR7P98 BXXg== X-Gm-Message-State: AOJu0Yx/UsxW1nnCJyBvlKi1d+dhQDZWuza6Z9kjT7lDUIXu5TDU1wfU TvdioR7ApvERUYRINvaeBnn0L8a0rEXoOFO/K0GmATMA1EXSo1ywTcOTqJJOjDhvttd/5/xda9C 33N+wMG9LjkMuMbGjDNChOocyJBw= X-Google-Smtp-Source: AGHT+IEXzDpqKsjBMVwMvYbBwIlRXr5qj5XZB862Vf+N0EHfhl2ZaCJyjdCxt4TPrfWJ0OZPmFOrycQSUFBJiHeaiYY= X-Received: by 2002:a05:651c:507:b0:2ed:2765:2491 with SMTP id 38308e7fff4ca-2ee5e3c3652mr1128391fa.28.1719632364595; Fri, 28 Jun 2024 20:39:24 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 28 Jun 2024 20:39:24 -0700 From: Stefan Kangas In-Reply-To: References: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> <86frt5ibou.fsf@gnu.org> <86o77sfeue.fsf@gnu.org> <14b4d89a-4947-c8e5-9216-adf201875c21@gmail.com> <88f17922-a833-ea6f-6d5e-bd01261b9068@gmail.com> MIME-Version: 1.0 Date: Fri, 28 Jun 2024 20:39:24 -0700 Message-ID: Subject: Re: bug#71666: 30.0.50; [PATCH] Fix zooming images with SHR To: Jim Porter , Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71666 Cc: 71666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jim Porter writes: > On 6/28/2024 8:08 PM, Stefan Kangas wrote: > >> This is a regression, right? So should it not go to emacs-30? > > The initial bug report is fixed on emacs-30, but then based on Eli's > message (and some further examination of the code on my part), I found > some more closely-related issues. OK, thanks. I had missed some necessary context here. If they're not regressions from Emacs 29, you're right that they belong on master. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 04 15:19:21 2024 Received: (at 71666-done) by debbugs.gnu.org; 4 Jul 2024 19:19:21 +0000 Received: from localhost ([127.0.0.1]:43006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPRzF-0002rH-2H for submit@debbugs.gnu.org; Thu, 04 Jul 2024 15:19:21 -0400 Received: from mail-pg1-f174.google.com ([209.85.215.174]:58676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPRzC-0002r1-Sl for 71666-done@debbugs.gnu.org; Thu, 04 Jul 2024 15:19:19 -0400 Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-707040e3018so602047a12.1 for <71666-done@debbugs.gnu.org>; Thu, 04 Jul 2024 12:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720120690; x=1720725490; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=IO94j7GjE3CBVgse51Kh/1uTk8fN0FG6JGCJeFUvAAA=; b=Hvy9TmJOeXusL+/2tsHEHl24WEuwNDnWbme+w+eARu5IX2TkZ22dxLK6btONDwrI1x YZQvS9xTZzEYVrxK5GENjjdHcyJH5QERKROA2RpuggpL36ucrdarpsGPSOgKeLG+4N8N 0fFJ+gPDasj1AH5ZK9DGKiyXs6V71Zi18s8tJrVAtKGJRpWDayt5nFz6extdhpNNK8Ei iA4sMqCOG6TYI58m2B0QA2JZ1IF23OGanE7lzCkUhnnPRxp5SZTXM1CqlEFGDVMMmCmP mCg1xUVuiL78pdg8Lpufhh/X8mUAlKqJG5mYzCY47caBJUIWZL+pi7rzQBeH6rmlFQUp UgWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720120690; x=1720725490; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IO94j7GjE3CBVgse51Kh/1uTk8fN0FG6JGCJeFUvAAA=; b=IGwuCKEVqsfpAoDnr6l3cRmYTRuwRyygocRnw1SgKLpiJ3h+nH34a73KZBieucihSn hRHGvXr+ArBTU/C1tz6nJQAs74I+bkxy7bDroXIDYHT6FRq3iwzeYPezzkRK8C9O9dur 4gnkEb7xvGm7Al58hcv306vzni2sooDXXPI+sb0eNY4635I3iaMWpd7pAWmk4vsaSF0a cyFDkwDuRj/6JGI58UgAzjqq1ez6glit3DcICqXxieDOis97dI+0TLB7i8zwk5RU9ue8 bXo+LqEiWAHAE95tJNmCSp+dIZnWlBen2Wvq3su667ICHXcHViuCr4RoLXcqhLN/lKKX mLCA== X-Gm-Message-State: AOJu0YyWQ621KWQukcDeSe2SwidfjC34dKcze/A/cTQLQ2C5U/E2SItt ipsScNyyJ1q+NKXMsk/TZXTE0YTjwrEfsdObxdL1gSWOAlg6xVUp X-Google-Smtp-Source: AGHT+IGZUne9zRxfzcRbt9rsWO7luffLnQOOloLyZZ+K78fe8IU1XL3R89J0QxGHa/9a/LXk0loGgw== X-Received: by 2002:a05:6a20:7344:b0:1be:d703:bc47 with SMTP id adf61e73a8af0-1c0cc8f66eamr3210528637.49.1720120690291; Thu, 04 Jul 2024 12:18:10 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1fb438cabf3sm4450575ad.275.2024.07.04.12.18.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jul 2024 12:18:09 -0700 (PDT) Message-ID: <4aefa1e3-6d43-2a0b-fe67-812e25df52d4@gmail.com> Date: Thu, 4 Jul 2024 12:18:08 -0700 MIME-Version: 1.0 Subject: Re: bug#71666: 30.0.50; [PATCH] Fix zooming images with SHR Content-Language: en-US To: Stefan Kangas , Eli Zaretskii References: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> <86frt5ibou.fsf@gnu.org> <86o77sfeue.fsf@gnu.org> <14b4d89a-4947-c8e5-9216-adf201875c21@gmail.com> <88f17922-a833-ea6f-6d5e-bd01261b9068@gmail.com> From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71666-done Cc: 71666-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 6/28/2024 8:39 PM, Stefan Kangas wrote: > OK, thanks. I had missed some necessary context here. If they're not > regressions from Emacs 29, you're right that they belong on master. Pushed to the master branch as f91387cce8f, and closing this bug now. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 04 15:31:34 2024 Received: (at control) by debbugs.gnu.org; 4 Jul 2024 19:31:34 +0000 Received: from localhost ([127.0.0.1]:43024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPSB3-0003D4-Ru for submit@debbugs.gnu.org; Thu, 04 Jul 2024 15:31:34 -0400 Received: from mail-pf1-f171.google.com ([209.85.210.171]:53409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPSB0-0003Cd-Bc; Thu, 04 Jul 2024 15:31:30 -0400 Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-7065a2f4573so663644b3a.2; Thu, 04 Jul 2024 12:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720121422; x=1720726222; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=1H2z+NTF3UPqxbtXJd0C0E4jF+EFfoh+B2uGHiiGLco=; b=Qm3OBKitduNAy35aJIxo6CI+G+GeSdEg2hCBUF18cuichUJBvJ1nixeshUtvxBYp1j HXStqW4Veg2XRvzBPIDQkupZaW/6C4WHg3oqT2Q1GnUUVawcuizmTxZgDzZ+rQr+SD6W 72+/7/tVgxByXI3hL0TyoAaavSlOVtRxQF1a7D95tCvQaPd1CpUAeDYxsvTFaKk39z3I v0B9PKbSdEtUf66O77ZQK57oHgLRbwTVZqtqwnzuk1jO3u3hEBFWV2RYd2awnTV68//Q iUJT+YMkMhdq6uWXgEcf49wMKib8Gg8myil4Nf3CktdZQ9/bwcmjr0osXOTpF5dRYNjo D2xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720121422; x=1720726222; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1H2z+NTF3UPqxbtXJd0C0E4jF+EFfoh+B2uGHiiGLco=; b=PppPTq3roKwOt0V03PHaBCnP7WAu4+v3q8P3rja7FezH6UkUMR07BV2wYY4dzJjQ5X DXFUV5NPghayZ6Khp1olFoXKs27rqdBrQNaWoi5Cbvrkc3nvMD8lugYOWArQbJ6YsJMG Auc2v10YRpHcEdo/7Cng6Dg663GZGR8x575qVtiQqEpkq7doSA0tsMaQT4uUSxoyyQhD sG3t4Kyl3R2CyV2Pkzs+ehkO2nR3wbTF2BXPYGjwjvF3AljT1e6BSVSesLc7DLbZ9L/4 S38cerFLEHOZMXToBzzqZ5wKgHez1FgnODMFdpn8pNZEXMJ7NyhUO8CpCOnNWmJQZT20 GgbQ== X-Forwarded-Encrypted: i=1; AJvYcCVx6CiyZ+U/X7kM/vijvdila7OfNfyPK3dfzYKWve+ZT+XX3Ps7pLGO0pYrwPk2N/ptJKG5jsOJRe6AvISqCxZlRNbFlRtaVQ== X-Gm-Message-State: AOJu0YzgOgT1d85rniKCoFZXlgiPfVE7tV7TMaYv3S/qN0hZriqNLfY8 gL2IWMJq26/I1FWU51HATSdBcu6EwywQZSw2yHlP3300choN2TDa X-Google-Smtp-Source: AGHT+IELNKvQR1i6ZE2FsmeTYjcOqGmelWFAe6O2xmCr1dCTu3NleJSMpablDmGCv5iZw9hGEmk6zQ== X-Received: by 2002:a05:6a21:99a6:b0:1bd:2520:1fa5 with SMTP id adf61e73a8af0-1c0cc727effmr2839795637.4.1720121421766; Thu, 04 Jul 2024 12:30:21 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-2c99a93e499sm1927458a91.2.2024.07.04.12.30.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jul 2024 12:30:21 -0700 (PDT) Message-ID: Date: Thu, 4 Jul 2024 12:30:20 -0700 MIME-Version: 1.0 Subject: Re: bug#63344: 29.0.90; (shr-zoom-image) doesn't zoom to buffer size Content-Language: en-US To: Eli Zaretskii , Pankaj Jangid , Lars Ingebrigtsen References: <87jzxk39zi.fsf@codeisgreat.org> <83sfc8eblo.fsf@gnu.org> <87fs882typ.fsf@codeisgreat.org> <83ednse117.fsf@gnu.org> <87r0rre7ix.fsf@codeisgreat.org> <83mt2fcb04.fsf@gnu.org> From: Jim Porter In-Reply-To: <83mt2fcb04.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 63344@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 71666 63344 thanks On 5/8/2023 4:34 AM, Eli Zaretskii wrote: > "Full buffer size" wrt an image is confusing in any case (an Emacs > buffer has no "dimensions"), but my reading of the code is that it is > interpreted as the window dimensions, unless the original size is > smaller than that. Not sure if I'm right, though. In bug#71666, I did some archaeology on the Gnus commit history to figure out what this was, and found that the "full buffer size" meant "rescale the image to the height of the window". Over in that bug, I've fixed the issue described here as well as improving the wording in the docstrings to be more precise. From unknown Thu Jun 19 14:33:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 02 Aug 2024 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator