GNU bug report logs - #7166
browse-url-xdg-open does not escape shell meta-characters

Previous Next

Package: emacs;

Reported by: Ken Hori <fplemma <at> gmail.com>

Date: Wed, 6 Oct 2010 13:27:02 UTC

Severity: normal

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #25 received at 7166 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Ken Hori <fplemma <at> gmail.com>, Jan Djärv <jan.h.d <at> swipnet.se>, 7166 <at> debbugs.gnu.org
Subject: Re: bug#7166: browse-url truncates the given url after an '&'
Date: Fri, 08 Oct 2010 19:24:55 +0200

Glenn Morris <rgm <at> gnu.org> writes:

> I guess this might fix it:
>
> *** lisp/net/browse-url.el	2010-09-23 06:42:45 +0000
> --- lisp/net/browse-url.el	2010-10-07 18:28:31 +0000
> ***************
> *** 939,945 ****
>     (interactive (browse-url-interactive-arg "URL: "))
>     (call-process "/bin/sh" nil nil nil
>   		"-c"
> ! 		(concat "nohup xdg-open " url
>   			">/dev/null 2>&1 </dev/null")))
>   
>   ;;;###autoload
> --- 939,945 ----
>     (interactive (browse-url-interactive-arg "URL: "))
>     (call-process "/bin/sh" nil nil nil
>   		"-c"
> ! 		(concat "nohup xdg-open " (shell-quote-argument url)
>   			">/dev/null 2>&1 </dev/null")))
>   
>   ;;;###autoload

The use of /bin/sh is completely unnecessary.  The nil for infile and
buffer are already equivalent to the explicit redirections.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
This bug report was last modified 14 years and 286 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.