GNU bug report logs - #7166
browse-url-xdg-open does not escape shell meta-characters

Previous Next

Package: emacs;

Reported by: Ken Hori <fplemma <at> gmail.com>

Date: Wed, 6 Oct 2010 13:27:02 UTC

Severity: normal

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Ken Hori <fplemma <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Jan Djärv <jan.h.d <at> swipnet.se>, 7166 <at> debbugs.gnu.org
Subject: bug#7166: browse-url truncates the given url after an '&'
Date: Thu, 7 Oct 2010 21:21:11 -0700

The diff did it. Thanks for the fix.

On Thu, Oct 7, 2010 at 11:35 AM, Glenn Morris <rgm <at> gnu.org> wrote:
>
> I guess this might fix it:
>
> *** lisp/net/browse-url.el      2010-09-23 06:42:45 +0000
> --- lisp/net/browse-url.el      2010-10-07 18:28:31 +0000
> ***************
> *** 939,945 ****
>    (interactive (browse-url-interactive-arg "URL: "))
>    (call-process "/bin/sh" nil nil nil
>                "-c"
> !               (concat "nohup xdg-open " url
>                        ">/dev/null 2>&1 </dev/null")))
>
>  ;;;###autoload
> --- 939,945 ----
>    (interactive (browse-url-interactive-arg "URL: "))
>    (call-process "/bin/sh" nil nil nil
>                "-c"
> !               (concat "nohup xdg-open " (shell-quote-argument url)
>                        ">/dev/null 2>&1 </dev/null")))
>
>  ;;;###autoload
>
>
This bug report was last modified 14 years and 286 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.