GNU bug report logs - #71654
[PATCH] Fix display-buffer-override-next-command

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andrea Corallo <acorallo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#71654: closed ([PATCH] Fix display-buffer-override-next-command)
Date: Wed, 19 Jun 2024 21:33:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 19 Jun 2024 17:32:01 -0400
with message-id <yp1wmmkfwku.fsf <at> fencepost.gnu.org>
and subject line Re: bug#71654: [PATCH] Fix display-buffer-override-next-command
has caused the debbugs.gnu.org bug report #71654,
regarding [PATCH] Fix display-buffer-override-next-command
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
71654: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71654
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "kassick <at> gmail.com" <kassick <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix display-buffer-override-next-command
Date: Wed, 19 Jun 2024 12:20:19 -0300

[Message part 3 (text/plain, inline)]

When display-buffer-overriding-action's car is set to a function instead of
a list, display-buffer-override-next-command must ensure that the car is a
list before pushing a new element to it, otherwise the car will become a
itself a cons-cell and the clear-fun will trigger a wrong-type-argumen
error when trying to delq the action.

The error can be triggered by using some minor mode that
updates display-buffer-override-next-command (such as purpose-mode) and
then calling other-window-prefix.

The patch was created using the `emacs-29` branch.

----

In GNU Emacs 29.3.50 (build 8, x86_64-pc-linux-gnu, GTK+ Version
 3.24.41, cairo version 1.18.0) of 2024-05-27 built on thnkpd
System Description: Fedora Linux 39 (Workstation Edition)

Configured using:
 'configure --build x86_64-linux-gnu --prefix=/usr/local
 --sharedstatedir=/var/lib --localstatedir=/var/lib --enable-libsystemd
 --with-pop=yes --build x86_64-linux-gnu
 --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/29/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29/site-lisp:/usr/share/emacs/site-lisp
 --with-sound=alsa --without-gconf --with-mailutils --with-cairo
 --with-x=yes --with-x-toolkit=gtk3 --with-pgtk
 --with-toolkit-scroll-bars --without-xwidgets --with-imagemagick
 --with-native-compilation --with-tree-sitter --with-xinput2'

-- 
Rodrigo Virote Kassick
------------------------------------------------------------

[Message part 4 (text/html, inline)]

[0001-Fix-display-buffer-override-next-command.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Andrea Corallo <acorallo <at> gnu.org>
To: kassick <at> gmail.com
Cc: 71654-done <at> debbugs.gnu.org
Subject: Re: bug#71654: [PATCH] Fix display-buffer-override-next-command
Date: Wed, 19 Jun 2024 17:32:01 -0400

"kassick <at> gmail.com" <kassick <at> gmail.com> writes:

> When display-buffer-overriding-action's car is set to a function instead of a list, display-buffer-override-next-command
> must ensure that the car is a list before pushing a new element to it, otherwise the car will become a itself a cons-cell
> and the clear-fun will trigger a wrong-type-argumen error when trying to delq the action.
>
> The error can be triggered by using some minor mode that updates display-buffer-override-next-command (such as
> purpose-mode) and then calling other-window-prefix.

Hi Rodrigo,

the patch LGTM so I applied it after some indentation massage to master.

Closing then, happy to reopen if some more work is needed.

Thanks

  Andrea

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.