GNU bug report logs - #71653
[PATCH] import/github: Honor upstream-name property.

Previous Next

Package: guix-patches;

Reported by: Dariqq <dariqq <at> posteo.net>

Date: Wed, 19 Jun 2024 16:28:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 71653 <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Dariqq <dariqq <at> posteo.net>
Cc: 71653 <at> debbugs.gnu.org
Subject: Re: [bug#71653] [PATCH] import/github: Honor upstream-name property.
Date: Sun, 23 Jun 2024 14:21:49 +0800
[Message part 1 (text/plain, inline)]
Dariqq <dariqq <at> posteo.net> writes:

> * guix/import/github.scm (import-release): Use 'upstream-name if available.
>
> Change-Id: I9a4999a01156ce02584270837ceab70996b49106
> ---
>  guix/import/github.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/guix/import/github.scm b/guix/import/github.scm
> index c5556d78ee..164fcde458 100644
> --- a/guix/import/github.scm
> +++ b/guix/import/github.scm
> @@ -328,8 +328,9 @@ (define* (import-release pkg #:key (version #f))
>    (let* ((original-uri (origin-uri (package-source pkg)))
>           (source-uri (github-uri original-uri))
>           (name (package-name pkg))
                  ^------------ I think maybe just use "package-upstream-name" on this?

> +         (upstream-name (assoc-ref (package-properties pkg) 'upstream-name))
>           (newest-version version-tag
> -                         (latest-released-version source-uri name
> +                         (latest-released-version source-uri (or upstream-name name)
>                                                    #:version version)))
>      (if newest-version
>          (upstream-source
>
> base-commit: c551e406a75273583ae3fef92f32468f905cc07f
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 319 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.