GNU bug report logs - #71648
30.0.50; Allow which-key to report on translation bindings

Previous Next

Package: emacs;

Reported by: Robert Pluim <rpluim <at> gmail.com>

Date: Wed, 19 Jun 2024 12:05:02 UTC

Severity: normal

Tags: fixed

Found in version 30.0.50

Fixed in version 30.1

Done: Robert Pluim <rpluim <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #6 received at 71648 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Pluim <rpluim <at> gmail.com>, justin <at> burkett.cc,
 Jeremy Bryant <jb <at> jeremybryant.net>
Cc: 71648 <at> debbugs.gnu.org
Subject: Re: bug#71648: 30.0.50;
 Allow which-key to report on translation bindings
Date: Wed, 19 Jun 2024 16:12:05 +0300
> From: Robert Pluim <rpluim <at> gmail.com>
> Date: Wed, 19 Jun 2024 14:04:35 +0200
> 
> `which-key-mode' currently only looks at keymaps, not translation
> keymaps such as `key-translation-map' and `function-key-map'. In order
> to aid discoverability, perhaps it should do the following
> 
> (maybe with a user option)
> 
> @@ -1942,8 +1949,10 @@ which-key--get-keymap-bindings
>  
>  (defun which-key--get-current-bindings (&optional prefix filter)
>    "Generate a list of current active bindings."
> -  (let (bindings)
> -    (dolist (map (current-active-maps t) bindings)
> +  (let (bindings
> +        (maps (nconc (current-active-maps t)
> +                     (list key-translation-map function-key-map))))
> +    (dolist (map maps bindings)
>        (when (cdr map)
>          (setq bindings
>                (which-key--get-keymap-bindings
> 

Let's have the relevant people on-board of this discussion.




This bug report was last modified 327 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.