From unknown Sun Jun 15 08:38:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2024 12:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 71648@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171879868622852 (code B ref -1); Wed, 19 Jun 2024 12:05:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Jun 2024 12:04:46 +0000 Received: from localhost ([127.0.0.1]:41549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJu3R-0005wW-OH for submit@debbugs.gnu.org; Wed, 19 Jun 2024 08:04:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:52348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJu3P-0005wM-FN for submit@debbugs.gnu.org; Wed, 19 Jun 2024 08:04:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJu3L-0004ru-Vt for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 08:04:40 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJu3K-0000FY-EO for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 08:04:39 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4218180a122so46747385e9.1 for ; Wed, 19 Jun 2024 05:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718798676; x=1719403476; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=36wRNGe3v+WmDuX/y1/5isRU9en1UPO39pY9dxpyK8g=; b=HfFlKCCjZG8bZjfSwnTB6kZhXoWxmzOnVdiqDk9u10rCNHrQwQiQ+11JEz7K0JtelQ SYzzqnwEVLSVCqxTBjO8hG66LIgAJj9lgy/rJL76jIT1QF6asQXNoOh5/YyfeACORNWl b50z3VsYzp2eo2iNnZ5RJDSnV2+Ai4l7kVtTR2wtFAOAtqzx50MXZr8atCAYrrfGvgbI iVHntvNggufBbsBlCs87muRI2tyk5TxFirhb6EhOmzO062l+eNMyTFsQGwaXjq2a/HzI sNPvp8NygOad77ABO6KOtiHIqD/eZmQGqw4O9901UpRGh9P9kfDSOoI4Sf9YPFv6/dvV HeEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718798676; x=1719403476; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=36wRNGe3v+WmDuX/y1/5isRU9en1UPO39pY9dxpyK8g=; b=oVnHgFCUIo/Bmh2DXwNGZVOKUl5gQJDu0hwDbvCo+O9p6ZPThPTEtKpTHxDGmF/+pn e6T2c2mEbf3O8RG9L+DC4br/kUoPbOer9Dc6LfMA8qbZoqRBmtHJO1guVKtmAq26NIsO hbnauPxbZuCx4wFSZ21g9hYH1wJZanl/9y3GI2lwt/2Jw+qkBkaN/3hDJ/WoFrcFuKYA rfNoP1CgLeUPUJGKvVkaEXauzxsT2iyVA6/uukiS2dNyLMqadP5JqjVMp0LlA11Nl12e y3B7+ABAODBjk1We7vLHVHzUcULmpdd+JkkfUuH19cxqJFbYAZLFWcZTnLzCfrZ81i8d mFEg== X-Gm-Message-State: AOJu0Yw/ZflQf9UV5HuhwQMrsQfgnnHPMhV9/iaB7VVYzEa8ujLxVKZ5 hbkq4L8MyECYANg/Pn58hrWWggNLbZEC33X4Yr3lub+M+mwKEhgdUHbcVA== X-Google-Smtp-Source: AGHT+IFK0b3JIHWLJ1XwDjwIDASFhKZBjwWCUQGu52byB6JJ40xdsDJbFDHKSJnJ5ExIud9V5o8Nog== X-Received: by 2002:a7b:c349:0:b0:422:218e:b8d7 with SMTP id 5b1f17b1804b1-424752a0838mr14557435e9.38.1718798676481; Wed, 19 Jun 2024 05:04:36 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36075114dcfsm16996307f8f.114.2024.06.19.05.04.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jun 2024 05:04:36 -0700 (PDT) From: Robert Pluim Date: Wed, 19 Jun 2024 14:04:35 +0200 Message-ID: <87plsdxhnw.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) `which-key-mode' currently only looks at keymaps, not translation keymaps such as `key-translation-map' and `function-key-map'. In order to aid discoverability, perhaps it should do the following (maybe with a user option) @@ -1942,8 +1949,10 @@ which-key--get-keymap-bindings (defun which-key--get-current-bindings (&optional prefix filter) "Generate a list of current active bindings." - (let (bindings) - (dolist (map (current-active-maps t) bindings) + (let (bindings + (maps (nconc (current-active-maps t) + (list key-translation-map function-key-map)))) + (dolist (map maps bindings) (when (cdr map) (setq bindings (which-key--get-keymap-bindings Robert -- From unknown Sun Jun 15 08:38:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2024 13:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim , justin@burkett.cc, Jeremy Bryant Cc: 71648@debbugs.gnu.org Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.171880274130879 (code B ref 71648); Wed, 19 Jun 2024 13:13:01 +0000 Received: (at 71648) by debbugs.gnu.org; 19 Jun 2024 13:12:21 +0000 Received: from localhost ([127.0.0.1]:43286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJv6q-00081z-QK for submit@debbugs.gnu.org; Wed, 19 Jun 2024 09:12:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJv6o-00081h-AV for 71648@debbugs.gnu.org; Wed, 19 Jun 2024 09:12:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJv6f-0004Mo-8r; Wed, 19 Jun 2024 09:12:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5vAWCOaNs7X3ALO7b1Gc1KJ8H4rWZI7SCiDyaOAsPWQ=; b=UsyPt+55UOq/ CLFcJdsu5k/jbSiDYrJJmox2JamkRgxpRRcAh8fpRHkyPPBn4eBxoz9r1W53HeYwaHFtCmQ1srmTb YCn2Fz+3TH5aOaIS+pmosB0YDl3HAfkMG7miouBBf4Lw/QcxkxyR7DkYhDOpBYboyj95PlV3fffN3 glG+Nv2yPmdE3Uc1wz2LaLRuG3k8+84JYR1rGkTOex1mmjL5ONebv3XyKhvdzZ5da7XCg6Lmc9UDJ 6C8/9RaPQXmYHBKx4jWlg7ndpWy4QosCVLGtstTi7mq0gLqSCF/ha8aDUI19xt2ytERrTQvWMPAIt Uw59hmBzu5OtmPTwv8ubVQ==; Date: Wed, 19 Jun 2024 16:12:05 +0300 Message-Id: <867celoz4q.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87plsdxhnw.fsf@gmail.com> (message from Robert Pluim on Wed, 19 Jun 2024 14:04:35 +0200) References: <87plsdxhnw.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Date: Wed, 19 Jun 2024 14:04:35 +0200 > > `which-key-mode' currently only looks at keymaps, not translation > keymaps such as `key-translation-map' and `function-key-map'. In order > to aid discoverability, perhaps it should do the following > > (maybe with a user option) > > @@ -1942,8 +1949,10 @@ which-key--get-keymap-bindings > > (defun which-key--get-current-bindings (&optional prefix filter) > "Generate a list of current active bindings." > - (let (bindings) > - (dolist (map (current-active-maps t) bindings) > + (let (bindings > + (maps (nconc (current-active-maps t) > + (list key-translation-map function-key-map)))) > + (dolist (map maps bindings) > (when (cdr map) > (setq bindings > (which-key--get-keymap-bindings > Let's have the relevant people on-board of this discussion. From unknown Sun Jun 15 08:38:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Resent-From: Justin Burkett Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2024 15:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 71648@debbugs.gnu.org, Robert Pluim , Jeremy Bryant Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.171880985916090 (code B ref 71648); Wed, 19 Jun 2024 15:11:02 +0000 Received: (at 71648) by debbugs.gnu.org; 19 Jun 2024 15:10:59 +0000 Received: from localhost ([127.0.0.1]:47839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJwxf-0004BQ-AB for submit@debbugs.gnu.org; Wed, 19 Jun 2024 11:10:59 -0400 Received: from mail-ed1-f48.google.com ([209.85.208.48]:45167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJwxd-0004BA-2S for 71648@debbugs.gnu.org; Wed, 19 Jun 2024 11:10:58 -0400 Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-57d1679ee83so542548a12.2 for <71648@debbugs.gnu.org>; Wed, 19 Jun 2024 08:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burkett-cc.20230601.gappssmtp.com; s=20230601; t=1718809788; x=1719414588; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wZ0JgyXRHOcDXxNj5W9lTT/1vYnbR0zPQsQxp1xdJ3Q=; b=wipohiP1yITPgews9HP6va/UE40MY+dE6EIUdshAHUaKLQzcoC2HN3kHry+IJdcoRV J2UPfRUfAhNW+UneNh8M38kHr1V6c0NvQDGA2G8XHspNkQFIBSlt+OoBeik1wkg+hOxs qPztDizQBzV9WiZ0hl3IBJT0p+c+jou7cV769OTF35WKta/R9qLainFir1h1amFgOnK8 tEWZp8dNsrq2dKFPao8JohXelMce0fVbg7xn9UcumhrD7NNaq5NST3HWTOj+hxKz/WhY 7SLnKOr+W/ccHocNL4FfSfHiq8vcs7QQUELWdycYRdZFY0LXLPeR5PbLtHVwfUwZhE9Z T60w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718809788; x=1719414588; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wZ0JgyXRHOcDXxNj5W9lTT/1vYnbR0zPQsQxp1xdJ3Q=; b=ExtOBLFWMuw+bqkJd9QMgJQJir4Q2Q/5HPSROTlnujcjEgfWeWMqBdqd8FfZ+4bm9+ hf703L2ODcoAbVpjR0ldO4irzowv+UV35V4k5WuxjfKV1MFvOAWMGiwn2RE7/QFzxBCy TUacn+PvYQdeQWkjRy1TWoGVaDejQDjD+0Hw1vycrrer+/3S4tgES+ftGSkUFr4WGMCR LIFi+/hWqDTL7n/GVpL8pVyJ/kw8Ht9IDPZhQHgmYEBJt/HqzbRA5ip7U3MNiCmvtr/6 toruyo3uuuHGJUNpjQ++u95fD6bYuha+2hRoPe5POfYw//W+NRhSvEbhcGnEFDfHR6D6 cvlw== X-Forwarded-Encrypted: i=1; AJvYcCWLL1jDO8S7Agqr/I+8eJMzGPKKNALg2wEKFCNP6Oz3imiNqfJuBr8PqQRrhVnT2+dqGINR3P6N4BPc1GnQQrzhmbekQX4= X-Gm-Message-State: AOJu0YwdX0K2o6QzlDASqysvBWwKKdMYJMmKSOYvLd6+GAHuW5kbWwPn mdxPO6sGDe+xf7HYFAs+wcCvY46y5nI80HbcvFVIlbnh75UfFOjvp3K2PdJy6j2jPz65Gy80x1a fsmRccijYKi3IrkjqaKdGk9ymu5UPameVWFc3mQ== X-Google-Smtp-Source: AGHT+IH/fzxqVUe6wtIeS1epT53e6tAdjx1CT7TRTdys3U8E7K22r0iSLvW6LfaOCqgv32BLAmND8I2jDnX3+eBq8o8= X-Received: by 2002:a50:c089:0:b0:57c:6868:2aea with SMTP id 4fb4d7f45d1cf-57d07e86b3dmr1615030a12.23.1718809787833; Wed, 19 Jun 2024 08:09:47 -0700 (PDT) MIME-Version: 1.0 References: <87plsdxhnw.fsf@gmail.com> <867celoz4q.fsf@gnu.org> In-Reply-To: <867celoz4q.fsf@gnu.org> From: Justin Burkett Date: Wed, 19 Jun 2024 11:09:36 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) The purpose of which-key was to show the commands that are available following an incomplete key sequence. If I understand correctly, these maps don't hold commands and anyway would be processed before which-key "sees" the current incomplete key sequence. If I understand correctly, if "C-d x" translates to "C-c x" then which-key I believe would see the sequence "C-c x" and find the bindings following that sequence. I'm not sure how or why we would want to display the information that "C-d x" translates to "C-c x". Justin On Wed, Jun 19, 2024 at 9:12=E2=80=AFAM Eli Zaretskii wrote: > > > From: Robert Pluim > > Date: Wed, 19 Jun 2024 14:04:35 +0200 > > > > `which-key-mode' currently only looks at keymaps, not translation > > keymaps such as `key-translation-map' and `function-key-map'. In order > > to aid discoverability, perhaps it should do the following > > > > (maybe with a user option) > > > > @@ -1942,8 +1949,10 @@ which-key--get-keymap-bindings > > > > (defun which-key--get-current-bindings (&optional prefix filter) > > "Generate a list of current active bindings." > > - (let (bindings) > > - (dolist (map (current-active-maps t) bindings) > > + (let (bindings > > + (maps (nconc (current-active-maps t) > > + (list key-translation-map function-key-map)))) > > + (dolist (map maps bindings) > > (when (cdr map) > > (setq bindings > > (which-key--get-keymap-bindings > > > > Let's have the relevant people on-board of this discussion. From unknown Sun Jun 15 08:38:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2024 15:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Justin Burkett Cc: 71648@debbugs.gnu.org, Eli Zaretskii , Jeremy Bryant Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.171881023416987 (code B ref 71648); Wed, 19 Jun 2024 15:18:02 +0000 Received: (at 71648) by debbugs.gnu.org; 19 Jun 2024 15:17:14 +0000 Received: from localhost ([127.0.0.1]:48042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJx3i-0004Pv-BM for submit@debbugs.gnu.org; Wed, 19 Jun 2024 11:17:14 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:44419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJx3g-0004Pb-1E for 71648@debbugs.gnu.org; Wed, 19 Jun 2024 11:17:12 -0400 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4217a96de38so48711675e9.1 for <71648@debbugs.gnu.org>; Wed, 19 Jun 2024 08:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718810163; x=1719414963; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=BbkiOhRa9p5hVgg2X36I1Hytw5UJMBJKKeJBtP1Re7o=; b=FuBDig8+pr42PgTRUDx1OaxEMa3TgeayUQMZKkxj06tUwtg76kF0LaRYjMvLAKwf18 +U/kDTd/xPcB2fgrill4HwMLfU44RTCcQqnl4BEZCnW/gLo5gnWsirclKTORvdVQXpOj QCp7EuaiHM/z1qi6MDCWVexExs7xoHGtlm7FF4mOa96fRg9lF0xcqW9XE6hnLEqFXk5O pn5sJYpqtELEzx2vFcxBOedf2avqIzoxrsvz2oZDeLQhfHEhsXpvqMPbO9inU7ItKj53 yk3HdHwxucsIyXxuVr2ke8kJlQCcLaJoKIMuY52r/AvNfyzQjsFcLqrOrj8c+TX3H5ej w9Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718810163; x=1719414963; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BbkiOhRa9p5hVgg2X36I1Hytw5UJMBJKKeJBtP1Re7o=; b=pSBvvcD3UIAs5rB7Tgj7BoHHC4OFSvmp8t7p25mLsbSHRlQIOQw1nUOVmsYGm1gmJh nC8TCPZorx7+cuDyPI+fxrlKvJRTcZYOvBFA9o5SzifvQwxJBZ366PzU5kiDUW27Ohnq xsxOqkwbip+BYUGagUFaTPsE1SqR2RJRqdatNcZu3nyDTPTQYQ2zj2CsLyfNDuXaR7XM enidK/JkV06B72O/89kE+CTdBQuB3sAAbTFkdHduzHSkhgGWXJ7G8tIn3k3FbtBDV9D4 xTBqjwYNwXLModLlUgNBuY7g3/E9hwnULho121oQdpHa9g4Zxc94gzfZg40l8tcuOkmT oeJQ== X-Forwarded-Encrypted: i=1; AJvYcCXCvwiQmJg42ZX6O1NVGbuxp7eXgPxriSuHAMleGN3lPrZTv8emxqKi5t2ffaLj3B3quousOwJhScBQ1Ow09RpyRA4sPTI= X-Gm-Message-State: AOJu0Ywy59++yAL3QE7mOA8A60bn8APoJbUi7kJ1iZFLE5JbJq7C/fSz n6yYGX1KOn5njCT1LipP8ukxP9x6Tt9dW2QY5dOZYhNzUgHD3TFKXyH3fQ== X-Google-Smtp-Source: AGHT+IEYNsn8jnErBA4aVRxFKZmn8raDYjpejk1PF+2JS0BK1+xFTONG65inrYntaLigSu4gRhxlJQ== X-Received: by 2002:a05:600c:790:b0:421:819c:5d84 with SMTP id 5b1f17b1804b1-42475175f98mr21378655e9.10.1718810162433; Wed, 19 Jun 2024 08:16:02 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42301a7c850sm227027445e9.6.2024.06.19.08.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jun 2024 08:16:01 -0700 (PDT) From: Robert Pluim In-Reply-To: (Justin Burkett's message of "Wed, 19 Jun 2024 11:09:36 -0400") References: <87plsdxhnw.fsf@gmail.com> <867celoz4q.fsf@gnu.org> Date: Wed, 19 Jun 2024 17:16:01 +0200 Message-ID: <874j9px8su.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 19 Jun 2024 11:09:36 -0400, Justin Burkett said: Justin> The purpose of which-key was to show the commands that are avai= lable Justin> following an incomplete key sequence. If I understand correctly= , these Justin> maps don't hold commands and anyway would be processed before Justin> which-key "sees" the current incomplete key sequence. They don=CA=BCt hold commands in the sense of defuns, but instead they produce characters, which to Emacs is pretty much the same thing, and looking up keys in them inside which-keys produces the same type of display. Justin> If I understand correctly, if "C-d x" translates to "C-c x" then Justin> which-key I believe would see the sequence "C-c x" and find the Justin> bindings following that sequence. I'm not sure how or why we wo= uld Justin> want to display the information that "C-d x" translates to "C-c= x". These maps don=CA=BCt translate sequences to sequences, they translate sequences to characters: 'C-x 8 * E' -> =E2=82=AC 'C-x 8 * L' -> =C2=A3 etc so with my patch, typing 'C-x 8 *' show the entries for 'E' and 'L' (and more besides) Robert --=20 From unknown Sun Jun 15 08:38:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2024 15:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Justin Burkett Cc: 71648@debbugs.gnu.org, rpluim@gmail.com, jb@jeremybryant.net Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.171881141219715 (code B ref 71648); Wed, 19 Jun 2024 15:37:02 +0000 Received: (at 71648) by debbugs.gnu.org; 19 Jun 2024 15:36:52 +0000 Received: from localhost ([127.0.0.1]:48666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJxMi-00057v-FY for submit@debbugs.gnu.org; Wed, 19 Jun 2024 11:36:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJxMg-00057a-5Z for 71648@debbugs.gnu.org; Wed, 19 Jun 2024 11:36:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJxKR-00070e-D9; Wed, 19 Jun 2024 11:34:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gVzvmogtXa36tY5ikFf3XDzy7YbxOicIIcmxhdsXPuA=; b=Jv/Geuc/1jxf iRxampWtVNQwNahupSUB+VjjThI9GMG84NMtTG85RqY6QA69X9G7cBYg/tpPVN15HR1uxT2f7gVMS liBXCIExtb2yJrwSgqoO2T/w6nlmwueYusj9kpUnUS+ayCnkKFAokWK5L7vId+StKwIEUqqNXNETo /czmO+I+gT0VHM4hbgq7GJ38eSfxHd6mai927n9S3cZtwpYu1DAiS8LWgiPrAtMCuiozOJ7Ee5tPJ YBUC2GWJAUtkbk2c1VHp3+XPRpdLVH0t9hPRnqDvfhceVLuTQXbo/XGmf0obfSSropQRJeR5ze0yB tnNTVC1InBWRLF4kDgK3pQ==; Date: Wed, 19 Jun 2024 18:34:27 +0300 Message-Id: <864j9posjg.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Justin Burkett on Wed, 19 Jun 2024 11:09:36 -0400) References: <87plsdxhnw.fsf@gmail.com> <867celoz4q.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Justin Burkett > Date: Wed, 19 Jun 2024 11:09:36 -0400 > Cc: Robert Pluim , Jeremy Bryant , 71648@debbugs.gnu.org > > The purpose of which-key was to show the commands that are available > following an incomplete key sequence. If I understand correctly, these > maps don't hold commands and anyway would be processed before > which-key "sees" the current incomplete key sequence. Everything in Emacs is a command. The specific sequences Robert was talking about eventually insert characters, but they are still a sequence of key events. So I'm not sure I understand how you distinguish between them and what fundamental differences do you see. Would you like to elaborate on how and why do you perceive these to be different? > If I understand correctly, if "C-d x" translates to "C-c x" then > which-key I believe would see the sequence "C-c x" and find the > bindings following that sequence. I'm not sure how or why we would > want to display the information that "C-d x" translates to "C-c x". I don't think this case is the most important or the most interesting. From unknown Sun Jun 15 08:38:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Resent-From: Justin Burkett Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2024 15:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 71648@debbugs.gnu.org, Eli Zaretskii , Jeremy Bryant Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.171881184520728 (code B ref 71648); Wed, 19 Jun 2024 15:45:01 +0000 Received: (at 71648) by debbugs.gnu.org; 19 Jun 2024 15:44:05 +0000 Received: from localhost ([127.0.0.1]:48956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJxTh-0005OF-Df for submit@debbugs.gnu.org; Wed, 19 Jun 2024 11:44:05 -0400 Received: from mail-lj1-f174.google.com ([209.85.208.174]:45216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJxTe-0005NW-6U for 71648@debbugs.gnu.org; Wed, 19 Jun 2024 11:44:04 -0400 Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2ec002caeb3so87451901fa.2 for <71648@debbugs.gnu.org>; Wed, 19 Jun 2024 08:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burkett-cc.20230601.gappssmtp.com; s=20230601; t=1718811772; x=1719416572; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TuMqoy6NAwTPWQhlVUwMxYrHF9E4vLYbuRvvqbPmnPI=; b=3bx8RcacnDeym8VwG0qyju7EH/f6ksbiV7mnADKulioGTUq0YCnnZKXqJkX+N/3Yam 5fGRTThmyZW2gkaU8pbpdDVTpLDVzFJgfxcpfZ9VrOLpG8ez8JUaLZjKcNd29J0k9IPO Z1c9CTgwJyBJhTJuIwFodkOTlH3rRQrj47HrCGE1OFUeFJtsTWGv7riRffIgOa1fL4YH JbC2nX2FJwPbQdp2VEZTPzdhHbsSVrE92+Yb2rQ4MfoKyRLMQhu970qUyeS8eNKdUknd 75w0lyykMRB37gum8OwB5YVjVn1uUFzofwjc8IUuyAAMV8U5CaZ6WPdqAFgmHCzUjPNB 1NaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718811772; x=1719416572; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TuMqoy6NAwTPWQhlVUwMxYrHF9E4vLYbuRvvqbPmnPI=; b=PfNMNha87y/zxOLi+sCMximQpbzXvKF6ON0YFg19VeVfWf7kk37bPATA7AxMbpluZS 5H0Ol8mJsNN7kTOd1oquZFA5ImBnnqisXiKbp7n6IkIVZB8cER/v5/NRv/PQ3WiBsOyZ YYLD7pBRv4UtosHDMG/ptqtqch8ifPCJuuQDrznDwzBtnI/JAdUYIiKFFnJJcspp1zs6 v8Re6mjTSGb6Uo0TycIKSv8/WJkdpdEiKCjl6I6fzUjm6XwZMWsQo9BvoK799qJTiHUt 4vxfSTf22isXzUlE89Ztwm/5cE2697qPMa+hOqz9tyWRab/p+cl6ZukTSEMFmTtlwqVq 4xAA== X-Forwarded-Encrypted: i=1; AJvYcCVXZ+ISglPPZZqiQnYcUk8udsOD+UUxBcoHiKdmWh5ubf+zMNKoDUdHPwbNgFiYve8MGvy7Ohns4sC+BeiSuYC6W4QaDt4= X-Gm-Message-State: AOJu0YzFoJHojkiw1+qWmnVBC+2PV4nR+MkLBjRGKwjmDoAwfO5XCtLC iDAkvpHKxO8BssjIgkQhSlqQXOAvQ8Gz/jKbW1isvNUsuV5A7MLxkkqYcWNdQu7G/dIhj/e+mr4 8hxHCEwDxdhCVwFciozJuoi9QWiOnMj9x30lSsw== X-Google-Smtp-Source: AGHT+IHxSp8kXs+6inEkKSW8w3KfEOmNYC4gI5tl+SD0A2q2tBAOae+2I8vy4wjsEr+uTBxnl4QtCahWqQvt+i1oQ3o= X-Received: by 2002:a2e:b0c9:0:b0:2eb:68d0:f1cc with SMTP id 38308e7fff4ca-2ec3cfe125emr20186361fa.43.1718811772463; Wed, 19 Jun 2024 08:42:52 -0700 (PDT) MIME-Version: 1.0 References: <87plsdxhnw.fsf@gmail.com> <867celoz4q.fsf@gnu.org> <874j9px8su.fsf@gmail.com> In-Reply-To: <874j9px8su.fsf@gmail.com> From: Justin Burkett Date: Wed, 19 Jun 2024 11:42:40 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, Jun 19, 2024 at 11:16=E2=80=AFAM Robert Pluim wr= ote: > > >>>>> On Wed, 19 Jun 2024 11:09:36 -0400, Justin Burkett said: > > Justin> The purpose of which-key was to show the commands that are av= ailable > Justin> following an incomplete key sequence. If I understand correct= ly, these > Justin> maps don't hold commands and anyway would be processed before > Justin> which-key "sees" the current incomplete key sequence. > > They don=CA=BCt hold commands in the sense of defuns, but instead they > produce characters, which to Emacs is pretty much the same thing, and > looking up keys in them inside which-keys produces the same type of > display. > > Justin> If I understand correctly, if "C-d x" translates to "C-c x" t= hen > Justin> which-key I believe would see the sequence "C-c x" and find t= he > Justin> bindings following that sequence. I'm not sure how or why we = would > Justin> want to display the information that "C-d x" translates to "C= -c x". > > These maps don=CA=BCt translate sequences to sequences, they translate > sequences to characters: > > 'C-x 8 * E' -> =E2=82=AC > 'C-x 8 * L' -> =C2=A3 > etc > > so with my patch, typing 'C-x 8 *' show the entries for 'E' and 'L' > (and more besides) Ah, so I didn't understand how these are used. Those are good additions to which-key. > > Robert > -- From unknown Sun Jun 15 08:38:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Resent-From: Justin Burkett Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2024 15:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 71648@debbugs.gnu.org, rpluim@gmail.com, jb@jeremybryant.net Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.171881216421468 (code B ref 71648); Wed, 19 Jun 2024 15:50:02 +0000 Received: (at 71648) by debbugs.gnu.org; 19 Jun 2024 15:49:24 +0000 Received: from localhost ([127.0.0.1]:49158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJxYq-0005a9-7O for submit@debbugs.gnu.org; Wed, 19 Jun 2024 11:49:24 -0400 Received: from mail-ed1-f54.google.com ([209.85.208.54]:50409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJxYn-0005Zq-AS for 71648@debbugs.gnu.org; Wed, 19 Jun 2024 11:49:22 -0400 Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-57cc1c00b97so5886783a12.0 for <71648@debbugs.gnu.org>; Wed, 19 Jun 2024 08:49:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burkett-cc.20230601.gappssmtp.com; s=20230601; t=1718812092; x=1719416892; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=znRCN38Nv4A3jVvAO3lkl1Z58QTzmfZMe/o5k31lKaA=; b=VnLCn7RVK5IcQtKwUleB8TgTEZfrbRJiWub91ueWOUUfazVaCQD74vhBtx0vPotyeK Q8DlQiO/OneYKuXkkzTPxA8eQN9IERyzLK4dOdUp8FvyQAXF6QxwlLfgrcV27MzHaCU0 cHk1hgpo5QSLALlwZBb2Ppe5sfwO1nLyIpFFoZpF/K+QlTD/d/LBcaxMOQSm5pp9VEf7 fM+9cYdBMY0/do6tHfqO4h+gfsDVvExA4UghzwylpMX0hybHs/yj09zGsn7nGVeoimO0 JW9B/PXWQK3iYwpHXx/X0upH8frROPA5US4PEPUX6wUx7I5A4QiG6Rv+vkStn74ltjAd 8rTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718812092; x=1719416892; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=znRCN38Nv4A3jVvAO3lkl1Z58QTzmfZMe/o5k31lKaA=; b=T8MAAEZ6zkBrVC8SOvEghCnWDV2hXV/SgRDGvbWgREBDqdHwTIozimTJ26u1mr0EEI ewtRqZxkF9u/xxEwKFNd9aQSi3vChMVyFRz2yy2w7aIEXLsz8WAyHgIQhp6K0EGAUdjP UUPYGH1/jmDxHRkK9/gQkJGKPlkhVQFMq1UmaKwZ0LFXsGiKGT2a3UafprUm3YHvz5wh hsLd7ZXb0kzGH7bMjo436Erak6r7spBW9mo2QffZRAadrwV8LgH3lE/3N7JYMomA1Zks RxvzNWDcrSXNxetA/1qYDk8EjCRBITWqm6BjwHQ3ByIclQQrY20AnvOSDOyArs37mxri Mqfw== X-Forwarded-Encrypted: i=1; AJvYcCWfUau5+OLcOgB1mytAmbddgBj2J8dczgNGOokjE7JKTqLkb8LTmApwg4oSvIxmJ3a/OmInBGJPYrNORCLlRPU7KI6UADQ= X-Gm-Message-State: AOJu0Yyd+IBBGEWoRW3a2YhOXnnYYiv+gvEHKhlkfFtFG8N4TEfAk7DM K8KHCrWpDoVUOT11qzcVNRS7GKoYe6+O6917kDUcKF+Pjj0SXfYXQ7dbHH5SQ8xDEAERmrcXenm QG4KGAQzDuE65MCTQVpi8cXAva2DSST09hMYceA== X-Google-Smtp-Source: AGHT+IEeygoeWAtMvVZIFvZjpAGLUArostBIdsoUNyqAHhrp6A80q9WTWREPjNhsE2ZM2Ve7L+g0z/yi/1dltvk+Y1w= X-Received: by 2002:a50:d54a:0:b0:57d:5ab:7a13 with SMTP id 4fb4d7f45d1cf-57d07eab9a7mr1650654a12.34.1718812091982; Wed, 19 Jun 2024 08:48:11 -0700 (PDT) MIME-Version: 1.0 References: <87plsdxhnw.fsf@gmail.com> <867celoz4q.fsf@gnu.org> <864j9posjg.fsf@gnu.org> In-Reply-To: <864j9posjg.fsf@gnu.org> From: Justin Burkett Date: Wed, 19 Jun 2024 11:48:01 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, Jun 19, 2024 at 11:34=E2=80=AFAM Eli Zaretskii wrote= : > > > From: Justin Burkett > > Date: Wed, 19 Jun 2024 11:09:36 -0400 > > Cc: Robert Pluim , Jeremy Bryant , 71648@debbugs.gnu.org > > > > The purpose of which-key was to show the commands that are available > > following an incomplete key sequence. If I understand correctly, these > > maps don't hold commands and anyway would be processed before > > which-key "sees" the current incomplete key sequence. > > Everything in Emacs is a command. The specific sequences Robert was > talking about eventually insert characters, but they are still a > sequence of key events. So I'm not sure I understand how you > distinguish between them and what fundamental differences do you see. > Would you like to elaborate on how and why do you perceive these to be > different? > > > If I understand correctly, if "C-d x" translates to "C-c x" then > > which-key I believe would see the sequence "C-c x" and find the > > bindings following that sequence. I'm not sure how or why we would > > want to display the information that "C-d x" translates to "C-c x". > > I don't think this case is the most important or the most interesting. The purpose of the example was to show my (mis)understanding of how these maps work. I was under the impression from the info manual that translation keymaps map key sequences to other key sequences which are then mapped to "commands" (which might be just text to insert). Quoting the info manual: "When the =E2=80=98read-key-sequence=E2=80=99 function reads a key sequence= (*note Key Sequence Input::), it uses =E2=80=9Ctranslation keymaps=E2=80=9D to transla= te certain event sequences into others. The translation keymaps are =E2=80=98input-decode-map=E2=80=99, =E2=80=98local-function-key-map=E2=80= =99, and =E2=80=98key-translation-map=E2=80=99 (in order of priority). Translation keymaps have the same structure as other keymaps, but are used differently: they specify translations to make while reading key sequences, rather than bindings for complete key sequences. As each key sequence is read, it is checked against each translation keymap. If one of the translation keymaps binds K to a vector V, then whenever K appears as a sub-sequence _anywhere_ in a key sequence, that sub-sequence is replaced with the events in V." This reads to me like translation keymaps don't yield "commands" they act at an intermediate level. In any event, Robert's example was helpful, and I think that information would be useful to include in which-key. From unknown Sun Jun 15 08:38:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Resent-From: Jeremy Bryant Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2024 21:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 71648@debbugs.gnu.org, Eli Zaretskii , Justin Burkett Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.171883168032046 (code B ref 71648); Wed, 19 Jun 2024 21:15:01 +0000 Received: (at 71648) by debbugs.gnu.org; 19 Jun 2024 21:14:40 +0000 Received: from localhost ([127.0.0.1]:59481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK2dc-0008Km-3F for submit@debbugs.gnu.org; Wed, 19 Jun 2024 17:14:40 -0400 Received: from out-179.mta0.migadu.com ([91.218.175.179]:33422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK2dZ-0008KW-1Q for 71648@debbugs.gnu.org; Wed, 19 Jun 2024 17:14:38 -0400 X-Envelope-To: 71648@debbugs.gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1718831637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S9jOF/2m4t06Dv2HLEQ8TZKOW2jZcFOF7h/33B6s+QE=; b=djLwRLYnOdw3sLJe+KpkbjnWAzLb0UQNs7kJCh2cqHOdD3o3eAX3w710YIZrWlbgc7/kz7 UH+YAX2dzc7IcJkbtnDUzli5/ddynlGvE+iYdEEGVhquc96DJj+6Wc/HJThQbCtuRUhMN8 1gK4qy+zLB4VsPaM6JMT2EKOYWTqsgI1lUCeITKSrTBYKOwhxa9D+7USA937Np9n/HWEVf zxvsfZOaG8EgtHTZCNMy9bze5hBjWzAqa6uy1kvACEo/YqPvRA84lyKzpdMkbFnlbQIENH ja1tAGodQ5ugGKqwfyQyN0r6amrohUxAQBihxWLPLP3NgArcZzy6xAHGASHdPQ== X-Envelope-To: eliz@gnu.org X-Envelope-To: justin@burkett.cc X-Envelope-To: rpluim@gmail.com X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Jeremy Bryant In-Reply-To: <874j9px8su.fsf@gmail.com> (Robert Pluim's message of "Wed, 19 Jun 2024 17:16:01 +0200") References: <87plsdxhnw.fsf@gmail.com> <867celoz4q.fsf@gnu.org> <874j9px8su.fsf@gmail.com> Date: Wed, 19 Jun 2024 22:13:55 +0100 Message-ID: <874j9o4ovg.fsf@jeremybryant.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: >>>>>> On Wed, 19 Jun 2024 11:09:36 -0400, Justin Burkett said: > > Justin> The purpose of which-key was to show the commands that are av= ailable > Justin> following an incomplete key sequence. If I understand correct= ly, these > Justin> maps don't hold commands and anyway would be processed before > Justin> which-key "sees" the current incomplete key sequence. > > They don=CA=BCt hold commands in the sense of defuns, but instead they > produce characters, which to Emacs is pretty much the same thing, and > looking up keys in them inside which-keys produces the same type of > display. > > Justin> If I understand correctly, if "C-d x" translates to "C-c x" t= hen > Justin> which-key I believe would see the sequence "C-c x" and find t= he > Justin> bindings following that sequence. I'm not sure how or why we = would > Justin> want to display the information that "C-d x" translates to "C= -c x". > > These maps don=CA=BCt translate sequences to sequences, they translate > sequences to characters: > > 'C-x 8 * E' -> =E2=82=AC > 'C-x 8 * L' -> =C2=A3 > etc > > so with my patch, typing 'C-x 8 *' show the entries for 'E' and 'L' > (and more besides) > > Robert This is a useful patch and would enhance which-key=20 From unknown Sun Jun 15 08:38:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2024 08:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Justin Burkett Cc: 71648@debbugs.gnu.org, Eli Zaretskii , jb@jeremybryant.net Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.17188721476584 (code B ref 71648); Thu, 20 Jun 2024 08:30:02 +0000 Received: (at 71648) by debbugs.gnu.org; 20 Jun 2024 08:29:07 +0000 Received: from localhost ([127.0.0.1]:48545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKDAJ-0001i7-Cs for submit@debbugs.gnu.org; Thu, 20 Jun 2024 04:29:07 -0400 Received: from mail-lf1-f45.google.com ([209.85.167.45]:61752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKDAH-0001hX-4D for 71648@debbugs.gnu.org; Thu, 20 Jun 2024 04:29:05 -0400 Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-52bc335e49aso623607e87.3 for <71648@debbugs.gnu.org>; Thu, 20 Jun 2024 01:29:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718872075; x=1719476875; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Elg9oW37m0XO0YsWxjARQ1jLjnnAJuEhl+Y5UK3uSrE=; b=adzA8Tt+uL9IKOVXeEH6iCLzRNUNQUBmEjJXMUspp35HV9wcpsqSul9tiFvtO2oo2x aqHg2JyG27cRQiwu7hRj7CsXP4ZS/OI8aYAU+Xi2P8c1B3pY1QT4Z9Ltc7R3AN5drMbA v2nlM966CJalZJN0duc+amLUKxVhNSSPREiJOCJ5hHl91e+5Kcj4Rdf1Qjpwe9ryw18O 2Re//kzn/J2P0OBKT3gZM5cTFAneJ6tVRKd8pyzXzOm0vhNlpEd9r7m7T77mvT8uJIzB HsjXLot0lNPf9O1yf/J43uHaHgtJMQvPSduU2+OuJwLWWS2X6pH4vymsKvJ4oMstru+n 7iEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718872075; x=1719476875; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Elg9oW37m0XO0YsWxjARQ1jLjnnAJuEhl+Y5UK3uSrE=; b=iwWeZJ8wn6bW0CvZ+zJRg2ugG4TNESYzsHL0dF0fA6D9CyDaPd4VKLcnmvY9EWqC+u n21iTV9BW4U0TJIn3iXrG1IHz3NqHoPz/YUrA7kCq7ARBmtiAT/7R6J+QIJb/NSloLT+ +T8JNf9O2kyYE3steBMCaW4Rqd0ufBgrgSj+vnw3vOwpakweLCixQX4rrBJsil89MJI6 mvzksylVs2t9hFIhARqMfw+KBDDyqxSduvqdNxtbAAwdtWDkjKm8Lz4VM5WoygVYYHRy jpX1yWXzo3xmrJ0B6l3J90dq6rD+ny23ri1mtqCqnpwG12LMi06HnbwJt3AQTpwrNvbf cSXw== X-Forwarded-Encrypted: i=1; AJvYcCVz4i3rQBxyHVuNYSxRKLHiHVUJvLuTMg5IHKdH9NF5TUU/cfVzXSnywXGO04bvpyksc3O0MkH9g0Fu84dDxRJwt71rjuE= X-Gm-Message-State: AOJu0Yx/8lSEoLdB9TTL3Jbwiz7+KYLnV5kDW7VFxT2XTAFc+v4Dd6Fo Z0oXEpiN8ftu8u+1/1NPbdximy4hBofREBDF0DW+3ofb4/qmkbqNYEGYOw== X-Google-Smtp-Source: AGHT+IGY0XpA8wNqiAq+p3UKH9iT9FqHZLkPv6m+v2iCWQinKkTqAP4BZ/Jm03GZ29VNOVMqkFa4QQ== X-Received: by 2002:a05:6512:1053:b0:52c:9e51:c3f with SMTP id 2adb3069b0e04-52ccaa919aemr3857794e87.42.1718872073184; Thu, 20 Jun 2024 01:27:53 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d0c54c9sm17206285e9.27.2024.06.20.01.27.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 01:27:52 -0700 (PDT) From: Robert Pluim In-Reply-To: (Justin Burkett's message of "Wed, 19 Jun 2024 11:48:01 -0400") References: <87plsdxhnw.fsf@gmail.com> <867celoz4q.fsf@gnu.org> <864j9posjg.fsf@gnu.org> Date: Thu, 20 Jun 2024 10:27:51 +0200 Message-ID: <87v824vx14.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 19 Jun 2024 11:48:01 -0400, Justin Burkett said: Justin> In any event, Robert's example was helpful, and I think that Justin> information would be useful to include in which-key. By default, or with a custom option? If the latter, it could be a list of 'extra' keymaps for `which-key' to consult. Robert -- From unknown Sun Jun 15 08:38:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Resent-From: Justin Burkett Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2024 14:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 71648@debbugs.gnu.org, Eli Zaretskii , jb@jeremybryant.net Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.17188933209783 (code B ref 71648); Thu, 20 Jun 2024 14:22:02 +0000 Received: (at 71648) by debbugs.gnu.org; 20 Jun 2024 14:22:00 +0000 Received: from localhost ([127.0.0.1]:59665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKIfn-0002Xj-Kz for submit@debbugs.gnu.org; Thu, 20 Jun 2024 10:21:59 -0400 Received: from mail-ed1-f50.google.com ([209.85.208.50]:46161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKIfl-0002XN-Rl for 71648@debbugs.gnu.org; Thu, 20 Jun 2024 10:21:58 -0400 Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-57d20d89748so901115a12.0 for <71648@debbugs.gnu.org>; Thu, 20 Jun 2024 07:21:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burkett-cc.20230601.gappssmtp.com; s=20230601; t=1718893248; x=1719498048; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8BS+JeZvD6ZTJ1hbdOWAFXcp4eQi53dUxoWjqx/kD4g=; b=XU331Rjm+OTsRiw/O2YKzHhgh4UT1mp5+iyOteAy64b3jPh3/YsG1tppOLF4gDQDmL BMblIItoeo+6998E9qoAdk6THbV6N1qhYNx6sEgSKp1CUrsk+Jimk+djEoYanF8rq0m3 BFYamJKbxErHo8XZHya6eJ6lc5ohJ81BULV/s2oQMmQ4/Tw86STXf+H3ZJI1Ii/1ilxd G3G3fVErbxv7sZQY7arao4bAX7qA6jFozLJu2ioMUlWFcQ9IrQxt7JVSwBcKZjJ03XSN mPJco+F0yDmRDKaXYwDRxajEpUEVZR9KBTnhX/1VEtLWyCxN3OMtZ/30wOnRpLQmlJ96 1vUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718893248; x=1719498048; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8BS+JeZvD6ZTJ1hbdOWAFXcp4eQi53dUxoWjqx/kD4g=; b=Jc6v61hGRA3c+2R+Jl0rXAyWs/NWez7zAEMBxWr6PaFaNcg8C5TOUKfwIa7x0ZqEdQ Abiq39VuMyHwpLq8hAwLzbjvLXEJ1rdHhW8PMleQYQ89+6NSZrqdUicUH/FlDBXvvrEE vplnonTPJcGAbF3uRv4DOi9++Uap3wPxVcJX6mA8gKvw3BUkpCOv5vGv4mQycMC5wBeR 2axsOiDWOpfZ/HcS8JEPs4kM7V4pNNRcrAcxEadHtWJzYvdieOt7gvFDGMYj/C6UdVkD 36WaGz3WPzpgEZFXmJjUdAA75yaXF8YhGcQ0CKZejWdJixQIwOPxFcptHfpnansKptBA dPCA== X-Forwarded-Encrypted: i=1; AJvYcCWG86YMPET0Y7LF2BWWHCE1Fs6Nm0z5rAxA1QTVQK1OmjBd6/0IDBizLG2iKmKHZicoutMgSiKmMdygpFC2sXSIEG2ug5A= X-Gm-Message-State: AOJu0YxVD++Qdr7u07lZws7N+eO7Dx7sLaWSaP4DBczDMdPxL1A/vVmz rKTkRT+fcYROo05gMV33rMiFRENvCglCu912npUy1WoRbnYp6/vVxRAA2cgNYAZjujCeeuYNXEI wSuTx8+9coUwY+ErqCZizNtrnMrWrSiw5k1Zv/A== X-Google-Smtp-Source: AGHT+IEaShPbDmHWko0zspIrnphMBbgk0RVQtmAXx7hXUyhom5qVNpzVdbYy6tf9NAi3rkhWsSOc1tU++0rbdp4Vsuk= X-Received: by 2002:a50:a6c6:0:b0:57c:7dcd:bce2 with SMTP id 4fb4d7f45d1cf-57d07ede3dcmr2703494a12.41.1718893247847; Thu, 20 Jun 2024 07:20:47 -0700 (PDT) MIME-Version: 1.0 References: <87plsdxhnw.fsf@gmail.com> <867celoz4q.fsf@gnu.org> <864j9posjg.fsf@gnu.org> <87v824vx14.fsf@gmail.com> In-Reply-To: <87v824vx14.fsf@gmail.com> From: Justin Burkett Date: Thu, 20 Jun 2024 10:20:36 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Jun 20, 2024 at 4:27=E2=80=AFAM Robert Pluim wro= te: > > >>>>> On Wed, 19 Jun 2024 11:48:01 -0400, Justin Burkett said: > > Justin> In any event, Robert's example was helpful, and I think that > Justin> information would be useful to include in which-key. > > By default, or with a custom option? If the latter, it could be a list > of 'extra' keymaps for `which-key' to consult. I can see an argument for either. My only concern with the option would be explaining what the option does in plain language. > > Robert > -- From unknown Sun Jun 15 08:38:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2024 14:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Justin Burkett Cc: 71648@debbugs.gnu.org, Eli Zaretskii , jb@jeremybryant.net Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.171889544714232 (code B ref 71648); Thu, 20 Jun 2024 14:58:02 +0000 Received: (at 71648) by debbugs.gnu.org; 20 Jun 2024 14:57:27 +0000 Received: from localhost ([127.0.0.1]:60820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKJE6-0003hU-WD for submit@debbugs.gnu.org; Thu, 20 Jun 2024 10:57:27 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:54557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKJE4-0003h5-Pg for 71648@debbugs.gnu.org; Thu, 20 Jun 2024 10:57:25 -0400 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-364cdfdaf91so638749f8f.1 for <71648@debbugs.gnu.org>; Thu, 20 Jun 2024 07:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718895375; x=1719500175; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=tq9fBsb58/oxRzwvNq34GPGvIgK1IYNcoZJLFWX3H0Y=; b=jt78c3PY8CnimIRFQpzNSrJAH2nD5yIq5Bu7XgAAickOEvU0ZI0yHkWxdARafjaEpu MXjhzJ2xpj0FvPjowuoSWoX/G2T5crif48f6frERzPcALvt1mJtBt2jEEwMXUFS+qhA+ fOI8i/EaKmEOMCV0iEoupXCHdgQDsudQoJALdO4z4Rt8qS+vE9MftmkiNhsheU5ZFZyM 7XMz8j4jUZTOeFQiVsIzIgJP3nu1x6VsjGFaoLmKFUMfdfxXlfoLcn41C/GNcpraYfXS Z+/BEkCUuiSbQT0/1JZ5oI0t7mutFI8C87dU0EtPO+VDLmS/A/9MJZlL69jrpsIbxWwO ZZUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718895375; x=1719500175; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tq9fBsb58/oxRzwvNq34GPGvIgK1IYNcoZJLFWX3H0Y=; b=VIRNqN4H3w7ojyuCyoamKp8EXOBP9iV+qMB8/5yPkvx3vcKEg+r+pZ5jZeI7TmN7EP +uTsWr0CEFLaEBxe6g1OiqstSSxDzciyFjfbyrTJ/vwIOj3b7SplQsTDWIh0T2A8XfKq M88mTwCinJNp6DHjO0nr8sLH/uCwfU9edcYycLo6vvX541iqAkxgf7yor6YtbTh/oyUD Tlhj48CFHPGIhR3kIPqvjc3927ldF1L2mBkHKbzWx9Gt45U7HjtLtZdzjtJsccG630R6 T82aZtEt2+dI0crgSCDJc8uy5ntW6TzkyEAJkUTfrBqGAw0bwxfu6cUPnwLyWeGUxUKE FqIQ== X-Forwarded-Encrypted: i=1; AJvYcCWCbRMkHgh2//1OmQ3plY6FXj4d3AwJp5qLnY8LzHs6qyZws31gIr0GZKXqb9d+HkJuuhdV/VwzbxK8g8O8OalWJfNm+Xk= X-Gm-Message-State: AOJu0YxcK1qioijnJyKb6JExLMtMhQLwWg16jrDHCY99CGvuodhVsgtG KZ2Bdkqa75+FbNKLRFoKsVanFblSBT3pGIkzOAPjSKJQ7/67jee1cHS22Q== X-Google-Smtp-Source: AGHT+IGUbUB4tu21rHfQxGorXgnkx8k9x4ZZjYkSmNXz3ullH6fX13ypa1BDjUIZaleAzZSJGtKYiQ== X-Received: by 2002:a05:6000:4584:b0:363:418:346b with SMTP id ffacd0b85a97d-36317c77551mr3557728f8f.38.1718895374354; Thu, 20 Jun 2024 07:56:14 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3639a18bf5esm4408500f8f.88.2024.06.20.07.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 07:56:13 -0700 (PDT) From: Robert Pluim In-Reply-To: (Justin Burkett's message of "Thu, 20 Jun 2024 10:20:36 -0400") References: <87plsdxhnw.fsf@gmail.com> <867celoz4q.fsf@gnu.org> <864j9posjg.fsf@gnu.org> <87v824vx14.fsf@gmail.com> Date: Thu, 20 Jun 2024 16:56:13 +0200 Message-ID: <87msnfwtma.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 20 Jun 2024 10:20:36 -0400, Justin Burkett said: Justin> On Thu, Jun 20, 2024 at 4:27=E2=80=AFAM Robert Pluim wrote: >>=20 >> >>>>> On Wed, 19 Jun 2024 11:48:01 -0400, Justin Burkett said: >>=20 Justin> In any event, Robert's example was helpful, and I think that Justin> information would be useful to include in which-key. >>=20 >> By default, or with a custom option? If the latter, it could be a li= st >> of 'extra' keymaps for `which-key' to consult. Justin> I can see an argument for either. My only concern with the opti= on Justin> would be explaining what the option does in plain language. Wordsmithing is easy ;-) (defcustom which-key-extra-keymaps nil "List of extra keymaps to show bindings from. This allows you to add personal keymaps for `which-key' to check. A preset value is available to enable looking in `key-translation-map', which contains the \\=3D'C-x 8' bindings for entering common characters." :type '(choice (list :tag "Translation map" (const key-translation-map)) (repeat :tag "Custom" symbol)) :version "30.1") Robert --=20 From unknown Sun Jun 15 08:38:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Resent-From: Justin Burkett Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2024 15:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 71648@debbugs.gnu.org, Eli Zaretskii , jb@jeremybryant.net Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.171889814220070 (code B ref 71648); Thu, 20 Jun 2024 15:43:02 +0000 Received: (at 71648) by debbugs.gnu.org; 20 Jun 2024 15:42:22 +0000 Received: from localhost ([127.0.0.1]:33861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKJvZ-0005Dd-Ne for submit@debbugs.gnu.org; Thu, 20 Jun 2024 11:42:21 -0400 Received: from mail-ej1-f51.google.com ([209.85.218.51]:53721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKJvX-0005DO-9t for 71648@debbugs.gnu.org; Thu, 20 Jun 2024 11:42:20 -0400 Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a6f1f33486eso51948466b.3 for <71648@debbugs.gnu.org>; Thu, 20 Jun 2024 08:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burkett-cc.20230601.gappssmtp.com; s=20230601; t=1718898069; x=1719502869; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vKnKYFAff27vpnqL3WDQ+AlulAUELw1fVjNQ6fUYPb0=; b=RGcWfAOr1SZ6YasOWSA/+FnOtFP28IFJO2HJkNEO+ZiZhOu/K3PKQik22YtQ3fA4xC mCiGVGDw0Ym2y0/sPEMl91X2rhSdoizdA5s9p+agbADooAzremAGjGmw0zmPb6pVO55W 95g4EbeaB1T+lyisPzTrNANzr+rqWDxZayXAuwwtYKnKisp/CDOuMzj/nu8X8AIXUkus Q8Yh7exfF+aARu+c3GXxfUpXU6VcuV0Pw0YyAgr0ZzB+aXlSf4u8RJXmD+BAd8EIxg/t vqbj00w6LH99HA/DX8hJeFT17SAVvG2wSr9R20WKQQXXIS4W/PwTSnPXICm7gKsYMl+m rIqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718898069; x=1719502869; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vKnKYFAff27vpnqL3WDQ+AlulAUELw1fVjNQ6fUYPb0=; b=HaA0xEJ5lwQSw3rSGifLuVBEcttX+tJ1iS+GfSEwDjUToePiSSCp6UhSeGoFgaXLPi z3uN2HsdFtYIxib5DzQ6GB8idbs1g8yNK3B9mbvISippfJsF38T8Epgb1fNQj6et0OlE AEQdNM9ZJpdvW6aUiuSTJHi1qcxdHOJji3/caejADjFJEr0D9esMjcnINTAhtLRV/iVj yXHEJK26iQhDcx6IRbR7EzVGp1GUAWyVcEq1AAVx/PsyqpaP21hyI/OZ98C5USMLdV8m 3wGTBTSHL77pA7iLmFiTS2UfHfxcIsI6q1RRz0zsAASMSyUtUSlYxheXXYL+NHgqIync Ynbg== X-Forwarded-Encrypted: i=1; AJvYcCVDavBb1CoXGVwyaiBtsmt2yIr1MiwDiZDeT6uTSiwTX6AWtvwl4NZmxLl86BkXrIQ5UjJ0mUS+mZX8tyoiPsHpXSG/m+k= X-Gm-Message-State: AOJu0YzsxxXwuFXd/5/MkTWCZsoWLAOgEBgGvyoJc7qWwHplPXpCL23Z A0qYGs9Jzo79s8fqaFORU90F9C7QT3vg6vohE1fpUwk4gWlLz650nuIEH0xDYI7zu52yM7s+DTm M1u2cXZaNCLzxCbem3pAxoOm+/wznmgI/iw33CQ== X-Google-Smtp-Source: AGHT+IHa+bjQ6PelrUkNuyAb4TDtue4B74nBJh+CNc7w/nFM/l2nJsdrNl9WZOr12KE3vgNReMJ3MUVAPsyu9AUzUo0= X-Received: by 2002:a50:d5cb:0:b0:57c:6861:d731 with SMTP id 4fb4d7f45d1cf-57d07ea6468mr4219780a12.28.1718898069454; Thu, 20 Jun 2024 08:41:09 -0700 (PDT) MIME-Version: 1.0 References: <87plsdxhnw.fsf@gmail.com> <867celoz4q.fsf@gnu.org> <864j9posjg.fsf@gnu.org> <87v824vx14.fsf@gmail.com> <87msnfwtma.fsf@gmail.com> In-Reply-To: <87msnfwtma.fsf@gmail.com> From: Justin Burkett Date: Thu, 20 Jun 2024 11:40:57 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Jun 20, 2024 at 10:56=E2=80=AFAM Robert Pluim wr= ote: > > >>>>> On Thu, 20 Jun 2024 10:20:36 -0400, Justin Burkett said: > > Justin> On Thu, Jun 20, 2024 at 4:27=E2=80=AFAM Robert Pluim wrote: > >> > >> >>>>> On Wed, 19 Jun 2024 11:48:01 -0400, Justin Burkett said: > >> > Justin> In any event, Robert's example was helpful, and I think that > Justin> information would be useful to include in which-key. > >> > >> By default, or with a custom option? If the latter, it could be a = list > >> of 'extra' keymaps for `which-key' to consult. > > Justin> I can see an argument for either. My only concern with the op= tion > Justin> would be explaining what the option does in plain language. > > Wordsmithing is easy ;-) > > (defcustom which-key-extra-keymaps nil > "List of extra keymaps to show bindings from. > This allows you to add personal keymaps for `which-key' to check. A > preset value is available to enable looking in `key-translation-map', > which contains the \\=3D'C-x 8' bindings for entering common characters." > :type '(choice (list :tag "Translation map" (const key-translation-map)= ) > (repeat :tag "Custom" symbol)) > :version "30.1") > That seems reasonable enough. How about doing both? Add the option and use key-translation-map for the default value. > Robert > -- From unknown Sun Jun 15 08:38:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2024 13:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Justin Burkett Cc: 71648@debbugs.gnu.org, Eli Zaretskii , jb@jeremybryant.net Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.171923494511882 (code B ref 71648); Mon, 24 Jun 2024 13:16:01 +0000 Received: (at 71648) by debbugs.gnu.org; 24 Jun 2024 13:15:45 +0000 Received: from localhost ([127.0.0.1]:57284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLjXs-00035a-RC for submit@debbugs.gnu.org; Mon, 24 Jun 2024 09:15:45 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:60465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLjXr-00035D-2n for 71648@debbugs.gnu.org; Mon, 24 Jun 2024 09:15:43 -0400 Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3608e6d14b6so2866691f8f.0 for <71648@debbugs.gnu.org>; Mon, 24 Jun 2024 06:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719234876; x=1719839676; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Fr257C/ZSBr2rrrMm2sUpQlqsBanv17Xst/Z4lNX7D0=; b=Ol0TVCOqjWOBPvM+aJGRTjs5yEWeHqV35e+N8Q8+KkCOcoWJa8YvZlmTicVKd5qcb8 vnZYQpxQahn7p3Wt6RrTi6zmzq4UWurU9rGmZkVT4wGrrWVB8Elopmg30+n7p1aUKAAP if+Mj33PQBezwFasQt8wrU4Gj9JXQJFwDNYUG1f3x9wCgiq/9iaN+3gmba70Mo5sVmfp 5PomW1BUqCdt2wMAx7m7/O33aYTHAcaDwq1NPI+DiEFGh9zsXvXgzXuXc7nvAI1Ca/kt TGdFqQSDRHILbUxp8TasVdW6Pfeoak/eWOd7NySdv/7TGD55FAMdn3yDK1Ka1d3M18Uv L2Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719234876; x=1719839676; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fr257C/ZSBr2rrrMm2sUpQlqsBanv17Xst/Z4lNX7D0=; b=TpEb2/YMXfezaCQGnNOpv900gVoVbJB/bv1pmV4ADwZ0KW04LNIcqlNdTCt7emaP5j udCVSunfRoouwIY56eRqOQjVAwyQbpp6tOsl4GXC/v1WSYbB5wAnwjcRZItT8hcYJne8 jjU9B+t1PJDN801PTfVqE5sdBHCNSYPFdjbCYYC/YnW+OaNj4H+ziRVQDDGZAvasEWSf tybsZnQYB3RhtTnGKUMn7CfQXd+og8UoBJ1fZ+P7sI12ujFwOoG2T3YJOs4BNijHOfFr Oul3i3jz6Vr3qBCDj0fgBV3zi1W4T8k8ilURi+M/DIdQqsHoKso/Imfr7dqvstzNIA30 aZ6A== X-Gm-Message-State: AOJu0YzlBsDU1YjpztHMzO/+ZJ/P5r3ogYDkO/cqMRnFQVE3/DnpV2fB pQQhB/VjC1AvuV4WK8FZICJOQHDiCmtqWF1o6gxe6hi2zHWW++pvSPu3fw== X-Google-Smtp-Source: AGHT+IE1xuOt/ZH2mV2wxmpfZlItsxjj3yhgrpyhgRHaytDARdH8iXxm/dY0uMi7YY0I+0ETAFf34A== X-Received: by 2002:adf:a382:0:b0:362:f291:6f90 with SMTP id ffacd0b85a97d-366e9652bcemr2684999f8f.60.1719234875861; Mon, 24 Jun 2024 06:14:35 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3666dc46d50sm9699994f8f.67.2024.06.24.06.14.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 06:14:35 -0700 (PDT) From: Robert Pluim In-Reply-To: (Justin Burkett's message of "Thu, 20 Jun 2024 11:40:57 -0400") References: <87plsdxhnw.fsf@gmail.com> <867celoz4q.fsf@gnu.org> <864j9posjg.fsf@gnu.org> <87v824vx14.fsf@gmail.com> <87msnfwtma.fsf@gmail.com> Date: Mon, 24 Jun 2024 15:14:34 +0200 Message-ID: <87a5jabhz9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> On Thu, 20 Jun 2024 11:40:57 -0400, Justin Burkett said: Justin> That seems reasonable enough. How about doing both? Add the opt= ion and Justin> use key-translation-map for the default value. Patch against emacs-30 attached. Since which-key is new in emacs-30, I=CA=BCm assuming a NEWS entry is not required for this specific change. Eli, let me know if it should go to master instead. Robert --=20 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Show-entries-from-key-translation-map-in-which-key-m.patch >From d6dd58a0c75affb9ff18b4974ca5f4cd56eb2604 Mon Sep 17 00:00:00 2001 From: Robert Pluim Date: Mon, 24 Jun 2024 15:09:00 +0200 Subject: [PATCH] Show entries from key-translation-map in which-key mode To: emacs-devel@gnu.org * lisp/which-key.el (which-key-extra-keymaps): New user option. (which-key--get-current-bindings): Consult it. (Bug#71648) --- lisp/which-key.el | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/lisp/which-key.el b/lisp/which-key.el index 91007ce4ada..a5075b3ba69 100644 --- a/lisp/which-key.el +++ b/lisp/which-key.el @@ -233,6 +233,15 @@ which-key-show-docstrings (const :tag "Replace command name with docstring" docstring-only)) :package-version "1.0" :version "30.1") +(defcustom which-key-extra-keymaps '(key-translation-map) + "List of extra keymaps to show entries from. +The default is to check `key-translation-map', which contains the +\\='C-x 8' bindings for entering common characters." + :type '(choice (list :tag "Translation map" (const key-translation-map)) + (const :tag "None" nil) + (repeat :tag "Custom" symbol)) + :package-version "1.0" :version "30.1") + (defcustom which-key-highlighted-command-list '() "Rules used to highlight certain commands. If the element is a string, assume it is a regexp pattern for @@ -1942,8 +1951,10 @@ which-key--get-keymap-bindings (defun which-key--get-current-bindings (&optional prefix filter) "Generate a list of current active bindings." - (let (bindings) - (dolist (map (current-active-maps t) bindings) + (let (bindings + (maps (nconc (current-active-maps t) + (mapcar #'symbol-value which-key-extra-keymaps)))) + (dolist (map maps bindings) (when (cdr map) (setq bindings (which-key--get-keymap-bindings -- 2.39.2 --=-=-=-- From unknown Sun Jun 15 08:38:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2024 13:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 71648@debbugs.gnu.org, jb@jeremybryant.net, justin@burkett.cc Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.171923584514982 (code B ref 71648); Mon, 24 Jun 2024 13:31:02 +0000 Received: (at 71648) by debbugs.gnu.org; 24 Jun 2024 13:30:45 +0000 Received: from localhost ([127.0.0.1]:57933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLjmO-0003tZ-OX for submit@debbugs.gnu.org; Mon, 24 Jun 2024 09:30:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLjmL-0003tB-Ey for 71648@debbugs.gnu.org; Mon, 24 Jun 2024 09:30:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLjmE-0000mp-Hp; Mon, 24 Jun 2024 09:30:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=V7HBakuaiMhWkw/QE6U1N2GNwejBHrYHP4Q34iVy+ks=; b=K6YKLCF6osHBHDB8JP07 lXGWegK/JVS1TruxTuGkalccDAWEEwvb0RttRs9TqV2fUkoK8vw4/Y/cHWSKyIzeen4VILO9l9lDI bIGAx6e1F44ITiQL4TjCjxWStUgB4wSHtaN0xqG2jYi51NZ9mcPHIdDxiq2F4rce2LK+eZeRrtoWC UeN9KjOL7bR6vi2Xd6Q8tH9j/EAxJAtWw7C6IToenlgIqikdXTjb45X8qa/ebV3vW27A9KB7d4CdD S7OfAF3xhDfHGqceu6db35Zc/rCi3i/MU36sJm0rEBg9Qn3r757miobOmi6LWq5Bt7IPlxr5yvJOM IPjEg3S5Na7zJw==; Date: Mon, 24 Jun 2024 16:30:30 +0300 Message-Id: <86frt2bh8p.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87a5jabhz9.fsf@gmail.com> (message from Robert Pluim on Mon, 24 Jun 2024 15:14:34 +0200) References: <87plsdxhnw.fsf@gmail.com> <867celoz4q.fsf@gnu.org> <864j9posjg.fsf@gnu.org> <87v824vx14.fsf@gmail.com> <87msnfwtma.fsf@gmail.com> <87a5jabhz9.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: 71648@debbugs.gnu.org, Eli Zaretskii , jb@jeremybryant.net > Date: Mon, 24 Jun 2024 15:14:34 +0200 > > Patch against emacs-30 attached. Since which-key is new in emacs-30, > Iʼm assuming a NEWS entry is not required for this specific change. > > Eli, let me know if it should go to master instead. This is okay for emacs-30, thanks. From unknown Sun Jun 15 08:38:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2024 17:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 71648@debbugs.gnu.org, jb@jeremybryant.net, justin@burkett.cc Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.171924971221711 (code B ref 71648); Mon, 24 Jun 2024 17:22:02 +0000 Received: (at 71648) by debbugs.gnu.org; 24 Jun 2024 17:21:52 +0000 Received: from localhost ([127.0.0.1]:35167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLnO3-0005e1-W9 for submit@debbugs.gnu.org; Mon, 24 Jun 2024 13:21:52 -0400 Received: from mail-lj1-f182.google.com ([209.85.208.182]:60543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLnO1-0005dj-7m; Mon, 24 Jun 2024 13:21:50 -0400 Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2ec50a5e230so31180481fa.0; Mon, 24 Jun 2024 10:21:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719249642; x=1719854442; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=zB12+zrArjeIMXYi7Asy1QoagoicsyHN6JCZLQ/QUmk=; b=JveMU5ipKdkJ49vi2Q6N6OWUv+XiKV4ib5H1E8g0eEemntYymF4OumHSspUjNi5R4Y KJfiuNlLAJLW8PrMF+8O8tJl/38lOWbu3l/NIIFDx0mZFlVXVYE55o4o3l5bTH5xQ9st nC0KHCAVG+0xO0MBei5wQw7mFXksrMgb8mXgkDJ1EVC7IVxaUKjTmKkKAAbeAIOOA1oQ jDA+gR/dydgRFsh2nVs+kcyzVy6MgqzYaVV9aquayYL2Mdl5ErTLcCfN5zMLVZxluaIA vQPBT5xUp/t6gZhpms/N1EMkeDjQvBXMvpmaF1SX9UZ028NVIj7q8wAewy+BKuiCz71Y appw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719249642; x=1719854442; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zB12+zrArjeIMXYi7Asy1QoagoicsyHN6JCZLQ/QUmk=; b=akQF0cvRSRIYYbZOXupcVzOcxIsFfIt5+m3k19IoxEfWdeo9rpwPXMn3RZcOrwPce1 AKw7Unrs4WH90wlr8CziTM4NpR3U3tF59VHp3tzzX+LPHWuhw7pdVoFRoIOCBYLEnCQP k5cDybxETnEv1mytjbWg2Q9IVsnktGM71S47dc8fHm6dwEyvBR66r3S7VC9hTKr/9d7E 1idsBXhtRLg1Dcrr1tr+RgDzZ30cPke/xD48co8P4hpL8StYjQnqa9TqcFj+gCqZ1cYD D5RzpIK0ge70fCcqdp5Le1O7gc+GgmX9OG43FoyQfUBW1VU00fXy3SGFGYBIXc04D/YA KdGQ== X-Forwarded-Encrypted: i=1; AJvYcCWog2o0tTYM3KIJMqlXe7gXDySSD5jy+YI1eiDtXRAtlLuUf9mXTnBmkoI8pfJ/dsaOQ0boqTTGv/4FFh8OV/YN7z1x9+dmVSROiHqyYze3vtrlsSXLcU383U8MSsj4 X-Gm-Message-State: AOJu0YwURAozyjl73yFrsY5bB2SckYOnwUq/Xt+IqBggq+n1patCVES+ 5P8yYQLlgjWDoXy78evkWwq5O/bRlV49Fwj2wBgOFySLVOieJYVENpDr3Q== X-Google-Smtp-Source: AGHT+IHvNeUCbjVnzHe0ylIwk7ZXbxeopjBF99eFG0X2djAy6Le7ae0X9GlZER58zP5qlzZ5UobKww== X-Received: by 2002:a2e:3005:0:b0:2ec:550e:24f3 with SMTP id 38308e7fff4ca-2ec5b26996cmr33121771fa.10.1719249641563; Mon, 24 Jun 2024 10:20:41 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d212254sm180775225e9.45.2024.06.24.10.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 10:20:41 -0700 (PDT) From: Robert Pluim In-Reply-To: <86frt2bh8p.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 24 Jun 2024 16:30:30 +0300") References: <87plsdxhnw.fsf@gmail.com> <867celoz4q.fsf@gnu.org> <864j9posjg.fsf@gnu.org> <87v824vx14.fsf@gmail.com> <87msnfwtma.fsf@gmail.com> <87a5jabhz9.fsf@gmail.com> <86frt2bh8p.fsf@gnu.org> Date: Mon, 24 Jun 2024 19:20:40 +0200 Message-ID: <87wmme9s0n.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 71648 fixed close 71648 30.1 quit >>>>> On Mon, 24 Jun 2024 16:30:30 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: 71648@debbugs.gnu.org, Eli Zaretskii , jb@jeremy= bryant.net >> Date: Mon, 24 Jun 2024 15:14:34 +0200 >>=20 >> Patch against emacs-30 attached. Since which-key is new in emacs-30, >> I=CA=BCm assuming a NEWS entry is not required for this specific cha= nge. >>=20 >> Eli, let me know if it should go to master instead. Eli> This is okay for emacs-30, thanks. Thanks, Closing. Committed as 7e8a97ac788 Robert --=20