GNU bug report logs - #71642
30.0.50; eglot-execute doesn't support ExecuteCommandParams

Previous Next

Full log

View this message in rfc822 format

From: João Távora <joaotavora <at> gmail.com>
To: Jeremy Bryant <jb <at> jeremybryant.net>
Cc: 71642 <at> debbugs.gnu.org, Troy Brown <brownts <at> troybrown.dev>
Subject: bug#71642: 30.0.50; eglot-execute doesn't support ExecuteCommandParams
Date: Wed, 19 Jun 2024 23:26:20 +0100

On Wed, Jun 19, 2024 at 10:19 PM Jeremy Bryant <jb <at> jeremybryant.net> wrote:
>
> > It appears that an ExecuteCommandParams interface should be added to
> > eglot--lsp-interface-alist and that a matcher for ExecuteCommandParams
> > should be added to the eglot--dcase in eglot-execute.
>
> Adding João as author of eglot

Thanks.

Troy, you seem to be on to something.  It would seem Command shouldn't
be there in the dcase matcher in eglot-execute at all.  Instead
ExecuteCommandParams should be there.  If so, patches welcome, as you
seem to have grasped how this code is supposed to work.

> Additionally,
> > the Command matcher should be changed to not send the "title"
> > parameter in the subsequent workspace/executeCommand request.

Looks like it shouldn't even be there right?

I may just have been thrown off  by the confusing naming (naively
thinking that executeCommand executes Commands, but it doesnt).

The reason no one has complained is probably that there aren't
many users invoking custom commands, and if there are, they could
be just using `jsonrpc-request` directly or using the deprecated
interface.

João

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.