From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 18 23:24:26 2024 Received: (at submit) by debbugs.gnu.org; 19 Jun 2024 03:24:26 +0000 Received: from localhost ([127.0.0.1]:59603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJlvt-00046u-Px for submit@debbugs.gnu.org; Tue, 18 Jun 2024 23:24:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:52508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJlvs-00046m-3P for submit@debbugs.gnu.org; Tue, 18 Jun 2024 23:24:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJlvo-0004eh-Ps for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2024 23:24:20 -0400 Received: from mail-ej1-f48.google.com ([209.85.218.48]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJlvn-0003M9-1Z for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2024 23:24:20 -0400 Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a6f958a3a45so176337266b.3 for ; Tue, 18 Jun 2024 20:24:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718767457; x=1719372257; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=HHp0wCKUufg2DFfEyYQfujF6rMmFAQGm9DJElx4t0Tw=; b=l65OcBIvIQi3L/+sHtAjmmVUBk/Q1ArE9VCsAKDnKTbAS0J3rvhlaz3HStj0XDUjJv fBPG3mgQwtqkEB21rUJPR/VtfsrvzzitcY6Mj6vhpYCusE2yEmTbN3iAqyKpf7MKK/tm E2/BQtJVdpgfVAsa9K1HxJDq5ZdYl3Wd38r3vGFdr8EuhCzmwlyNB9bEZril1zi6/zW6 J9bSCEOj1+DL+d1ZczHbdtf3CEDNwFQyV280P9eh5HTPINkBTNeyKFVdBGCIa3Xl+qNa QdbTYWX3X/A0SUi96n74URiC5Vra/QeJt5E0hBADOK40+ywuYYUlavZ8gT+6Ik0okD/U Lzsg== X-Gm-Message-State: AOJu0Yy06Rn/A0TNblfOqN+FMa40rM2xFjsKXBusYWzqYDSqCCzI4uYn mL1SzVTljmgEd8k1JfMKntrKcvt1XHVBKTKWOVBY2/jh+6sPhsIWjWJ6mtp4 X-Google-Smtp-Source: AGHT+IEZt8p5r9KhBjjfQi642usfOUg8vLof8LZRQuB7oDQgTs+Bk+ew9sV529l3M8bPpZUCtheHGw== X-Received: by 2002:a17:906:d8a:b0:a6f:4c90:7951 with SMTP id a640c23a62f3a-a6fab60bcc3mr51527366b.8.1718767456692; Tue, 18 Jun 2024 20:24:16 -0700 (PDT) Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com. [209.85.208.51]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f56db5c3dsm646027966b.55.2024.06.18.20.24.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jun 2024 20:24:16 -0700 (PDT) Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-57cfe600cbeso1616937a12.2 for ; Tue, 18 Jun 2024 20:24:16 -0700 (PDT) X-Received: by 2002:a50:c192:0:b0:57c:9c5d:d195 with SMTP id 4fb4d7f45d1cf-57d07ed94d3mr537026a12.27.1718767455957; Tue, 18 Jun 2024 20:24:15 -0700 (PDT) MIME-Version: 1.0 From: Troy Brown Date: Tue, 18 Jun 2024 23:24:04 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: 30.0.50; eglot-execute doesn't support ExecuteCommandParams To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=209.85.218.48; envelope-from=troy.s.brown@gmail.com; helo=mail-ej1-f48.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) With the deprecation of eglot-execute-command and its referral to eglot-execute, it would seem that eglot-execute should support the same command and arguments to send the workspace/executeCommand request to the server. Unfortunately, this doesn't seem to work as expected. I would have expected the following to work: (eglot-execute (eglot-current-server) '(:command "my-command")) The reason this doesn't work is because within eglot-execute, the use of eglot--dcase is configured to only match Command or CodeAction. Command requires that there be a "title" parameter, but this doesn't exist in the workspace/executeCommand request. In fact, if the above "eglot-execute" example is changed to add a ":title" parameter, it will erroneously send a workspace/executeCommand with a title parameter. The following example can be used to illustrate that the Command interface (which is intended for code actions, not for sending an executeCommand) doesn't match for this simple case: (condition-case err (eglot--dcase '(:command "my-command") (((Command)) (message "Matched command"))) (error (message "%s" (cdr err)))) It appears that an ExecuteCommandParams interface should be added to eglot--lsp-interface-alist and that a matcher for ExecuteCommandParams should be added to the eglot--dcase in eglot-execute. Additionally, the Command matcher should be changed to not send the "title" parameter in the subsequent workspace/executeCommand request. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 19 17:20:05 2024 Received: (at 71642) by debbugs.gnu.org; 19 Jun 2024 21:20:05 +0000 Received: from localhost ([127.0.0.1]:59657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK2iq-000071-Tn for submit@debbugs.gnu.org; Wed, 19 Jun 2024 17:20:05 -0400 Received: from out-175.mta1.migadu.com ([95.215.58.175]:59820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK2io-00006D-6i for 71642@debbugs.gnu.org; Wed, 19 Jun 2024 17:20:02 -0400 X-Envelope-To: joaotavora@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1718831959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cC1gfpSt5zqux1ekAjrXFwd+KC2yFE2Qa6HcEx5lqPQ=; b=kjL9h5rMzXVzmKIlgGyiV+oEXUYc6AhLs+iUIZn5AITiNdLleMxrUWZNcMkYqjtIpeTuus DWci2p00Q/p52My7FZljYGLQKbnnsm94tWWCO575fCtiA28X8pWrDiIiSQ1OsfjlEaid2G fUdRxYBjc2kaZzSPF9a2Ly4vIDos32+IWap+QtaU9OQ6ibkOONm1FXQZUA/NTioNTa6pfo PomcHDfAmqefN8qhwA9eQ5qd/g1R7dLWlVnYnLrLMCctzc5cKsft0XzNORJTs2bjvFP+Xb iW1W0nyXI50RN40m/XwM9L622XWLrRfFnI4pyDaCzwCo8eRi3nNY/DHtypib6g== X-Envelope-To: 71642@debbugs.gnu.org X-Envelope-To: brownts@troybrown.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Jeremy Bryant To: Troy Brown Subject: Re: bug#71642: 30.0.50; eglot-execute doesn't support ExecuteCommandParams In-Reply-To: (Troy Brown's message of "Tue, 18 Jun 2024 23:24:04 -0400") References: Date: Wed, 19 Jun 2024 22:19:17 +0100 Message-ID: <87v8243a22.fsf@jeremybryant.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71642 Cc: 71642@debbugs.gnu.org, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Troy Brown writes: > With the deprecation of eglot-execute-command and its referral to > eglot-execute, it would seem that eglot-execute should support the > same command and arguments to send the workspace/executeCommand > request to the server. Unfortunately, this doesn't seem to work as > expected. I would have expected the following to work: > > (eglot-execute (eglot-current-server) '(:command "my-command")) > > The reason this doesn't work is because within eglot-execute, the use > of eglot--dcase is configured to only match Command or CodeAction. > Command requires that there be a "title" parameter, but this doesn't > exist in the workspace/executeCommand request. In fact, if the above > "eglot-execute" example is changed to add a ":title" parameter, it > will erroneously send a workspace/executeCommand with a title > parameter. > > The following example can be used to illustrate that the Command > interface (which is intended for code actions, not for sending an > executeCommand) doesn't match for this simple case: > > (condition-case err > (eglot--dcase '(:command "my-command") > (((Command)) (message "Matched command"))) > (error > (message "%s" (cdr err)))) > > It appears that an ExecuteCommandParams interface should be added to > eglot--lsp-interface-alist and that a matcher for ExecuteCommandParams > should be added to the eglot--dcase in eglot-execute. Additionally, > the Command matcher should be changed to not send the "title" > parameter in the subsequent workspace/executeCommand request. Adding Jo=C3=A3o as author of eglot From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 19 18:27:45 2024 Received: (at 71642) by debbugs.gnu.org; 19 Jun 2024 22:27:45 +0000 Received: from localhost ([127.0.0.1]:33432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK3mK-00054j-Qv for submit@debbugs.gnu.org; Wed, 19 Jun 2024 18:27:45 -0400 Received: from mail-lf1-f41.google.com ([209.85.167.41]:46405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK3mH-00054U-Qg for 71642@debbugs.gnu.org; Wed, 19 Jun 2024 18:27:42 -0400 Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-52c8c0d73d3so264658e87.1 for <71642@debbugs.gnu.org>; Wed, 19 Jun 2024 15:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718835992; x=1719440792; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=o2wYXVXYwoMTGUwNZ4xRZMQCvrBzCIhs5aEhfC61Muk=; b=YAtiKFdnRSW9+aA+1XeKMbvFmWXECa71DfEoOmGfNYuHYf4zCyY6/myPDm5qZNaTBE qz14Bz5Hk8IAg7Ju6gTcwdr4kELWJ7rpMY+/cd/ssCPQlwpQjyXpSiDoi8Dkn0PKNw5f 3mzWeeTPBJ4fU6xiFwAV62nMq5B4xQRLmYbfWPNPA0izx2ExHPQ9HPAex5bsJlGcvJM7 28zn7M63ccNwZbop7lHQ4H5YZcntpFNdkdtJJm5Fmp0DvQBiYEwYXpzMDR8WpB0TqxhJ yMahmN19CiQKSUylzNyfcOAWuh6GeFbOkt0/eMxrjbbyK2L1dgu9aazrsKIuyaiHnejp mEYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718835992; x=1719440792; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o2wYXVXYwoMTGUwNZ4xRZMQCvrBzCIhs5aEhfC61Muk=; b=t0ZRVXr4ZnLUBd2w9zgXV/IkRCCh7xAEM4U98mq1V3Tdf4FkoJ1NJINQlbAPbt6seE ZumMVNQrjDhcWOk99+iczKtGBKrmGDe5so5A0fUx2rpqOPH04fAGEuZ4f33Dx/PHv6lH Gk6uGGJODK2ZynECjclGE3/pjNlF7AYCatsmOJMzeuw836NXmyCnop8L0Bs16TfAWPQ1 wq6t1+H9Rj+wRBPqfiGpx+BmYGfSY9jfDmtB/FKRfO6kcK5NpOatMR4L5XEtywWzcIfz hzTAoGMfhXIYB2xoKpNxktSL+5QixygPU5CRa4PRnCEjGbCEmVCAfCYHhe9d1euiXAhj pDaQ== X-Forwarded-Encrypted: i=1; AJvYcCW6sa0bB6MBS+FSQ1LfiXkQYy3ARwbe15lxO3MD/lpolJ3pCAC8E8cHSLHrltJ1oZwv4sQzs8F3n5I0yxftNaEYR9yjv0E= X-Gm-Message-State: AOJu0YyObaS0LJt9jQ1uWpyqGFhnJev8TdfQkNxhI18DcuC0Ym5GFpsZ oFDzPR0Yf0tty7o3buHwwQdMB1HYPYcBitUFElyIQzlzTgM6EjPvAnM+xisDClnZVAdEkDnUcEB 6TLg2oV2eCefz3y7OvtGGk/nwJ9s= X-Google-Smtp-Source: AGHT+IGaNHoIRd8znpJRpWFaCLe/02dRrbOfU9opLRR8kVbPZNaO/BxTI/0pPuZaeK2Aabxd3PUUdVGtezsSjpFP1Lk= X-Received: by 2002:a05:6512:3d9e:b0:52c:89b5:27bc with SMTP id 2adb3069b0e04-52ccaa974b5mr2780640e87.42.1718835991952; Wed, 19 Jun 2024 15:26:31 -0700 (PDT) MIME-Version: 1.0 References: <87v8243a22.fsf@jeremybryant.net> In-Reply-To: <87v8243a22.fsf@jeremybryant.net> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 19 Jun 2024 23:26:20 +0100 Message-ID: Subject: Re: bug#71642: 30.0.50; eglot-execute doesn't support ExecuteCommandParams To: Jeremy Bryant Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71642 Cc: 71642@debbugs.gnu.org, Troy Brown X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, Jun 19, 2024 at 10:19=E2=80=AFPM Jeremy Bryant wrote: > > > It appears that an ExecuteCommandParams interface should be added to > > eglot--lsp-interface-alist and that a matcher for ExecuteCommandParams > > should be added to the eglot--dcase in eglot-execute. > > Adding Jo=C3=A3o as author of eglot Thanks. Troy, you seem to be on to something. It would seem Command shouldn't be there in the dcase matcher in eglot-execute at all. Instead ExecuteCommandParams should be there. If so, patches welcome, as you seem to have grasped how this code is supposed to work. > Additionally, > > the Command matcher should be changed to not send the "title" > > parameter in the subsequent workspace/executeCommand request. Looks like it shouldn't even be there right? I may just have been thrown off by the confusing naming (naively thinking that executeCommand executes Commands, but it doesnt). The reason no one has complained is probably that there aren't many users invoking custom commands, and if there are, they could be just using `jsonrpc-request` directly or using the deprecated interface. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 19 23:55:36 2024 Received: (at 71642) by debbugs.gnu.org; 20 Jun 2024 03:55:36 +0000 Received: from localhost ([127.0.0.1]:41892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK8tb-0006v8-Vv for submit@debbugs.gnu.org; Wed, 19 Jun 2024 23:55:36 -0400 Received: from mail-lf1-f41.google.com ([209.85.167.41]:46268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK8tZ-0006us-H8 for 71642@debbugs.gnu.org; Wed, 19 Jun 2024 23:55:34 -0400 Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-52c85a7f834so536793e87.0 for <71642@debbugs.gnu.org>; Wed, 19 Jun 2024 20:55:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718855723; x=1719460523; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RQYxEu90ffiR+Uc9IBwP8ZDLOFsdpYcWErpx0Dj52lU=; b=PQ3qU4bNY46MJUjivtRWfQ5Udmvrb30MJ4k8XAFB73iCKrNnTZ86wWgoNvmyNiA56N AGbsI7eEhFxlnx+HIAW8XodGoplGBBJ7flBQqm+6YSsrhz6pmu2z1XbwSMS84sEEKros +eL7aosTrmENBxJG1BHt15zQuwRR2FBj7FUu2LuaPr2rfSesBG/AymN39gktsqO1JyMD s3mBs2+IoJV4rIJEoeoelQ3OShdSZ0V5jJY11fpEw7V8midNLEbQOikVC42pWyjpjmfT PwLqVI0DjjeiR3yhRKce8tOud7MKr8pU+Eut3QbQQQ7QGA2HIwVTVaKaBc3wEZB4NXEE zirQ== X-Forwarded-Encrypted: i=1; AJvYcCXh9v7hwgd/vdADvhFS+RHmG/spGbtnSoJpoBB9QbkETgTHikrcOP7lxL/6mhLrARlkLEG2mFP9jUyc74yswVJGYgToX4g= X-Gm-Message-State: AOJu0YwZ7Zcdh6JXTeZINOTP5F+uacsRXBAOG/p17gLh6Bk6krcXNEH2 /q+RlVk3EdDyuVV3gTWMv3syWHJr3+xJH4bcGsaDKtzGGNGT/StHIyGeL5HB X-Google-Smtp-Source: AGHT+IH1W4o3/BrHfgv0mKGTXtP0vhtdoGYhiXKBu+9HjBjlutyMeD17xqTnvAVMi6JLeto7xl/iPA== X-Received: by 2002:a05:6512:4de:b0:52c:a5e6:989e with SMTP id 2adb3069b0e04-52ccaa5b9a7mr2432736e87.16.1718855723100; Wed, 19 Jun 2024 20:55:23 -0700 (PDT) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52ca28870f5sm1915666e87.249.2024.06.19.20.55.22 for <71642@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jun 2024 20:55:22 -0700 (PDT) Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-52cccd44570so514488e87.2 for <71642@debbugs.gnu.org>; Wed, 19 Jun 2024 20:55:22 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUREV91z+2WLRIuJiNl7+Ii6PNXK3iSSwA3064+Jbua50tSKGn4TFPCafwaCTTK+DNIC9zWx2nKegsnqs49LbxoRSq0hZs= X-Received: by 2002:a05:6512:2f4:b0:52c:8f01:c8a1 with SMTP id 2adb3069b0e04-52ccaaa85famr1890965e87.56.1718855722061; Wed, 19 Jun 2024 20:55:22 -0700 (PDT) MIME-Version: 1.0 References: <87v8243a22.fsf@jeremybryant.net> In-Reply-To: From: Troy Brown Date: Wed, 19 Jun 2024 23:55:10 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#71642: 30.0.50; eglot-execute doesn't support ExecuteCommandParams To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Content-Type: multipart/mixed; boundary="000000000000bc7ea2061b4a48ed" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 71642 Cc: Jeremy Bryant , 71642@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000bc7ea2061b4a48ed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jun 19, 2024 at 6:26=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > Troy, you seem to be on to something. It would seem Command shouldn't > be there in the dcase matcher in eglot-execute at all. Instead > ExecuteCommandParams should be there. > I suspected that might be the case (that Command was really supposed to be ExecuteCommandParams), but I hadn't exhaustively looked at everything, however you have now confirmed that suspicion. > > I may just have been thrown off by the confusing naming (naively > thinking that executeCommand executes Commands, but it doesnt). > Yes, that makes sense, I was confused for a bit as well until I had investigated why it had the "title" parameter, looked at the LSP specification and realized that it was meant for something else. > The reason no one has complained is probably that there aren't > many users invoking custom commands, and if there are, they could > be just using `jsonrpc-request` directly or using the deprecated > interface. Yes, that makes sense, I'd imagine people who are using custom commands are using the older eglot-execute-command interface since it's still functional. I had looked at it and saw that it was now deprecated so I attempted to use the new interface. > If so, patches welcome, as you > seem to have grasped how this code is supposed to work. > I've attached a patch which I believe addresses the issue. I did have to reorder the interfaces to put CodeAction before ExecuteCommandParams as both contain "command" parameters. Since eglot-strict-mode doesn't normally contain disallow-non-standard-keys, it causes eglot--dcase to match ExecuteCommandParams for a CodeAction interface if the optional "command" parameter is present. Reordering the interfaces allows them to match correctly since CodeAction contains a required "title" parameter which is not present in the ExecuteCommandParams interface. --000000000000bc7ea2061b4a48ed Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Eglot-Fix-command-execution-bug-71642.patch" Content-Disposition: attachment; filename="0001-Eglot-Fix-command-execution-bug-71642.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lxmq5uf50 RnJvbSBmN2MyMGFmYzQ2NDlhZWVkYTBiMzYxMThmNTBiNTkzNjVkMWM5NmU0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUcm95IEJyb3duIDxicm93bnRzQHRyb3licm93bi5kZXY+CkRh dGU6IFdlZCwgMTkgSnVuIDIwMjQgMjA6MTQ6MDcgLTA0MDAKU3ViamVjdDogW1BBVENIXSBFZ2xv dDogRml4IGNvbW1hbmQgZXhlY3V0aW9uIChidWcjNzE2NDIpCgoqIGxpc3AvcHJvZ21vZGVzL2Vn bG90LmVsIChlZ2xvdC0tbHNwLWludGVyZmFjZS1hbGlzdCk6IEFkZApFeGVjdXRlQ29tbWFuZFBh cmFtcyBpbnRlcmZhY2UuCihlZ2xvdC0tZXhlY3V0ZSk6IENoYW5nZSBDb21tYW5kIGludGVyZmFj ZSB0byBFeGVjdXRlQ29tbWFuZFBhcmFtcwppbnRlcmZhY2UuCgpDb3B5cmlnaHQtcGFwZXJ3b3Jr LWV4ZW1wdDogeWVzCi0tLQogbGlzcC9wcm9nbW9kZXMvZWdsb3QuZWwgfCA4ICsrKysrLS0tCiAx IGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVsIGIvbGlzcC9wcm9nbW9kZXMvZWdsb3QuZWwKaW5k ZXggMDNkYTVjN2IyMmEuLmNmOTFlYWU1Njk0IDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9l Z2xvdC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbApAQCAtNjI0LDYgKzYyNCw3IEBA IGVnbG90LS11cmktcGF0aC1hbGxvd2VkLWNoYXJzCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDpjb21tYW5kIDpkYXRhIDp0YWdzKSkKICAgICAgIChEaWFnbm9zdGljICg6cmFuZ2UgOm1l c3NhZ2UpICg6c2V2ZXJpdHkgOmNvZGUgOnNvdXJjZSA6cmVsYXRlZEluZm9ybWF0aW9uIDpjb2Rl RGVzY3JpcHRpb24gOnRhZ3MpKQogICAgICAgKERvY3VtZW50SGlnaGxpZ2h0ICg6cmFuZ2UpICg6 a2luZCkpCisgICAgICAoRXhlY3V0ZUNvbW1hbmRQYXJhbXMgKCg6Y29tbWFuZCAuIHN0cmluZykp ICg6YXJndW1lbnRzKSkKICAgICAgIChGaWxlU3lzdGVtV2F0Y2hlciAoOmdsb2JQYXR0ZXJuKSAo OmtpbmQpKQogICAgICAgKEhvdmVyICg6Y29udGVudHMpICg6cmFuZ2UpKQogICAgICAgKEluaXRp YWxpemVSZXN1bHQgKDpjYXBhYmlsaXRpZXMpICg6c2VydmVySW5mbykpCkBAIC04ODQsMTcgKzg4 NSwxOCBAQCBlZ2xvdC1leGVjdXRlLWNvbW1hbmQKIAogKGNsLWRlZmdlbmVyaWMgZWdsb3QtZXhl Y3V0ZSAoc2VydmVyIGFjdGlvbikKICAgIkFzayBTRVJWRVIgdG8gZXhlY3V0ZSBBQ1RJT04uCi1B Q1RJT04gaXMgYW4gTFNQIG9iamVjdCBvZiBlaXRoZXIgYENvZGVBY3Rpb24nIG9yIGBDb21tYW5k JyB0eXBlLiIKK0FDVElPTiBpcyBhbiBMU1Agb2JqZWN0IG9mIGVpdGhlciBgQ29kZUFjdGlvbicg b3IgYEV4ZWN1dGVDb21tYW5kUGFyYW1zJyB0eXBlLiIKICAgKDptZXRob2QKICAgIChzZXJ2ZXIg YWN0aW9uKSAiRGVmYXVsdCBpbXBsZW1lbnRhdGlvbi4iCiAgICAoZWdsb3QtLWRjYXNlIGFjdGlv bgotICAgICAoKChDb21tYW5kKSkgKGVnbG90LS1yZXF1ZXN0IHNlcnZlciA6d29ya3NwYWNlL2V4 ZWN1dGVDb21tYW5kIGFjdGlvbikpCiAgICAgICgoKENvZGVBY3Rpb24pIGVkaXQgY29tbWFuZCBk YXRhKQogICAgICAgKGlmIChhbmQgKG51bGwgZWRpdCkgKG51bGwgY29tbWFuZCkgZGF0YQogICAg ICAgICAgICAgICAgKGVnbG90LXNlcnZlci1jYXBhYmxlIDpjb2RlQWN0aW9uUHJvdmlkZXIgOnJl c29sdmVQcm92aWRlcikpCiAgICAgICAgICAgKGVnbG90LWV4ZWN1dGUgc2VydmVyIChlZ2xvdC0t cmVxdWVzdCBzZXJ2ZXIgOmNvZGVBY3Rpb24vcmVzb2x2ZSBhY3Rpb24pKQogICAgICAgICAod2hl biBlZGl0IChlZ2xvdC0tYXBwbHktd29ya3NwYWNlLWVkaXQgZWRpdCB0aGlzLWNvbW1hbmQpKQot ICAgICAgICAod2hlbiBjb21tYW5kIChlZ2xvdC0tcmVxdWVzdCBzZXJ2ZXIgOndvcmtzcGFjZS9l eGVjdXRlQ29tbWFuZCBjb21tYW5kKSkpKSkpKQorICAgICAgICAod2hlbiBjb21tYW5kIChlZ2xv dC0tcmVxdWVzdCBzZXJ2ZXIgOndvcmtzcGFjZS9leGVjdXRlQ29tbWFuZCBjb21tYW5kKSkpKQor ICAgICAoKChFeGVjdXRlQ29tbWFuZFBhcmFtcykpCisgICAgICAoZWdsb3QtLXJlcXVlc3Qgc2Vy dmVyIDp3b3Jrc3BhY2UvZXhlY3V0ZUNvbW1hbmQgYWN0aW9uKSkpKSkKIAogKGNsLWRlZmdlbmVy aWMgZWdsb3QtaW5pdGlhbGl6YXRpb24tb3B0aW9ucyAoc2VydmVyKQogICAiSlNPTiBvYmplY3Qg dG8gc2VuZCB1bmRlciBgaW5pdGlhbGl6YXRpb25PcHRpb25zJy4iCi0tIAoyLjM3LjEKCg== --000000000000bc7ea2061b4a48ed-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 20 05:48:03 2024 Received: (at 71642) by debbugs.gnu.org; 20 Jun 2024 09:48:03 +0000 Received: from localhost ([127.0.0.1]:50648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKEOg-0004El-RB for submit@debbugs.gnu.org; Thu, 20 Jun 2024 05:48:03 -0400 Received: from mail-lj1-f180.google.com ([209.85.208.180]:45431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKEOe-0004EF-79 for 71642@debbugs.gnu.org; Thu, 20 Jun 2024 05:48:00 -0400 Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2eaa89464a3so7813561fa.3 for <71642@debbugs.gnu.org>; Thu, 20 Jun 2024 02:47:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718876810; x=1719481610; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YiJCCWWgJTuQTQXUMUy14L08Yl8mqpOSNIy0r+E5r68=; b=YjvHax6KWmkMRlef4IJsHUwv17urN9AFkuFGJ7+m9PwT5PcmPscraR3fs2a+vUmw22 eaB0NYWOKLFynU0EptzJtilvqXcX/HzXVfn1X3ys6fdff5r/GTPtIAnzxI6xeoxrX09l iSlSVZwdDqQ2j6dC5K6NaUcIGKBfiGbFc78w7qHETsNdIwZt4uUflL4QsEwmkI6JRHu1 OC3pUlGQsh4/AW+TgCPpoHstfAiFSmHTJ4V9rf1mpPKLoWDlf89ZYKWKKv8lR5NrMEiM XiFkXLli3ziHrhy2kF6FCFNwcwRrWwWxfRIu0023/ItgdfqQozZNwFXl/eK4XNeucrf3 9ckA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718876810; x=1719481610; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YiJCCWWgJTuQTQXUMUy14L08Yl8mqpOSNIy0r+E5r68=; b=O/iiXK8lsDqoqyu3+dovsLs24na4IYTlT3BiRz5k6SHHEjwJOqjPsk9BsYZ7xxGD1Q +suj8IZH7EOCfLN0V9kKTtqSUD0nlLRX+/71NYVcuDQbNOD/InNDReg/ncwShWOddkrH rA18oAv5nAym6cY8vZjSwHpRPluyMUYOpdOJwvjOc3ANI267o+hTT42ia1ic24pxOx66 Zu3f3uxIT1FSiaetPqfk1cLwxAisc0l+k8zHwa/w5k0J7cfSByRj/14a0OosFoH9lNTM wxW0JTCii4976cktamFEGi4g1haGkT/9xgxEaDMelGTnHgwUsgxsssk0fUku14Vgeag+ nkWA== X-Forwarded-Encrypted: i=1; AJvYcCVzPBIm1dxANCeqhhpCdxmji/CuNNLPYmp8N7/ajxOP7kJ7C73r1dot2waOtt/d7SdjJhNLou3V5qCLcs8sb/q9ryh7Ssw= X-Gm-Message-State: AOJu0YzHiK6e1xVIF4e5mods4HWC1PxQwTjja4UdTzkIL0a7YiuGDyD7 3T0dhlJ9046lX5uq8l2c24LV3mjeYnwK7rIPJNGQQX/qH8juKiAZG7BUh5kAnNaCpdulsnUZ8M1 75OqS21D6KIot9pFIu7mz69Q5WcQ= X-Google-Smtp-Source: AGHT+IHYAGIgBVDW+muSroJo7cpOKsvQA0CbUD7cDaL7nERv37nOyuoWPwcFShAVDS+itivKIi41YVmJM+LOSktlyRo= X-Received: by 2002:a2e:b604:0:b0:2eb:efd4:7f7d with SMTP id 38308e7fff4ca-2ec3cea1b02mr34070671fa.30.1718876810193; Thu, 20 Jun 2024 02:46:50 -0700 (PDT) MIME-Version: 1.0 References: <87v8243a22.fsf@jeremybryant.net> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Thu, 20 Jun 2024 10:46:38 +0100 Message-ID: Subject: Re: bug#71642: 30.0.50; eglot-execute doesn't support ExecuteCommandParams To: Troy Brown Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71642 Cc: Jeremy Bryant , 71642@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Jun 20, 2024 at 4:55=E2=80=AFAM Troy Brown = wrote: > > On Wed, Jun 19, 2024 at 6:26=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > > > Troy, you seem to be on to something. It would seem Command shouldn't > > be there in the dcase matcher in eglot-execute at all. Instead > > ExecuteCommandParams should be there. > I suspected that might be the case (that Command was really supposed > to be ExecuteCommandParams), but I hadn't exhaustively looked at > everything, however you have now confirmed that suspicion. No, no, after closer analysis, this is not right. Command must absolutely be there in the matcher, as textDocument/codeAction can simply return an array of them. > > I may just have been thrown off by the confusing naming (naively > > thinking that executeCommand executes Commands, but it doesnt). > Yes, that makes sense, I was confused for a bit as well until I had > investigated why it had the "title" parameter, looked at the LSP > specification and realized that it was meant for something else. On closer analysis the only confusing thing is that the spec encourages clients to call textDocument/executeCommand with illegal ExecuteCommandParams objects that contain an extraneous 'title' Most servers apparently don't care, but Eglot is doing this and it's a subtle bug. I think the right thing to do is to have Command _and_ ExecuteCommandParams in the matcher. After that: * custom callers of `textDocument/executeCommand` can do their thing (they could already but now it's arguably easiest) * Eglot won't suffer from this subtle bug * Hopefully the situation is clearer While none of this is super-serious, I think we can fix it and we'll benefit in clarity. > Since > eglot-strict-mode doesn't normally contain disallow-non-standard-keys, > it causes eglot--dcase to match ExecuteCommandParams for a CodeAction > interface if the optional "command" parameter is present. But if it is present, it shouldn't be a string, so it should still work in the order. I've done a tweak to your patch. See after my sig. It's untested, so please have a look. If you can, test, add more comments, change the order if indeed it's needed. You can also change the implementation if you think the recursiveness makes it more confusing. When that is done, please resubmit the patch with the nicely formatted commit message (just like you did before) and I'll ask someone to install it (or install it myself). Jo=C3=A3o diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 6896baf30ce..450f5a507f6 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -631,6 +631,7 @@ eglot--uri-path-allowed-chars :command :data :tags)) (Diagnostic (:range :message) (:severity :code :source :relatedInformation :codeDescription :tags)) (DocumentHighlight (:range) (:kind)) + (ExecuteCommandParams ((:command . string)) (:arguments)) (FileSystemWatcher (:globPattern) (:kind)) (Hover (:contents) (:range)) (InitializeResult (:capabilities) (:serverInfo)) @@ -891,17 +892,25 @@ eglot-execute-command (cl-defgeneric eglot-execute (server action) "Ask SERVER to execute ACTION. -ACTION is an LSP object of either `CodeAction' or `Command' type." +ACTION is an LSP `CodeAction', `Command' or `ExecuteCommandParams' +object." (:method (server action) "Default implementation." (eglot--dcase action - (((Command)) (eglot--request server :workspace/executeCommand action)= ) + (((Command)) + ;; Convert to ExecuteCommandParams and recurse (bug#71642) + (cl-remf action :title) + (eglot-execute action)) + (((ExecuteCommandParams)) + (eglot--request server :workspace/executeCommand action)) (((CodeAction) edit command data) (if (and (null edit) (null command) data (eglot-server-capable :codeActionProvider :resolveProvider)= ) (eglot-execute server (eglot--request server :codeAction/resolve action)) (when edit (eglot--apply-workspace-edit edit this-command)) - (when command (eglot--request server :workspace/executeCommand command))))))) + (when command + ;; Recursive call with what must be a Command object (bug#71642) + (eglot-execute command))))))) (cl-defgeneric eglot-initialization-options (server) "JSON object to send under `initializationOptions'." From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 21 12:34:18 2024 Received: (at 71642) by debbugs.gnu.org; 21 Jun 2024 16:34:18 +0000 Received: from localhost ([127.0.0.1]:43182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKhDO-0000sD-3R for submit@debbugs.gnu.org; Fri, 21 Jun 2024 12:34:18 -0400 Received: from mail-lf1-f50.google.com ([209.85.167.50]:50669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKhDM-0000s0-AQ for 71642@debbugs.gnu.org; Fri, 21 Jun 2024 12:34:17 -0400 Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52cdbc20faeso569502e87.1 for <71642@debbugs.gnu.org>; Fri, 21 Jun 2024 09:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718987591; x=1719592391; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aEybApRA+v9L42KcwoecF9VkQGmviKgiVVwdHSyka9s=; b=ZjTpNH/0IN32qClb21zsZTwRUzSPTIWJBskcd69pJH6c+WA2qOXaXbozHCn7vxaqax ovK/7C6nuC93ImGHxNGFtJv7aEdIGRygafE2aP+L0O3SK2hkJFNQYSQF0s05pDVGhDzp OhANYykhmqWA9CS5chq1sZbHIbV4TPwnFXcEbnMQ8H3T0clkZzQdllUCD5OBj/kgs6jZ 3ZnScfe7jl/niaE198n/pQBZz6dSpjOgva4p1TuAmAXPBIuO/zd30JJ5xj/AqJgj5Lsp dAnXfDd8WC/JLkaqPlRJ++PEfCh+TvVSYPl5KpTQUSr4h93WBo1fnHUkJ7AxQfrxb8QH MEHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718987591; x=1719592391; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aEybApRA+v9L42KcwoecF9VkQGmviKgiVVwdHSyka9s=; b=pvFP7dwY7n+oMYS4UhJ8v9o19e09UuR+HXKGwCEUPRgYZjMePt7OlkL7ixmH3QVUTb PKnTUmx3V5VUgR5qK6rC5F8CVKUB4qvg/g2oXm/3TetYi2R/ivFXVN2H4FM6xtcFQ3O8 fxd/o6O0i3gjxDPp91V7rZ6LNFWF3ex5F8eTP9q9H9jNh5Cklw+4+WK3KSSDhkIsBTSe lqoS+RomKLfylgB9tR08hzblhCEVHtY7omo5OK6t7twSW33HSfHhIXOSTG1hyzY3kX0O hn/z/f9iq5HpHcd7yKcTVChXgx+7GRyoSjt8QkNiZU2R9TIFTJB0eN28jkHBTGQ2gyHd mBwA== X-Forwarded-Encrypted: i=1; AJvYcCWJgdv/hKP1j0esoe8HEVHKu+PMwiTcD5X+4PfsH9lJRgieC6z/675NksLeBBBd4TfMx+IUIQN1oaoKqRjvjCFV8Ui8JxU= X-Gm-Message-State: AOJu0Yyzq0Q1CcMbBlvwnhSk+l4GK1hChgxazN3sMZeVG1pWUMhn6Od9 abfe7Dh05QhgOMJJjss0X7y02MVogmYjZO4V67dW9OAo+TtlFxEmRgIw2uIpI9mkq6bfNyv8oZW DT/4PPkxdunZ1Sf7+Bygk/WyqgdWH6EQC X-Google-Smtp-Source: AGHT+IF3pZEMjXJ/G/s2p+sjTrMgpG3OaXCtOSBdYk+pzs//xrZdesiGA6advMBXj9dt1eHKn/XNY7PZPAnUbCl13+E= X-Received: by 2002:a05:6512:4019:b0:52c:2b7a:ad51 with SMTP id 2adb3069b0e04-52ccaa37681mr5695290e87.37.1718977897882; Fri, 21 Jun 2024 06:51:37 -0700 (PDT) MIME-Version: 1.0 References: <87v8243a22.fsf@jeremybryant.net> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Fri, 21 Jun 2024 14:51:26 +0100 Message-ID: Subject: Re: bug#71642: 30.0.50; eglot-execute doesn't support ExecuteCommandParams To: Troy Brown Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71642 Cc: Jeremy Bryant , 71642@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Jun 21, 2024 at 1:14=E2=80=AFPM Troy Brown = wrote: > I've updated the patch based on your suggestions. Looks good, thanks! The only doubt I have is the Copyright Assignment. This is still a "trivial" patch (< 15 LOC), I think but I'll need to ask Eli for his opinion to be sure. Eli, if you're OK with the copyright aspects, please install this and close the bug. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 21 13:44:59 2024 Received: (at 71642) by debbugs.gnu.org; 21 Jun 2024 17:44:59 +0000 Received: from localhost ([127.0.0.1]:43222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKiJn-0002bm-9v for submit@debbugs.gnu.org; Fri, 21 Jun 2024 13:44:59 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:46099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKiJj-0002bS-Ik for 71642@debbugs.gnu.org; Fri, 21 Jun 2024 13:44:57 -0400 Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-363826fbcdeso1695900f8f.0 for <71642@debbugs.gnu.org>; Fri, 21 Jun 2024 10:44:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718991890; x=1719596690; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L5N4gIhG6AwLNdSfRiqxdaAQTcottx2hAZzbuvUkPe8=; b=JmYhdXZNmMl1g4EdLSnXOEw3i+noPdcG+nSzZW/c2WfKWEbcjI/zTXqVoTNs2osOP2 akGfJ47bcO2ePZoPomhrl0v9iwRefY2nQZaN2M74IvC6Y1nBBizL6ONoMWGYqZhbeYyh oSyYXwH1Ntv6dVs2E/kQKOI8ZOhbtoA5RgJQS+tZId6Fe8hPerZaMQXAnXqhgpEE3L8z 6igI7T1oEEg9ToN6gF4+eyrLm15xwnXnC0XjJW+M3Uy62EV9nnj9xgyCz8+udzXeJ0ER V0hpry+IdMM8AOgnlcoP+KhVCeGSNSYLOvcbFGMkWY+xyrN2bVYDtvL8iNnRv1CmYtfR A5dw== X-Forwarded-Encrypted: i=1; AJvYcCUkuogX3lYi/yLUgkrs+eKohjs9cAsQ1OoW51b+g6zeUJInIthJNvqVoj6d5TLXccgshhLsazx+CG24rLaMBA8i8fuOBOc= X-Gm-Message-State: AOJu0YyHI9jyz8naGxaqW1c0eYiR9hJ39A60qp6D+GCOD3tV57P3ngMv wMeSiklxTouHi+scKD5CWLIkYjLDb8zNqOhmnPM1+Fz12V6P52tgbdSFdin3 X-Google-Smtp-Source: AGHT+IHhiDatxPMPtinORCGtT6wqw8T2s8XTuhzuhpLWTwq6syxeITxzYjmAAvdO60QRNEtQsfiyZg== X-Received: by 2002:a50:c2c9:0:b0:57c:749f:f5ef with SMTP id 4fb4d7f45d1cf-57d07ed4f92mr5197873a12.34.1718972054662; Fri, 21 Jun 2024 05:14:14 -0700 (PDT) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com. [209.85.218.52]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57d30534ffasm855389a12.60.2024.06.21.05.14.13 for <71642@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jun 2024 05:14:14 -0700 (PDT) Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a6f7b785a01so211573866b.1 for <71642@debbugs.gnu.org>; Fri, 21 Jun 2024 05:14:13 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUGJ7CTSM+QghgOKEx9p2tm6jtAmVT7xOEUs30uYyWU4D9nUShEKuo9nRgcFtFu+fWyKnUpHFh1pD4jJaobM21EU/hFEUM= X-Received: by 2002:a17:906:7003:b0:a6f:510b:5c88 with SMTP id a640c23a62f3a-a6fab7cd4c2mr415999566b.75.1718972053777; Fri, 21 Jun 2024 05:14:13 -0700 (PDT) MIME-Version: 1.0 References: <87v8243a22.fsf@jeremybryant.net> In-Reply-To: From: Troy Brown Date: Fri, 21 Jun 2024 08:14:02 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#71642: 30.0.50; eglot-execute doesn't support ExecuteCommandParams To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Content-Type: multipart/mixed; boundary="000000000000a51f6b061b655e1e" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 71642 Cc: Jeremy Bryant , 71642@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000a51f6b061b655e1e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jun 20, 2024 at 5:46=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > > On closer analysis the only confusing thing is that the spec > encourages clients to call textDocument/executeCommand with > illegal ExecuteCommandParams objects that contain an extraneous > 'title' > > Most servers apparently don't care, but Eglot is doing this and > it's a subtle bug. > > I think the right thing to do is to have Command _and_ > ExecuteCommandParams in the matcher. > Thanks for the explanation. > I've done a tweak to your patch. See after my sig. It's untested, so > please have a look. If you can, test, add more comments, change the order > if indeed it's needed. You can also change the implementation if you thi= nk > the recursiveness makes it more confusing. > I've updated the patch based on your suggestions. I've tested all invocations of executeCommand through Command, ExecuteCommandParams and CodeAction and they all appear to be working as expected now. I think the recursion is fine, it's simple and elegant. With regards to the order, you are correct, since the command in CodeAction isn't a string, it's not a problem. I was previously erroneously only testing with a string. --000000000000a51f6b061b655e1e Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Eglot-Fix-command-execution-bug-71642.patch" Content-Disposition: attachment; filename="0001-Eglot-Fix-command-execution-bug-71642.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lxonenr70 RnJvbSA5NjNlNWM5NzVmODlkOWM2MTExOTAyNjk0YWM1MWZhY2FmN2ZjMmI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUcm95IEJyb3duIDxicm93bnRzQHRyb3licm93bi5kZXY+CkRh dGU6IFdlZCwgMTkgSnVuIDIwMjQgMjA6MTQ6MDcgLTA0MDAKU3ViamVjdDogW1BBVENIXSBFZ2xv dDogRml4IGNvbW1hbmQgZXhlY3V0aW9uIChidWcjNzE2NDIpCgoqIGxpc3AvcHJvZ21vZGVzL2Vn bG90LmVsIChlZ2xvdC0tbHNwLWludGVyZmFjZS1hbGlzdCk6IEFkZApFeGVjdXRlQ29tbWFuZFBh cmFtcyBpbnRlcmZhY2UuCihlZ2xvdC0tZXhlY3V0ZSk6IEZpeCBoYW5kbGluZyBvZiBDb21tYW5k IGFuZCBDb2RlQWN0aW9uIGFuZCBhZGQKRXhlY3V0ZUNvbW1hbmRQYXJhbXMuCgpDb3B5cmlnaHQt cGFwZXJ3b3JrLWV4ZW1wdDogeWVzCi0tLQogbGlzcC9wcm9nbW9kZXMvZWdsb3QuZWwgfCAxNSAr KysrKysrKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAzIGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVsIGIvbGlzcC9wcm9n bW9kZXMvZWdsb3QuZWwKaW5kZXggMDNkYTVjN2IyMmEuLmRmNGNiZTUwZGMwIDEwMDY0NAotLS0g YS9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbApA QCAtNjI0LDYgKzYyNCw3IEBAIGVnbG90LS11cmktcGF0aC1hbGxvd2VkLWNoYXJzCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIDpjb21tYW5kIDpkYXRhIDp0YWdzKSkKICAgICAgIChEaWFn bm9zdGljICg6cmFuZ2UgOm1lc3NhZ2UpICg6c2V2ZXJpdHkgOmNvZGUgOnNvdXJjZSA6cmVsYXRl ZEluZm9ybWF0aW9uIDpjb2RlRGVzY3JpcHRpb24gOnRhZ3MpKQogICAgICAgKERvY3VtZW50SGln aGxpZ2h0ICg6cmFuZ2UpICg6a2luZCkpCisgICAgICAoRXhlY3V0ZUNvbW1hbmRQYXJhbXMgKCg6 Y29tbWFuZCAuIHN0cmluZykpICg6YXJndW1lbnRzKSkKICAgICAgIChGaWxlU3lzdGVtV2F0Y2hl ciAoOmdsb2JQYXR0ZXJuKSAoOmtpbmQpKQogICAgICAgKEhvdmVyICg6Y29udGVudHMpICg6cmFu Z2UpKQogICAgICAgKEluaXRpYWxpemVSZXN1bHQgKDpjYXBhYmlsaXRpZXMpICg6c2VydmVySW5m bykpCkBAIC04ODQsMTcgKzg4NSwyNSBAQCBlZ2xvdC1leGVjdXRlLWNvbW1hbmQKIAogKGNsLWRl ZmdlbmVyaWMgZWdsb3QtZXhlY3V0ZSAoc2VydmVyIGFjdGlvbikKICAgIkFzayBTRVJWRVIgdG8g ZXhlY3V0ZSBBQ1RJT04uCi1BQ1RJT04gaXMgYW4gTFNQIG9iamVjdCBvZiBlaXRoZXIgYENvZGVB Y3Rpb24nIG9yIGBDb21tYW5kJyB0eXBlLiIKK0FDVElPTiBpcyBhbiBMU1AgYENvZGVBY3Rpb24n LCBgQ29tbWFuZCcgb3IgYEV4ZWN1dGVDb21tYW5kUGFyYW1zJworb2JqZWN0LiIKICAgKDptZXRo b2QKICAgIChzZXJ2ZXIgYWN0aW9uKSAiRGVmYXVsdCBpbXBsZW1lbnRhdGlvbi4iCiAgICAoZWds b3QtLWRjYXNlIGFjdGlvbgotICAgICAoKChDb21tYW5kKSkgKGVnbG90LS1yZXF1ZXN0IHNlcnZl ciA6d29ya3NwYWNlL2V4ZWN1dGVDb21tYW5kIGFjdGlvbikpCisgICAgICgoKENvbW1hbmQpKQor ICAgICAgOzsgQ29udmVydCB0byBFeGVjdXRlQ29tbWFuZFBhcmFtcyBhbmQgcmVjdXJzZSAoYnVn IzcxNjQyKQorICAgICAgKGNsLXJlbWYgYWN0aW9uIDp0aXRsZSkKKyAgICAgIChlZ2xvdC1leGVj dXRlIHNlcnZlciBhY3Rpb24pKQorICAgICAoKChFeGVjdXRlQ29tbWFuZFBhcmFtcykpCisgICAg ICAoZWdsb3QtLXJlcXVlc3Qgc2VydmVyIDp3b3Jrc3BhY2UvZXhlY3V0ZUNvbW1hbmQgYWN0aW9u KSkKICAgICAgKCgoQ29kZUFjdGlvbikgZWRpdCBjb21tYW5kIGRhdGEpCiAgICAgICAoaWYgKGFu ZCAobnVsbCBlZGl0KSAobnVsbCBjb21tYW5kKSBkYXRhCiAgICAgICAgICAgICAgICAoZWdsb3Qt c2VydmVyLWNhcGFibGUgOmNvZGVBY3Rpb25Qcm92aWRlciA6cmVzb2x2ZVByb3ZpZGVyKSkKICAg ICAgICAgICAoZWdsb3QtZXhlY3V0ZSBzZXJ2ZXIgKGVnbG90LS1yZXF1ZXN0IHNlcnZlciA6Y29k ZUFjdGlvbi9yZXNvbHZlIGFjdGlvbikpCiAgICAgICAgICh3aGVuIGVkaXQgKGVnbG90LS1hcHBs eS13b3Jrc3BhY2UtZWRpdCBlZGl0IHRoaXMtY29tbWFuZCkpCi0gICAgICAgICh3aGVuIGNvbW1h bmQgKGVnbG90LS1yZXF1ZXN0IHNlcnZlciA6d29ya3NwYWNlL2V4ZWN1dGVDb21tYW5kIGNvbW1h bmQpKSkpKSkpCisgICAgICAgICh3aGVuIGNvbW1hbmQKKyAgICAgICAgICA7OyBSZWN1cnNpdmUg Y2FsbCB3aXRoIHdoYXQgbXVzdCBiZSBhIENvbW1hbmQgb2JqZWN0IChidWcjNzE2NDIpCisgICAg ICAgICAgKGVnbG90LWV4ZWN1dGUgc2VydmVyIGNvbW1hbmQpKSkpKSkpCiAKIChjbC1kZWZnZW5l cmljIGVnbG90LWluaXRpYWxpemF0aW9uLW9wdGlvbnMgKHNlcnZlcikKICAgIkpTT04gb2JqZWN0 IHRvIHNlbmQgdW5kZXIgYGluaXRpYWxpemF0aW9uT3B0aW9ucycuIgotLSAKMi4zNy4xCgo= --000000000000a51f6b061b655e1e-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 04:45:09 2024 Received: (at 71642) by debbugs.gnu.org; 22 Jun 2024 08:45:09 +0000 Received: from localhost ([127.0.0.1]:44334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKwMv-00009d-D0 for submit@debbugs.gnu.org; Sat, 22 Jun 2024 04:45:09 -0400 Received: from mail-lj1-f175.google.com ([209.85.208.175]:59455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKwMt-00008z-5k for 71642@debbugs.gnu.org; Sat, 22 Jun 2024 04:45:08 -0400 Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2ebe0a81dc8so31948471fa.2 for <71642@debbugs.gnu.org>; Sat, 22 Jun 2024 01:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719045841; x=1719650641; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pzRHTvebvr4kNimhRScxwADqkZo9VYbto5ae2aSlygE=; b=EaVjGMjeOyPBGJmckxPBFoPJr/vrfg5K8v4BaqvLVV3Hp65wqAY9dFfLVO+VrshEPz JM/zyc3mPqDD/nh3q8g0k6vU4AgBCnqWcS1CqldM90he3dzbvhs2WEqogXEo2qiSZc13 bdLCEIt4kZA7gaN73fPtIv9vPizmuNPDwqMs3O7C3DQUuTC0l0HZ+vnUTuAejnCeOYDb q0INbYg2F1N6Z5tGCczyrCKunWCZWMA9wjlwdSfq/WeiTd5I/hVicb6amUArQf+aP7Qg I0zaseoCf3bA7KA309chs3Wbfyn/BCfLP/gs7OM5fIuhx7AFDl0RZjgvCsrnYv9GEcup DViA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719045841; x=1719650641; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pzRHTvebvr4kNimhRScxwADqkZo9VYbto5ae2aSlygE=; b=uqTiIu8PZ0D6WHL2Mz5sey6cgU1MO0H9g47drABZ+dP53rkrP973yupcIN0k8a1xqf ceeNU2QKO83hUwnX6d4sMrhuO+8Ouo3V4gbpzXg+TYXCcYPlT24pi7fvBqdZOPmIX+or KeTTW/pqiJOSaq4jmYbyT6E7ceBmBvCzMLPY6PgjMarHgV0508ZSEmYMzwWrcBFA3Ubx unKY9tu5nic3EA+hdkAfTfv5d9ULAPwoGNa9yn2OqpBc9h8CIMbkMHW4GeQ1JVoJraJD 2jiCQH8XiS9uq6OsRriNK5KcaFxP7UbIgIDNFgjOFPbmOHgm0qqrOsLb7LxVSjmv1CI5 Peyw== X-Forwarded-Encrypted: i=1; AJvYcCVIG6zF2Htv8Siv2TMejMlP99jp9DJt95cCBHNK2aPKlpL34cwSOCmJL0s8cnQUGzSnM4FH6pgDJE6gLFHC3q1qfrgvAr0= X-Gm-Message-State: AOJu0YzyOGUHBeGeZiFJlHsQ6i3COdBjgIrFm8sfDIoreW4Lik/yP5UA 1c1zyNuOEYwQt/S6sNL1t2uuwb3GYUSi+bDhRaqXHvaZdrl7ssRTJczQDPf9ZpcWCr0G4REllGg F8r+13H1cq+5Ww3tAaPXg88Pl1d4= X-Google-Smtp-Source: AGHT+IEn9T7pUfme9c85Qdvaa9HrC08SFVGhSHXGngHhDLjiNc3d3EXB0pUHKA7X7afZaOnAtTofNOZhJRtTxGlVFjQ= X-Received: by 2002:a19:740e:0:b0:52c:dea5:7c8c with SMTP id 2adb3069b0e04-52cdea57dc4mr780851e87.22.1719045840990; Sat, 22 Jun 2024 01:44:00 -0700 (PDT) MIME-Version: 1.0 References: <87v8243a22.fsf@jeremybryant.net> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 22 Jun 2024 09:44:59 +0100 Message-ID: Subject: Re: bug#71642: 30.0.50; eglot-execute doesn't support ExecuteCommandParams To: Troy Brown , Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71642 Cc: Jeremy Bryant , 71642@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Jun 21, 2024 at 2:51=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > On Fri, Jun 21, 2024 at 1:14=E2=80=AFPM Troy Brown wrote: > > > I've updated the patch based on your suggestions. > > Looks good, thanks! > > The only doubt I have is the Copyright Assignment. This is still a > "trivial" patch (< 15 LOC), I think but I'll need to ask Eli for > his opinion to be sure. > > Eli, if you're OK with the copyright aspects, please install this > and close the bug. Now actually copying in Eli. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 22 05:49:03 2024 Received: (at 71642-done) by debbugs.gnu.org; 22 Jun 2024 09:49:03 +0000 Received: from localhost ([127.0.0.1]:44479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKxMk-0001tj-Me for submit@debbugs.gnu.org; Sat, 22 Jun 2024 05:49:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKxMi-0001tE-GG for 71642-done@debbugs.gnu.org; Sat, 22 Jun 2024 05:49:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKxMc-0001lb-Qs; Sat, 22 Jun 2024 05:48:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=RkQhZu6WA2xmELwvRsJiiSJnHa3Umf9N+xe9Qnd+rRs=; b=jWw7/0Nr+aSBP9fnktc9 QrSdjKKL0WnCrRVyTYAvvOB5Jdx1TxeO9G+l8WFoo/VIAIVJsRZl3x21wButYrZCUkyVHa1Sx43xa Pn8zgxCD6CqI/GHTDPRSytSx8Cyl2J5NHt9BhcJhQq9hn/fqXL4dZVnE3ZumVGPnEEI3Wv2pKwyw5 ynja5fQprWMV81uAdJDn8dc9T9uTu8CER1todSKZf3J/QLJn8N3MAlgaFDnBkYSEHFIl/MrR5rB9B ZWzEYrUkTwjxuxnSE7ZKN47ulyL6OvNX6Gq8VfQgGnUBfPV2NKGF3Qc5B+KyQuddpcqdVJjSSK2M3 781F8WPde7Uqag==; Date: Sat, 22 Jun 2024 12:48:52 +0300 Message-Id: <868qyxi9yz.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Sat, 22 Jun 2024 09:44:59 +0100) Subject: Re: bug#71642: 30.0.50; eglot-execute doesn't support ExecuteCommandParams References: <87v8243a22.fsf@jeremybryant.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71642-done Cc: jb@jeremybryant.net, brownts@troybrown.dev, 71642-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Sat, 22 Jun 2024 09:44:59 +0100 > Cc: Jeremy Bryant , 71642@debbugs.gnu.org > > On Fri, Jun 21, 2024 at 2:51 PM João Távora wrote: > > > > On Fri, Jun 21, 2024 at 1:14 PM Troy Brown wrote: > > > > > I've updated the patch based on your suggestions. > > > > Looks good, thanks! > > > > The only doubt I have is the Copyright Assignment. This is still a > > "trivial" patch (< 15 LOC), I think but I'll need to ask Eli for > > his opinion to be sure. > > > > Eli, if you're OK with the copyright aspects, please install this > > and close the bug. > > Now actually copying in Eli. Thanks, I installed this, and I'm therefore closing the bug. Troy, if you want us to be able to accept your contributions in the future, please consider starting the copyright assignment paperwork at this time. (If you agree, I will send you the form to fill and the instructions to go with it.) From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 10:28:01 2024 Received: (at 71642-done) by debbugs.gnu.org; 23 Jun 2024 14:28:02 +0000 Received: from localhost ([127.0.0.1]:34771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLOCH-0005yz-El for submit@debbugs.gnu.org; Sun, 23 Jun 2024 10:28:01 -0400 Received: from mail-lj1-f180.google.com ([209.85.208.180]:51522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLOCF-0005yY-Ls for 71642-done@debbugs.gnu.org; Sun, 23 Jun 2024 10:28:00 -0400 Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2ec1ac1aed2so42011261fa.3 for <71642-done@debbugs.gnu.org>; Sun, 23 Jun 2024 07:27:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719152873; x=1719757673; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6gEWst0VJ+R7p5ec8SZsSkDpUybkMahKSn3htnpQQ3k=; b=XEuFh7MuakW6rZAiKXIntcbdLbtGOSFvVMwk1iYyRo+vQ7Bjro6K8xa5NpWyz6rA5n gaxCQf6BRgqaaFzYyMGrrMfyfOrl8+iSs7Q5ULV/k/VjOqh+oQlXIGae61PzGPKhwEtY 2EzRXn3eOw/LUfcgULKsxiE+QGJjAScQ+bUUERAxiNUWNPny+wT4dW2D0An2yh9zH1sq WmVRdXWGskHJx5i0RaTsfxAXE/97SotLeLC+itlu5HNxgKvXjaRrLo31qKhQuQmg2P+6 BZaj5VWVKXO+84uCX0Ji5iViWSz5lEPnfBceBCn82uE7X2B2krSsFws4KU/aV8DN6aEd 50Jw== X-Forwarded-Encrypted: i=1; AJvYcCVieAInzobQ7YpQ45TbvAfTVyTxYBSJBnYS+/7YWKKfIpI6hKNdvlKsh0bI6NVizRCeFOT2gDK9sArm8VBCqc0vjAIqlngy3gnnNA== X-Gm-Message-State: AOJu0Yz0LWNgQBt1UYxilDy3W1g7gaY3eXrZ7f9pkuP9IWTjNz3fqnb2 2x6LE9m79esrt6Fyf2ABA6O/UYg80SgJ4s6S3Px17cLnaX/AjJbCwGT5IREKfVc= X-Google-Smtp-Source: AGHT+IFWGNUSwmon4OemhHJq5j9ELP4JAcCUi881mgyPrsyph+MQQ9dzubZj/P2+10cp+Rq3ZrZe0A== X-Received: by 2002:ac2:5f09:0:b0:52c:8fe4:b153 with SMTP id 2adb3069b0e04-52ce1839751mr1171342e87.32.1719152872131; Sun, 23 Jun 2024 07:27:52 -0700 (PDT) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com. [209.85.208.50]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72440ebcc1sm120839366b.180.2024.06.23.07.27.51 for <71642-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Jun 2024 07:27:51 -0700 (PDT) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-57d044aa5beso3821513a12.2 for <71642-done@debbugs.gnu.org>; Sun, 23 Jun 2024 07:27:51 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXz7E/9Q+SXEPQeiOKTXEOn7emYU15oiNTRws4Bz8KEjKX1zm3TeFxj9bOk8lN/wU8bYxs54sdF2fo+L6uyaIu/5PFJIXOreDRVlA== X-Received: by 2002:a50:d59c:0:b0:57d:1696:fd16 with SMTP id 4fb4d7f45d1cf-57d4bd569afmr1465040a12.2.1719152871105; Sun, 23 Jun 2024 07:27:51 -0700 (PDT) MIME-Version: 1.0 References: <87v8243a22.fsf@jeremybryant.net> <868qyxi9yz.fsf@gnu.org> In-Reply-To: <868qyxi9yz.fsf@gnu.org> From: Troy Brown Date: Sun, 23 Jun 2024 10:27:39 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#71642: 30.0.50; eglot-execute doesn't support ExecuteCommandParams To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 71642-done Cc: jb@jeremybryant.net, =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , 71642-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On Sat, Jun 22, 2024 at 5:48=E2=80=AFAM Eli Zaretskii wrote: > > Troy, if you want us to be able to accept your contributions in the > future, please consider starting the copyright assignment paperwork at > this time. (If you agree, I will send you the form to fill and the > instructions to go with it.) Yes please send me the form and instructions, thanks Eli. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 10:35:40 2024 Received: (at 71642-done) by debbugs.gnu.org; 23 Jun 2024 14:35:40 +0000 Received: from localhost ([127.0.0.1]:35083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLOJg-0006H9-Fk for submit@debbugs.gnu.org; Sun, 23 Jun 2024 10:35:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLOJe-0006Gr-4y for 71642-done@debbugs.gnu.org; Sun, 23 Jun 2024 10:35:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLOJY-0002SW-5a; Sun, 23 Jun 2024 10:35:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=wtldXHjqWStwIlKTdddgDkz/AkMVrrDqrsNdh5lQaG4=; b=jeSHEI1RbSmcdKNnGsD6 81jLitFLYacaDJ1CwoAGlkAxDpQYtNLRbT1l/JcT9F1rBimyHOOF6Bhvr5JULjbyP6d6BVWApB+Ee RDeOpWNbKWDF2DiIr9QF7hZ996MmLS1SjLNnbBzHzcb/DMjTbE5WiO9iD6L5VluLLX0f6qaDNlQKx CoSbCB63YWrB9tyHMQC18C+4R/vOiveFSxAMi+GBj8JztlXAyYOeQmZxEjqf2XEzv0ycK+1Kcn5ll AkkFkOuBopcZhI+Wmn141/j0vb8msNAPzcypvQ8SX8Lg1FIZSbVCvpVYi0NMSY1c1aaVicinIiuWt XYdm8/0MR9IKVw==; Date: Sun, 23 Jun 2024 17:35:29 +0300 Message-Id: <8634p3engu.fsf@gnu.org> From: Eli Zaretskii To: Troy Brown In-Reply-To: (message from Troy Brown on Sun, 23 Jun 2024 10:27:39 -0400) Subject: Re: bug#71642: 30.0.50; eglot-execute doesn't support ExecuteCommandParams References: <87v8243a22.fsf@jeremybryant.net> <868qyxi9yz.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71642-done Cc: jb@jeremybryant.net, joaotavora@gmail.com, 71642-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Troy Brown > Date: Sun, 23 Jun 2024 10:27:39 -0400 > Cc: João Távora , > jb@jeremybryant.net, 71642-done@debbugs.gnu.org > > On Sat, Jun 22, 2024 at 5:48 AM Eli Zaretskii wrote: > > > > Troy, if you want us to be able to accept your contributions in the > > future, please consider starting the copyright assignment paperwork at > > this time. (If you agree, I will send you the form to fill and the > > instructions to go with it.) > > Yes please send me the form and instructions, thanks Eli. Thanks, form sent off-list. From unknown Tue Jun 17 01:46:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 22 Jul 2024 11:24:18 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator