GNU bug report logs - #71638
30.0.50; Compilation warnings

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Rudolf Adamkovič <rudolf <at> adamkovic.org>
Cc: luangruo <at> yahoo.com, 71638 <at> debbugs.gnu.org
Subject: bug#71638: 30.0.50; Compilation warnings
Date: Thu, 20 Jun 2024 18:48:16 +0300

> From: Rudolf Adamkovič <rudolf <at> adamkovic.org>
> Cc: Po Lu <luangruo <at> yahoo.com>, 71638 <at> debbugs.gnu.org
> Date: Thu, 20 Jun 2024 15:24:19 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Thanks, I tried to fix that now on master.
> 
> All warnings are gone *except* this one:
> 
> xwidget.c:492:17: warning: variable 'f' set but not used
>   struct frame *f = NULL;
>                 ^

Sorry, this one you will have to live with: the setting of 'f' is part
of checking the validity of the function's arguments, so it must be
left alone.

> Also, CC'in Po Lu, as after his 'cebca072c33', I *cannot build*:
> 
>   CC       nsxwidget.o
> nsfns.m:1320:3: error: use of undeclared identifier 'image_cache_refcount'
>   image_cache_refcount =
>   ^
> nsfns.m:3025:3: error: use of undeclared identifier 'image_cache_refcount'
>   image_cache_refcount =
>   ^
> 2 errors generated.

Please try again, I think this was fixed meanwhile.

> > In the future, please try to fix this on your system, because that's
> > the best place to make sure the changes indeed eliminate the warnings.
> 
> Honestly, I did not want to risk wasting more of your time that way.

It's the other way around, actually.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.