Subject: Re: bug#71622: mumi CLI client features for review checklists

From: Ludovic Courtès <[email-masked]>
Date: Thu, 27 Jun 2024 14:21:55 +0200

Hi Arun,

Arun Isaac <[email-masked]> skribis:

> # Idea 1
>
> Projects provide a review checklist in their .mumi/config. For example,
> something like
>
> ((review-checklist . (((name . good-commit-message)
>                        (description . "Are the commit messages written well?")
>                        (tag . review-good-commit-message))
>                       ((name . good-synopsis-description)
>                        (description . "Are the synopsis and description written well?")
>                        (tag . review-good-synopsis-description))
>                       ((name . tests-run)
>                        (description . "Are the package tests being run (if available)?")
>                        (tag . review-tests-run))
>                       […]))
>  […])

[...]

> # Idea 2
>
> A second much simpler idea is to implement templates for `mumi
> compose'. Projects provide templates under .mumi/templates. For example,
> $ cat .mumi/templates/review
> [ ] Are the commit messages written well?
> [ ] Are the synopsis and description written well?
> [ ] Are the package tests being run (if available)?

I prefer #2: it’s familiar to anyone used to Git{Hub,Lab}, it’s simpler,
good enough, and doesn’t go too far to provide a technical solution to a
social problem.

Alongside, a ‘mumi approve’ command that would set the
‘reviewed-looks-good’ tag would be a great step forward.

Thank you!

Ludo’.