GNU bug report logs - #716
23.0.60; opening tgz file causes emacs crash

Previous Next

Packages: w32, emacs;

Reported by: robert marshall <robert.marshall <at> tnei.co.uk>

Date: Thu, 14 Aug 2008 09:15:04 UTC

Severity: grave

Merged with 805, 899, 1088

Done: Jason Rumney <jasonr <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #135 received at 716 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: jasonr <at> f2s.com
Cc: 716 <at> debbugs.gnu.org, Magnus Henoch <mange <at> freemail.hr>
Subject: Re: bug#716: Bug in buffer-swap-text
Date: Tue, 23 Dec 2008 21:41:22 -0500

>> Your analysis sounds right, thank you.  I'd suggest to use another
>> r_alloc primitve, something like r_alloc_reset_variable, so you could do

> I've adapted your suggestion so it does not remove the consistency check in
> find_bloc (instead it does a non-checking find inline):

Thanks.  After your email, I thought we could just change
r_alloc_reset_variable to take 2 arguments: the old ptr and the
new ptr.  This way, you get more consistency checking.

BTW, if the double check (p->variable == ptr && p->data == *ptr) is
there for consistency, it would be good to add a comment about it.

Better yet: make it a real consistency check, along the lines of

  assert (*p->variable == p->data);

so it's not just checked for `ptr', but for all blocs visited in the loop.


        Stefan
This bug report was last modified 16 years and 153 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.