From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 15 13:53:27 2024 Received: (at submit) by debbugs.gnu.org; 15 Jun 2024 17:53:27 +0000 Received: from localhost ([127.0.0.1]:36679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIXag-0005Qu-V5 for submit@debbugs.gnu.org; Sat, 15 Jun 2024 13:53:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:34204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIXaf-0005Ql-Fd for submit@debbugs.gnu.org; Sat, 15 Jun 2024 13:53:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIXae-0006H2-8z for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2024 13:53:24 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sIXac-00053p-JI for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2024 13:53:24 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-35f090093d8so2541776f8f.0 for ; Sat, 15 Jun 2024 10:53:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718474000; x=1719078800; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=TvoCHsXk3V61aANiiqyIwohmZkc3whZslKOncnyI9Ak=; b=YhHKMepW+QVdGlHzZWh65mMkdswOBuutuCNzX07CU/Ssr0Uu5HsyoK52unyzLCHVB0 1hoIiv61WtNe/oeHTWQQhf8HNLl6dkYIkWzvT0sghIilKvljL5j7xqYbDiGcv53TzvO6 Ysujb98/CudnR/jknscdr+TIaqyU/bGg4hj9pCiRzVlX1VX1CLG1mkQZ0U+4fPU1KWHX bzCgmp67ZGd4aRQP47Hp1l5idTLeJ8yn9NsG+Mu/Cvwa8nBRbW97XvLSUm9KuNynsYk+ kPC9v2+0ESkwi0XTwl+64uFyPoMtEJqFSXp09iWyKbvAwOw9Pc5S6MrjfoWq3G4miN0u bnmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718474000; x=1719078800; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TvoCHsXk3V61aANiiqyIwohmZkc3whZslKOncnyI9Ak=; b=r+/wbshaorTAA3jmAHFvSmo8ChU+628gqxJuzQHJ6uSJtN1VtkwDY2VdbGwp4yC1hP LFqwsUUsb4c7s1Ktoah/exr0sux2sAzEx/yDHtRTsu+qAYO2M1UikDoqca2By+rBIeHb kdSMkIVnBp/UU6S2LV4mnJa1SDdjjuppzP0V7N7vUQHkrlskn7KyHF/+ykSPrMyY4jRL Ig4u4bLPMzdBDuudYxXSAR7A/vMtrzLHQsvJQmKtZe02ODdgS+PmEPUd8a4m+aKGY1Re oJONSiWTF5RhGoyvMl1xLt28lLKLVrc8Z6FHVWZymuzQOCbQJF7oamXXCuN94blxS0kc JgfQ== X-Gm-Message-State: AOJu0Yxl8aJNlI+GFtGvTY42FxuvZevW7gO9C4u7sDw34ne2aqx/R/fR VLaEX7hrWiCpX5EITNsGTd6hjXcByI0PTbWgvuP8m6Rk3X1S8uK1JR0WuDNl X-Google-Smtp-Source: AGHT+IF1TKlT62/SwwCuRmDiLUY7k/AXL458XZarclMQnw6p1wi0pa7oPzIA8SXS0EMglW8jhaYkXw== X-Received: by 2002:a5d:6da6:0:b0:360:83cd:ea2d with SMTP id ffacd0b85a97d-36083cded29mr4639732f8f.24.1718474000280; Sat, 15 Jun 2024 10:53:20 -0700 (PDT) Received: from fedora.localnet (2-230-139-124.ip202.fastwebnet.it. [2.230.139.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3607510315csm7646284f8f.90.2024.06.15.10.53.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jun 2024 10:53:19 -0700 (PDT) From: Vincenzo Pupillo To: bug-gnu-emacs@gnu.org Subject: 30.0.50; [PATCH] Fix wrong-type-argument in php-ts-mode--webserver-read-args Date: Sat, 15 Jun 2024 19:53:18 +0200 Message-ID: <26459508.1r3eYUQgxm@fedora> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart2279625.vFx2qVVIhK" Content-Transfer-Encoding: 7Bit Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=v.pupillo@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --nextPart2279625.vFx2qVVIhK Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Ciao, php-ts-mode-run-php-webserver throws an error if the current buffer is not associated with a file. This is due to php-ts-mode--webserver-read-args. php- ts-mode--webserver-read-args now uses default-directory if buffer-file-name returns nil. The included patch fixes this. Thanks. Vincenzo --nextPart2279625.vFx2qVVIhK Content-Disposition: attachment; filename="0001-Fix-wrong-type-argument-in-php-ts-mode-webserver-rea.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="x-UTF_8J"; name="0001-Fix-wrong-type-argument-in-php-ts-mode-webserver-rea.patch" >From 4a22bae2bd7515801037f3ab55f1a514a7e82aef Mon Sep 17 00:00:00 2001 From: Vincenzo Pupillo Date: Sat, 15 Jun 2024 18:57:29 +0200 Subject: [PATCH] Fix wrong-type-argument in php-ts-mode--webserver-read-args Prevents php-ts-mode--webserver-read-args from throwing an error if the current buffer is not associated with a file. * lisp/progmodes/php-ts-mode.el (php-ts-mode--webserver-read-args): Use default-directory if the current buffer is not associated with a file. * lisp/progmodes/php-ts-mode.el (php-ts-mode-run-php-webserver): Fix doc string. --- lisp/progmodes/php-ts-mode.el | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lisp/progmodes/php-ts-mode.el b/lisp/progmodes/php-ts-mode.el index fc029a17120..1a8a0a44468 100644 --- a/lisp/progmodes/php-ts-mode.el +++ b/lisp/progmodes/php-ts-mode.el @@ -1464,7 +1464,7 @@ php-ts-mode-run-php-webserver (derived-mode-add-parents 'php-ts-mode '(php-mode)) (defun php-ts-mode--webserver-read-args (&optional type) - "Helper for php-ts-mode-run-php-webserver. + "Helper for `php-ts-mode-run-php-webserver'. The optional TYPE can be the symbol \"port\", \"hostname\", \"document-root\" or \"router-script\", otherwise it requires all of them." (let ((ask-port (lambda () @@ -1474,11 +1474,15 @@ php-ts-mode--webserver-read-args (ask-document-root (lambda () (expand-file-name (read-directory-name "Document root: " - (file-name-directory (buffer-file-name)))))) + (file-name-directory + (or (buffer-file-name) + default-directory)))))) (ask-router-script (lambda () (expand-file-name (read-file-name "Router script: " - (file-name-directory (buffer-file-name))))))) + (file-name-directory + (or (buffer-file-name) + default-directory))))))) (cl-case type (port (funcall ask-port)) (hostname (funcall ask-hostname)) -- 2.45.2 --nextPart2279625.vFx2qVVIhK-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 15 14:58:22 2024 Received: (at 71574-done) by debbugs.gnu.org; 15 Jun 2024 18:58:22 +0000 Received: from localhost ([127.0.0.1]:41478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIYbW-0002p2-0G for submit@debbugs.gnu.org; Sat, 15 Jun 2024 14:58:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIYbT-0002oi-D4 for 71574-done@debbugs.gnu.org; Sat, 15 Jun 2024 14:58:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIYZF-00076A-PN; Sat, 15 Jun 2024 14:56:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cMgkl5NwQWBmwyLAy1+/6EPbKkCSskjyOXiNcR6CmHE=; b=Usr/YW+G8c58 nzuZnnen/yf9XCk+OsHXkqx4ug/zWqj21+VAaElGWAG9b160O9r8JwdlSUlDTuVGF8XbZMJkcTuk9 zh5hIhRtPCsoUzwtvedvBiBHvQQTkGhaULgIqA4SDIzoP7Xeqra7sfvbD2KfKz7dW5DppPFDtTDmR xaDWTkg9YF1LRN2yb7/XUw6/mOjJfqqOIkX3qvhFsHH875vSLP5NWJM0QOOVUVR2QxHwES26OFQn2 zrVDYIC9/13hij99LB1V+5z/i8bUB/JXzP5F5pcmc4bljKT8zV38hio7y0XM6B9/ktsItWrPjq3nq NqQ0FPERtkJMgdXUFDwTVg==; Date: Sat, 15 Jun 2024 21:55:50 +0300 Message-Id: <86zfrmrq6h.fsf@gnu.org> From: Eli Zaretskii To: Vincenzo Pupillo In-Reply-To: <26459508.1r3eYUQgxm@fedora> (message from Vincenzo Pupillo on Sat, 15 Jun 2024 19:53:18 +0200) Subject: Re: bug#71574: 30.0.50; [PATCH] Fix wrong-type-argument in php-ts-mode--webserver-read-args References: <26459508.1r3eYUQgxm@fedora> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71574-done Cc: 71574-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Vincenzo Pupillo > Date: Sat, 15 Jun 2024 19:53:18 +0200 > > php-ts-mode-run-php-webserver throws an error if the current buffer is not > associated with a file. This is due to php-ts-mode--webserver-read-args. php- > ts-mode--webserver-read-args now uses default-directory if buffer-file-name > returns nil. > The included patch fixes this. Thanks, installed (but please note the minor changes I made in your commit log message, and try to follow this style in the future). I'm closing this bug. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 15 16:05:43 2024 Received: (at 71574-done) by debbugs.gnu.org; 15 Jun 2024 20:05:43 +0000 Received: from localhost ([127.0.0.1]:46022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIZeh-0005q9-0O for submit@debbugs.gnu.org; Sat, 15 Jun 2024 16:05:43 -0400 Received: from mail-lf1-f50.google.com ([209.85.167.50]:51693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIZef-0005pn-LJ for 71574-done@debbugs.gnu.org; Sat, 15 Jun 2024 16:05:42 -0400 Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52bc3130ae6so3602230e87.3 for <71574-done@debbugs.gnu.org>; Sat, 15 Jun 2024 13:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718481875; x=1719086675; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=chxpRQOf3hQKmHe3WhZQd7Lyg9OApF8xLbeOkqZe/d4=; b=U7rWbYsitIKIg8aXSNy+p4wbe9VOCZ8VTHO3agTq9NKeTMSSoWHV7vjdtLdm0aCh2/ II38iereyQJ5hAFSqylVkBeV7h5+hnDoxdRC13pLNh4C5Brb4+MKrR1gFjbcINudPluc Tz28EvOYEkKI30CXTZcZUCdQ1a8Fij5ROCeZd9H9YAUa2+dhhZp8ckihkgupc2rcRMib dAlu1wmsc7qrNNMfQFAC3i52s5U1/KevNd7ArFg77AZUvngCO4Mz0p342L2iOzZvyvz4 /1L49y9IippN0HQ2qJ9K7miSB/prcx5T0Zd3eXJXZ66dQzl901JZRe/mVhFmwINUYKtn PtRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718481875; x=1719086675; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=chxpRQOf3hQKmHe3WhZQd7Lyg9OApF8xLbeOkqZe/d4=; b=B8dPe0TuFeD6isW9RcEsTPbXGR6A19QGzf1NqZfWatpMNwkV4ibELMiS7rddXtm/57 Qrc10ixbeajjRcXahGMn0Y0OWpECPmRyXniZOHsagZkSTJozATviWweW0n70oeaMBXhx bIusbXtkbFoQkQbuB3vtNJO3hvBwpi7WEw7Q7MVS2QzQIaK/Ty87AKM0EMJ0yJVIrZ5j eeC4It3q8OW5BsPODaBQ0YG0fdWT1sHtBSX7Yji8+t4owho3c/aDU9O2U0T7zmMGBfIY OQ8bB8t13Y64rPmTmA77XsHSZF2XIeSDVy7oNiJqwalYmHKDkxPW+C8j+1Nn65cTwwI3 2bTQ== X-Gm-Message-State: AOJu0Yys1mkQci08RHvkafw/IiqDTLMwnJjdI4pnGKNe89QM6U4P1TW8 HRrZQ9Gwq0mXHpmBZ8VER481IOsgnrjHRvVvwl4W307iVcvwDZiKaHj928oO X-Google-Smtp-Source: AGHT+IF0z+ljk/j3jh9pPyHpTRpAKT9rBjdUtXq8HocWYsf+HlmAAkpk5tr+SUgXIDoMQNt/65RSxg== X-Received: by 2002:a17:906:308c:b0:a6f:33d6:2d4b with SMTP id a640c23a62f3a-a6f60de8311mr340020166b.75.1718481374141; Sat, 15 Jun 2024 12:56:14 -0700 (PDT) Received: from fedora.localnet (2-230-139-124.ip202.fastwebnet.it. [2.230.139.124]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f56f40fe2sm339706666b.148.2024.06.15.12.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jun 2024 12:56:13 -0700 (PDT) From: Vincenzo Pupillo To: Eli Zaretskii Subject: Re: bug#71574: 30.0.50; [PATCH] Fix wrong-type-argument in php-ts-mode--webserver-read-args Date: Sat, 15 Jun 2024 21:56:13 +0200 Message-ID: <2522875.XAFRqVoOGU@fedora> In-Reply-To: <86zfrmrq6h.fsf@gnu.org> References: <26459508.1r3eYUQgxm@fedora> <86zfrmrq6h.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71574-done Cc: 71574-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) In data sabato 15 giugno 2024 20:55:50 CEST, Eli Zaretskii ha scritto: > > From: Vincenzo Pupillo > > Date: Sat, 15 Jun 2024 19:53:18 +0200 > > > > php-ts-mode-run-php-webserver throws an error if the current buffer is not > > associated with a file. This is due to php-ts-mode--webserver-read-args. > > php- ts-mode--webserver-read-args now uses default-directory if > > buffer-file-name returns nil. > > The included patch fixes this. > > Thanks, installed (but please note the minor changes I made in your > commit log message, and try to follow this style in the future). Ok, thank you! > > I'm closing this bug. Vincenzo From unknown Thu Aug 14 20:53:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 14 Jul 2024 11:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator