GNU bug report logs - #71572
[PATCH] seconds-to-string-approximate

Previous Next

Full log

View this message in rfc822 format

From: JD Smith <jdtsmith <at> gmail.com>
To: john muhl <jm <at> pub.pink>
Cc: Adam Porter <adam <at> alphapapa.net>, 71572 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, Jonas Bernoulli <jonas <at> bernoul.li>, Paul Eggert <eggert <at> cs.ucla.edu>
Subject: bug#71572: [PATCH] seconds-to-string-approximate
Date: Mon, 9 Dec 2024 04:52:56 +0900

[Message part 1 (text/plain, inline)]

> On Dec 8, 2024, at 4:17 AM, john muhl <jm <at> pub.pink> wrote:
> 
> JD Smith <jdtsmith <at> gmail.com <mailto:jdtsmith <at> gmail.com>> writes:
> 
>>> On Dec 7, 2024, at 8:02 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>> 
>>>> From: JD Smith <jdtsmith <at> gmail.com>
>>>> Date: Sat, 30 Nov 2024 13:58:52 -0500
>>>> Cc: Eli Zaretskii <eliz <at> gnu.org>,
>>>> Adam Porter <adam <at> alphapapa.net>,
>>>> jonas <at> bernoul.li,
>>>> Paul Eggert <eggert <at> cs.ucla.edu>
>>>> 
>>>> I was recently reminded of the need for a more capable seconds-to-string.  
>>>> 
>>>> Anyone have any additional comments on this proposed patch? If not,
>>>> I'd suggest someone with access
>>>> merges.
>>> 
>>> A few minor nits below, and then we can install:
>> 
>> Thanks.  Updated patch below.
> 
> Thanks for working on this. I gave a quick try and noticed some
> amounts aren’t pluralized how I expect; e.g.
> 
>  (seconds-to-string 36541462 'expanded nil 1)
>  ;; "1 year 1.9 month"
...
> According to the Chicago Manual of Style all fractional values are
> plural, even 1.0, 2.0 &c.

Thanks for this, a case I hadn't tested.  Corrected in the attached.



[Message part 2 (text/html, inline)]

[0001-seconds-to-string-new-optional-arguments-for-readabl.patch (application/octet-stream, attachment)]

[Message part 4 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.