From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 14 14:06:24 2024 Received: (at submit) by debbugs.gnu.org; 14 Jun 2024 18:06:24 +0000 Received: from localhost ([127.0.0.1]:40898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIBJf-0004g6-HH for submit@debbugs.gnu.org; Fri, 14 Jun 2024 14:06:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:52636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIBJc-0004fx-9U for submit@debbugs.gnu.org; Fri, 14 Jun 2024 14:06:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIBHU-0000Gj-37 for guix-patches@gnu.org; Fri, 14 Jun 2024 14:04:10 -0400 Received: from mail-108-mta159.mxroute.com ([136.175.108.159]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sIBHR-0003pv-J7 for guix-patches@gnu.org; Fri, 14 Jun 2024 14:04:07 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta159.mxroute.com (ZoneMTA) with ESMTPSA id 19017ebb1e700017a3.001 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 14 Jun 2024 18:04:00 +0000 X-Zone-Loop: 547e130cee8682972b93f8ab799e177802a625307450 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:MIME-Version: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/OGUUfoO+nk1NL9bepkWCkzrvIpyV99xpS+73YhE72c=; b=Akm2UU3dPaAGizYDfJetCc603s wm8WKhDM4cxmiNXT5z5PXx7dkhstD8RYowai9AkPn0fsUeXm2bdI+dq+TEYGkPB7ObcxHa/zBf4z6 QhmwY+6GQX4M7rlGnhRDAIFXHcZNM0Wk+WU+wbnauL0A1T/DMjKVOG5vz6CXYBQot9JcZriAvKgft xAQBuMtPO0m3Kn5a3xkogqQ2jnLOTaGPekch7z5foDd8LaxkcNQh06ywrBP45Cjj02tfQbhvJE4jp b4APeX3nfQlmRNxt6jZ9m7NmVKFjMCyHYCcdbn0LsmNwoJBKq2w/p/KLe2ToU+enWVp5D+yc1k5Fy t29tVrMw==; From: Richard Sent To: guix-patches@gnu.org Subject: [PATCH] services: networking: Allow dhcp-client to use a config file Date: Fri, 14 Jun 2024 13:52:58 -0400 Message-ID: <0888b6afe4003512c452fad2bc88370b007fc0ca.1718387578.git.richard@freakingpenguin.com> MIME-Version: 1.0 X-Debbugs-Cc: Florian Pelz , Ludovic Courtès , Matthew Trzcinski , Maxim Cournoyer Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com Received-SPF: pass client-ip=136.175.108.159; envelope-from=richard@freakingpenguin.com; helo=mail-108-mta159.mxroute.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/services/networking (dhcp-client-configuration): Create dhcp-client-configuration-config-file. (dhcp-client-shepherd-service): Use the config file when invoking dhclient if supplied. * doc/guix.texi: Document it. Change-Id: I286de4ddf59c5e606bf1fe0a7510570869e62b1a --- Hi all. This patch adds support for providing dhcp-client a configuration file, which is a file of the form https://man.archlinux.org/man/dhclient.conf.5. I believe this can be used to resolve https://lists.gnu.org/archive/html/help-guix/2024-06/msg00071.html using the instructions at https://unix.stackexchange.com/a/399694, although I haven't confirmed that. Either way, adding more flexibility to the service is a good thing in my eyes. doc/guix.texi | 3 +++ gnu/services/networking.scm | 15 +++++++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 0102fd0fad..ad67a436ea 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -21035,6 +21035,9 @@ Networking Setup non-loopback interfaces that can be activated. Otherwise the DHCP client listens only on the specified interfaces. +@item @code{config-file} (default: @code{#f}) +The configuration file for the DHCP client. + @item @code{shepherd-requirement} (default: @code{'()}) @itemx @code{shepherd-provision} (default: @code{'(networking)}) This option can be used to provide a list of symbols naming Shepherd services diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm index 378e117a86..12d8934e43 100644 --- a/gnu/services/networking.scm +++ b/gnu/services/networking.scm @@ -91,6 +91,7 @@ (define-module (gnu services networking) dhcp-client-configuration? dhcp-client-configuration-package dhcp-client-configuration-interfaces + dhcp-client-configuration-config-file dhcp-client-configuration-shepherd-provision dhcp-client-configuration-shepherd-requirement @@ -319,6 +320,8 @@ (define-record-type* (default '())) (shepherd-provision dhcp-client-configuration-shepherd-provision (default '(networking))) + (config-file dhcp-client-configuration-config-file + (default #f)) (interfaces dhcp-client-configuration-interfaces (default 'all))) ;'all | list of strings @@ -329,6 +332,7 @@ (define dhcp-client-shepherd-service (requirement (dhcp-client-configuration-shepherd-requirement config)) (provision (dhcp-client-configuration-shepherd-provision config)) (interfaces (dhcp-client-configuration-interfaces config)) + (config-file (dhcp-client-configuration-config-file config)) (pid-file "/var/run/dhclient.pid")) (list (shepherd-service (documentation "Set up networking via DHCP.") @@ -364,6 +368,11 @@ (define dhcp-client-shepherd-service (_ #~'#$interfaces)))) + (define config-file-args + (if #$config-file + (list "-cf" #$config-file) + '())) + (false-if-exception (delete-file #$pid-file)) (let ((pid (fork+exec-command ;; By default dhclient uses a @@ -371,8 +380,10 @@ (define dhcp-client-shepherd-service ;; DDNS, which is incompatable with ;; non-ISC DHCP servers; thus, pass '-I'. ;; . - (cons* dhclient "-nw" "-I" - "-pf" #$pid-file ifaces)))) + `(,dhclient "-nw" "-I" + "-pf" ,#$pid-file + ,@config-file-args + ,@ifaces)))) (and (zero? (cdr (waitpid pid))) (read-pid-file #$pid-file))))) (stop #~(make-kill-destructor)))))) base-commit: 7770e4140cddd5dc9c9879cb2bfcbd6cd4de59a0 -- 2.45.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 17 17:03:03 2024 Received: (at 71561) by debbugs.gnu.org; 17 Jun 2024 21:03:03 +0000 Received: from localhost ([127.0.0.1]:37550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJJVH-0004Tm-6a for submit@debbugs.gnu.org; Mon, 17 Jun 2024 17:03:03 -0400 Received: from mail-ot1-f44.google.com ([209.85.210.44]:44261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJJVE-0004TH-Gv for 71561@debbugs.gnu.org; Mon, 17 Jun 2024 17:03:01 -0400 Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-6f9a4f9923aso2696101a34.0 for <71561@debbugs.gnu.org>; Mon, 17 Jun 2024 14:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718658112; x=1719262912; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=6ZbCuRSfdAfIlRKpFB0qTDPBwo9SSlylgkTUFvkt1pY=; b=KyejVTWafy2Y78Y7l+UMJojn+y9AEUHQOfU1DFHG4UAuFvcqes2IiWa+6ZTfiYhZK6 BKxP7y4/OrcDVzfRif40Z+aYHIoUY2kKwXU8FVk4X3SCvEXS+9hAe85OQzstxAjg1wa9 +/3uPwkStR/GoXhSQJmE+EYdjTDuhq8KY5FWjulcXw/GZ28WvZkZKkfcbfvYZaOMHge8 zfouirSTEuG1s4W1t8apzmvaadhfTGsWLWjyQ6jMjxr2EMp7Mw+pe2vDivedg+XCHdY1 jE+uQ6Yl6b1rJZxV6bSU7D+p0p4QogGZdLPdZjCz/pCJEbMculBrodbCcCGpSRvWq0B2 ryxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718658112; x=1719262912; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6ZbCuRSfdAfIlRKpFB0qTDPBwo9SSlylgkTUFvkt1pY=; b=OeytxwtiMJbCNBcbGl/QEYUxdGw5JaO8/badA1sz16SlEM1Z2JMEiv/X7QU1Jkwv/U ntRGQKBQa7hzMB1BLANfC2N7Kzsc53xbLOKk7peoZSihbMrw8QCIk9LNDRG6gmV+QFBy gd/7OpoYFZhN6O2CoERGgdCPCSHgi/4rWXXpnymWB9JE1pedHZAutCvVe4jNr3avw5hw l4Af1fwo4jRMNLAOVX47dM8fpps9Xc3jyJ9HjW++kZAXI/FtsFSetbTfs5TMkDbAM7Zs Y+jrUXhATafUQbej3n2txuYjAl3WoGDcjTSFyxqXBIIzFXNf4IUFqM5WeT0KwoLpCCDV KZVQ== X-Gm-Message-State: AOJu0YzhKhA3k8Ti8UTeiuxZWdxgO5B7Nn3tZf0D02ObNqXBV/bN/kHC EJxgmUwK1bpJFxOuDyTbLm1M10Kg0msv7DqIQOs8BzIIg1jI3EBB X-Google-Smtp-Source: AGHT+IEL3C8da+VB/KQGnlgfhfF1InWpetom8ReaOEzF5SczmG56w5hFB7aMwcilRvL6H/DPjO5IUA== X-Received: by 2002:a05:6830:1395:b0:6f9:b82b:a09c with SMTP id 46e09a7af769-6fb9364aa27mr11653086a34.7.1718658112270; Mon, 17 Jun 2024 14:01:52 -0700 (PDT) Received: from hurd (dsl-158-184.b2b2c.ca. [66.158.158.184]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b2a5bf2ae0sm59114146d6.22.2024.06.17.14.01.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 14:01:51 -0700 (PDT) From: Maxim Cournoyer To: Richard Sent Subject: Re: [bug#71561] [PATCH] services: networking: Allow dhcp-client to use a config file In-Reply-To: <0888b6afe4003512c452fad2bc88370b007fc0ca.1718387578.git.richard@freakingpenguin.com> (Richard Sent's message of "Fri, 14 Jun 2024 13:52:58 -0400") References: <0888b6afe4003512c452fad2bc88370b007fc0ca.1718387578.git.richard@freakingpenguin.com> Date: Mon, 17 Jun 2024 17:01:50 -0400 Message-ID: <87o77zfflt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71561 Cc: 71561@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , Florian Pelz , Matthew Trzcinski X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Richard, Richard Sent writes: > * gnu/services/networking (dhcp-client-configuration): Create Nitpick: The file name should be complete, including the extension. Pressing 'C' on the diff's hunk while authoring a commit message in Magit (Emacs) creates a ChangeLog entry automatically, if that helps. > dhcp-client-configuration-config-file. I'd perhaps reword this to: (dhcp-client-configuration) [config-file]: New field. (dhcp-client-configuration-config-file): New accessor. > (dhcp-client-shepherd-service): Use the config file when invoking > dhclient if supplied. > * doc/guix.texi: Document it. > > Change-Id: I286de4ddf59c5e606bf1fe0a7510570869e62b1a > --- > Hi all. > > This patch adds support for providing dhcp-client a configuration > file, which is a file of the form > https://man.archlinux.org/man/dhclient.conf.5. I believe this can be > used to resolve > https://lists.gnu.org/archive/html/help-guix/2024-06/msg00071.html > using the instructions at https://unix.stackexchange.com/a/399694, > although I haven't confirmed that. Either way, adding more flexibility > to the service is a good thing in my eyes. I think it's a good thing to have the 'escape hatch' implemented by many services! > doc/guix.texi | 3 +++ > gnu/services/networking.scm | 15 +++++++++++++-- > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/doc/guix.texi b/doc/guix.texi > index 0102fd0fad..ad67a436ea 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -21035,6 +21035,9 @@ Networking Setup > non-loopback interfaces that can be activated. Otherwise the DHCP > client listens only on the specified interfaces. > > +@item @code{config-file} (default: @code{#f}) > +The configuration file for the DHCP client. > + > @item @code{shepherd-requirement} (default: @code{'()}) > @itemx @code{shepherd-provision} (default: @code{'(networking)}) > This option can be used to provide a list of symbols naming Shepherd services > diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm > index 378e117a86..12d8934e43 100644 > --- a/gnu/services/networking.scm > +++ b/gnu/services/networking.scm > @@ -91,6 +91,7 @@ (define-module (gnu services networking) > dhcp-client-configuration? > dhcp-client-configuration-package > dhcp-client-configuration-interfaces > + dhcp-client-configuration-config-file > dhcp-client-configuration-shepherd-provision > dhcp-client-configuration-shepherd-requirement > > @@ -319,6 +320,8 @@ (define-record-type* > (default '())) > (shepherd-provision dhcp-client-configuration-shepherd-provision > (default '(networking))) > + (config-file dhcp-client-configuration-config-file > + (default #f)) > (interfaces dhcp-client-configuration-interfaces > (default 'all))) ;'all | list of strings > > @@ -329,6 +332,7 @@ (define dhcp-client-shepherd-service > (requirement (dhcp-client-configuration-shepherd-requirement config)) > (provision (dhcp-client-configuration-shepherd-provision config)) > (interfaces (dhcp-client-configuration-interfaces config)) > + (config-file (dhcp-client-configuration-config-file config)) > (pid-file "/var/run/dhclient.pid")) > (list (shepherd-service > (documentation "Set up networking via DHCP.") > @@ -364,6 +368,11 @@ (define dhcp-client-shepherd-service > (_ > #~'#$interfaces)))) > > + (define config-file-args > + (if #$config-file > + (list "-cf" #$config-file) > + '())) > + > (false-if-exception (delete-file #$pid-file)) > (let ((pid (fork+exec-command > ;; By default dhclient uses a > @@ -371,8 +380,10 @@ (define dhcp-client-shepherd-service > ;; DDNS, which is incompatable with > ;; non-ISC DHCP servers; thus, pass '-I'. > ;; . > - (cons* dhclient "-nw" "-I" > - "-pf" #$pid-file ifaces)))) > + `(,dhclient "-nw" "-I" > + "-pf" ,#$pid-file > + ,@config-file-args > + ,@ifaces)))) > (and (zero? (cdr (waitpid pid))) > (read-pid-file #$pid-file))))) > (stop #~(make-kill-destructor)))))) Reviewed-by: Maxim Cournoyer Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 17 20:50:29 2024 Received: (at 71561) by debbugs.gnu.org; 18 Jun 2024 00:50:29 +0000 Received: from localhost ([127.0.0.1]:38628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJN3M-0005B6-PG for submit@debbugs.gnu.org; Mon, 17 Jun 2024 20:50:29 -0400 Received: from mail-108-mta195.mxroute.com ([136.175.108.195]:38755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJN3J-0005As-KV for 71561@debbugs.gnu.org; Mon, 17 Jun 2024 20:50:27 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta195.mxroute.com (ZoneMTA) with ESMTPSA id 19028d2cb0400017a3.001 for <71561@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 18 Jun 2024 00:50:21 +0000 X-Zone-Loop: 65dcf4d74f29dd232f5205d6e9818b9414cef7791300 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=z3DaJi7CeD4R2AF4ObyE7w+8IYCkAmwBgCVcguUKlZc=; b=e4tGdaMc9Ki5pHfv1majrAiGIF 7fgfMNc3orP5++Ar5ugtDlQm2hoCtjUrYvZoPySwZfWKHBA5lvoyBuhPdlxB27bfstJvFeSStiqLQ 4KR2Qyi2bVYbqP2fn3BxZWAH6l3IDGSmFta2LpTUk+M+2r0luFYHE7gyaNj8xVNdj19kh4I6iD6m4 ioAxFFqsEoLoaTIdnQn32FEOzPeasyDuRAiBarsUoPjxK2xsqQ/Ul8AIeQbdvCPH6y2O5e5GE04VQ FGoe6zrG8PoVfnhgmY++etNMeqCW/V426S+txrbno2Lb/7sW31f4vIUrHSjcZqR4VZ0xYZA9h86Ox 2IAdDkmA==; From: Richard Sent To: 71561@debbugs.gnu.org Subject: [PATCH 2/2] doc: Prepend ISC to DHCP client references. Date: Mon, 17 Jun 2024 20:49:13 -0400 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Florian Pelz , Ludovic Courtès , Matthew Trzcinski , Maxim Cournoyer Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71561 Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This makes it clearer that this service uses the ISC's dhclient implementation and does not support DHCP clients that have different command line interfaces. * doc/guix.texi (Networking Setup): Prepend ISC to all DHCP client references. Change-Id: I750ef2ffb4b23445c4a2b97aaa44eba56458f430 --- doc/guix.texi | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index ad67a436ea..8dd3bee5ca 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -21016,27 +21016,27 @@ Networking Setup @cindex DHCP, networking service @defvar dhcp-client-service-type -This is the type of services that run @var{dhcp}, a Dynamic Host Configuration -Protocol (DHCP) client. +This is the type of services that run @var{dhclient}, the ISC Dynamic +Host Configuration Protocol (DHCP) client. @end defvar @deftp {Data Type} dhcp-client-configuration -Data type representing the configuration of the DHCP client service. +Data type representing the configuration of the ISC DHCP client service. @table @asis @item @code{package} (default: @code{isc-dhcp}) -DHCP client package to use. +The ISC DHCP client package to use. @item @code{interfaces} (default: @code{'all}) -Either @code{'all} or the list of interface names that the DHCP client -should listen on---e.g., @code{'("eno1")}. +Either @code{'all} or the list of interface names that the ISC DHCP +client should listen on---e.g., @code{'("eno1")}. -When set to @code{'all}, the DHCP client listens on all the available -non-loopback interfaces that can be activated. Otherwise the DHCP -client listens only on the specified interfaces. +When set to @code{'all}, the ISC DHCP client listens on all the +available non-loopback interfaces that can be activated. Otherwise the +ISC DHCP client listens only on the specified interfaces. @item @code{config-file} (default: @code{#f}) -The configuration file for the DHCP client. +The configuration file for the ISC DHCP client. @item @code{shepherd-requirement} (default: @code{'()}) @itemx @code{shepherd-provision} (default: @code{'(networking)}) @@ -21047,7 +21047,7 @@ Networking Setup Likewise, @code{shepherd-provision} is a list of Shepherd service names (symbols) provided by this service. You might want to change the -default value if you intend to run several DHCP clients, only one of +default value if you intend to run several ISC DHCP clients, only one of which provides the @code{networking} Shepherd service. @end table @end deftp -- 2.45.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 17 20:50:29 2024 Received: (at 71561) by debbugs.gnu.org; 18 Jun 2024 00:50:29 +0000 Received: from localhost ([127.0.0.1]:38630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJN3N-0005B9-86 for submit@debbugs.gnu.org; Mon, 17 Jun 2024 20:50:29 -0400 Received: from mail-108-mta2.mxroute.com ([136.175.108.2]:42493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJN3J-0005Ar-Iz for 71561@debbugs.gnu.org; Mon, 17 Jun 2024 20:50:27 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta2.mxroute.com (ZoneMTA) with ESMTPSA id 19028d2c02e00017a3.001 for <71561@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 18 Jun 2024 00:50:18 +0000 X-Zone-Loop: c6f20fe761421c0f76d79758dd1ed31bacf59443412a X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:MIME-Version: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=00ctH3eh+Xk44C2oMRar+NfUAo4wQadYF68kxkumw58=; b=Q1I73c2gE12MXWXbVSoGBSepxr 4GkA4Ko45XNOtA4H54gfWGAzlXr9cjzOMCcuytjNmkPECEU9Fk6l09uvj5IdiTqVfEVr/vf0pMezl Z8jet58GSE0BD6pbTs8cqpQcyT5JUTxVHAl/aviJ5crAJBfNRSbAW4kJOpA6kp4PFH6+SYDuv8Jxf xDqD9jBrBUshvgtwnuhgcgOoGF4qk+thdLWNDB8e75TBm01X69alWj8AWG7Z6aQlw2AmS+szZNcCB S2uSpU51klxrU/nc75Rvz+B5w8342dwDbxltA/5ZALPKlMaDnKytl9RMbf2dOp7boFdcmY09N7a5A utVTkCrA==; From: Richard Sent To: 71561@debbugs.gnu.org Subject: [PATCH 1/2] services: networking: Allow dhcp-client to use a config file Date: Mon, 17 Jun 2024 20:49:12 -0400 Message-ID: MIME-Version: 1.0 X-Debbugs-Cc: Florian Pelz , Ludovic Courtès , Matthew Trzcinski , Maxim Cournoyer Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71561 Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/services/networking.scm (dhcp-client-configuration) [config-file]: New field. (dhcp-client-configuration-config-file): New accessor. (dhcp-client-shepherd-service): Use the config file when invoking dhclient if supplied. * doc/guix.texi: Document it. Change-Id: I286de4ddf59c5e606bf1fe0a7510570869e62b1a --- doc/guix.texi | 3 +++ gnu/services/networking.scm | 15 +++++++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 0102fd0fad..ad67a436ea 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -21035,6 +21035,9 @@ Networking Setup non-loopback interfaces that can be activated. Otherwise the DHCP client listens only on the specified interfaces. +@item @code{config-file} (default: @code{#f}) +The configuration file for the DHCP client. + @item @code{shepherd-requirement} (default: @code{'()}) @itemx @code{shepherd-provision} (default: @code{'(networking)}) This option can be used to provide a list of symbols naming Shepherd services diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm index 378e117a86..12d8934e43 100644 --- a/gnu/services/networking.scm +++ b/gnu/services/networking.scm @@ -91,6 +91,7 @@ (define-module (gnu services networking) dhcp-client-configuration? dhcp-client-configuration-package dhcp-client-configuration-interfaces + dhcp-client-configuration-config-file dhcp-client-configuration-shepherd-provision dhcp-client-configuration-shepherd-requirement @@ -319,6 +320,8 @@ (define-record-type* (default '())) (shepherd-provision dhcp-client-configuration-shepherd-provision (default '(networking))) + (config-file dhcp-client-configuration-config-file + (default #f)) (interfaces dhcp-client-configuration-interfaces (default 'all))) ;'all | list of strings @@ -329,6 +332,7 @@ (define dhcp-client-shepherd-service (requirement (dhcp-client-configuration-shepherd-requirement config)) (provision (dhcp-client-configuration-shepherd-provision config)) (interfaces (dhcp-client-configuration-interfaces config)) + (config-file (dhcp-client-configuration-config-file config)) (pid-file "/var/run/dhclient.pid")) (list (shepherd-service (documentation "Set up networking via DHCP.") @@ -364,6 +368,11 @@ (define dhcp-client-shepherd-service (_ #~'#$interfaces)))) + (define config-file-args + (if #$config-file + (list "-cf" #$config-file) + '())) + (false-if-exception (delete-file #$pid-file)) (let ((pid (fork+exec-command ;; By default dhclient uses a @@ -371,8 +380,10 @@ (define dhcp-client-shepherd-service ;; DDNS, which is incompatable with ;; non-ISC DHCP servers; thus, pass '-I'. ;; . - (cons* dhclient "-nw" "-I" - "-pf" #$pid-file ifaces)))) + `(,dhclient "-nw" "-I" + "-pf" ,#$pid-file + ,@config-file-args + ,@ifaces)))) (and (zero? (cdr (waitpid pid))) (read-pid-file #$pid-file))))) (stop #~(make-kill-destructor)))))) base-commit: b993f4735d41e690dbafb8ee2e17fce996a8cf20 -- 2.45.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 17 20:53:28 2024 Received: (at 71561) by debbugs.gnu.org; 18 Jun 2024 00:53:28 +0000 Received: from localhost ([127.0.0.1]:38641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJN6G-0005HF-0Z for submit@debbugs.gnu.org; Mon, 17 Jun 2024 20:53:28 -0400 Received: from mail-108-mta248.mxroute.com ([136.175.108.248]:39519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJN6D-0005H6-Us for 71561@debbugs.gnu.org; Mon, 17 Jun 2024 20:53:26 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta248.mxroute.com (ZoneMTA) with ESMTPSA id 19028d5859900017a3.001 for <71561@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 18 Jun 2024 00:53:20 +0000 X-Zone-Loop: f8f562019877892e28f4de307796e4133887e1d146c0 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/nDmAIunAMh822Ab3QlRZ17KhNOEGW2X/qER3ujbBLM=; b=cDc1FO9+lmy2FZHJfnD9FhXh8d 0Px9utLXjo+myHOjQBPy1q1IPrWBMw2X1uOxJPjj/F7U7CYy6b6tJe+F5egmcI1qQyv1L5iAIgUCa EtVn0ZIkoVCMuwTetY0swH+OcoRssdkzx1JuGbmgUc9Jzs+7MNY16zYaUvH4xW1j/FDwy5l0zSklh /napZj/xzDdoj6q7Du+3UFGtZikDpm7V6Cp1MS0eLTEBqfexynhyaA453wDKgFe2NIMTvALgR049J ZkXmRKsYFqlxcws4pi87WvgtxAsRddj7qGpFtKT6j7z4A4N+M2Vqme1Aa2pJIEcrn24XmJQTPkeys Wh8LuIzQ==; From: Richard Sent To: Maxim Cournoyer Subject: Re: [bug#71561] [PATCH] services: networking: Allow dhcp-client to use a config file In-Reply-To: <87o77zfflt.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 17 Jun 2024 17:01:50 -0400") References: <0888b6afe4003512c452fad2bc88370b007fc0ca.1718387578.git.richard@freakingpenguin.com> <87o77zfflt.fsf@gmail.com> Date: Mon, 17 Jun 2024 20:53:10 -0400 Message-ID: <87ed8vgjgp.fsf@freakingpenguin.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71561 Cc: 71561@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , Florian Pelz , Matthew Trzcinski X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, > Nitpick: The file name should be complete, including the extension. > Pressing 'C' on the diff's hunk while authoring a commit message in > Magit (Emacs) creates a ChangeLog entry automatically, if that helps. Huh, I didn't know that. Good to know, thanks. > I'd perhaps reword this to: > > (dhcp-client-configuration) [config-file]: New field. > (dhcp-client-configuration-config-file): New accessor. I believe these comments have been addressed in v2. I also added another commit to prepend "ISC" in references to DHCP client. This way it should be clearer this service is specific to the ISC's implementation. -- Take it easy, Richard Sent Making my computer weirder one commit at a time. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 18 08:13:18 2024 Received: (at 71561) by debbugs.gnu.org; 18 Jun 2024 12:13:18 +0000 Received: from localhost ([127.0.0.1]:42128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJXi9-00017N-PL for submit@debbugs.gnu.org; Tue, 18 Jun 2024 08:13:17 -0400 Received: from mail-qk1-f173.google.com ([209.85.222.173]:45535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJXi7-000178-3F for 71561@debbugs.gnu.org; Tue, 18 Jun 2024 08:13:16 -0400 Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-79776e3e351so397853185a.3 for <71561@debbugs.gnu.org>; Tue, 18 Jun 2024 05:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718712727; x=1719317527; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=qztkpJ4LS2cF3dVNvVAYcWa5SaZIPZ2zg4dnWh28FTI=; b=FTd1MVtv9NEudslNWc0JCmB5gid3vs30yq8q6FSrZX6wu43E2/yx8iknNcEZX6CmaX rLgrA02DeOQwbFlTTwQhUSEJN2op7Oq7he9bul6eKsF7bNYUxiaptBVaJXeE7Ic8Nd4P 0k/4Rzkw42g0CT4/XCqXtcBy3ZYOLhdC/59XDNXm3YzuSpefLh1nezYh0x4dBqMcHEMq olYoh1SfOKmiei1IOe8yerVuO/tuV6VAGF4TNnm59rKFtOAikdAlMp0loQ8P0U/ufnjV jqrq9MaR9rZIFPllL76eJd+hvLNKoM1X7ZazqDilkZh6lVRZV45/QxYq4ClDqwiaDEDV N3sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718712727; x=1719317527; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qztkpJ4LS2cF3dVNvVAYcWa5SaZIPZ2zg4dnWh28FTI=; b=J7jUUcCKCB1ppcFA3emPE+uZ7TtWCdvdBQCxg8HijF6PBboaq3s2zjT9XFoVX2zE4r o9J/S/x+5wOt3QYOBrN0N7812xRkml8AWNsSFdsir+yqrsYS+bN+cRZumldXhofuNv9u 2249PnPFWrSjZ7YETI2C2jixLx24/6bZFwMP9izVKHyoS8FKk7jFvhHXyMVTWv0JcK28 pBvR8UEdIiNfMir3ar2rRpVFZJmBRWZRsxnIlv4TUwBklds8Nk5uYSZxunb8BoWG5jEN sclWPq4T4CWCJmShqCY3MNfYpUYKMFWUN8Qp0M06SQiBzg4aHK4u/1LWq/k4U3WLrUxt hD/Q== X-Gm-Message-State: AOJu0Yx3Mf9gNPaufvi4Oup2V3ABXhFXzDGXNdzNSzEI/2XFF+K2uLMc pVh65HyHHH8vUEVxoBrJpXU7/acaLph7r7FLyItabAVgvuQasCoP X-Google-Smtp-Source: AGHT+IHf97k6vtC09+gfKPCuggmA+krbpl457mAsSSY6DrYu/IgQaX/kD+rt38gDDOwHc1pjnhAd7w== X-Received: by 2002:a05:620a:394d:b0:795:4971:da30 with SMTP id af79cd13be357-798d243a988mr1529563685a.46.1718712726920; Tue, 18 Jun 2024 05:12:06 -0700 (PDT) Received: from hurd (dsl-152-211.b2b2c.ca. [66.158.152.211]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798abc0ce27sm515185085a.90.2024.06.18.05.12.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 05:12:06 -0700 (PDT) From: Maxim Cournoyer To: Richard Sent Subject: Re: [bug#71561] [PATCH 1/2] services: networking: Allow dhcp-client to use a config file In-Reply-To: (Richard Sent's message of "Mon, 17 Jun 2024 20:49:12 -0400") References: <0888b6afe4003512c452fad2bc88370b007fc0ca.1718387578.git.richard@freakingpenguin.com> Date: Tue, 18 Jun 2024 08:12:05 -0400 Message-ID: <87plsee9gq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71561 Cc: 71561@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , Florian Pelz , Matthew Trzcinski X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Richard Sent writes: > * gnu/services/networking.scm (dhcp-client-configuration) [config-file]: New > field. > (dhcp-client-configuration-config-file): New accessor. > (dhcp-client-shepherd-service): Use the config file when invoking > dhclient if supplied. > * doc/guix.texi: Document it. > > Change-Id: I286de4ddf59c5e606bf1fe0a7510570869e62b1a Reviewed-by: Maxim Cournoyer -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 18 08:13:23 2024 Received: (at 71561) by debbugs.gnu.org; 18 Jun 2024 12:13:23 +0000 Received: from localhost ([127.0.0.1]:42131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJXiF-00017h-1X for submit@debbugs.gnu.org; Tue, 18 Jun 2024 08:13:23 -0400 Received: from mail-oa1-f54.google.com ([209.85.160.54]:53556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJXiD-00017F-3y for 71561@debbugs.gnu.org; Tue, 18 Jun 2024 08:13:21 -0400 Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-254efc9ca45so3367748fac.3 for <71561@debbugs.gnu.org>; Tue, 18 Jun 2024 05:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718712733; x=1719317533; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=FADgu1cYZuBn078lYq71G6C5bQJg4K6k+XSNmeQO/Bk=; b=P2D52+T/pcaA+Ziiwf278mswpq3rZGd+vj8u/WbhCsh42/nTzDarNTIMQ4WCfasFup NJ1vw8ky6BwIvRBpxcOhHKgBvXnr36sWOeCQ3xRVTW6cneTPx4KiskpJBVmULBRG+CWO oOpOssQTCMNHx9ChUEii2HEno6J1WoA/htg6xXAHuoU8BBrXkbu8c7YSUIlrIUYtvYUT Wm424E1bGrNgj3F3/08xxw37im2dKYrSG7vWNMdDZr0fZsxVFt6bhy975zrTUddl1LzW hgfNdGWn5DRRb51yUYPJBlPbzHse/P/wvAIU7BfHw1wgGGN2ObT8KgtMwgpvTEBfoUaB g6wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718712733; x=1719317533; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FADgu1cYZuBn078lYq71G6C5bQJg4K6k+XSNmeQO/Bk=; b=kPSds1jh2ang8U5FovlbJX19SWox2HP1bgTkciEbruJSCWq4DVW9ZFVZcIIO7wGPlz zlE+x+2AQQNFN2ySvQvjMzNl2ZPAwpamOmfBbtWUW9Vhpsn5QtRPrd/M1tOwBxyh9uVX Kt5ub7km9KT6Q2mgllpGDCPTxGwJEdzwpjP4dahBtexYGEOI9NqM3inlFaeDLZTb8rSo qV9BXmlXJJuGRL/JUXfFvLjrTmRP5uBOqd5E8I9ThZERcM9xdSCnlS4wAYxhOqKwGX3t W1FZI7Hsrc0yZMcqDbMI3XQMQQXVb/8Y0lfIdcRJZB1mKSHYh0rYhnTQzZHXeccngoNW crqg== X-Gm-Message-State: AOJu0YzSEWhOlzCa34P9f9BxYcDo7MdP28KPwE3vPIQPlm17UG3OXEhs bHsHM2hgniANUzf0IH6BO4YeL1qjDCzDrbr67C7L1TRCqWIoF+ia X-Google-Smtp-Source: AGHT+IEjW9xvRFzbVrVq1ljNucF1tvd/0aoSorw2zVyPNwUUsEOrDHgAMyNMoVPnFxQa6n/mp6a52A== X-Received: by 2002:a05:6870:c18a:b0:250:831b:49b1 with SMTP id 586e51a60fabf-25842c15e8dmr12873429fac.56.1718712732786; Tue, 18 Jun 2024 05:12:12 -0700 (PDT) Received: from hurd (dsl-152-211.b2b2c.ca. [66.158.152.211]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798abc0ceeesm518684785a.73.2024.06.18.05.12.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 05:12:12 -0700 (PDT) From: Maxim Cournoyer To: Richard Sent Subject: Re: [bug#71561] [PATCH 2/2] doc: Prepend ISC to DHCP client references. In-Reply-To: (Richard Sent's message of "Mon, 17 Jun 2024 20:49:13 -0400") References: Date: Tue, 18 Jun 2024 08:12:11 -0400 Message-ID: <87le32e9gk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71561 Cc: 71561@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , Florian Pelz , Matthew Trzcinski X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Richard Sent writes: > This makes it clearer that this service uses the ISC's dhclient implementation > and does not support DHCP clients that have different command line interfaces. > > * doc/guix.texi (Networking Setup): Prepend ISC to all DHCP client references. > > Change-Id: I750ef2ffb4b23445c4a2b97aaa44eba56458f430 Reviewed-by: Maxim Cournoyer -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 22:16:53 2024 Received: (at 71561-done) by debbugs.gnu.org; 24 Jun 2024 02:16:53 +0000 Received: from localhost ([127.0.0.1]:33661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLZGH-0006bg-7X for submit@debbugs.gnu.org; Sun, 23 Jun 2024 22:16:53 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:58703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLZGF-0006bT-IZ for 71561-done@debbugs.gnu.org; Sun, 23 Jun 2024 22:16:52 -0400 Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-795482e114cso347332785a.1 for <71561-done@debbugs.gnu.org>; Sun, 23 Jun 2024 19:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719195345; x=1719800145; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=TPMSTj/G55APjaHIUsoflu+DM1oacwpJPEsUk/RubRI=; b=eG+Fd8O61N8MHAAx3KuIz+Fp9y4VZA3+yS9pYJ3A+2mXd+dJxIW4mI0MHGqfdWtm/z xQHSJkbWtHP6yHn0tJ54IPEIQ8wDvUa0H7SDKQ/Wdbxkg2JdN4g2LJzmn1YS127JHs0U OKyKz+oFPy0CFgRDtF8ew0NoMmBNJu7hc/2BIZ7w5vNAwsXxhAKk/EXizXs078S74Qna Q5WyX8gceXPc/WQhK3WIm5Eh+6TKoq17js0qFYncUV85IEYx4pRIJwmXbfc9dPHhMoML sAGknDF0KbaQ41bem+s4A/ZMFnSinreY/h8xo1a6wKZpAHLz1HeX4IsP54E711HtBZv/ TYHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719195345; x=1719800145; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TPMSTj/G55APjaHIUsoflu+DM1oacwpJPEsUk/RubRI=; b=von6KsanPoLA+vgb7PG1q8Q9ncUggPZWJ6VPg3v7aHdVOWvfU2qjnrl+mosc1qGOg7 lvOHIdz3Ht1M+PmUZR/OILRKwhCV37o5HV0uLLxWvh8u9pL7Bxk2AmAFCSs796KWWrzU KYGYD/GSNa4Nx7C1CfRYgUswUnT90eFwD06Fm9X/jNo8RGEY/IRk9zjovcwsVtEYK0tX a0T7r18VlY/SdJawKC50/d53cT6y3W4ZYdIT4f6xMIa53Kcy5LttJMkL39DfycrI7FW5 Tl1fq914LkI1fFQV8Cowxal+BdylmDzY8pz3TYyFLUxjpPx/mvjp7mSYFlLBJerGH3wP +JlA== X-Gm-Message-State: AOJu0Yw7pJh1mc7ChdWHSlVSpfJXYq9IifXELA0Wa49h+/LKRGz9wYs1 4N5PMkkNOwYj5SX0RAtJVV4uhP/YX62bxY1SiVvK4zU05Je+zDed X-Google-Smtp-Source: AGHT+IExjHTJ2zDIvNZvHuu4xGjgq8ccxdr/0chV4k5Ica0SGCZG3F/L7AbUqhdr0pSGQdM5K41P/g== X-Received: by 2002:a05:620a:24d6:b0:797:2e94:cc5d with SMTP id af79cd13be357-79be6cc53bemr493874585a.7.1719195345222; Sun, 23 Jun 2024 19:15:45 -0700 (PDT) Received: from hurd (dsl-205-233-124-241.b2b2c.ca. [205.233.124.241]) by smtp.gmail.com with ESMTPSA id af79cd13be357-79bce89a381sm273466385a.3.2024.06.23.19.15.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jun 2024 19:15:44 -0700 (PDT) From: Maxim Cournoyer To: Richard Sent Subject: Re: [bug#71561] [PATCH] services: networking: Allow dhcp-client to use a config file In-Reply-To: <0888b6afe4003512c452fad2bc88370b007fc0ca.1718387578.git.richard@freakingpenguin.com> (Richard Sent's message of "Fri, 14 Jun 2024 13:52:58 -0400") References: <0888b6afe4003512c452fad2bc88370b007fc0ca.1718387578.git.richard@freakingpenguin.com> Date: Sun, 23 Jun 2024 22:15:43 -0400 Message-ID: <87jzif84s0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71561-done Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 71561-done@debbugs.gnu.org, Florian Pelz , Matthew Trzcinski X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Richard Sent writes: > * gnu/services/networking (dhcp-client-configuration): Create > dhcp-client-configuration-config-file. > (dhcp-client-shepherd-service): Use the config file when invoking > dhclient if supplied. > * doc/guix.texi: Document it. > > Change-Id: I286de4ddf59c5e606bf1fe0a7510570869e62b1a Applied, thanks. -- Maxim From unknown Sat Jun 21 10:39:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 22 Jul 2024 11:24:23 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator