GNU bug report logs - #71545
30.0.50; [PATCH] Fix paragraph navigation in Eshell

Previous Next

Package: emacs;

Reported by: Jim Porter <jporterbugs <at> gmail.com>

Date: Fri, 14 Jun 2024 04:35:01 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Done: Jim Porter <jporterbugs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71545 in the body.
You can then email your comments to 71545 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#71545; Package emacs. (Fri, 14 Jun 2024 04:35:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Jim Porter <jporterbugs <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 14 Jun 2024 04:35:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Fix paragraph navigation in Eshell
Date: Thu, 13 Jun 2024 21:33:57 -0700

[Message part 1 (text/plain, inline)]
A while back, I updated how forward- and backward-paragraph work in 
Eshell so that we didn't have to rely on regexps to detect the prompt 
(paragraph navigation in Eshell has always stopped at prompts as well as 
blank lines separating paragraphs). I got that implementation wrong, and 
since then it's only navigated between prompts. Attached is a patch to 
restore the proper behavior, plus some tests to make sure I got it right 
this time.
[0001-Ensure-navigating-by-paragraphs-in-Eshell-stops-at-p.patch (text/plain, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#71545; Package emacs. (Fri, 14 Jun 2024 04:45:02 GMT) Full text and rfc822 format available.

Message #8 received at 71545 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: 71545 <at> debbugs.gnu.org
Subject: Re: bug#71545: 30.0.50; [PATCH] Fix paragraph navigation in Eshell
Date: Thu, 13 Jun 2024 21:42:50 -0700

[Message part 1 (text/plain, inline)]
My previous patch had a typo that snuck in. Here's the fixed version.
[0001-Ensure-navigating-by-paragraphs-in-Eshell-stops-at-p.patch (text/plain, attachment)]
Reply sent to Jim Porter <jporterbugs <at> gmail.com>:
You have taken responsibility. (Fri, 21 Jun 2024 02:11:02 GMT) Full text and rfc822 format available.
Notification sent to Jim Porter <jporterbugs <at> gmail.com>:
bug acknowledged by developer. (Fri, 21 Jun 2024 02:11:02 GMT) Full text and rfc822 format available.

Message #13 received at 71545-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: 71545-done <at> debbugs.gnu.org
Subject: Re: bug#71545: 30.0.50; [PATCH] Fix paragraph navigation in Eshell
Date: Thu, 20 Jun 2024 19:09:23 -0700

On 6/13/2024 9:42 PM, Jim Porter wrote:
> My previous patch had a typo that snuck in. Here's the fixed version.

Merged as e22b072423a to the master branch, and closing this bug.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 20 Jul 2024 11:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified 336 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.