From unknown Sun Aug 17 01:01:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71537: 30.0.50; [PATCH] missing autoload cookies Resent-From: Gerard Vermeulen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jun 2024 15:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71537 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 71537@debbugs.gnu.org X-Debbugs-Original-To: Bug gnu emacs Received: via spool by submit@debbugs.gnu.org id=B.171829076017984 (code B ref -1); Thu, 13 Jun 2024 15:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jun 2024 14:59:20 +0000 Received: from localhost ([127.0.0.1]:59003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHlv5-0004fw-Do for submit@debbugs.gnu.org; Thu, 13 Jun 2024 10:59:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:33826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHlv3-0004fh-2n for submit@debbugs.gnu.org; Thu, 13 Jun 2024 10:59:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHlv3-0007cP-5B for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2024 10:59:17 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHlv0-0002yQ-Pr for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2024 10:59:16 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1E99B240103 for ; Thu, 13 Jun 2024 16:59:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718290748; bh=omdbQ6vnZU9jpHx+/ElEU0fQFbWRdBH+ZivA97VHZmw=; h=MIME-Version:Content-Type:Date:From:To:Subject:Message-ID:From; b=JaCz0Pg5f5MJ8tTWxGJjcj0tDl8eg9viheD+Ry7J8phFjPLnSZocA1HDSzHlD0LBV DS6o08WEVWNTswjADekjEkP9JtnjFVobAte4zb5RF951Iydwo3bYTJ6oBQQ3UPgGgy WIdytaL0YbRTGZw518aPb6zj5wSnv1ReMZn3OpDJlxX5z6pUxhbGKECnElOhZmU9O3 hB7gtZAypGLFU/a/SBmR2W1rjaYmVWB3lT6r67TpadJIIM1CAm8h4GeQbbaJ//Enf1 6OZ+GAWUIAPkC4KaaZcxoEQNg7llNDdWeBTg8XE7lmicNHE9MkIueTQH4mGw+lONqr HCSJg3FQP9Zcg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W0QXp39S3z9rxP for ; Thu, 13 Jun 2024 16:59:06 +0200 (CEST) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_99d14e8cb2fdc2b314a3ae12a266be7e" Date: Thu, 13 Jun 2024 14:59:06 +0000 From: Gerard Vermeulen Message-ID: <6b02899a34d61995765d18f245dd33c5@posteo.net> Received-SPF: pass client-ip=185.67.36.66; envelope-from=gerard.vermeulen@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=_99d14e8cb2fdc2b314a3ae12a266be7e Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hello, I propose the attached patch adding three missing autoload cookies to eliminate two require forms from two sections in my init.el. To eliminate (require 'shortdoc) from the first section: (with-eval-after-load 'help-fns ;; ChatGPT recommends to require `shortdoc' contrary to the ;; `shortdoc-help-fns-examples-function' documentation string. (require 'shortdoc) (add-hook 'help-fns-describe-function-functions #'shortdoc-help-fns-examples-function) (setopt help-enable-symbol-autoload t)) And to eliminate (require 'pulse) from the second section: (require 'pulse) ; since `pulse' does not autoload `pulse-delay' and ; `pulse-iterations'. (defun flash-line-around-point (&rest _) "Flash the line around point." (let ((pulse-iterations 16) (pulse-delay 0.1)) (pulse-momentary-highlight-one-line (point)))) (dolist (command '(scroll-up-command scroll-down-command recenter-top-bottom other-window)) (advice-add command :after #'flash-line-around-point)) Regards -- Gerard --=_99d14e8cb2fdc2b314a3ae12a266be7e Content-Transfer-Encoding: base64 Content-Type: application/octet-stream; name=missing-autoload-cookies.patch Content-Disposition: attachment; filename=missing-autoload-cookies.patch; size=913 ZGlmZiAtLWdpdCBhL2xpc3AvY2VkZXQvcHVsc2UuZWwgYi9saXNwL2NlZGV0L3B1bHNlLmVsCmlu ZGV4IGQ5ZjZhNDA4NjVhLi43Mjg2N2I4NTYyZSAxMDA2NDQKLS0tIGEvbGlzcC9jZWRldC9wdWxz ZS5lbAorKysgYi9saXNwL2NlZGV0L3B1bHNlLmVsCkBAIC05NCwxMSArOTQsMTMgQEAgcHVsc2Ut aGlnaGxpZ2h0LWZhY2UKIAogOzs7IENvZGU6CiAKKzs7OyMjI2F1dG9sb2FkCiAoZGVmY3VzdG9t IHB1bHNlLWl0ZXJhdGlvbnMgMTAKICAgIk51bWJlciBvZiBpdGVyYXRpb25zIGluIGEgcHVsc2Ug b3BlcmF0aW9uLiIKICAgOmdyb3VwICdwdWxzZQogICA6dHlwZSAnbnVtYmVyKQogCis7OzsjIyNh dXRvbG9hZAogKGRlZmN1c3RvbSBwdWxzZS1kZWxheSAuMDMKICAgIkRlbGF5IGJldHdlZW4gZmFj ZSBsaWdodGVuaW5nIGl0ZXJhdGlvbnMuIgogICA6Z3JvdXAgJ3B1bHNlCmRpZmYgLS1naXQgYS9s aXNwL2VtYWNzLWxpc3Avc2hvcnRkb2MuZWwgYi9saXNwL2VtYWNzLWxpc3Avc2hvcnRkb2MuZWwK aW5kZXggYTFlNDliNTA1MTAuLjU0ZmRiYTcwNjc1IDEwMDY0NAotLS0gYS9saXNwL2VtYWNzLWxp c3Avc2hvcnRkb2MuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL3Nob3J0ZG9jLmVsCkBAIC0xNjQ5 LDYgKzE2NDksNyBAQCBzaG9ydGRvYy1mdW5jdGlvbi1leGFtcGxlcwogICAgICBncm91cHMpCiAg ICAgZXhhbXBsZXMpKQogCis7OzsjIyNhdXRvbG9hZAogKGRlZnVuIHNob3J0ZG9jLWhlbHAtZm5z LWV4YW1wbGVzLWZ1bmN0aW9uIChmdW5jdGlvbikKICAgIkluc2VydCBFbWFjcyBMaXNwIGV4YW1w bGVzIGZvciBGVU5DVElPTiBpbnRvIHRoZSBjdXJyZW50IGJ1ZmZlci4KIFlvdSBjYW4gYWRkIHRo aXMgZnVuY3Rpb24gdG8gdGhlIGBoZWxwLWZucy1kZXNjcmliZS1mdW5jdGlvbi1mdW5jdGlvbnMn Cg== --=_99d14e8cb2fdc2b314a3ae12a266be7e-- From unknown Sun Aug 17 01:01:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71537: 30.0.50; [PATCH] missing autoload cookies Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jun 2024 15:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71537 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Gerard Vermeulen Cc: 71537@debbugs.gnu.org Received: via spool by 71537-submit@debbugs.gnu.org id=B71537.171829295925228 (code B ref 71537); Thu, 13 Jun 2024 15:36:02 +0000 Received: (at 71537) by debbugs.gnu.org; 13 Jun 2024 15:35:59 +0000 Received: from localhost ([127.0.0.1]:33566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHmUZ-0006Yo-49 for submit@debbugs.gnu.org; Thu, 13 Jun 2024 11:35:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHmUX-0006YV-C9 for 71537@debbugs.gnu.org; Thu, 13 Jun 2024 11:35:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHmSM-0001RP-4K; Thu, 13 Jun 2024 11:33:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QiydbmUrKmmX3Ok6G2RFT1N6p/wfZrgQVM0z/ZQwQXE=; b=pdMOFSRub8NG qeUtG9PjSJvKe31m0IIHshKpAuW8iTk6cyLiF1q3rnZ4UhxwYzet0gTQCYdJ3gAto9ekGGvjXZKbJ 56XRr1LVvJibdbPX68WvdDOR8UTjpyDU/JNhOc8MB+4AAQTKZLwReeHuLk7mEOzhNzBQ+ojfaUsjl 6lZbfdYHaKVLu4TP3L5dLaDtnQSzGWNmmHX5YnZ7pRo+5YQdrSsQpwLhU09dO58fmC8Q16i+qCsO4 hc6S08pn2ybUQP4EAEKKHOF6drluy2imXc0f7qJ/RphoU6hoeURqZ3LFkUIFoBxNPLAKFYcus9KCM 1B45oPMBeydY3JzgJWqG4g==; Date: Thu, 13 Jun 2024 18:33:37 +0300 Message-Id: <868qz8zwku.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <6b02899a34d61995765d18f245dd33c5@posteo.net> (message from Gerard Vermeulen on Thu, 13 Jun 2024 14:59:06 +0000) References: <6b02899a34d61995765d18f245dd33c5@posteo.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 13 Jun 2024 14:59:06 +0000 > From: Gerard Vermeulen > > I propose the attached patch adding three missing autoload cookies > to eliminate two require forms from two sections in my init.el. > > To eliminate (require 'shortdoc) from the first section: > (with-eval-after-load 'help-fns > ;; ChatGPT recommends to require `shortdoc' contrary to the > ;; `shortdoc-help-fns-examples-function' documentation string. > (require 'shortdoc) > (add-hook 'help-fns-describe-function-functions > #'shortdoc-help-fns-examples-function) > (setopt help-enable-symbol-autoload t)) > > And to eliminate (require 'pulse) from the second section: > (require 'pulse) ; since `pulse' does not autoload `pulse-delay' and > ; `pulse-iterations'. > > (defun flash-line-around-point (&rest _) > "Flash the line around point." > (let ((pulse-iterations 16) > (pulse-delay 0.1)) > (pulse-momentary-highlight-one-line (point)))) > > (dolist (command '(scroll-up-command > scroll-down-command > recenter-top-bottom > other-window)) > (advice-add command :after #'flash-line-around-point)) Thanks, but I don't understand why what we have now constitutes a problem. help-fns loads shortdoc when it needs it, and pulse-momentary-highlight-one-line is autoloaded already (you don't need to auto-load variables to assign values to them). Can you describe the problems you have if you delete those 'require's from your init file, and explain why manually requiring them is a problem? From unknown Sun Aug 17 01:01:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71537: 30.0.50; [PATCH] missing autoload cookies Resent-From: Gerard Vermeulen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jun 2024 20:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71537 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 71537@debbugs.gnu.org Received: via spool by 71537-submit@debbugs.gnu.org id=B71537.171831228130808 (code B ref 71537); Thu, 13 Jun 2024 20:58:02 +0000 Received: (at 71537) by debbugs.gnu.org; 13 Jun 2024 20:58:01 +0000 Received: from localhost ([127.0.0.1]:39343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHrWC-00080p-Rg for submit@debbugs.gnu.org; Thu, 13 Jun 2024 16:58:01 -0400 Received: from mout02.posteo.de ([185.67.36.66]:50887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHrW9-00080Y-GV for 71537@debbugs.gnu.org; Thu, 13 Jun 2024 16:57:59 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id BF272240103 for <71537@debbugs.gnu.org>; Thu, 13 Jun 2024 22:57:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718312271; bh=R7tPVH0+MelfrLPuqt7SYTKQHYEyFbr7o0MQIedLsMI=; h=MIME-Version:Content-Type:Content-Transfer-Encoding:Date:From:To: Cc:Subject:Message-ID:From; b=VBpNEWDi5+SinQh4uxFJrCTbRZWuAF6zT9gRe5syX1onXv2YgfWFyw8ccRcwbZAJB 1KFOPPKfW+SQO1RItJs+RUcsEA5U7JnyrR93kOD4D6DnZhnf/Fjx3QvLuZQJV/3Lek KtF1YFIRxJxj4TdTl/hSWLMDgiHJEexR4swV+vTrG2y5hUYGduBYHHoEZCDEaiwzAa uWwEkaz0V/hQomzvDcbQCrDAP0zx9w4PF+JkJZqke86tyxyghYlqUTKo9T5SH1r4WJ P2C5mWwLS/gsBtSrYApyGvz8E1I3he7dNbI2a7s56Uw+gbVR0Fndiflu+c+2pylcuz g1ZnniLGiaeqg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W0ZVl17Mqz6tsB; Thu, 13 Jun 2024 22:57:51 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Date: Thu, 13 Jun 2024 20:57:50 +0000 From: Gerard Vermeulen In-Reply-To: <868qz8zwku.fsf@gnu.org> References: <6b02899a34d61995765d18f245dd33c5@posteo.net> <868qz8zwku.fsf@gnu.org> Message-ID: <76a8fbc0c826314a440c04d54fc1f71f@posteo.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 13.06.2024 17:33, Eli Zaretskii wrote: >> Date: Thu, 13 Jun 2024 14:59:06 +0000 >> From: Gerard Vermeulen >>=20 >> I propose the attached patch adding three missing autoload cookies >> to eliminate two require forms from two sections in my init.el. >>=20 >> To eliminate (require 'shortdoc) from the first section: >> (with-eval-after-load 'help-fns >> ;; ChatGPT recommends to require `shortdoc' contrary to the >> ;; `shortdoc-help-fns-examples-function' documentation string. >> (require 'shortdoc) >> (add-hook 'help-fns-describe-function-functions >> #'shortdoc-help-fns-examples-function) >> (setopt help-enable-symbol-autoload t)) >>=20 >> And to eliminate (require 'pulse) from the second section: >> (require 'pulse) ; since `pulse' does not autoload `pulse-delay' and >> ; `pulse-iterations'. >>=20 >> (defun flash-line-around-point (&rest _) >> "Flash the line around point." >> (let ((pulse-iterations 16) >> (pulse-delay 0.1)) >> (pulse-momentary-highlight-one-line (point)))) >>=20 >> (dolist (command '(scroll-up-command >> scroll-down-command >> recenter-top-bottom >> other-window)) >> (advice-add command :after #'flash-line-around-point)) >=20 > Thanks, but I don't understand why what we have now constitutes a > problem. help-fns loads shortdoc when it needs it, and > pulse-momentary-highlight-one-line is autoloaded already (you don't > need to auto-load variables to assign values to them). >=20 > Can you describe the problems you have if you delete those 'require's > from your init file, and explain why manually requiring them is a > problem? I try: after deleting those require's: 1. and after doing "M-x describe-function shortdoc" before shortdoc has=20 been (auto)loaded by something else, I get in my message window: help-fns--run-describe-functions: Symbol=E2=80=99s function definition= is=20 void: shortdoc-help-fns-examples-function and the help window does not show (is not created). Addition of an autoload cookie to=20 shortdoc-help-fns-examples-function fixes this. 2. and after calling "other-window" flash-line-around-point gets called, but I get in my message window: byte-code: Defining as dynamic an already lexical var:=20 pulse-iterations and the expected visual effect (a slow - about 2 seconds - flashing=20 of the line containing point) does not show itself. Addition of the=20 two autoload cookies to the two defcustoms pulse-iterations and=20 pulse-delay fixes this. Manually requiring the two requires is not a real problem, but just=20 somewhat inconvenient and surprising in my point of view (FWIW). From unknown Sun Aug 17 01:01:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71537: 30.0.50; [PATCH] missing autoload cookies Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jun 2024 06:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71537 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Gerard Vermeulen Cc: 71537@debbugs.gnu.org Received: via spool by 71537-submit@debbugs.gnu.org id=B71537.17183475351854 (code B ref 71537); Fri, 14 Jun 2024 06:46:02 +0000 Received: (at 71537) by debbugs.gnu.org; 14 Jun 2024 06:45:35 +0000 Received: from localhost ([127.0.0.1]:39641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sI0gp-0000Tq-3x for submit@debbugs.gnu.org; Fri, 14 Jun 2024 02:45:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sI0gm-0000Tc-QP for 71537@debbugs.gnu.org; Fri, 14 Jun 2024 02:45:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sI0eb-0006Bw-V8; Fri, 14 Jun 2024 02:43:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=1TR4/LDB83YsmuTNf0dKACjg+em/Ftsl3gER4DIQ65w=; b=aO6Fjy3cyMsum9s/HnqT 8mKwjymeA8msePD7hZyW2DKkZ4b9X3LtQEuBfki75X1OBst8dmNLo5JJU8c1xI39vuf7BR1oDIa0t lWFMZTCk3fHdkoNGvu8igbdgMvKtaCoMDBRyXFxxkKOn5oPXHRxbQEfSF4k20L9f8DuLa98n14qDC tbvOFNMCToRJRID7ck+2HUjqcVzjyNfLRFzKtyGJTZbvOvl2kEnDh+td4FSJiRvVCEFX2vXfouAUv fmGLJBH1AtrKo3lFTOwhmtwVDjD+2HoT8FO5Jc0owWCYqVYjFHJgbpE5WikHOnzMOd5IL53zPVclU einbJ1mqd9PFTQ==; Date: Fri, 14 Jun 2024 09:43:15 +0300 Message-Id: <86y178xbwc.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <76a8fbc0c826314a440c04d54fc1f71f@posteo.net> (message from Gerard Vermeulen on Thu, 13 Jun 2024 20:57:50 +0000) References: <6b02899a34d61995765d18f245dd33c5@posteo.net> <868qz8zwku.fsf@gnu.org> <76a8fbc0c826314a440c04d54fc1f71f@posteo.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 13 Jun 2024 20:57:50 +0000 > From: Gerard Vermeulen > Cc: 71537@debbugs.gnu.org > > > Thanks, but I don't understand why what we have now constitutes a > > problem. help-fns loads shortdoc when it needs it, and > > pulse-momentary-highlight-one-line is autoloaded already (you don't > > need to auto-load variables to assign values to them). > > > > Can you describe the problems you have if you delete those 'require's > > from your init file, and explain why manually requiring them is a > > problem? > > I try: after deleting those require's: > > 1. and after doing "M-x describe-function shortdoc" before shortdoc has > been > (auto)loaded by something else, I get in my message window: > > help-fns--run-describe-functions: Symbol’s function definition is > void: shortdoc-help-fns-examples-function > > and the help window does not show (is not created). I cannot reproduce this. For me, the *Help* buffer is displayed without any error message. Are you using the latest master branch of the Emacs Git repository? Is this in "emacs -Q"? > 2. and after calling "other-window" flash-line-around-point gets called, > but I get in my message window: > > byte-code: Defining as dynamic an already lexical var: > pulse-iterations You should use setq (or setopt) instead of let-binding. These two variables are user options, so let-binding them is not appropriate. From unknown Sun Aug 17 01:01:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71537: 30.0.50; [PATCH] missing autoload cookies Resent-From: Gerard Vermeulen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jun 2024 08:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71537 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 71537@debbugs.gnu.org Received: via spool by 71537-submit@debbugs.gnu.org id=B71537.171835375113002 (code B ref 71537); Fri, 14 Jun 2024 08:30:02 +0000 Received: (at 71537) by debbugs.gnu.org; 14 Jun 2024 08:29:11 +0000 Received: from localhost ([127.0.0.1]:39893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sI2J5-0003Ne-Ej for submit@debbugs.gnu.org; Fri, 14 Jun 2024 04:29:11 -0400 Received: from mout02.posteo.de ([185.67.36.66]:44765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sI2J3-0003NR-Rk for 71537@debbugs.gnu.org; Fri, 14 Jun 2024 04:29:11 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 8DFBB240103 for <71537@debbugs.gnu.org>; Fri, 14 Jun 2024 10:29:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718353743; bh=PThIQX9YmAs24UTZbVmV82+gY7yprbJ5Kfj3y9niNQc=; h=MIME-Version:Content-Type:Content-Transfer-Encoding:Date:From:To: Cc:Subject:Message-ID:From; b=e2L4NkMQ4KHOfiReUz/oIQjxTcB/hRR7OSUfR8MShk7IktviTpbx9l9jRkv4o+AY+ DPn/WOJOHUuTv8uEUjVCZYYtM1ch4fXkkkWGnDe6+Vwb/KtMYdhLQKiq8aEehmQQFh tjba/DWGcJjPnYwik0dnMZ59uvM8mEyhmxumc+pBjBbU4Icyue7VNt2wO3RouaGoRJ BDzh+MjZASfxxrkR4q3+ZY8CbMni/onF1kAkCCqNGfhrIaHa+d0fgQfmKAPOfBnUQo /4KI8jHIyyubdUv9k+I0StO40RqvBVoHFxrYVovpvSzn5ZC4GDIQlolA7An8c4YoI5 n9uuRwwy7jZ5g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W0srG2l2vz9rxQ; Fri, 14 Jun 2024 10:29:01 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Date: Fri, 14 Jun 2024 08:29:01 +0000 From: Gerard Vermeulen In-Reply-To: <86y178xbwc.fsf@gnu.org> References: <6b02899a34d61995765d18f245dd33c5@posteo.net> <868qz8zwku.fsf@gnu.org> <76a8fbc0c826314a440c04d54fc1f71f@posteo.net> <86y178xbwc.fsf@gnu.org> Message-ID: <45eb2322a2b9b676d0d1b319378d81ed@posteo.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 14.06.2024 08:43, Eli Zaretskii wrote: >> Date: Thu, 13 Jun 2024 20:57:50 +0000 >> From: Gerard Vermeulen >> Cc: 71537@debbugs.gnu.org >>=20 >> > Thanks, but I don't understand why what we have now constitutes a >> > problem. help-fns loads shortdoc when it needs it, and >> > pulse-momentary-highlight-one-line is autoloaded already (you don't >> > need to auto-load variables to assign values to them). >> > >> > Can you describe the problems you have if you delete those 'require's >> > from your init file, and explain why manually requiring them is a >> > problem? >>=20 >> I try: after deleting those require's: >>=20 >> 1. and after doing "M-x describe-function shortdoc" before shortdoc=20 >> has >> been >> (auto)loaded by something else, I get in my message window: >>=20 >> help-fns--run-describe-functions: Symbol=E2=80=99s function definit= ion is >> void: shortdoc-help-fns-examples-function >>=20 >> and the help window does not show (is not created). >=20 > I cannot reproduce this. For me, the *Help* buffer is displayed > without any error message. Are you using the latest master branch of > the Emacs Git repository? Is this in "emacs -Q"? It works in "emacs -Q" in yesterday's master branch. In the process, I figured out what was the issue in my init.el: shortdoc-help-fns-examples-function was the first item in the help-fns-describe-function-functions list and this needs the=20 require. After moving shortdoc-help-fns-examples-function after all=20 help-fns--XXXX functions in the list, everything works fine without the require. >=20 >> 2. and after calling "other-window" flash-line-around-point gets=20 >> called, >> but I get in my message window: >>=20 >> byte-code: Defining as dynamic an already lexical var: >> pulse-iterations >=20 > You should use setq (or setopt) instead of let-binding. These two > variables are user options, so let-binding them is not appropriate. Indeed, it works with setq. Thanks a lot. You can close the bug, as far as I am concerned. From unknown Sun Aug 17 01:01:06 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Gerard Vermeulen Subject: bug#71537: closed (Re: bug#71537: 30.0.50; [PATCH] missing autoload cookies) Message-ID: References: <86plsjyekk.fsf@gnu.org> <6b02899a34d61995765d18f245dd33c5@posteo.net> X-Gnu-PR-Message: they-closed 71537 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 71537@debbugs.gnu.org Date: Fri, 14 Jun 2024 11:01:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1718362862-27833-1" This is a multi-part message in MIME format... ------------=_1718362862-27833-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #71537: 30.0.50; [PATCH] missing autoload cookies which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 71537@debbugs.gnu.org. --=20 71537: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71537 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1718362862-27833-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 71537-done) by debbugs.gnu.org; 14 Jun 2024 11:00:58 +0000 Received: from localhost ([127.0.0.1]:40040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sI4fy-0007EY-0Q for submit@debbugs.gnu.org; Fri, 14 Jun 2024 07:00:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sI4fv-0007EE-Au for 71537-done@debbugs.gnu.org; Fri, 14 Jun 2024 07:00:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sI4fo-0006x7-Vj; Fri, 14 Jun 2024 07:00:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=3LbhgDFGE2MvSxOTfSkilqH1I4HhpbexSVlHhb3/un8=; b=gSfvOnRGtA1orZfrLCAn 0U4YPKQSUIM9n2Orhy+JWhAOai19FJIcqc1LcpaPQO7q2Mn/s8Vv98xei9g1k1eWygbcr+0qnvDcq is9T99GsbFgdNnlsi/zkjKpD6eBB9LXTqRF3uzCIN4Z+pXg7nmbkFjEwzB3iVbyfTgBFyc3QFd/a7 4lLljdLov+pojiWlo0aA4bUCRskvm5E+J3b/j4/HuVi1F1m703nHnyTUjMPcEnCeLGlMvk4FIe1uz +KZxYlp+75S/975j+91LBDEJ0o+8h6ptQR9388O0F7JNg/rx6Uu6I75uHdr2NDfAOI8KF9003ccSK kq56zEuEO/z3Tw==; Date: Fri, 14 Jun 2024 14:00:11 +0300 Message-Id: <86plsjyekk.fsf@gnu.org> From: Eli Zaretskii To: Gerard Vermeulen In-Reply-To: <45eb2322a2b9b676d0d1b319378d81ed@posteo.net> (message from Gerard Vermeulen on Fri, 14 Jun 2024 08:29:01 +0000) Subject: Re: bug#71537: 30.0.50; [PATCH] missing autoload cookies References: <6b02899a34d61995765d18f245dd33c5@posteo.net> <868qz8zwku.fsf@gnu.org> <76a8fbc0c826314a440c04d54fc1f71f@posteo.net> <86y178xbwc.fsf@gnu.org> <45eb2322a2b9b676d0d1b319378d81ed@posteo.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71537-done Cc: 71537-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 14 Jun 2024 08:29:01 +0000 > From: Gerard Vermeulen > Cc: 71537@debbugs.gnu.org > > > > On 14.06.2024 08:43, Eli Zaretskii wrote: > >> Date: Thu, 13 Jun 2024 20:57:50 +0000 > >> From: Gerard Vermeulen > >> Cc: 71537@debbugs.gnu.org > >> > >> > Thanks, but I don't understand why what we have now constitutes a > >> > problem. help-fns loads shortdoc when it needs it, and > >> > pulse-momentary-highlight-one-line is autoloaded already (you don't > >> > need to auto-load variables to assign values to them). > >> > > >> > Can you describe the problems you have if you delete those 'require's > >> > from your init file, and explain why manually requiring them is a > >> > problem? > >> > >> I try: after deleting those require's: > >> > >> 1. and after doing "M-x describe-function shortdoc" before shortdoc > >> has > >> been > >> (auto)loaded by something else, I get in my message window: > >> > >> help-fns--run-describe-functions: Symbol’s function definition is > >> void: shortdoc-help-fns-examples-function > >> > >> and the help window does not show (is not created). > > > > I cannot reproduce this. For me, the *Help* buffer is displayed > > without any error message. Are you using the latest master branch of > > the Emacs Git repository? Is this in "emacs -Q"? > > It works in "emacs -Q" in yesterday's master branch. > > In the process, I figured out what was the issue in my init.el: > > shortdoc-help-fns-examples-function was the first item in > the help-fns-describe-function-functions list and this needs the > require. > > After moving shortdoc-help-fns-examples-function after all > help-fns--XXXX > functions in the list, everything works fine without the require. > > > > >> 2. and after calling "other-window" flash-line-around-point gets > >> called, > >> but I get in my message window: > >> > >> byte-code: Defining as dynamic an already lexical var: > >> pulse-iterations > > > > You should use setq (or setopt) instead of let-binding. These two > > variables are user options, so let-binding them is not appropriate. > > Indeed, it works with setq. > > Thanks a lot. You can close the bug, as far as I am concerned. Done, thanks. ------------=_1718362862-27833-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Jun 2024 14:59:20 +0000 Received: from localhost ([127.0.0.1]:59003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHlv5-0004fw-Do for submit@debbugs.gnu.org; Thu, 13 Jun 2024 10:59:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:33826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHlv3-0004fh-2n for submit@debbugs.gnu.org; Thu, 13 Jun 2024 10:59:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHlv3-0007cP-5B for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2024 10:59:17 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHlv0-0002yQ-Pr for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2024 10:59:16 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1E99B240103 for ; Thu, 13 Jun 2024 16:59:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718290748; bh=omdbQ6vnZU9jpHx+/ElEU0fQFbWRdBH+ZivA97VHZmw=; h=MIME-Version:Content-Type:Date:From:To:Subject:Message-ID:From; b=JaCz0Pg5f5MJ8tTWxGJjcj0tDl8eg9viheD+Ry7J8phFjPLnSZocA1HDSzHlD0LBV DS6o08WEVWNTswjADekjEkP9JtnjFVobAte4zb5RF951Iydwo3bYTJ6oBQQ3UPgGgy WIdytaL0YbRTGZw518aPb6zj5wSnv1ReMZn3OpDJlxX5z6pUxhbGKECnElOhZmU9O3 hB7gtZAypGLFU/a/SBmR2W1rjaYmVWB3lT6r67TpadJIIM1CAm8h4GeQbbaJ//Enf1 6OZ+GAWUIAPkC4KaaZcxoEQNg7llNDdWeBTg8XE7lmicNHE9MkIueTQH4mGw+lONqr HCSJg3FQP9Zcg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W0QXp39S3z9rxP for ; Thu, 13 Jun 2024 16:59:06 +0200 (CEST) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_99d14e8cb2fdc2b314a3ae12a266be7e" Date: Thu, 13 Jun 2024 14:59:06 +0000 From: Gerard Vermeulen To: Bug gnu emacs Subject: 30.0.50; [PATCH] missing autoload cookies Message-ID: <6b02899a34d61995765d18f245dd33c5@posteo.net> Received-SPF: pass client-ip=185.67.36.66; envelope-from=gerard.vermeulen@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=_99d14e8cb2fdc2b314a3ae12a266be7e Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hello, I propose the attached patch adding three missing autoload cookies to eliminate two require forms from two sections in my init.el. To eliminate (require 'shortdoc) from the first section: (with-eval-after-load 'help-fns ;; ChatGPT recommends to require `shortdoc' contrary to the ;; `shortdoc-help-fns-examples-function' documentation string. (require 'shortdoc) (add-hook 'help-fns-describe-function-functions #'shortdoc-help-fns-examples-function) (setopt help-enable-symbol-autoload t)) And to eliminate (require 'pulse) from the second section: (require 'pulse) ; since `pulse' does not autoload `pulse-delay' and ; `pulse-iterations'. (defun flash-line-around-point (&rest _) "Flash the line around point." (let ((pulse-iterations 16) (pulse-delay 0.1)) (pulse-momentary-highlight-one-line (point)))) (dolist (command '(scroll-up-command scroll-down-command recenter-top-bottom other-window)) (advice-add command :after #'flash-line-around-point)) Regards -- Gerard --=_99d14e8cb2fdc2b314a3ae12a266be7e Content-Transfer-Encoding: base64 Content-Type: application/octet-stream; name=missing-autoload-cookies.patch Content-Disposition: attachment; filename=missing-autoload-cookies.patch; size=913 ZGlmZiAtLWdpdCBhL2xpc3AvY2VkZXQvcHVsc2UuZWwgYi9saXNwL2NlZGV0L3B1bHNlLmVsCmlu ZGV4IGQ5ZjZhNDA4NjVhLi43Mjg2N2I4NTYyZSAxMDA2NDQKLS0tIGEvbGlzcC9jZWRldC9wdWxz ZS5lbAorKysgYi9saXNwL2NlZGV0L3B1bHNlLmVsCkBAIC05NCwxMSArOTQsMTMgQEAgcHVsc2Ut aGlnaGxpZ2h0LWZhY2UKIAogOzs7IENvZGU6CiAKKzs7OyMjI2F1dG9sb2FkCiAoZGVmY3VzdG9t IHB1bHNlLWl0ZXJhdGlvbnMgMTAKICAgIk51bWJlciBvZiBpdGVyYXRpb25zIGluIGEgcHVsc2Ug b3BlcmF0aW9uLiIKICAgOmdyb3VwICdwdWxzZQogICA6dHlwZSAnbnVtYmVyKQogCis7OzsjIyNh dXRvbG9hZAogKGRlZmN1c3RvbSBwdWxzZS1kZWxheSAuMDMKICAgIkRlbGF5IGJldHdlZW4gZmFj ZSBsaWdodGVuaW5nIGl0ZXJhdGlvbnMuIgogICA6Z3JvdXAgJ3B1bHNlCmRpZmYgLS1naXQgYS9s aXNwL2VtYWNzLWxpc3Avc2hvcnRkb2MuZWwgYi9saXNwL2VtYWNzLWxpc3Avc2hvcnRkb2MuZWwK aW5kZXggYTFlNDliNTA1MTAuLjU0ZmRiYTcwNjc1IDEwMDY0NAotLS0gYS9saXNwL2VtYWNzLWxp c3Avc2hvcnRkb2MuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL3Nob3J0ZG9jLmVsCkBAIC0xNjQ5 LDYgKzE2NDksNyBAQCBzaG9ydGRvYy1mdW5jdGlvbi1leGFtcGxlcwogICAgICBncm91cHMpCiAg ICAgZXhhbXBsZXMpKQogCis7OzsjIyNhdXRvbG9hZAogKGRlZnVuIHNob3J0ZG9jLWhlbHAtZm5z LWV4YW1wbGVzLWZ1bmN0aW9uIChmdW5jdGlvbikKICAgIkluc2VydCBFbWFjcyBMaXNwIGV4YW1w bGVzIGZvciBGVU5DVElPTiBpbnRvIHRoZSBjdXJyZW50IGJ1ZmZlci4KIFlvdSBjYW4gYWRkIHRo aXMgZnVuY3Rpb24gdG8gdGhlIGBoZWxwLWZucy1kZXNjcmliZS1mdW5jdGlvbi1mdW5jdGlvbnMn Cg== --=_99d14e8cb2fdc2b314a3ae12a266be7e-- ------------=_1718362862-27833-1--