From unknown Mon Jun 16 23:37:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#71502 <71502@debbugs.gnu.org> To: bug#71502 <71502@debbugs.gnu.org> Subject: Status: [PATCH][DOCUMENTATION] doc: Clarify when to use guix style when submitting patches. Reply-To: bug#71502 <71502@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:37:42 +0000 retitle 71502 [PATCH][DOCUMENTATION] doc: Clarify when to use guix style wh= en submitting patches. reassign 71502 guix-patches submitter 71502 altadil severity 71502 normal tag 71502 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 03:45:03 2024 Received: (at submit) by debbugs.gnu.org; 12 Jun 2024 07:45:03 +0000 Received: from localhost ([127.0.0.1]:37455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHIfG-0004Ux-MT for submit@debbugs.gnu.org; Wed, 12 Jun 2024 03:45:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:49290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHIfE-0004UD-GA for submit@debbugs.gnu.org; Wed, 12 Jun 2024 03:45:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHIfF-0002bw-GH for guix-patches@gnu.org; Wed, 12 Jun 2024 03:45:01 -0400 Received: from mail-40130.protonmail.ch ([185.70.40.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHIfD-00012t-Se for guix-patches@gnu.org; Wed, 12 Jun 2024 03:45:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1718178296; x=1718437496; bh=odcsceQxictzCwrxDeO3EiGGQGM25I4hquZZ4LIu644=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=DqpZP284WN8QWnlzUDVoDIn+HNDVOmsW+XS2UySfbmUYDU7rU7+VdI8bVnUoYhhxc JQKtPX8zHYeGyIRbq0cdP0XXz3s8Pq3L5ijz9VZG2yZGbpLURVElPVVy7F8c1gJpSL VFibasaXNFqRpMT8nB955Vayu2Jd6PG0xn/9mu4GFOtAZExHRz/osyIcyVDQyqCk7j rWPkhXOnJLEv+k56dRDQfHo7tHML9n31siwMXZ4RryOJNsW2szqmNTtQCH7LfWBhVn uoJmpVvhpao8xA3EACVtRnWAM6bxcBD45Z4oiY/tQfOKLxtWyR145YHXE0IPvZXZMb TBT40/C+ajw6g== Date: Wed, 12 Jun 2024 07:44:50 +0000 To: guix-patches@gnu.org From: altadil Subject: [PATCH][DOCUMENTATION] doc: Clarify when to use guix style when submitting patches. Message-ID: <20240612074419.13282-1-altadil@protonmail.com> Feedback-ID: 3841829:user:proton X-Pm-Message-ID: b031584ba6ec4445dc4e458d4f1facf4ab74c1c4 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.130; envelope-from=Altadil@protonmail.com; helo=mail-40130.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: submit Cc: altadil X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Make more explicit the need to run guix style for new packages only, not for updates. * doc/contributing.texi (Submitting Patches): clarify the fourth item of the checklist. Change-Id: I69e1a6144b4da4814d2c8d9b44c7f77490183556 --- A newbie like me can easily miss the "new" here and mix guix style with other changes. So let=E2=80=99s make it extra clear. doc/contributing.texi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/contributing.texi b/doc/contributing.texi index b8adc169d8..33ef94bba3 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -1891,8 +1891,10 @@ name of the new or modified package, and fix any err= ors it reports (@pxref{Invoking guix lint}). =20 @item -Run @code{guix style @var{package}} to format the new package definition -according to the project's conventions (@pxref{Invoking guix style}). +For a new package, run @code{guix style @var{package}} to format the packa= ge +definition according to the project's conventions (@pxref{Invoking guix st= yle}). +For an update to an existing package, it=E2=80=99s better to skip this ste= p, as it +would make reviewing the changes harder. =20 @item Make sure the package builds on your platform, using @code{guix build --=20 2.45.1