From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 00:44:32 2024 Received: (at submit) by debbugs.gnu.org; 12 Jun 2024 04:44:32 +0000 Received: from localhost ([127.0.0.1]:37153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHFqZ-0007eb-BF for submit@debbugs.gnu.org; Wed, 12 Jun 2024 00:44:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:59872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH8A9-0005ne-Dy for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:32:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH62o-0006Wx-OK for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 14:16:30 -0400 Received: from wfhigh2-smtp.messagingengine.com ([64.147.123.153]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH62m-0008Q4-DG for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 14:16:30 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfhigh.west.internal (Postfix) with ESMTP id CF3F41800080 for ; Tue, 11 Jun 2024 14:16:24 -0400 (EDT) Received: from imap43 ([10.202.2.93]) by compute3.internal (MEProxy); Tue, 11 Jun 2024 14:16:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm3; t=1718129784; x=1718216184; bh=agdLJUks3zEZZOIiGyzSP9KHoBxb9i6K U6bhR0Hp/W8=; b=E6ELE9MS73RwmbQFT1TPAHGx9JqNce64ovLfnC04wDPCdVw8 YwGGkAMMDyNDFjvfM6Z0fQEt68ax5X/GVJhTUFPgyeXETzvdLGXqAdrG5TdGEwrc tf7zzEoVn0LJ/6L5W386sC6f3PNAq0EqXJ6veToZUAmI7Hotpio4RIbXOxw364Ns 3ckFJV6U6G4DFQaDv39RlEnL0YsmY59atH1XHa5NVRIRox4W1eIwG+Y3spF/1+RG UPE8La4AovCA/mBCUAFioMDeAWlANH/iub5UN3wPux7wCnAJKqijOIUYoui5F8jj 3cKo3mNStwdF2tNT8bo2WLL/cAJo6a4fk8xFOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1718129784; x=1718216184; bh=agdLJUks3zEZZOIiGyzSP9KHoBxb9i6KU6b hR0Hp/W8=; b=JAUhmclMZqXEs7jetwyRRXqLsDSK483ija6qDLe7ywIcg3RFBKD QxdBn58i6txE14vlqyLAheNDQLkOJsBRDExO7qtLTmwe2TYtdVGLWvZhU0H5YhI9 d8rTZRQqf7hygLlstqBq/7Zgf7fTFcBZBzyPya38/P9j5CqOH2iAFKJOF83/7XzG Tojn8bPhAKQQmuNPJ/ET0QYr8x2Ea929tlciYRq/6Q4ubfHs48I1zMjMjJUaCW3T Q0UFXFGWOmQmvdR1s/FlDeeE77INtE/qv4fGFHm6HvrDTir1KSeb/aZaLFbXgkhq WJrjBbpi6ZwAEgTzBHyQAShNo2FDPf2uLIw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeduvddguddvtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkfffhvffutgesmhdtre erreerjeenucfhrhhomhepuehjnphrnhcunfhinhgushhtrhpnmhcuoegskhhhlhesvghl vghkthhruhgsrgguuhhrrdhsvgeqnecuggftrfgrthhtvghrnhepveevleeiveehleeltd fftdfgueeghfeljedtgfelteeihfeuieeileekuedvvedvnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsghkhhhlsegvlhgvkhhtrhhusggrug hurhdrshgv X-ME-Proxy: Feedback-ID: i05c146bc:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id DCEFA2D405A9; Tue, 11 Jun 2024 14:16:23 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-515-g87b2bad5a-fm-20240604.001-g87b2bad5 MIME-Version: 1.0 Message-Id: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> Date: Tue, 11 Jun 2024 20:16:03 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_Lindstr=C3=B6m?= To: bug-gnu-emacs@gnu.org Subject: [PATCH] Make whitespace.el cleanup add missing final newline Content-Type: multipart/mixed; boundary=5341e6259c634780b3b71dbea41e16ae Received-SPF: none client-ip=64.147.123.153; envelope-from=bkhl@elektrubadur.se; helo=wfhigh2-smtp.messagingengine.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 12 Jun 2024 00:44:30 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --5341e6259c634780b3b71dbea41e16ae Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, attaching patch to make the whitespace-cleanup and whitespace-cleanup-re= gion functions add a final newline to a file if whitespace-style contain= s `missing-newline-at-eof I'm aware this somewhat replicates what setting `require-final-newline w= ould do, but I think since whitespace.el with this configuration highlig= hts this as an error, it should also clean it up when asked. Best wishes, Bj=C3=B6rn --5341e6259c634780b3b71dbea41e16ae Content-Disposition: attachment; filename*0="0001-Make-whitespace.el-cleanup-add-missing-final-newline.pat"; filename*1="ch" Content-Type: text/x-patch; name="=?UTF-8?Q?0001-Make-whitespace.el-cleanup-add-missing-final-newline.patc?= =?UTF-8?Q?h?=" Content-Transfer-Encoding: BASE64 RnJvbSA3M2UyMGIzNGMxNjY5YTlkNTJjYmM3MGY0YzAyY2MyNmZhMjNjZjViIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Qmo9QzM9QjZybj0yMExpbmRzdHI9 QzM9QjZtPz0gPGJraGxAZWxla3RydWJhZHVyLnNlPgpEYXRlOiBUdWUsIDExIEp1biAyMDI0 IDE5OjQ5OjU1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gTWFrZSB3aGl0ZXNwYWNlLmVsIGNs ZWFudXAgYWRkIG1pc3NpbmcgZmluYWwgbmV3bGluZQoKKiBsaXNwL3doaXRlc3BhY2UuZWwg KHdoaXRlc3BhY2UtY2xlYW51cC1yZWdpb24pOiBpZiBjbGVhbmluZyB1cCBhdCBlbmQKb2Yg ZmlsZSwgYWRkIG1pc3NpbmcgbmV3bGluZSBpZiBpbmRpY2F0ZWQgYnkgd2hpdGVzcGFjZS1z dHlsZS4KLS0tCiBsaXNwL3doaXRlc3BhY2UuZWwgfCAxMyArKysrKysrKysrKystCiAxIGZp bGUgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdp dCBhL2xpc3Avd2hpdGVzcGFjZS5lbCBiL2xpc3Avd2hpdGVzcGFjZS5lbAppbmRleCBiYzIz YTg3OTRlYi4uYTQxYTc1MjA5MTUgMTAwNjQ0Ci0tLSBhL2xpc3Avd2hpdGVzcGFjZS5lbAor KysgYi9saXNwL3doaXRlc3BhY2UuZWwKQEAgLTE0NjUsNiArMTQ2NSwxMSBAQCBkZWZ1biB3 aGl0ZXNwYWNlLWNsZWFudXAtcmVnaW9uCiAgICBJZiBgd2hpdGVzcGFjZS1zdHlsZScgaW5j bHVkZXMgdGhlIHZhbHVlCiAgICBgc3BhY2UtYWZ0ZXItdGFiOjpzcGFjZScsIHJlcGxhY2Ug VEFCcyBieSBTUEFDRXMuCiAKKzUuIG1pc3NpbmcgbmV3bGluZSBhdCBlbmQgb2YgZmlsZS4K KyAgIElmIGB3aGl0ZXNwYWNlLXN0eWxlJyBpbmNsdWRlcyB0aGUgdmFsdWUgYG1pc3Npbmct bmV3bGluZS1hdC1lb2YnLAorICAgYW5kIHRoZSBjbGVhbnVwIHJlZ2lvbiBpbmNsdWRlcyB0 aGUgZW5kIG9mIGZpbGUsIGFkZCBhIGZpbmFsIG5ld2xpbmUKKyAgIGlmIGl0IGlzIG5vdCB0 aGVyZSBhbHJlYWR5LgorCiBTZWUgYHdoaXRlc3BhY2Utc3R5bGUnLCBgaW5kZW50LXRhYnMt bW9kZScgYW5kIGB0YWItd2lkdGgnIGZvcgogZG9jdW1lbnRhdGlvbi4iCiAgIChpbnRlcmFj dGl2ZSAiQHIiKQpAQCAtMTU0NSw3ICsxNTUwLDEzIEBAIGRlZnVuIHdoaXRlc3BhY2UtY2xl YW51cC1yZWdpb24KICAgICAgICAgICgobWVtcSAnc3BhY2UtYmVmb3JlLXRhYjo6c3BhY2Ug d2hpdGVzcGFjZS1zdHlsZSkKICAgICAgICAgICAod2hpdGVzcGFjZS1yZXBsYWNlLWFjdGlv bgogICAgICAgICAgICAndW50YWJpZnkgcnN0YXJ0IHJlbmQKLSAgICAgICAgICAgd2hpdGVz cGFjZS1zcGFjZS1iZWZvcmUtdGFiLXJlZ2V4cCAyKSkpKQorICAgICAgICAgICB3aGl0ZXNw YWNlLXNwYWNlLWJlZm9yZS10YWItcmVnZXhwIDIpKSkKKyAgICAgICAgOzsgUFJPQkxFTSA1 OiBtaXNzaW5nIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKKyAgICAgICAgKHdoZW4gKGFuZCAo bWVtcSAnbWlzc2luZy1uZXdsaW5lLWF0LWVvZikKKyAgICAgICAgICAgICAgICAgICAoPSAo cG9pbnQtbWF4KSAod2l0aG91dC1yZXN0cmljdGlvbiAocG9pbnQtbWF4KSkpKQorICAgICAg ICAgIChnb3RvLWNoYXIgKHBvaW50LW1heCkpCisgICAgICAgICAgKHdoZW4gKHJlLXNlYXJj aC1iYWNrd2FyZCAiLlxcJyIgbmlsIHQpCisgICAgICAgICAgICAoaW5zZXJ0ICJcbiIpKSkK ICAgICAgIChzZXQtbWFya2VyIHJlbmQgbmlsKSkpKQkJOyBwb2ludCBtYXJrZXIgdG8gbm93 aGVyZQogCiAKLS0gCjIuNDUuMgoK --5341e6259c634780b3b71dbea41e16ae-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 01:21:53 2024 Received: (at 71499) by debbugs.gnu.org; 12 Jun 2024 05:21:53 +0000 Received: from localhost ([127.0.0.1]:37335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHGQi-0000RB-U3 for submit@debbugs.gnu.org; Wed, 12 Jun 2024 01:21:53 -0400 Received: from fout3-smtp.messagingengine.com ([103.168.172.146]:36591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHGQg-0000Qp-RO for 71499@debbugs.gnu.org; Wed, 12 Jun 2024 01:21:51 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfout.nyi.internal (Postfix) with ESMTP id 66DC913800FF for <71499@debbugs.gnu.org>; Wed, 12 Jun 2024 01:21:46 -0400 (EDT) Received: from imap43 ([10.202.2.93]) by compute3.internal (MEProxy); Wed, 12 Jun 2024 01:21:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1718169706; x=1718256106; bh=mBaPCSDPyh 49I/0zvr/YFGVJ4SlocfYbSsJZSyUeTZY=; b=D5C5ON2OxId4bBzGHfSmddw72T xl3rk7T2jqfwxtedE1jT4qk1GGU5IU4MZYiH7SBMmJoJTdhPJz0dLh7ktPmUxFBn +OdB4KxZrx2YUmubTkO9lCjWLe4bpUA/zhvc/t80QRaLVNB5mqM0EEL9Eei9xVgg l+lHKUaA94wmQuutO4qMLUKE0PxpR+wFXSvVczfjmjZEQ+QM0fLLJjJMY3lWHRwV AP48sr4fW4vtFD6hwG/4KQSYpflJDuDN4OVeQ2pVVf7qdvmP4NLXzuSqEsJTYN53 hDRAMTtBDX/1+lhh+3+516z4RqD4NRQTJ2pXfvqcs+xKlDaiTe1rd9SZJBcA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1718169706; x=1718256106; bh=mBaPCSDPyh49I/0zvr/YFGVJ4Slo cfYbSsJZSyUeTZY=; b=Xl9Wa/pDaAX+pobxggOE4ZbpX91S2u9G5QBQi+i9DQ4j WfayqDP7CAMYm4mp3leNHr+Gqek8FJv59Z4DwpOE2P3bxPaM3qcVCKwJlachkqz1 dN8mMHOLhwoHGj5yIL+tHjBavlMFFFeiqxQngJkBnAlh8MtimDLAIPh9GvqXBgcA qy35+b3D930g8KJXZOKIXk4uJTiUeQzUsgITcW13EkhlIqfWIK5NTs6nSS3blhEB bfjKZXlKmBpVbnVeFVe0DZMho3sOCoZTPAFzvuikDz8InW2f3QSBDwR8Jto++q2u Lqku+u3tU56WDHL/LdiBODe7NivqF7ygm7dlcIUHGA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedufedgleduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtsehmtd erreerreejnecuhfhrohhmpeeujhpnrhhnucfnihhnughsthhrnphmuceosghkhhhlsegv lhgvkhhtrhhusggrughurhdrshgvqeenucggtffrrghtthgvrhhnpeettddvjefhleevke fhjeeigfeijeeflefgvedtveffueeufeffudevkeeuueekfeenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegskhhhlhesvghlvghkthhruhgsrg guuhhrrdhsvg X-ME-Proxy: Feedback-ID: i05c146bc:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id DE82A2D405B3; Wed, 12 Jun 2024 01:21:45 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-515-g87b2bad5a-fm-20240604.001-g87b2bad5 MIME-Version: 1.0 Message-Id: <09bb792d-3a3c-46b0-8e42-193f62bc11c2@app.fastmail.com> In-Reply-To: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> Date: Wed, 12 Jun 2024 07:21:04 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_Lindstr=C3=B6m?= To: 71499@debbugs.gnu.org Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline Content-Type: multipart/mixed; boundary=ef95b6c42da54744ab2942a5d8a8894a X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71499 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --ef95b6c42da54744ab2942a5d8a8894a Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Jun 11, 2024, at 20:16, Bj=C3=B6rn Lindstr=C3=B6m wrote: > Hello, > > attaching patch to make the whitespace-cleanup and=20 > whitespace-cleanup-region functions add a final newline to a file if=20 > whitespace-style contains `missing-newline-at-eof > > I'm aware this somewhat replicates what setting `require-final-newline=20 > would do, but I think since whitespace.el with this configuration=20 > highlights this as an error, it should also clean it up when asked. > > Best wishes, > Bj=C3=B6rn > Attachments: > * 0001-Make-whitespace.el-cleanup-add-missing-final-newline.patch Sorry, somehow messed up the first patch I sent, now attaching a correct= ed one. Attaching the correct one here. Best wishes, Bj=C3=B6rn --ef95b6c42da54744ab2942a5d8a8894a Content-Disposition: attachment; filename*0="0001-Make-whitespace.el-cleanup-add-missing-final-newline-2.p"; filename*1="atch" Content-Type: text/x-patch; name="=?UTF-8?Q?0001-Make-whitespace.el-cleanup-add-missing-final-newline-2.pa?= =?UTF-8?Q?tch?=" Content-Transfer-Encoding: BASE64 RnJvbSAzZTE4MDY3NDYwNGY0MWRlNzAxOThjM2FhYTNiMGJjNWNkZGYwYTY4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Qmo9QzM9QjZybj0yMExpbmRzdHI9 QzM9QjZtPz0gPGJraGxAZWxla3RydWJhZHVyLnNlPgpEYXRlOiBUdWUsIDExIEp1biAyMDI0 IDE5OjQ5OjU1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gTWFrZSB3aGl0ZXNwYWNlLmVsIGNs ZWFudXAgYWRkIG1pc3NpbmcgZmluYWwgbmV3bGluZQoKKiBsaXNwL3doaXRlc3BhY2UuZWwg KHdoaXRlc3BhY2UtY2xlYW51cC1yZWdpb24pOiBpZiBjbGVhbmluZyB1cCBhdCBlbmQKb2Yg ZmlsZSwgYWRkIG1pc3NpbmcgbmV3bGluZSBpZiBpbmRpY2F0ZWQgYnkgd2hpdGVzcGFjZS1z dHlsZS4KLS0tCiBsaXNwL3doaXRlc3BhY2UuZWwgfCAxNCArKysrKysrKysrKysrLQogMSBm aWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1n aXQgYS9saXNwL3doaXRlc3BhY2UuZWwgYi9saXNwL3doaXRlc3BhY2UuZWwKaW5kZXggYmMy M2E4Nzk0ZWIuLjZmOGJkMGI4NTg1IDEwMDY0NAotLS0gYS9saXNwL3doaXRlc3BhY2UuZWwK KysrIGIvbGlzcC93aGl0ZXNwYWNlLmVsCkBAIC0xNDY1LDYgKzE0NjUsMTEgQEAgZGVmdW4g d2hpdGVzcGFjZS1jbGVhbnVwLXJlZ2lvbgogICAgSWYgYHdoaXRlc3BhY2Utc3R5bGUnIGlu Y2x1ZGVzIHRoZSB2YWx1ZQogICAgYHNwYWNlLWFmdGVyLXRhYjo6c3BhY2UnLCByZXBsYWNl IFRBQnMgYnkgU1BBQ0VzLgogCis1LiBtaXNzaW5nIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUu CisgICBJZiBgd2hpdGVzcGFjZS1zdHlsZScgaW5jbHVkZXMgdGhlIHZhbHVlIGBtaXNzaW5n LW5ld2xpbmUtYXQtZW9mJywKKyAgIGFuZCB0aGUgY2xlYW51cCByZWdpb24gaW5jbHVkZXMg dGhlIGVuZCBvZiBmaWxlLCBhZGQgYSBmaW5hbCBuZXdsaW5lCisgICBpZiBpdCBpcyBub3Qg dGhlcmUgYWxyZWFkeS4KKwogU2VlIGB3aGl0ZXNwYWNlLXN0eWxlJywgYGluZGVudC10YWJz LW1vZGUnIGFuZCBgdGFiLXdpZHRoJyBmb3IKIGRvY3VtZW50YXRpb24uIgogICAoaW50ZXJh Y3RpdmUgIkByIikKQEAgLTE1NDUsNyArMTU1MCwxNCBAQCBkZWZ1biB3aGl0ZXNwYWNlLWNs ZWFudXAtcmVnaW9uCiAgICAgICAgICAoKG1lbXEgJ3NwYWNlLWJlZm9yZS10YWI6OnNwYWNl IHdoaXRlc3BhY2Utc3R5bGUpCiAgICAgICAgICAgKHdoaXRlc3BhY2UtcmVwbGFjZS1hY3Rp b24KICAgICAgICAgICAgJ3VudGFiaWZ5IHJzdGFydCByZW5kCi0gICAgICAgICAgIHdoaXRl c3BhY2Utc3BhY2UtYmVmb3JlLXRhYi1yZWdleHAgMikpKSkKKyAgICAgICAgICAgd2hpdGVz cGFjZS1zcGFjZS1iZWZvcmUtdGFiLXJlZ2V4cCAyKSkpCisgICAgICAgIDs7IFBST0JMRU0g NTogbWlzc2luZyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCisgICAgICAgICh3aGVuIChhbmQg KG1lbXEgJ21pc3NpbmctbmV3bGluZS1hdC1lb2Ygd2hpdGVzcGFjZS1zdHlsZSkKKyAgICAg ICAgICAgICAgICAgICAoPSAocG9pbnQtbWF4KSAod2l0aG91dC1yZXN0cmljdGlvbiAocG9p bnQtbWF4KSkpKQorICAgICAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1heCkpCisgICAgICAg ICAgKHdoZW4gKHJlLXNlYXJjaC1iYWNrd2FyZCAiLlxcJyIgbmlsIHQpCisgICAgICAgICAg ICAoZ290by1jaGFyIChwb2ludC1tYXgpKQorICAgICAgICAgICAgKGluc2VydCAiXG4iKSkp KQogICAgICAgKHNldC1tYXJrZXIgcmVuZCBuaWwpKSkpCQk7IHBvaW50IG1hcmtlciB0byBu b3doZXJlCiAKIAotLSAKMi40NS4yCgo= --ef95b6c42da54744ab2942a5d8a8894a-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 03:47:02 2024 Received: (at 71499) by debbugs.gnu.org; 12 Jun 2024 07:47:02 +0000 Received: from localhost ([127.0.0.1]:37461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHIhC-0004Yh-AA for submit@debbugs.gnu.org; Wed, 12 Jun 2024 03:47:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHIhA-0004YC-KC for 71499@debbugs.gnu.org; Wed, 12 Jun 2024 03:47:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHIh6-0001XY-5y; Wed, 12 Jun 2024 03:46:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=SzMp2V43CWp/NuLI+u5A7B3Nku9LeCgLsda1uvK35qs=; b=lGYoebTYf/MNd32B/3Ui YswCSwA/qpIKoDgOmIV9ojRHmsGVRyoIR2irAjPwcmcGBQwIsR6YO6JN8WY3KWqhqEasaM5+U3TqW NambmMlHGr4wbF6emUchlhJA7sgqtGOtXHDU8/GlX8IMklBselC8pzTA2inX44XHLkFe5hELyggPC YcuKGb6wlD81ew/oedbyEt//MIm9vmir/teJjmB4tfS64fy/PPCu0FnYaAySR3otD43mOeCn1xTeB T3OmNMTaaSRwff1d2VDlfY2XiD2OhokW61EY2UXSaMRn2dYtU6dLX6u5rL6PcR0HcOJlh5yL3Y2KQ OmNlO1gCq+5g8w==; Date: Wed, 12 Jun 2024 10:46:52 +0300 Message-Id: <86tthy1u37.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Bj=C3=B6rn_Lindstr=C3=B6m?= In-Reply-To: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> (message from =?utf-8?Q?Bj=C3=B6rn_Lindstr=C3=B6m?= on Tue, 11 Jun 2024 20:16:03 +0200) Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71499 Cc: 71499@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 11 Jun 2024 20:16:03 +0200 > From: Björn Lindström > > attaching patch to make the whitespace-cleanup and whitespace-cleanup-region functions add a final newline to a file if whitespace-style contains `missing-newline-at-eof > > I'm aware this somewhat replicates what setting `require-final-newline would do, but I think since whitespace.el with this configuration highlights this as an error, it should also clean it up when asked. This is an incompatible change of behavior on behalf of whitespace-cleanup, so I don't think we can accept it as in this patch (or the next one you sent). Se we'd need some new user option, by default off, to turn on this new feature. Or maybe a new action for whitespace-action? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 05:04:45 2024 Received: (at 71499) by debbugs.gnu.org; 12 Jun 2024 09:04:45 +0000 Received: from localhost ([127.0.0.1]:37574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHJuP-0006dz-BL for submit@debbugs.gnu.org; Wed, 12 Jun 2024 05:04:45 -0400 Received: from fhigh3-smtp.messagingengine.com ([103.168.172.154]:41751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHJuO-0006do-Dd for 71499@debbugs.gnu.org; Wed, 12 Jun 2024 05:04:44 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 17833114012B; Wed, 12 Jun 2024 05:04:40 -0400 (EDT) Received: from imap43 ([10.202.2.93]) by compute3.internal (MEProxy); Wed, 12 Jun 2024 05:04:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1718183080; x=1718269480; bh=c2NzxXkOkdPARn9Tgcz0W1QxWEpXZbvZ/XXJBoAoX7U=; b= qei9+A/NVIQxGrmJ3R2OwL2akFUAPB69mtesGps9dvjEc0oDefnC6/i3+U00SnbL IVw8e/XN4B52KDd1CKsXB5WBOdlDN6M5NkoumytRtbULjKdWzPFSAQeMW+Kanvs8 oJQjsQaKRiH7/IXEmVmliZQ8jvspRf2Q97b+xx+AUXLVkqcfwxAvtSqZN7znIG9d Snyw0oTOJTuvR/2V1Xt7/0ygUvumcmUNdbn+iZRCYqkXsKKh9KM0JigX3LjKEMVr fWy1HNsb1CK1PaYlG9LL+zxTdQjauSKjzRKLeYqHH3D4oVDS31dZnvfgTqdxdC3N hU6sQY5OB3pjiwWmsYLbEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1718183080; x= 1718269480; bh=c2NzxXkOkdPARn9Tgcz0W1QxWEpXZbvZ/XXJBoAoX7U=; b=L DutV0FHEvUP7SnQORvAhN8AyNR39T402IwkxuiWr9l3RDm6iB8amnaqr0+KRC3iQ vcQveKVQhp1498rOhEW6c27SwcL2Eh620JhfZfwd2V3sjzU8ZGpaiF/OCqUU6i32 xnNBBFhDb5FmwntLs6osvCEtqQgLic6Sy9Iiza1RxtunyTC+C9Mh6FwzCEaghhEQ HCLoFBb6H3OzrZ+qFNR2X937m6ExM+21CYagWOJbvC7/GS6iJesbYPvqzhGi5FE/ nF3iKlUDxBA0Zhq/1Hnfmd4h9CZomkYBQoq09W9AxHcsXgEZzJCtC74PMwPMQUEY N/7lFg3X+1IXhJoxHqbHw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedugedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepuehj nphrnhcunfhinhgushhtrhpnmhcuoegskhhhlhesvghlvghkthhruhgsrgguuhhrrdhsvg eqnecuggftrfgrthhtvghrnhephfetheekleetffffhfeifffftdetfeelgfefhefhuddv vddvgefggfffueettddtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepsghkhhhlsegvlhgvkhhtrhhusggrughurhdrshgv X-ME-Proxy: Feedback-ID: i05c146bc:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 87BB52D408B7; Wed, 12 Jun 2024 05:04:39 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-515-g87b2bad5a-fm-20240604.001-g87b2bad5 MIME-Version: 1.0 Message-Id: In-Reply-To: <86tthy1u37.fsf@gnu.org> References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> Date: Wed, 12 Jun 2024 11:04:18 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_Lindstr=C3=B6m?= To: "Eli Zaretskii" Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71499 Cc: 71499@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, Jun 12, 2024, at 09:46, Eli Zaretskii wrote: >> Date: Tue, 11 Jun 2024 20:16:03 +0200 >> From: Bj=C3=B6rn Lindstr=C3=B6m >>=20 >> attaching patch to make the whitespace-cleanup and whitespace-cleanup= -region functions add a final newline to a file if whitespace-style cont= ains `missing-newline-at-eof >>=20 >> I'm aware this somewhat replicates what setting `require-final-newlin= e would do, but I think since whitespace.el with this configuration high= lights this as an error, it should also clean it up when asked. > > This is an incompatible change of behavior on behalf of > whitespace-cleanup, so I don't think we can accept it as in this patch > (or the next one you sent). Se we'd need some new user option, by > default off, to turn on this new feature. Or maybe a new action for > whitespace-action? > > Thanks. Hello, I thought about that, but since whitespace-cleanup generally applies cle= an-up according to white-space style, I thought it was simply an oversig= ht that it doesn't apply a fix when it is set to highlight missing end-o= f-file newline. Adding a separate way to configure this removes the simplicity of config= uring your preferred whitespace-style as a single option. However, If you still disagree I can make another patch somehow maintain= s the old behaviour as the default, so just let me know. Thanks, Bj=C3=B6rn From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 05:41:43 2024 Received: (at 71499) by debbugs.gnu.org; 12 Jun 2024 09:41:43 +0000 Received: from localhost ([127.0.0.1]:37645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHKUA-0007cc-Ka for submit@debbugs.gnu.org; Wed, 12 Jun 2024 05:41:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHKU8-0007cP-JF for 71499@debbugs.gnu.org; Wed, 12 Jun 2024 05:41:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHKU3-0005MN-VS; Wed, 12 Jun 2024 05:41:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=JYUpWJgSNvLYQRdi1RAf9HNMZz0vAmkFUB6I9nRCCe0=; b=GFTbmfYKsuxvH0l/b5Y6 VecKdHEnMoq6czvxhUElu4fHP5RCgMPXurmDeyfRXzYXrO1+wAYNjRbTNVx33Lpg88WI37s3W7L4S PBIKdh9gcXLtkp1uMZDMEGPhsRTc0dX527gAW/r8+j+aW5+AUTPGUs2BByMIp3bTPov3EyghFsyn+ KkK9z5Ii1bSpM/FzG6DSePwbGRFcL50HvjjTgaJwwZlDkq9RiS5s5KT1VuBx9gbGhdBIW9IHRXJpb CWhGmtGxFvokDVD/2vATJd2Scsf6DRYnP6F4cPR4Wmo9nowe6fNF8gUCNAbKbFbNS83StrFZ5ILxv 6tZMAYNr//bDhA==; Date: Wed, 12 Jun 2024 12:41:33 +0300 Message-Id: <86cyom1os2.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Bj=C3=B6rn_Lindstr=C3=B6m?= , Stefan Kangas , Andrea Corallo In-Reply-To: (message from =?utf-8?Q?Bj=C3=B6rn_Lindstr=C3=B6m?= on Wed, 12 Jun 2024 11:04:18 +0200) Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71499 Cc: 71499@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 12 Jun 2024 11:04:18 +0200 > From: Björn Lindström > Cc: 71499@debbugs.gnu.org > > On Wed, Jun 12, 2024, at 09:46, Eli Zaretskii wrote: > >> Date: Tue, 11 Jun 2024 20:16:03 +0200 > >> From: Björn Lindström > >> > > This is an incompatible change of behavior on behalf of > > whitespace-cleanup, so I don't think we can accept it as in this patch > > (or the next one you sent). Se we'd need some new user option, by > > default off, to turn on this new feature. Or maybe a new action for > > whitespace-action? > > > > Thanks. > > Hello, > > I thought about that, but since whitespace-cleanup generally applies clean-up according to white-space style, I thought it was simply an oversight that it doesn't apply a fix when it is set to highlight missing end-of-file newline. > > Adding a separate way to configure this removes the simplicity of configuring your preferred whitespace-style as a single option. > > However, If you still disagree I can make another patch somehow maintains the old behaviour as the default, so just let me know. Let's see what others think, and take it from there. Stefan, Andrea: WDYT about this change? From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 08:40:07 2024 Received: (at 71499) by debbugs.gnu.org; 12 Jun 2024 12:40:07 +0000 Received: from localhost ([127.0.0.1]:37863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHNGo-00014j-Ky for submit@debbugs.gnu.org; Wed, 12 Jun 2024 08:40:07 -0400 Received: from mail-lj1-f177.google.com ([209.85.208.177]:57565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHNGl-000147-TC for 71499@debbugs.gnu.org; Wed, 12 Jun 2024 08:40:05 -0400 Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2ebec2f11b7so21842631fa.2 for <71499@debbugs.gnu.org>; Wed, 12 Jun 2024 05:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718195939; x=1718800739; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=UdFoZJ9owxooVv5834cE5la2qgsdkg+ekEcLnA7GjRc=; b=JdI93uXyWPSWElfE12UrZK3VlB1r6Pl+pcAnA+ZHPVRnzPQfX7tISqYpGE2iCnWZcV CmPKEMsS0MeqYTLbDDP6wPnavmO/gfbAK554DPVaA9jPotKidioG7EIZIqm3mpJKQ16r i3b1RpTqnvSJPef6xtFaQoA7yof1kUm0JLbeERpupcOfAoL0Npjf3W6Jj6I8urPe7iCt rP9T0Z8Y6F8rVRkylsqXmLBMpUhY3m3/8b5b1br6CCW4IU8T9CYC0n3uTWeVKHzn2C+P Dm7ZlM17YB/eFfv6x6E+lGGEPeI31JbBLjZ5a07YYjUE1r3a+/3nx99uyj9HIQTsE3bJ aJFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718195939; x=1718800739; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UdFoZJ9owxooVv5834cE5la2qgsdkg+ekEcLnA7GjRc=; b=pnvryZBVbjlj3snkH77c7ax+/HOFgPdBRTkz9GZdCgK4kg98b754EvkEZnfDPeKmua bGGjGWE8oWP0s6cpUvD8MITLvbGN0/qz5UKKaGovwELUm8LJLS//qRIUr2h9RDXidzmI dlC2av9Jb0jjRRqLLZumSHPVn8ow1PAZPCFvogZy6NipcP1Krg13u+D04msYNNsZ7UEB vYmkhebXO9LRFaijp5aLcOW+gIqYnV41kFO3b4JESc6+dDJ6mT0TwQn/IDAC/JGhHnFg DCYSFwJrP8udXpv2c8j4R6sdHzAce28PjfAZq84kG+a6gQmvaAb2ViwUyqrpX5PKOVQZ DVZQ== X-Gm-Message-State: AOJu0YwWux6KrKuzmsZQ8TRsQyhUpsiBY7X/LChLk230m0CMMTqaP0Ki LxYvb/CHMFpGLkGR4TMxeuelkns+uTrbBiRgtd/1vtWHxNAzIzh416zwv5+mWIcWPUlkjkmW4B0 2jh2pvzZnolG1WeqzQsMB12qXVMg= X-Google-Smtp-Source: AGHT+IGRnkVvU+G9TmCB7ezwz0Kzlky0i+anpaZ9u8geSkOTzQL1sWLHOp5OXXeT72n5+D35zbyM50zaLS+HID/ujbA= X-Received: by 2002:a2e:9b88:0:b0:2eb:120c:1a59 with SMTP id 38308e7fff4ca-2ebfc9d0865mr9987981fa.16.1718195938640; Wed, 12 Jun 2024 05:38:58 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 12 Jun 2024 12:38:57 +0000 From: Stefan Kangas In-Reply-To: <86cyom1os2.fsf@gnu.org> References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> MIME-Version: 1.0 Date: Wed, 12 Jun 2024 12:38:57 +0000 Message-ID: Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline To: Eli Zaretskii , =?UTF-8?B?QmrDtnJuIExpbmRzdHLDtm0=?= , Andrea Corallo Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71499 Cc: 71499@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> I thought about that, but since whitespace-cleanup generally applies >> clean-up according to white-space style, I thought it was simply an >> oversight that it doesn't apply a fix when it is set to highlight >> missing end-of-file newline. >> >> Adding a separate way to configure this removes the simplicity of >> configuring your preferred whitespace-style as a single option. >> >> However, If you still disagree I can make another patch somehow >> maintains the old behaviour as the default, so just let me know. > > Let's see what others think, and take it from there. > > Stefan, Andrea: WDYT about this change? AFAIU, the purpose of whitespace.el is to detect and eventually fix incorrect whitespace, and it has two ways of doing this: - Visual highlighting - Commands to fix problems (`whitespace-report` and `whitespace-cleanup). Since it is mostly configured in the centralized option, `whitespace-style`, it seems natural that if a user wants to detect `missing-newline-at-eof`, she would also want this to be fixed by `whitespace-cleanup`. This seems even more natural given that `whitespace-report` already considers that a problem worthy of reporting. IOW, I tend to agree that this not already being the case looks like an oversight. So I think the existing options are fine, and the patch could go in as-is, despite the fact that it is backwards-incompatible. If users really hate it, I guess we will hear about it and can react. If we want to be really cautious, we might want to consider waiting with this change until Emacs 31. That should provide ample time for people to notice the new behaviour and react. My two cents. BTW, note that we have `require-final-newline` as well, which is what I use here (in combination with `delete-trailing-whitespace` and the third-party package `ws-butler`). From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 13 03:39:01 2024 Received: (at 71499) by debbugs.gnu.org; 13 Jun 2024 07:39:01 +0000 Received: from localhost ([127.0.0.1]:59110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHf2y-0004UY-9N for submit@debbugs.gnu.org; Thu, 13 Jun 2024 03:39:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHf2v-0004U7-T3 for 71499@debbugs.gnu.org; Thu, 13 Jun 2024 03:38:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHf2p-0003Ru-K4; Thu, 13 Jun 2024 03:38:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=6h4og7P64Eao8PVMhIoaxxPxxYg1GW21wtqZyiVknRU=; b=fiBQ1K+mM2I3CP3ps4EW p7awu27DYkJSHMvV1GfABcIY5yRet/LRg7+72y0uXK+4EKEbrb+PrnV29lP8OpIfz29wk4az3aLqQ zcIU/X3VD5+e+hlEoEDhCTnqdSoWsrMKHYrMU1bGUN3XBpG8ZQwvDyTIQrN4OFH6XFge/+GJa87yY K2UDh/44AvBItVWbbOG5Z99M4RfBDYc0U2fWbxjMw4I8STWbiXmhd6JUTZMkwyptpw0HU/TKFRV/5 BpLc68PtWWmKOtxIQB1DC/b9SfRjjBZOaa0bH8M57c8GNgpsm0IxRnYSClLgoF/mgDH6Z85xuYrWt bi0s4crth6yngQ==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sHf2g-0004h0-Ez; Thu, 13 Jun 2024 03:38:50 -0400 From: Andrea Corallo To: Stefan Kangas Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline In-Reply-To: (Stefan Kangas's message of "Wed, 12 Jun 2024 12:38:57 +0000") References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> Date: Thu, 13 Jun 2024 03:38:42 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71499 Cc: Eli Zaretskii , =?utf-8?Q?Bj=C3=B6rn_Lindstr=C3=B6m?= , 71499@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > Eli Zaretskii writes: > >>> I thought about that, but since whitespace-cleanup generally applies >>> clean-up according to white-space style, I thought it was simply an >>> oversight that it doesn't apply a fix when it is set to highlight >>> missing end-of-file newline. >>> >>> Adding a separate way to configure this removes the simplicity of >>> configuring your preferred whitespace-style as a single option. >>> >>> However, If you still disagree I can make another patch somehow >>> maintains the old behaviour as the default, so just let me know. >> >> Let's see what others think, and take it from there. >> >> Stefan, Andrea: WDYT about this change? > > AFAIU, the purpose of whitespace.el is to detect and eventually fix > incorrect whitespace, and it has two ways of doing this: > > - Visual highlighting > - Commands to fix problems (`whitespace-report` and > `whitespace-cleanup). > > Since it is mostly configured in the centralized option, > `whitespace-style`, it seems natural that if a user wants to detect > `missing-newline-at-eof`, she would also want this to be fixed by > `whitespace-cleanup`. This seems even more natural given that > `whitespace-report` already considers that a problem worthy of > reporting. IOW, I tend to agree that this not already being the case > looks like an oversight. > > So I think the existing options are fine, and the patch could go in > as-is, despite the fact that it is backwards-incompatible. If users > really hate it, I guess we will hear about it and can react. > > If we want to be really cautious, we might want to consider waiting with > this change until Emacs 31. That should provide ample time for people > to notice the new behaviour and react. > > My two cents. I'm as well for having the patch in, but I guess would be safer in 31 so we have plenty of time to react if needed. Andrea From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 13 04:31:09 2024 Received: (at 71499) by debbugs.gnu.org; 13 Jun 2024 08:31:09 +0000 Received: from localhost ([127.0.0.1]:34391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHfrQ-0006pG-Sg for submit@debbugs.gnu.org; Thu, 13 Jun 2024 04:31:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHfrN-0006oW-5S for 71499@debbugs.gnu.org; Thu, 13 Jun 2024 04:31:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHfrH-00046Y-SZ; Thu, 13 Jun 2024 04:30:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=RQnkNP6ZUR1cd8jcO2Ur6/mPXWfvTs6f8SOU5G55aVo=; b=XxMUPGM7t4ccrgFzGksf 0o18t+KwtfrTqv5oeOo4LV3lZ22F/hH6g+lQ9h45BWpAWEj1D63Xb30BkpdlMJadsenP9vFzbXAxf dr+HsHDVhAUo3P3KX0SgfIVEe66gvO8GcA+cbcZ/WB+UNhmJq9qfj1zRg8lB7q8Lq9C+KQWTrw0uX /AhkVUPduECW1N4chr0sXyjb4fYLbHGULVzxR0v0ggD8l5TnEnyLo1WzWtWN1pVSAPxc1NNgS3yps cu2Ce1qra/hMFPPQI2U9vCRfjXFEyaaWyBw2VB01/3+P0k2jAjPotSTK91LzzAz8k6qVYtUU/Js0C /nXcMhts4VLIfg==; Date: Thu, 13 Jun 2024 11:30:51 +0300 Message-Id: <86jzitz1l0.fsf@gnu.org> From: Eli Zaretskii To: Andrea Corallo In-Reply-To: (message from Andrea Corallo on Thu, 13 Jun 2024 03:38:42 -0400) Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71499 Cc: 71499@debbugs.gnu.org, stefankangas@gmail.com, bkhl@elektrubadur.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrea Corallo > Cc: Eli Zaretskii , Björn Lindström > , > 71499@debbugs.gnu.org > Date: Thu, 13 Jun 2024 03:38:42 -0400 > > Stefan Kangas writes: > > > Eli Zaretskii writes: > > > >>> I thought about that, but since whitespace-cleanup generally applies > >>> clean-up according to white-space style, I thought it was simply an > >>> oversight that it doesn't apply a fix when it is set to highlight > >>> missing end-of-file newline. > >>> > >>> Adding a separate way to configure this removes the simplicity of > >>> configuring your preferred whitespace-style as a single option. > >>> > >>> However, If you still disagree I can make another patch somehow > >>> maintains the old behaviour as the default, so just let me know. > >> > >> Let's see what others think, and take it from there. > >> > >> Stefan, Andrea: WDYT about this change? > > > > AFAIU, the purpose of whitespace.el is to detect and eventually fix > > incorrect whitespace, and it has two ways of doing this: > > > > - Visual highlighting > > - Commands to fix problems (`whitespace-report` and > > `whitespace-cleanup). > > > > Since it is mostly configured in the centralized option, > > `whitespace-style`, it seems natural that if a user wants to detect > > `missing-newline-at-eof`, she would also want this to be fixed by > > `whitespace-cleanup`. This seems even more natural given that > > `whitespace-report` already considers that a problem worthy of > > reporting. IOW, I tend to agree that this not already being the case > > looks like an oversight. > > > > So I think the existing options are fine, and the patch could go in > > as-is, despite the fact that it is backwards-incompatible. If users > > really hate it, I guess we will hear about it and can react. > > > > If we want to be really cautious, we might want to consider waiting with > > this change until Emacs 31. That should provide ample time for people > > to notice the new behaviour and react. > > > > My two cents. > > I'm as well for having the patch in, but I guess would be safer in 31 so > we have plenty of time to react if needed. OK, thanks. I will then install after the branch is cut. Meanwhile, Björn, I have a few comments to the patch: . it needs a NEWS entry announcing the new feature . is there any reason your code to handle the missing newline is not identical to what the implementation of require-final-newline does? From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 14 08:24:28 2024 Received: (at 71499) by debbugs.gnu.org; 14 Jun 2024 12:24:28 +0000 Received: from localhost ([127.0.0.1]:40097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sI5ym-0003gF-2X for submit@debbugs.gnu.org; Fri, 14 Jun 2024 08:24:28 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:46124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sI5yj-0003fz-TY for 71499@debbugs.gnu.org; Fri, 14 Jun 2024 08:24:27 -0400 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4210aa012e5so20446175e9.0 for <71499@debbugs.gnu.org>; Fri, 14 Jun 2024 05:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718367800; x=1718972600; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=1bEUAtkNvbssaom2GLUVEjItTvs8MmdY6TiGH2MR1VI=; b=CVFuPHtP9QqOMCHuYE9/6Vdeq+Mn2WrQZhJWZer/7z+oL/JxLlNm1MLtBfY7wziH9z /hi2VF27EJf0kEmn5gcchNWVpfUWCy5dJLQ01s/UNCaECQz0ZkQsWIoLjHPDaaU2YbMR 2ZBJbnaWGl1Uast7GQKI7nQFvUu7mZdxB6bcmJgNRvNcvLWqsIKaqSTOQHim0biPqX66 GdUSJH5MUsKnEdl44xOr72oMycpxVXr7Pe/F7JM/KmLNL7fZq3nde5usJkaIsg5aeRCU tozoZtmF48dwPijvCcGQQbDiue6SaY0N58O8e7e8NKkte/LoHi1kQvfDTWekk9gqFhgg rXQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718367800; x=1718972600; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1bEUAtkNvbssaom2GLUVEjItTvs8MmdY6TiGH2MR1VI=; b=DiUPHR+VZ3islmQCJkax7BVyYRCfn+ZyNuS7/DPeRayh48lSuc00AqhQs0kc70NiEg Es19oKFZLvfbapF80svrJiTXWlbzqYi/ZdqKtNERYfT/Co+5mopR3YOrJW9a1YLQJDwn HP36vVnHpoiDKZ2wlIgpG1764+l0c+2c4slmsI8fyTZKXhf+3BQumhhg9F1oSO6+0EaA B0FiEWtp0yfDjVpXeFZhrYFPYU52tw/Y/qzqgSiJdv0iyqnSbLnq/g3E1PhKTr22Y9g1 MJINMLc0CIFWoK2f5WMVhiTvRUT2Ag1nnfC/YjHq71KgLc36C5uE3USlej0RLQuT2/yZ A5EQ== X-Forwarded-Encrypted: i=1; AJvYcCWDuKCQxVE8WpHCmZlvIgmQ9/kf+NI2+EPiIEfQ/IZLhI6aQf+UxA5BaCQtv3xYuJNwwShKP/SejE6tsCIljTUUsh5/bK8= X-Gm-Message-State: AOJu0YxRdLCd8H2h7opEr5SoHTXC1/0MTFz16YiC/ZAG9uGRiJJbS8QK PI4Yt4bI4x+pH9Ep3nxwX8726kO9QxkrrSs8SDjooJkGwzG3PD3T X-Google-Smtp-Source: AGHT+IHfVQ++NgEny4TS+dm8OUl/CDUGqUOa9M5Uc9GH031fWPCj3O7eROkgPR7yQF4LW771/sbhvQ== X-Received: by 2002:a05:600c:1d9f:b0:422:fe45:2629 with SMTP id 5b1f17b1804b1-4230482b87dmr22003965e9.23.1718367799649; Fri, 14 Jun 2024 05:23:19 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422f641a64bsm59399855e9.46.2024.06.14.05.23.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 05:23:18 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline In-Reply-To: <86jzitz1l0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Jun 2024 11:30:51 +0300") References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> Date: Fri, 14 Jun 2024 14:23:17 +0200 Message-ID: <87sexfaf2i.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71499 Cc: Andrea Corallo , 71499@debbugs.gnu.org, bkhl@elektrubadur.se, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 13 Jun 2024 11:30:51 +0300, Eli Zaretskii said: >> I'm as well for having the patch in, but I guess would be safer in 3= 1 so >> we have plenty of time to react if needed. Eli> OK, thanks. I will then install after the branch is cut. Eli> Meanwhile, Bj=C3=B6rn, I have a few comments to the patch: Eli> . it needs a NEWS entry announcing the new feature Eli> . is there any reason your code to handle the missing newline is= not Eli> identical to what the implementation of require-final-newline Eli> does? I=CA=BCm going to chime in and say that, even though I highlight missing newlines at eob, I don=CA=BCt normally set `require-final-newline' to t, because of various reasons involving collaboration with others. So I=CA=BCd have to turn this off once it goes in. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 14 08:53:29 2024 Received: (at 71499) by debbugs.gnu.org; 14 Jun 2024 12:53:29 +0000 Received: from localhost ([127.0.0.1]:40132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sI6Qq-0004Pp-Oc for submit@debbugs.gnu.org; Fri, 14 Jun 2024 08:53:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sI6Qo-0004Pb-9C for 71499@debbugs.gnu.org; Fri, 14 Jun 2024 08:53:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sI6Ob-0002je-D7; Fri, 14 Jun 2024 08:51:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=j8CgUaLw8oIBm75GfjfwzCiSOs1JOa781oCsilsEf+k=; b=oaUb+fY7GNTXZ8BogqVs +TzwSK6PrmIj8TpgHE68tKBJGmw1Y65arnORTq4lo1mnptRFYuaKcgtMyzPNk+gBmpsh2w6t7OLeJ vL42f6IdC6u5GimvC6d9nbEXlhZRPzzaIfJQOOpfWFDozHqQgrGlDZNCdtJVxY1BHm5j78N0dZ4qj THH4y5gcKFY86XYxcoBsVvJu7RszIcS3bSGAX3B3BzUZaiIV4QhWMgaiXnk8Kf8ofAtr27IAuiNpp ZhdqKhVE1FSAW/PAsFZ89yMiD+BRiCd7vJc5Lsr3tkIx1giiM3wNbDYGdyq1g/zQPsfP558BBmhB6 Is2ZbArlroQM3g==; Date: Fri, 14 Jun 2024 15:50:43 +0300 Message-Id: <86ed8zy9gc.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87sexfaf2i.fsf@gmail.com> (message from Robert Pluim on Fri, 14 Jun 2024 14:23:17 +0200) Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> <87sexfaf2i.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71499 Cc: acorallo@gnu.org, 71499@debbugs.gnu.org, bkhl@elektrubadur.se, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: Andrea Corallo , 71499@debbugs.gnu.org, > stefankangas@gmail.com, bkhl@elektrubadur.se > Date: Fri, 14 Jun 2024 14:23:17 +0200 > > >>>>> On Thu, 13 Jun 2024 11:30:51 +0300, Eli Zaretskii said: > >> I'm as well for having the patch in, but I guess would be safer in 31 so > >> we have plenty of time to react if needed. > > Eli> OK, thanks. I will then install after the branch is cut. > > Eli> Meanwhile, Björn, I have a few comments to the patch: > > Eli> . it needs a NEWS entry announcing the new feature > Eli> . is there any reason your code to handle the missing newline is not > Eli> identical to what the implementation of require-final-newline > Eli> does? > > Iʼm going to chime in and say that, even though I highlight missing > newlines at eob, I donʼt normally set `require-final-newline' to t, > because of various reasons involving collaboration with others. So Iʼd > have to turn this off once it goes in. Maybe this feature should take a hint from require-final-newline? From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 20 03:56:33 2024 Received: (at 71499) by debbugs.gnu.org; 20 Jun 2024 07:56:33 +0000 Received: from localhost ([127.0.0.1]:47648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKCem-0000gr-Td for submit@debbugs.gnu.org; Thu, 20 Jun 2024 03:56:33 -0400 Received: from mail-ej1-f53.google.com ([209.85.218.53]:42306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKCek-0000gZ-0O for 71499@debbugs.gnu.org; Thu, 20 Jun 2024 03:56:30 -0400 Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a6e43dad8ecso101687966b.1 for <71499@debbugs.gnu.org>; Thu, 20 Jun 2024 00:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718870120; x=1719474920; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=vDLu1PbkGdMjljarpAZ5/hYv9+1o/4Tnq2JwfRvSDmc=; b=Nv1GhCIo9WK/MnqwTeYS4xtXbohNLbumfvmExFWtJdllsq4XWAmcry/dePjZ8tAkYg Wj2eDgOIvIeTArT9jpDQHVOfezatmhYZrZ0c3TO3v9BhQONJWMCeAn6z5htMApx61aGF 4bR1hUx7yUVRBm/ZBPiCF7yiG5BbPjLMbg/6hoF7Usj8795FjOo83m1YoVrIYkHgTMSv If9+t97NNkG5yQPojrGoEGjVGxJCdUqj0vwh7bY8vwmRXHk3GYENHcQdAqnlSHCBYjmd UJLcQTmBGv3hLL3nkId8aNn7Z8VGZEbhIKhksBnqQ2iOy3BKCVzX/rd3FOuFpPYahzPz Ws7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718870120; x=1719474920; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vDLu1PbkGdMjljarpAZ5/hYv9+1o/4Tnq2JwfRvSDmc=; b=FD3NmR/9TLuP8APKQch4HQBLF/w3Cqt+VXdeZ0qZ/rhGn9WVmQ8Ur1N4DoGTBCXd7+ SJn38D2Bj/TDhwbDP0nF4NkgXkTtFVsmB5v1qCpVmIjp2vvLmxoSYQdZZNzg2rLHxseB NlLY8GeYxN1Yh49W5ti5Zax3w1u93kn7J7Sl5uTg/icaOmRKdn+z1wkVZDBIFlRZl+9p c9+4E2LcjVBcRkV9LyxWJkTTc45oVw2GocAu6EE0RniKN76uB/nnMyPO99RbqR/L+6el dPQPe/r6jt1dXldAi3/1NyoM3PudKWnGNbpz4zAykPUEg7oYarUe1NuHtquu+C+zGemY sT8w== X-Forwarded-Encrypted: i=1; AJvYcCWtxzbuEFvmZPfsRfvjOwsk222uyg+CCz30Ad+gVcOpqTcn3rFtgT2mvnGebwnm5hzyE2HQkQa+lMSArKoQfDiStQQ6+s8= X-Gm-Message-State: AOJu0YyLAogE7WaY62vQLMv5FVDHjpHCZBQk+/6vYV7pYMRvn5YcGJ4P eudRcXl1zTyAR2Rgvwpg+T0jfLBDb4wKoPtw9sYqNwBQQXV86L4S9V0ZPQqmXeEcSrSBjDbcla/ IYJYQJOxvZ8psfp1rvXY1uD64Cu8= X-Google-Smtp-Source: AGHT+IHV5n8MHBfkIa/KzIaCFIUqkPLfzMCzTmSnjJlHmeGgC7e9QJeiH5L7d+/TYI0CRRIKoOfHrVAY2ogPZlQXhCQ= X-Received: by 2002:a17:906:684b:b0:a6f:8f48:5d29 with SMTP id a640c23a62f3a-a6f9506efbcmr487754666b.28.1718870120223; Thu, 20 Jun 2024 00:55:20 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 20 Jun 2024 07:55:19 +0000 From: Stefan Kangas In-Reply-To: <86ed8zy9gc.fsf@gnu.org> References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> <87sexfaf2i.fsf@gmail.com> <86ed8zy9gc.fsf@gnu.org> MIME-Version: 1.0 Date: Thu, 20 Jun 2024 07:55:19 +0000 Message-ID: Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline To: Eli Zaretskii , Robert Pluim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71499 Cc: acorallo@gnu.org, 71499@debbugs.gnu.org, bkhl@elektrubadur.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Robert Pluim >> Cc: Andrea Corallo , 71499@debbugs.gnu.org, >> stefankangas@gmail.com, bkhl@elektrubadur.se >> Date: Fri, 14 Jun 2024 14:23:17 +0200 >> >> >>>>> On Thu, 13 Jun 2024 11:30:51 +0300, Eli Zaretskii s= aid: >> >> I'm as well for having the patch in, but I guess would be safer i= n 31 so >> >> we have plenty of time to react if needed. >> >> Eli> OK, thanks. I will then install after the branch is cut. >> >> Eli> Meanwhile, Bj=C3=B6rn, I have a few comments to the patch: >> >> Eli> . it needs a NEWS entry announcing the new feature >> Eli> . is there any reason your code to handle the missing newline= is not >> Eli> identical to what the implementation of require-final-newli= ne >> Eli> does? >> >> I=CA=BCm going to chime in and say that, even though I highlight missing >> newlines at eob, I don=CA=BCt normally set `require-final-newline' to t, >> because of various reasons involving collaboration with others. So I=CA= =BCd >> have to turn this off once it goes in. Could you explain why you'd need to turn it off? Do you usually use `whitespace-cleanup` on files where you collaborate with others, but then you specifically don't want to ever touch newlines at eob? > Maybe this feature should take a hint from require-final-newline? To my mind, the main use case of this feature would be users that don't want to set `require-final-newline`, instead preferring to make such fixes manually. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 20 04:23:38 2024 Received: (at 71499) by debbugs.gnu.org; 20 Jun 2024 08:23:39 +0000 Received: from localhost ([127.0.0.1]:48420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKD50-0001Y1-H6 for submit@debbugs.gnu.org; Thu, 20 Jun 2024 04:23:38 -0400 Received: from mail-lf1-f41.google.com ([209.85.167.41]:58569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKD4y-0001Xn-LN for 71499@debbugs.gnu.org; Thu, 20 Jun 2024 04:23:38 -0400 Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-52cc5d5179aso973633e87.0 for <71499@debbugs.gnu.org>; Thu, 20 Jun 2024 01:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718871747; x=1719476547; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=6KvR1qujlJHA03nIqpxp4pM10YPGa/cgicCDfNWryRs=; b=BuRGRXlG+tCLVp+bf9KYJXQ47h/l6jaRUHBglpYtb0QN8IUUZYScfckkhnzSkKm7PA Cwf65TI8iIU5uU9xLQmrN6+HLEqATXVMloo8tsrgCEhSWVN3F8r/W8qNm2sNoMNFjd14 ofgPzlae8diIXNivPghdg41IfOdw4ueOheHane8Es0wu3v1oWEbPUgXlNJBzuSjf+1fR /5KOW74N4yy/eRRD2KI5rJRSoP2SzlB2R55yVxx92gIyUexmdQ39paereIDt/Q16tUjS TnHuPJNBR1W38lgO9U+HaQHtogd6SD74GSSTWZgVUdbaYPviuZaMF0j46lFmAeetoJ5F DRhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718871747; x=1719476547; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6KvR1qujlJHA03nIqpxp4pM10YPGa/cgicCDfNWryRs=; b=B4BJWIvZmuOYGJGNp8cxtR+58Am2aE/ACSaIKuotDuokaGU41qcWTb61aaRg47ennN d14fzE3xRTx/0RXWixUjRtJ3T/ThDcJRCHAttuSXCIS1FFs+FMnsiPQ65s9A77Z32o0m vBiP/WWnjz1ypFCjQBshSFfgmThZJw2f170S4G7CW3kVT0XooCyKwNk0hx0NcuaPb6Wf gwlktlKmiv8UPLU5Xp1vM2a0KAmXe0wIdM9x82sTP27i10vO/IfNv4QPZzlCM+mAuz/N xoBY9KZDtiZK3cEwfzWWR7H8+Y/quC6qicGaYJADSpDvBGVVUBPMkdECv4cl9//js9JN SHmw== X-Forwarded-Encrypted: i=1; AJvYcCXwjGEVy7NEN3axKv8zHX8HVIWB7u5Pd4yes/7ZsdAR5s7+wzKOquSJFlPkBBhOp7RpZE5Os+GBVgRUE5nFedszeGz0GF8= X-Gm-Message-State: AOJu0Yz/O4AmtLcDDlIf8oJz942Nko34PlkJ7ftRQn7J5szzgZq6CEUw e/LucbV9eRfcbHIuQHPhx7QXpoI/gCvv8L9c2w8MyCcqdSp8WaZp X-Google-Smtp-Source: AGHT+IEhuBqiwmHZtXN2DT9BcEljVNnM7xNjFcb7+sn82fyhEsOzqhDmHa8e2WnSNBMzwmHbFLOrrA== X-Received: by 2002:a19:8c12:0:b0:52c:99fe:3133 with SMTP id 2adb3069b0e04-52ccaa5a120mr3124520e87.63.1718871746445; Thu, 20 Jun 2024 01:22:26 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d1f6da9sm16576765e9.44.2024.06.20.01.22.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 01:22:25 -0700 (PDT) From: Robert Pluim To: Stefan Kangas Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline In-Reply-To: (Stefan Kangas's message of "Thu, 20 Jun 2024 07:55:19 +0000") References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> <87sexfaf2i.fsf@gmail.com> <86ed8zy9gc.fsf@gnu.org> Date: Thu, 20 Jun 2024 10:22:24 +0200 Message-ID: <87zfrgvxa7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 71499 Cc: Eli Zaretskii , acorallo@gnu.org, 71499@debbugs.gnu.org, bkhl@elektrubadur.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 20 Jun 2024 07:55:19 +0000, Stefan Kangas said: Stefan> Eli Zaretskii writes: >>> From: Robert Pluim >>> Cc: Andrea Corallo , 71499@debbugs.gnu.org, >>> stefankangas@gmail.com, bkhl@elektrubadur.se >>> Date: Fri, 14 Jun 2024 14:23:17 +0200 >>>=20 >>> >>>>> On Thu, 13 Jun 2024 11:30:51 +0300, Eli Zaretskii said: >>> >> I'm as well for having the patch in, but I guess would be safer = in 31 so >>> >> we have plenty of time to react if needed. >>>=20 Eli> OK, thanks. I will then install after the branch is cut. >>>=20 Eli> Meanwhile, Bj=C3=B6rn, I have a few comments to the patch: >>>=20 Eli> . it needs a NEWS entry announcing the new feature Eli> . is there any reason your code to handle the missing newline is n= ot Eli> identical to what the implementation of require-final-newline Eli> does? >>>=20 >>> I=CA=BCm going to chime in and say that, even though I highlight mi= ssing >>> newlines at eob, I don=CA=BCt normally set `require-final-newline' = to t, >>> because of various reasons involving collaboration with others. So = I=CA=BCd >>> have to turn this off once it goes in. Stefan> Could you explain why you'd need to turn it off? Stefan> Do you usually use `whitespace-cleanup` on files where you coll= aborate Stefan> with others, but then you specifically don't want to ever touch= newlines Stefan> at eob? Yes. I guess I could turn off whitespace-cleanup for those files, and complain at those people more loudly :-) . I don=CA=BCt have a strong objection to this feature, so we don=CA=BCt have to add yet-another-config-variable just for me. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 20 04:56:17 2024 Received: (at 71499) by debbugs.gnu.org; 20 Jun 2024 08:56:17 +0000 Received: from localhost ([127.0.0.1]:49194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKDab-0002Xd-FJ for submit@debbugs.gnu.org; Thu, 20 Jun 2024 04:56:17 -0400 Received: from mail-ed1-f42.google.com ([209.85.208.42]:50213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKDaY-0002XJ-Pu for 71499@debbugs.gnu.org; Thu, 20 Jun 2024 04:56:15 -0400 Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-57cc1c00b97so513128a12.0 for <71499@debbugs.gnu.org>; Thu, 20 Jun 2024 01:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718873705; x=1719478505; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=lCSZB+gjSOFey6Pd0pOj4A7w9CACevYTVarnBNWHk5Q=; b=TrACYprmPBRG3fLOcN3+vw+tRBlSLSMIYgbNZMMQSLoDOZkrm+uKP/Co6UlD7gpmb6 W686M8DTEhuCcYvE+ZK0vxoOPMuxq7tjSCmn1vBrDO1TUHSOYUO/fIURS1CblwWtIFBX 9MKC3LpOkodmJuiGoEfjssFqUjZko8juMBtPk4m9Am3OPQcLcPfqls2sJLCNvC9qcen0 NnSJV10TE8eDQ6YIMmCL+vwXaHch5NcKoDT53WdcUXzVvtkPAa4Vb6tFyhMDmIiHSMba vSjAfPLa2pJ+tOQMjyYGNax/gI1lYogMVc8kbo0PmIRdTwq2X5Aave/6U4nLgoA9BzQt Gciw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718873705; x=1719478505; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lCSZB+gjSOFey6Pd0pOj4A7w9CACevYTVarnBNWHk5Q=; b=SCL+8O2aV2UONIZCZ0DWKJk/Dx3z95DxR4RvlEZx3szwWy2AJO2aPb3tWLqt7SP2FZ o8RPxxg9lsFQ4UCS66ETsLmP5kzzEEOobR8LHa5wI/P0ZS29lg988nvhiqG5plBc13jk cz9lEn2/Jqb+pxTY000JVEcGi3jG6fbYOgB5o2DKVEgbsdbzcO9iatuVwrPPIKnxflA7 fKMHqkxzNPu+VRbWtsWLj0GKunXx2hi6hz46BBcV5pf3BxhuiWYFaibVzBKr2nAmJ3rt SWFobR4erzCbm/xDyWnqT9eLDU7ukZE2KUNw4JfzE3DXKyfjqlMQ+5SD37z+yob6SsG3 VRjA== X-Forwarded-Encrypted: i=1; AJvYcCWSWfAbTEs3zGhKkuO85lbrPpHnPs8z2bIQqZCJ57dlbbV/XziwusdXS63/FdwGpWJFmU07vmngb2D/3roGYtgSYUwipbs= X-Gm-Message-State: AOJu0YzS5DgFBRL7SkuOfn0jHI4UXV6LXVue0LgmcRnH48yowWz+qiws rdTGIdJyBRKKAPcfIZRat21TP72bRVJZh4KnmfY1bdLz/EDK1V5/eoQrVE+NZPN3OGXoyLn7s2E 9Vh1BndGE3SHW7I4mJC1ULEXPZDQ= X-Google-Smtp-Source: AGHT+IFyx5jBW9hWxnLpGyqvNiwsnmIzGMOx7Xsh8pqs1keQHfMWSWzPugKVciyVg2mbGqrgoAqR8nGCrW0BGnkfOtE= X-Received: by 2002:a50:d012:0:b0:57c:73a7:da08 with SMTP id 4fb4d7f45d1cf-57d07e6b7a3mr2877995a12.21.1718873705006; Thu, 20 Jun 2024 01:55:05 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 20 Jun 2024 08:55:04 +0000 From: Stefan Kangas In-Reply-To: <87zfrgvxa7.fsf@gmail.com> References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> <87sexfaf2i.fsf@gmail.com> <86ed8zy9gc.fsf@gnu.org> <87zfrgvxa7.fsf@gmail.com> MIME-Version: 1.0 Date: Thu, 20 Jun 2024 08:55:04 +0000 Message-ID: Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline To: Robert Pluim Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71499 Cc: Eli Zaretskii , acorallo@gnu.org, 71499@debbugs.gnu.org, bkhl@elektrubadur.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > Yes. I guess I could turn off whitespace-cleanup for those files, and > complain at those people more loudly :-) . Just to confirm: you still want it highlighted, despite the fact that you're anyways not planning to change it? IOW, you couldn't just customize `whitespace-style` in those directories and have it do what you want? Perhaps we should have `whitespace-disable-cleanups` for these use cases, but it should then allow customizing a list of values similar to the ones in `whitespace-style`. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 20 05:46:58 2024 Received: (at 71499) by debbugs.gnu.org; 20 Jun 2024 09:46:58 +0000 Received: from localhost ([127.0.0.1]:50622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKENe-0004C4-F6 for submit@debbugs.gnu.org; Thu, 20 Jun 2024 05:46:58 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:61862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKENc-0004Bg-LO for 71499@debbugs.gnu.org; Thu, 20 Jun 2024 05:46:57 -0400 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-421bb51d81aso6916435e9.3 for <71499@debbugs.gnu.org>; Thu, 20 Jun 2024 02:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718876747; x=1719481547; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=hFv73TMXNFl7KUtsfBJViC8oQh+cZ9PcH3sUN5bHWLM=; b=fSz1dAFhHRTGjLKWRdLuu1cIwH7UQPVZ8slEHcaENi/5wl3zyk6jmx9S00CA7lj0Mg Bl4ujkHXxYuArwfeFsOjjZPT/6GVSCV7ZsvyI2NJlrgCvwVqGJ7ooWujQ9uanAZuucCx 1UNXg7Iw5RIwcYwMhp53ZOGUszFwtWr8rHFnOYoAq7AH9aVEckxUFdUUw+LFYtdt9NN3 G0xvjmF4xXi/C6jHfVFlpKkwUSEQViU7oWMNewQQ8n/UWBscHgEcgfL7CrlEMLuGl7Ga R5GQH42dF3i7jj24iNulJ8vsbWIG4kwTXaiwkIZ2lskNONg64IVCqNeEsxtIzOpxhNd0 7TJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718876747; x=1719481547; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hFv73TMXNFl7KUtsfBJViC8oQh+cZ9PcH3sUN5bHWLM=; b=E+PmXIUXqvRJu+pX4jM5XITTHo3fkJO2k8r7pQ61/2NQd71r9FIceycaExExBqZhKV 98R9wi4NGaVrR8hZ5aU6QqqVkNbAskh0qWJU/QhMozJ2putIfhyf0tmNvlUbXCDotEyD ujZlHQeSyc1cyVzpiqOZWEvICsqbxCsnERXIdMN4HtIzQC9tppVSHBq7mjmT9TylGWu7 CprxxbeU+5s5XLQ9BHPT+VtOpI2GMJ1zsrN2vXRGCfTxMiFVppDJPkTKLMbNqnw1IK6G wZ6uItvyGakOnqlFjjU+p2hYh6zf7W/Dv1NmXFtya0GYOVAjoII2AROJz7a43w7kQFze bGkA== X-Forwarded-Encrypted: i=1; AJvYcCWD8U2KjEgzYvhJGSfd4Y48twD4hBskot23KFkAr7GjNdx3YVXeKiM9dP2RYM0/KmC23QjR13Yrt9ILbd877gqUgS4yse0= X-Gm-Message-State: AOJu0YxU4pxmfgcvt7IeM45ZgkGVbPE+G7xLbFOdQa2ST5uVeCYh7rSJ 3bco2jK7jWX8vl+I+dIExnoJB8k9EiIi1W6IcbkCtbfrMHO92f75 X-Google-Smtp-Source: AGHT+IH6OvmQNk84KiRAlEnQB7NgJkZPb1pnMTaji3DQ0T8PIhBuvVZ+DR36EgnqiSPvTJ6DzMn/IA== X-Received: by 2002:a05:600c:2299:b0:424:78dd:60a2 with SMTP id 5b1f17b1804b1-42478dd621fmr28654295e9.0.1718876746635; Thu, 20 Jun 2024 02:45:46 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d0bea05sm19723155e9.18.2024.06.20.02.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 02:45:46 -0700 (PDT) From: Robert Pluim To: Stefan Kangas Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline In-Reply-To: (Stefan Kangas's message of "Thu, 20 Jun 2024 08:55:04 +0000") References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> <87sexfaf2i.fsf@gmail.com> <86ed8zy9gc.fsf@gnu.org> <87zfrgvxa7.fsf@gmail.com> Date: Thu, 20 Jun 2024 11:45:45 +0200 Message-ID: <87r0csvtfa.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71499 Cc: Eli Zaretskii , acorallo@gnu.org, 71499@debbugs.gnu.org, bkhl@elektrubadur.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 20 Jun 2024 08:55:04 +0000, Stefan Kangas said: Stefan> Robert Pluim writes: >> Yes. I guess I could turn off whitespace-cleanup for those files, and >> complain at those people more loudly :-) . Stefan> Just to confirm: you still want it highlighted, despite the fac= t that Stefan> you're anyways not planning to change it? IOW, you couldn't ju= st Stefan> customize `whitespace-style` in those directories and have it d= o what Stefan> you want? That=CA=BCs another way I could fix it, but it=CA=BCs fixable just in my co= nfig. Stefan> Perhaps we should have `whitespace-disable-cleanups` for these = use Stefan> cases, but it should then allow customizing a list of values si= milar to Stefan> the ones in `whitespace-style`. Again: let=CA=BCs not overcomplicate this just for my niche case. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 20 07:24:40 2024 Received: (at 71499) by debbugs.gnu.org; 20 Jun 2024 11:24:41 +0000 Received: from localhost ([127.0.0.1]:53044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKFuC-0001Zq-Kr for submit@debbugs.gnu.org; Thu, 20 Jun 2024 07:24:40 -0400 Received: from mail-ed1-f42.google.com ([209.85.208.42]:46151) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKFuA-0001ZX-ED for 71499@debbugs.gnu.org; Thu, 20 Jun 2024 07:24:38 -0400 Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-57d20d89748so671173a12.0 for <71499@debbugs.gnu.org>; Thu, 20 Jun 2024 04:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718882609; x=1719487409; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=p0Z3TpQQrQHKrRSzzIP77m2azYQIa5wtv6fLEbPSB/M=; b=YdAdRDnTiiRvVkJmM7V3FQFR84KG2Zt2qGSpkXdq3UtRXVq2OmFhTc1gypI13fmdGa n4NEaYyZa3jOmNZE5RAW03guS/g+f0TUF7ejQGWtUQ1ag4nfXSLjY5ax0LAVxS7unj9I 25UxGXarhUzI/L9Z480GVq8O91/PMcXgBc8yag5jWiHBskHAYtV2qfEE7ECfVdgI2WBA ZTbJOxYLNBBGinDr2wPo+yLBI4h9cUi92ooZ9ADjrF6bt2H6BjMES66QcsSY42kb2tpB QopHb+sd8LJ7pI6WH683+qYrUD/fw0lJFRSajb/J9BjggW5eIAbHwllRAjErCiPsXz4h 4jiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718882609; x=1719487409; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=p0Z3TpQQrQHKrRSzzIP77m2azYQIa5wtv6fLEbPSB/M=; b=kxdnnUoN/3wNqbMKdBLyWdeZNdXx/XvTAbiXBOUk2bDYylDbwqYr4Q0QKepuNVG8EC 0LYPMxkskov3EMnwv+7n2iFut2nCwEX27xoQrmeg9W37dE9WaVTYIU3YZX1mUod7ijzL LTQ70TBbvi+UXAZk280XkautI9u+L37Rj82dH9db73GdxlWEmT4YA/U+nwBUsP5xO0Fi PW6GGJ8E8cx7FEGULanbt3r5ivsV/615bBADwYrz2eDoDAdzIiIIEOAQ+dCbLIeHNdNE MlmWFB20iX7qpI9u76BGnbZ9FmH8SAJjfp9GKUNzPLIVMOOgrkPRGdmTTpZJEBjgJbb+ gbfQ== X-Forwarded-Encrypted: i=1; AJvYcCWPoW2OVS24Yr7xei3IEYKOhjbyepsnNye1aZNOMjzypX102NJ15rJgzbKnoOw85Rqa21E3K9D4bbNgPh6pjPFt4+9G80M= X-Gm-Message-State: AOJu0YzIr94zJOkqWtLbB3ijAqZvjzME8s2AlnkFCRs5fH+1LuFvYGXP yZAVGyE+5Uc5xypdkiFhN+DKxXFow3UQMTxfjun+Oj3pAq10uGIcGwqpBH7ilpcuCKukPBj4k5T +GsxUM6na+FzfRZCHBkc2lOqp68o= X-Google-Smtp-Source: AGHT+IEWlUgHwxOQ9VgwzdzSB2wxXwoBtycM1GEoK19uxlKK+wm4Du4IoLXKYZztIM/ApZVvxTm5dPAwOvOuPKyV9h4= X-Received: by 2002:a17:907:a646:b0:a6f:5192:6f4d with SMTP id a640c23a62f3a-a6fab60321fmr350562266b.8.1718882608654; Thu, 20 Jun 2024 04:23:28 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 20 Jun 2024 04:23:28 -0700 From: Stefan Kangas In-Reply-To: <87r0csvtfa.fsf@gmail.com> References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> <87sexfaf2i.fsf@gmail.com> <86ed8zy9gc.fsf@gnu.org> <87zfrgvxa7.fsf@gmail.com> <87r0csvtfa.fsf@gmail.com> MIME-Version: 1.0 Date: Thu, 20 Jun 2024 04:23:28 -0700 Message-ID: Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline To: Robert Pluim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71499 Cc: Eli Zaretskii , acorallo@gnu.org, 71499@debbugs.gnu.org, bkhl@elektrubadur.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > That=CA=BCs another way I could fix it, but it=CA=BCs fixable just in my = config. [...] > Again: let=CA=BCs not overcomplicate this just for my niche case. Sounds good to me. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 27 03:37:38 2024 Received: (at 71499) by debbugs.gnu.org; 27 Jun 2024 07:37:38 +0000 Received: from localhost ([127.0.0.1]:40895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMjhK-00061X-2f for submit@debbugs.gnu.org; Thu, 27 Jun 2024 03:37:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMjhI-00061F-0q for 71499@debbugs.gnu.org; Thu, 27 Jun 2024 03:37:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMjh8-0001wS-QV; Thu, 27 Jun 2024 03:37:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=oSlXo2EOcW4nBl1ThFX41MuEtGMgNfQtabNdoe+jZvU=; b=Mv4002mBzVrtfnwRVXMn pP2cCRYCbjohhsWBGVL4+vvZzgyOsYCZ/eBVow/YxvWhFj9qHKQlWVHyJlmPXerG8rUg8nRwWbl3N ZBbCL9Go7yuxLkoyhJS1gaYdiWG44rNt4WoyN3frH7e+MPkI9UjSkojnw32VL8QB7dAGHYX7rKyNd 4FS3Z0zbiGtDVMf+gxiqIWuXSuCImelqet6qlACMpUkdzoGD4Pj2qE36gg0/c4leAPKOHIsEb+9/6 /HvaXM3XAC7KmyXIUbOscHjDVNhMempJdn/luHH7HLx4UABRXxnl4TjMSzbD5quMqgtt+8w/LGCUo iuJT2xSQtsC4bg==; Date: Thu, 27 Jun 2024 10:37:24 +0300 Message-Id: <864j9e7s5n.fsf@gnu.org> From: Eli Zaretskii To: bkhl@elektrubadur.se In-Reply-To: <86jzitz1l0.fsf@gnu.org> (message from Eli Zaretskii on Thu, 13 Jun 2024 11:30:51 +0300) Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71499 Cc: acorallo@gnu.org, 71499@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 71499@debbugs.gnu.org, stefankangas@gmail.com, bkhl@elektrubadur.se > Date: Thu, 13 Jun 2024 11:30:51 +0300 > From: Eli Zaretskii > > Meanwhile, Björn, I have a few comments to the patch: > > . it needs a NEWS entry announcing the new feature > . is there any reason your code to handle the missing newline is not > identical to what the implementation of require-final-newline > does? Ping! Björn, can you please post an updated patch with the above nits taken care of? We can install this now on the master branch. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 29 07:59:31 2024 Received: (at 71499) by debbugs.gnu.org; 29 Jun 2024 11:59:31 +0000 Received: from localhost ([127.0.0.1]:37259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNWjr-0005iH-7a for submit@debbugs.gnu.org; Sat, 29 Jun 2024 07:59:31 -0400 Received: from fhigh8-smtp.messagingengine.com ([103.168.172.159]:53237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNWjp-0005i0-HX for 71499@debbugs.gnu.org; Sat, 29 Jun 2024 07:59:30 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfhigh.nyi.internal (Postfix) with ESMTP id AD8D11140304; Sat, 29 Jun 2024 07:59:24 -0400 (EDT) Received: from imap43 ([10.202.2.93]) by compute3.internal (MEProxy); Sat, 29 Jun 2024 07:59:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1719662364; x=1719748764; bh=n8yKcHBhnq fZHz0J/wJ1CaSKRuHy7pnsK/Qmjqp1qV8=; b=PiML67lOFdmZffhXoTC+h/fa4N zBpIDPcIaPA9hfT+dYWiR8OI5TPyBdOZLEW8DSuko82huVkJQCdehXSducXdePK+ M7+PUK8QQDs0ZYT6msDhmrm8sixQXR100cixlbNF3H4UJirpUFRLJzAD+RiHTrtk HMGKSCgpCtwertayIFAspREy7gd7zcZZiCMGeMld7FGkEYCgR2/jsXgyIS5euOn2 J4m48PveVnUMZhzKszygGRgLnRi/0Y2aqzXdqY7kzsJwsYFrlB2nhD0OH2UxZ8Pt 3DezCYWDuONfS0S4ywFpuobgZUgnCx2KvBe9xO3ZErLgO0FEY404do9cZ6iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1719662364; x=1719748764; bh=n8yKcHBhnqfZHz0J/wJ1CaSKRuHy 7pnsK/Qmjqp1qV8=; b=SwXc+cRg/Tn+VVKASnkW5OmvFrcv5JI9z8MxHty2N1h9 3q0dmjP7LavkftTOJi0t6oer4ctfTeLJtX4YYT71bqV8B4MWO52gwU7YlwOr2TtK 1jQPl8vdS/YIjxlbxu1MbCsTPISWqAaDjkV8+h8QNXy5cvT3JZcvtOtT9Zjj7XYv dQytTJbVsWKf0Lfi4RKLX5eOTtj4iPSNdWQp3pSTYXqBaMBQRPvMpnbS4hodyHbw 5HEnd/xWME0uHSSsRro3r2GiGPg83+6K6Xj3alWAK/r4tXGNmQbJLShfNmIUJwiK nXdXpBnOsaIw4BhbYrjcjulCuV8Cya1x4Hz8mNHDtA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrtdelgdegkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehmtderreerreejnecuhfhrohhmpeeujhpnrhhn ucfnihhnughsthhrnphmuceosghkhhhlsegvlhgvkhhtrhhusggrughurhdrshgvqeenuc ggtffrrghtthgvrhhnpedtheefteduuefgfeegudfflefggefgudeiffehiefggfektdfg ieefffdthefgteenucffohhmrghinhepvghlrdhithenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegskhhhlhesvghlvghkthhruhgsrgguuhhr rdhsvg X-ME-Proxy: Feedback-ID: i05c146bc:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 429832D4007D; Sat, 29 Jun 2024 07:59:24 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-538-g1508afaa2-fm-20240616.001-g1508afaa MIME-Version: 1.0 Message-Id: <690f2378-fa81-48bf-a780-3ee9ad59e579@app.fastmail.com> In-Reply-To: <864j9e7s5n.fsf@gnu.org> References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> <864j9e7s5n.fsf@gnu.org> Date: Sat, 29 Jun 2024 13:59:03 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_Lindstr=C3=B6m?= To: "Eli Zaretskii" , 71499@debbugs.gnu.org Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline Content-Type: multipart/mixed; boundary=fcc8120cc54144519a26de39c7f7fcda X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71499 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --fcc8120cc54144519a26de39c7f7fcda Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, updated patch attached, which ads a note to NEWS, and has a changed impl= ementation of the insertion of missing newline inspired by the one from = files.el. It's still slightly different to account for it also being pos= sible to use on a region. This time there's also an added test. / Bj=C3=B6rn On Thu, Jun 27, 2024, at 09:37, Eli Zaretskii wrote: >> Cc: 71499@debbugs.gnu.org, stefankangas@gmail.com, bkhl@elektrubadur.= se >> Date: Thu, 13 Jun 2024 11:30:51 +0300 >> From: Eli Zaretskii >>=20 >> Meanwhile, Bj=C3=B6rn, I have a few comments to the patch: >>=20 >> . it needs a NEWS entry announcing the new feature >> . is there any reason your code to handle the missing newline is not >> identical to what the implementation of require-final-newline >> does? > > Ping! Bj=C3=B6rn, can you please post an updated patch with the above= nits > taken care of? We can install this now on the master branch. --fcc8120cc54144519a26de39c7f7fcda Content-Disposition: attachment; filename*0="0001-Make-whitespace.el-cleanup-add-missing-final-newline.pat"; filename*1="ch" Content-Type: text/x-patch; name="=?UTF-8?Q?0001-Make-whitespace.el-cleanup-add-missing-final-newline.patc?= =?UTF-8?Q?h?=" Content-Transfer-Encoding: BASE64 RnJvbSBhNmNhNzk4NGRmM2VlYzgwZThhMzZkZWQ3M2QwNjgwNzNkOWE1YTBiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Qmo9QzM9QjZybj0yMExpbmRzdHI9 QzM9QjZtPz0gPGJraGxAZWxla3RydWJhZHVyLnNlPgpEYXRlOiBUdWUsIDExIEp1biAyMDI0 IDE5OjQ5OjU1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gTWFrZSB3aGl0ZXNwYWNlLmVsIGNs ZWFudXAgYWRkIG1pc3NpbmcgZmluYWwgbmV3bGluZQoKKiBsaXNwL3doaXRlc3BhY2UuZWwg KHdoaXRlc3BhY2UtY2xlYW51cC1yZWdpb24pOiBpZiBjbGVhbmluZyB1cCBhdCBlbmQKb2Yg ZmlsZSwgYWRkIG1pc3NpbmcgbmV3bGluZSBpZiBpbmRpY2F0ZWQgYnkgd2hpdGVzcGFjZS1z dHlsZS4KLS0tCiBldGMvTkVXUyAgICAgICAgICAgICAgICAgICAgICB8ICA2ICsrKysrKwog bGlzcC93aGl0ZXNwYWNlLmVsICAgICAgICAgICAgfCAxNiArKysrKysrKysrKysrKystCiB0 ZXN0L2xpc3Avd2hpdGVzcGFjZS10ZXN0cy5lbCB8IDE1ICsrKysrKysrKysrKysrLQogMyBm aWxlcyBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggYWYzMmE5M2Q5YzQuLjlmNjFhNGFh NGNlIDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMzYsNiArMzYs MTIgQEAgYXBwbGllcywgYW5kIHBsZWFzZSBhbHNvIHVwZGF0ZSBkb2NzdHJpbmdzIGFzIG5l ZWRlZC4KIAwKICogQ2hhbmdlcyBpbiBTcGVjaWFsaXplZCBNb2RlcyBhbmQgUGFja2FnZXMg aW4gRW1hY3MgMzEuMQogCistLS0KKyoqIFdoaXRlc3BhY2UKKyd3aGl0ZXNwYWNlLWNsZWFu dXAnIG5vdyBhZGRzIG1pc3NpbmcgbmV3bGluZSBhdCBlbmQgb2YgZmlsZSBJZgorJ3doaXRl c3BhY2Utc3R5bGUnIGluY2x1ZGVzICdtaXNzaW5nLW5ld2xpbmUtYXQtZW9mICh3aGljaCBp cyB0aGUKK2RlZmF1bHQpLCB0aGUgJ3doaXRlc3BhY2UtY2xlYW51cCcgZnVuY3Rpb24gd2ls bCBmaXggdGhpcyB3aGVuIHJ1bi4KKwogDAogKiBOZXcgTW9kZXMgYW5kIFBhY2thZ2VzIGlu IEVtYWNzIDMxLjEKIApkaWZmIC0tZ2l0IGEvbGlzcC93aGl0ZXNwYWNlLmVsIGIvbGlzcC93 aGl0ZXNwYWNlLmVsCmluZGV4IGJjMjNhODc5NGViLi4yOGQxMzFiMDU0YyAxMDA2NDQKLS0t IGEvbGlzcC93aGl0ZXNwYWNlLmVsCisrKyBiL2xpc3Avd2hpdGVzcGFjZS5lbApAQCAtMTQ2 NSw2ICsxNDY1LDExIEBAIGRlZnVuIHdoaXRlc3BhY2UtY2xlYW51cC1yZWdpb24KICAgIElm IGB3aGl0ZXNwYWNlLXN0eWxlJyBpbmNsdWRlcyB0aGUgdmFsdWUKICAgIGBzcGFjZS1hZnRl ci10YWI6OnNwYWNlJywgcmVwbGFjZSBUQUJzIGJ5IFNQQUNFcy4KIAorNS4gbWlzc2luZyBu ZXdsaW5lIGF0IGVuZCBvZiBmaWxlLgorICAgSWYgYHdoaXRlc3BhY2Utc3R5bGUnIGluY2x1 ZGVzIHRoZSB2YWx1ZSBgbWlzc2luZy1uZXdsaW5lLWF0LWVvZicsCisgICBhbmQgdGhlIGNs ZWFudXAgcmVnaW9uIGluY2x1ZGVzIHRoZSBlbmQgb2YgZmlsZSwgYWRkIGEgZmluYWwgbmV3 bGluZQorICAgaWYgaXQgaXMgbm90IHRoZXJlIGFscmVhZHkuCisKIFNlZSBgd2hpdGVzcGFj ZS1zdHlsZScsIGBpbmRlbnQtdGFicy1tb2RlJyBhbmQgYHRhYi13aWR0aCcgZm9yCiBkb2N1 bWVudGF0aW9uLiIKICAgKGludGVyYWN0aXZlICJAciIpCkBAIC0xNTQ1LDcgKzE1NTAsMTYg QEAgZGVmdW4gd2hpdGVzcGFjZS1jbGVhbnVwLXJlZ2lvbgogICAgICAgICAgKChtZW1xICdz cGFjZS1iZWZvcmUtdGFiOjpzcGFjZSB3aGl0ZXNwYWNlLXN0eWxlKQogICAgICAgICAgICh3 aGl0ZXNwYWNlLXJlcGxhY2UtYWN0aW9uCiAgICAgICAgICAgICd1bnRhYmlmeSByc3RhcnQg cmVuZAotICAgICAgICAgICB3aGl0ZXNwYWNlLXNwYWNlLWJlZm9yZS10YWItcmVnZXhwIDIp KSkpCisgICAgICAgICAgIHdoaXRlc3BhY2Utc3BhY2UtYmVmb3JlLXRhYi1yZWdleHAgMikp KQorICAgICAgICA7OyBQUk9CTEVNIDU6IG1pc3NpbmcgbmV3bGluZSBhdCBlbmQgb2YgZmls ZQorICAgICAgICAoYW5kIChtZW1xICdtaXNzaW5nLW5ld2xpbmUtYXQtZW9mIHdoaXRlc3Bh Y2Utc3R5bGUpCisgICAgICAgICAgICAgKD4gKHBvaW50LW1heCkgKHBvaW50LW1pbikpCisg ICAgICAgICAgICAgKD0gKHBvaW50LW1heCkgKHdpdGhvdXQtcmVzdHJpY3Rpb24gKHBvaW50 LW1heCkpKQorICAgICAgICAgICAgICgvPSAoY2hhci1iZWZvcmUgKHBvaW50LW1heCkpID9c bikKKyAgICAgICAgICAgICAobm90IChhbmQgKGVxIHNlbGVjdGl2ZS1kaXNwbGF5IHQpCisg ICAgICAgICAgICAgICAgICAgICAgICg9IChjaGFyLWJlZm9yZSAocG9pbnQtbWF4KSkgP1xy KSkpCisgICAgICAgICAgICAgKGdvdG8tY2hhciAocG9pbnQtbWF4KSkKKyAgICAgICAgICAg ICAoaWdub3JlLWVycm9ycyAoaW5zZXJ0ICJcbiIpKSkpCiAgICAgICAoc2V0LW1hcmtlciBy ZW5kIG5pbCkpKSkJCTsgcG9pbnQgbWFya2VyIHRvIG5vd2hlcmUKIAogCmRpZmYgLS1naXQg YS90ZXN0L2xpc3Avd2hpdGVzcGFjZS10ZXN0cy5lbCBiL3Rlc3QvbGlzcC93aGl0ZXNwYWNl LXRlc3RzLmVsCmluZGV4IDczYzdlNzQyZWM1Li5iZDM1YjNhYzlmMyAxMDA2NDQKLS0tIGEv dGVzdC9saXNwL3doaXRlc3BhY2UtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL3doaXRlc3Bh Y2UtdGVzdHMuZWwKQEAgLTgsNyArOCw2IEBACiA7OyBpdCB1bmRlciB0aGUgdGVybXMgb2Yg dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQogOzsgdGhl IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgZWl0aGVyIHZlcnNpb24gMyBvZiB0aGUgTGlj ZW5zZSwgb3IKIDs7IChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCi0KIDs7 IEdOVSBFbWFjcyBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUg dXNlZnVsLAogOzsgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhl IGltcGxpZWQgd2FycmFudHkgb2YKIDs7IE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZP UiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKQEAgLTk0LDYgKzkzLDIwIEBAIGRl ZnVuIHdoaXRlc3BhY2UtdGVzdHMtLWNsZWFudXAtc3RyaW5nCiAgICAgKHNob3VsZCAoZXF1 YWwgKHdoaXRlc3BhY2UtdGVzdHMtLWNsZWFudXAtc3RyaW5nICJhICBcblx0IFxuXG4iKQog ICAgICAgICAgICAgICAgICAgICJhICBcbiIpKSkpCiAKKyhlcnQtZGVmdGVzdCB3aGl0ZXNw YWNlLWNsZWFudXAtbWlzc2luZy1uZXdsaW5lLWF0LWVvZiAoKQorICAobGV0ICgod2hpdGVz cGFjZS1zdHlsZSAnKGVtcHR5IG1pc3NpbmctbmV3bGluZS1hdC1lb2YpKSkKKyAgICAoc2hv dWxkIChlcXVhbCAod2hpdGVzcGFjZS10ZXN0cy0tY2xlYW51cC1zdHJpbmcgIiIpCisgICAg ICAgICAgICAgICAgICAgIiIpKQorICAgIChzaG91bGQgKGVxdWFsICh3aGl0ZXNwYWNlLXRl c3RzLS1jbGVhbnVwLXN0cmluZyAiYSIpCisgICAgICAgICAgICAgICAgICAgImFcbiIpKQor ICAgIChzaG91bGQgKGVxdWFsICh3aGl0ZXNwYWNlLXRlc3RzLS1jbGVhbnVwLXN0cmluZyAi YVxuXHQiKQorICAgICAgICAgICAgICAgICAgICJhXG4iKSkKKyAgICAoc2hvdWxkIChlcXVh bCAod2hpdGVzcGFjZS10ZXN0cy0tY2xlYW51cC1zdHJpbmcgImFcblx0ICIpCisgICAgICAg ICAgICAgICAgICAgImFcbiIpKQorICAgIChzaG91bGQgKGVxdWFsICh3aGl0ZXNwYWNlLXRl c3RzLS1jbGVhbnVwLXN0cmluZyAiYVxuXHQgIikKKyAgICAgICAgICAgICAgICAgICAiYVxu IikpCisgICAgKHNob3VsZCAoZXF1YWwgKHdoaXRlc3BhY2UtdGVzdHMtLWNsZWFudXAtc3Ry aW5nICJcblx0IikKKyAgICAgICAgICAgICAgICAgICAiIikpKSkKIAogOzsgV2UgY2Fubm90 IGNhbGwgd2hpdGVzcGFjZS1tb2RlIGJlY2F1c2UgaXQgd2lsbCBkbyBub3RoaW5nIGluIGJh dGNoCiA7OyBtb2RlLiAgU28gd2UgY2FsbCBpdHMgaW5uYXJkcyBpbnN0ZWFkLgotLSAKMi40 NS4yCgo= --fcc8120cc54144519a26de39c7f7fcda-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 29 09:05:33 2024 Received: (at 71499-done) by debbugs.gnu.org; 29 Jun 2024 13:05:34 +0000 Received: from localhost ([127.0.0.1]:37436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNXll-0007cO-NQ for submit@debbugs.gnu.org; Sat, 29 Jun 2024 09:05:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNXlk-0007cB-Dl for 71499-done@debbugs.gnu.org; Sat, 29 Jun 2024 09:05:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNXlf-0001LX-29; Sat, 29 Jun 2024 09:05:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=DJBm2aQ6ecozdKLfz+NqYRDfpXuqKRFrM2OenkzS8gM=; b=sIIC4axXdbokBIExJ9Zd 3qEmgqnmxIjrNy8Z0Fow0ocssaEy9bUybtUX1slzYNhIgwrmlaAPfz7t1JuNv+InFzN5xGh4PV1i1 UeeRsiScgQLPjckilyhrRf2faj1xMjbiiYVRr2ia7CDnZ50goPmz1tR+J9i5rL6JLkn+UNxT8IVut sX4dmqErcU1AaaX3aebJ9vTByaueAUgbu917N1N7H34KUFRE7ZNSRcX8AahaOknw1T7stmbKA7sLD o4EB+0VhgZGn1wx4i3+aF5x/4b20woLZqbHEH4Vn+/z8A6wSPgcPu7Q4zr7lSdVUh26VIyn+4dIIG EJ3xDopbHEJykw==; Date: Sat, 29 Jun 2024 16:05:23 +0300 Message-Id: <86msn3j3vw.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Bj=C3=B6rn_Lindstr=C3=B6m?= In-Reply-To: <690f2378-fa81-48bf-a780-3ee9ad59e579@app.fastmail.com> (message from =?utf-8?Q?Bj=C3=B6rn_Lindstr=C3=B6m?= on Sat, 29 Jun 2024 13:59:03 +0200) Subject: Re: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> <864j9e7s5n.fsf@gnu.org> <690f2378-fa81-48bf-a780-3ee9ad59e579@app.fastmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71499-done Cc: 71499-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 29 Jun 2024 13:59:03 +0200 > From: Björn Lindström > > updated patch attached, which ads a note to NEWS, and has a changed implementation of the insertion of missing newline inspired by the one from files.el. It's still slightly different to account for it also being possible to use on a region. > > This time there's also an added test. Thanks, installed on the master branch, and closing the bug. From unknown Wed Aug 20 03:37:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 28 Jul 2024 11:24:21 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator