From unknown Sat Aug 16 21:20:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71490: [PATCH] ; Fix customisation buffer for dired group Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2024 20:42:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 71490@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171813848724167 (code B ref -1); Tue, 11 Jun 2024 20:42:03 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jun 2024 20:41:27 +0000 Received: from localhost ([127.0.0.1]:36745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH8J4-0006Hd-TH for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:41:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:47004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH8BO-0005td-9Y for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:33:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGuAD-0004z7-7t for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 01:35:21 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGuAA-00047n-LY for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 01:35:20 -0400 Received: by mail-pf1-x443.google.com with SMTP id d2e1a72fcca58-70417a6c328so2929487b3a.1 for ; Mon, 10 Jun 2024 22:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718084116; x=1718688916; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=wpf70kR5fsKYrIaiQSznV/ZC+PZoIJw+NKflqmGm8Lw=; b=R1rVUFdOHCKTmNh8bigOBDm+HF34ukP1BGhn/nbtTNKze/tM8TPw/UkzRUvvZUhTYS PwPRtNTE38Icf/5T/W6Uw/PiJ6nqD8bRuDTORpxZxD0289HALmabmBbj/7o8kwqHiRfk RfS4XpA2S6kzXudeRCBax09wS1RY5hs+09aU9nQkJVSLvED+likopz2cd4GyOkE8Mnri N9YR1+PogGdMtoziw/dQ1UJe85QCjsA33VdiJhyLCjsEBFdC7vHZCftLxwWGn18eitF7 GIIMPa33u2dT7GOvYy/Z7ul0jrkJxzgHcao+7dBlOhP5134voUTqdjjeI4JdalgG9MwR PzWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718084116; x=1718688916; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wpf70kR5fsKYrIaiQSznV/ZC+PZoIJw+NKflqmGm8Lw=; b=jjvfzps7oga4ldb0OxCxj4wGLj61eoh2I3zdeD/BinMk2+6ptdAgR7sDcFYyGHp9GJ mYByK6ta+2H2NASPd+kNQf9fLvp7rg5a8T9BvfcqdICGJYYtgUDgnL9w01nuBjpEIMlU tQXuyDRWnREW9PdGH/AoNSqoc6YFgxyMg0LgB1X93kIAR7SGHODPma9nVft1Kx9ZHxXO 9snAnAkqsyhq3mZR8h6KYc+VgsstFMhEPW20Z7tf+09zmflRbYeXEypWhMU4kCeIHCXj HSXlDs5F2QvfREu7ELdRW2wnCpMkb15TW1VNDt/yJvZykGxr+0kyAgRBQD/64nAQn9+X whlQ== X-Gm-Message-State: AOJu0YytmxTL8V7uC9OuqqHRrLyOtZgB+kZwNFEYw6IqzfdafUeBwQvK Wg1qDqS+juib2VCofMyA5D+Z1+hMelo/lMmpFEww/jMbfAcRbP8lYanilgBY X-Google-Smtp-Source: AGHT+IEdwScZQYVn9ZRfRWICAABnTgfM8vpgZBSjHJfbiA/OWaQhVe97GRc1iUFKwbS2wsl91DX2tg== X-Received: by 2002:a05:6a20:2443:b0:1b6:a1c1:b8ca with SMTP id adf61e73a8af0-1b6a1c1ba19mr5380298637.47.1718084115397; Mon, 10 Jun 2024 22:35:15 -0700 (PDT) Received: from localhost ([103.232.241.147]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f7029c5d63sm40714405ad.299.2024.06.10.22.35.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 22:35:14 -0700 (PDT) From: Visuwesh Date: Tue, 11 Jun 2024 11:05:12 +0530 Message-ID: <87h6e059f3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=visuweshm@gmail.com; helo=mail-pf1-x443.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Tags: patch To reproduce, 1. emacs -Q 2. M-x customize-group RET dired RET 3. Click the triangle of Dired Create Destination Dirs On Trailing Dirsep Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.51.188.17 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (visuweshm[at]gmail.com) 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [103.232.241.147 listed in zen.spamhaus.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Tags: patch To reproduce, 1. emacs -Q 2. M-x customize-group RET dired RET 3. Click the triangle of Dired Create Destination Dirs On Trailing Dirsep Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.51.188.17 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (visuweshm[at]gmail.com) 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [103.232.241.147 listed in zen.spamhaus.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain Tags: patch To reproduce, 1. emacs -Q 2. M-x customize-group RET dired RET 3. Click the triangle of Dired Create Destination Dirs On Trailing Dirsep In GNU Emacs 30.0.50 (build 8, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.0, Xaw scroll bars) of 2024-05-07 built on astatine Repository revision: 4b31074f5f49898ba0499a2b617cad425750eafa Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101011 System Description: Debian GNU/Linux trixie/sid Configured using: 'configure --with-sound=alsa --with-x-toolkit=lucid --with-json --without-xaw3d --without-gconf --without-libsystemd --with-cairo --with-xft' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Fix-customisation-buffer-for-dired-group.patch >From 628afa281e1c050a9fe49a4c362b1572c439c4d2 Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Tue, 11 Jun 2024 10:51:39 +0530 Subject: [PATCH] ; Fix customisation buffer for dired group * lisp/dired-aux.el (dired-create-destination-dirs-on-trailing-dirsep): Actually concat the string. --- lisp/dired-aux.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index a2ce3083cfe..a0fa1ce6fe5 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -2218,14 +2218,14 @@ dired-create-destination-dirs-on-trailing-dirsep trailing /) is given or this option or `dired-create-destination-dirs' is nil, `old_name' will be renamed to `new_name'." - :type '(choice + :type `(choice (const :tag - (concat "Do not treat destination dirs with a " - "trailing directory separator specially") + ,(concat "Do not treat destination dirs with a " + "trailing directory separator specially") nil) (const :tag - (concat "Treat destination dirs with trailing " - "directory separator specially") + ,(concat "Treat destination dirs with trailing " + "directory separator specially") t)) :group 'dired :version "29.1") -- 2.43.0 --=-=-=-- From unknown Sat Aug 16 21:20:43 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Visuwesh Subject: bug#71490: closed (Re: bug#71490: [PATCH] ; Fix customisation buffer for dired group) Message-ID: References: <87h6e059f3.fsf@gmail.com> X-Gnu-PR-Message: they-closed 71490 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 71490@debbugs.gnu.org Date: Tue, 11 Jun 2024 21:29:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1718141342-29306-1" This is a multi-part message in MIME format... ------------=_1718141342-29306-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #71490: [PATCH] ; Fix customisation buffer for dired group which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 71490@debbugs.gnu.org. --=20 71490: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71490 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1718141342-29306-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 71490-done) by debbugs.gnu.org; 11 Jun 2024 21:28:27 +0000 Received: from localhost ([127.0.0.1]:36917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH92Z-0007bs-DR for submit@debbugs.gnu.org; Tue, 11 Jun 2024 17:28:27 -0400 Received: from mail-ed1-f44.google.com ([209.85.208.44]:54480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH92X-0007be-Ah for 71490-done@debbugs.gnu.org; Tue, 11 Jun 2024 17:28:25 -0400 Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-57a1fe6392eso9112750a12.0 for <71490-done@debbugs.gnu.org>; Tue, 11 Jun 2024 14:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718141241; x=1718746041; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=8q+CwV9P38gVma8siKr6BIFHbUTXibDYisPIn0EdWz8=; b=fNnwkiVSAxdqT2So7B0vS3ofTeGNY+f89vogX+35hfO+qBHhDtJJt8Q08QNljA8ti1 pVAI6s0m0GShfssbeZRUosWpj/+4+1MxTVYkU8u3s7eYG2P6DKg93omJKj3CrnpT7wA7 yA168Hlc4lVEl59oWJY1XENaqei6cFoYP38ZHGywOkBe9BiY2oBmP8aqD+YlJh6ckexj dWSWPVs6uGdcPWsNoWI4lAXKQVjnGvSBu/cH2c3DZmpOZE+7dbdX2XmrWOuDALi7Y+SD VTWUFxeYLailddPaLSbiJlIrKY+MmktbiWmG1FJAEde2qkw4Fl6Qp1/puCiJaMgnEER+ TZlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718141241; x=1718746041; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8q+CwV9P38gVma8siKr6BIFHbUTXibDYisPIn0EdWz8=; b=AYWddw3YDmD92VQjUE4DGTWv+1knWfXHNJ5s3RW7g/+j3VK8K76GJR/hDlluXtmlM3 MyekOiYxfVZeBGAyznjY3w3/IgHPA5xD5OkfWn9rECwS0ybx6Sg5l6849qBHEFWsIpdn aJUHGuhdq7JIFgNcinP+4KFBgtTAzdVsyv8rRD2XM2ZbWs0vuzPoBPHx048utDHG5MAT OJiW9RoguHQ8aWzW7BKKZkpe1NoX4ZbmBxvFNBj90yGxNKdIhrxu3EUyU8MKWWRcEF1q 3l3R6o2S09tZjJb5b5lBxPgsImBUaS7KmbDDn/4ZHKtSO30elb8vrGFnWdcEZiqgVuLF Xuiw== X-Forwarded-Encrypted: i=1; AJvYcCVD5cs9fJOi/pEQXJpM7y+TMjG8+1yVeyu4P15+88V4uTACHYqAwZSF+LN0ovOtfpnGPF/O6goTzzwisUQIUozLn5VKgqYem6VtuA== X-Gm-Message-State: AOJu0YznIe302Fdpi5ivjYYyPnshkR0PHjdEo2wv9i09SFmQNukmt+hj kRSoQvLAkVtpCN2HxWO+IKNwLAvzFVaCSrC0u1HmWGleul3jZT64xxMZhnduV+O3DByif7Zfy9+ k7EDkgY3v7+oS7oVdF8PRi1qA2app8mkx X-Google-Smtp-Source: AGHT+IFmsRgabaQWR+9hDyYsuje1/MpCXS6RDUNIfm9BzoO88WEcI7pQVgsvZ71alM/dix9Zt9banXkmue3EoVCi3P8= X-Received: by 2002:a50:c09a:0:b0:57c:5fca:ab25 with SMTP id 4fb4d7f45d1cf-57ca976bc09mr42179a12.25.1718141240642; Tue, 11 Jun 2024 14:27:20 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Jun 2024 21:27:19 +0000 From: Stefan Kangas In-Reply-To: <87h6e059f3.fsf@gmail.com> References: <87h6e059f3.fsf@gmail.com> MIME-Version: 1.0 Date: Tue, 11 Jun 2024 21:27:19 +0000 Message-ID: Subject: Re: bug#71490: [PATCH] ; Fix customisation buffer for dired group To: Visuwesh , 71490-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71490-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 30.1 Visuwesh writes: > Tags: patch > > To reproduce, > > 1. emacs -Q > 2. M-x customize-group RET dired RET > 3. Click the triangle of Dired Create Destination Dirs On Trailing Dirsep Thanks, pushed as commit 076e8ad5fc5 and closing. ------------=_1718141342-29306-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Jun 2024 20:41:27 +0000 Received: from localhost ([127.0.0.1]:36745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH8J4-0006Hd-TH for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:41:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:47004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH8BO-0005td-9Y for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:33:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGuAD-0004z7-7t for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 01:35:21 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGuAA-00047n-LY for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2024 01:35:20 -0400 Received: by mail-pf1-x443.google.com with SMTP id d2e1a72fcca58-70417a6c328so2929487b3a.1 for ; Mon, 10 Jun 2024 22:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718084116; x=1718688916; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=wpf70kR5fsKYrIaiQSznV/ZC+PZoIJw+NKflqmGm8Lw=; b=R1rVUFdOHCKTmNh8bigOBDm+HF34ukP1BGhn/nbtTNKze/tM8TPw/UkzRUvvZUhTYS PwPRtNTE38Icf/5T/W6Uw/PiJ6nqD8bRuDTORpxZxD0289HALmabmBbj/7o8kwqHiRfk RfS4XpA2S6kzXudeRCBax09wS1RY5hs+09aU9nQkJVSLvED+likopz2cd4GyOkE8Mnri N9YR1+PogGdMtoziw/dQ1UJe85QCjsA33VdiJhyLCjsEBFdC7vHZCftLxwWGn18eitF7 GIIMPa33u2dT7GOvYy/Z7ul0jrkJxzgHcao+7dBlOhP5134voUTqdjjeI4JdalgG9MwR PzWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718084116; x=1718688916; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wpf70kR5fsKYrIaiQSznV/ZC+PZoIJw+NKflqmGm8Lw=; b=jjvfzps7oga4ldb0OxCxj4wGLj61eoh2I3zdeD/BinMk2+6ptdAgR7sDcFYyGHp9GJ mYByK6ta+2H2NASPd+kNQf9fLvp7rg5a8T9BvfcqdICGJYYtgUDgnL9w01nuBjpEIMlU tQXuyDRWnREW9PdGH/AoNSqoc6YFgxyMg0LgB1X93kIAR7SGHODPma9nVft1Kx9ZHxXO 9snAnAkqsyhq3mZR8h6KYc+VgsstFMhEPW20Z7tf+09zmflRbYeXEypWhMU4kCeIHCXj HSXlDs5F2QvfREu7ELdRW2wnCpMkb15TW1VNDt/yJvZykGxr+0kyAgRBQD/64nAQn9+X whlQ== X-Gm-Message-State: AOJu0YytmxTL8V7uC9OuqqHRrLyOtZgB+kZwNFEYw6IqzfdafUeBwQvK Wg1qDqS+juib2VCofMyA5D+Z1+hMelo/lMmpFEww/jMbfAcRbP8lYanilgBY X-Google-Smtp-Source: AGHT+IEdwScZQYVn9ZRfRWICAABnTgfM8vpgZBSjHJfbiA/OWaQhVe97GRc1iUFKwbS2wsl91DX2tg== X-Received: by 2002:a05:6a20:2443:b0:1b6:a1c1:b8ca with SMTP id adf61e73a8af0-1b6a1c1ba19mr5380298637.47.1718084115397; Mon, 10 Jun 2024 22:35:15 -0700 (PDT) Received: from localhost ([103.232.241.147]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f7029c5d63sm40714405ad.299.2024.06.10.22.35.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 22:35:14 -0700 (PDT) From: Visuwesh To: bug-gnu-emacs@gnu.org Subject: [PATCH] ; Fix customisation buffer for dired group Date: Tue, 11 Jun 2024 11:05:12 +0530 Message-ID: <87h6e059f3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=visuweshm@gmail.com; helo=mail-pf1-x443.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Tags: patch To reproduce, 1. emacs -Q 2. M-x customize-group RET dired RET 3. Click the triangle of Dired Create Destination Dirs On Trailing Dirsep Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.51.188.17 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (visuweshm[at]gmail.com) 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [103.232.241.147 listed in zen.spamhaus.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Tags: patch To reproduce, 1. emacs -Q 2. M-x customize-group RET dired RET 3. Click the triangle of Dired Create Destination Dirs On Trailing Dirsep Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.51.188.17 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (visuweshm[at]gmail.com) 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [103.232.241.147 listed in zen.spamhaus.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain Tags: patch To reproduce, 1. emacs -Q 2. M-x customize-group RET dired RET 3. Click the triangle of Dired Create Destination Dirs On Trailing Dirsep In GNU Emacs 30.0.50 (build 8, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.0, Xaw scroll bars) of 2024-05-07 built on astatine Repository revision: 4b31074f5f49898ba0499a2b617cad425750eafa Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101011 System Description: Debian GNU/Linux trixie/sid Configured using: 'configure --with-sound=alsa --with-x-toolkit=lucid --with-json --without-xaw3d --without-gconf --without-libsystemd --with-cairo --with-xft' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Fix-customisation-buffer-for-dired-group.patch >From 628afa281e1c050a9fe49a4c362b1572c439c4d2 Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Tue, 11 Jun 2024 10:51:39 +0530 Subject: [PATCH] ; Fix customisation buffer for dired group * lisp/dired-aux.el (dired-create-destination-dirs-on-trailing-dirsep): Actually concat the string. --- lisp/dired-aux.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index a2ce3083cfe..a0fa1ce6fe5 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -2218,14 +2218,14 @@ dired-create-destination-dirs-on-trailing-dirsep trailing /) is given or this option or `dired-create-destination-dirs' is nil, `old_name' will be renamed to `new_name'." - :type '(choice + :type `(choice (const :tag - (concat "Do not treat destination dirs with a " - "trailing directory separator specially") + ,(concat "Do not treat destination dirs with a " + "trailing directory separator specially") nil) (const :tag - (concat "Treat destination dirs with trailing " - "directory separator specially") + ,(concat "Treat destination dirs with trailing " + "directory separator specially") t)) :group 'dired :version "29.1") -- 2.43.0 --=-=-=-- ------------=_1718141342-29306-1-- From unknown Sat Aug 16 21:20:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71490: [PATCH] ; Fix customisation buffer for dired group Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2024 07:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Visuwesh Cc: 71490@debbugs.gnu.org Received: via spool by 71490-submit@debbugs.gnu.org id=B71490.171817687714765 (code B ref 71490); Wed, 12 Jun 2024 07:22:01 +0000 Received: (at 71490) by debbugs.gnu.org; 12 Jun 2024 07:21:17 +0000 Received: from localhost ([127.0.0.1]:37404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHIIH-0003q2-6L for submit@debbugs.gnu.org; Wed, 12 Jun 2024 03:21:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHIIF-0003pp-3r for 71490@debbugs.gnu.org; Wed, 12 Jun 2024 03:21:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHIIA-0004uX-Vc; Wed, 12 Jun 2024 03:21:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dBCp6y+sO+U0AiYU/6ag9l4XvvBj/SeJm3PtfoXzloI=; b=BNJ6TyMo+oq2 w6c58iF0HLWmu+zKt6+hC+nwJBCjdSOmaMK+iaoMCi+AtfZFeyPYbyKUGvWSqxfb5ggCzUXUZhHBf wwA5/Nwpb6LHg7AkYOd2ziI2y/akrg2HzZDpT9TV0bzZpJsWqudUD4jnEVY21a67VVdHMwutgploz 5mANfImA9PEc/PIE1UtmZrf/1RFHVYEGHEVMkNmzsgCZVPyEm28mP8t6q9YCecY/am6H8FeoeipeO syIIPAbQLMhG/MGZEZrHju+8mqRVfzDoDxlKp7Vh1AWcKFmKtQDyWA5Ip+dxkXVukNRmrIUKYzVLs bXvQASmwZ5irNq+SkTOOeQ==; Date: Wed, 12 Jun 2024 10:21:07 +0300 Message-Id: <861q5239uk.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87h6e059f3.fsf@gmail.com> (message from Visuwesh on Tue, 11 Jun 2024 11:05:12 +0530) References: <87h6e059f3.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Visuwesh > Date: Tue, 11 Jun 2024 11:05:12 +0530 > > 1. emacs -Q > 2. M-x customize-group RET dired RET > 3. Click the triangle of Dired Create Destination Dirs On Trailing Dirsep Why do we use 'concat' there in the first place? I fixed the defcustom not to use 'concat' (and fixed the text while at that).