From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 12:40:24 2024 Received: (at submit) by debbugs.gnu.org; 10 Jun 2024 16:40:24 +0000 Received: from localhost ([127.0.0.1]:45615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGi4G-000585-Do for submit@debbugs.gnu.org; Mon, 10 Jun 2024 12:40:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:42400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGhwh-0004k3-ON for submit@debbugs.gnu.org; Mon, 10 Jun 2024 12:32:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGgct-0005Zn-49 for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2024 11:08:03 -0400 Received: from sonic316-20.consmr.mail.ne1.yahoo.com ([66.163.187.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGgck-0006VF-In for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2024 11:08:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1718032068; bh=Vz7LfiF8kJFqqP4vPkM4WrtCk4uF4waiTEzgTuAopbU=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=N+KL/znbQfZbAFN9/IQ8pA1sCSnan07Dmd3T3fbk9MItFXPzuDeK4kj3QqEkJOQk9qFxn0oCR7nUc7ENV2CR9/JbU+cWBT2qaj/WGNPApIJcbu0pshXhIVpWEiOddnCR55OWlspHB5Q5VUWI/gsLfsYgoPAueUu+eKJVSqO3Ma4R6NQdBmsPiJ4fM4VR1lHZ9ziC9bF7/DT9Y/6lSRwwoEdUdR1OZjwItrYgkk/dyOsjXb4iQFCKPsGIu26i4uBNTpG22q+yEl0gfkDzIfAkJETyL3SviCIg/naY/zEqck/GE8ppfseHMVOrIwiu3Mp/qzBhbo8nvQviYuYX+LpBlA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1718032068; bh=F/vy+Q0H5Ypo5zFcJRJ3t/REoFIZ8ILPCkSYtAQUptJ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=K+dRGaj/xAEBGzfu02PL2ZYbIP8fRFik3ktS+KuT0781bSEp9XgH4VOsgQ4MNp7KZwwC7Tem92IA75/oI2X9VH/z0l6duSuaSqzhNKyH31I9Cbh2hkrK5AkToY2AWTQ/wPjrPKJPbhXqo/x9aNLhsMa2Wr2ytC56Ail4ALo9LTaACp1qNfrRURbSOnFh2ApKZ3yenaCH/op+kJgvByTYOtrkScsZ3VaqxldWoGK/Rdrawv88Vl4nnbcpyT/1amp3h//mk7OXqpLcSI0QVy/zuRcl10l7wG2zGm/WWtyyR7CEdFlUJaF6J34ykllKkNpLBT39DlyExA59ZSmy+j5zgw== X-YMail-OSG: YCD42eIVM1lh93qHJlcxwgsgvklFoGnn.BSLz8v0zC63Z6RoDElCRk170AmL1ke 6DUtlz852S2jq_R100GeM6ctx5qdrQg3Dhku2b7zETsCXobpLBTztF1UIrGxy7fcBK5uG._gJV0B Gp7v4Z_mrgeyPGY.hVHCJal_CZUPg52P6Isk0RG3ZrZHeXdgT46n6MTMUk0.1ftIrp9QXOIUZoXL u2Czo01PXkpyKfC9sbmBoiUGvHG3S4APuJt0VDBfCrGE5JipZ8r.WQ60komBNt.XmBKTDce3jxse stFY3lEpijBvbFEWVncP71g0_C71rgCsR2Z.ojagiA3NvEAf8Omcw_50NjavQ5buwiFg99lwdOd_ ewaCj_opA2LRF0wApBPJL37sKM2PV3zAkz4mHJEHnvbtKo9DgMkB3TN4CT6tijFVGGr96KjuLQrv Id0RzDNZ4KDUoztBjg_wtTmgl91Xglo7D5gGZl6KQkb4BM7QOb.ntUMc3Pk8nl9V6LfYK4R0RNKi bihTtwQQbHRLLgjP0SG0JWEi_WXHL7_fccxiMdtuGO5SsoNHpMPFdk0FT._K52s7Qj55IcUTsiQk pOGFPHK16mJcBuFlsJ8zjtyp1xLHAkr4Lk5XnIAy8YFxINrbpOTR2Acw0CcsxloCu4bdZHRANnle hFSJ9FPNIlP9jvl4l5vjEGbsfJwCjm8Gqk3xFhfuDPP6ydzhZkbV.tKEqT97e3qddJOBHn6o.llF CPW8x3dKkF56jtzOZ6G8ZPVRqqHnGu2FOd0rD8chY40.jNDsW_KkNu_QH9_YpaIobsfQyxA4hu3a XxjBJyp17SvTGQzhLZmYIjZHP9m_llEC5nIx3VqOXK7tGTLn777Ezyu7rQQfGV7c.cevROfA3Vvx T.kv5xy58_IwIZMLTUK_tiEsUiklUGcDdavb6E_mobUwtG629Jv20YSbaAzKSnb5gZC2z6tcl5ae Nbr6HdYldGEMM9NDMpV9MU5.lrn6ZOrlUXoc8rjOOIMmp3GhZNetdSl5y_3M1ZC0NLKW99ERHj_V SJrWkra0FievggyjvPSMt8KBXzvxxAWiye26hthg6fchN18rsyWlsoUAm7W8Z3Qg4lL.p.5h.VXf 4tX6.MDLn.RV3oi78.mWIfJ93adPSbAriUmpyXANfCjl2b_i6Xo72qLQoE0VHSLlPWRf7uA2P90d KgnCVs6h3rTzh5EEOab1tgDGDSESRYGWmL3WFKpA5s8TQtgonUBR1mCwTxCtK6EEaNJes_zsTWHr kTOS5i581sKaUGyWznLxxmrJq9RNqq5dr9R.OWvfQ6mAAHhBTrNcqYNhjxXlqRJGgTWuL5WLCEo0 MqSyep9xEUufjMvB.w7sQeHVJUB.7EQh3SE1JfqdJ8uocGeqUDZ.PsC5xHryXo2wz9w4xbVlftMg yBJBvHsMThmjWIJi6I7nAfw_j9HDzQIGzDq8PbYDU0c0qRqsUsORYqk7fEiMVYuFW1p4_2ihKKN7 hQiBaYQdR732a1WFCLG4V3MrEpy28SrlsAtG_9gPLccZCOLhwhjIN9p5kZdiIEyXEwhOaw6A35e9 NOXRV2LUDAu_zja4y6S5uJ4HM2hmsiemh17UUt7ozFh54O6A_re5M3Di3C1gxVXgdNVdZZ21XjeJ NEpE9285CsvMtRPz9zWR1QkT2x1oXO3FyZtXy7Gkety_gyHYO3j_GwcU_bb6CimCbSUMl6GXPX8N bXoF9hYNZWK1IC0mIhv7.b2WydsZ.YYOmwTHecpuAokvW.LCB83aVmqSpejZXyYz8sd3NUAzBN83 _UJHdE4iP5pLL22_0NlSs28zWij5P5XemJ3PnVAeClsDILivULL.cBmN9tAN7.YtclIGbmKhuQkh Vp6TVuiSONz1EFD6JzJJ3v41IjBckLmecEXTpr.rRuD5fDp.qkRs0P9WDIS67ZkxkEBZLA2VSkfl fkzVZrrWHbi_3ymiEIE7p1CWplqijAV2Zc9LswcxWBw7_XnzesqKrakvTKV5PPQZQiXl0jOnGhpC qzVwYia5ZZiAtIbDXn7f6be9WjWjvL0tq88mJ5eQWsHWYzLouyFrxFADKSAB9C_nMxRZmGzZlVpL 0zjQJ2ynoYzXyOJ2M.jxpwNDxonovk61tGxsbdjwqBlo9tdAdR0AO3BKce9DdQ4BZve6AHSv7mgv u1EfW.xHp7jr_Z6rr0UfSo5hCgkd.z7uoJ9caveYN7whHy2IXCNWP0tBqmxfiTd2p2EJA1hCLIf1 Os8EUNl0LMBa.OqVzuPO2IWZLx0L.PSkYPcHL2ymiVTb0 X-Sonic-MF: X-Sonic-ID: 4a03706b-128a-4435-98c4-9933387e0da0 Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Mon, 10 Jun 2024 15:07:48 +0000 Received: by hermes--production-sg3-6f9f87bd85-hl8cc (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 9848289c933e34aa64dfde84d74b2032; Mon, 10 Jun 2024 15:07:43 +0000 (UTC) From: Po Lu To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Lock files are not deleted on Windows 98 Date: Mon, 10 Jun 2024 23:07:38 +0800 Message-ID: <87r0d4bzut.fsf@yahoo.com> MIME-Version: 1.0 Content-Type: text/plain References: <87r0d4bzut.fsf.ref@yahoo.com> X-Mailer: WebService/1.1.22407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 417 Received-SPF: pass client-ip=66.163.187.146; envelope-from=luangruo@yahoo.com; helo=sonic316-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) With lock files enabled, type C-x C-f C:/WINDOWS/Application Data/.emacs RET, modify the file, and type C-x C-f, whereupon such a warning will be displayed: Warning (unlock-file): Invalid argument, `~/.emacs', ignored I don't recall whether it was because lock files were disabled on the same machine that this issue wasn't present in Emacs 28.1, or it was because the issue was introduced in a subsequent release. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 14:55:25 2024 Received: (at 71477) by debbugs.gnu.org; 10 Jun 2024 18:55:25 +0000 Received: from localhost ([127.0.0.1]:52700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGkAv-00009Z-0u for submit@debbugs.gnu.org; Mon, 10 Jun 2024 14:55:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGjgQ-00079v-HN for 71477@debbugs.gnu.org; Mon, 10 Jun 2024 14:23:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGj4K-0007MB-FF; Mon, 10 Jun 2024 13:44:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kKISsvIeMz1AhcanoS2PjKK/ktyGjp7W9ee5HyyLxrE=; b=RrdpcCjFJHp2 c/0tYPSjjqARvlAxu+gYFOlZt7PgyoYug8NlQzBYNrLTRbelLCMz61UpvLWRvdE2nfemDyFGaAU5y oFA7KbUTw0VHtac8hyGjqlap2RyjcCWiiyZ+n9Xy4mWhcUHDPMy465t08jVwlqHOAd377wcUQfcuE WTEyLa37Vk9/4XoTbxZp+ITbxfq5gN8erz/QFJXCpp03pTndBQrgo4leHu6N/tDsNiaKodAr5Q9Lr TwdMBzi50GDjGkWsbngrdVhnMOQ8wa+px3tn5+BsC9BbZBFY5JA0Od5s0bF7FPMBGcwPhFOO84V7h npwqDShtU+HbrR+5Xq+kXA==; Date: Mon, 10 Jun 2024 20:44:30 +0300 Message-Id: <867cew8zgh.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87r0d4bzut.fsf@yahoo.com> (bug-gnu-emacs@gnu.org) Subject: Re: bug#71477: 30.0.50; Lock files are not deleted on Windows 98 References: <87r0d4bzut.fsf.ref@yahoo.com> <87r0d4bzut.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71477 Cc: 71477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 10 Jun 2024 23:07:38 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > With lock files enabled, type C-x C-f C:/WINDOWS/Application Data/.emacs > RET, modify the file, and type C-x C-f, whereupon such a warning will be > displayed: > > Warning (unlock-file): Invalid argument, `~/.emacs', ignored I don't have access to Windows 9X anymore, and there's no such directory on the Windows system to which I do have access. So either you or someone will show a recipe that can be reproduced and debugged on a more modern system, or you dig into the EINVAL on that system and tell more details to understand what happens, or we just dismiss this bug alone with "moreinfo" tag (after all, this is just a warning). From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 11:45:22 2024 Received: (at 71477) by debbugs.gnu.org; 11 Jun 2024 15:45:22 +0000 Received: from localhost ([127.0.0.1]:35797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH3gY-0000Vp-72 for submit@debbugs.gnu.org; Tue, 11 Jun 2024 11:45:22 -0400 Received: from sonic316-20.consmr.mail.ne1.yahoo.com ([66.163.187.146]:40536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH3gT-0000VY-BZ for 71477@debbugs.gnu.org; Tue, 11 Jun 2024 11:45:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1718120710; bh=mAuiK3yAa23H73T9qZYzDRjliAIxgQrt79EhkgUlMUA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=hLqVS5ugG3iwLh874IYYDidVoX8snGZ51cB+RMh9oTQw+HtksDkj3KWCBE5uKIJX+ulBVEo5OCqQDIaWGiKUp4tlQ5gYArEfmH2EQXqtQEkNkPm2DVkN3Ng1eg1CgsyPQTjrB4Yo8IfDxUYtMiHJEVSz/NX/YMCi+/dFMI/6rKLdQBBFDOtKuJoJhSHXhp1oUfizQSDioXR3PsV5B6lj/xHV0Z5nvT2iHcew79/4rjvzHYjZlQbFQHN8NFsSPJeTXrwwU56g8Besvc1Aitwd4glKPFUHoZBYFV1pCT6+ey3XhdEou6aTClsTJW+KbjrYUci2QhjOxj+oSpNwOS/q9A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1718120710; bh=ki+CN4E2VBJa3hVfGdiT/B1IIOyIA9RHROy5waoIYnA=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ffrxVJonwLk47LMH+3/utCoq5XnY/qCZzqyKMNdr6t2x6xcDaj5BAKTmXWIOsytWBGCkMGg29kFA9QPtehGR+siDNW4BVPh/RZnIxkYWoDQyYCpFmmYZgKh59pSWupN8dbJKuAulhbv+tVUiZwkQ7C84I9oAA6LMo/wi+jW1IL6T5wgXLIwpMjTST48UHvhBNSurmZk8pajXG8W1rEknN3snUT9tjU0Z0iesxw1M4/Ig5BuMsWWT4dI+J4GhYgQAia82Qiot4NXxYLBA6OQIyG2Qb+AExLqx22qi4c8zO/Z4jl8SBlOyqwMb88VDCOr+qAYa5aciqjIEenvsCAxTtQ== X-YMail-OSG: p_NqaVIVM1l71R4gAL_pU95F7QjesJwT.O.yebuwXAq1vUQYCLrIdGRnCpqv1Vb pd0UBRjcV6VyCviE_ngNlklue97YGKiUI68DRE1RK31cmkBaOhHf9gFsyCBktpDAjCRJM9XUp.ef 0GnAAPWorOlnE6FvrsH5nk_yiseeqvGVafya7bnfWJMLuXUf88.iDNea7FHa7VKHcobZlFqcu2tq QwrTHYbaqDnzCcsdhYiVQ.kPku.55q.DRYY._oCGrSZnqnOZLd3aF_nRODdZBnNQQrH0KRJkiB.5 AqD.eYplSAl0R4FqPBLwOVlsJu11_rfb4fiUY85j2XPbCjDhyGJD.cpY6xAAJfHkkjvqVNGsCZ6p 6jVdskWDW_tMfMl1dnlUgq4Cxp3HoWwFk0HPvcppGVtTE6JSvdI1pKwqwXqRAkfmSYli9L7.Wg0G Xic_wjspv50WtKpfRf7U_QmWLG6n7dsmjqyUdy_EUvFgWjS7l3JoN1MQQzJuJz_NMZSofGNoQ3_E 7Q80gwc74KZnO4b6pr6gWggjC3ZZFfsUWrS1yBoU2MoFHNMv4RMHQyFVrgS31eOuEoN8xhs0c6IN B34lrjmj2wK1nQNrDPwC.c2GKcsS6mPGJf39oOgvwbUXuG6v6NmVbUYUiM_qaihyPBqJrHjCSpOf vy_0didQ8vtoeB0pzyIO7YGqBXl1ljJ73rBrBwp0yrEtCIRs5BzN5WAegCye223Jly0ynpWY71wn JoEhMdiWYM3lfwftvVg5DstWQIwrG.bgfYfkuZ7dl55s8TI4hi6LK8O8ZpU0gc3BWgavW2QKPZxK wt_hH9cYrdo9tudcRFnmmbCkpeKQce9VYy5zbmx_UV_sSmO84ssXAAboRHS7vEnJwpHsc_2R2JBb 0raWvAZM2G4fGP9jSuRFPbINjKHOyezzRJ6HctGourrZFEE34FovYgiDSeNZJbiQ2Ij23noJp4c8 1geJRw4EZOee.7Qe4Ay8GWV0CEu5i4eVRcf.ApYZMB3nxxDFnyA6CF_B3tp7MclaL.2L_cWYKDqd vapgJX4yTY.TpSsIApOfZaKbXCm4duh7W7EEKk1tvE7MsNjOWKscrVjNgRqnc2sgyeM3sVTLuObm 6oYRVlROSuKh167z22Z5ddTNf8xaQS7HQQWk3GdGJY62fK7QIFLbPim6h7Y4ovXH8OPPGwZ2E7kG 0rP213IKuJRaRzh5G0x4zx5RbVTHIEDVnB9qy8KPDpuLu_zIvJM_RxK2zG5E4cIwE5yLxO_Mp0Ok zaneSdM86fLko7Zcz5MU.VLN7PrQmePVwNPswDLUSu4jzAd4bcelkPwRVEchRp68L9BYa1jA.DFu r0U2HAoSSZzFGKP3ljGGZPyhKt6Cu4j6yfAvi3Xo3rl8XGyqKyX0zhHOfr1bpNcOPvbAOSNOBvgQ t7IedeDWyb91TeYHWQ8P6g_4P642ZXkll7sX91BD0y1_ab0C2OIGhZjnPFQpxJ2IDPM8HrWmB6xM J.74ytAqzvUz33MPQKba_5YMDDG_zKn4mNiAqgHoxEpituzu0Tms.nd13vpJqMeYKo9VES19heif xHeU_sQyq696Kor2ozxLenn1moXVdeLMFXjx6xd7B4KIZYtVCpbE78uU0GAE6kAvNOPHcbH2SzJv TKGeCXrvJQfZowUAn1gxMie7nnf8uZd3PaP46OI79iEWNxL_60FAucDDHD7iNsWsrtfdZ3cbC7Ok ij2Jr5.eblDXqE0R.45q3I8ptj0rfndANhGVU1D8XMH2QreIJ1EmiF2Ijw3jZdlm9U9jdpSZZhxS r06.2cqhS6U_tF_QRgUPszhZnFO88h6ZDp4RPzJWdiQwT9cmSxSikrojlCFfaiJ0vgRSQfFMXxwt lQb8oXE4OiOIeIonHZvimAUfguFz1hWetg8v8Lh8sfKS47aQWPSqOaD56V_Alpsl2epBhhQx8P1V 6QNlZhYLrnEYuBhQellgbDpVyacyv7CvviyhZPtNsehKpjDXFAfWLDfPFYgt3.jMTrODj9HNbX.o u4V88iJNr5ZBH03hBAUuYvymMdBQSzDQd4Q86vQpHS.5T1pmk6jeANokTm5KQY2_saDGXcPTt4yv xKzj0CakQLQANyC.KnZOL7JSSCrI_7iiB6iVxAj9I84ejuBs2Y6qRrTv_ayJAf.ZOKkpVuRQsf1l MBA0yjcZNzjdgxvJybafB0plJ1cHSsrFIx1zb1vrbsNwmk9aNcGGRFSjeVCQZ6lywEvgqXNBVPXx 0_URwhZLSYZL3nRPK3CgrJ8ciqKNbDMoSCQo7PApTzkRNAOXswDJ8Apj.cPEBiT4KPA3NYg-- X-Sonic-MF: X-Sonic-ID: 373d8edb-8e83-4317-82df-f60dfd920bb7 Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Tue, 11 Jun 2024 15:45:10 +0000 Received: by hermes--production-sg3-6f9f87bd85-7p8x6 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b07b4065de0ed9f660fb522e25ec51bf; Tue, 11 Jun 2024 13:34:27 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#71477: 30.0.50; Lock files are not deleted on Windows 98 In-Reply-To: <861q537htm.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Jun 2024 16:03:01 +0300") References: <87r0d4bzut.fsf.ref@yahoo.com> <87r0d4bzut.fsf@yahoo.com> <867cew8zgh.fsf@gnu.org> <87ikygb6hp.fsf@yahoo.com> <86h6e06kn5.fsf@gnu.org> <87bk47c4cd.fsf@yahoo.com> <86bk477vzx.fsf@gnu.org> <871q53c2ur.fsf@yahoo.com> <868qzb7uic.fsf@gnu.org> <87jzivamzp.fsf@yahoo.com> <861q537htm.fsf@gnu.org> Date: Tue, 11 Jun 2024 21:34:22 +0800 Message-ID: <87tthz8uxt.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.22407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 953 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71477 Cc: 71477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > OK, but could you provide some additional details, so I could > understand the issue better? What kind of negative values do you get > from getpid on Windows 98, and what does the system show as the PID of > that process? Is the value really such a large positive number that > its MSB is set? The value of getpid was -1859765, but I did not attempt to read the PID manually with GetCurrentProcessID or cross-check it against the OS's equivalent of ps, if there exists one at all. > According to my records, _getpid just calls GetCurrentProcessId and > returns the value as an int. So for _getpid to return a negative > value, GetCurrentProcessId should return a very large positive value, > I think. There's a screenshot on this forum that, if it is to be trusted, demonstrates that PIDs are indeed of this scale on Windows 9X: https://www.vbforums.com/showthread.php?308830-Task-Manager-For-Windows-98 From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 16:24:13 2024 Received: (at 71477) by debbugs.gnu.org; 11 Jun 2024 20:24:14 +0000 Received: from localhost ([127.0.0.1]:36375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH82P-0002js-Mw for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:24:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH82J-0002i3-UO for 71477@debbugs.gnu.org; Tue, 11 Jun 2024 16:24:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH1A0-0006DA-22; Tue, 11 Jun 2024 09:03:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Psl2QWb5Kz8wi0XcdkexRjxvrchuYZ1dgEXlRDps+/Q=; b=EqcVjNwbyX+G LnqTT4+FSEtiYG8Ra6ogz7U2YZ0JB2uSUGLX36wcptOChOAFVYMkey4R0reenqOQ9G63f63uzD7Ko zLFQjJgOigSYXXUtqoZ0KqpR3lkpidm1y7W02G3LP/PKjxlsLQ7idXic2yZgqZr3QH16ICixkEjAS gEk9a7JaVXXbxT/pxHsQ12yPxThKSAwnY5Kviu+e2uRFkSVEZ2u2qzgGSUC3shPLwEul47RVu2+wo mbC4sW3tyavgtIG7GE/oLBqIYDIYmkJZ6aXQlImqzFXPMPOUY2NJpUTLMcqMNMxYiX4dK+SQuH6GX ZV+fAr0GnE/8Cj1mrz0Z/A==; Date: Tue, 11 Jun 2024 16:03:01 +0300 Message-Id: <861q537htm.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87jzivamzp.fsf@yahoo.com> (message from Po Lu on Tue, 11 Jun 2024 16:43:06 +0800) Subject: Re: bug#71477: 30.0.50; Lock files are not deleted on Windows 98 References: <87r0d4bzut.fsf.ref@yahoo.com> <87r0d4bzut.fsf@yahoo.com> <867cew8zgh.fsf@gnu.org> <87ikygb6hp.fsf@yahoo.com> <86h6e06kn5.fsf@gnu.org> <87bk47c4cd.fsf@yahoo.com> <86bk477vzx.fsf@gnu.org> <871q53c2ur.fsf@yahoo.com> <868qzb7uic.fsf@gnu.org> <87jzivamzp.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71477 Cc: 71477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: 71477@debbugs.gnu.org > Date: Tue, 11 Jun 2024 16:43:06 +0800 > > > The only possible issue I see with allowing a negative PID is that the > > code checks for "pid > 0" or "pid < 0" somewhere; if that is the case, > > we should replace those with comparisons with -1 instead. > > > > Can you test the above on Windows 9X when you have a chance? Then we > > could install it. > > If it doesn't produce any adverse effect on modern Windows, and what I > raised is not important, let's install it now, and I will test it as > soon as may be, or it might fall by the wayside. OK, but could you provide some additional details, so I could understand the issue better? What kind of negative values do you get from getpid on Windows 98, and what does the system show as the PID of that process? Is the value really such a large positive number that its MSB is set? According to my records, _getpid just calls GetCurrentProcessId and returns the value as an int. So for _getpid to return a negative value, GetCurrentProcessId should return a very large positive value, I think. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 16:24:15 2024 Received: (at 71477) by debbugs.gnu.org; 11 Jun 2024 20:24:15 +0000 Received: from localhost ([127.0.0.1]:36385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH82Q-0002kA-R5 for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:24:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH82N-0002i3-NZ for 71477@debbugs.gnu.org; Tue, 11 Jun 2024 16:24:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGwsW-0004FT-2W; Tue, 11 Jun 2024 04:29:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EEEEzTSQR4/2cqZiR4axn704a7L0HoRG6RwYU4bx+fU=; b=Dw1V9j4HzXxf YI2xOVLsba4RhCr7WVHeHQl2tS3nRkvu7MKGimIhjLN517r1x43iNgcnV6lQDG62JrZMzXOOFTlk4 ydimVVPmYjMHA4Y4D/31jABb/ctvwRohVyQ4cJgiohoJzW5eOHml/BEVfWBeiOl2JE/hwU5e1OB1v ZKzqfBaF+bRDUFwzpluhU7gPvBE/fr82ObUEvlgD+ouuhdF7Mh8nP+L1L4bMZ79DgMT2InJyEL3bb A99W2bnwyHGm0gbC9cw/yKFeDJ8y5zcWkToK+rlzlKDz2Hr9i1TKHkQAyW4cjWtLOpbJ+oR7u4B9/ v9puHb0iN+xmSy1QDtlMQg==; Date: Tue, 11 Jun 2024 11:28:59 +0300 Message-Id: <868qzb7uic.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <871q53c2ur.fsf@yahoo.com> (message from Po Lu on Tue, 11 Jun 2024 16:15:08 +0800) Subject: Re: bug#71477: 30.0.50; Lock files are not deleted on Windows 98 References: <87r0d4bzut.fsf.ref@yahoo.com> <87r0d4bzut.fsf@yahoo.com> <867cew8zgh.fsf@gnu.org> <87ikygb6hp.fsf@yahoo.com> <86h6e06kn5.fsf@gnu.org> <87bk47c4cd.fsf@yahoo.com> <86bk477vzx.fsf@gnu.org> <871q53c2ur.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71477 Cc: 71477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: 71477@debbugs.gnu.org > Date: Tue, 11 Jun 2024 16:15:08 +0800 > > Eli Zaretskii writes: > > >> From: Po Lu > >> Cc: 71477@debbugs.gnu.org > >> Date: Tue, 11 Jun 2024 15:42:58 +0800 > >> > >> Eli Zaretskii writes: > >> > >> > Sorry, I don't understand the problems with negative PID values. > >> > Where exactly in the code of filelock.c it gets in the way? > >> > >> Here: > >> > >> /* The PID is everything from the last '.' to the ':' or equivalent. */ > >> if (! c_isdigit (dot[1])) <-------------- > >> return EINVAL; > >> errno = 0; > >> > >> The first character of the number after the period is `-' on Windows 98. > > > > But that is easy to fix without any significant effect on the rest of > > the code. For example: > > > > if (! (c_isdigit (dot[1]) > > || (dot[1] == '-' && c_isdigit (dot[2])))) > > return EINVAL; > > > > Are there any problems with the above fix? > > No, but won't leaving the format of the lock file string inconsistent > with Unix create difficulties elsewhere, as, for example, on a Samba > share to which Unix systems are also connected? What inconsistencies, specifically? The only possible issue I see with allowing a negative PID is that the code checks for "pid > 0" or "pid < 0" somewhere; if that is the case, we should replace those with comparisons with -1 instead. Can you test the above on Windows 9X when you have a chance? Then we could install it. > P.S. is debbugs.gnu.org offline or some such? It has connectivity problems. It was already reported. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 16:24:15 2024 Received: (at 71477) by debbugs.gnu.org; 11 Jun 2024 20:24:15 +0000 Received: from localhost ([127.0.0.1]:36389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH82R-0002kI-63 for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:24:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH82O-0002i3-8m for 71477@debbugs.gnu.org; Tue, 11 Jun 2024 16:24:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGwNY-0005ss-61; Tue, 11 Jun 2024 03:57:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QgrnvCVJrc6rXmNhI3QQ0chzAn/7iha78laOut5qHKY=; b=NmSxtiaWhjX2 8FsIYHHwljj7qB1Bu3hwQEJJ9Q5KdN8ISBkgzPdsSl8E0kD+QJm+/zX8SrFmazyMVR+qtx19U8+7d w9JvOJOmPTwGGpHalwwlfCGx6ZL40FwbqJ6f/nM7wJHzJch1oZRSw8iwofMu8VSjh+n11y5SDVWUH IjdNu260BlzvM+GXVesl+f9Gkt3mG/06psBtfkkTtfcOM0XWkclbsyumu0MTnL4oJZeArVDTKAEux KDABJ415T3hADGrUER5MQpQYLJN7bN2cjDc6GQg74qIkVSR4LZWguYR1p0Vh+EGFVBGr8TCDCthL4 ia3Veype7FJUev6V2kBjqQ==; Date: Tue, 11 Jun 2024 10:56:50 +0300 Message-Id: <86bk477vzx.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87bk47c4cd.fsf@yahoo.com> (message from Po Lu on Tue, 11 Jun 2024 15:42:58 +0800) Subject: Re: bug#71477: 30.0.50; Lock files are not deleted on Windows 98 References: <87r0d4bzut.fsf.ref@yahoo.com> <87r0d4bzut.fsf@yahoo.com> <867cew8zgh.fsf@gnu.org> <87ikygb6hp.fsf@yahoo.com> <86h6e06kn5.fsf@gnu.org> <87bk47c4cd.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71477 Cc: 71477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: 71477@debbugs.gnu.org > Date: Tue, 11 Jun 2024 15:42:58 +0800 > > Eli Zaretskii writes: > > > Sorry, I don't understand the problems with negative PID values. > > Where exactly in the code of filelock.c it gets in the way? > > Here: > > /* The PID is everything from the last '.' to the ':' or equivalent. */ > if (! c_isdigit (dot[1])) <-------------- > return EINVAL; > errno = 0; > > The first character of the number after the period is `-' on Windows 98. But that is easy to fix without any significant effect on the rest of the code. For example: if (! (c_isdigit (dot[1]) || (dot[1] == '-' && c_isdigit (dot[2])))) return EINVAL; Are there any problems with the above fix? Please note: I don't want to make any significant changes in this area, certainly not for the benefit of Windows 9X. So if the above is not sufficient, please tell the details, and let's discuss how to solve what's left. P.S. I've for now reverted the changes you made to use unsigned values because I don't think that TRT (pid must support negative values), and this whole area of code is fragile enough for us to discuss changes before installing them. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 16:41:40 2024 Received: (at 71477) by debbugs.gnu.org; 11 Jun 2024 20:41:40 +0000 Received: from localhost ([127.0.0.1]:36763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH8JI-0006Iq-6r for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:41:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH82Q-0002i3-H5 for 71477@debbugs.gnu.org; Tue, 11 Jun 2024 16:24:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGvI0-0000nY-7P; Tue, 11 Jun 2024 02:47:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QopJcU6rzZUxSQg3Qqw41oDt81RmgoU5b2T/mAcjuUU=; b=HBxRCWrBuFpP XbnS6uAuo6THJhIdOaEr3R51nuqw8HytbpueSLpHil6113X6N0D5nfP9mgwI5/5Cy2Bh/Ctp2dUee POfGi/aMUUQcv1+9YkBaVkpcFBF2/FLUW5i6GYHYrk5aYtLzhdqSoWfMt6vmBvMsdR4tt2foLtJZF 82zmaMks9ZO4+MqIm+8HjSfolhyh5xs/LZwAPCgp/3RN2oNI6r0L2+gHwRabj3Ri7iDaedgP1Bd9l OkSLP9LpID5B1Xu6YBq7WOKyO1dv4AWRfJAMyEBrpIsT1cLdxVxlhh6HztwYW01G5unIMFv9bKJO5 cWjSmtz8yndFJcqznwKW9g==; Date: Tue, 11 Jun 2024 09:47:26 +0300 Message-Id: <86h6e06kn5.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87ikygb6hp.fsf@yahoo.com> (message from Po Lu on Tue, 11 Jun 2024 09:41:54 +0800) Subject: Re: bug#71477: 30.0.50; Lock files are not deleted on Windows 98 References: <87r0d4bzut.fsf.ref@yahoo.com> <87r0d4bzut.fsf@yahoo.com> <867cew8zgh.fsf@gnu.org> <87ikygb6hp.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71477 Cc: 71477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: 71477@debbugs.gnu.org > Date: Tue, 11 Jun 2024 09:41:54 +0800 > > Eli Zaretskii writes: > > > I don't have access to Windows 9X anymore, and there's no such > > directory on the Windows system to which I do have access. So either > > you or someone will show a recipe that can be reproduced and debugged > > on a more modern system, or you dig into the EINVAL on that system and > > tell more details to understand what happens, or we just dismiss this > > bug alone with "moreinfo" tag (after all, this is just a warning). > > I think I've arrived at the problem: Femacs_pid and getpid return a > negative value, and once it is duly written to the lock file, > current_lock_owner does not accept the sign character after the PID > separator, consequently returning EINVAL. Apparently, in times past > file-locking routines cast all PIDs to unsigned long, but that behavior > was lost in the midst of changes since installed for Unix systems, and > as such I will attempt to restore the historical semantics on Windows > systems. Sorry, I don't understand the problems with negative PID values. Where exactly in the code of filelock.c it gets in the way? We had a similar problem on Cygwin, albeit with boot time, not PID, and we fixed it very easily. If filelock.c assumes PIDs are positive somewhere, please point out that code. In any case, please don't install any changes in this area without posting them for discussion first. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 04:25:54 2024 Received: (at 71477) by debbugs.gnu.org; 12 Jun 2024 08:25:54 +0000 Received: from localhost ([127.0.0.1]:37497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHJIn-0005Z1-Nt for submit@debbugs.gnu.org; Wed, 12 Jun 2024 04:25:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHJIm-0005Yp-G2 for 71477@debbugs.gnu.org; Wed, 12 Jun 2024 04:25:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHJIh-0000aX-Pi; Wed, 12 Jun 2024 04:25:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AaF52YDleG6ca0gSJi+siLrcDXeXF7Iq1IMMINXnqUw=; b=ACyZxci0cstl A1LghLGmPToqiwMAbAcS45V6a/bIMGVbXjxzN6jp4oaBHatgCy25af/z/eG0qnDKGAOFzOWqmuQc2 HYDD+3mPv9RZRU7NeKTzSkc35+RVhNI5kq5eo7ZMkxfuiYf9OrdxwjIs+iKILRUKPcotMdMyvSNS4 e5Jos7/NCYTMYESpISf4vR4vLyLb1aTFrJWMreda3029MlUN8WBd6U5O4Rt2I2VHanyh6ilXzjGA3 OBJdPH49JqfhCtEU4BpXYV345PLGETIQMlGadiFRp+nn8fkyFGJdUbXKhqiX8Vz4sAB2aSeWlFzO8 7Hjrh5m+Jcr0KD0XkYInqQ==; Date: Wed, 12 Jun 2024 11:25:44 +0300 Message-Id: <86h6dy1saf.fsf@gnu.org> From: Eli Zaretskii To: Po Lu , Paul Eggert In-Reply-To: <87jzivamzp.fsf@yahoo.com> (message from Po Lu on Tue, 11 Jun 2024 16:43:06 +0800) Subject: Re: bug#71477: 30.0.50; Lock files are not deleted on Windows 98 References: <87r0d4bzut.fsf.ref@yahoo.com> <87r0d4bzut.fsf@yahoo.com> <867cew8zgh.fsf@gnu.org> <87ikygb6hp.fsf@yahoo.com> <86h6e06kn5.fsf@gnu.org> <87bk47c4cd.fsf@yahoo.com> <86bk477vzx.fsf@gnu.org> <871q53c2ur.fsf@yahoo.com> <868qzb7uic.fsf@gnu.org> <87jzivamzp.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71477 Cc: 71477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: 71477@debbugs.gnu.org > Date: Tue, 11 Jun 2024 16:43:06 +0800 > > Eli Zaretskii writes: > > > What inconsistencies, specifically? > > Any older Emacs binary that encounters a lock file produced under > Windows 9X will report an "Invalid argument" error until the user > intervenes to delete this lock file. I don't see how we can fix such problems retroactively. > > The only possible issue I see with allowing a negative PID is that the > > code checks for "pid > 0" or "pid < 0" somewhere; if that is the case, > > we should replace those with comparisons with -1 instead. > > > > Can you test the above on Windows 9X when you have a chance? Then we > > could install it. > > If it doesn't produce any adverse effect on modern Windows, and what I > raised is not important, let's install it now, and I will test it as > soon as may be, or it might fall by the wayside. OK. (It turns out we already knew about this issue, see the comments in w32proc.c, search for "Hack for Windows 95".) Paul, do you see any problems with the change below? It worked for me in some limited testing. I intend to install it on the master branch unless there are objections. diff --git a/src/filelock.c b/src/filelock.c index 050cac5..59fb47e 100644 --- a/src/filelock.c +++ b/src/filelock.c @@ -393,7 +393,9 @@ current_lock_owner (lock_info_type *owner, Lisp_Object lfname) return EINVAL; /* The PID is everything from the last '.' to the ':' or equivalent. */ - if (! c_isdigit (dot[1])) + if (! (c_isdigit (dot[1]) + /* Windows 9X report negative PID values. */ + || (dot[1] == '-' && c_isdigit (dot[2])))) return EINVAL; errno = 0; pid = strtoimax (dot + 1, &owner->colon, 10); @@ -451,7 +453,7 @@ current_lock_owner (lock_info_type *owner, Lisp_Object lfname) { if (pid == getpid ()) return I_OWN_IT; - else if (0 < pid && pid <= TYPE_MAXIMUM (pid_t) + else if (pid != -1 && pid <= TYPE_MAXIMUM (pid_t) && (kill (pid, 0) >= 0 || errno == EPERM) && (boot_time == 0 || (boot_time <= TYPE_MAXIMUM (time_t) From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 12:08:02 2024 Received: (at 71477) by debbugs.gnu.org; 12 Jun 2024 16:08:02 +0000 Received: from localhost ([127.0.0.1]:40013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHQW1-00007T-Le for submit@debbugs.gnu.org; Wed, 12 Jun 2024 12:08:02 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:56352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHQVy-00006x-6x for 71477@debbugs.gnu.org; Wed, 12 Jun 2024 12:08:00 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id A20323C011BD4; Wed, 12 Jun 2024 09:07:53 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id HVttPlva3sJ0; Wed, 12 Jun 2024 09:07:53 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 3B0D33C011BD8; Wed, 12 Jun 2024 09:07:53 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 3B0D33C011BD8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1718208473; bh=cgWvz2u+2WZkYEDWkGsqorAUi8q2ANv0k6rpiEx+gRk=; h=Message-ID:Date:MIME-Version:To:From; b=bDI/lE9CKrAykiEVab09QEva9Z5EgiwQHs/EVA1b2Rz4RmeKE8TpRnxxGAKxekfRp Q7PtNN1gryc0aidHtKJmVVPqklB5vz8fg2UJKs3KWh8YxvHahOjqMOfzsbKKjguqdo 070P69iFD+T1F7ZGeH/+wlDGlaXB6DK7OMSoqy476aIiLRAQkc2CsRarqZwqG78/CN SFEiqr1H7yqC1l2pt6unR27yX8ihjDbE6wTTvkzX7jX6MS6OxvgsRTakg7FBVQ9Nyx W2XgX0D4KatV5djFoWF8f8cUBoVhvpP67xi7j0Hl+QuJA1uW7YWBXVvAcAYS9FcjiJ Xq7DrRtqViVpQ== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id NSPjMUCwXdGB; Wed, 12 Jun 2024 09:07:53 -0700 (PDT) Received: from [192.168.254.12] (unknown [47.154.17.165]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 187ED3C011BD4; Wed, 12 Jun 2024 09:07:53 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------2FrdXrp2ci3ibfXNOHl0gbtM" Message-ID: <531dbf85-2554-43aa-bca1-db50e0bf2306@cs.ucla.edu> Date: Wed, 12 Jun 2024 09:07:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71477: 30.0.50; Lock files are not deleted on Windows 98 To: Eli Zaretskii , Po Lu References: <87r0d4bzut.fsf.ref@yahoo.com> <87r0d4bzut.fsf@yahoo.com> <867cew8zgh.fsf@gnu.org> <87ikygb6hp.fsf@yahoo.com> <86h6e06kn5.fsf@gnu.org> <87bk47c4cd.fsf@yahoo.com> <86bk477vzx.fsf@gnu.org> <871q53c2ur.fsf@yahoo.com> <868qzb7uic.fsf@gnu.org> <87jzivamzp.fsf@yahoo.com> <86h6dy1saf.fsf@gnu.org> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <86h6dy1saf.fsf@gnu.org> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71477 Cc: 71477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------2FrdXrp2ci3ibfXNOHl0gbtM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024-06-12 01:25, Eli Zaretskii wrote: > - if (! c_isdigit (dot[1])) > + if (! (c_isdigit (dot[1]) > + /* Windows 9X report negative PID values. */ > + || (dot[1] == '-' && c_isdigit (dot[2])))) Faster is "if (! c_isdigit[(dot[1] == '-') + 1])", as it avoids a conditional branch on most platforms. > - else if (0 < pid && pid <= TYPE_MAXIMUM (pid_t) > + else if (pid != -1 && pid <= TYPE_MAXIMUM (pid_t) > && (kill (pid, 0) >= 0 || errno == EPERM) This looks dubious for most systems, where 'kill' has special behavior when pid < -1 or pid == 0; it tests a process group. That's not the test we want here, since we want to check whether Emacs can be sent a signal, not whether any process in its process group can be sent a signal (this can be valid even after Emacs has exited). The code should use calls like kill (-2, 0) and kill (0, 0) only on platforms where we know the calls do not test a process group. Even on MS Windows 98 we should check that TYPE_MINIMUM (pid_t) <= pid. Also, is there a special meaning for kill (0, 0) on MS Windows 98? If so, we should also check that pid != 0. Do any MS-Windows platforms support process groups, i.e., kill (-2, 0) operates on process group 2 rather than on an individual process with process ID -2? If so, these platforms should be careful too, and should not use kill (-2, 0) or kill (0, 0). How about the attached patch instead? You can adjust the Microsoft-specific .h files to define VALID_PROCESS_ID appropriately for MS Windows 98, and for any other MS platform where kill (-2, 0) is known to check for just the individual process -2. --------------2FrdXrp2ci3ibfXNOHl0gbtM Content-Type: text/x-patch; charset=UTF-8; name="0001-Start-of-a-fix-for-bug-71477.patch" Content-Disposition: attachment; filename="0001-Start-of-a-fix-for-bug-71477.patch" Content-Transfer-Encoding: base64 RnJvbSBmNWRjZWNiODMzYzcxNjk5NWQzOGY5MGFiYzZkMTIwZDZmNWUzMDY0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDEyIEp1biAyMDI0IDA4OjQyOjI0IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gU3RhcnQgb2YgYSBmaXggZm9yIGJ1ZyM3MTQ3NwoKKiBzcmMvZmlsZWxvY2suYyAoaW50 ZWdlcl9wcmVmaXhlZCk6IE5ldyBzdGF0aWMgZnVuY3Rpb24uCihWQUxJRF9QUk9DRVNTX0lE KTogTmV3IG1hY3JvLgooY3VycmVudF9sb2NrX293bmVyKTogVXNlIHRoZW0gdG8gYWxsb3cg bmVnYXRpdmUgcHJvY2VzcyBJRHMKb24gc29tZSBNaWNyb3NvZnQgcGxhdGZvcm1zLgotLS0K IHNyYy9maWxlbG9jay5jIHwgMjQgKysrKysrKysrKysrKysrKysrKy0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9zcmMvZmlsZWxvY2suYyBiL3NyYy9maWxlbG9jay5jCmluZGV4IDA1MGNhYzU2NWM5Li5k NGE0NzQ3OTU1YSAxMDA2NDQKLS0tIGEvc3JjL2ZpbGVsb2NrLmMKKysrIGIvc3JjL2ZpbGVs b2NrLmMKQEAgLTM0Miw2ICszNDIsMjIgQEAgcmVhZF9sb2NrX2RhdGEgKGNoYXIgKmxmbmFt ZSwgY2hhciBsZmluZm9bTUFYX0xGSU5GTyArIDFdKQogICByZXR1cm4gbmJ5dGVzOwogfQog CisvKiBXaGV0aGVyIHRoZSBzdHJpbmcgUyBzdGFydHMgd2l0aCBhIGRlY2ltYWwgaW50ZWdl ciwgb3B0aW9uYWxseQorICAgbmVnYXRpdmUuICAqLworc3RhdGljIGJvb2wKK2ludGVnZXJf cHJlZml4ZWQgKGNoYXIgY29uc3QgKnMpCit7CisgIC8qIERvaW5nIGl0IHRoaXMgd2F5IGF2 b2lkcyBhIGNvbmRpdGlvbmFsIGJyYW5jaCBvbiBtb3N0IHBsYXRmb3Jtcy4gICovCisgIHJl dHVybiBjX2lzZGlnaXQgKHNbc1swXSA9PSAnLSddKTsKK30KKworLyogV2hldGhlciB0aGUg aW50ZWdlciBQIGNvdWxkIGlkZW50aWZ5IGFuIGluZGl2aWR1YWwgcHJvY2Vzcy4gIE9uIG1v c3QKKyAgIHBsYXRmb3JtcyB0aGlzIHNpbXBseSBjaGVja3MgZm9yIHBvc2l0aXZlIHBpZF90 LCBidXQgb24gc29tZQorICAgTWljcm9zb2Z0IHBvcnRzIG91ciBoZWFkZXJzICNkZWZpbmUg aXQgdG8gdG8gc29tZSBvdGhlciB0ZXN0LiAgKi8KKyNpZm5kZWYgVkFMSURfUFJPQ0VTU19J RAorIyBkZWZpbmUgVkFMSURfUFJPQ0VTU19JRChwKSAoMCA8IChwKSAmJiAocCkgPD0gVFlQ RV9NQVhJTVVNIChwaWRfdCkpCisjZW5kaWYKKwogLyogVHJ1ZSBpZiBlcnJubyB2YWx1ZXMg YXJlIG5lZ2F0aXZlLiAgQWx0aG91Z2ggdGhlIEMgc3RhbmRhcmQKICAgIHJlcXVpcmVzIHRo ZW0gdG8gYmUgcG9zaXRpdmUsIHRoZXkgYXJlIG5lZ2F0aXZlIGluIEhhaWt1LiAgKi8KIGVu dW0geyBORUdBVElWRV9FUlJOTyA9IEVET00gPCAwIH07CkBAIC0zOTMsNyArNDA5LDcgQEAg Y3VycmVudF9sb2NrX293bmVyIChsb2NrX2luZm9fdHlwZSAqb3duZXIsIExpc3BfT2JqZWN0 IGxmbmFtZSkKICAgICByZXR1cm4gRUlOVkFMOwogCiAgIC8qIFRoZSBQSUQgaXMgZXZlcnl0 aGluZyBmcm9tIHRoZSBsYXN0ICcuJyB0byB0aGUgJzonIG9yIGVxdWl2YWxlbnQuICAqLwot ICBpZiAoISBjX2lzZGlnaXQgKGRvdFsxXSkpCisgIGlmICghIGludGVnZXJfcHJlZml4ZWQg KGRvdCArIDEpKQogICAgIHJldHVybiBFSU5WQUw7CiAgIGVycm5vID0gMDsKICAgcGlkID0g c3RydG9pbWF4IChkb3QgKyAxLCAmb3duZXItPmNvbG9uLCAxMCk7CkBAIC00MTksOSArNDM1 LDcgQEAgY3VycmVudF9sb2NrX293bmVyIChsb2NrX2luZm9fdHlwZSAqb3duZXIsIExpc3Bf T2JqZWN0IGxmbmFtZSkKICAgICAgIGJvb3QgKz0gMjsKICAgICAgIEZBTExUSFJPVUdIOwog ICAgIGNhc2UgJzonOgotICAgICAgaWYgKCEoY19pc2RpZ2l0IChib290WzBdKQotCSAgICAv KiBBIG5lZ2F0aXZlIG51bWJlci4gICovCi0JICAgIHx8IChib290WzBdID09ICctJyAmJiBj X2lzZGlnaXQgKGJvb3RbMV0pKSkpCisgICAgICBpZiAoISBpbnRlZ2VyX3ByZWZpeGVkIChi b290KSkKIAlyZXR1cm4gRUlOVkFMOwogICAgICAgYm9vdF90aW1lID0gc3RydG9pbWF4IChi b290LCAmbGZpbmZvX2VuZCwgMTApOwogICAgICAgYnJlYWs7CkBAIC00NTEsNyArNDY1LDcg QEAgY3VycmVudF9sb2NrX293bmVyIChsb2NrX2luZm9fdHlwZSAqb3duZXIsIExpc3BfT2Jq ZWN0IGxmbmFtZSkKICAgICB7CiAgICAgICBpZiAocGlkID09IGdldHBpZCAoKSkKICAgICAg ICAgcmV0dXJuIElfT1dOX0lUOwotICAgICAgZWxzZSBpZiAoMCA8IHBpZCAmJiBwaWQgPD0g VFlQRV9NQVhJTVVNIChwaWRfdCkKKyAgICAgIGVsc2UgaWYgKFZBTElEX1BST0NFU1NfSUQg KHBpZCkKICAgICAgICAgICAgICAgICYmIChraWxsIChwaWQsIDApID49IDAgfHwgZXJybm8g PT0gRVBFUk0pCiAJICAgICAgICYmIChib290X3RpbWUgPT0gMAogCQkgICB8fCAoYm9vdF90 aW1lIDw9IFRZUEVfTUFYSU1VTSAodGltZV90KQotLSAKMi40My4wCgo= --------------2FrdXrp2ci3ibfXNOHl0gbtM-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 13:11:02 2024 Received: (at 71477) by debbugs.gnu.org; 12 Jun 2024 17:11:02 +0000 Received: from localhost ([127.0.0.1]:40058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHRUz-0001sX-JV for submit@debbugs.gnu.org; Wed, 12 Jun 2024 13:11:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHRUv-0001sB-Hf for 71477@debbugs.gnu.org; Wed, 12 Jun 2024 13:11:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHRUq-0006OP-E1; Wed, 12 Jun 2024 13:10:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dZz33Nsnn+SxbnLcX7uyXIHbrCn9I5/35wOuUUNAwGo=; b=BkFI0s36Lyg6 CUWknuP/1IcfLFU6LJX1Pe+F/w2CQY4F/BSm5GQGoo8Z74UVQKY7uK0CEz3qtFYp/+X5nG8WtE8Dh tFsXdcYhGXne7LrY44qghudpirAP+R6RLd1S323B4N7Rclbk2sKgVCvlkRtaO8Lf2HrqBKRCJzzcm 8knXBxLmVZJDmzJN5F/ZHtksMOvAgc4ES+t/L61Z5XHfYpJYTDgqK1n+ANueS0svw0hy/DlotvIXB Nvuds29M6reqVmrPkAIVLn+A+WqQoWcH7toxPSyDgWY7p+woULw5a0G7aMIMH2yyE2jdE4JMASTYX STzppmg3g19dnOsXxDAivA==; Date: Wed, 12 Jun 2024 20:10:50 +0300 Message-Id: <86sexiytlx.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-Reply-To: <531dbf85-2554-43aa-bca1-db50e0bf2306@cs.ucla.edu> (message from Paul Eggert on Wed, 12 Jun 2024 09:07:52 -0700) Subject: Re: bug#71477: 30.0.50; Lock files are not deleted on Windows 98 References: <87r0d4bzut.fsf.ref@yahoo.com> <87r0d4bzut.fsf@yahoo.com> <867cew8zgh.fsf@gnu.org> <87ikygb6hp.fsf@yahoo.com> <86h6e06kn5.fsf@gnu.org> <87bk47c4cd.fsf@yahoo.com> <86bk477vzx.fsf@gnu.org> <871q53c2ur.fsf@yahoo.com> <868qzb7uic.fsf@gnu.org> <87jzivamzp.fsf@yahoo.com> <86h6dy1saf.fsf@gnu.org> <531dbf85-2554-43aa-bca1-db50e0bf2306@cs.ucla.edu> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71477 Cc: luangruo@yahoo.com, 71477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 12 Jun 2024 09:07:52 -0700 > Cc: 71477@debbugs.gnu.org > From: Paul Eggert > > > On 2024-06-12 01:25, Eli Zaretskii wrote: > > > - if (! c_isdigit (dot[1])) > > + if (! (c_isdigit (dot[1]) > > + /* Windows 9X report negative PID values. */ > > + || (dot[1] == '-' && c_isdigit (dot[2])))) > > Faster is "if (! c_isdigit[(dot[1] == '-') + 1])", as it avoids a > conditional branch on most platforms. OK. > > - else if (0 < pid && pid <= TYPE_MAXIMUM (pid_t) > > + else if (pid != -1 && pid <= TYPE_MAXIMUM (pid_t) > > && (kill (pid, 0) >= 0 || errno == EPERM) > > This looks dubious for most systems, where 'kill' has special behavior > when pid < -1 or pid == 0; it tests a process group. That's not the test > we want here, since we want to check whether Emacs can be sent a signal, > not whether any process in its process group can be sent a signal (this > can be valid even after Emacs has exited). The code should use calls > like kill (-2, 0) and kill (0, 0) only on platforms where we know the > calls do not test a process group. But on all platforms except Windows 9X we shouldn't see a negative PID here, so what you say is purely theoretical, no? > Even on MS Windows 98 we should check that TYPE_MINIMUM (pid_t) <= pid. Since pid_t is typedefed as 'int', that's always true, no? > Also, is there a special meaning for kill (0, 0) on MS Windows 98? No. And our emulation of 'kill' fails with EPERM when called witgh both arguments zero. > If so, we should also check that pid != 0. There are no processes on Windows whose PID is zero, so getting zero here is impossible. > Do any MS-Windows platforms support process groups, i.e., kill (-2, 0) > operates on process group 2 rather than on an individual process with > process ID -2? If so, these platforms should be careful too, and should > not use kill (-2, 0) or kill (0, 0). Windows does support process groups, but our emulation of 'kill' pretends that each process is its own group. > How about the attached patch instead? You can adjust the > Microsoft-specific .h files to define VALID_PROCESS_ID appropriately for > MS Windows 98, and for any other MS platform where kill (-2, 0) is known > to check for just the individual process -2. Fine with me, please install and I will followup. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 13:57:20 2024 Received: (at 71477) by debbugs.gnu.org; 12 Jun 2024 17:57:20 +0000 Received: from localhost ([127.0.0.1]:40091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHSDo-000350-Bb for submit@debbugs.gnu.org; Wed, 12 Jun 2024 13:57:20 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:56486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHSDk-00034m-5L for 71477@debbugs.gnu.org; Wed, 12 Jun 2024 13:57:18 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 8B1493C011BD4; Wed, 12 Jun 2024 10:57:11 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id a_o379x1v5sf; Wed, 12 Jun 2024 10:57:11 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 3E6033C011BD7; Wed, 12 Jun 2024 10:57:11 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 3E6033C011BD7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1718215031; bh=Yjtt1r/zzaNjRLUnphRmwKsxSU3ApoUYgC7ZLAjRIrE=; h=Message-ID:Date:MIME-Version:To:From; b=FSrTuOwAtlshm4EzQnvpThI+51Bajo51wvRaORsvX0Y5DQrZNPQR3nPkIQMKsFP0O /dJ8LJKtxb5g9naeB1VtjTrtrRAwYyCCuwl0Y74sPR9Pg+A/69LAf/XOjZNaXYsQUK Zo5lGTfF+p5/KZbr1TOpiO8gTCwuNzNOyb4lTsnVNuIq4sFTbuB3TfEphY27oDiAv7 fF0ezTUzLwTao6U+691EpBcjIQ19rgAYiLm7/HkztFe6b3/ltfOMAKyObMZmzvtPfg fd/PhI5SgXvgQPPtk0LdS7F5KTr6BkUS0xU/ICQ2vV4a0nujHvfW5lrnK6rQKk0V+p KFpXVsRfhyxuA== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id QDbyq5PrVUWL; Wed, 12 Jun 2024 10:57:11 -0700 (PDT) Received: from [192.168.254.12] (unknown [47.154.17.165]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 22A893C011BD4; Wed, 12 Jun 2024 10:57:11 -0700 (PDT) Message-ID: Date: Wed, 12 Jun 2024 10:57:10 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#71477: 30.0.50; Lock files are not deleted on Windows 98 To: Eli Zaretskii References: <87r0d4bzut.fsf.ref@yahoo.com> <87r0d4bzut.fsf@yahoo.com> <867cew8zgh.fsf@gnu.org> <87ikygb6hp.fsf@yahoo.com> <86h6e06kn5.fsf@gnu.org> <87bk47c4cd.fsf@yahoo.com> <86bk477vzx.fsf@gnu.org> <871q53c2ur.fsf@yahoo.com> <868qzb7uic.fsf@gnu.org> <87jzivamzp.fsf@yahoo.com> <86h6dy1saf.fsf@gnu.org> <531dbf85-2554-43aa-bca1-db50e0bf2306@cs.ucla.edu> <86sexiytlx.fsf@gnu.org> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <86sexiytlx.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71477 Cc: luangruo@yahoo.com, 71477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2024-06-12 10:10, Eli Zaretskii wrote: > But on all platforms except Windows 9X we shouldn't see a negative PID > here, so what you say is purely theoretical, no? No, because that value doesn't come from a pid_t that the system gave us as a process ID. It comes from the file system, and so could be invalid as a process ID. That's why the code already checks that pid <= TYPE_MAXIMUM (pid_t). Such a check wouldn't be needed if the pid were a valid process ID. >> Even on MS Windows 98 we should check that TYPE_MINIMUM (pid_t) <= pid. > > Since pid_t is typedefed as 'int', that's always true, no? No, because the code is checking 'pid', which is of type intmax_t not pid_t. (And anyway pid_t need not be 'int'.) > No. And our emulation of 'kill' fails with EPERM when called witgh > both arguments zero. In that case there's no need to worry about pid == 0 here. > Fine with me, please install and I will followup. OK, installed. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 13 04:08:38 2024 Received: (at 71477-done) by debbugs.gnu.org; 13 Jun 2024 08:08:38 +0000 Received: from localhost ([127.0.0.1]:32850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHfVd-0005ny-Qa for submit@debbugs.gnu.org; Thu, 13 Jun 2024 04:08:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHfVc-0005nc-04 for 71477-done@debbugs.gnu.org; Thu, 13 Jun 2024 04:08:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHfTR-0008Ad-2B; Thu, 13 Jun 2024 04:06:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6MQtdz7fjYyt5eycPIhtMs1Iv0pdUycwKYDTqde7IEA=; b=r7lhB1MVnMY6 TqKNYzVJmmWY0wqPQVIHBUOnX97GJPqjGKAj56HyOpZcCkW3zGIIXaUpzSb8fu3VixbCgKhVKhalT OG1af6iZa/G0EgG9WF9iVeFvreRJ1jQeTf6bUPTrx3l5SRiCY6cye8vaKT3Ywgv/WdrMbgGlQ9KOl stpAKkI43SayB4MNdJq97yQQWRsAgR9ED6bFFt7uhHVPBP0BCzHpz99PecqL0NjPk1izjwuLa7MrO lP8ZwheKrcRO/aoZAn8Tw+syLe4f2PSspknRgahG0binYbA55B3QsFD4K3robz82ZNJvKHkwa8qkx jrVXVTV0p+T9j8KUoBICEw==; Date: Thu, 13 Jun 2024 11:06:17 +0300 Message-Id: <86msnpz2py.fsf@gnu.org> From: Eli Zaretskii To: luangruo@yahoo.com, Paul Eggert In-Reply-To: (message from Paul Eggert on Wed, 12 Jun 2024 10:57:10 -0700) Subject: Re: bug#71477: 30.0.50; Lock files are not deleted on Windows 98 References: <87r0d4bzut.fsf.ref@yahoo.com> <87r0d4bzut.fsf@yahoo.com> <867cew8zgh.fsf@gnu.org> <87ikygb6hp.fsf@yahoo.com> <86h6e06kn5.fsf@gnu.org> <87bk47c4cd.fsf@yahoo.com> <86bk477vzx.fsf@gnu.org> <871q53c2ur.fsf@yahoo.com> <868qzb7uic.fsf@gnu.org> <87jzivamzp.fsf@yahoo.com> <86h6dy1saf.fsf@gnu.org> <531dbf85-2554-43aa-bca1-db50e0bf2306@cs.ucla.edu> <86sexiytlx.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71477-done Cc: 71477-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 12 Jun 2024 10:57:10 -0700 > Cc: luangruo@yahoo.com, 71477@debbugs.gnu.org > From: Paul Eggert > > > Fine with me, please install and I will followup. > > OK, installed. Thanks, I've now installed the followup bits. Po Lu, please test if the result works on Windows 9X when you have time. I'm closing the bug for now; please reopen with new information if the new code still doesn't work. From unknown Tue Aug 19 07:26:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 11 Jul 2024 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator