GNU bug report logs - #71469
font-lock does not apply standard faces and their descendants

Previous Next

Package: emacs;

Reported by: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>

Date: Mon, 10 Jun 2024 12:33:02 UTC

Severity: normal

Fixed in version 31.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 71469 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#71469: font-lock does not apply standard faces and their descendants
Date: Wed, 09 Oct 2024 11:58:57 +0300
On Wed, 2024-10-09 at 10:43 +0200, Robert Pluim wrote:
> > > > > > On Tue, 08 Oct 2024 16:25:32 +0300, Konstantin Kharlamov
> > > > > > <Hi-Angel <at> yandex.ru> said:
>     >> 
>     >> "use value 'font-lock-comment-face directly instead"
> 
>     Konstantin> Maybe "pass font-lock-comment-face as a symbol
> instead"? To understand
>     Konstantin> what "directly" means one would have to notice the
> lone singular quote,
>     Konstantin> which I didn't when I read the suggestion, so I
> imagine I'd feel
>     Konstantin> confused had I not know what the warning is about.
> 
> Then the question becomes "how do I pass font-lock-comment-face as a
> symbol", to which the answer is 'font-lock-comment-face, which is in
> my suggestion :-)

Well, yeah, this implies a user knows what "a lisp symbol" is. I like
your suggestion to include the quote:

> How about "use quoted value 'font-lock-comment-face directly
> instead"?

I'm wondering whether "directly" makes this sentence any more clear or
maybe it's excessive? So like, maybe just "use quoted value 'font-lock-
comment-face instead"? Also, "the value" may be ambiguous here (because
`foo` is a value and `'foo` is a symbol, so we kind end up overloading
the meaning in the sentence) so maybe even make it shorter: "pass
'font-lock-comment-face quoted instead"? (FWIW, english isn't my native
language, Idk if the sentence flow sounds okay here)




This bug report was last modified 151 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.