From unknown Wed Jun 18 23:16:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#71469 <71469@debbugs.gnu.org> To: bug#71469 <71469@debbugs.gnu.org> Subject: Status: font-lock does not apply standard faces and their descendants Reply-To: bug#71469 <71469@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:16:48 +0000 retitle 71469 font-lock does not apply standard faces and their descendants reassign 71469 emacs submitter 71469 Konstantin Kharlamov severity 71469 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 08:32:33 2024 Received: (at submit) by debbugs.gnu.org; 10 Jun 2024 12:32:34 +0000 Received: from localhost ([127.0.0.1]:59291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGeCP-00046N-Gj for submit@debbugs.gnu.org; Mon, 10 Jun 2024 08:32:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:41086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGeCM-00045G-Dy for submit@debbugs.gnu.org; Mon, 10 Jun 2024 08:32:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGdgl-0007IS-1u for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2024 07:59:52 -0400 Received: from forward103c.mail.yandex.net ([2a02:6b8:c03:500:1:45:d181:d103]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGdgf-0000WY-KG for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2024 07:59:49 -0400 Received: from mail-nwsmtp-smtp-production-main-17.iva.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-17.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:201a:0:640:4af0:0]) by forward103c.mail.yandex.net (Yandex) with ESMTPS id 2829860B1D for ; Mon, 10 Jun 2024 14:59:38 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-17.iva.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id bxbmcD1oBuQ0-ct126Mn6; Mon, 10 Jun 2024 14:59:37 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1718020777; bh=uPyP9UVIP6AZX662pn+J7F+ceYALt1XaaKnqi3XKPJM=; h=Date:To:From:Subject:Message-ID; b=KpShXcB6zL4hCeTaQP71BklvhGoMIMUI4pOoRTM+MUNnn1/Ym1w3kKRZ1shJX90rP AxIZ4aDJiEb20A97M7x0Yo8G9JvKhWAZfMkkU2Sl8izwpkVbitWzZKPyc+X104fcB4 ndxplyAyxlaFPGxRikdeiQcCyXYRhvdwK7zytNe4= Authentication-Results: mail-nwsmtp-smtp-production-main-17.iva.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: Subject: font-lock does not apply standard faces and their descendants From: Konstantin Kharlamov To: bug-gnu-emacs@gnu.org Date: Mon, 10 Jun 2024 14:59:37 +0300 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.2 MIME-Version: 1.0 Received-SPF: pass client-ip=2a02:6b8:c03:500:1:45:d181:d103; envelope-from=Hi-Angel@yandex.ru; helo=forward103c.mail.yandex.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) While trying to add a face to a major mode I found that both standard faces=C2=B9 and inherited ones are ignored completely. In steps below I create a simple major mode and it uses an inherited face, but face does not get applied. NOTE: if you replace the inherited face with, for example, `font-lock-constant-face`, it will get highlighted. I.e. the problem somehow bound to faces. # Steps to reproduce 1. Create `test.el` file as follows: (defface test-face '((t (:inherit bold))) "Test face.") (define-derived-mode my-mode fundamental-mode "My Mode" "A minimal mode that highlights 'hello world' text." (font-lock-add-keywords nil '(("hello world" 0 test-face))) (font-lock-flush)) (add-to-list 'auto-mode-alist (cons "test.txt" 'my-mode)) (provide 'my-mode) And `test.txt` as follows: =20 =3D=3D> hello world <=3D=3D 2. Launch Emacs as `emacs -Q -l test.el test.txt` 3. Put a caret over the word `hello` and evaluate M-x describe-char ## Expected The description buffer mentions that `face` is `test-face`. ## Actual There is no `face` property at all. # Additional information Versions tested: Emacs built from February master and a stable 29.3 The problem actually doesn't seem to be related to `defface`, because passing `bold` to the `font-lock-add-keywords` had similarly no effect for some reason. More likely it's related to the "standard faces". 1: https://www.gnu.org/software/emacs/manual/html_node/emacs/Standard-Faces= .html From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 09:42:47 2024 Received: (at 71469) by debbugs.gnu.org; 10 Jun 2024 13:42:47 +0000 Received: from localhost ([127.0.0.1]:34219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGfIN-0007Og-10 for submit@debbugs.gnu.org; Mon, 10 Jun 2024 09:42:47 -0400 Received: from forward502b.mail.yandex.net ([178.154.239.146]:54346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGfIJ-0007OP-VH for 71469@debbugs.gnu.org; Mon, 10 Jun 2024 09:42:45 -0400 Received: from mail-nwsmtp-smtp-production-main-25.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-25.sas.yp-c.yandex.net [IPv6:2a02:6b8:c08:c8ad:0:640:7c75:0]) by forward502b.mail.yandex.net (Yandex) with ESMTPS id A1A6B5E6B4; Mon, 10 Jun 2024 16:41:54 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-25.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id rfdeUv4XsKo0-q2uk7iXG; Mon, 10 Jun 2024 16:41:54 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1718026914; bh=engnPy2cg+AJAOV/aDxxRq1hlG0PecjrseAcQpgtTjw=; h=Date:In-Reply-To:Cc:References:To:From:Subject:Message-ID; b=mKQwQegzDFnp1VbqHHp7jG41m8kDnQOD1wMMtaVcl+DLE5eMOw/ejYUzN/ppryVnN /39XMY7PfDyO75kNkitaOGfEgfqKUU7Sg/avyLVu8aCikfqdOdmmRDWIBmWDfTHlk6 3BnHYU9BzXiX/JtJaDpRHODs5IbUjcq714Zqloyk= Authentication-Results: mail-nwsmtp-smtp-production-main-25.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> Subject: [PATCH] Re: bug#71469: font-lock does not apply standard faces and their descendants From: Konstantin Kharlamov To: Eli Zaretskii Date: Mon, 10 Jun 2024 16:41:53 +0300 In-Reply-To: <86tti17y8y.fsf@gnu.org> References: <86tti17y8y.fsf@gnu.org> Content-Type: multipart/mixed; boundary="=-gr4aJWjLqF4eAUxSSPDR" User-Agent: Evolution 3.52.2 MIME-Version: 1.0 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71469 Cc: 71469@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-gr4aJWjLqF4eAUxSSPDR Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2024-06-10 at 15:55 +0300, Eli Zaretskii wrote: > tags 71469 notabug > thanks >=20 > > From: Konstantin Kharlamov > > Date: Mon, 10 Jun 2024 14:59:37 +0300 > >=20 > > =C2=A0=C2=A0=C2=A0=C2=A0 (defface test-face > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 '((t (:inherit bold))) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Test face.") > >=20 > > =C2=A0=C2=A0=C2=A0=C2=A0 (define-derived-mode my-mode fundamental-mode = "My Mode" > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "A minimal mode that highlights 'h= ello world' text." > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (font-lock-add-keywords nil '(("he= llo world" 0 test-face))) >=20 > From the ELisp manual: >=20 > =C2=A0=C2=A0 Each element of =E2=80=98font-lock-keywords=E2=80=99 should = have one of these > forms: > =C2=A0=C2=A0 [...] > =C2=A0 =E2=80=98(MATCHER . FACESPEC)=E2=80=99 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 In this kind of element, FACESPEC is= an expression whose value > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 specifies the face to use for highli= ghting.=C2=A0 In the simplest > case, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 FACESPEC is a Lisp variable (a symbo= l) whose value is a face > name. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >=20 > IOW, there's a difference between a symbol of a variable whose value > is a face name, and that face name itself. >=20 > This works for me: >=20 > =C2=A0 (defface test-face > =C2=A0=C2=A0=C2=A0 '((t (:inherit bold))) > =C2=A0=C2=A0=C2=A0 "Test face.") > =C2=A0 (defvar test-face 'test-face > =C2=A0=C2=A0=C2=A0 "Face name to use for My Mode.") >=20 > =C2=A0 (define-derived-mode my-mode fundamental-mode "My Mode" > =C2=A0=C2=A0=C2=A0 "A minimal mode that highlights 'hello world' text." > =C2=A0=C2=A0=C2=A0 (font-lock-add-keywords nil '(("hello world" 0 test-fa= ce))) > =C2=A0=C2=A0=C2=A0 (font-lock-flush)) > =C2=A0 (add-to-list 'auto-mode-alist (cons "test.txt" 'my-mode)) > =C2=A0 (provide 'my-mode) Ooh, I see, thank you! So using e.g. a `'test-face` also makes it work. I'm wondering if it would be okay to mention such nuance in the "standard faces" documentation, such as with the attached patch? I think it would be really helpful, because the nuance of how it works is not obvious at all (it would be much easier if none of the faces such as font-lock-keyword-face, would be defining a variable). I've spent for about an hour on this trying in different ways to make it work, and I also think it wasn't the first time I stumbled upon this. Having the "standard faces" mention that interaction nuance I think could be helpful for people in the future. --=-gr4aJWjLqF4eAUxSSPDR Content-Disposition: attachment; filename="1.patch" Content-Type: text/x-patch; name="1.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAwMjgxMWI2NDAwMjU5YzBkOWIyZGVkY2NhNzZmZWM3NzFkY2Q4MzlhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLb25zdGFudGluIEtoYXJsYW1vdiA8SGktQW5nZWxAeWFuZGV4 LnJ1PgpEYXRlOiBNb24sIDEwIEp1biAyMDI0IDE2OjM0OjMwICswMzAwClN1YmplY3Q6IFtQQVRD SF0gTWVudGlvbiBpbnRlcmFjdGlvbiBvZiBzdGFuZGFyZCBmYWNlcyB3aXRoIGZvbnQtbG9jay1r ZXl3b3JkcwoKKiBkb2MvZW1hY3MvZGlzcGxheS50ZXhpIChzdGFuZGFyZCBmYWNlcyk6IG1lbnRp b24gdGhhdCB0aGVzZSBmYWNlcyBkbwpub3QgcHJvZHVjZSB2YXJpYWJsZXMgYW5kIHNvIGNhbid0 IGJlIHBhc3NlZCB0byBmb250LWxvY2sta2V5d29yZHMgYXMKaXMuCi0tLQogZG9jL2VtYWNzL2Rp c3BsYXkudGV4aSB8IDQgKysrLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RvYy9lbWFjcy9kaXNwbGF5LnRleGkgYi9kb2MvZW1h Y3MvZGlzcGxheS50ZXhpCmluZGV4IDhmMjJlM2M4OGRhLi5iY2JlNjhkMjFlYSAxMDA2NDQKLS0t IGEvZG9jL2VtYWNzL2Rpc3BsYXkudGV4aQorKysgYi9kb2MvZW1hY3MvZGlzcGxheS50ZXhpCkBA IC02NDcsNyArNjQ3LDkgQEAgU3RhbmRhcmQgRmFjZXMKIEBjaW5kZXggc3RhbmRhcmQgZmFjZXMK IAogICBIZXJlIGFyZSB0aGUgc3RhbmRhcmQgZmFjZXMgZm9yIHNwZWNpZnlpbmcgdGV4dCBhcHBl YXJhbmNlLiAgWW91IGNhbgotYXBwbHkgdGhlbSB0byBzcGVjaWZpYyB0ZXh0IHdoZW4geW91IHdh bnQgdGhlIGVmZmVjdHMgdGhleSBwcm9kdWNlLgorYXBwbHkgdGhlbSB0byBzcGVjaWZpYyB0ZXh0 IHdoZW4geW91IHdhbnQgdGhlIGVmZmVjdHMgdGhleSBwcm9kdWNlLiBOb3RlCit0aGF0IHRoZXNl IGZhY2VzIGRvIG5vdCBkZWZpbmUgdmFyaWFibGVzLCBzbyB0byBwYXNzIHN1Y2ggZmFjZSB0bwor QGNvZGV7Zm9udC1sb2NrLWtleXdvcmRzfSB5b3UgaGF2ZSB0byBxdW90ZSBpdC4KIAogQHRhYmxl IEBjb2RlCiBAaXRlbSBkZWZhdWx0Ci0tIAoyLjQ1LjIKCg== --=-gr4aJWjLqF4eAUxSSPDR-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 11:12:19 2024 Received: (at 71469) by debbugs.gnu.org; 10 Jun 2024 15:12:19 +0000 Received: from localhost ([127.0.0.1]:40738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGgh0-0003bT-An for submit@debbugs.gnu.org; Mon, 10 Jun 2024 11:12:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGggu-0003Zs-2j; Mon, 10 Jun 2024 11:12:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGeZe-0003dT-1D; Mon, 10 Jun 2024 08:56:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=2Z35AxSPEDyEihgKYjGyflawIpKwvx96G58hJ8SuaNM=; b=m+9dQGvSDmt/n8ymBWfk ComPpIcm3Z84USuWDu6MkZKASoeVmNTyzvLC8y/EWQaemeNHzxat8bYKobWy8IeGaLjMkK4C3+NoP zQ87vzuSCFLKDpGbKs2DUTSBw1TW1xv2aBPotRA4JKSgWKGAe2WVKsGgazoQ1tYnlBLGn8S5COu1K iGyUEEDwJf5KJUCELq/KH0Zpv/UByTuvcCQMS2DDy5LDxPYVxVMQq1rHap5+6nvuXtufus24O83O5 kKApBx1DSM2RlT0VwBa318OAw86pXkcgHu53kBh4H01OxQEBX2uXJgcMQ0sqRqW9SPqHxOh1PkDwM wwyFbplUq2CZUg==; Date: Mon, 10 Jun 2024 15:55:57 +0300 Message-Id: <86tti17y8y.fsf@gnu.org> From: Eli Zaretskii To: Konstantin Kharlamov In-Reply-To: (message from Konstantin Kharlamov on Mon, 10 Jun 2024 14:59:37 +0300) Subject: Re: bug#71469: font-lock does not apply standard faces and their descendants References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71469 Cc: 71469@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 71469 notabug thanks > From: Konstantin Kharlamov > Date: Mon, 10 Jun 2024 14:59:37 +0300 > > (defface test-face > '((t (:inherit bold))) > "Test face.") > > (define-derived-mode my-mode fundamental-mode "My Mode" > "A minimal mode that highlights 'hello world' text." > (font-lock-add-keywords nil '(("hello world" 0 test-face))) >From the ELisp manual: Each element of ‘font-lock-keywords’ should have one of these forms: [...] ‘(MATCHER . FACESPEC)’ In this kind of element, FACESPEC is an expression whose value specifies the face to use for highlighting. In the simplest case, FACESPEC is a Lisp variable (a symbol) whose value is a face name. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ IOW, there's a difference between a symbol of a variable whose value is a face name, and that face name itself. This works for me: (defface test-face '((t (:inherit bold))) "Test face.") (defvar test-face 'test-face "Face name to use for My Mode.") (define-derived-mode my-mode fundamental-mode "My Mode" "A minimal mode that highlights 'hello world' text." (font-lock-add-keywords nil '(("hello world" 0 test-face))) (font-lock-flush)) (add-to-list 'auto-mode-alist (cons "test.txt" 'my-mode)) (provide 'my-mode) From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 11:17:33 2024 Received: (at 71469) by debbugs.gnu.org; 10 Jun 2024 15:17:33 +0000 Received: from localhost ([127.0.0.1]:41172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGgm4-0006hm-KD for submit@debbugs.gnu.org; Mon, 10 Jun 2024 11:17:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGgm1-0006hI-VO for 71469@debbugs.gnu.org; Mon, 10 Jun 2024 11:17:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGgld-00004s-Qt; Mon, 10 Jun 2024 11:17:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qe3mlNImGy78fMuTmGvCtl/kgnZ7F7l+chEMiumRjns=; b=PJq7jmlqljYL VhgBnkrB3JWIvCUfKes/k33HeEt87YYHwQ0/026ymJjdv0krcc1Za8+jiHW03BlC44x3XCydozx4V BIZsi2yTBOR7KMfjRLewaqAEUQjLOQbcxUcicNgonSvZKjqVkrUqSmCUrv2yKiL/M7SYzDguZoAbU p6ynvHE4TzF50ekUJefkr0qO7rvyouYycUaRqjTx0RGBBSTfwqCtNb0qj7CYgl7q7HQK1LqVy23YZ 35pc47gdiewhagzmjjReJXcB6vdcHauuLEfWlOxBRxLVM2ZkCP/Y277Y26idO4QSRwvTdjKVnsq/v QwIGuUgq+AXo982YdwFscA==; Date: Mon, 10 Jun 2024 18:17:02 +0300 Message-Id: <86plso96a9.fsf@gnu.org> From: Eli Zaretskii To: Konstantin Kharlamov , Stefan Monnier In-Reply-To: <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> (message from Konstantin Kharlamov on Mon, 10 Jun 2024 16:41:53 +0300) Subject: Re: [PATCH] Re: bug#71469: font-lock does not apply standard faces and their descendants References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71469 Cc: 71469@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Konstantin Kharlamov > Cc: 71469@debbugs.gnu.org > Date: Mon, 10 Jun 2024 16:41:53 +0300 > > I'm wondering if it would be okay to mention such nuance in the > "standard faces" documentation, such as with the attached patch? I > think it would be really helpful, because the nuance of how it works is > not obvious at all (it would be much easier if none of the faces such > as font-lock-keyword-face, would be defining a variable). I've spent > for about an hour on this trying in different ways to make it work, and > I also think it wasn't the first time I stumbled upon this. Having the > "standard faces" mention that interaction nuance I think could be > helpful for people in the future. > > > From 02811b6400259c0d9b2dedcca76fec771dcd839a Mon Sep 17 00:00:00 2001 > From: Konstantin Kharlamov > Date: Mon, 10 Jun 2024 16:34:30 +0300 > Subject: [PATCH] Mention interaction of standard faces with font-lock-keywords > > * doc/emacs/display.texi (standard faces): mention that these faces do > not produce variables and so can't be passed to font-lock-keywords as > is. > --- > doc/emacs/display.texi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/doc/emacs/display.texi b/doc/emacs/display.texi > index 8f22e3c88da..bcbe68d21ea 100644 > --- a/doc/emacs/display.texi > +++ b/doc/emacs/display.texi > @@ -647,7 +647,9 @@ Standard Faces > @cindex standard faces > > Here are the standard faces for specifying text appearance. You can > -apply them to specific text when you want the effects they produce. > +apply them to specific text when you want the effects they produce. Note > +that these faces do not define variables, so to pass such face to > +@code{font-lock-keywords} you have to quote it. I don't think I agree with this addition, so I added Stefan to this discussion. Stefan, any comments? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 13:33:51 2024 Received: (at 71469) by debbugs.gnu.org; 10 Jun 2024 17:33:51 +0000 Received: from localhost ([127.0.0.1]:48577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGitz-00026H-Cr for submit@debbugs.gnu.org; Mon, 10 Jun 2024 13:33:51 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGitw-00025y-Ud for 71469@debbugs.gnu.org; Mon, 10 Jun 2024 13:33:49 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 39128808F6; Mon, 10 Jun 2024 13:26:22 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1718040381; bh=Qo/hvvySCkIwXLmexLT49OrybBeqGqdLDp+r9naE3nc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iTIXbjefr2RY484x7vcQ1xVJbvPZNTI/5vO59+0ftzeNW+GIi8SzDTbq1A2TioZJx 7zCthQWJytWbLa9Vp15WVk0NGowYLUwv0MlKgjfMTgEisJ7HDFWSPKAf2PbSR52UGV ti0DDRGTehTTGllPNauiD5hU94SNNwpXHCHU0WpSYnjnREBAwbccI+IHqPvIGJz2TA OV2uFjQqXEbl62mP0BtzcPJg7ZuLzMafUMFpdbI0addv/b+GBPAwHRbRKeDaQ4SMZk sKuH0wsj6D6rTJqqInl8Zu+QCQ7oIaTW5rRMPzVy2szvfempg7QAPsELrIe9+LogY5 21zP4NhtasogQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1C7CA8062B; Mon, 10 Jun 2024 13:26:21 -0400 (EDT) Received: from pastel (unknown [24.140.236.196]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E675612024D; Mon, 10 Jun 2024 13:26:20 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: [PATCH] Re: bug#71469: font-lock does not apply standard faces and their descendants In-Reply-To: <86plso96a9.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 10 Jun 2024 18:17:02 +0300") Message-ID: References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> <86plso96a9.fsf@gnu.org> Date: Mon, 10 Jun 2024 13:26:19 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.111 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71469 Cc: 71469@debbugs.gnu.org, Konstantin Kharlamov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I'm wondering if it would be okay to mention such nuance in the >> "standard faces" documentation, such as with the attached patch? I >> think it would be really helpful, because the nuance of how it works is >> not obvious at all (it would be much easier if none of the faces such >> as font-lock-keyword-face, would be defining a variable). No face defines a variable. Some faces (mostly font-lock faces) have an associated variable whose content is "the face name" (which is also the variable's name), but it's not a result of the face itself. It's a separate explicit definition of a variable with the same name as the face. And I agree that it would be simpler if we didn't have those, but they've been with us since `font-lock.el` in Emacs-19, so it's not easy to get rid of them. >> Here are the standard faces for specifying text appearance. You can >> -apply them to specific text when you want the effects they produce. >> +apply them to specific text when you want the effects they produce. Note >> +that these faces do not define variables, so to pass such face to >> +@code{font-lock-keywords} you have to quote it. You *always* need to quote the face name. Otherwise you're not referring to the face but to a variable of the same name (and ideally we'd want to get rid of the cases where this happens to work, because the only upside is to save you from typing a quote character, while the downside is to encourage confusion). Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 04 21:40:20 2024 Received: (at 71469) by debbugs.gnu.org; 5 Oct 2024 01:40:20 +0000 Received: from localhost ([127.0.0.1]:37017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swtmN-0002xf-Id for submit@debbugs.gnu.org; Fri, 04 Oct 2024 21:40:20 -0400 Received: from mail-ed1-f54.google.com ([209.85.208.54]:59864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swtmL-0002s7-0H for 71469@debbugs.gnu.org; Fri, 04 Oct 2024 21:40:17 -0400 Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5c718bb04a3so3363188a12.3 for <71469@debbugs.gnu.org>; Fri, 04 Oct 2024 18:40:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728092347; x=1728697147; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=/FiHRoVZyK2pNDyC75ua0KQv0i5IbLu7JbVbNVW4CKY=; b=hlV2vSunoge7jbAswX7zkkEWKrFFTf+AYojpltrWUp3ncjeOBcOehJwFodjL7903XY 5fcFmfr3PzqH+d2KzKB4pTDMIWNocE7+1+jZPnhO+rJfZgOtuf429FulTmOa3teiVVUz ptNeXmySE79/Cp0h/UR3GwT7AMTYp/treD5d0Ab/KqxiudHhmGqcGGCSKP74wJP6RifT TYzt1u7wNKKF3F5ChB7/wQUct+L/pcfyJKn7pCaV4sqNLRgk8lzdCHQaiocBTp+q+JOw j7lw+BCcVb5+EmGLbCx/PQOmIA8ndngEKymPYa7o3Ro//ezCuBz3ScIrAvWkHJKnxYcf DT3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728092347; x=1728697147; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/FiHRoVZyK2pNDyC75ua0KQv0i5IbLu7JbVbNVW4CKY=; b=aQuEL/SGqPtYEyymir1cLdaukUxh+aYI0z45r+ZGLWfietXt/D+WbFtkgcT8Rkw9mj vKewlJ7hHtD1/eVs9PqxcRnPro90mFqnjOHWVpEBvst4RfJKwy7zi+VWodgNGyH45pr+ IuiJtInX2r4UNR1M7/ulQZVXBYfMeqJLidiCmPxBG7FEC+YScp9SVQ8eMLoApIzT2jCr A7vdIFmw4asKrrervvAPC/caUzfFwzMqO62fAiqNIpJFkji8L1MX/kmI9Cdjb3xA4hA3 1uMlUVlk9X6ugpzuYgnm8oQn0BLIxjGJy9Qd6EzdDGVvqwDSVs+jOfdR7QY7xk/Tnys0 UuyQ== X-Forwarded-Encrypted: i=1; AJvYcCWC4KWq60Hpop/fkSdY/SL9RljsPzDxYDNW1EKVEoCz15LVn4mZyngdj5OjXLb+s8oq/s/81Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0YziQwJAiRqqgF9Mdr0FqciKuQFKK+MQYHRA0R6CA5nTe4ynamW1 a6CMn5MG5xU5Uc8Qd71zJEGc9TAOWfgKbzLZnlNNwJH0F7oGoLqEww8HW7n9V2WfAkCA6GWAHyx GH8XwbxITi+L5RrlBh2UDmPCrgajoXg== X-Google-Smtp-Source: AGHT+IEJVlRk7uSlhMoV+VdjY172QteqT1GNNZKDEQZ95tWR/tmO7pPIg3pb+u32TJtyts8CLIt/r2w0pDJsVuBoOcM= X-Received: by 2002:a05:6402:34d0:b0:5c8:8381:c246 with SMTP id 4fb4d7f45d1cf-5c8d2dfda00mr3564393a12.3.1728092347114; Fri, 04 Oct 2024 18:39:07 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 4 Oct 2024 18:39:06 -0700 From: Stefan Kangas In-Reply-To: (Stefan Monnier's message of "Mon, 10 Jun 2024 13:26:19 -0400") References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> <86plso96a9.fsf@gnu.org> MIME-Version: 1.0 Date: Fri, 4 Oct 2024 18:39:06 -0700 Message-ID: Subject: Re: bug#71469: font-lock does not apply standard faces and their descendants To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71469 Cc: Eli Zaretskii , 71469@debbugs.gnu.org, Konstantin Kharlamov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >>> I'm wondering if it would be okay to mention such nuance in the >>> "standard faces" documentation, such as with the attached patch? I >>> think it would be really helpful, because the nuance of how it works is >>> not obvious at all (it would be much easier if none of the faces such >>> as font-lock-keyword-face, would be defining a variable). > > No face defines a variable. > > Some faces (mostly font-lock faces) have an associated variable whose > content is "the face name" (which is also the variable's name), but it's > not a result of the face itself. It's a separate explicit definition of > a variable with the same name as the face. > > And I agree that it would be simpler if we didn't have those, but > they've been with us since `font-lock.el` in Emacs-19, so it's not easy > to get rid of them. We have occasionally declared things obsolete with the understanding that they'll be deleted much later than the normal "10 years, give or take". See the comment in `interactive-p', for example. The patch below gives me 64 warnings in our tree. I'm not sure if it's worth installing or not. diff --git a/lisp/font-lock.el b/lisp/font-lock.el index 7b077a826bf..7787af43bc9 100644 --- a/lisp/font-lock.el +++ b/lisp/font-lock.el @@ -316,46 +316,74 @@ font-lock-verbose ;; need to create variables that specify face names. Simply using ;; faces directly is enough. Font-lock is not a template to be ;; followed in this area. +(make-obsolete-variable 'font-lock-comment-face + "use 'font-lock-comment-face instead." "31.1") (defvar font-lock-comment-face 'font-lock-comment-face "Face name to use for comments.") +(make-obsolete-variable 'font-lock-comment-delimiter-face + "use 'font-lock-comment-delimiter-face instead." "31.1") (defvar font-lock-comment-delimiter-face 'font-lock-comment-delimiter-face "Face name to use for comment delimiters.") +(make-obsolete-variable 'font-lock-string-face + "use 'font-lock-string-face instead." "31.1") (defvar font-lock-string-face 'font-lock-string-face "Face name to use for strings.") +(make-obsolete-variable 'font-lock-doc-face + "use 'font-lock-doc-face instead." "31.1") (defvar font-lock-doc-face 'font-lock-doc-face "Face name to use for documentation.") +(make-obsolete-variable 'font-lock-doc-markup-face + "use 'font-lock-doc-markup-face instead." "31.1") (defvar font-lock-doc-markup-face 'font-lock-doc-markup-face "Face name to use for documentation mark-up.") +(make-obsolete-variable 'font-lock-keyword-face + "use 'font-lock-keyword-face instead." "31.1") (defvar font-lock-keyword-face 'font-lock-keyword-face "Face name to use for keywords.") +(make-obsolete-variable 'font-lock-builtin-face + "use 'font-lock-builtin-face instead." "31.1") (defvar font-lock-builtin-face 'font-lock-builtin-face "Face name to use for builtins.") +(make-obsolete-variable 'font-lock-function-name-face + "use 'font-lock-function-name-face instead." "31.1") (defvar font-lock-function-name-face 'font-lock-function-name-face "Face name to use for function names.") +(make-obsolete-variable 'font-lock-variable-name-face + "use 'font-lock-variable-name-face instead." "31.1") (defvar font-lock-variable-name-face 'font-lock-variable-name-face "Face name to use for variable names.") +(make-obsolete-variable 'font-lock-type-face + "use 'font-lock-type-face instead." "31.1") (defvar font-lock-type-face 'font-lock-type-face "Face name to use for type and class names.") +(make-obsolete-variable 'font-lock-constant-face + "use 'font-lock-constant-face instead." "31.1") (defvar font-lock-constant-face 'font-lock-constant-face "Face name to use for constant and label names.") +(make-obsolete-variable 'font-lock-warning-face + "use 'font-lock-warning-face instead." "31.1") (defvar font-lock-warning-face 'font-lock-warning-face "Face name to use for things that should stand out.") +(make-obsolete-variable 'font-lock-negation-char-face + "use 'font-lock-negation-char-face instead." "31.1") (defvar font-lock-negation-char-face 'font-lock-negation-char-face "Face name to use for easy to overlook negation. This can be an \"!\" or the \"n\" in \"ifndef\".") +(make-obsolete-variable 'font-lock-preprocessor-face + "use 'font-lock-preprocessor-face instead." "31.1") (defvar font-lock-preprocessor-face 'font-lock-preprocessor-face "Face name to use for preprocessor directives.") From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 09:06:41 2024 Received: (at 71469) by debbugs.gnu.org; 5 Oct 2024 13:06:42 +0000 Received: from localhost ([127.0.0.1]:37478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx4Ub-0006EN-LM for submit@debbugs.gnu.org; Sat, 05 Oct 2024 09:06:41 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sx4UZ-0006E8-Uv for 71469@debbugs.gnu.org; Sat, 05 Oct 2024 09:06:40 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4C9D9440FB0; Sat, 5 Oct 2024 09:06:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1728133586; bh=0Yo3HBPfoi+lVcWvJWb+LhnKJEg2ZXmzhb58t87dIQ8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=H7PTjs9SR+ksrWnyfaMqfvPHTieISp9E6Ac2deQh1HRvC/fNbfRUoScRMSKPrwRLz KVGFlhiIISqiCka7OC/y6l4ndLzP/Z3rysR5eQDjx6WbvkSxgXKhJxVSfGYMxVoNcq gcXD4blN2ZG5yC4qodBiSDxR+ScyOcxEftYcrbjDBJtF5qgVHq95AJZg1ydLQHbpny OR9PQVraPpbhVcWwGQvZwg/BpakTcVkFI5uLJsQv11m9wefLf5X6a5LSKu+W9CTqQ8 Ul43gl6P0Ie4LY4CZnLRXTKMfF9jUzq2PkWcRgqbQIOkOGNOEDmQKr9p4q+DW6N5Qt 02mz92zdPtVOg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C6852440C51; Sat, 5 Oct 2024 09:06:26 -0400 (EDT) Received: from pastel (unknown [216.154.14.167]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9257112023B; Sat, 5 Oct 2024 09:06:26 -0400 (EDT) From: Stefan Monnier To: Stefan Kangas Subject: Re: bug#71469: font-lock does not apply standard faces and their descendants In-Reply-To: (Stefan Kangas's message of "Fri, 4 Oct 2024 18:39:06 -0700") Message-ID: References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> <86plso96a9.fsf@gnu.org> Date: Sat, 05 Oct 2024 09:06:24 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.159 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71469 Cc: Eli Zaretskii , 71469@debbugs.gnu.org, Konstantin Kharlamov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > We have occasionally declared things obsolete with the understanding > that they'll be deleted much later than the normal "10 years, give or > take". See the comment in `interactive-p', for example. > > The patch below gives me 64 warnings in our tree. I'm not sure if it's > worth installing or not. FWIW, it's a +1 from me (assuming we then silence the resulting warnings, of course). Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 08:58:55 2024 Received: (at 71469) by debbugs.gnu.org; 8 Oct 2024 12:58:55 +0000 Received: from localhost ([127.0.0.1]:51610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy9ni-0005Do-NJ for submit@debbugs.gnu.org; Tue, 08 Oct 2024 08:58:55 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:60440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy9nf-0005Df-Vm for 71469@debbugs.gnu.org; Tue, 08 Oct 2024 08:58:53 -0400 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-42cae4eb026so58075725e9.0 for <71469@debbugs.gnu.org>; Tue, 08 Oct 2024 05:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728392262; x=1728997062; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=CKPd+65HszeWuCkXeHBW5fPF6C+TtzM35dvi1OMabTI=; b=A+NRiyBHn7no1WC5HDRhvqpKtaJfewYT63y+NUxCZoZ2jnTB0qTYefXchD5W2qVYVz V+dMnLUGKZFFCKNFEfiI7yPuvTRRzVMV4diJH4E7SgaH7WxIghsk8Pd2h3DreVyIuXNM PwqTJDSOc2T/6z2qS4k7beaXfpFVDuH/rrJdie6GM6I1yLGjFDEGtL+jSGsnH0VfJyRF FbbSMI/ndE6GjgXQMqDh3cX3YU+FFTqsiuii/QxIv6Hw4XinCJGy74GXutbPwXPi0DZI WV0xLlbOLzp3Uw9EifRdwPGPfaEyL7JceP9/cyOu/LRNEIHU0MDYDkF9Aw2teFwT1QS4 8+PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728392262; x=1728997062; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CKPd+65HszeWuCkXeHBW5fPF6C+TtzM35dvi1OMabTI=; b=guMi9WOKZlr8xF2UHtvqAzNEGNx739qkS92PqnGZwE/KFuWtEnnp5s8gi8adD4+Uog UxC7FCV3DRyGr0+exQC6HcCt5uIsW/VdziDCqIfmPT6EdpJLYKE9PnaWr/5mqNSAKr4v yAJD8jRf1staL2FvTxGMRU2HcaifmHEmYESqvJJAkDylyx3yaplGAvWkuanRIbQJzE8O IMMiAGyIk/Xwn8XW8sHvGv6DTV3BwqW7e5+idT6sKxjvonHh9ypyztyRxlE5Yy32v97b Ti7jmjCdPWTg3AFzmChO9L7LpEUVQ79/73xU0++RyF49ugLg84YIJ2eb2GhbyMxRNgb1 jh3Q== X-Forwarded-Encrypted: i=1; AJvYcCUY0i3G8WcKrdDrGoLu8Fn/W4e/Szd1WIiQadE2Ln4ppHKacDxK8b+h6HYjQ+M+mqSiMALMOw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwSFrCL2rO5HKS/xew8T9QhnZhXxf9gXSX0y1ew1DRVzxjiuoih pQCe/XbWOWzk1hdbz3dTtW+xDi3zhOQV+iBSzhYz814tPbglelrf X-Google-Smtp-Source: AGHT+IFidoSuyJDlO+k1TtZPT2sCg3aEeojzdtf6ZiNkWwKoTXAs9XQn32PYnJeyCi2GH9sWgEF2Xg== X-Received: by 2002:a05:600c:510d:b0:42c:b45d:4a7b with SMTP id 5b1f17b1804b1-42f85ae9030mr115824455e9.25.1728392262110; Tue, 08 Oct 2024 05:57:42 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:2971:f165:b364:b372]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f89e85dd0sm109326895e9.4.2024.10.08.05.57.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 05:57:41 -0700 (PDT) From: Robert Pluim To: Stefan Kangas Subject: Re: bug#71469: font-lock does not apply standard faces and their descendants In-Reply-To: (Stefan Monnier via's message of "Sat, 05 Oct 2024 09:06:24 -0400") References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> <86plso96a9.fsf@gnu.org> Date: Tue, 08 Oct 2024 14:57:40 +0200 Message-ID: <87v7y2zr97.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71469 Cc: Eli Zaretskii , 71469@debbugs.gnu.org, Stefan Monnier , Konstantin Kharlamov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Sat, 05 Oct 2024 09:06:24 -0400, Stefan Monnier via "Bug reports f= or GNU Emacs, the Swiss army knife of text editors" = said: >> We have occasionally declared things obsolete with the understanding >> that they'll be deleted much later than the normal "10 years, give or >> take". See the comment in `interactive-p', for example. >>=20 >> The patch below gives me 64 warnings in our tree. I'm not sure if i= t's >> worth installing or not. Stefan> FWIW, it's a +1 from me (assuming we then silence the resulting Stefan> warnings, of course). emacs-lisp/lisp-mode.el:311:18: Warning: =E2=80=98font-lock-warning-face=E2= =80=99 is an obsolete variable (as of 31.1); use =E2=80=99font-lock-warning-face instead. sounds like a great way to cause confusion. How about: "use value 'font-lock-comment-face directly instead" or similar? Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 08 09:25:50 2024 Received: (at 71469) by debbugs.gnu.org; 8 Oct 2024 13:25:51 +0000 Received: from localhost ([127.0.0.1]:51690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syADm-0006w8-Bn for submit@debbugs.gnu.org; Tue, 08 Oct 2024 09:25:50 -0400 Received: from forward501a.mail.yandex.net ([178.154.239.81]:57118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syADi-0006vw-2g for 71469@debbugs.gnu.org; Tue, 08 Oct 2024 09:25:48 -0400 Received: from mail-nwsmtp-smtp-production-main-51.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-51.vla.yp-c.yandex.net [IPv6:2a02:6b8:c0f:4c80:0:640:a0f:0]) by forward501a.mail.yandex.net (Yandex) with ESMTPS id 5F41C61890; Tue, 8 Oct 2024 16:25:34 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-51.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id WPheaC9Tsa60-i9FEwgXk; Tue, 08 Oct 2024 16:25:33 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1728393934; bh=X7lZ0MnTsTVodXnVGhXTR5XMovEaPhfAxWVzS7VU+NI=; h=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID; b=gp9hE1Hfn53pSVEoNk6kdB7GQHyVa7/jVFgdjCQ73PJt/tazgZfNvWr4IrUd9fTJ0 l91qKoaN+6lsdHCFkPEYquntFprPoZ+QvF5qnN5r3uUnb90zYcPFEbbEZq17B7+9fS v3xQC22qkl/po89y4Lyvh4d00YHh4pa2kxGag7B4= Authentication-Results: mail-nwsmtp-smtp-production-main-51.vla.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <5882b135ea4b67309fb329fcb95fd06c50211b3a.camel@yandex.ru> Subject: Re: bug#71469: font-lock does not apply standard faces and their descendants From: Konstantin Kharlamov To: Robert Pluim , Stefan Kangas Date: Tue, 08 Oct 2024 16:25:32 +0300 In-Reply-To: <87v7y2zr97.fsf@gmail.com> References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> <86plso96a9.fsf@gnu.org> <87v7y2zr97.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 MIME-Version: 1.0 X-Yandex-Filter: 1 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71469 Cc: Eli Zaretskii , 71469@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, 2024-10-08 at 14:57 +0200, Robert Pluim wrote: > > > > > > On Sat, 05 Oct 2024 09:06:24 -0400, Stefan Monnier via "Bug > > > > > > reports for GNU Emacs, the Swiss army knife of text > > > > > > editors" said: >=20 > =C2=A0=C2=A0=C2=A0 >> We have occasionally declared things obsolete with = the > understanding > =C2=A0=C2=A0=C2=A0 >> that they'll be deleted much later than the normal = "10 years, > give or > =C2=A0=C2=A0=C2=A0 >> take".=C2=A0 See the comment in `interactive-p', fo= r example. > =C2=A0=C2=A0=C2=A0 >>=20 > =C2=A0=C2=A0=C2=A0 >> The patch below gives me 64 warnings in our tree.= =C2=A0 I'm not > sure if it's > =C2=A0=C2=A0=C2=A0 >> worth installing or not. >=20 > =C2=A0=C2=A0=C2=A0 Stefan> FWIW, it's a +1 from me (assuming we then sile= nce the > resulting > =C2=A0=C2=A0=C2=A0 Stefan> warnings, of course). >=20 > emacs-lisp/lisp-mode.el:311:18: Warning: =E2=80=98font-lock-warning-face= =E2=80=99 is > an obsolete variable (as of 31.1); use =E2=80=99font-lock-warning-face > instead. >=20 > sounds like a great way to cause confusion. How about: >=20 > "use value 'font-lock-comment-face directly instead" Maybe "pass font-lock-comment-face as a symbol instead"? To understand what "directly" means one would have to notice the lone singular quote, which I didn't when I read the suggestion, so I imagine I'd feel confused had I not know what the warning is about. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 04:44:54 2024 Received: (at 71469) by debbugs.gnu.org; 9 Oct 2024 08:44:54 +0000 Received: from localhost ([127.0.0.1]:55578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sySJS-000189-2j for submit@debbugs.gnu.org; Wed, 09 Oct 2024 04:44:54 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:45433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sySJP-00017x-4O for 71469@debbugs.gnu.org; Wed, 09 Oct 2024 04:44:52 -0400 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-37d2e81e110so867381f8f.3 for <71469@debbugs.gnu.org>; Wed, 09 Oct 2024 01:44:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728463420; x=1729068220; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=TD0GGrFHZ2+fxn56o1cKTl/fMSSDbTJumyQVfQmW3Sc=; b=nAJgVEkl7vTmyA1gtwjWnRURaa+g7iHWRkWFoVgnxh+Rs20wCTb8cnQzhZ/m/Dw6nr k6HrplV7zBeBdZVvce6dl/R5JCWE3+OfgBFD6I+635Yl22MQOmcwZxsbybBS1jrlb8Tc LuppdnKEYVy34r+J+Z0JVbQ1Iw60TfFrN6CPqsT7jfEn7IlfGxyDjyWJK6oeUVIX0i9M 6CrTiJq3dHE0V6F/D6jc5Fe4rF6N9DfLJbOztm+NMxvGFx4tUZ1IPQQj5jwzrBd7bKjt Mb8nOPmR/q/wNrIj6E+H82N4VnMGPnczRcqsb8wMyB6clwurrU7dq44vbH+LbX4yQ2Qj BmoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728463420; x=1729068220; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TD0GGrFHZ2+fxn56o1cKTl/fMSSDbTJumyQVfQmW3Sc=; b=jXbVfnCQ2M1H2PrNH6T9YYU+qG2MwqjHeS9+UF3NjelCM5i28BY2JTJVRiX1QtBi7G Rp38sqi0AqcbKonNc70ZnVpPaYVlypH3KzI1wADtVI6JEBJSe/T0V7BcOYGcZdtAQ+A4 1JyhfKtPoiUg1KD5KunGiQT2lToyzqxHIICJ2/Tj4fd5nK9DnZkIeyQ5fmM0JZqq64vX gfzVcGw/yHa82yixekDKmBR6GqxYRAzTHQJgfgmzMQXil6Vf2SvaYaIcw/BPN1nyM7QY jXU8Pq0ByhvDF8IGgTY1hTQdSrQtje+dFqBHV9BGkMEJ/DUn8GPBZYjoEvUX7yZXVfjD oFAw== X-Forwarded-Encrypted: i=1; AJvYcCVEU6ezxm7ITinB9kX58Ha+OdyGDsaqxG8jwtW9sMOT91BKHvoI6oAcY1LfdOJBMny1ALXltA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxpixB/k17U/eE1iq9J8ac3Dg2K/tEAZJmM1IrlV5sF826Ekt4b KAMCujGPWqT8N6DXFbYu5H3C4c2tZpDn7XP3gWvstlIoTHdHPsldlPo9sA== X-Google-Smtp-Source: AGHT+IFadNaHO5v5+v8ckNjD1ey2dfX0ap5mMCVMO4HveGJnMrgxlgXaJCfYvjfJdKviSAQ/WVj7aA== X-Received: by 2002:a5d:5c88:0:b0:37d:3e8c:f708 with SMTP id ffacd0b85a97d-37d3e8cf837mr600091f8f.20.1728463419908; Wed, 09 Oct 2024 01:43:39 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:2971:f165:b364:b372]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d37454ae0sm2289178f8f.85.2024.10.09.01.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 01:43:39 -0700 (PDT) From: Robert Pluim To: Konstantin Kharlamov Subject: Re: bug#71469: font-lock does not apply standard faces and their descendants In-Reply-To: <5882b135ea4b67309fb329fcb95fd06c50211b3a.camel@yandex.ru> (Konstantin Kharlamov's message of "Tue, 08 Oct 2024 16:25:32 +0300") References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> <86plso96a9.fsf@gnu.org> <87v7y2zr97.fsf@gmail.com> <5882b135ea4b67309fb329fcb95fd06c50211b3a.camel@yandex.ru> Date: Wed, 09 Oct 2024 10:43:38 +0200 Message-ID: <87r08pzmx1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71469 Cc: Eli Zaretskii , 71469@debbugs.gnu.org, Stefan Kangas , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 08 Oct 2024 16:25:32 +0300, Konstantin Kharlamov said: >> >> "use value 'font-lock-comment-face directly instead" Konstantin> Maybe "pass font-lock-comment-face as a symbol instead"? To understand Konstantin> what "directly" means one would have to notice the lone singular quote, Konstantin> which I didn't when I read the suggestion, so I imagine I'd feel Konstantin> confused had I not know what the warning is about. Then the question becomes "how do I pass font-lock-comment-face as a symbol", to which the answer is 'font-lock-comment-face, which is in my suggestion :-) How about "use quoted value 'font-lock-comment-face directly instead"? Robert -- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 04:59:15 2024 Received: (at 71469) by debbugs.gnu.org; 9 Oct 2024 08:59:15 +0000 Received: from localhost ([127.0.0.1]:55611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sySXK-0001vP-UZ for submit@debbugs.gnu.org; Wed, 09 Oct 2024 04:59:15 -0400 Received: from forward501d.mail.yandex.net ([178.154.239.209]:37440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sySXH-0001vE-TE for 71469@debbugs.gnu.org; Wed, 09 Oct 2024 04:59:13 -0400 Received: from mail-nwsmtp-smtp-production-main-45.myt.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-45.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:308c:0:640:7ea3:0]) by forward501d.mail.yandex.net (Yandex) with ESMTPS id 43A7A61722; Wed, 9 Oct 2024 11:58:59 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-45.myt.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id vwdj328Z3uQ0-amCSNhiW; Wed, 09 Oct 2024 11:58:58 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1728464338; bh=34bkD098dDzUeDGgGm0h30PpQTs2jpu/tiXOXDWJfQs=; h=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID; b=GHh5Eb+sCepW78oRtA0Cg5vDrfVXRbV8f40jAeql9ubwworYYfKJsjbMa5XHWG7HO ASHEsyLUAuti7WkBGu6TVy6dvxsmBcLWbt80/zRQ/nYLWzMHW2Njjg3nACgOkp0Iu4 IbVlpPt55jXt2mwrGCjmn6d5F0MekfNJiJKW1S+A= Authentication-Results: mail-nwsmtp-smtp-production-main-45.myt.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <001828d82970f4ca6a6d5388fbecdf6e75fcd31d.camel@yandex.ru> Subject: Re: bug#71469: font-lock does not apply standard faces and their descendants From: Konstantin Kharlamov To: Robert Pluim Date: Wed, 09 Oct 2024 11:58:57 +0300 In-Reply-To: <87r08pzmx1.fsf@gmail.com> References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> <86plso96a9.fsf@gnu.org> <87v7y2zr97.fsf@gmail.com> <5882b135ea4b67309fb329fcb95fd06c50211b3a.camel@yandex.ru> <87r08pzmx1.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 MIME-Version: 1.0 X-Yandex-Filter: 1 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71469 Cc: Eli Zaretskii , 71469@debbugs.gnu.org, Stefan Kangas , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 2024-10-09 at 10:43 +0200, Robert Pluim wrote: > > > > > > On Tue, 08 Oct 2024 16:25:32 +0300, Konstantin Kharlamov > > > > > > said: > =C2=A0=C2=A0=C2=A0 >>=20 > =C2=A0=C2=A0=C2=A0 >> "use value 'font-lock-comment-face directly instead= " >=20 > =C2=A0=C2=A0=C2=A0 Konstantin> Maybe "pass font-lock-comment-face as a sy= mbol > instead"? To understand > =C2=A0=C2=A0=C2=A0 Konstantin> what "directly" means one would have to no= tice the > lone singular quote, > =C2=A0=C2=A0=C2=A0 Konstantin> which I didn't when I read the suggestion,= so I > imagine I'd feel > =C2=A0=C2=A0=C2=A0 Konstantin> confused had I not know what the warning i= s about. >=20 > Then the question becomes "how do I pass font-lock-comment-face as a > symbol", to which the answer is 'font-lock-comment-face, which is in > my suggestion :-) Well, yeah, this implies a user knows what "a lisp symbol" is. I like your suggestion to include the quote: > How about "use quoted value 'font-lock-comment-face directly > instead"? I'm wondering whether "directly" makes this sentence any more clear or maybe it's excessive? So like, maybe just "use quoted value 'font-lock- comment-face instead"? Also, "the value" may be ambiguous here (because `foo` is a value and `'foo` is a symbol, so we kind end up overloading the meaning in the sentence) so maybe even make it shorter: "pass 'font-lock-comment-face quoted instead"? (FWIW, english isn't my native language, Idk if the sentence flow sounds okay here) From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 08:49:07 2024 Received: (at 71469) by debbugs.gnu.org; 9 Oct 2024 12:49:07 +0000 Received: from localhost ([127.0.0.1]:55952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syW7n-0005OS-89 for submit@debbugs.gnu.org; Wed, 09 Oct 2024 08:49:07 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syW7l-0005Nx-0s for 71469@debbugs.gnu.org; Wed, 09 Oct 2024 08:49:06 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 95A9880966; Wed, 9 Oct 2024 08:48:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1728478128; bh=/+KaUEFq9Tnp1JHRjcBuLJTB82bYlQKNhY0sD1ZYyec=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=KS3F7DyKHZZB85P7WPpk/CAp4WdKXjs9kpj/i/3qolqHaS6GhB17OKpKsRtqnhz8I t5sAcviQ7PZ4CUBUX0ypxwuxgbxvof8M4yfyyseiBT8RG46AgKVrPK7dlLlUw6+aze iIF34mwLOBE7tycmAOb/DxCMTNezDhO1Na/2On8Sp9huFslFkZHvimnXReOF8078Vs UZJscN60WvcgkW/aCXfDED+bFp3v6E0HupCV6h0hEEogiPvFyKYgs7CzyJ3gxL2F73 k7+FER3Mj43MdoX2OgA0iL4TurSU1XKwOOHLRWnaDaUigD9auceVQmDbIrQlUKBK0W dE6f1DbT2GZzg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DBD4280251; Wed, 9 Oct 2024 08:48:48 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C7834120175; Wed, 9 Oct 2024 08:48:48 -0400 (EDT) From: Stefan Monnier To: Robert Pluim Subject: Re: bug#71469: font-lock does not apply standard faces and their descendants In-Reply-To: <87r08pzmx1.fsf@gmail.com> (Robert Pluim's message of "Wed, 09 Oct 2024 10:43:38 +0200") Message-ID: References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> <86plso96a9.fsf@gnu.org> <87v7y2zr97.fsf@gmail.com> <5882b135ea4b67309fb329fcb95fd06c50211b3a.camel@yandex.ru> <87r08pzmx1.fsf@gmail.com> Date: Wed, 09 Oct 2024 08:48:47 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.162 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71469 Cc: Eli Zaretskii , 71469@debbugs.gnu.org, Stefan Kangas , Konstantin Kharlamov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > How about "use quoted value 'font-lock-comment-face directly instead"? Much better, yes. I'd even say "symbol" rather than "value" to be more precise. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 09:21:53 2024 Received: (at 71469) by debbugs.gnu.org; 9 Oct 2024 13:21:53 +0000 Received: from localhost ([127.0.0.1]:56009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syWdV-0007Ck-7l for submit@debbugs.gnu.org; Wed, 09 Oct 2024 09:21:53 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:48263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syWdT-0007CV-75 for 71469@debbugs.gnu.org; Wed, 09 Oct 2024 09:21:52 -0400 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-37ccdc0d7f6so4285486f8f.0 for <71469@debbugs.gnu.org>; Wed, 09 Oct 2024 06:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728480039; x=1729084839; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=wN7Hy6hViosPSh0hD/8RAu6t/YQi3UqyD8TIxJwCBtw=; b=CO9egVcC9EQkfXgoqtMRH5si3bwNblTAzeQi79P4iG/886/pgZeBn/cDwihU281Lcv tl+8zqTfm7Aml6SRffQiH3LjCC6qDnSm0NAGcvXYPdfTyQjHgTEvhpduVZB2Q/rxf/5w wlSWxtjhwgh+Q3KQ0MiB4xvNe6ZBJYtDOikxx/+2Tb9aLEOfhiyEZdWZ+aKLtOyL7uxM XBMefrisLgOPZSDEQPwRNYkaDn/a5UXq7bEbkVOLCuERFYT0fAj2zAd+UC88CskvfXU4 Dy/o3JLcxSl7MnOL70a1qkuGM432DOorDDhD5P+MMH1cLuW9+tprEmfLOi5Xga22RTuT eTsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728480039; x=1729084839; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wN7Hy6hViosPSh0hD/8RAu6t/YQi3UqyD8TIxJwCBtw=; b=LPrmzE2islaAF+avFBSwbQGno1qQkcrWvp3vUvT7W5THnSj/+8zeMB1exlZ6y4wCeT PgXi7QExqyXVEPzfP9JXjbxBers/FzPq9gqOReQhNqMARYNdr+DeYvSeiAAjxr09NKAE H0j9tlNZSwS4uMvr2tgVN1+UDCPtYiQokHUL/HKDLAhPgijTdkmZuHN9jGqUtWgsBZlk /O1Hyy23Kf0U5TWX9oq83A8+NCbFKYG8jA3QXh+3Dr1Yeo6Ey1KCrniaWHEQq2C8I4mz 4EF+pJYqgatSHHz53wT7erYCcdUjTNEA7NGGdpGq66JiYgO2R5roVD6H6Buak9jxqmkS ACfw== X-Forwarded-Encrypted: i=1; AJvYcCU4HAaiWIm9ih1G9TSmHsHXXQSypiqLt1vMHtgkYc4nWG8iNbUlvBmpyUTYpti2LXVPtX5t1w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxDg900NvG94K48cZbKeHvKGdCkUgcPxsEiUMqdqatGHlURvZvC ayLrd+X1c0kJ7SI4RUx6kHnoQzGoVY1Wjq0wYt/d93xUV1t9duYYmvjLdQ== X-Google-Smtp-Source: AGHT+IGLhIC3epgle+1MVaO0eJWRYMaUa93cvc5C40u+Ni5Y6KIsVM86JiYLIiX0J1m2DYGqm1pgDQ== X-Received: by 2002:a5d:69cf:0:b0:37d:2d45:b3d4 with SMTP id ffacd0b85a97d-37d3aabfb26mr1804286f8f.52.1728480039071; Wed, 09 Oct 2024 06:20:39 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb51:b450:f538:406e:ef43]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d45acf153sm629169f8f.48.2024.10.09.06.20.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 06:20:38 -0700 (PDT) From: Robert Pluim To: Stefan Monnier Subject: Re: bug#71469: font-lock does not apply standard faces and their descendants In-Reply-To: (Stefan Monnier's message of "Wed, 09 Oct 2024 08:48:47 -0400") References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> <86plso96a9.fsf@gnu.org> <87v7y2zr97.fsf@gmail.com> <5882b135ea4b67309fb329fcb95fd06c50211b3a.camel@yandex.ru> <87r08pzmx1.fsf@gmail.com> Date: Wed, 09 Oct 2024 15:20:37 +0200 Message-ID: <87cyk9za3e.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71469 Cc: Eli Zaretskii , 71469@debbugs.gnu.org, Stefan Kangas , Konstantin Kharlamov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 09 Oct 2024 08:48:47 -0400, Stefan Monnier said: >> How about "use quoted value 'font-lock-comment-face directly instead"? Stefan> Much better, yes. I'd even say "symbol" rather than "value" to be Stefan> more precise. Works for me. Robert -- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 10:04:32 2024 Received: (at 71469) by debbugs.gnu.org; 9 Oct 2024 14:04:32 +0000 Received: from localhost ([127.0.0.1]:57208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syXIm-0001Rb-0w for submit@debbugs.gnu.org; Wed, 09 Oct 2024 10:04:32 -0400 Received: from forward502d.mail.yandex.net ([178.154.239.210]:51904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syXIi-0001R9-V0 for 71469@debbugs.gnu.org; Wed, 09 Oct 2024 10:04:30 -0400 Received: from mail-nwsmtp-smtp-production-main-17.iva.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-17.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:aba6:0:640:703c:0]) by forward502d.mail.yandex.net (Yandex) with ESMTPS id B896E60D89; Wed, 9 Oct 2024 17:04:16 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-17.iva.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id E4jl3s6oCW20-lPXaLkdx; Wed, 09 Oct 2024 17:04:16 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1728482656; bh=Dmkyuo3RHFvvqeE1X/PmD9HjdQizFgcWwlDDtxbxToQ=; h=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID; b=kbFXzKtEMYRjZHZmMNIgAwu/3QjC3+uqcGK5EFszxeZ8JesTYC2zzUhvfkTvqX17+ wsYWpuO0NJ/RNt34Zy+ObI7dvJKltRf4s6kQdJHhrWBUwcBTJNwVdGzt7p5TfyGDiw pJlw1KpJ7GGANC9wQFaRFfBOWCy71P+G+rMSneK0= Authentication-Results: mail-nwsmtp-smtp-production-main-17.iva.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <4e85c1cc443c1407ca5884c46c997bbdb6e0f8db.camel@yandex.ru> Subject: Re: bug#71469: font-lock does not apply standard faces and their descendants From: Konstantin Kharlamov To: Stefan Monnier , Robert Pluim Date: Wed, 09 Oct 2024 17:04:14 +0300 In-Reply-To: References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> <86plso96a9.fsf@gnu.org> <87v7y2zr97.fsf@gmail.com> <5882b135ea4b67309fb329fcb95fd06c50211b3a.camel@yandex.ru> <87r08pzmx1.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 MIME-Version: 1.0 X-Yandex-Filter: 1 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71469 Cc: Eli Zaretskii , 71469@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 2024-10-09 at 08:48 -0400, Stefan Monnier wrote: > > How about "use quoted value 'font-lock-comment-face directly > > instead"? >=20 > Much better, yes.=C2=A0 I'd even say "symbol" rather than "value" to be > more precise. Right, same as I mentioned. Do you think my suggestion "pass 'font-lock-comment-face quoted instead" will not be a better wording? It's shorter. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 10:27:22 2024 Received: (at 71469) by debbugs.gnu.org; 9 Oct 2024 14:27:23 +0000 Received: from localhost ([127.0.0.1]:57321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syXes-00036y-ED for submit@debbugs.gnu.org; Wed, 09 Oct 2024 10:27:22 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syXep-00036g-Mc for 71469@debbugs.gnu.org; Wed, 09 Oct 2024 10:27:20 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 733881000D6; Wed, 9 Oct 2024 10:27:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1728484022; bh=tcKyo08uT7r50BIDJlKjL/yh3avJJPIJEL5a4e/7Yq0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Agodx/Ea+KWUA3NyPrZlc+A63SzCfZ3Oqxr9WJX4PSCJCt4SCqid4JCz+3u0K7ybc hfm2wsdmPJHyro0cu8a9LLd0w5rxMiqvT6cmQSH3hNzJCeRwjfKDs5+TibWNw/epms qHOGwGpPi2QMbdnWk2pxYRso1AzfcDjMm71MYBcTmYCNAFGmGhjPhugbYOQHWvlChp +vBtgREnYFZRI77ez6fMsRQG8INZfReG0mqh7aeLcAahzV7JI9GQXDZwTwfkVHNE0L Z3VDo3/wZMX7sVY8Xrt4SNmLDaN/vScGqtzFCJJ6MVUTm01H5Lczzlue+GOPQjZXNb rtRRRo53K6rIA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CA9CB100043; Wed, 9 Oct 2024 10:27:02 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BBFDD120213; Wed, 9 Oct 2024 10:27:02 -0400 (EDT) From: Stefan Monnier To: Konstantin Kharlamov Subject: Re: bug#71469: font-lock does not apply standard faces and their descendants In-Reply-To: <4e85c1cc443c1407ca5884c46c997bbdb6e0f8db.camel@yandex.ru> (Konstantin Kharlamov's message of "Wed, 09 Oct 2024 17:04:14 +0300") Message-ID: References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> <86plso96a9.fsf@gnu.org> <87v7y2zr97.fsf@gmail.com> <5882b135ea4b67309fb329fcb95fd06c50211b3a.camel@yandex.ru> <87r08pzmx1.fsf@gmail.com> <4e85c1cc443c1407ca5884c46c997bbdb6e0f8db.camel@yandex.ru> Date: Wed, 09 Oct 2024 10:27:00 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.170 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71469 Cc: 71469@debbugs.gnu.org, Robert Pluim , Eli Zaretskii , Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> > How about "use quoted value 'font-lock-comment-face directly >> > instead"? >>=20 >> Much better, yes.=A0 I'd even say "symbol" rather than "value" to be >> more precise. > > Right, same as I mentioned. Do you think my suggestion "pass > 'font-lock-comment-face quoted instead" will not be a better wording? > It's shorter. No preference. We could use a more active form, like Quote the font-lock-comment-face symbol instead - Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 17 08:33:19 2024 Received: (at control) by debbugs.gnu.org; 17 Dec 2024 13:33:19 +0000 Received: from localhost ([127.0.0.1]:58078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNXhM-0008BQ-8T for submit@debbugs.gnu.org; Tue, 17 Dec 2024 08:33:19 -0500 Received: from mail-ej1-f41.google.com ([209.85.218.41]:44121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNXhI-0008B1-SC for control@debbugs.gnu.org; Tue, 17 Dec 2024 08:33:13 -0500 Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a9f1d76dab1so1075582866b.0 for ; Tue, 17 Dec 2024 05:33:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734442327; x=1735047127; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=LcZIJh+hhFTuk5WKQpFquydnmX3rnia4YcNq5ZPwsxY=; b=O/BbgXjvpaae4crwiKch4OJgM03ZT8lDp8/7VlDxHdfvKQwLkzUZN0ppn1ol/H10xZ VCYpMIsbQuN8Q6GzoitrvbYzqnCcoorbrbdgkf/79xnHOASywwHSzU0q1e1xdZ482MAF 1b6YnnVLnuNN+G2muLfN/Rd3G3cphGEz0oimZH+NqEfiGyx8NAgK63wj0rxhDFa8bzRi Nb/EiSyJ68QhthxEG9H42ock3BLhB5Irhe+XRaLjxFNFNXj0qlhDpVSQsgPKSrnvKETJ N48ZE4svq274cdmV40vmY63dVG1WNBmCMbC243lKr0RobwkB2NNvlQVj03FKJ1a8RIgI UWLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734442327; x=1735047127; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=LcZIJh+hhFTuk5WKQpFquydnmX3rnia4YcNq5ZPwsxY=; b=eYsjL6NMsayJC9VgTX/nmBgPVfeGtigkTnWrZIvCRw7250DvLASOdgRgMnz/HcC+/a LCN8r5lCoJp5C8NMexSoxqUalKQVyPz4mX182rdVWCvHVXcheRncxlHPImkKIwoE7ikJ TKuAg9bsTBU7ernd5tIxEXhb4jhoyv4UpR7fSw2xck0Ui5eovibDToquCceTZGzJsORe wPref7+zyl0zAk8kWEjRzoFwz1xThAs+0vTQpcbE5eDTApfCx+SN+cZd69wITMrPUgMO DqbaVj6Vt4gqNSSLkwEyYfiMdhXrZ/ZuOKyZ263HxUetTvFmu7dCWeEtTgaKYP8lrWMa dAuA== X-Gm-Message-State: AOJu0YxQPOpZtTaStKcMeFXMPW/ZGuAufFBRVI+oE5PgJieAbQMZ98hq gzzX1uUOMUkCDvD5TQ+tOW7sOviqQwhYK810znJ9hpd9djoNq91vNOf99vEg00ZE4nxa6yXMIaz NCjU5hXR8kCugvph3UBFrLlaoA/o1XTEkBw0= X-Gm-Gg: ASbGncuWzMvtqp1/oRoK9PElvUtEMFI5SZTcv5jXN31TiCXIJ6K7sg9MYTOM06Z1zYJ vRMBl2qNBvmiLSF4wADA05UuCTDUTWlxKqH67qw== X-Google-Smtp-Source: AGHT+IHlEV3YPWxbl/tPRGP1LPHI0es2jU/wZhADGCPvMxywDyD2fkCHAkbYIfL43eYA5YZxtWvGaIw7QkWEANZVXhY= X-Received: by 2002:a17:907:9508:b0:aa6:81dc:6638 with SMTP id a640c23a62f3a-aabdafbea74mr287181566b.16.1734442326760; Tue, 17 Dec 2024 05:32:06 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 17 Dec 2024 13:32:06 +0000 From: Stefan Kangas MIME-Version: 1.0 Date: Tue, 17 Dec 2024 13:32:06 +0000 Message-ID: Subject: control message for bug #71469 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 71469 - notabug quit From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 17 21:52:43 2024 Received: (at 71469-done) by debbugs.gnu.org; 18 Dec 2024 02:52:43 +0000 Received: from localhost ([127.0.0.1]:60995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNkAv-0005bq-OI for submit@debbugs.gnu.org; Tue, 17 Dec 2024 21:52:41 -0500 Received: from mail-ed1-f42.google.com ([209.85.208.42]:48493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNkAk-0005ai-Mr for 71469-done@debbugs.gnu.org; Tue, 17 Dec 2024 21:52:33 -0500 Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5d122cf8e52so1420364a12.1 for <71469-done@debbugs.gnu.org>; Tue, 17 Dec 2024 18:52:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734490261; x=1735095061; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=qMdBRr0RCGHK9/HnDx0frKTLYj9bvJQBHC15aRBBDxs=; b=bWKAx8EvY3+A8ugyhyaOJfBogtlcwiKTVkakGhQp67KkezLHuBpI/Cj+71e+qhFc/h wqEQ8AMqVqWz81qcCwHJxd/zpGhAaid+Y6epFLn+Q589sKB8OgUnQThOe75chKh0wxCX kxOdDOF5BgjgV7mCfXbpuwd25NkY0/TAwpAGpVXUTNC/BDo1ONKbDRTNv4AIK/uOoKsA Sx881VwCBSmyBg8dhHSvfLtapuGL5otfIYdJSxihbleqTcGj/nfZxbCdOKfpGT1Wvcxq 5ThWHId6OOL+xQjlsf9PJlJKdEL4xyBLWjPS/cFI7nxuuVLR7mj5a5RJMBROzmQuBwLi Lzbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734490261; x=1735095061; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qMdBRr0RCGHK9/HnDx0frKTLYj9bvJQBHC15aRBBDxs=; b=Xenjt/24QbUdyQFjyt6ibBSSh2FKYqbXyUD/Ek74ZzN7hvzcQCdsqakvRM7er7R6em HRCnqvH94uOJO0rKbudDtNEyOQLMUF4VCJ/9FSdqWiF0V1pSyWDPV2WlqJK3HbP0Bpu/ y2gumhVOv3iOZXymfhSScADoai9VRQS9AIEQk8ggwM71TRBzyB9i5+2mE21xlrRiHvxf 6GopcvwB9IGdtqe+oyhfwdigMy/cNVglsmJZTqGBW/z3a2+81gBGvKujp2DjJMgCQFnr +vAw0f74NDukYtIXzVjicWapbzh2a1+DF1775vysZHNpYTYtbygPFGOA4bc22+8OeimC I8CQ== X-Forwarded-Encrypted: i=1; AJvYcCWvA3uik+waJA5jfpjGe6My+cUN3OH3vnpVbCLcrh0su4btv+xLymh3FKWdCgv5viH/4pDF5j8p5RBz@debbugs.gnu.org X-Gm-Message-State: AOJu0Yxi9dAu5BLY687lE33/nVp6/YeN4CdfAUDXlfp1xlyqRlpBarer 0kiYtox1vQ0Aq2s41oEljNOEixffOcqpjYh/mJnV9l+rqyN9W5LtxvHDgjRL/dYbaL7Ynbbgw2b QaCqkRgjcYiIcuIR61goolxqcV2w= X-Gm-Gg: ASbGnculhWbGH9D4gavSctpixYgctgmu2GyMZieughVsFhvmjMdJ9lsfMDYwwDDsVEz 7JItRAggBCNVLoeSSiEf8aYVYukuO9nnKHqhCoQ== X-Google-Smtp-Source: AGHT+IGFm3Wb/JoGhkRzPV88pwqEW7/uIkrYLL9CHGk+mzhQxf5MLaDcyxhCwpaJ1yask/qrvuoxOTqDFl3GLwwf3/w= X-Received: by 2002:a05:6402:270f:b0:5d0:f81d:f555 with SMTP id 4fb4d7f45d1cf-5d7ee3bace1mr1177107a12.5.1734490260779; Tue, 17 Dec 2024 18:51:00 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 17 Dec 2024 18:51:00 -0800 From: Stefan Kangas In-Reply-To: References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> <86plso96a9.fsf@gnu.org> MIME-Version: 1.0 Date: Tue, 17 Dec 2024 18:51:00 -0800 Message-ID: Subject: Re: bug#71469: font-lock does not apply standard faces and their descendants To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71469-done Cc: Eli Zaretskii , 71469-done@debbugs.gnu.org, Konstantin Kharlamov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 31.1 Stefan Monnier writes: >> We have occasionally declared things obsolete with the understanding >> that they'll be deleted much later than the normal "10 years, give or >> take". See the comment in `interactive-p', for example. >> >> The patch below gives me 64 warnings in our tree. I'm not sure if it's >> worth installing or not. > > FWIW, it's a +1 from me (assuming we then silence the resulting > warnings, of course). Thanks. There have been no objections to the suggested patch, so I have now installed a version of it on master as commit 3d3c1094604. The installed change silences all warnings, and updates the manual and NEWS. The discussion in this thread focused on the wording of the warning, and there were several good suggestions. In the end, I settled on the following, which I hope strikes a compromise between being brief, exact, and telling the user in clear terms how to fix the warning: use the quoted symbol instead: 'font-lock-foo-face Getting rid of these variables should help avoid the confusion that the OP had regarding faces and variables. With that, I'm closing this bug report. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 05:16:59 2024 Received: (at 71469) by debbugs.gnu.org; 18 Dec 2024 10:16:59 +0000 Received: from localhost ([127.0.0.1]:33508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNr6s-0002KQ-Sc for submit@debbugs.gnu.org; Wed, 18 Dec 2024 05:16:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNr6p-0002KC-Pd for 71469@debbugs.gnu.org; Wed, 18 Dec 2024 05:16:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNr6k-0005mY-Dv; Wed, 18 Dec 2024 05:16:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=lwKL1Lel4txDd4uKETxd+DWzPROyb170/MJ/XarPBxc=; b=HkWZJY4bQX2PeSFi+oTl 8RbTZ7NlYHvzKwSl70jNzAoWUl8RnQYhttBR810HgBNSySzFoBRjPHRCEJYRGcJRdmvPz8sfshMwu p7XhQAY16eq/6ko7ixkiAicxsXRHBj94qKxSn9qz7M2fqQzqW6EVt+RF+Ptfiv70DjBXd8A5myz7+ YQddsDyJc4jcFqNXPnkM+VttdeMPAtjt5XPVQjVpzhGOtjKaCT16Ovqqm+f3h2rCL6XBZKidV1u1x MxLxqcIkQf46LWrR3QKpzitgzeBlm0c++XFgEO4uNGJeRncqqHBvsOXrfXUWd2oxX8s4WK2JMkYyt Sj3mGJpEifd9ow==; From: Arash Esbati To: 71469@debbugs.gnu.org Subject: Re: bug#71469: font-lock does not apply standard faces and their descendants In-Reply-To: (Stefan Kangas's message of "Tue, 17 Dec 2024 18:51:00 -0800") References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> <86plso96a9.fsf@gnu.org> Date: Wed, 18 Dec 2024 11:16:42 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71469 Cc: stefankangas@gmail.com, Hi-Angel@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > There have been no objections to the suggested patch, so I have now > installed a version of it on master as commit 3d3c1094604. Thanks. > The installed change silences all warnings, and updates the manual and > NEWS. I still get: cedet/semantic/bovine/c.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 = ... org/ob-C.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... org/ob-fortran.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... progmodes/cc-awk.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 progmodes/cc-awk.el: Warning: =E2=80=98font-lock-keyword-face=E2=80=99 progmodes/cc-awk.el: Warning: =E2=80=98font-lock-function-name-face=E2=80= =99 ... progmodes/antlr-mode.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... progmodes/cmacexp.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... progmodes/csharp-mode.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... progmodes/cwarn.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... progmodes/hideif.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... progmodes/php-ts-mode.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... progmodes/typescript-ts-mode.el: Warning: =E2=80=98font-lock-type-face=E2= =80=99 ... textmodes/mhtml-mode.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... progmodes/cc-fonts.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... This is with Emacs 43fcda0c on macOS. Org and CC-mode(?) are maintained externally, but others not, I think. Best, Arash From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 19:48:02 2024 Received: (at 71469) by debbugs.gnu.org; 19 Dec 2024 00:48:02 +0000 Received: from localhost ([127.0.0.1]:36585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tO4hu-0003TG-En for submit@debbugs.gnu.org; Wed, 18 Dec 2024 19:48:02 -0500 Received: from mail-ed1-f46.google.com ([209.85.208.46]:44227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tO4hs-0003Sp-M2 for 71469@debbugs.gnu.org; Wed, 18 Dec 2024 19:48:01 -0500 Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5d3e6274015so360449a12.0 for <71469@debbugs.gnu.org>; Wed, 18 Dec 2024 16:48:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734569220; x=1735174020; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jw9ZWAB/1m9fB3MWkIzcgpS0w5HxcVJYfBxx/t8HcjE=; b=D1D+6R2t98wpIbn4TtmeqSimD6oYIO/ydkWEJGfae14hWU7r5BnjIdq6PYARoiBqU/ FXkw8/zHDZRQdA1rwRHaBIzZz7CAD5ymUw0Vj6VkVxakUVhfx+S0vXY0/uA341j9c0sP dPbq3MguMOEPt4lw4LG8Sg/v2nWjCUdJGfnDRYUQOaI55b6/7L7YB5z9IqYZTvBqInnJ Zjn5l+GoHLXB7sVz35tb7IAt+O09KbFlchG8kvAlEnc4RjmtDRGf2tJ8t3s5Q52KKKFI /nBedWQkppZER7pd4TZ7Z50QKko21rgOznl5b+6a50lXW3brHvJkaFC9MzydF5bYTZAe ZUXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734569220; x=1735174020; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Jw9ZWAB/1m9fB3MWkIzcgpS0w5HxcVJYfBxx/t8HcjE=; b=HYNk4yI77Vi6RQ1Sh5YiLgQsmJLWd53JFDAKSe6g4jyItqkkO3rXWKXi5/pU+fgL6U PI3REvOxc9DsIk2rz5si+0JiWD+irHkD8JACvxaogB3E5mWoDl7TWz4/MFlB2euHNSaU LJ1pFDYT3tgFBBNVuGTV4WpZGsQPBwJ5zGjT/0X8rlHV9Nb4d37DgC0GvVLKtyQqYXUE eSmVjQ0zeGGPBZoWkNkSYDQfTBZawY7V6TwKc+OSNJDH4DMPAnoS6BuGNnOljrbXM5v3 6b5BYhxaSbmlDRBmGzwY8CwmqwKSCktcu4+GLxXwA3AvOYqrUntrS/G1qwrCxCQT6eQD wA6g== X-Forwarded-Encrypted: i=1; AJvYcCUZwcUGI39+5PEb+cMcs7BgnzSE8vwW9LjYtZWe9pNSjO5Ebum11twkb0Y5PPX2DfPtrU4YNg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwbR0kxlyISDfTv8VRdDPo0w/uDA3rELTMVc1aw9eP7JzEjYP4r CTq6Qx8VnFkjvZXE1eGvM3Nv7NWx0OVvR+CqPXfY1PHZUuR6d56b6Ur3IbuCwDpogsbaFd4XCdK px2C3LOVXV/bcYnnxM2YCzg9kle8= X-Gm-Gg: ASbGncvoUf8K5WJDEf3vYJ9eKgujVEpwLMfj1nfSFU6DyAsesqoAl8TLmAeIzn+Xw+C EIqZHcDpq1cj7H/gJEQfiLGmAuZdo8VGomcEYxQ== X-Google-Smtp-Source: AGHT+IFtpmAKWRN6qTGyp6f4tMJ9Wlo1PPuX2RpIAcUN77/msrITJgKVJHXXeqXizX/xf57klk6wSWiIY9LD3mPnWtU= X-Received: by 2002:a05:6402:234e:b0:5d0:ed71:3ce4 with SMTP id 4fb4d7f45d1cf-5d7ee37b196mr4323291a12.6.1734569219633; Wed, 18 Dec 2024 16:46:59 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 18 Dec 2024 19:46:58 -0500 From: Stefan Kangas In-Reply-To: References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> <86plso96a9.fsf@gnu.org> MIME-Version: 1.0 Date: Wed, 18 Dec 2024 19:46:58 -0500 Message-ID: Subject: Re: bug#71469: font-lock does not apply standard faces and their descendants To: Arash Esbati , 71469@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71469 Cc: Hi-Angel@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Arash Esbati writes: > I still get: > > cedet/semantic/bovine/c.el: Warning: =E2=80=98font-lock-type-face=E2=80= =99 ... > org/ob-C.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... > org/ob-fortran.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... > progmodes/cc-awk.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 > progmodes/cc-awk.el: Warning: =E2=80=98font-lock-keyword-face=E2=80=99 > progmodes/cc-awk.el: Warning: =E2=80=98font-lock-function-name-face=E2=80= =99 ... > progmodes/antlr-mode.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 .= .. > progmodes/cmacexp.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... > progmodes/csharp-mode.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 = ... > progmodes/cwarn.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... > progmodes/hideif.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... > progmodes/php-ts-mode.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 = ... > progmodes/typescript-ts-mode.el: Warning: =E2=80=98font-lock-type-face=E2= =80=99 ... > textmodes/mhtml-mode.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 .= .. > progmodes/cc-fonts.el: Warning: =E2=80=98font-lock-type-face=E2=80=99 ... > > This is with Emacs 43fcda0c on macOS. Org and CC-mode(?) are maintained > externally, but others not, I think. Thanks, this should now be fixed on master. Please test. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 11:23:08 2024 Received: (at 71469) by debbugs.gnu.org; 19 Dec 2024 16:23:08 +0000 Received: from localhost ([127.0.0.1]:39801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOJIm-0008NR-Ok for submit@debbugs.gnu.org; Thu, 19 Dec 2024 11:23:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOJIk-0008MY-6k for 71469@debbugs.gnu.org; Thu, 19 Dec 2024 11:23:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOJId-0004NU-C3; Thu, 19 Dec 2024 11:22:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=RWZfcinv2uwj6BvDNyCniUGlTkyXHTk1orGtR552Jn8=; b=X4gNQuwI++3VVm/F676f RMJDbs9BH7k2GsYwA7Ikt8pW2aw+pDlIl0RaWtBNN8prZznTSZEgqflfqcweJiJm/pby/DEKu+KGM H5VQW7e9+neZfw46vPAQyIbelxrHPro5l8ftlw0PY4gA39RRMI3brIOSjVH2sPRyh83GkfYcLptd4 Vxo0il8wCaFyktY+slItOk9QEGUcopbdKpZtySTUPaCTvJmZEY214hyyiQRjTj7VrpxrTQI5k8PHL 8zk6pCLDjcAYE720anQ8kvbf3ilbMgrme0uAU9EB0H8gmR0UsSn5gQi1W5OevD9IRUtp7lo2yE50O fRi8SnIeAYJ55Q==; From: Arash Esbati To: Stefan Kangas Subject: Re: bug#71469: font-lock does not apply standard faces and their descendants In-Reply-To: (Stefan Kangas's message of "Wed, 18 Dec 2024 19:46:58 -0500") References: <86tti17y8y.fsf@gnu.org> <519d35a7717587222c5da915a9e02ccaa06e9c5b.camel@yandex.ru> <86plso96a9.fsf@gnu.org> Date: Thu, 19 Dec 2024 17:22:51 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71469 Cc: 71469@debbugs.gnu.org, Hi-Angel@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > Thanks, this should now be fixed on master. Please test. Thanks, all warnings are now gone. This is with 3281f861. Best, Arash From unknown Wed Jun 18 23:16:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 17 Jan 2025 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator