GNU bug report logs - #71466
30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted

Previous Next

Full log

Message #68 received at 71466 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Juri Linkov <juri <at> linkov.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 71466 <at> debbugs.gnu.org, me <at> eshelyaron.com
Subject: Re: bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point
 when Buffer List is reverted
Date: Tue, 25 Jun 2024 01:42:46 +0300

On 24/06/2024 09:27, Juri Linkov wrote:
> I still don't understand how duplicating revert-buffer
> 
> +(defun xref-revert-buffer ()
> +  "Refresh the search results in the current buffer."
> +  (declare (obsolete revert-buffer "30.1"))
> +  (interactive)
> +  (let (restore-functions)
> +    (when (boundp 'revert-buffer-restore-functions)
> +      (run-hook-wrapped 'revert-buffer-restore-functions
> +                        (lambda (f) (push (funcall f) restore-functions) nil)))
> +    (prog1 (xref--revert-buffer)
> +      (mapc #'funcall (delq nil restore-functions)))))
> 
> can be better than what Eshel proposed with an alias:
> 
> + (define-obsolete-function-alias 'xref-revert-buffer #'revert-buffer "30.1")

That is my opinion as well: better obsolete it this way.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.