Subject: bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted

From: Juri Linkov <[email-masked]>
Date: Tue, 25 Jun 2024 09:54:32 +0300

>> I still don't understand how duplicating revert-buffer
>> +(defun xref-revert-buffer ()
>> +  "Refresh the search results in the current buffer."
>> +  (declare (obsolete revert-buffer "30.1"))
>> +  (interactive)
>> +  (let (restore-functions)
>> +    (when (boundp 'revert-buffer-restore-functions)
>> +      (run-hook-wrapped 'revert-buffer-restore-functions
>> +                        (lambda (f) (push (funcall f) restore-functions) nil)))
>> +    (prog1 (xref--revert-buffer)
>> +      (mapc #'funcall (delq nil restore-functions)))))
>> can be better than what Eshel proposed with an alias:
>> + (define-obsolete-function-alias 'xref-revert-buffer #'revert-buffer
>> "30.1")
>
> That is my opinion as well: better obsolete it this way.

Nice, then Eshel could push the latest patch (with discussed amendments).