GNU bug report logs - #71460
[PATCH] gnu: emacs-yeetube: Update to 2.1.16

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71460 in the body.
You can then email your comments to 71460 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thanos Apollo <public <at> thanosapollo.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-yeetube: Update to 2.1.16
Date: Mon, 10 Jun 2024 00:11:19 +0300

[Message part 1 (text/plain, inline)]

Thanks for maintaining yeetube packaging.  Attaching a version bump
that removes wget as a dependency.

[0001-gnu-emacs-yeetube-Update-to-2.1.6.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 

Thanos Apollo
 
https://thanosapollo.org

62B7 58D0 F671 9938 BC09 CECA 339F 736C 3A72 0928

Message #8 received at 71460 <at> debbugs.gnu.org (full text, mbox):

From: Thanos Apollo <public <at> thanosapollo.org>
To: 71460 <at> debbugs.gnu.org
Subject: Fixing commit message
Date: Mon, 10 Jun 2024 18:26:12 +0300

[Message part 1 (text/plain, inline)]

Same patch, this time with a generated =Change-Id: ***=. Still learning
how to properly format patches for Guix.

[0001-gnu-emacs-yeetube-Update-to-2.1.6.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 

Thanos Apollo
 
https://thanosapollo.org

62B7 58D0 F671 9938 BC09 CECA 339F 736C 3A72 0928

Message #11 received at 71460 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Thanos Apollo <public <at> thanosapollo.org>
Cc: 71460 <at> debbugs.gnu.org
Subject: Re: [bug#71460] Fixing commit message
Date: Mon, 10 Jun 2024 18:32:33 +0200

Hello,

Thanos Apollo <public <at> thanosapollo.org> writes:

> Same patch, this time with a generated =Change-Id: ***=. Still learning
> how to properly format patches for Guix.

Thank you (for the package, too!).

> Subject: [PATCH] gnu: emacs-yeetube: Update to 2.1.6
>
> * gnu/packages/emacs-xyz.scm (emacs-yeetube): Update to 2.1.6.

You need to add that you removed wget dependency:

  [arguments]<#:phases>: No longer replace (executable-find "wget") in
  the code base.
  [inputs]: Remove WGET.

> Change-Id: I6aee95029e829170a98d8fb7447bf0fd39ed6176
> ---
>  gnu/packages/emacs-xyz.scm | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 2a943f5846..1d0519aa88 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -29074,10 +29074,10 @@ (define-public emacs-ytel-show
>        (license license:gpl3+))))
>  
>  (define-public emacs-yeetube
> -  (let ((commit "c74e4e77156297624d278a05bdd19c016a91ff9b")) ;version bump
> +  (let ((commit "c9721a295f4fd30a44e94b3424151fa8a14d22ae"))

Why are you removing the comment? It is used to indicate that upstream
does not tag commits, but this commit matches the version bump anyway.

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Nicolas Goaziou via Guix-patches via <guix-patches <at> gnu.org>
Cc: Thanos Apollo <public <at> thanosapollo.org>, 71460-done <at> debbugs.gnu.org
Subject: Re: [bug#71460] Fixing commit message
Date: Wed, 19 Jun 2024 09:56:14 +0200

Nicolas Goaziou via Guix-patches via <guix-patches <at> gnu.org> writes:

> Thanos Apollo <public <at> thanosapollo.org> writes:

>> * gnu/packages/emacs-xyz.scm (emacs-yeetube): Update to 2.1.6.
>
> You need to add that you removed wget dependency:
>
>   [arguments]<#:phases>: No longer replace (executable-find "wget") in
>   the code base.
>   [inputs]: Remove WGET.
>

[...]

>>  (define-public emacs-yeetube
>> -  (let ((commit "c74e4e77156297624d278a05bdd19c016a91ff9b")) ;version bump
>> +  (let ((commit "c9721a295f4fd30a44e94b3424151fa8a14d22ae"))
>
> Why are you removing the comment? It is used to indicate that upstream
> does not tag commits, but this commit matches the version bump anyway.

I applied the changes and push the commit.

Regards,

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.