Subject: bug#71455: closed (Re: [bug-diffutils] bug#71455: "make distcheck" regression)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 11 Jun 2024 17:13:02 +0000

Your bug report

#71455: "make distcheck" regression

which was filed against the diffutils package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
71455: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71455
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug-diffutils] bug#71455: "make distcheck" regression
From: Paul Eggert <[email-masked]>
To: Bruno Haible <[email-masked]>
Cc: [email-masked]
Date: Tue, 11 Jun 2024 10:12:23 -0700
List-Id: <debbugs-submit.debbugs.gnu.org>

Thanks, fixed by installing the attached.

From d82aac15e6fc1e813d7f793e9cc3f82f9e593a44 Mon Sep 17 00:00:00 2001
From: Paul Eggert <[email-masked]>
Date: Tue, 11 Jun 2024 10:11:05 -0700
Subject: [PATCH] =?UTF-8?q?maint:=20pacify=20=E2=80=98make=20sc=5Ftight=5F?=
 =?UTF-8?q?scope=E2=80=99?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Problem reported by Bruno Haible <https://bugs.gnu.org/71455>.
* src/system.h (same_file, stat_size): Add ‘extern’.
---
 src/system.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/system.h b/src/system.h
index 39f645b..1259a68 100644
--- a/src/system.h
+++ b/src/system.h
@@ -150,7 +150,7 @@ SYSTEM_INLINE int floor_log2 (idx_t n)
 
 _GL_INLINE_HEADER_END
 
-bool same_file (struct stat const *, struct stat const *)
+extern bool same_file (struct stat const *, struct stat const *)
   ATTRIBUTE_PURE;
-off_t stat_size (struct stat const *)
+extern off_t stat_size (struct stat const *)
   ATTRIBUTE_PURE;
-- 
2.43.0

Subject: "make distcheck" regression
From: Bruno Haible <[email-masked]>
To: [email-masked]
Date: Sun, 09 Jun 2024 20:33:40 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

My new diffutils continuous integration [1] run fails at the "make distcheck"
step. The substep that fails is

$ make sc_tight_scope
...
same_file
stat_size
the above functions should have static scope
make[4]: *** [/home/runner/work/ci-check/ci-check/diffutils/tight-scope.mk:42: _gl_tight_scope] Error 1

To me, it looks like a regression in commit bf85e93a52366d5361cfad68e79667514259d666.

Bruno

[1] https://github.com/gnu-diffutils/ci-check/actions