From unknown Sun Jun 22 00:02:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#71424 <71424@debbugs.gnu.org> To: bug#71424 <71424@debbugs.gnu.org> Subject: Status: 29.3; auto-revert-use-notify buggy interaction with indirect buffers Reply-To: bug#71424 <71424@debbugs.gnu.org> Date: Sun, 22 Jun 2025 07:02:03 +0000 retitle 71424 29.3; auto-revert-use-notify buggy interaction with indirect = buffers reassign 71424 emacs submitter 71424 z@bcc32.com severity 71424 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 00:44:47 2024 Received: (at submit) by debbugs.gnu.org; 8 Jun 2024 04:44:47 +0000 Received: from localhost ([127.0.0.1]:39393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFnwb-0002Ck-NI for submit@debbugs.gnu.org; Sat, 08 Jun 2024 00:44:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:57360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFnwY-0002CX-Bm for submit@debbugs.gnu.org; Sat, 08 Jun 2024 00:44:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFnwH-0006Bi-WD for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2024 00:44:26 -0400 Received: from wfhigh6-smtp.messagingengine.com ([64.147.123.157]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFnwD-0004nk-JT for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2024 00:44:25 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.west.internal (Postfix) with ESMTP id 3E59918000BD; Sat, 8 Jun 2024 00:44:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 08 Jun 2024 00:44:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bcc32.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm1; t=1717821855; x=1717908255; bh=yf9HXFAB3+qVn5kh3D7tb1rvT5rdn7nG TZ2pIFJvxAo=; b=DSjITYOD6DPlhvEI0H0zajBI2j/qggwtaYWhJG2RKeMeJ9Wn nWbtCF/xB7PJ0+AZfr52nSO2R1ABlRT0LpVgX60to5NDVrPyAwNqOiJsn8GHr+Nz m4N/c+K6CuHZaJXkyNOIXWbfuuFWtzeI+yxWLVyI9I3Hlifqd3OMO/fr4RQQJvVP /t+EulmTUZulK7dfq/VAWtyGqI85jOsqg8sY6iPtznSq5ZdjmMH+TpEOAupIlWmw aarCcrf+jopJ43uWjE+hg7/iaSXWKmy1z901AvK6B8uh1VzD9H6/c/InM5ykOCqk UV7MdcYpyPC9EOK3oH1As2688n3lEJbKrwKYRA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1717821855; x=1717908255; bh=yf9HXFAB3+qVn5kh3D7tb1rvT5rdn7nGTZ2 pIFJvxAo=; b=kDopN3Xr2ISw48b+GkyeimZvyH3DzTeuaM1n4/pBWaUSgtUkJzu T7/yrSeVoaPTfTuXvRpbq3ibrPdkyJ43ELjwWjctm5N3Mw1qo6XmAYNhVmH2DIQ/ 6iMPXXg9XCbaxVWSarwYWVqB1DUwkOKzz2soceIp2j75jUa83hXc2HETF7uTbTKw 4pmkwf/FBm6BX4btE97oeg0uwCYrakFO3d9wxJJLYk0pb7nCZKTArgc2Ptls//9H BW4YADEKsWAOFkuEKBqE01pygIRyLdl0clCwNFAgoAc0lUR/tmJ0nVa5sF5RcfON K2GAA4eEl8Pv1e2Koh6rm04qDZ4p5/7pZxw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedtvddgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkfggtgesthdtredttd dttdenucfhrhhomhepiiessggttgefvddrtghomhenucggtffrrghtthgvrhhnpefgveeg tdfgffdttddtveejvdejkeehhfevvdeftedtgeejiedvgffgffejkefgfeenucffohhmrg hinhepthgvmhhprdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepiiessggttgefvddrtghomh X-ME-Proxy: Feedback-ID: iba994645:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 8 Jun 2024 00:44:14 -0400 (EDT) From: z@bcc32.com To: bug-gnu-emacs@gnu.org Subject: 29.3; auto-revert-use-notify buggy interaction with indirect buffers Date: Sat, 08 Jun 2024 00:44:13 -0400 Message-ID: <87ed98caci.fsf@bcc32.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.147.123.157; envelope-from=z@bcc32.com; helo=wfhigh6-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit Cc: z@bcc32.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) 1. emacs -Q 2. Enable global-auto-revert-mode, and ensure auto-revert-use-notify=t 3. Open an org file, such as ~/temp.org 4. Insert some contents: * example org contents here is a subtree * another heading 5. Save the buffer 6. Outside of Emacs, modify ~/temp.org: $ echo asdf >> ~/temp.org 7. See that temp.org's buffer is immediately reverted in Emacs and contains the new contents that were added. 8. M-x org-tree-to-indirect-buffer 9. Kill the new indirect buffer 10. Modify ~/temp.org outside of Emacs again. temp.org's buffer is not reverted, and even if you eval (auto-revert-buffers), the buffer is not reverted. At this point, `auto-revert--buffer-by-watch-descriptor' does not contain an entry for temp.org, and the value of `auto-revert-notify-watch-descriptor' in temp.org is not present as a key in that alist either. As a result, when inotify events are received by Emacs, `auto-revert-notify-handler' cannot find the buffer whose file was apparently updated, and therefore it does not set `auto-revert-notify-modified-p'. When `auto-revert-handler' runs in temp.org, it sees that `auto-revert-notify-watch-descriptor' is non-nil and `auto-revert-notify-modified-p' is nil, and skips reverting the buffer, even though the file has in fact been modified outside of Emacs. In GNU Emacs 29.3 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.0, Xaw3d scroll bars) Windowing system distributor 'HC-Consult', version 11.0.12014000 System Description: NixOS 24.05 (Uakari) Configured using: 'configure --prefix=/nix/store/8r6lgsfyak1mr2gg3ka6zkffxswkj3wv-emacs-29.3 --disable-build-details --with-modules --with-x-toolkit=lucid --with-cairo --with-xft --with-compress-install --with-toolkit-scroll-bars --with-native-compilation --without-imagemagick --with-mailutils --without-small-ja-dic --with-tree-sitter --with-xinput2 --without-xwidgets --with-dbus --with-selinux' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $EMACSLOADPATH: value of $EMACSNATIVELOADPATH: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Org Minor modes in effect: global-evil-surround-mode: t evil-surround-mode: t evil-org-mode: t org-appear-mode: t org-modern-mode: t org-superstar-mode: t org-indent-mode: t windmove-mode: t pupo-mode: t purpose-mode: t evil-escape-mode: t global-display-line-numbers-mode: t global-vi-tilde-fringe-mode: t vi-tilde-fringe-mode: t recentf-mode: t eval-sexp-fu-flash-mode: t show-smartparens-global-mode: t show-smartparens-mode: t indent-guide-global-mode: t indent-guide-mode: t dired-async-mode: t global-corfu-mode: t corfu-mode: t winner-mode: t flyspell-mode: t flycheck-pos-tip-mode: t global-flycheck-mode: t global-spacemacs-whitespace-cleanup-mode: t spacemacs-whitespace-cleanup-mode: t winum-mode: t volatile-highlights-mode: t vertico-mode: t unkillable-scratch: t global-undo-tree-mode: t undo-tree-mode: t global-term-cursor-mode: t term-cursor-mode: t save-place-mode: t savehist-mode: t persistent-scratch-autosave-mode: t org-wild-notifier-mode: t projectile-mode: t shell-dirtrack-mode: t server-mode: t mode-line-bell-mode: t marginalia-mode: t global-ligature-mode: t ligature-mode: t Info-breadcrumbs-in-mode-line-mode: t global-hl-todo-mode: t global-fasd-mode: t global-evil-quickscope-always-mode: t evil-quickscope-always-mode: t global-anzu-mode: t anzu-mode: t envrc-global-mode: t envrc-mode: t editorconfig-mode: t global-column-enforce-mode: t clean-aindent-mode: t hybrid-mode: t which-key-mode: t evil-mode: t evil-local-mode: t spacemacs-leader-override-mode: t global-spacemacs-leader-override-mode: t global-hl-line-mode: t xterm-mouse-mode: t global-auto-revert-mode: t which-function-mode: t minibuffer-depth-indicate-mode: t midnight-mode: t display-time-mode: t override-global-mode: t ido-vertical-mode: t global-page-break-lines-mode: t page-break-lines-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t column-number-mode: t line-number-mode: t auto-fill-function: org-auto-fill-function transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/aaron/.emacs.d/elpa/29.3/develop/load-env-vars-20180511.2210/load-env-vars hides /home/aaron/.emacs.d/core/libs/forks/load-env-vars /home/aaron/.emacs.d/elpa/29.3/develop/spinner-1.7.4/spinner hides /home/aaron/.emacs.d/core/libs/spinner /nix/store/gxi8whqw0hp0h1c83hh5l171qzk98n5g-emacs-packages-deps/share/emacs/site-lisp/site-start hides /nix/store/8r6lgsfyak1mr2gg3ka6zkffxswkj3wv-emacs-29.3/share/emacs/site-lisp/site-start ~/.spacemacs.d/custom hides /nix/store/8r6lgsfyak1mr2gg3ka6zkffxswkj3wv-emacs-29.3/share/emacs/29.3/lisp/custom /home/aaron/.emacs.d/elpa/29.3/develop/transient-20240603.2200/transient hides /nix/store/8r6lgsfyak1mr2gg3ka6zkffxswkj3wv-emacs-29.3/share/emacs/29.3/lisp/transient /home/aaron/.emacs.d/elpa/29.3/develop/hierarchy-20190425.842/hierarchy hides /nix/store/8r6lgsfyak1mr2gg3ka6zkffxswkj3wv-emacs-29.3/share/emacs/29.3/lisp/emacs-lisp/hierarchy /nix/store/gxi8whqw0hp0h1c83hh5l171qzk98n5g-emacs-packages-deps/share/emacs/site-lisp/elpa/let-alist-1.0.6/let-alist hides /nix/store/8r6lgsfyak1mr2gg3ka6zkffxswkj3wv-emacs-29.3/share/emacs/29.3/lisp/emacs-lisp/let-alist Features: (shadow sort mail-extr emacsbug message yank-media rfc822 mml mml-sec epa gnus-util mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader sendmail mail-utils consult-imenu consult bookmark vertico-directory evil-surround elisp-demos mule-util helpful cc-langs cc-vars cc-defs trace edebug debug backtrace info-look help-fns radix-tree elisp-refs cal-iso org-eldoc evil-org org-appear org-download org-modern org-superstar toc-org org-indent image-file image-converter oc-basic face-remap add-log windmove misearch multi-isearch zoom-frm frame-cmds frame-fns avoid spacemacs-purpose-popwin window-purpose-x imenu-list window-purpose window-purpose-fixes window-purpose-prefix-overload window-purpose-switch window-purpose-layout window-purpose-core evil-escape display-line-numbers vi-tilde-fringe persistent-soft list-utils pcache eieio-base cl font-utils recentf tree-widget overseer pkg-info url-http url-auth mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm puny epl auto-compile elisp-slime-nav flycheck-elsa flycheck-package package-lint let-alist finder eval-sexp-fu goto-addr vc-hg vc-git diff-mode vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view pcvs-util vc vc-dispatcher bug-reference evil-lisp-state highlight-numbers parent-mode highlight-parentheses hideshow rainbow-delimiters smartparens-config smartparens-org smartparens-text smartparens loadhist ol-man org-checklist ol-eshell eshell-z em-dirs esh-var em-term term disp-table ehelp em-smart esh-mode eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util files-x org-tempo tempo ol-info org-habit ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex iso8601 indent-guide fancy-battery battery dired-async dired-aux evil-collection-dired dired-x dired dired-loaddefs cus-start corfu bcc32-abbrev winner flyspell ispell window-purpose-configuration window-purpose-utils org-clock flycheck-pos-tip pos-tip flycheck-ledger flycheck evil-matchit evil-matchit-evil-setup evil-matchit-sdk semantic/lex semantic/fw mode-local spacemacs-whitespace-cleanup ws-butler winum etags fileloop xref volatile-highlights vertico-repeat vertico-quick vertico unkillable-scratch unicode-fonts undo-tree diff queue term-cursor symbol-overlay string-inflection saveplace savehist popwin persistent-scratch pdf-loader diary-lib diary-loaddefs org-wild-notifier org-duration bcc32-org bcc32-org-lint org-lint ox-texinfo ox-org ox-latex ox-icalendar ox-gfm ox-md ox-html table ox-ascii ox-publish ox org-attach projectile project lisp-mnt grep compile text-property-search ibuf-ext ibuffer ibuffer-loaddefs org-agenda org-element org-persist xdg org-id avl-tree generator org-refile magit-core magit-autorevert magit-margin magit-transient magit-process with-editor shell server magit-mode transient magit-git magit-base magit-section cursor-sensor crm org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete pcomplete comint ansi-osc org-list org-footnote org-faces org-entities time-date ob-emacs-lisp ob-core ob-eval org-cycle org-table org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs ol org-fold org-fold-core org-compat org-version org-macs async alert log4e notifications dbus xml gntp org-rich-yank orderless mode-line-bell marginalia ligature keycast info+ hl-todo compat fasd evil-unimpaired f s dash evil-textobj-line evil-quickscope evil-easymotion evil-collection-simple evil-collection-replace evil-collection-buff-menu evil-collection annalist evil-anzu anzu envrc inheritenv ansi-color editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch noutline outline drag-stuff column-enforce-mode clean-aindent-mode bcc32 zenburn-theme-autoloads yapfify-autoloads yaml-mode-autoloads ws-butler-autoloads writeroom-mode-autoloads visual-fill-column-autoloads winum-autoloads window-purpose-autoloads imenu-list-autoloads wgrep-autoloads web-mode-autoloads web-beautify-autoloads volatile-highlights-autoloads vim-powerline-autoloads vi-tilde-fringe-autoloads vertico-autoloads uuidgen-autoloads utop-autoloads unkillable-scratch-autoloads unicode-fonts-autoloads ucs-utils-autoloads font-utils-autoloads persistent-soft-autoloads pcache-autoloads undo-tree-autoloads queue-autoloads typescript-mode-autoloads tuareg-autoloads caml-autoloads toml-mode-autoloads toc-org-autoloads tide-autoloads terminal-here-autoloads term-cursor-autoloads tao-theme-autoloads tagedit-autoloads symon-autoloads symbol-overlay-autoloads string-inflection-autoloads string-edit-at-point-autoloads sql-indent-autoloads spotify-autoloads sphinx-doc-autoloads spacemacs-whitespace-cleanup-autoloads spacemacs-purpose-popwin-autoloads space-doc-autoloads solarized-theme-autoloads smeargle-autoloads slim-mode-autoloads shfmt-autoloads reformatter-autoloads shell-pop-autoloads scss-mode-autoloads sass-mode-autoloads rustic-autoloads xterm-color-autoloads rust-mode-autoloads ron-mode-autoloads reveal-in-osx-finder-autoloads restart-emacs-autoloads rainbow-delimiters-autoloads quickrun-autoloads pytest-autoloads pylookup-autoloads pyenv-mode-autoloads pydoc-autoloads py-isort-autoloads pug-mode-autoloads prettier-js-autoloads posframe-autoloads popwin-autoloads poetry-autoloads pocket-reader-autoloads org-web-tools-autoloads esxml-autoloads rainbow-identifiers-autoloads ov-autoloads pocket-lib-autoloads plz-autoloads peg-autoloads kv-autoloads pippel-autoloads pipenv-autoloads load-env-vars-autoloads pyvenv-autoloads pip-requirements-autoloads persistent-scratch-autoloads pdf-tools-autoloads tablist-autoloads password-generator-autoloads paradox-autoloads spinner-autoloads ox-gfm-autoloads overseer-autoloads osx-trash-autoloads osx-clipboard-autoloads orgit-forge-autoloads orgit-autoloads org-wild-notifier-autoloads org-superstar-autoloads org-rich-yank-autoloads org-projectile-autoloads org-project-capture-autoloads org-category-capture-autoloads org-present-autoloads org-pomodoro-autoloads alert-autoloads log4e-autoloads gntp-autoloads org-modern-autoloads org-mime-autoloads org-download-autoloads org-contrib-autoloads org-cliplink-autoloads org-appear-autoloads orderless-autoloads open-junk-file-autoloads ocp-indent-autoloads ocamlformat-autoloads npm-mode-autoloads nose-autoloads nodejs-repl-autoloads nixos-options-autoloads nix-mode-autoloads nano-agenda-autoloads nameless-autoloads multi-vterm-autoloads vterm-autoloads multi-term-autoloads multi-line-autoloads shut-up-autoloads mode-line-bell-autoloads merlin-iedit-autoloads merlin-eldoc-autoloads merlin-company-autoloads company-autoloads markdown-toc-autoloads marginalia-autoloads magit-todos-autoloads macrostep-autoloads lorem-ipsum-autoloads livid-mode-autoloads skewer-mode-autoloads live-py-mode-autoloads link-hint-autoloads ligature-autoloads launchctl-autoloads keycast-autoloads json-reformat-autoloads json-navigator-autoloads hierarchy-autoloads json-mode-autoloads json-snatcher-autoloads js2-refactor-autoloads multiple-cursors-autoloads js2-mode-autoloads js-doc-autoloads inspector-autoloads insert-shebang-autoloads info+-autoloads indent-guide-autoloads importmagic-autoloads epc-autoloads ctable-autoloads concurrent-autoloads impatient-mode-autoloads simple-httpd-autoloads ibuffer-projectile-autoloads hungry-delete-autoloads htmlize-autoloads hl-todo-autoloads highlight-parentheses-autoloads highlight-numbers-autoloads parent-mode-autoloads highlight-indentation-autoloads hide-comnt-autoloads helpful-autoloads elisp-refs-autoloads helm-make-autoloads haml-mode-autoloads google-translate-autoloads google-c-style-autoloads golden-ratio-autoloads gnuplot-autoloads gitignore-templates-autoloads git-timemachine-autoloads git-modes-autoloads git-messenger-autoloads git-link-autoloads gh-md-autoloads gendoxy-autoloads geiser-guile-autoloads geiser-chicken-autoloads geiser-autoloads forge-autoloads yaml-autoloads markdown-mode-autoloads ghub-autoloads treepy-autoloads closql-autoloads emacsql-autoloads flyspell-correct-popup-autoloads flyspell-correct-autoloads flycheck-ycmd-autoloads ycmd-autoloads pkg-info-autoloads epl-autoloads request-deferred-autoloads deferred-autoloads flycheck-rtags-autoloads rtags-autoloads flycheck-pos-tip-autoloads pos-tip-autoloads flycheck-package-autoloads package-lint-autoloads flycheck-ocaml-autoloads merlin-autoloads flycheck-ledger-autoloads flycheck-elsa-autoloads flycheck-bashate-autoloads flycheck-autoloads flx-ido-autoloads flx-autoloads fish-mode-autoloads fasd-autoloads fancy-battery-autoloads explain-pause-mode-autoloads expand-region-autoloads evil-visualstar-autoloads evil-visual-mark-mode-autoloads evil-unimpaired-autoloads evil-tutor-autoloads evil-textobj-line-autoloads evil-surround-autoloads evil-quickscope-autoloads evil-org-autoloads evil-numbers-autoloads evil-nerd-commenter-autoloads evil-matchit-autoloads evil-lisp-state-autoloads evil-lion-autoloads evil-ledger-autoloads ledger-mode-autoloads evil-indent-plus-autoloads evil-iedit-state-autoloads evil-goggles-autoloads evil-exchange-autoloads evil-escape-autoloads evil-easymotion-autoloads evil-collection-autoloads annalist-autoloads evil-cleverparens-autoloads smartparens-autoloads evil-args-autoloads evil-anzu-autoloads anzu-autoloads eval-sexp-fu-autoloads eshell-z-autoloads eshell-prompt-extras-autoloads esh-help-autoloads envrc-autoloads inheritenv-autoloads emr-autoloads iedit-autoloads paredit-autoloads list-utils-autoloads emmet-mode-autoloads embark-consult-autoloads embark-autoloads elisp-slime-nav-autoloads elisp-demos-autoloads elisp-def-autoloads editorconfig-autoloads eat-autoloads dune-autoloads dumb-jump-autoloads popup-autoloads drag-stuff-autoloads disaster-autoloads dired-quick-sort-autoloads devdocs-autoloads define-word-autoloads debbugs-autoloads cython-mode-autoloads csv-mode-autoloads cpp-auto-include-autoloads corfu-autoloads consult-yasnippet-autoloads yasnippet-autoloads consult-autoloads compleseus-spacemacs-help-autoloads command-log-mode-autoloads column-enforce-mode-autoloads code-cells-autoloads clean-aindent-mode-autoloads clang-format-autoloads centered-cursor-mode-autoloads browse-at-remote-autoloads blacken-autoloads bcc32-org-autoloads projectile-autoloads magit-autoloads magit-section-autoloads git-commit-autoloads with-editor-autoloads transient-autoloads compat-autoloads auto-highlight-symbol-autoloads ht-autoloads auto-dictionary-autoloads auto-compile-autoloads anaconda-mode-autoloads pythonic-autoloads f-autoloads dash-autoloads s-autoloads all-the-icons-autoloads ahk-mode-autoloads aggressive-indent-autoloads advent-of-code-autoloads request-autoloads ace-window-autoloads ace-link-autoloads avy-autoloads hybrid-mode evil-evilified-state pcre2el-autoloads hybrid-mode-autoloads holy-mode-autoloads evil-evilified-state-autoloads dotenv-mode-autoloads which-key hydra lv evil evil-integration evil-maps evil-commands reveal evil-jumps evil-command-window evil-types evil-search evil-ex evil-macros evil-repeat evil-states evil-core advice evil-common thingatpt rect evil-vars diminish ring bind-map which-key-autoloads hydra-autoloads lv-autoloads info evil-autoloads goto-chg-autoloads diminish-autoloads bind-map-autoloads async-autoloads thunk comp comp-cstr hl-line xt-mouse autorevert filenotify base16-material-theme base16-theme base16-theme-autoloads format-spec finder-inf which-func imenu mb-depth midnight time edmacro kmacro cl-extra use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key use-package-core ido-vertical-mode ido core-spacemacs core-use-package-ext core-spacebind core-transient-state core-micro-state core-toggle core-keybindings core-fonts-support core-themes-support core-display-init core-jump core-release-management core-custom-settings core-configuration-layer core-progress-bar core-spacemacs-buffer core-funcs spacemacs-ht inline help-mode warnings package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq password-cache json map url-vars eieio byte-opt eieio-core epg rfc6068 epg-config core-command-line core-debug derived core-hooks page-break-lines easy-mmode core-env load-env-vars rx core-dotspacemacs core-customization validate cus-edit pp cus-load icons wid-edit core-emacs-backports core-compilation pcase bytecomp byte-compile subr-x core-dumper spinner cl-macs gv cl-loaddefs cl-lib core-versions core-load-paths core-early-funcs rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 1796915 1282520) (symbols 48 91360 3) (strings 32 366852 186994) (string-bytes 1 12422101) (vectors 16 112664) (vector-slots 8 2933826 1475577) (floats 8 620 2108) (intervals 56 71575 671) (buffers 984 53)) From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 00:47:41 2024 Received: (at 71424) by debbugs.gnu.org; 8 Jun 2024 04:47:41 +0000 Received: from localhost ([127.0.0.1]:39617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFnzR-0002Ml-Gs for submit@debbugs.gnu.org; Sat, 08 Jun 2024 00:47:41 -0400 Received: from wfout3-smtp.messagingengine.com ([64.147.123.146]:50373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFnzP-0002MK-A2 for 71424@debbugs.gnu.org; Sat, 08 Jun 2024 00:47:39 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.west.internal (Postfix) with ESMTP id 4DA401C000B8 for <71424@debbugs.gnu.org>; Sat, 8 Jun 2024 00:47:17 -0400 (EDT) Received: from imap46 ([10.202.2.96]) by compute4.internal (MEProxy); Sat, 08 Jun 2024 00:47:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bcc32.com; h=cc :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm1; t=1717822036; x=1717908436; bh=FCurNLP4s+Z0WoclR8ld5/h6TTgz5hHk +3PTcNfz+ig=; b=WQlvbIRmU9pahJ8UCWG65TFUm+pvVii5ildzBeLtU4UFp2mC MRlAEy+XmsJDL92kTUgVuYSPsFvWVE0OZF4UnajQ1ik7RtMH0te0bEgnL0wfXAep M8Gd1+pM8sdH5GgjW7Q4JyfGEB2S+VknHr1l+UFZwJql0/mRW2t9TjD7EaNDH8C8 dOFM5QtP+mLY96Q3TIlmZqXq+4y33MWfQD3JmkWFkZU0gJjAl9V+bzIzKW+YuQCj kRaCmb+uOALgxcgnelVbCOmJEQrxZ7864LJwO9txmDHB263utsvuSWkYn/HeoGM3 POTRAiNdSXRrpB7tF0wyblYdmyVOvxTg+bVNeQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1717822036; x=1717908436; bh=FCurNLP4s+Z0WoclR8ld5/h6TTgz5hHk+3P TcNfz+ig=; b=H2L981vl92sXWbE0mUJwm1wk2JB55t3wqYF07/f+vAIaNWAJbHE WFXEZEKdpE9dWaRB3M15nOroeOTC+ZmhtxvKMkLjFoKARZyeOmgJpjl0DgENTyFF gpZtND+o3oGdfAAFsFtwFH1PseQCGjA65ZCnf9z/k+Kc5cd1H8QR9E0Sj4w7H38O bBCGUV0ylCc9yMcQVyUofDeoCqBDF5iZJRrj2L2tJaUxkRGZq5tbhcgVQ83oY79R 4vg3SJrNHSQOGppAq8hxcx0sVAD/Gl96YQvz9R33+1YYy+MdxwF01xkccf70rJQE Y6u0w/ryizfLVRC/5eQ6TsiUypMiYUkDZCQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedtvddgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucfgmhhpthihuchsuhgsjhgvtghtucdluddtmdenuc fjughrpefofgggkfffhffvufgtsegrtderreerredtnecuhfhrohhmpedftegrrhhonhcu kggvnhhgfdcuoeiisegstggtfedvrdgtohhmqeenucggtffrrghtthgvrhhnpefhffeugf eftddtudevudfhvdegleffkeehfeevieefieetheekkeduieefjeeugeenucffohhmrghi nhepmhhouggvshdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpeiisegstggtfedvrdgtohhm X-ME-Proxy: Feedback-ID: iba994645:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id AC99D2A20085; Sat, 8 Jun 2024 00:47:16 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-497-g97f96844c-fm-20240526.001-g97f96844 MIME-Version: 1.0 Message-Id: Date: Sat, 08 Jun 2024 00:46:55 -0400 From: "Aaron Zeng" To: 71424@debbugs.gnu.org Subject: Content-Type: multipart/alternative; boundary=813d5c3148a94175b30fefc2236ed06c X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I should add---this also happens with more common org-mode commands, such as org-capture, as well as plenty of commands from other major modes. org-capture is where I actually first noticed this issue [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [64.147.123.146 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message -0.0 T_SCC_BODY_TEXT_LINE No description available. 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: 71424 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) --813d5c3148a94175b30fefc2236ed06c Content-Type: text/plain I should add---this also happens with more common org-mode commands, such as org-capture, as well as plenty of commands from other major modes. org-capture is where I actually first noticed this issue. --813d5c3148a94175b30fefc2236ed06c Content-Type: text/html
I should add---this also happens with more common org-mode commands, such as org-capture, as well as plenty of commands from other major modes.  org-capture is where I actually first noticed this issue.
--813d5c3148a94175b30fefc2236ed06c-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 03:04:03 2024 Received: (at 71424) by debbugs.gnu.org; 8 Jun 2024 07:04:03 +0000 Received: from localhost ([127.0.0.1]:50558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFq7P-0001J5-8d for submit@debbugs.gnu.org; Sat, 08 Jun 2024 03:04:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFq7M-0001IL-Hr for 71424@debbugs.gnu.org; Sat, 08 Jun 2024 03:04:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFq71-0001ik-55; Sat, 08 Jun 2024 03:03:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BiruSM94Yqwg/6CZGZvUOvBznrcIT3YNKfuMDqvbvOA=; b=X5fnNeV/xTVq ReWSQsRvHshGbYuB+2LJ92appF3sfiK1wX1+OWcQ2bD+rDNwWgORMwvSAvyKL5E9X+ldSy2Z5eFLM HZ1LK2CA4QTV7aw5sL19fjcN3imrJZZrFHJt5rdEJixz2CaWgPeLX2yHHa9P9K1MnN+GDfhZvhUKU 1NfOJwNWfjCckdDpEWfp6SR9AXlTei/iWppb/Im+MckedeMObgcAe3Twgsw6hO13eS/BK8CrJsuKW DTTZlAIIGxarJpwqG38TLFU4O3SIKnK+S3GBxSh0kotrMljhUPTIP9YGMVjKezS3RxQnCIkiHlXVM AaStYz+Aq2R1ghwUtm1khw==; Date: Sat, 08 Jun 2024 10:03:36 +0300 Message-Id: <86h6e3ex13.fsf@gnu.org> From: Eli Zaretskii To: z@bcc32.com In-Reply-To: <87ed98caci.fsf@bcc32.com> (z@bcc32.com) Subject: Re: bug#71424: 29.3; auto-revert-use-notify buggy interaction with indirect buffers References: <87ed98caci.fsf@bcc32.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71424 Cc: 71424@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: z@bcc32.com > From: z@bcc32.com > Date: Sat, 08 Jun 2024 00:44:13 -0400 > > > 1. emacs -Q > 2. Enable global-auto-revert-mode, and ensure auto-revert-use-notify=t > 3. Open an org file, such as ~/temp.org > 4. Insert some contents: > > * example org contents > here is a subtree > * another heading > > 5. Save the buffer > 6. Outside of Emacs, modify ~/temp.org: > > $ echo asdf >> ~/temp.org > > 7. See that temp.org's buffer is immediately reverted in Emacs and > contains the new contents that were added. > 8. M-x org-tree-to-indirect-buffer > 9. Kill the new indirect buffer > > 10. Modify ~/temp.org outside of Emacs again. temp.org's buffer is > not reverted, and even if you eval (auto-revert-buffers), the > buffer is not reverted. Thanks, but did you report this to the Org developers first? If not, please do, so they could analyze the issue and determine whether it's an Org bug or a bug in some core Emacs functionality. To see that at least the basic functionality works in Emacs, I did the following: emacs -Q C-x C-f SOME-FILE RET M-x global-auto-revert-mode RET M-x clone-indirect-buffer RET Then, outside Emacs, typed from the shell prompt $ cat OTHER-FILE >> SOME-FILE where OTHER-FILE is some other existing file. After that, I saw both the base buffer's text and that of its indirect clone change to reflect the appended text. So my conclusion is that the Subject of your bug report is not accurate: the auto-revert feature does work with indirect buffers as expected. Which is why I think this might be an Org specific issue, since org-tree-to-indirect-buffer does more than just create an indirect buffer. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 11:30:53 2024 Received: (at 71424) by debbugs.gnu.org; 8 Jun 2024 15:30:53 +0000 Received: from localhost ([127.0.0.1]:39228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFy1t-0000wV-8M for submit@debbugs.gnu.org; Sat, 08 Jun 2024 11:30:53 -0400 Received: from fhigh4-smtp.messagingengine.com ([103.168.172.155]:39313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFy1r-0000wF-Bd for 71424@debbugs.gnu.org; Sat, 08 Jun 2024 11:30:51 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 4E7ED11400A8; Sat, 8 Jun 2024 11:30:30 -0400 (EDT) Received: from imap46 ([10.202.2.96]) by compute4.internal (MEProxy); Sat, 08 Jun 2024 11:30:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bcc32.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1717860630; x=1717947030; bh=YcoUWKU35I fC95iiVRqGosBE5OltszdBiZ7ZBUJ0EJY=; b=Dk3jJOorusjCGGfPqFx8xERl1I pjWduvA40CvTUlWBUErzO1k/Hx+1ftzQRIufNgHmpIkoLyJJRJbavj+36MGzhY30 f+h/40d2/rMHXvpyGJsAnCj8RVgQ44mEVjjP9QdSvBAho2IEB/2iKIwkKO+t/x8c qKjs6t1H1L6C89UJxkdJMf39nWjFbbwV/jFGA725PcPVCvReoLzEjay4nWLvjLDB s9gV5k4Amf3pnbI5r4cMea2vPiqHD4GcWPWR8/FMiG1m6Ep58l/U8fQHWQXJBD/i mGSzs+qmR4N3ixN9ew3o7L3gSkF2iZczcX+SCFultdhcSd2dWQd6AaLzwuCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1717860630; x=1717947030; bh=YcoUWKU35IfC95iiVRqGosBE5Olt szdBiZ7ZBUJ0EJY=; b=D7WKbPhsYTuD+73PEsbZJhd8d42IqclRDma8ZKubfVQt dfL0k4NSednno1ThIGQr3GzfXySlRqDH6upWad8XaQNCdn3g1yYedbBdG2URPGFH 45KAdZgnvqouHB6fp0UHXEnSg1VAcmWkD1I1u0tk1hhFhV+Nt5KFRL15y+YP7tTr VrOP0DeqvJwLokF7XOr2Ye6PV7Q/0C63B/ivReAYjR44iISw3BZrqna8390I1Dok ruybtCNiaRygrlNmD1mI9PG6oPcMGA6nLHhHpt7WJON5hkXxvN+dYTeV+WopXs71 ITUIW4WhctHalw9hLt8LzyABrCqdDo0cmj+1s+SYUg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedtgedgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftegr rhhonhcukggvnhhgfdcuoeiisegstggtfedvrdgtohhmqeenucggtffrrghtthgvrhhnpe dttdeuhfeujeegjefhvefhfeefhfegjefhtefhgeffleekheegkefgleehgedtjeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeiisegstggtfe dvrdgtohhm X-ME-Proxy: Feedback-ID: iba994645:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E3A0E2A20077; Sat, 8 Jun 2024 11:30:29 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-497-g97f96844c-fm-20240526.001-g97f96844 MIME-Version: 1.0 Message-Id: <01d36245-763b-43e8-93f8-679f176fedd0@app.fastmail.com> In-Reply-To: <86h6e3ex13.fsf@gnu.org> References: <87ed98caci.fsf@bcc32.com> <86h6e3ex13.fsf@gnu.org> Date: Sat, 08 Jun 2024 11:30:08 -0400 From: "Aaron Zeng" To: "Eli Zaretskii" Subject: Re: bug#71424: 29.3; auto-revert-use-notify buggy interaction with indirect buffers Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71424 Cc: 71424@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, Jun 8, 2024, at 03:03, Eli Zaretskii wrote: > To see that at least the basic functionality works in Emacs, I did the > following: > > emacs -Q > C-x C-f SOME-FILE RET > M-x global-auto-revert-mode RET > M-x clone-indirect-buffer RET > > Then, outside Emacs, typed from the shell prompt > > $ cat OTHER-FILE >> SOME-FILE > > where OTHER-FILE is some other existing file. After that, I saw both > the base buffer's text and that of its indirect clone change to > reflect the appended text. Indeed, while the indirect buffer is live, everything works fine. However, after you kill the indirect buffer, then the buffer no longer gets auto-reverted when you modify SOME-FILE outside Emacs. > So my conclusion is that the Subject of your bug report is not > accurate: the auto-revert feature does work with indirect buffers as > expected. Which is why I think this might be an Org specific issue, > since org-tree-to-indirect-buffer does more than just create an > indirect buffer. Good point. I didn't know about M-x clone-indirect-buffer ("If I had more time, I would have written a shorter letter", etc.). Thanks for your quick reply. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 12:27:36 2024 Received: (at 71424) by debbugs.gnu.org; 8 Jun 2024 16:27:36 +0000 Received: from localhost ([127.0.0.1]:39301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFyul-0002Uw-UX for submit@debbugs.gnu.org; Sat, 08 Jun 2024 12:27:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFyui-0002Uc-Ui for 71424@debbugs.gnu.org; Sat, 08 Jun 2024 12:27:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFyuN-0001sR-J0; Sat, 08 Jun 2024 12:27:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qufLAr54+5XXpgdcywvxv8PaNKDRI0iQtdnxz5zS64k=; b=p0nZx+DfHNC/ P3xb6bcnD/rjDS08KhLFa/huSBbyc627q9hYY7djaa8PGXIirSDazZgrj5UhJdZ0dGZxp3OuGEXHk 6dWIXzTl/d1WmYcBtEEOSceKIdiK4Yw4rQx1wAgHoxo8VtO8z94vTALWeKUc3jYFkkD8JxEENB7fG DfnmO0XLDtkG6VTro7SR1F4zp7DzXDdXvHYrUH7BONhGnuSuCQ8bV7dXbYPza5e9J9ygIJe+7r7aY fTNX57uQkPwuf0S5APEFwGLmzck4W1Q0E0aOeNeC3cYnUCqbftXWfA0SiLUeud6742QUEJ8EewOhs UZhksIy9nUWJYqBj+eO3iw==; Date: Sat, 08 Jun 2024 19:27:08 +0300 Message-Id: <86zfrvbdsz.fsf@gnu.org> From: Eli Zaretskii To: "Aaron Zeng" , Michael Albinus In-Reply-To: <01d36245-763b-43e8-93f8-679f176fedd0@app.fastmail.com> (z@bcc32.com) Subject: Re: bug#71424: 29.3; auto-revert-use-notify buggy interaction with indirect buffers References: <87ed98caci.fsf@bcc32.com> <86h6e3ex13.fsf@gnu.org> <01d36245-763b-43e8-93f8-679f176fedd0@app.fastmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71424 Cc: 71424@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 08 Jun 2024 11:30:08 -0400 > From: "Aaron Zeng" > Cc: 71424@debbugs.gnu.org > > On Sat, Jun 8, 2024, at 03:03, Eli Zaretskii wrote: > > > To see that at least the basic functionality works in Emacs, I did the > > following: > > > > emacs -Q > > C-x C-f SOME-FILE RET > > M-x global-auto-revert-mode RET > > M-x clone-indirect-buffer RET > > > > Then, outside Emacs, typed from the shell prompt > > > > $ cat OTHER-FILE >> SOME-FILE > > > > where OTHER-FILE is some other existing file. After that, I saw both > > the base buffer's text and that of its indirect clone change to > > reflect the appended text. > > Indeed, while the indirect buffer is live, everything works fine. However, after you kill the indirect buffer, then the buffer no longer gets auto-reverted when you modify SOME-FILE outside Emacs. Right. Michael, is the below the correct fix? diff --git a/lisp/autorevert.el b/lisp/autorevert.el index a23d536..ab69add 100644 --- a/lisp/autorevert.el +++ b/lisp/autorevert.el @@ -378,8 +378,11 @@ auto-revert-debug (defun auto-revert-remove-current-buffer (&optional buffer) "Remove BUFFER from `auto-revert-buffer-list'. BUFFER defaults to `current-buffer'." - (setq auto-revert-buffer-list - (delq (or buffer (current-buffer)) auto-revert-buffer-list))) + (let ((buf (or buffer (current-buffer)))) + ;; Don't remove the watch if we are killing an indirect buffer. + (or (buffer-base-buffer buf) + (setq auto-revert-buffer-list + (delq buf auto-revert-buffer-list))))) ;;;###autoload (define-minor-mode auto-revert-mode @@ -639,7 +642,9 @@ auto-revert-set-timer (defun auto-revert-notify-rm-watch () "Disable file notification for current buffer's associated file." - (when-let ((desc auto-revert-notify-watch-descriptor)) + (when-let ((desc + (and (buffer-base-buffer) + auto-revert-notify-watch-descriptor))) (setq auto-revert--buffer-by-watch-descriptor (assoc-delete-all desc auto-revert--buffer-by-watch-descriptor)) (ignore-errors From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 12:58:13 2024 Received: (at 71424) by debbugs.gnu.org; 8 Jun 2024 16:58:13 +0000 Received: from localhost ([127.0.0.1]:39343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFzOP-0003LN-9D for submit@debbugs.gnu.org; Sat, 08 Jun 2024 12:58:13 -0400 Received: from mout.gmx.net ([212.227.15.15]:41427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFzON-0003L8-6y for 71424@debbugs.gnu.org; Sat, 08 Jun 2024 12:58:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1717865866; x=1718470666; i=michael.albinus@gmx.de; bh=dLZY+ORcBpf1BPdd755u/yBDdJHXWriZwgp1bnk4/RM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=c/zsOP6n9i3WuGZB4jBKXOklLPF0nPn454uveq4eAN2JbUpRHQXGeGdqwiIiAHwa sqOGLFPOMBVFQj+kVGaGl8iXNIecltaHJi0LcVTw7uFk52wuMypBVQsLjQ85jSJCI X2uHJ8gCHLOoFP7hfJt6+slsMBATDDSB+IRbphoyPEjKY0L+6OczYiKlgXc8VfCjy BZJ7m0fm35ZsV57AjpH2xiEO6F99EEDW2RWub6UOfrTW13y7JtbhTuQep5GSespFa FInIRrUrUfTC8nLS36jUafnXyj4S1Y9ZSbMsvt3L+E/nz7FfSpNh0qpX0K7k9bIyE c19p+NtxGDrjwjulgg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.18]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M3DO3-1sHLlP2IWL-003FP0; Sat, 08 Jun 2024 18:57:46 +0200 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#71424: 29.3; auto-revert-use-notify buggy interaction with indirect buffers In-Reply-To: <86zfrvbdsz.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 08 Jun 2024 19:27:08 +0300") References: <87ed98caci.fsf@bcc32.com> <86h6e3ex13.fsf@gnu.org> <01d36245-763b-43e8-93f8-679f176fedd0@app.fastmail.com> <86zfrvbdsz.fsf@gnu.org> Date: Sat, 08 Jun 2024 18:57:45 +0200 Message-ID: <871q57gynq.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Fm7Z4T4lOSSTuVhmcQm4DZ7w+uMoP+633TiXcf2ACzZ7Sb3HIXE 7rVvi3q7IIEMd5i/UFrafp3I/OsM/wY9KCsDJJWBcLPeB+5BcaRthBW+GB8iVuMe8cFH7vH mBjamGNofCfB2fGDAhuCgCbT0hwPxrCVq7OrW0eEwZGFPxasHv+Y1MOWgW+9ehWG6y33jfc serQ9LC6sgmjtFTip5Cog== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:tEhV5KMH/xw=;Qb4vHmggf5Q5cV+XBdAd1TenhlQ XRyNA0jZawczPqSMPFK28fibPqiaVesnaGGFxIqvifxErzs/hU1gGjN0/NOYLvEnQXTFsYjab qAEfX9dGiALIJ8zdDEy/uSKENg+UpCJbyevlAh3SQfx9mDmxJduFcd9VA1OMVKMIWlFPqwpaC g1HVXiwtsiRrUnU9+DCnVEyPzf0jIbh6QcwfWtWHiCX3yCT2wU1EbV/PzSL0xdWuj8lmQRPK4 FCpfOcibjwfjS1hBv9hn8oine9IKQarQAJNRS+Ucees8u2K/iPIm/A2SnE0FsjSf9eCUVlctx yz8vFcq50hPVuJkfDlyinFimfHT0wpdbzP8gvXHs33ud0a/uaIx9cQ1qFEZKaevR6C5wm2TIV KDYPxMIMtj73dXVn359HTQlLBfEbT902mmTPEc5ffPhk5vodci2/aCxQ47ZBBxvcONoNBMUXV D2Yb9jFqcK8q9aHEQIlqhEYY0pJFmGZ7oTfEg0xzLImGLB5iKkR83ZtbvhaRQdsobgXBAu+EQ msSHyO7E4buPs1CIYoB7jvZzy/C1WPGaOGst6uBoPU0kz+Myze6NNBkYFYSNGtcSegcJrmuTE bzI7RSy0fGIAwL8/3IUt/004DxO9v7sQPF0d6QYvt5tcb6tUF6Jnz7z8UAcBKZOoG8NzxU9CD InaZFX239Sz8ExC5Z9yTH3thswQyEdmFV9aw/LWXlbQrrPZScK9pfzfa3zkBJpGgJI/zbHeTB XFvOJwwkCyhqn8gbaxJtyRDmFUnI5W02q0iNUh1+lKBOEPYjqjY7hzNJwQMjHItTqIo3laJx9 kgvH+1SGnKuOsNxbsL8FB6qxBUxrGyUfAKtFdZVfc+8tM= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71424 Cc: Aaron Zeng , 71424@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: Hi Eli, >> Indeed, while the indirect buffer is live, everything works fine. >> However, after you kill the indirect buffer, then the buffer no >> longer gets auto-reverted when you modify SOME-FILE outside Emacs. > > Right. Michael, is the below the correct fix? I haven't tested yet, but it looks proper to me. You might push it. I will add a test for this case next days. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 13:07:13 2024 Received: (at 71424) by debbugs.gnu.org; 8 Jun 2024 17:07:14 +0000 Received: from localhost ([127.0.0.1]:39353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFzX7-0003bZ-KB for submit@debbugs.gnu.org; Sat, 08 Jun 2024 13:07:13 -0400 Received: from fhigh5-smtp.messagingengine.com ([103.168.172.156]:46117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFzX5-0003bK-Oc for 71424@debbugs.gnu.org; Sat, 08 Jun 2024 13:07:12 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 76A0211400E0; Sat, 8 Jun 2024 13:06:50 -0400 (EDT) Received: from imap46 ([10.202.2.96]) by compute4.internal (MEProxy); Sat, 08 Jun 2024 13:06:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bcc32.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1717866410; x=1717952810; bh=mgrFsO066d CdfTEapUrBezJwCwrLlJyiWWCEzhiCGcY=; b=NhkqUzGT0uWkqv/d8MuM307mzN 8g9sR2j4lzd2fQ1kvPyoTqofHllsrBpKBnS1k8jZs2BxFGylK0UdM7fR/K40xbv4 fKCAK3RFm7NZygb6t7GLS1CBLeUn/qmM9HqHAIs1KTtrYPD24k2aHpXUtC0xpt7e BvXnk7CfxXXSCJC3Yjp06AHNSVMNVgOxb0mfgAsJu1RODfG1Qpt/jvNm6RUJZ4N1 j4308gfY1pqinoC0p+t20ps27wB2b+1m29/MCjUNmTt41MtbBtAI62ITIIxIVdaA 3RzfKmW+Imjtssjd3FKb00dNoLE6E0U/Y4EF5BWm6e1fIWGZZtclcEhyC6OA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1717866410; x=1717952810; bh=mgrFsO066dCdfTEapUrBezJwCwrL lJyiWWCEzhiCGcY=; b=iuTEEJXqzO+9o4JGWD+wyAzwf4XBd9MkMv66KNdoQn39 cgmeuTFsuOgoaHCp0Kf8u/15FdnDsDNpnjx9tl7Y5SCa/pJJRIoMC+5Lfc+wlJ+1 i2dR/lLu5kmRBHk9oY0O6PdySCV1EohZVtk6ebP420dvsDVIL3YDCIF5wTnsAQsW 4SRN9YcFzAqMthvp4hGtv9zlw14bf5cbCpT1DDC2xIEZiuDgJpdSFU33+2edcUBm ixC7Sdr5P9cnLcUQrFaykZvlcerwmEf7hWZK/2cJFuY4fSSppgbKnPatGkiuIbhl 6bZXoCOXmyKBiEjNd34ZtF3NYp0QQHqAx90BzjIOYQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedtgedggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftegr rhhonhcukggvnhhgfdcuoeiisegstggtfedvrdgtohhmqeenucggtffrrghtthgvrhhnpe dttdeuhfeujeegjefhvefhfeefhfegjefhtefhgeffleekheegkefgleehgedtjeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeiisegstggtfe dvrdgtohhm X-ME-Proxy: Feedback-ID: iba994645:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 17D992A20077; Sat, 8 Jun 2024 13:06:50 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-497-g97f96844c-fm-20240526.001-g97f96844 MIME-Version: 1.0 Message-Id: <718012e2-b09e-40e1-921f-d94c3aadf0d1@app.fastmail.com> In-Reply-To: <86zfrvbdsz.fsf@gnu.org> References: <87ed98caci.fsf@bcc32.com> <86h6e3ex13.fsf@gnu.org> <01d36245-763b-43e8-93f8-679f176fedd0@app.fastmail.com> <86zfrvbdsz.fsf@gnu.org> Date: Sat, 08 Jun 2024 13:06:28 -0400 From: "Aaron Zeng" To: "Eli Zaretskii" , "Michael Albinus" Subject: Re: bug#71424: 29.3; auto-revert-use-notify buggy interaction with indirect buffers Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71424 Cc: 71424@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, Jun 8, 2024, at 12:27, Eli Zaretskii wrote: > diff --git a/lisp/autorevert.el b/lisp/autorevert.el > index a23d536..ab69add 100644 > --- a/lisp/autorevert.el > +++ b/lisp/autorevert.el > @@ -378,8 +378,11 @@ auto-revert-debug > (defun auto-revert-remove-current-buffer (&optional buffer) > "Remove BUFFER from `auto-revert-buffer-list'. > BUFFER defaults to `current-buffer'." > - (setq auto-revert-buffer-list > - (delq (or buffer (current-buffer)) auto-revert-buffer-list))) > + (let ((buf (or buffer (current-buffer)))) > + ;; Don't remove the watch if we are killing an indirect buffer. > + (or (buffer-base-buffer buf) > + (setq auto-revert-buffer-list > + (delq buf auto-revert-buffer-list))))) (take my reply with a grain of salt---I'm not that familiar with this code). I think this will leave killed buffers in auto-revert-buffer-list, which seems wrong to me. > ;;;###autoload > (define-minor-mode auto-revert-mode > @@ -639,7 +642,9 @@ auto-revert-set-timer > > (defun auto-revert-notify-rm-watch () > "Disable file notification for current buffer's associated file." > - (when-let ((desc auto-revert-notify-watch-descriptor)) > + (when-let ((desc > + (and (buffer-base-buffer) > + auto-revert-notify-watch-descriptor))) > (setq auto-revert--buffer-by-watch-descriptor > (assoc-delete-all desc auto-revert--buffer-by-watch-descriptor)) > (ignore-errors Maybe I'm reading the code wrong, but should this be (not (buffer-base-buffer)) instead? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 13:45:27 2024 Received: (at 71424) by debbugs.gnu.org; 8 Jun 2024 17:45:27 +0000 Received: from localhost ([127.0.0.1]:39388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sG087-0004fz-6B for submit@debbugs.gnu.org; Sat, 08 Jun 2024 13:45:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sG081-0004fc-O9 for 71424@debbugs.gnu.org; Sat, 08 Jun 2024 13:45:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sG07g-00066I-66; Sat, 08 Jun 2024 13:45:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EO5NZ3QDLq2ZchXJFReO2d6rK32S8DNdTsHMUW/WQDs=; b=mUsPAUMK7I7j FZ/97U4rgl+I9rnSvLLDWW3KsvthrYg6vcKhsv/jD08ZExlr+hfp+v3jxWdCsStKpArQV6T6RDrFE ODV/CFKTHygekm9Oa8W+5epL97pGaEyCU+P5iCITDPzhqAG/BsNjGYNKURHj46lWTM+GxxeZGGIMR xe4Z8uVwQLroTyhIcLSn2SPptJ6LuvdGljMUx3FCLSuMqB9GsZR3oSaE3Lb+rjauxDyigUVainELo SwQ52isVwo/3UJ6rDs6bltZU4cTD/eOsNa7ISt8VwHLlOHU3+EYf3DVyrvqISEYDuCQMp7PSXxhxV G7jfQh5DsGuhHZVw1cMD9A==; Date: Sat, 08 Jun 2024 20:44:57 +0300 Message-Id: <86plsrba7a.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-Reply-To: <871q57gynq.fsf@gmx.de> (message from Michael Albinus on Sat, 08 Jun 2024 18:57:45 +0200) Subject: Re: bug#71424: 29.3; auto-revert-use-notify buggy interaction with indirect buffers References: <87ed98caci.fsf@bcc32.com> <86h6e3ex13.fsf@gnu.org> <01d36245-763b-43e8-93f8-679f176fedd0@app.fastmail.com> <86zfrvbdsz.fsf@gnu.org> <871q57gynq.fsf@gmx.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71424 Cc: z@bcc32.com, 71424@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Albinus > Cc: "Aaron Zeng" , 71424@debbugs.gnu.org > Date: Sat, 08 Jun 2024 18:57:45 +0200 > > Eli Zaretskii writes: > > Hi Eli, > > >> Indeed, while the indirect buffer is live, everything works fine. > >> However, after you kill the indirect buffer, then the buffer no > >> longer gets auto-reverted when you modify SOME-FILE outside Emacs. > > > > Right. Michael, is the below the correct fix? > > I haven't tested yet, but it looks proper to me. You might push it. Thanks, done. > I will add a test for this case next days. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 13:46:07 2024 Received: (at 71424-done) by debbugs.gnu.org; 8 Jun 2024 17:46:07 +0000 Received: from localhost ([127.0.0.1]:39393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sG08k-0004hK-Rz for submit@debbugs.gnu.org; Sat, 08 Jun 2024 13:46:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sG08j-0004gj-0k for 71424-done@debbugs.gnu.org; Sat, 08 Jun 2024 13:46:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sG08N-0006L6-0M; Sat, 08 Jun 2024 13:45:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WGfIAeT8sFb2BSsDgao/XqZGjj52m0vIptG/26H+ty0=; b=rM7SKW0gircu itLz8JULhUWzlYpno/EKpjWQ0KcN7Wtq/ZD2sak+rbrJWnx4DZX5XbYNVgPQomf5q1d9AnLQQDlrM 53Iz5uzKBhyM4c0uNeHP5uSv/m6Zd1A5k/6wQMv09C1toEIPBVGM9KdKoAWh7f0dlK2wW7QjlPCc5 CHQ3Px9A7SyoRQh4YCVFiIy3uEHOep/XkQLoMIsKetL9jHgV+HsTGlgngHTyuJdy1UVq+EfFXeSVT ypQmJ4O4eJXRCz8S6+dE/GYsiZxTeoH+fBATfm02zzdHznIFqC1QYPgjSjQdVCnwkZi6TMdzIxfda B4Jle94ALuPrfnmOH5vZdQ==; Date: Sat, 08 Jun 2024 20:45:41 +0300 Message-Id: <86o78bba62.fsf@gnu.org> From: Eli Zaretskii To: "Aaron Zeng" In-Reply-To: <718012e2-b09e-40e1-921f-d94c3aadf0d1@app.fastmail.com> (z@bcc32.com) Subject: Re: bug#71424: 29.3; auto-revert-use-notify buggy interaction with indirect buffers References: <87ed98caci.fsf@bcc32.com> <86h6e3ex13.fsf@gnu.org> <01d36245-763b-43e8-93f8-679f176fedd0@app.fastmail.com> <86zfrvbdsz.fsf@gnu.org> <718012e2-b09e-40e1-921f-d94c3aadf0d1@app.fastmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71424-done Cc: michael.albinus@gmx.de, 71424-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 08 Jun 2024 13:06:28 -0400 > From: "Aaron Zeng" > Cc: 71424@debbugs.gnu.org > > On Sat, Jun 8, 2024, at 12:27, Eli Zaretskii wrote: > > diff --git a/lisp/autorevert.el b/lisp/autorevert.el > > index a23d536..ab69add 100644 > > --- a/lisp/autorevert.el > > +++ b/lisp/autorevert.el > > @@ -378,8 +378,11 @@ auto-revert-debug > > (defun auto-revert-remove-current-buffer (&optional buffer) > > "Remove BUFFER from `auto-revert-buffer-list'. > > BUFFER defaults to `current-buffer'." > > - (setq auto-revert-buffer-list > > - (delq (or buffer (current-buffer)) auto-revert-buffer-list))) > > + (let ((buf (or buffer (current-buffer)))) > > + ;; Don't remove the watch if we are killing an indirect buffer. > > + (or (buffer-base-buffer buf) > > + (setq auto-revert-buffer-list > > + (delq buf auto-revert-buffer-list))))) > > (take my reply with a grain of salt---I'm not that familiar with this code). I think this will leave killed buffers in auto-revert-buffer-list, which seems wrong to me. Fixed. > > ;;;###autoload > > (define-minor-mode auto-revert-mode > > @@ -639,7 +642,9 @@ auto-revert-set-timer > > > > (defun auto-revert-notify-rm-watch () > > "Disable file notification for current buffer's associated file." > > - (when-let ((desc auto-revert-notify-watch-descriptor)) > > + (when-let ((desc > > + (and (buffer-base-buffer) > > + auto-revert-notify-watch-descriptor))) > > (setq auto-revert--buffer-by-watch-descriptor > > (assoc-delete-all desc auto-revert--buffer-by-watch-descriptor)) > > (ignore-errors > > Maybe I'm reading the code wrong, but should this be (not (buffer-base-buffer)) instead? Also fixed. I'm therefore closing this bug. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 07:21:03 2024 Received: (at 71424) by debbugs.gnu.org; 10 Jun 2024 11:21:03 +0000 Received: from localhost ([127.0.0.1]:55668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGd5B-0003ZL-UD for submit@debbugs.gnu.org; Mon, 10 Jun 2024 07:21:03 -0400 Received: from mout.gmx.net ([212.227.17.21]:60031) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGd59-0003Z1-BU for 71424@debbugs.gnu.org; Mon, 10 Jun 2024 07:21:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1718018436; x=1718623236; i=michael.albinus@gmx.de; bh=xWS+ckrOurLY17cemC43FM4DP6NLaSClMyXgPqiK4WA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=If2N3NH5Qaiy9PRWO3SY42/lQa413t0r3l/N6wvLG22HTN9HmDLaOpVfeGO/4h5m 4P3vYqSvFh9M0PKvnps1ESNztAA4ReuBBXhYkJTAV600dxjWG2fcVp/uvi4Ni1CEB MwNPFQpdzI5v9c6syLuggz2QMCFdaZYiMqAs1Wq6tvamTn3XTHl1HfqkQDgedXHfE rgssQ8trKsLlf6rv0mgQx2hkt88CmmkRGs54LNteKl6MPzQsWTPJx2tN+lydrsuNg 3GGrFydBwT/sBgrr3d8JFj9Bjfa7TqWcmJQn+dc/3CKITxi7yiFGk6s8U0Os5ZNML n1DtewoeIV2uIBuP8w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.18]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MUGeB-1rpr334BcZ-00Pp26; Mon, 10 Jun 2024 13:15:23 +0200 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#71424: 29.3; auto-revert-use-notify buggy interaction with indirect buffers In-Reply-To: <86plsrba7a.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 08 Jun 2024 20:44:57 +0300") References: <87ed98caci.fsf@bcc32.com> <86h6e3ex13.fsf@gnu.org> <01d36245-763b-43e8-93f8-679f176fedd0@app.fastmail.com> <86zfrvbdsz.fsf@gnu.org> <871q57gynq.fsf@gmx.de> <86plsrba7a.fsf@gnu.org> Date: Mon, 10 Jun 2024 13:15:21 +0200 Message-ID: <87r0d59hh2.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:8o2IXG7Y6ID+gWJrEBgGrdfaNlzhND8BG8eGEFYcx1EVlC0jIU7 QJWi4awFJpeID0HJiU1ae/ew0GL25zbgqWj+XRBQdHWqsey74JN3Qbd1PQ0Gn8d6piHN/9W GoBeiEqfRpOE5ZgfjqwfwnRR4vmbohaIb60InZxRbbaRxcF2yO7h3EvXu8/T4lnjoqgkd9G HxRQAEsrfYQKbtTy2MueQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:8Hcv8mxTMHo=;ziJut8RdIRa5aNyevwgwWBHi20K ADQ3dX5+9zMvTI6erd1aZnK+aUFhacIajwgdEdkrV15IR0PW4eq6GvzFi8lUWv343uE51HucM sPMmm4nx5GKh7itjNLBoqn2z/akO+V384kECoD0CCUZyLsNgtaYvvrJjPciwmR/NQrd09vmvu bG2qKeSr9F6ba6qLRTRmZsSZoJfBByTzx2p8Vykiq8sjdQOP5tLMFcTvmzn0iowxXM57zA20H 0Sq/WISKvem9rgU3ZRWURRA+tlLNAvKzai8fD2iSfQTQ7gMNqKQMLH+OWfU+Zh4J+H2RLIvQc ezNFBP1CS3PrXgfHb4LXK7bk8wN32GxvKFGBfsBr+gheQwWKaCbKiYIL7XygDKoiJyZseVlWZ SCzbkl5S1oxOoCfGPFGxa+84cim5Ttuoz02hOmxjC02MQhKbfupWDi7RZy7hkyb8BYZ0sjl6h 38OFXgLvQRDemQFwR1ba4/tlzXnsNdIfFsGQtI3IZGZFW4wneKhtOnCMaoZtoRIKaQza9i13e CBLTKhGRrD9aH7s0RiI9OXf3tXoT+AwJImdOQ0RPmat27m0T52Q8Eg9QEaIEiVi/nMGeTxejV L0gl7+wwBrdec/dTidRIY8JfN9i4YdEgSwK45N0VSSMY9jCZkYJjguY/BZm0se2HDAnlb+OaR SO3C1XUmyQkwRVd3DrVONjnHWYohskjlMyypFcJVjze4o955OdxxVMTllw5FyKyPVHtqBDw3G dEbBJUzWGf0F9p9u4MQY6vhY6h5ozPOnRUV80djTGhNF+rVEukoUShfK3ZMwJetPINu3yNtQG Z8wbxTPnw7lNDNXmP4fT1c5XpWJ49cEhoUCleVNQWeY+4= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 71424 Cc: z@bcc32.com, 71424@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: Hi Eli, >> I will add a test for this case next days. > > Thanks. Done, pushed to master as 24448b7bbb8. Best regards, Michael. From unknown Sun Jun 22 00:02:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 08 Jul 2024 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator