GNU bug report logs - #71406
30.0.50; string-edit signals error when user aborts and :abort-callback parameter nil

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicholas Vollmer <nv <at> parenthetic.dev>
Subject: bug#71406: closed (Re: bug#71406: 30.0.50; string-edit signals
 error when user aborts and :abort-callback parameter nil)
Date: Sat, 15 Jun 2024 11:01:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#71406: 30.0.50; string-edit signals error when user aborts and :abort-callback parameter nil

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 71406 <at> debbugs.gnu.org.

-- 
71406: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71406
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Nicholas Vollmer <nv <at> parenthetic.dev>
Cc: 71406-done <at> debbugs.gnu.org
Subject: Re: bug#71406: 30.0.50; string-edit signals error when user aborts
 and :abort-callback parameter nil
Date: Sat, 15 Jun 2024 13:42:34 +0300

> From: Nicholas Vollmer <nv <at> parenthetic.dev>
> Cc: 71406 <at> debbugs.gnu.org
> Date: Mon, 10 Jun 2024 16:50:29 -0400
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Thanks, I fixed this with the patch below.
> 
> Makes sense. Works on my end, too.

Thanks, I'm therefore closing this bug.

[Message part 3 (message/rfc822, inline)]

From: Nicholas Vollmer <nv <at> parenthetic.dev>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; string-edit signals error when user aborts and
 :abort-callback parameter nil
Date: Thu, 06 Jun 2024 12:03:34 -0400

1. emacs -q
2. eval (string-edit "test" "" #'ignore)
3. In the "*edit string*" buffer eval string-edit-abort.

The following error is signaled:

Debugger entered--Lisp error: (void-variable 
string-edit--abort-callback)
 string-edit-abort()
 funcall-interactively(string-edit-abort)
 command-execute(string-edit-abort)

Seeing as string-edit specifies this parameter as a &key, it 
should either provide a default (#'ignore?) or error if the caller 
does not provide an abort function (Though why specify it as a 
keyword arg if it's mandatory?).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.