Subject: bug#71406: closed (Re: bug#71406: 30.0.50; string-edit signals error when user aborts and :abort-callback parameter nil)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 15 Jun 2024 11:01:02 +0000

Your bug report

#71406: 30.0.50; string-edit signals error when user aborts and :abort-callback parameter nil

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
71406: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71406
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#71406: 30.0.50; string-edit signals error when user aborts and :abort-callback parameter nil
From: Eli Zaretskii <[email-masked]>
To: Nicholas Vollmer <[email-masked]>
Cc: [email-masked]
Date: Sat, 15 Jun 2024 13:42:34 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: Nicholas Vollmer <[email-masked]>
> Cc: [email-masked]
> Date: Mon, 10 Jun 2024 16:50:29 -0400
> 
> Eli Zaretskii <[email-masked]> writes:
> 
> > Thanks, I fixed this with the patch below.
> 
> Makes sense. Works on my end, too.

Thanks, I'm therefore closing this bug.

Subject: 30.0.50; string-edit signals error when user aborts and :abort-callback parameter nil
From: Nicholas Vollmer <[email-masked]>
To: [email-masked]
Date: Thu, 06 Jun 2024 12:03:34 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

1. emacs -q
2. eval (string-edit "test" "" #'ignore)
3. In the "*edit string*" buffer eval string-edit-abort.

The following error is signaled:

Debugger entered--Lisp error: (void-variable 
string-edit--abort-callback)
  string-edit-abort()
  funcall-interactively(string-edit-abort)
  command-execute(string-edit-abort)

Seeing as string-edit specifies this parameter as a &key, it 
should either provide a default (#'ignore?) or error if the caller 
does not provide an abort function (Though why specify it as a 
keyword arg if it's mandatory?).