From unknown Sat Aug 16 23:48:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71406: 30.0.50; string-edit signals error when user aborts and :abort-callback parameter nil Resent-From: Nicholas Vollmer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jun 2024 03:51:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71406 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 71406@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17177322402947 (code B ref -1); Fri, 07 Jun 2024 03:51:03 +0000 Received: (at submit) by debbugs.gnu.org; 7 Jun 2024 03:50:40 +0000 Received: from localhost ([127.0.0.1]:41995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFQch-0000lM-LH for submit@debbugs.gnu.org; Thu, 06 Jun 2024 23:50:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:48742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFFb0-00030F-O6 for submit@debbugs.gnu.org; Thu, 06 Jun 2024 12:04:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFFal-0006Jn-Nu for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 12:03:55 -0400 Received: from out-09.pe-a.jellyfish.systems ([198.54.127.69]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sFFak-0002ZR-1K for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 12:03:55 -0400 Received: from output-router-d5c465c44-45n78 (new-01-3.privateemail.com [66.29.159.56]) by pe-a.jellyfish.systems (Postfix) with ESMTPA id 4Vw8JZ01S6z9sw2 for ; Thu, 6 Jun 2024 16:03:41 +0000 (UTC) Received: from MTA-10.privateemail.com (unknown [10.50.14.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by NEW-01-3.privateemail.com (Postfix) with ESMTPS id F18171005898 for ; Thu, 6 Jun 2024 12:03:41 -0400 (EDT) Received: from mta-10.privateemail.com (localhost [127.0.0.1]) by mta-10.privateemail.com (Postfix) with ESMTP id C865E18003C4 for ; Thu, 6 Jun 2024 12:03:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=parenthetic.dev; s=default; t=1717689821; bh=X9QArJczq6WvFXzSsKi69ikypolXKNVFwg/wPZlf8Fc=; h=From:To:Subject:Date:From; b=bv/c//pdXNiShfO8SIKKfQFpYcU5+prhti8F5Fb8OJotp1adhghVTAPTdCXJfgWrU O5rWZTM8JQl4IrD9T5UVemkDkJRNYqVSZSHjU3/gitr8X3tPW1Md5zwYhAhPd1HEtN lCUxrKAmLsJeE56XJkH+aUceP3Y83kDxOthaYLTUZwrB6Nb5LvVDnLyw7elsDWoutM ebkMFiSsFGFaugwp6M6UcOFWRCDkurR+1riIcoabGn7emZza+bM65qldJw5gMzZn9M XKGBavUw2aOsupQgcLj1l1qlCGs2I3yHS6X2WB3gpgvpiE+adu8MxsOBWs0zmdFehy UAJvCvmJDXQ4A== Received: from laptop (c-174-166-84-198.hsd1.nj.comcast.net [174.166.84.198]) by mta-10.privateemail.com (Postfix) with ESMTPA for ; Thu, 6 Jun 2024 12:03:41 -0400 (EDT) From: Nicholas Vollmer Date: Thu, 06 Jun 2024 12:03:34 -0400 Message-ID: <87bk4eawix.fsf@parenthetic.dev> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Virus-Scanned: ClamAV using ClamSMTP Received-SPF: pass client-ip=198.54.127.69; envelope-from=nv@parenthetic.dev; helo=out-09.pe-a.jellyfish.systems X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Mailman-Approved-At: Thu, 06 Jun 2024 23:50:36 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) 1. emacs -q 2. eval (string-edit "test" "" #'ignore) 3. In the "*edit string*" buffer eval string-edit-abort. The following error is signaled: Debugger entered--Lisp error: (void-variable string-edit--abort-callback) string-edit-abort() funcall-interactively(string-edit-abort) command-execute(string-edit-abort) Seeing as string-edit specifies this parameter as a &key, it should either provide a default (#'ignore?) or error if the caller does not provide an abort function (Though why specify it as a keyword arg if it's mandatory?). From unknown Sat Aug 16 23:48:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71406: 30.0.50; string-edit signals error when user aborts and :abort-callback parameter nil Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jun 2024 13:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71406 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Nicholas Vollmer Cc: 71406@debbugs.gnu.org Received: via spool by 71406-submit@debbugs.gnu.org id=B71406.171785220617917 (code B ref 71406); Sat, 08 Jun 2024 13:11:01 +0000 Received: (at 71406) by debbugs.gnu.org; 8 Jun 2024 13:10:06 +0000 Received: from localhost ([127.0.0.1]:37859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFvpe-0004ev-5e for submit@debbugs.gnu.org; Sat, 08 Jun 2024 09:10:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFvpc-0004eL-HK for 71406@debbugs.gnu.org; Sat, 08 Jun 2024 09:10:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFvpH-0003XM-Di; Sat, 08 Jun 2024 09:09:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CmqxXUohrRDS2FD/N4lqiV9LhNioXVPy8gLx4V5eb3k=; b=eQS1cOBKyvvQ PlQpLiEiZXq1X27Czz2Y4TXShNQ/F4qaa40e1bg5A3vPXNWueuQGksY8IylohjvsQbtWcQX+zS4p4 swze9ZZKMaBhK0CaVtte9uVhoKDJS6OXPCJmgn94eGEsWlXuVmWyeVYfrVxz/jMdchlvSS5OH/NU+ ShGaSN8jFJMlTiyLgDsZtl86QdENCLmQwKoqLSzHHIfJHc6jmMO4EV/OquUPYwe9wRI4rygbLRVNZ wdoH+0wawSazEofIwUYzZVzC+ENCcRqYK6N+qbWhCaIuo5IUrp+iAvyh/eohJNQBFIpg8BSNkaw35 +0c/zuM2tJE2EkhbubEfEg==; Date: Sat, 08 Jun 2024 16:09:33 +0300 Message-Id: <86cyord1iq.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87bk4eawix.fsf@parenthetic.dev> (message from Nicholas Vollmer on Thu, 06 Jun 2024 12:03:34 -0400) References: <87bk4eawix.fsf@parenthetic.dev> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nicholas Vollmer > Date: Thu, 06 Jun 2024 12:03:34 -0400 > > > 1. emacs -q > 2. eval (string-edit "test" "" #'ignore) > 3. In the "*edit string*" buffer eval string-edit-abort. > > The following error is signaled: > > Debugger entered--Lisp error: (void-variable > string-edit--abort-callback) > string-edit-abort() > funcall-interactively(string-edit-abort) > command-execute(string-edit-abort) > > Seeing as string-edit specifies this parameter as a &key, it > should either provide a default (#'ignore?) or error if the caller > does not provide an abort function (Though why specify it as a > keyword arg if it's mandatory?). Thanks, I fixed this with the patch below. diff --git a/lisp/textmodes/string-edit.el b/lisp/textmodes/string-edit.el index 03be426..cafed5a 100644 --- a/lisp/textmodes/string-edit.el +++ b/lisp/textmodes/string-edit.el @@ -75,8 +75,7 @@ string-edit (setq buffer-undo-list nil) (string-edit-mode) (setq-local string-edit--success-callback success-callback) - (when abort-callback - (setq-local string-edit--abort-callback abort-callback)) + (setq-local string-edit--abort-callback abort-callback) (setq-local header-line-format (substitute-command-keys "Type \\\\[string-edit-done] when you've finished editing or \\[string-edit-abort] to abort")) From unknown Sat Aug 16 23:48:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71406: 30.0.50; string-edit signals error when user aborts and :abort-callback parameter nil Resent-From: Nicholas Vollmer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Jun 2024 20:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71406 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 71406@debbugs.gnu.org Received: via spool by 71406-submit@debbugs.gnu.org id=B71406.171805266232248 (code B ref 71406); Mon, 10 Jun 2024 20:52:01 +0000 Received: (at 71406) by debbugs.gnu.org; 10 Jun 2024 20:51:02 +0000 Received: from localhost ([127.0.0.1]:59078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGlyo-0008O3-5P for submit@debbugs.gnu.org; Mon, 10 Jun 2024 16:51:02 -0400 Received: from mta-09-4.privateemail.com ([198.54.127.118]:49536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGlym-0008NP-BD for 71406@debbugs.gnu.org; Mon, 10 Jun 2024 16:51:01 -0400 Received: from mta-09.privateemail.com (localhost [127.0.0.1]) by mta-09.privateemail.com (Postfix) with ESMTP id 9CE621800195; Mon, 10 Jun 2024 16:50:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=parenthetic.dev; s=default; t=1718052636; bh=Q74QZWSWr+iWwlBLjCZH3z4mKakZaWxwHSJiMSjSa+Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ip48JhFdmEA14efn7PIggGxNDmZMYQtcZYRs0Gdk4tptOthvzVQPJNVkIlTfeToKK 5bZgBjX99fH0HdQUgUrGJV+kPgHYKr6EK/YsaQ39uH2zAChCutglE1gK296lHxE2cb PIOjviu8LPJQL8U76UD9O8pHuX+Gt05TijMHcLCpUY+T/MFimGqttOIKg0wZxNPCBE n5iPIOpBrPvvciYcAkICsmVzUWZEyaNBtUVFVi+Xa2E20AmWTO/kiZQMYaedaqn9Vb NFfXnos6bKRH/bXQxs2c+RuM6GOgaYvuc7ck0vkdAF+NwX1Eeb96Y3c39mAIvYFWgG TiFbaksrisbLw== Received: from laptop (c-174-166-84-198.hsd1.nj.comcast.net [174.166.84.198]) by mta-09.privateemail.com (Postfix) with ESMTPA; Mon, 10 Jun 2024 16:50:35 -0400 (EDT) From: Nicholas Vollmer In-Reply-To: <86cyord1iq.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 08 Jun 2024 16:09:33 +0300") References: <87bk4eawix.fsf@parenthetic.dev> <86cyord1iq.fsf@gnu.org> Date: Mon, 10 Jun 2024 16:50:29 -0400 Message-ID: <87y17cwmi2.fsf@parenthetic.dev> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Thanks, I fixed this with the patch below. Makes sense. Works on my end, too. From unknown Sat Aug 16 23:48:37 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nicholas Vollmer Subject: bug#71406: closed (Re: bug#71406: 30.0.50; string-edit signals error when user aborts and :abort-callback parameter nil) Message-ID: References: <868qz6v65h.fsf@gnu.org> <87bk4eawix.fsf@parenthetic.dev> X-Gnu-PR-Message: they-closed 71406 X-Gnu-PR-Package: emacs Reply-To: 71406@debbugs.gnu.org Date: Sat, 15 Jun 2024 11:01:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1718449262-21618-1" This is a multi-part message in MIME format... ------------=_1718449262-21618-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #71406: 30.0.50; string-edit signals error when user aborts and :abort-call= back parameter nil which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 71406@debbugs.gnu.org. --=20 71406: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71406 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1718449262-21618-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 71406-done) by debbugs.gnu.org; 15 Jun 2024 11:00:16 +0000 Received: from localhost ([127.0.0.1]:35092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIR8p-0005Zb-IQ for submit@debbugs.gnu.org; Sat, 15 Jun 2024 07:00:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIR8h-0005Xa-RD for 71406-done@debbugs.gnu.org; Sat, 15 Jun 2024 07:00:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIQrk-0005T2-Kd; Sat, 15 Jun 2024 06:42:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+rGgqL/BzptRiLQIO1MKsz9F5anOYuwRnSX/7GYYrPs=; b=pqP0TeMrvbVn BpDQZ2v/Vh0NqFFNNGSPNiGPlRT9E2s4QXzJpgSeXiZsDd7GdNfaNt/fv3JO+Rd5iu9WHwqTPZA6i u8QqdUJqr7+yVeWmWrL3uf8OpOKxP75fviHrBuqnCP+bKCu1vbd71wMYteZhNJloLwMVCSDgfDK2O gzrl0TXJ8l9rb/YUJN4e3Drvsy9U7quoAzaYqxsSBB6s/5P2E4m/+rrqgfiHMxTD1yVrAQHVShv7G CzS+YRDQkUTcLNo83ttYmfGayRb/Kpx1R+aNEaGaZMwKA6/L/mQHNfjQGvDxk1k8Yhv9EeaTMaF5q eFoKzh0g5338oPPoZzj7qg==; Date: Sat, 15 Jun 2024 13:42:34 +0300 Message-Id: <868qz6v65h.fsf@gnu.org> From: Eli Zaretskii To: Nicholas Vollmer In-Reply-To: <87y17cwmi2.fsf@parenthetic.dev> (message from Nicholas Vollmer on Mon, 10 Jun 2024 16:50:29 -0400) Subject: Re: bug#71406: 30.0.50; string-edit signals error when user aborts and :abort-callback parameter nil References: <87bk4eawix.fsf@parenthetic.dev> <86cyord1iq.fsf@gnu.org> <87y17cwmi2.fsf@parenthetic.dev> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71406-done Cc: 71406-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nicholas Vollmer > Cc: 71406@debbugs.gnu.org > Date: Mon, 10 Jun 2024 16:50:29 -0400 > > Eli Zaretskii writes: > > > Thanks, I fixed this with the patch below. > > Makes sense. Works on my end, too. Thanks, I'm therefore closing this bug. ------------=_1718449262-21618-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Jun 2024 03:50:40 +0000 Received: from localhost ([127.0.0.1]:41995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFQch-0000lM-LH for submit@debbugs.gnu.org; Thu, 06 Jun 2024 23:50:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:48742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFFb0-00030F-O6 for submit@debbugs.gnu.org; Thu, 06 Jun 2024 12:04:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFFal-0006Jn-Nu for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 12:03:55 -0400 Received: from out-09.pe-a.jellyfish.systems ([198.54.127.69]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sFFak-0002ZR-1K for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 12:03:55 -0400 Received: from output-router-d5c465c44-45n78 (new-01-3.privateemail.com [66.29.159.56]) by pe-a.jellyfish.systems (Postfix) with ESMTPA id 4Vw8JZ01S6z9sw2 for ; Thu, 6 Jun 2024 16:03:41 +0000 (UTC) Received: from MTA-10.privateemail.com (unknown [10.50.14.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by NEW-01-3.privateemail.com (Postfix) with ESMTPS id F18171005898 for ; Thu, 6 Jun 2024 12:03:41 -0400 (EDT) Received: from mta-10.privateemail.com (localhost [127.0.0.1]) by mta-10.privateemail.com (Postfix) with ESMTP id C865E18003C4 for ; Thu, 6 Jun 2024 12:03:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=parenthetic.dev; s=default; t=1717689821; bh=X9QArJczq6WvFXzSsKi69ikypolXKNVFwg/wPZlf8Fc=; h=From:To:Subject:Date:From; b=bv/c//pdXNiShfO8SIKKfQFpYcU5+prhti8F5Fb8OJotp1adhghVTAPTdCXJfgWrU O5rWZTM8JQl4IrD9T5UVemkDkJRNYqVSZSHjU3/gitr8X3tPW1Md5zwYhAhPd1HEtN lCUxrKAmLsJeE56XJkH+aUceP3Y83kDxOthaYLTUZwrB6Nb5LvVDnLyw7elsDWoutM ebkMFiSsFGFaugwp6M6UcOFWRCDkurR+1riIcoabGn7emZza+bM65qldJw5gMzZn9M XKGBavUw2aOsupQgcLj1l1qlCGs2I3yHS6X2WB3gpgvpiE+adu8MxsOBWs0zmdFehy UAJvCvmJDXQ4A== Received: from laptop (c-174-166-84-198.hsd1.nj.comcast.net [174.166.84.198]) by mta-10.privateemail.com (Postfix) with ESMTPA for ; Thu, 6 Jun 2024 12:03:41 -0400 (EDT) From: Nicholas Vollmer To: bug-gnu-emacs@gnu.org Subject: 30.0.50; string-edit signals error when user aborts and :abort-callback parameter nil X-Debbugs-Cc: Date: Thu, 06 Jun 2024 12:03:34 -0400 Message-ID: <87bk4eawix.fsf@parenthetic.dev> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Virus-Scanned: ClamAV using ClamSMTP Received-SPF: pass client-ip=198.54.127.69; envelope-from=nv@parenthetic.dev; helo=out-09.pe-a.jellyfish.systems X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 06 Jun 2024 23:50:36 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) 1. emacs -q 2. eval (string-edit "test" "" #'ignore) 3. In the "*edit string*" buffer eval string-edit-abort. The following error is signaled: Debugger entered--Lisp error: (void-variable string-edit--abort-callback) string-edit-abort() funcall-interactively(string-edit-abort) command-execute(string-edit-abort) Seeing as string-edit specifies this parameter as a &key, it should either provide a default (#'ignore?) or error if the caller does not provide an abort function (Though why specify it as a keyword arg if it's mandatory?). ------------=_1718449262-21618-1--