From unknown Sun Jun 22 07:59:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71404: 30.0.50; [WISHLIST] string-edit-mode should allow changing major mode Resent-From: Nicholas Vollmer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jun 2024 03:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71404 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 71404@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17177322382916 (code B ref -1); Fri, 07 Jun 2024 03:51:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Jun 2024 03:50:38 +0000 Received: from localhost ([127.0.0.1]:41984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFQcf-0000kv-GB for submit@debbugs.gnu.org; Thu, 06 Jun 2024 23:50:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:44714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFFO7-0002fX-U0 for submit@debbugs.gnu.org; Thu, 06 Jun 2024 11:50:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFFNs-0000Xk-Uz for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 11:50:36 -0400 Received: from out-14.pe-a.jellyfish.systems ([198.54.127.78]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sFFNq-0008M9-UB for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 11:50:36 -0400 Received: from output-router-d5c465c44-d7pgd (new-01-3.privateemail.com [66.29.159.56]) by pe-a.jellyfish.systems (Postfix) with ESMTPA id 4Vw81D0BZFz9s9T for ; Thu, 6 Jun 2024 15:50:24 +0000 (UTC) Received: from MTA-06.privateemail.com (unknown [10.50.14.16]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by NEW-01-3.privateemail.com (Postfix) with ESMTPS id F21CC100588A for ; Thu, 6 Jun 2024 11:50:23 -0400 (EDT) Received: from mta-06.privateemail.com (localhost [127.0.0.1]) by mta-06.privateemail.com (Postfix) with ESMTP id C9F77180295B for ; Thu, 6 Jun 2024 11:50:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=parenthetic.dev; s=default; t=1717689023; bh=4Egc28zKM2Mqp5Qkur4jS3ZfOpNDYtGxcToGsL5VuGg=; h=From:To:Subject:Date:From; b=N1DKfaFupa4S7OzLo97BHl7sGlq+KVlD3V+oQLrMPj44V4b1PtCbFMyDTch9hpsO8 g5dApO2J1/LvVI7ZQ4dv6vTqTo5bOzfyhFFM4u9zf/LYB0XYJ9j3B+/Xak3vgxqJPS XGN2XpIdWasbi80kNouYQql5qjBtAm+LN1tceOnB1874zjkHAqnDoErCpmcu/rvoMA hpaH1syMDUgX8Cvj0CCofDbnJyOU0r9Xna9AsPsnhPSck2b7PjnK6PG4eDDba1sMC5 D54gvjlnVrNmfAobQSEP33E23QlNf0YwWhRNv4Cr7z1KYMgid03vqs270jdH6oDeY+ l3BnULgSCNOkQ== Received: from laptop (c-174-166-84-198.hsd1.nj.comcast.net [174.166.84.198]) by mta-06.privateemail.com (Postfix) with ESMTPA for ; Thu, 6 Jun 2024 11:50:23 -0400 (EDT) From: Nicholas Vollmer Date: Thu, 06 Jun 2024 11:50:16 -0400 Message-ID: <87msnyax53.fsf@parenthetic.dev> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Virus-Scanned: ClamAV using ClamSMTP Received-SPF: pass client-ip=198.54.127.78; envelope-from=nv@parenthetic.dev; helo=out-14.pe-a.jellyfish.systems X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Mailman-Approved-At: Thu, 06 Jun 2024 23:50:36 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) string-edit-mode is a nice feature to have built in. It would be nice if one could change the major mode of the editing buffer while preserving the edit/abort functionality and any buffer state necessary to make those function. Any reason it couldn't be implemented as a minor mode? From unknown Sun Jun 22 07:59:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71404: 30.0.50; [WISHLIST] string-edit-mode should allow changing major mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jun 2024 06:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71404 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Nicholas Vollmer Cc: 71404@debbugs.gnu.org Received: via spool by 71404-submit@debbugs.gnu.org id=B71404.17177423322340 (code B ref 71404); Fri, 07 Jun 2024 06:39:02 +0000 Received: (at 71404) by debbugs.gnu.org; 7 Jun 2024 06:38:52 +0000 Received: from localhost ([127.0.0.1]:54716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFTFU-0000be-0q for submit@debbugs.gnu.org; Fri, 07 Jun 2024 02:38:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFTFS-0000b7-BE for 71404@debbugs.gnu.org; Fri, 07 Jun 2024 02:38:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFTC8-00022B-Qt; Fri, 07 Jun 2024 02:35:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yNmAUwxu55fwY4c9OEPv66TA7OrnPY38/XsIJvVB/WU=; b=SB426Iq2alAF ThY5TG8hUtAW1VCR0ntqkNWfxJUkFE0maMpKfd+gAXK8iJSBaaFkWlF9ssjZNhfOxT5nw6ORtCqtl cE/YiigNjQdReM97EyUgmLOhsZmVZGa5xhHSPBDGX1ocH8yTFQR8Of4r8/WmskQw+cUMyHhAx7oVU Pe+DbK6QFRW2Mpv619PIhXb6Tq6njsmvc5kuwcIN50N/3hCk3Eq38Y30/RAxtDXPoScX89k45Q1kt 0zjU7HRMBasaaN9NV8YK/f0SxyBLpUzYgwViciP4Ftn4+vMqtu/W6fCn5Ejmjqp88Hn8N8uM4BHAI kGt0EMpon06cn2Qomn3QVg==; Date: Fri, 07 Jun 2024 09:35:22 +0300 Message-Id: <86o78dfefp.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87msnyax53.fsf@parenthetic.dev> (message from Nicholas Vollmer on Thu, 06 Jun 2024 11:50:16 -0400) References: <87msnyax53.fsf@parenthetic.dev> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nicholas Vollmer > Date: Thu, 06 Jun 2024 11:50:16 -0400 > > > string-edit-mode is a nice feature to have built in. It already is? Or what do you mean by "built in" here? > It would be nice if one could change the major mode of the editing > buffer while preserving the edit/abort functionality and any > buffer state necessary to make those function. > Any reason it couldn't be implemented as a minor mode? In what major modes will this make sense as a minor mode? IOW, I don't think I understand what you mean by "preserving the edit/abort functionality and buffer state", so please elaborate. From unknown Sun Jun 22 07:59:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71404: 30.0.50; [WISHLIST] string-edit-mode should allow changing major mode Resent-From: Nicholas Vollmer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jun 2024 23:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71404 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 71404@debbugs.gnu.org Received: via spool by 71404-submit@debbugs.gnu.org id=B71404.171780348717141 (code B ref 71404); Fri, 07 Jun 2024 23:39:02 +0000 Received: (at 71404) by debbugs.gnu.org; 7 Jun 2024 23:38:07 +0000 Received: from localhost ([127.0.0.1]:45413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFj9r-0004SN-AS for submit@debbugs.gnu.org; Fri, 07 Jun 2024 19:38:07 -0400 Received: from mta-12-4.privateemail.com ([198.54.127.107]:33645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFj9o-0004Rh-Iz for 71404@debbugs.gnu.org; Fri, 07 Jun 2024 19:38:05 -0400 Received: from mta-12.privateemail.com (localhost [127.0.0.1]) by mta-12.privateemail.com (Postfix) with ESMTP id F25461800041; Fri, 7 Jun 2024 19:37:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=parenthetic.dev; s=default; t=1717803463; bh=nij9V82IMxOqFUvKFw36xwon2I7SwVA6azX6rLt+DDM=; h=From:To:Cc:Subject:In-Reply-To:Date:References:From; b=cc8yytq1QCb8l8PHtN53sI+u/FpzPN88x3HQyf38I7HibYoEjFXzcpnjgzm1q4c2E xsok6mxUoKatGafIuPX1AUNXoxmRzq1XM901NHZfKDOHK1nhdHHfhtqZjv7jLxCU8Z /k+M1RNq64RrxOlTwLoR2I03F2o0tem+gYxJBIkXU8gnaxs6hIz6so8HiFSoaUzFnc G/bFRPiQ1vDsY1uqb+EvMzC1xkhDAwQ8K6KXEO6hWoJKZ+f2+c14GFBf/yv/qzHGcJ VqksWM1RabCMjozaSzu8e39F6vBh2Xz3pri1KsBkObkYnmQRqLZcHvtcAep5GLYh89 NH2Hy0BLKmd9w== Received: from laptop (c-174-166-84-198.hsd1.nj.comcast.net [174.166.84.198]) by mta-12.privateemail.com (Postfix) with ESMTPA; Fri, 7 Jun 2024 19:37:41 -0400 (EDT) From: Nicholas Vollmer In-Reply-To: <86o78dfefp.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 07 Jun 2024 09:35:22 +0300") Date: Fri, 07 Jun 2024 19:37:24 -0400 References: <87msnyax53.fsf@parenthetic.dev> <86o78dfefp.fsf@gnu.org> Message-ID: <87plsspbnl.fsf@parenthetic.dev> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Nicholas Vollmer >> Date: Thu, 06 Jun 2024 11:50:16 -0400 >> >> >> string-edit-mode is a nice feature to have built in. > > It already is? Or what do you mean by "built in" here? Correct. It is. I was just commenting that I'm glad to see it part of Emacs, rather than re-implemented over and over in third-party packages. That is all. >> It would be nice if one could change the major mode of the >> editing >> buffer while preserving the edit/abort functionality and any >> buffer state necessary to make those function. >> Any reason it couldn't be implemented as a minor mode? > > In what major modes will this make sense as a minor mode? Many. For example. If the string to edit is an elisp form, why shouldn't the editing buffer be emacs-lisp-mode? If the string to edit is a message which can be formatted with markdown, why not markdown-mode? (I ran into this yesterday when implementing a command for personal use). I can imagine many scenarios where the major mode could be something other than text-mode. It seems to me that it would make more sense for the "abort/finish" key bindings to be bound to a minor mode map so the editing buffer can be much more flexible. > IOW, I don't think I understand what you mean by "preserving the > edit/abort functionality and buffer state", so please elaborate. The buffer has some local state (e.g. the abort callback function, header-line) stored in a buffer-local variables which are not preserved when the major mode is changed. From unknown Sun Jun 22 07:59:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71404: 30.0.50; [WISHLIST] string-edit-mode should allow changing major mode Resent-From: Nicholas Vollmer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jun 2024 02:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71404 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 71404@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171781444017013 (code B ref -1); Sat, 08 Jun 2024 02:41:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Jun 2024 02:40:40 +0000 Received: from localhost ([127.0.0.1]:58072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFm0W-0004QJ-AU for submit@debbugs.gnu.org; Fri, 07 Jun 2024 22:40:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:46018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFm0T-0004Pz-Pw for submit@debbugs.gnu.org; Fri, 07 Jun 2024 22:40:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFlkf-0004ta-0G for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2024 22:24:17 -0400 Received: from mta-06-4.privateemail.com ([198.54.122.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFlkd-0008Qt-6u for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2024 22:24:16 -0400 Received: from mta-06.privateemail.com (localhost [127.0.0.1]) by mta-06.privateemail.com (Postfix) with ESMTP id 037B318000AE for ; Fri, 7 Jun 2024 22:24:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=parenthetic.dev; s=default; t=1717813453; bh=wA1ouPn24mGJjrDu+XpB6Sfmn2jQ+kprLXTnPLyFJxQ=; h=From:To:Subject:In-Reply-To:References:Date:From; b=v2Uk23HpVtBnONSaVeyWMFf5CrUsXNQUy4dpEz0IBmWQk4uzbzg4+EV0hij8K2a2k sWeouYOMcL0E9ngLNd8bBRgnArlpmV1Qsi4g0VLg2SIuyDcnskhv/09PfP+fvpYICy yiLt8Qhy0cr/v22oVLGDYfY7LDu6nC9w49hzE9hv2OK7brvkDSetF0m7bexbyQJdTX DmJf3yTrcSzvgNP9R5VBoPTB0oyTSSK7BgPFzRzH9RIKI28VGLxZxZ5YbUHqV2w/YC BvSBHgr2fj4QWUGgkcHUb+Kn5bmndGZOHZdkfR9Mvc/FnbxKLZOtA8C2l7S6Vaf6jW HRsSjG5/lu3EA== Received: from laptop (c-174-166-84-198.hsd1.nj.comcast.net [174.166.84.198]) by mta-06.privateemail.com (Postfix) with ESMTPA for ; Fri, 7 Jun 2024 22:24:12 -0400 (EDT) From: Nicholas Vollmer In-Reply-To: <87msnyax53.fsf@parenthetic.dev> (Nicholas Vollmer's message of "Thu, 06 Jun 2024 11:50:16 -0400") References: <87msnyax53.fsf@parenthetic.dev> Date: Fri, 07 Jun 2024 22:24:06 -0400 Message-ID: <87bk4cf9yx.fsf@parenthetic.dev> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Virus-Scanned: ClamAV using ClamSMTP Received-SPF: pass client-ip=198.54.122.146; envelope-from=nv@parenthetic.dev; helo=MTA-06-4.privateemail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Nicholas Vollmer writes: Attached is a proof-of-concept patch which addresses bugs #71404, #71405, and #71406 I'll take care of that if/when the design is agreed upon. The patch rewrites string-edit-mode as a minor mode. It utilizes an overlay for the edit prompt (to persist across major mode changes) and prevents the prompt separator from being deleted. It persists the buffer-local editing data so that the major mode can be changed and the edit can still be completed. It uses #'ignore as the default abort function if none is provided. From unknown Sun Jun 22 07:59:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71404: 30.0.50; [WISHLIST] string-edit-mode should allow changing major mode Resent-From: Nicholas Vollmer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jun 2024 02:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71404 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 71404@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171781444317032 (code B ref -1); Sat, 08 Jun 2024 02:41:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Jun 2024 02:40:43 +0000 Received: from localhost ([127.0.0.1]:58075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFm0Y-0004Qc-P1 for submit@debbugs.gnu.org; Fri, 07 Jun 2024 22:40:43 -0400 Received: from lists.gnu.org ([209.51.188.17]:46018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFm0V-0004Pz-Al for submit@debbugs.gnu.org; Fri, 07 Jun 2024 22:40:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFloP-0005mZ-5F for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2024 22:28:09 -0400 Received: from mta-09-4.privateemail.com ([198.54.127.118]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFloN-0000is-4H for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2024 22:28:08 -0400 Received: from mta-09.privateemail.com (localhost [127.0.0.1]) by mta-09.privateemail.com (Postfix) with ESMTP id 6D30418000AD for ; Fri, 7 Jun 2024 22:28:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=parenthetic.dev; s=default; t=1717813685; bh=ZjYNdFRn1ljGYjDyKgoO3Oq2qZQZn2G9u/PB1Fm8txA=; h=From:To:Subject:In-Reply-To:References:Date:From; b=PAN5dh0qR8HOkS3/wcRGb+CJ1dnHQM07sgcCOIO6NS9YXMqhXC2wE8n74fVJxWBiX bjCy2SZ1ppUUxQYKIc4gKvr4d7MOruCURzVjnc65lR9q2J9LlFeaW8EwdOhalBvmp/ BP5UsDETaE0TYFWIzXphDmyLIzK6LjxYoMoxw3taCJXRPhBBlIt/SWaqufdtf6whhG GgzCumjODXW8R+/e42keEtQX7m5cVDWHwQQ0A9VoDjJGCVOTCS3KSHCwPOc4W4xhHR u2MtDn+D9M4JurXMjp3MhMwYMWS7QWXlPXWvT+XMWz3WwINnIOwvXgCZQBecDridGL n+hqlVzT8mI4g== Received: from laptop (c-174-166-84-198.hsd1.nj.comcast.net [174.166.84.198]) by mta-09.privateemail.com (Postfix) with ESMTPA for ; Fri, 7 Jun 2024 22:28:05 -0400 (EDT) From: Nicholas Vollmer In-Reply-To: <87bk4cf9yx.fsf@parenthetic.dev> (Nicholas Vollmer's message of "Fri, 07 Jun 2024 22:24:06 -0400") References: <87msnyax53.fsf@parenthetic.dev> <87bk4cf9yx.fsf@parenthetic.dev> Date: Fri, 07 Jun 2024 22:27:58 -0400 Message-ID: <877cf0f9sh.fsf@parenthetic.dev> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Virus-Scanned: ClamAV using ClamSMTP Received-SPF: pass client-ip=198.54.127.118; envelope-from=nv@parenthetic.dev; helo=MTA-09-4.privateemail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; format=flowed Nicholas Vollmer writes: > Nicholas Vollmer writes: > > Attached is a proof-of-concept patch which addresses bugs > #71404, #71405, and > #71406 I'll take care of that if/when the design is agreed upon. > > The patch rewrites string-edit-mode as a minor mode. > It utilizes an overlay for the edit prompt (to persist across > major mode > changes) and prevents the prompt separator from being deleted. > It persists the buffer-local editing data so that the major mode > can be changed > and the edit can still be completed. > It uses #'ignore as the default abort function if none is > provided. Sorry. Forgot to attach patch. Attached here. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lisp-textmodes-string-edit.el-refactor-as-minor-mode.patch >From 10ae067b0590884c7df6854ca04a1863782c368c Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Fri, 7 Jun 2024 22:11:16 -0400 Subject: [PATCH] lisp/textmodes/string-edit.el: refactor as minor mode --- lisp/textmodes/string-edit.el | 82 +++++++++++++++++++---------------- 1 file changed, 45 insertions(+), 37 deletions(-) diff --git a/lisp/textmodes/string-edit.el b/lisp/textmodes/string-edit.el index 03be426ac25..0eeba50b8ed 100644 --- a/lisp/textmodes/string-edit.el +++ b/lisp/textmodes/string-edit.el @@ -23,20 +23,22 @@ ;;; Code: -(require 'cl-lib) - (defface string-edit-prompt '((t (:inherit font-lock-comment-face))) "Face used on `string-edit' help text." :group 'text :version "29.1") -(defvar string-edit--success-callback) -(defvar string-edit--abort-callback) +(defvar-local string-edit--success-callback nil) +(put 'string-edit--success-callback 'permanent-local t) +(defvar-local string-edit--abort-callback nil) +(put 'string-edit--abort-callback 'permanent-local t) +(defvar-local string-edit--prompt nil) +(put 'string-edit--prompt 'permanent-local t) + ;;;###autoload -(cl-defun string-edit (prompt string success-callback - &key abort-callback) +(defun string-edit (prompt string success-callback &optional abort-callback) "Switch to a new buffer to edit STRING. When the user finishes editing (with \\\\[string-edit-done]), SUCCESS-CALLBACK is called with the resulting string. @@ -50,36 +52,16 @@ string-edit Also see `read-string-from-buffer'." (with-current-buffer (generate-new-buffer "*edit string*") - (when prompt - (let ((inhibit-read-only t)) - (insert prompt) - (ensure-empty-lines 0) - (add-text-properties (point-min) (point) - (list 'intangible t - 'face 'string-edit-prompt - 'read-only t)) - (insert (propertize (make-separator-line) 'rear-nonsticky t)) - (add-text-properties (point-min) (point) - (list 'string-edit--prompt t)))) - (let ((start (point))) - (insert string) - (goto-char start)) - + (setq string-edit--prompt prompt + string-edit--success-callback success-callback + string-edit--abort-callback (or abort-callback #'ignore)) + (string-edit-mode) + (save-excursion (insert string)) ;; Use `fit-window-to-buffer' after the buffer is filled with text. (pop-to-buffer (current-buffer) '(display-buffer-below-selected (window-height . (lambda (window) (fit-window-to-buffer window nil 10))))) - - (set-buffer-modified-p nil) - (setq buffer-undo-list nil) - (string-edit-mode) - (setq-local string-edit--success-callback success-callback) - (when abort-callback - (setq-local string-edit--abort-callback abort-callback)) - (setq-local header-line-format - (substitute-command-keys - "Type \\\\[string-edit-done] when you've finished editing or \\[string-edit-abort] to abort")) (message "%s" (substitute-command-keys "Type \\\\[string-edit-done] when you've finished editing")))) @@ -99,9 +81,9 @@ read-string-from-buffer (lambda (edited) (setq string edited) (exit-recursive-edit)) - :abort-callback (lambda () - (exit-recursive-edit) - (error "Aborted edit"))) + (lambda () + (exit-recursive-edit) + (error "Aborted edit"))) (recursive-edit) string) @@ -109,9 +91,35 @@ string-edit-mode-map "C-c C-c" #'string-edit-done "C-c C-k" #'string-edit-abort) -(define-derived-mode string-edit-mode text-mode "String" - "Mode for editing strings." - :interactive nil) +(defun string-edit--prepare-buffer () + "Prepare `string-edit-mode' buffer." + (with-silent-modifications + (when string-edit--prompt + (insert (propertize " " 'intangible t 'read-only t)) + (let ((o (make-overlay (point-min) (point-max)))) + (overlay-put o 'display + (concat (propertize string-edit--prompt 'face 'string-edit-prompt) + "\n" + (propertize "\n" 0 1 'face '(:inherit separator-line :extend t)))) + (overlay-put o 'evaporate nil) + (insert (propertize "\n" 'string-edit--prompt t 'read-only t 'rear-nonsticky t 'intangible t 'front-sticky t))) + (setq string-edit--prompt nil)) + (setq header-line-format + (substitute-command-keys + "Type \\\\[string-edit-done] when you've finished editing or \\[string-edit-abort] to abort")) + (setq buffer-undo-list nil))) + +(define-minor-mode string-edit-mode + "Minor mode for editing strings in a dedicated buffer." + :lighter " string-edit" + (cond + (string-edit-mode + (add-hook 'after-change-major-mode-hook #'string-edit-mode nil t) + (put 'after-change-major-mode-hook 'permanent-local t) + (string-edit--prepare-buffer)) + (t + (remove-hook 'after-change-major-mode-hook #'string-edit-mode t) + (put 'after-change-major-mode-hook 'permanent-local nil)))) (defun string-edit-done () "Finish editing the string and call the callback function. -- 2.45.1 --=-=-=-- From unknown Sun Jun 22 07:59:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71404: 30.0.50; [WISHLIST] string-edit-mode should allow changing major mode Resent-From: Nicholas Vollmer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2024 20:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71404 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 71404@debbugs.gnu.org Cc: Eli Zaretskii X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171813805223104 (code B ref -1); Tue, 11 Jun 2024 20:35:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jun 2024 20:34:12 +0000 Received: from localhost ([127.0.0.1]:36667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH8C3-00060Y-SD for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:34:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:45188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH8C0-0005zL-Oy for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:34:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGm1e-0007Lm-6i for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2024 16:53:58 -0400 Received: from mta-09-4.privateemail.com ([198.54.127.118]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGm1c-00047Y-3u; Mon, 10 Jun 2024 16:53:57 -0400 Received: from mta-09.privateemail.com (localhost [127.0.0.1]) by mta-09.privateemail.com (Postfix) with ESMTP id 8C90118001A3; Mon, 10 Jun 2024 16:53:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=parenthetic.dev; s=default; t=1718052834; bh=YeYzgvjWpTkqMmUpaebGZPuPuN22eOk1F/Qxa7Hro8s=; h=From:To:Subject:In-Reply-To:References:CC:Date:From; b=ACd/27gWbOUqfwfLE+8ko4HObxeWIMhbMs4xCIxpR6Ahn2NeTnEwAbWzw8AzEEsV6 lWXzLmDzGMwMzfqac2EswXuMoxALDz9mEIYMy79WbI2dK0rUDF/P1PxNOQHm7iPlUr nTXhRhxRD2T28czNxpo9pQWOaf25o4zdRx5xkU7udKbRH1/46eBmjLSGng4sTv9buY EyX1W4lE9gVMal9SdLmuErjJROR5cVgtsAPU4pTGFOIRiG0bmct0bSbE0jn8bPlGTP 36dLhIrNZNjLGEF3GkvaWpSpOYbUqInaoHI9e8mV3+g/E7CAVZkPZ4sRjluDsmHYQ3 3C3Wkz0CS8HhA== Received: from laptop (c-174-166-84-198.hsd1.nj.comcast.net [174.166.84.198]) by mta-09.privateemail.com (Postfix) with ESMTPA; Mon, 10 Jun 2024 16:53:52 -0400 (EDT) From: Nicholas Vollmer In-Reply-To: <877cf0f9sh.fsf@parenthetic.dev> (Nicholas Vollmer's message of "Fri, 07 Jun 2024 22:27:58 -0400") References: <87msnyax53.fsf@parenthetic.dev> <87bk4cf9yx.fsf@parenthetic.dev> <877cf0f9sh.fsf@parenthetic.dev> Date: Mon, 10 Jun 2024 16:53:47 -0400 Message-ID: <87plsowmck.fsf@parenthetic.dev> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Virus-Scanned: ClamAV using ClamSMTP Received-SPF: pass client-ip=198.54.127.118; envelope-from=nv@parenthetic.dev; helo=MTA-09-4.privateemail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Nicholas Vollmer writes: > Nicholas Vollmer writes: > >> Nicholas Vollmer writes: >> >> Attached is a proof-of-concept patch which addresses bugs >> #71404, #71405, and >> #71406 I'll take care of that if/when the design is agreed >> upon. >> >> The patch rewrites string-edit-mode as a minor mode. >> It utilizes an overlay for the edit prompt (to persist across >> major mode >> changes) and prevents the prompt separator from being deleted. >> It persists the buffer-local editing data so that the major >> mode can be >> changed >> and the edit can still be completed. >> It uses #'ignore as the default abort function if none is >> provided. > > Sorry. Forgot to attach patch. > Attached here. > > [2. text/x-patch; > 0001-lisp-textmodes-string-edit.el-refactor-as-minor-mode.patch]... Any thoughts here? From unknown Sun Jun 22 07:59:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71404: 30.0.50; [WISHLIST] string-edit-mode should allow changing major mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2024 20:42:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71404 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Nicholas Vollmer Cc: 71404@debbugs.gnu.org Received: via spool by 71404-submit@debbugs.gnu.org id=B71404.171813848724175 (code B ref 71404); Tue, 11 Jun 2024 20:42:06 +0000 Received: (at 71404) by debbugs.gnu.org; 11 Jun 2024 20:41:27 +0000 Received: from localhost ([127.0.0.1]:36747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH8J5-0006Hp-D5 for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:41:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH82Q-0002i3-VB for 71404@debbugs.gnu.org; Tue, 11 Jun 2024 16:24:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGutC-0004Qx-UH; Tue, 11 Jun 2024 02:21:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NqlXub7DF1IIHwwJZYxXTu0y2WCH4V85RVecg5jMM5w=; b=Cs/k0P7oJqsY 0hbUmDfJK5QFvftbsIQLFEEaFlvFn7ezxqZ0NhSV1lZmARyvIfBhs9olVYer+VRgwS18LV75OeJnv wYNgWHO0M/t+Fqm207pHqWPbTOJzS1Q9RySb0eT6KJeWpjdYFvqYy8QWJm3cXf/hkhyDUtKNjkmRm mqrIXz9ekkD1SB+5jDiWB0kgrhbmPXCgY82ryK1X0vzW+pPkPOjVHDqrxMA/GZgQnWyVE21avoZUf 49gaf9e/a6RMab16Mve6DQFDLE2eY9KqeSA9dWtoBT7ikjmE+d2zcn+6/JFsawk/zVkJ4YxlhwpNQ uoN/0/intd59NoAoX6NJhg==; Date: Tue, 11 Jun 2024 09:21:48 +0300 Message-Id: <86o7886ltv.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87plsowmck.fsf@parenthetic.dev> (message from Nicholas Vollmer on Mon, 10 Jun 2024 16:53:47 -0400) References: <87msnyax53.fsf@parenthetic.dev> <87bk4cf9yx.fsf@parenthetic.dev> <877cf0f9sh.fsf@parenthetic.dev> <87plsowmck.fsf@parenthetic.dev> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nicholas Vollmer > CC: Eli Zaretskii > Date: Mon, 10 Jun 2024 16:53:47 -0400 > > Any thoughts here? I didn't yet have time to look into this, sorry. From unknown Sun Jun 22 07:59:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71404: 30.0.50; [WISHLIST] string-edit-mode should allow changing major mode Resent-From: No Wayman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2024 15:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71404 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Nicholas Vollmer , 71404@debbugs.gnu.org Received: via spool by 71404-submit@debbugs.gnu.org id=B71404.172071018518696 (code B ref 71404); Thu, 11 Jul 2024 15:04:02 +0000 Received: (at 71404) by debbugs.gnu.org; 11 Jul 2024 15:03:05 +0000 Received: from localhost ([127.0.0.1]:52404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRvK5-0004rU-Cr for submit@debbugs.gnu.org; Thu, 11 Jul 2024 11:03:05 -0400 Received: from mail-oi1-f180.google.com ([209.85.167.180]:49591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRvK4-0004qy-34 for 71404@debbugs.gnu.org; Thu, 11 Jul 2024 11:03:04 -0400 Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-3d934cb84b6so578982b6e.3 for <71404@debbugs.gnu.org>; Thu, 11 Jul 2024 08:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720710118; x=1721314918; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=3M7o92a3sm7B1JKB4XHk+4ENu+6chgLu5Xmn9YpuIgA=; b=PKAbR4AH853RD8Ule1idZDIYNVZ8BLmoDQ7Zpmx0o3dvorZnPiOjklHqz3jaexX8xN 1bugcA81ODeaJHjrwQ4RWj6JeLzxFDrjRF7z5sMERxvf0Txp3RvQZqx//YGrY28fHMRi /KG3f+AzZzSWylkb+4gh60sLQ0egD2tXd57RZ2fJnH4B4zEfIPgdix1Cl6QVXtGhPLCQ QpmNYzfN7mAylIXb4OYY6V1zhL+C340F7zdFM86UJSQ/zMm/DMNxGFwVo5Zcg0N4p8px hrtQPzY0tYYYkJE8mznKoEdglNXmUIuOR2w8soY1P80Pw2hOxxN1R0j5j73zxNZYECp8 rYQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720710118; x=1721314918; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3M7o92a3sm7B1JKB4XHk+4ENu+6chgLu5Xmn9YpuIgA=; b=iEpvK929G09geifF+HIpbGjvZiyGFTxdQ2Ekmq2jMquL+iuh8KIjXSs+vPakBK6jjB cYWqjXbh1/2uvh4cjNJVHc5UUE731c3q9GAXBZbmnlI/pNyf0cOd/DijLMzEPihPy54k NKNW7mzuvL8hY9XK02GnAFbIOu09L8zQ5FfyNJ3uCziiUhLDX6gliqnD99oO3rqKzxqA GQD9Wab/0Z/w/qexROZ5+zIZLl/hNzwoFKZTlJrM2dXh9dvmboLwsFu9NKxgN9HaRrAQ IDGhWO+QbS1d/lh5gs/R87Q+uKcVoZQQgEiMBrOira6fwEitlvUVl4lD3cekcvvVIhY+ viXw== X-Forwarded-Encrypted: i=1; AJvYcCWMbogNSFjm0yjsUh5fT7fZR4RCIDXEWT7yyS3THfNF/34WnnsZ0pM/A7a45Co/hecSyJTTJwhfNMKQODruYtVegaosj2k= X-Gm-Message-State: AOJu0Yw0+5ikpt4d0jBOsoUgvzhx3EY+cAEcQxxQf4h4s37ECmUv0g7H i6ufa08SeYgvaffeQVa98ywWrHFAuUXBZhqT7+uLOYKGosW+t6XK3T3IDQ== X-Google-Smtp-Source: AGHT+IE/YMcYFpfhHYnpkvrD75hr7kre82T5aZEJCbmTkvLm4VuOvbtImIxyvbp7lrLbXN6lzb2G1Q== X-Received: by 2002:a05:6808:1928:b0:3d9:3671:e4dc with SMTP id 5614622812f47-3d93beda43amr9578899b6e.12.1720710117206; Thu, 11 Jul 2024 08:01:57 -0700 (PDT) Received: from laptop ([2601:84:847f:c697:e217:2894:4724:14f4]) by smtp.gmail.com with ESMTPSA id af79cd13be357-79f1908ae8csm298980285a.88.2024.07.11.08.01.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jul 2024 08:01:56 -0700 (PDT) From: No Wayman X-Google-Original-From: No Wayman In-Reply-To: <86o7886ltv.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Jun 2024 09:21:48 +0300") References: <87msnyax53.fsf@parenthetic.dev> <87bk4cf9yx.fsf@parenthetic.dev> <877cf0f9sh.fsf@parenthetic.dev> <87plsowmck.fsf@parenthetic.dev> <86o7886ltv.fsf@gnu.org> Date: Thu, 11 Jul 2024 11:01:39 -0400 Message-ID: <878qy8nfak.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Nicholas Vollmer >> CC: Eli Zaretskii >> Date: Mon, 10 Jun 2024 16:53:47 -0400 >> >> Any thoughts here? > > I didn't yet have time to look into this, sorry. Feel free to close this. Patch has gone rotten on the vine. From unknown Sun Jun 22 07:59:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71404: 30.0.50; [WISHLIST] string-edit-mode should allow changing major mode Resent-From: Jeremy Bryant Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jul 2024 21:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71404 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: No Wayman Cc: Eli Zaretskii , 71404@debbugs.gnu.org, Nicholas Vollmer Received: via spool by 71404-submit@debbugs.gnu.org id=B71404.172176870929551 (code B ref 71404); Tue, 23 Jul 2024 21:06:01 +0000 Received: (at 71404) by debbugs.gnu.org; 23 Jul 2024 21:05:09 +0000 Received: from localhost ([127.0.0.1]:60807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWMh2-0007gZ-Jt for submit@debbugs.gnu.org; Tue, 23 Jul 2024 17:05:08 -0400 Received: from out-178.mta1.migadu.com ([95.215.58.178]:26324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWMgz-0007fx-Em for 71404@debbugs.gnu.org; Tue, 23 Jul 2024 17:05:07 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1721768694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dSR779hJnrZprOcmeBr6vIoImxogjaue/N8AXTVxwBE=; b=sROkwyhF26Z9Jhq3LOHgdIxIkWWL+DeMYR8SlnPT3aiyYeFxgrUrJwQxgxF9I6dkCMO/Br +boEqBVX6Zg5WFce7UXnNT7zVq+PkhGrR+NXWPJUdau+rGv8oG7XpLkbtGbe4Pb0hfa5ds 8ZBglmlRxNdU6XcimFQkAhVyrf6mDEdgJONyuxbJKVJgi79j+4noGq7bRVD4w0a4WNZeFD EhtL6o+kwR3ihuS3C48Z77/EeRdIJsD8azuXrEbj94M/8genBBVB8Y/xMJSBsxKCUYMSAc j7a9Bq7vl1l+SFJRnK35kXftdQAQs+07C1y8DTOTfcobcU1nwa0uMzmLReCe0A== From: Jeremy Bryant In-Reply-To: <878qy8nfak.fsf@gmail.com> (No Wayman's message of "Thu, 11 Jul 2024 11:01:39 -0400") References: <87msnyax53.fsf@parenthetic.dev> <87bk4cf9yx.fsf@parenthetic.dev> <877cf0f9sh.fsf@parenthetic.dev> <87plsowmck.fsf@parenthetic.dev> <86o7886ltv.fsf@gnu.org> <878qy8nfak.fsf@gmail.com> Date: Tue, 23 Jul 2024 22:04:52 +0100 Message-ID: <87zfq7akgb.fsf@jeremybryant.net> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) No Wayman writes: > Eli Zaretskii writes: > >>> From: Nicholas Vollmer >>> CC: Eli Zaretskii >>> Date: Mon, 10 Jun 2024 16:53:47 -0400 >>> Any thoughts here? >> >> I didn't yet have time to look into this, sorry. > > Feel free to close this. Patch has gone rotten on the vine. Please elaborate? From unknown Sun Jun 22 07:59:44 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nicholas Vollmer Subject: bug#71404: closed (Re: bug#71404: 30.0.50; [WISHLIST] string-edit-mode should allow changing major mode) Message-ID: References: <87msnyax53.fsf@parenthetic.dev> X-Gnu-PR-Message: they-closed 71404 X-Gnu-PR-Package: emacs Reply-To: 71404@debbugs.gnu.org Date: Sat, 01 Mar 2025 02:08:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1740794882-8680-1" This is a multi-part message in MIME format... ------------=_1740794882-8680-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #71404: 30.0.50; [WISHLIST] string-edit-mode should allow changing major mo= de which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 71404@debbugs.gnu.org. --=20 71404: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71404 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1740794882-8680-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 71404-done) by debbugs.gnu.org; 1 Mar 2025 02:07:46 +0000 Received: from localhost ([127.0.0.1]:55953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1toCGX-0002ES-Pw for submit@debbugs.gnu.org; Fri, 28 Feb 2025 21:07:46 -0500 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:53282) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1toCGU-0002Dq-NO for 71404-done@debbugs.gnu.org; Fri, 28 Feb 2025 21:07:43 -0500 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5deb956aa5eso3959184a12.2 for <71404-done@debbugs.gnu.org>; Fri, 28 Feb 2025 18:07:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740794857; x=1741399657; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=+RIRnu0w6KXo1vEmsISZhA/TtBOONjnRmRqByHBoNTM=; b=ar2/775cxa/cBKNVEfq1sQbLC0Wy1XiBRcpoqnyeNjEf1+h10hpv4xkMwGxUDzXNt/ tdH1MTK3VJ+iNAPRUt3+j8UVms81Cpjc9dZLEjWJt4LOaSDmpPDplvIjQVpfMKG5ykRG 8VAkg9ctd/8XvJVgIogtqInb0O0RYJgQnlOrsPDsGwmuucBu3KBbqk5a61VBrQl5Dbgl rF5j955m93pKp1MLt4xoJR4fPd3S7SviPibj07Q5zKfWPJke6fi2PtayJsIyUGrMxMXx iMXpbdEfL9mb0BwaFS4qGmfIbXTfQuMEApmg74jC2SkD4ctV1PD3PQHveuydFulW3hiH tn/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740794857; x=1741399657; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+RIRnu0w6KXo1vEmsISZhA/TtBOONjnRmRqByHBoNTM=; b=bi5ZdFEYjuNyX3gofGGWAZG+uJpqtmBPm3ZlT1AnOajnG221otyLSNcbOofoag5LsG lH9tf3xSM6h5jT9095mjC5wHsPntPt5L8dE8qxZIgLtEjGIzAToOl0dPX1QnU5vUQRyM gIk2P3rcCWThE3DYrt5KVBZaQjf66Eopj8fhgqScwzUjcJvEvLXYqSpVMot/wYkuSv5f 1Q0iIYqHSjYHpf4heR2BC8TghhxopWxCDG4rxzbVa4y+azVtZ2YXJcprgDnosw4O2QwY cQdq2dmDTyV0K1guoet7Q0IE9/obh6GTP+34IIHdMqoW351TiBuVBPGlCWE+q7Frp1b/ 7KZg== X-Forwarded-Encrypted: i=1; AJvYcCU3jx/xjtGor5AldMnfA3u/im3oITJ5HwnGPvl42qLFICTjuKiaHhlj1FENAW0r0hCdx3sIlwS9t9M8@debbugs.gnu.org X-Gm-Message-State: AOJu0YxMjzlcYTbIJxoTwwDc/QzeAyR/b1sTWQpQF67OyXCW95RI0RVn DHIGlBme0c5cQlie63Sck2ElIrwocQbsqXzeLOQDJku/ZjcB+nCF3tMom24TKubEfNcUAfB6oYv yDpXjeu5FTOsWOLPj1f9CnS4KdRE= X-Gm-Gg: ASbGncus+xL6p9MBK+d4SDT6uKB1NzMqbHY/QEWgKZMMtA6llKgiTO9jREc/l9W4bXG 25S2w5miRsIfQ/smHmVWmglNkEtVGoVT9oa94HbcPCMXGTkXk26Xvu4VYcrbEab5LaKhHXx6VjH Lq1e71+/HSo53ev8N1mAhryK5Z2D0= X-Google-Smtp-Source: AGHT+IHKALyJYPN4sccY5bTeLJ6ZZ8GUX07QsAiL6PqrpCICgLJpbrwhW6tJcxxKSk4N+2WRVugFT6jjreRmpVCLx/I= X-Received: by 2002:a05:6402:350e:b0:5e4:92ca:34d0 with SMTP id 4fb4d7f45d1cf-5e4d6b4bb17mr11095530a12.20.1740794856609; Fri, 28 Feb 2025 18:07:36 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 28 Feb 2025 18:07:36 -0800 From: Stefan Kangas In-Reply-To: <87zfq7akgb.fsf@jeremybryant.net> References: <87msnyax53.fsf@parenthetic.dev> <87bk4cf9yx.fsf@parenthetic.dev> <877cf0f9sh.fsf@parenthetic.dev> <87plsowmck.fsf@parenthetic.dev> <86o7886ltv.fsf@gnu.org> <878qy8nfak.fsf@gmail.com> <87zfq7akgb.fsf@jeremybryant.net> MIME-Version: 1.0 Date: Fri, 28 Feb 2025 18:07:36 -0800 X-Gm-Features: AQ5f1JrdpNLkAGixXocljBWnRjAFuXaU_CyJ6K-oDpSouA8YBwjHNqxlKc56ep4 Message-ID: Subject: Re: bug#71404: 30.0.50; [WISHLIST] string-edit-mode should allow changing major mode To: Jeremy Bryant Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 71404-done Cc: Eli Zaretskii , Nicholas Vollmer , No Wayman , 71404-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Jeremy Bryant writes: > No Wayman writes: > >> Eli Zaretskii writes: >> >>>> From: Nicholas Vollmer >>>> CC: Eli Zaretskii >>>> Date: Mon, 10 Jun 2024 16:53:47 -0400 >>>> Any thoughts here? >>> >>> I didn't yet have time to look into this, sorry. >> > > > >> Feel free to close this. Patch has gone rotten on the vine. > > Please elaborate? No further comments within 6 months. I'm therefore closing this bug report. ------------=_1740794882-8680-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Jun 2024 03:50:38 +0000 Received: from localhost ([127.0.0.1]:41984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFQcf-0000kv-GB for submit@debbugs.gnu.org; Thu, 06 Jun 2024 23:50:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:44714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFFO7-0002fX-U0 for submit@debbugs.gnu.org; Thu, 06 Jun 2024 11:50:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFFNs-0000Xk-Uz for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 11:50:36 -0400 Received: from out-14.pe-a.jellyfish.systems ([198.54.127.78]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sFFNq-0008M9-UB for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 11:50:36 -0400 Received: from output-router-d5c465c44-d7pgd (new-01-3.privateemail.com [66.29.159.56]) by pe-a.jellyfish.systems (Postfix) with ESMTPA id 4Vw81D0BZFz9s9T for ; Thu, 6 Jun 2024 15:50:24 +0000 (UTC) Received: from MTA-06.privateemail.com (unknown [10.50.14.16]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by NEW-01-3.privateemail.com (Postfix) with ESMTPS id F21CC100588A for ; Thu, 6 Jun 2024 11:50:23 -0400 (EDT) Received: from mta-06.privateemail.com (localhost [127.0.0.1]) by mta-06.privateemail.com (Postfix) with ESMTP id C9F77180295B for ; Thu, 6 Jun 2024 11:50:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=parenthetic.dev; s=default; t=1717689023; bh=4Egc28zKM2Mqp5Qkur4jS3ZfOpNDYtGxcToGsL5VuGg=; h=From:To:Subject:Date:From; b=N1DKfaFupa4S7OzLo97BHl7sGlq+KVlD3V+oQLrMPj44V4b1PtCbFMyDTch9hpsO8 g5dApO2J1/LvVI7ZQ4dv6vTqTo5bOzfyhFFM4u9zf/LYB0XYJ9j3B+/Xak3vgxqJPS XGN2XpIdWasbi80kNouYQql5qjBtAm+LN1tceOnB1874zjkHAqnDoErCpmcu/rvoMA hpaH1syMDUgX8Cvj0CCofDbnJyOU0r9Xna9AsPsnhPSck2b7PjnK6PG4eDDba1sMC5 D54gvjlnVrNmfAobQSEP33E23QlNf0YwWhRNv4Cr7z1KYMgid03vqs270jdH6oDeY+ l3BnULgSCNOkQ== Received: from laptop (c-174-166-84-198.hsd1.nj.comcast.net [174.166.84.198]) by mta-06.privateemail.com (Postfix) with ESMTPA for ; Thu, 6 Jun 2024 11:50:23 -0400 (EDT) From: Nicholas Vollmer To: bug-gnu-emacs@gnu.org Subject: 30.0.50; [WISHLIST] string-edit-mode should allow changing major mode X-Debbugs-Cc: Date: Thu, 06 Jun 2024 11:50:16 -0400 Message-ID: <87msnyax53.fsf@parenthetic.dev> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Virus-Scanned: ClamAV using ClamSMTP Received-SPF: pass client-ip=198.54.127.78; envelope-from=nv@parenthetic.dev; helo=out-14.pe-a.jellyfish.systems X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 06 Jun 2024 23:50:36 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) string-edit-mode is a nice feature to have built in. It would be nice if one could change the major mode of the editing buffer while preserving the edit/abort functionality and any buffer state necessary to make those function. Any reason it couldn't be implemented as a minor mode? ------------=_1740794882-8680-1--