From unknown Fri Sep 05 14:42:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#71396 <71396@debbugs.gnu.org> To: bug#71396 <71396@debbugs.gnu.org> Subject: Status: [PATCH 0/2] gnu: solaar: Update to 1.1.13. Reply-To: bug#71396 <71396@debbugs.gnu.org> Date: Fri, 05 Sep 2025 21:42:28 +0000 retitle 71396 [PATCH 0/2] gnu: solaar: Update to 1.1.13. reassign 71396 guix-patches submitter 71396 gemmaro severity 71396 normal tag 71396 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 06 08:25:33 2024 Received: (at submit) by debbugs.gnu.org; 6 Jun 2024 12:25:33 +0000 Received: from localhost ([127.0.0.1]:52630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFCBR-0007yn-AD for submit@debbugs.gnu.org; Thu, 06 Jun 2024 08:25:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:53084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFCBO-0007yf-FU for submit@debbugs.gnu.org; Thu, 06 Jun 2024 08:25:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFCB9-0005EB-Ia for guix-patches@gnu.org; Thu, 06 Jun 2024 08:25:15 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sFCB7-0007Wb-Tq for guix-patches@gnu.org; Thu, 06 Jun 2024 08:25:15 -0400 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1f6a837e9a3so6312875ad.1 for ; Thu, 06 Jun 2024 05:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717676712; x=1718281512; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9a3FR/tBHHGkUF5BkFJAv/BAHDs8MSITsEU3EwM8nag=; b=WfB4tuKTiwmXxcOtRwIIfJIVrllp001T59qDj1zd014myUF086hA0Mox9ipEQgNf33 +dO3dUWBNha6dh84qimAK+0o2Po4R7BAuKgObHSERRH/sIo1UhBL1sql1sGToiNleCBA OJmrvCT02sNeo6jdsB5We7MTpa+K7jtD4mQjg9uiMFTmSpt/9Jjkh8fqWCqCOgkFuDGP SY/cmDg4vfhgk5dm2wqhu0NVVNvKIazaaG3nzRzDUmyvXeerC0ZGjGcio2RH8q+2gPAA GvxKg1VY3JUTYQUiG6gHLY4Iy8hBXOiAWAkDb4W5C4ujGmR6XHHdxeqJqXFL/M1MO+zK h13A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717676712; x=1718281512; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9a3FR/tBHHGkUF5BkFJAv/BAHDs8MSITsEU3EwM8nag=; b=hKociXOyfGeRi9PoX/QZZyJcr/NAkJc0Y3aokHniAWOIqkXAdXYcRFjai71lJunoFs TX+5EBUuFpNnJ2Iju+u/TY3QL72/AA5SMerQNTB7ca/XamtehdCaOaEA0eXXu7earUKD fvZAfrdWmOoP/+7arFSAPM386OJTCg4wnnkYj4x9BURlZSF0bXwWdcs59dEhCmBONF8X KXBrSC7l4YsGUBSpp7w0ZSgekTI+mGodP4yPZBV5Z+auY5+uMVFva+4y1RE+/hR/kGeA tHeRzo9yi0G+awgN6bdmyucm2ZljpbfxCCgQEybuP5I6/+1Z4R2TXIW8hdImQvTevnWh 35uQ== X-Gm-Message-State: AOJu0YzqAX2uuzEj6kIjgWzyHBnOeQeEmBDa3Z3lvZOqqa2muXOHjQzp zD5q/MZ5zBJUO+39V8We74yacprFroVfdRTo1EQK4ZR4YJ9O9aYWFHYR6amw X-Google-Smtp-Source: AGHT+IFgiDGlLGdFR1rFzVgnhV0e0UKpa/4ghH2DJA4NAgHlVCaAAJkOMWwwAhqGSRYuiFSm9UUFlQ== X-Received: by 2002:a17:903:183:b0:1f6:5795:fb7 with SMTP id d9443c01a7336-1f6a5a6be3amr62632205ad.53.1717676712341; Thu, 06 Jun 2024 05:25:12 -0700 (PDT) Received: from mac.gemmaro.name ([240f:74:d1f0:1:1883:f3d1:907f:a2e3]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6bd7ccd30sm13519755ad.138.2024.06.06.05.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 05:25:11 -0700 (PDT) From: gemmaro To: guix-patches@gnu.org Subject: [PATCH 0/2] gnu: solaar: Update to 1.1.13. Date: Thu, 6 Jun 2024 21:24:57 +0900 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=gemmaro.dev@gmail.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: gemmaro X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello, This updates the solaar to 1.1.13. It also uses the newer package style for the arguments. Regards, gemmaro. gemmaro (2): gnu: solaar: Update to 1.1.13. gnu: solaar: Use newer package style. gnu/packages/admin.scm | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) base-commit: 4ae4311b31f1687714a01196a20bdc8b5c2a5843 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 06 08:42:27 2024 Received: (at 71396) by debbugs.gnu.org; 6 Jun 2024 12:42:27 +0000 Received: from localhost ([127.0.0.1]:52665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFCRm-0002mS-Ti for submit@debbugs.gnu.org; Thu, 06 Jun 2024 08:42:27 -0400 Received: from mail-pj1-f53.google.com ([209.85.216.53]:51330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFCRk-0002m7-3o for 71396@debbugs.gnu.org; Thu, 06 Jun 2024 08:42:25 -0400 Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2c2200dbdf7so814371a91.2 for <71396@debbugs.gnu.org>; Thu, 06 Jun 2024 05:42:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717677664; x=1718282464; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AU9arWPgyY6FDBdIgcwNoO08JSH78A5KaOHQtPXkoqk=; b=aAoY0TA26f3fWFW/KuJYchBmvA+72/SK2GjhJzV7zaqAF40GPgDyIkyVQ9Ab/L8yKg rUtKbrCPpAA5JlFlFFcAA+ePejN4TFcKCih8Fe8KPAEyXF2tNpSEW9BkuUkOcOxjy/gv /viblja0FN6o/x2YhZYYA2727BGq+PLoDMFqla0y3HPvtHx+01jJ7HR1aoMyIBFbvu4d VxjQ75ALXDRXstfqWxirG9V5rPr9xu3EyGwqv7jOw3bz7ZU59Bw+bHSC8e3W3wayC3kh D6FRQJqhbfTCOtLoV0sg9mknjTv976vD75s0Dow4TUccEHETI53HL3YpCl41dPHbVWGr EfCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717677664; x=1718282464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AU9arWPgyY6FDBdIgcwNoO08JSH78A5KaOHQtPXkoqk=; b=K/ZcnWppvn5XB1YBAQ6fudILxH8iDmg294KjZ7NYEzD3swVZ79HIdDWQKWTs1MUokh 9bfa6pqpt63dQ/Mz2K+KktT1isWlKhifKINCpaGLu17dbk+gRrJisWfR1wQMZcD9PfKT DhJQOzoQ5MoIGas42aglSv5W3Oy/FwEKR8z2jTTkAJZ1vvY9jtaGno3T2Rcto1MW32NM Osr751PhUTyva12Bas5QuzEZhlG/vnYLzztDqN2J1X8kmb01pcXpkcKjswD4CQwlrF5M KvFXCbztjcE6E1iBBMoIck60Bwg16ird9GGtWEDqbbqYdo7UaGY8BZe3fivt///A6q1M 4roA== X-Gm-Message-State: AOJu0YyoNP67Gz2Rgr2REW+PrID+QReHh/jQzGQ19E4NZWpwqRQ7FMhw UMRLtVGhqeXjtJ+lksZz8XoYS7AC8OHISHVPJtMScP3HGuIGhHYP+r6ub5+f X-Google-Smtp-Source: AGHT+IEqNNXNt/8/MwKqNvIGShNkeBiX1ASFc9Tv82E5agycJ8eeHPHnVcF5DqrDP4Vwf9pJXV2Lrg== X-Received: by 2002:a17:90b:908:b0:2bd:dc20:a2a0 with SMTP id 98e67ed59e1d1-2c27db684c5mr5138969a91.40.1717677663492; Thu, 06 Jun 2024 05:41:03 -0700 (PDT) Received: from mac.gemmaro.name ([240f:74:d1f0:1:1883:f3d1:907f:a2e3]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c2806d18ecsm3386542a91.52.2024.06.06.05.41.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 05:41:03 -0700 (PDT) From: gemmaro To: 71396@debbugs.gnu.org Subject: [PATCH 1/2] gnu: solaar: Update to 1.1.13. Date: Thu, 6 Jun 2024 21:40:50 +0900 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71396 Cc: gemmaro X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/admin.scm (solaar): Update to 1.1.13. [native-inputs]: Add python-pytest. [propagated-inputs]: Add python-dbus-python and python-evdev. Change-Id: I616c89ba50a0e8300c08856a96959eec7d274635 --- gnu/packages/admin.scm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index c730d43819..212c2b3715 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -65,6 +65,7 @@ ;;; Copyright © 2023 Nicolas Graves ;;; Copyright © 2023 Tomás Ortín Fernández ;;; Copyright © 2024 dan +;;; Copyright © 2024 gemmaro ;;; ;;; This file is part of GNU Guix. ;;; @@ -4719,7 +4720,7 @@ (define-public vmtouch (define-public solaar (package (name "solaar") - (version "1.0.7") + (version "1.1.13") (source (origin (method git-fetch) (uri (git-reference @@ -4728,7 +4729,7 @@ (define-public solaar (file-name (git-file-name name version)) (sha256 (base32 - "0k7mjdfvf28fay50b2hs2z4qk6s23h71wvl8777idlrz5i5f43j5")))) + "1fz3qgjx3ygr4clgh7iryxgvvjy510rgy8ixr2xld2wr0xa6p0mi")))) (build-system python-build-system) (arguments `(#:phases @@ -4736,9 +4737,12 @@ (define-public solaar (add-before 'build 'setenv-PATH (lambda _ (setenv "PYTHONPATH" "lib")))))) + (native-inputs (list python-pytest)) (propagated-inputs (list python-pygobject python-pyudev + python-dbus-python + python-evdev ;; For GUI. python-pyyaml python-psutil -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 06 08:42:28 2024 Received: (at 71396) by debbugs.gnu.org; 6 Jun 2024 12:42:28 +0000 Received: from localhost ([127.0.0.1]:52667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFCRo-0002ma-Bp for submit@debbugs.gnu.org; Thu, 06 Jun 2024 08:42:28 -0400 Received: from mail-pf1-f171.google.com ([209.85.210.171]:52333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFCRm-0002mA-4W for 71396@debbugs.gnu.org; Thu, 06 Jun 2024 08:42:26 -0400 Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-702621d8725so1020711b3a.0 for <71396@debbugs.gnu.org>; Thu, 06 Jun 2024 05:42:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717677665; x=1718282465; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mxvrcqIYVOFrwIM0qaTY7110dF1pmULzJ4j1Aoobwq4=; b=YpNXMfpmpfxShSk90JTBjylagv3Qw07S79/KMgJXWsliDt+4HMLewXOwCcKKd4XFEt uC0UI/E8v4YRhys/NHTTUnoF+oWO9inKAC4R3v//w/nsp/RP5ZRu/E62H3Tt6UTCdL5W fXQJLfJgp0U4vNeh3J6HCFgE25qMG4RFIDmrsQZ+WeGNzE4bNFXWvoKD01cyj2NyNEkp v1a/H9c1Zu8U4xF4C+J/Yneup4UM6/4wpMjYp/aOrsF48mqCKV++oGFh/jSnrui545PL HX83qxY1qbpfFzcQXbrNJ19PBh15mziiuqvIBKytb7hcYH63LcY5+n8is/DZu3XYgEu2 x50g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717677665; x=1718282465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mxvrcqIYVOFrwIM0qaTY7110dF1pmULzJ4j1Aoobwq4=; b=K4asKFieJUErszuaov7+xcihUgIZ0Ak/K0z1As7jaPDWXGn28E8KGOoeUVWqGgsQ25 vmKiJoGGMEatGZO/TzHjeXBR+YAuNOrb8uGBFwbJdFFY6IPhJEntDjplzorjCfJw6zZh X9VggC2xRdmRT1PUHytzz29lNkEdoGVo6jzvEZaR1fA573WH8YOPor8z7FqZwhnTnytb duVPyEFa9kL/BriyhagQlV+iXEjQg9ViWOZIO1qV7Afy0g1abR0NtzM0ZXO2/bnqZitG qEQ+I7KpfurtoAzxqd19UAR14Gu3Ud/LE9+RgHomqhWUkJC5ST1T/7LbsybS88Vy/CJ7 /Ihg== X-Gm-Message-State: AOJu0YyuVE58qvZOB3bmnYb3COKTYIyZWdiHWOtO2QTZ2se64KV08aT+ dOpR7OMIi0TbaQkspgI2hd3V6P49rAOm1ilcrMIbTE7QdV4pygLD/mu4Z8LR X-Google-Smtp-Source: AGHT+IHsohhZ7Pus+rD8OVfpuDu28jBcRqYeDgdkpoGtZjmytvypkn0B8vBQ0yd094KkkMKmeBl4+A== X-Received: by 2002:a05:6a20:3caa:b0:1af:5195:d035 with SMTP id adf61e73a8af0-1b2b713c810mr6401109637.45.1717677665407; Thu, 06 Jun 2024 05:41:05 -0700 (PDT) Received: from mac.gemmaro.name ([240f:74:d1f0:1:1883:f3d1:907f:a2e3]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c2806d18ecsm3386542a91.52.2024.06.06.05.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 05:41:04 -0700 (PDT) From: gemmaro To: 71396@debbugs.gnu.org Subject: [PATCH 2/2] gnu: solaar: Use newer package style. Date: Thu, 6 Jun 2024 21:40:51 +0900 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71396 Cc: gemmaro X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/admin.scm (solaar)[arguments]: Use newer package style. Change-Id: I9bec91e379bed709228eb2fe809205ba5a5b377f --- gnu/packages/admin.scm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index 212c2b3715..c1b265cf96 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -4732,11 +4732,11 @@ (define-public solaar "1fz3qgjx3ygr4clgh7iryxgvvjy510rgy8ixr2xld2wr0xa6p0mi")))) (build-system python-build-system) (arguments - `(#:phases - (modify-phases %standard-phases - (add-before 'build 'setenv-PATH - (lambda _ - (setenv "PYTHONPATH" "lib")))))) + (list #:phases + #~(modify-phases %standard-phases + (add-before 'build 'setenv-PATH + (lambda _ + (setenv "PYTHONPATH" "lib")))))) (native-inputs (list python-pytest)) (propagated-inputs (list python-pygobject -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 05:59:56 2024 Received: (at 71396-done) by debbugs.gnu.org; 10 Jun 2024 09:59:56 +0000 Received: from localhost ([127.0.0.1]:50895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGboh-0007so-S9 for submit@debbugs.gnu.org; Mon, 10 Jun 2024 05:59:56 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:42864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGbof-0007sJ-Jh for 71396-done@debbugs.gnu.org; Mon, 10 Jun 2024 05:59:54 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 3E6023B3; Mon, 10 Jun 2024 11:59:01 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qxqYw2O_j6Pt; Mon, 10 Jun 2024 11:59:00 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id B1F99288; Mon, 10 Jun 2024 11:59:00 +0200 (CEST) Date: Mon, 10 Jun 2024 11:58:59 +0200 From: Andreas Enge To: 71396-done@debbugs.gnu.org Subject: Close Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71396-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, thanks for the update! I have applied the first patch. Concerning the second patch, we do not need a gexp; they are similar to quoting and unquoting and needed to stage code execution (from the package definition to the build). Here everything is done at package definition time. #~ is some kind of (quasi-)quoting, but there is no corresponding unquoting #$ or #+ in the following block. (Actually, to make this even clearer, one could replace ` by '; but this would not warrant a commit.) Andreas From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 06:16:29 2024 Received: (at 71396) by debbugs.gnu.org; 10 Jun 2024 10:16:30 +0000 Received: from localhost ([127.0.0.1]:52047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGc4j-0000Hp-BT for submit@debbugs.gnu.org; Mon, 10 Jun 2024 06:16:29 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGc4f-0000HN-6O for 71396@debbugs.gnu.org; Mon, 10 Jun 2024 06:16:27 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 8111127BBE2; Mon, 10 Jun 2024 11:07:12 +0100 (BST) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id e7fc706c; Mon, 10 Jun 2024 10:07:11 +0000 (UTC) From: Christopher Baines To: 71396@debbugs.gnu.org Subject: Re: bug#71396: Close In-Reply-To: (Andreas Enge's message of "Mon, 10 Jun 2024 11:58:59 +0200") References: User-Agent: mu4e 1.12.4; emacs 29.3 Date: Mon, 10 Jun 2024 11:07:11 +0100 Message-ID: <87wmmxyuuo.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71396 Cc: andreas@enge.fr, gemmaro.dev@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Andreas Enge writes: > Concerning the second patch, we do not need a gexp; they are similar to > quoting and unquoting and needed to stage code execution (from the package > definition to the build). Here everything is done at package definition > time. #~ is some kind of (quasi-)quoting, but there is no corresponding > unquoting #$ or #+ in the following block. (Actually, to make this even > clearer, one could replace ` by '; but this would not warrant a commit.) Note that quoting vs gexps matters for package inheritance, so even though there's no ungexp'ing happening in this pacakge, the phases could be ungexp'ed by a package that inherits from solaar. For this reason, I think it's important to move to using gexp's for all phases, even the trivial ones, so that there are less issues when it comes to package inheritance and modifying phases. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmZm0E9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcVuQ/7Byj9iKLWThQgVk9J0+tZKZGdcqiTrGmu nklIhxody1b0Z5y6zjsnz3g6YzWnh+VsVnUc/OBWU0zPqdONaFTdpaW3W1O9lHL+ KIrbwO9+8Ywy1j+g5YguGxJVMfLmKlbOxC3n3RoPVOtYa32EPIu63zMCdf/F7cNZ QVXwjDAYB+cBVSDRN/zuoSL9A0q/4XedE9d/vXg8D8VmsAmpY4Y6hDVzVcqU0c3M cFRuYQktOhpcCAixVbtGYCzRnRs2Uxsm4zUBDEnPQIgcgpEXpqJhv3wo3m3LOT1D Mx+MISYKgsHspOB7BQTv9POvjl8X1rgT9izo/QMsi55KTYjG5QIq0MyVZliYoPUo tZXrkdXihhtS+hF8cenB8C8ejSHpv1rM2d9sH7iwUjk+0y9B+wBpKhxW6Pk70xys q35kHT8OlyM89o3SY/59hlZp8K1FTldwu13nYrzFf6lolU1LKLICPPNV9UTXhfCh rb9IImeED/vwGRCDSiC7vWxc930kntblpNw/zlH4Vygq1jzx7Q6GQGPlVAHLdDQy 8ZOoRg90qwCbAqppgp8EqVMnDbAs0Zh41J+Vp7SC/DRD3bNhrR4iRyeuxZqi4A0b MzhYMsTWX1xgZgNJs/p4WrNBTMdAtZwKc9K61ONCbG/OIEeGt//6fm6bZfifl8u/ QmZKVh/HSBY= =yMld -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 06:22:07 2024 Received: (at 71396) by debbugs.gnu.org; 10 Jun 2024 10:22:08 +0000 Received: from localhost ([127.0.0.1]:52411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGcAB-0000ZI-It for submit@debbugs.gnu.org; Mon, 10 Jun 2024 06:22:07 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:40778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGcA9-0000YW-Ox for 71396@debbugs.gnu.org; Mon, 10 Jun 2024 06:22:06 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 49DEF2B6; Mon, 10 Jun 2024 12:21:13 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9M4-0XCchwWl; Mon, 10 Jun 2024 12:21:12 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 9E5512D2; Mon, 10 Jun 2024 12:21:12 +0200 (CEST) Date: Mon, 10 Jun 2024 12:21:11 +0200 From: Andreas Enge To: Christopher Baines Subject: Re: bug#71396: Close Message-ID: References: <87wmmxyuuo.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wmmxyuuo.fsf@cbaines.net> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71396 Cc: gemmaro.dev@gmail.com, 71396@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Mon, Jun 10, 2024 at 11:07:11AM +0100 schrieb Christopher Baines: > Note that quoting vs gexps matters for package inheritance, so even > though there's no ungexp'ing happening in this pacakge, the phases could > be ungexp'ed by a package that inherits from solaar. > For this reason, I think it's important to move to using gexp's for all > phases, even the trivial ones, so that there are less issues when it > comes to package inheritance and modifying phases. Good point, although most packages do not lead to inheritance; but when they do, this issue becomes difficult to debug. Feel free to push the second patch if you want to. Andreas From unknown Fri Sep 05 14:42:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 08 Jul 2024 11:24:15 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator