GNU bug report logs - #71386
29.1; Frame is auto-deleted even when it has multiple tabs

Previous Next

Full log

View this message in rfc822 format

From: Ship Mints <shipmints <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: martin rudalics <rudalics <at> gmx.at>, Eli Zaretskii <eliz <at> gnu.org>, abdo.haji.ali <at> gmail.com, 71386 <at> debbugs.gnu.org
Subject: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs
Date: Tue, 1 Apr 2025 16:13:08 -0400

[Message part 1 (text/plain, inline)]

On Tue, Apr 1, 2025 at 3:07 PM Ship Mints <shipmints <at> gmail.com> wrote:

> On Tue, Apr 1, 2025 at 2:44 PM Juri Linkov <juri <at> linkov.net> wrote:
>
>> > WIP patch attached with a test and some few refinements we've talked
>> about
>> > in this dialog.  I didn't alter tab-bar-mode to tab-bar-lines as Martin
>> > suggested.  You're the expert.
>>
>> We don't need a new unusable option, so please remove it and submit a new
>> patch.
>> Also please replace tab-bar-mode with tab-bar-lines like Martin suggested.
>> Then everything should be good.  Also it seems you forgot to remove
>> window-dedicated-p in your previous patch.
>>
>
> I'll work on that now.  I'll remove
> 'window-delete-active-tabs-inhibit-delete-frame'.  'window-dedicated-p'
> condition now gone.
>
> Are you sure you don't want this to support the case where tab-bar-mode is
> active and tabs merely aren't visible?
>

There's also 'tab-bar--tab-bar-lines-for-frame' if you think that's more
appropriate.

All tests pass unless I set tab-bar-show nil, and I still think this patch
should work even if the tab-bar is hidden, but tab-bar-mode is enabled.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.