GNU bug report logs - #71386
29.1; Frame is auto-deleted even when it has multiple tabs

Previous Next

Full log

View this message in rfc822 format

From: martin rudalics <rudalics <at> gmx.at>
To: Ship Mints <shipmints <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, abdo.haji.ali <at> gmail.com, 71386 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs
Date: Mon, 31 Mar 2025 17:09:13 +0200

> Below with -Q reproduces the effect.
>
> (setq kill-buffer-quit-windows nil)
> (tab-bar-mode)
> (select-frame-set-input-focus (make-frame))
> (switch-to-buffer "FOO")
> (tab-bar-new-tab)
> (switch-to-buffer "BAR")
> ;; these emulate the effect I see
> (set-window-prev-buffers nil nil)
> (setq switch-to-prev-buffer-skip #'always)

The last two boil down to saying that the selected window is dedicated
to its buffer.

> (kill-buffer) ; frame is deleted when I expect the first tab to remain
> intact
>
> If the patch removes the test for window-dedicated-p, it leaves the first
> tab in place.  I almost never use dedicated windows outside of a few
> packages that do but those haven't been in play vis-a-vis this issue.  I
> don't pretend to fully understand what situation w-d-p is intended to deal
> with but if we can accommodate both, that'd be fine.
>
>       ((and tab-bar-mode

(> (frame-parameter frame 'tab-bar-lines) 0) is more reliable.

>             ;; Fall back to frame handling in case of less than 2 tabs
>             (> (length (funcall tab-bar-tabs-function frame)) 1)
>             ;; Close the tab with the initial window (bug#59862)
>             (or (eq (nth 1 (window-parameter window 'quit-restore)) 'tab)
>                 ;; or with the dedicated window (bug#71386)
>                 (and ;; (window-dedicated-p window) ; <==== THIS WORKS BETTER

I'd rather make this subject to an option say
'tab-bar-open-tab-inhibits-delete-frame'.

>                      (frame-root-window-p window)))
>             ;; Don't close the tab if more windows were created explicitly
>             (< (seq-count (lambda (w)
>                             (memq (car (window-parameter w 'quit-restore))
>                                   '(window tab frame same)))
>                           (window-list-1 nil 'nomini))
>                2)
>             )
>        'tab)

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.