From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 05 09:16:43 2024 Received: (at submit) by debbugs.gnu.org; 5 Jun 2024 13:16:43 +0000 Received: from localhost ([127.0.0.1]:33061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEqVO-0005ry-IF for submit@debbugs.gnu.org; Wed, 05 Jun 2024 09:16:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:56844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEqVM-0005rp-UZ for submit@debbugs.gnu.org; Wed, 05 Jun 2024 09:16:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEqV7-0002rd-Si for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 09:16:26 -0400 Received: from ns1.lmf.cnrs.fr ([195.220.198.153] helo=mx.lmf.cnrs.fr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEqV3-0006eL-SL for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 09:16:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lmf.cnrs.fr; s=mail; t=1717593377; bh=XLL0iyO6ySEjE1BENbiUo34p2z9rWm59ES1EYQlGkuA=; h=Date:To:From:Subject:From; b=CF7Az1hYta0oIQ5T6Yhle+0wELCe43yQHUptxN0uVaurKQ//OAvqL00eSriExih6w 3n1uKNxfnk10GR7yOH2hoDBck1s6nnNVZWMulGpXjrIMa3yG91bQwZS1TASk/V298Z 83dbx0jry8I5GdVkUNgqvD9LGcm9blfZUKtcY5eqsJ2X6nX0CnEOQXOECBGGkG9XK9 +41ocZP5JD/Z5pgcK3jEV5GmsdHYgJBlLOlwzu8Al+K5Pltisgc4MzGahfogJl1fzk oHsffLoemt3zusCwuCDJ6+RcsVekfufxJ4YBsK8UbCccaPnIqtV/t18SigYMqi37kd SiVEn5Ppt6eTQ== Received: from authenticated-user (mx.lmf.cnrs.fr [195.220.198.153]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx.lmf.cnrs.fr (Postfix) with ESMTPSA id 140113F0FB; Wed, 5 Jun 2024 15:16:17 +0200 (CEST) Message-ID: Date: Wed, 5 Jun 2024 15:16:16 +0200 MIME-Version: 1.0 Content-Language: fr To: bug-gnu-emacs@gnu.org From: Philippe Schnoebelen Autocrypt: addr=phs@lmf.cnrs.fr; keydata= xsFNBGUULdoBEACzW6FKHcnl6PzE8zIRx8xxCc/46ux/2C/qT1oLbpLJ9nBgBwrKyxUyma37 b/znzwtTYBzEe7chMp/9bBciPG6fdone/hMkMULLEx+Lq1KwsjtlogZs8nCT0b9GBxlzfB9b tHJL1Sn6AuNdFWFS6PKvAeYK/d+oTaKRfyctXzlkuRZv9L3FM0IoNp0Ihn0++oRgei3WoT7z EavBlvyrcVQOTu6Gj5lM7IYqOrnXbGp77djCS8JpGHZFdhdsQEMTYg+bViaXq9uMyN9MO+8T +IBulqd6VmDzmfsy02XNpZbqZ/GXwzYx40NcHvHvb1etp4XgU3WkSYajGszVI0iVtpruQM0P njPq4JYf506FtmmezPgiA1DPrz/Rqdhp0k3cIKDSk22kHinak8L7vtJ9JfecNq1Yws9xAyJX 4yy2gqP0ow5ZU7muhkGUnXQaUBgT5oi7UBIz3xDCHrzyn8sBVmZtsMUgajz0KE+KW66YeP4K fALQdfIFPjaQ4PWEtmqtm4e6Wt68eVXM3Pbup+1ncxvzZuFmcboNBHExJEtplQCqLbILa4XQ YEW+Z6dFCkk5jzXKUCkSSkIYU9T9n021qG1PKtAdVZAqic/7wSU3rTVb6DgukGaMPZ3tlCpN weBtF91NHRrGGDA5S3zumBmJ6iZupFcNkKEUSNOb2ZIok0/tEQARAQABzSZQaGlsaXBwZSBT Y2hub2ViZWxlbiA8cGhzQGxtZi5jbnJzLmZyPsLBjgQTAQgAOBYhBPNWbzsPpdbApuomRnyz pHZG5tVbBQJlFC3aAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHyzpHZG5tVbH7UQ AKQNEitqm5V4pB0iWQEtN/1JGDLAyWs0G6s4dmQEq1Kg96PRafgeapJRWj32XOZDDUYvtlXQ 97BMPzzc2ujYPQMGceOAYUH+qnvtZM6ZHCzxLkBV2/kfjMPeN7eqdRs1GhHXIu7t2oapcIW5 FRV9sr8wtTyHJf+Jnvur0k6HUh1NEjA5ZAlhjgMiyK4QpQegQq4ZUYXRxMDcTtGgnLgAEHW9 bsOnUwPZH1K9Ao6jQu+q4ZSyRViXJTZdUlNLrXqRywFgr2mj4/9ieYFVRW8VKf0V4TNGksiY jGWa/PGKhNGp0rRJwptIFkmjKzcNnmdVrNM3Bh9nDY82Ye1nSWMB6CcK09l9GnV+a4gRFc4g Rvj8ixVuBuoqOC0zgCZx50LkudwslQCU9L2pSAL2hU+6y9xpu5GxH2a1kD7osfSUmgmKytSE Pc7PLZcfTWzz9uP4LGsWKceNDtGFFC1jlzHxtsy2lkDjuNBcFKWVAyAqijn5HQKRRXlCR76f i86yK/CoQxQ1m96Qw/Sm1DoTQX6DZqjVc0GF9dna5B1kis9t9S9WjncOfMJtrf40AvMegvEJ WPQA0oO0lAUHGfDA0wRy9XUALJU1l/p4Laih3dSc79mOq/FmK8XPpVOfHOPx9X+Szfq+TSpy x64cRR5XYh1Ec460FS+eQKAC7JOcDHkxjXC6zsFNBGUULdoBEACn3MVYrfhdaZ5hIT9359k9 tutM67sCe4OJRP4GoSbLebAX4ng/AtJdJcyKD4enquTz2XZS7yhlGD+FP2pE46Nsg2gxOcI9 cPzqwGz0sFNqiZOj/HueoZQzcFpvL38RH+4/dGF/p/DWQlZNDhuLtH2HC/YJB/EgtNTF9sjT 93Aq6JDkrxyhj2OkQx1cpXTBnxMdnlbt08wzR71G+6F7x84IwjumwfngThgDWE9NR0rjzOX2 rOIfsUJ2/2NXA0xx5gpSIqlvNrsduvR0hQ+Wx4x6AYB5xjOASDUf9BKVQi2p2Sffhrfc0CDG Wv0gWnnNsSdtjUn3a8ylS5690/U+z+LRsnJKcw1pp6/9T68jZeauc8xDGmNznO2CeRnN6KMg rNx+HY8Yyw7hC33/MFUdWqhCd6oJ6zqHac+1hpizjD09Af7hZN3NPuFYidcqCzbvlCnmuSUJ VD98+DK5QPfnK8hwOC1gQrFyBItkNL6lOdu6rR0yWq7WBzAewZ4Gol05Rzgl8vbGGGMhzKbh CUda22CJ+mkmQbOuVfZIe3k0VL7m4h5/I2dUIhT42uLdn14eH2ZAWEf01/lXMhdwT+/sbl28 +SR0KtCYc/7QRgVpiJb2rYOXfF/8L4XdLq93Wjq2nj9rYFJHVetDu3PkN+SWi5X/t7iJKYa4 brztlzs1CMlvsQARAQABwsF2BBgBCAAgFiEE81ZvOw+l1sCm6iZGfLOkdkbm1VsFAmUULdoC GwwACgkQfLOkdkbm1VuAxhAApTB5tMvp/ogBJyo3nbqoiyi/2Kn2m0Himbbg6AjK29o5hTTa S45xmYm7tckZHU9uKz9togzyoj4NfKmPH23lzzzgAh2hTYGLGNVayrhMaiS0EZ/xOtQbC+MH caRCag8mj2mmeAwGEMSntAHz3V9mzGtq0lMwHbFb2JFGF1ObkDd0ORtpzWlmwoD/WDy5hCqK 9iSfxvOUOGtmTeN+AcQUE0RsaFg5XXEt2nZhzUr16/n8tyC5YxFA7fHcjOW09D6v0DzstAMq N5YP+AYyA5AT/CtEawN4IS7O6u46acd/UoaTu6IKINqhwIECu9ke/wJ58kUioAH782wuWV1U BmbHquYJyKheWyd8Dgrns/AvGKGBjACwWGOgVfYyOzFLt3d+MewTP8h9yxsJQ5u4lCBu9rxZ e4k1uMtu7PeA2fxMAnopdqjFJ65cbOFBESucF/JDkrMDRfqmAADHLcCxhYUVBwn9PKWhRQ/6 dJs3qv9H9XEsKbuQEb25WyrCTXQ9fCE90uDhJu6m8JeJdnTMywgwbC7QLDbnbKqS/I8thJu6 CuQUgFrWDgveZ84kALxXevoyd2GGb+9nfFSWtExCRfYzW6NWB4U10rpzjynR7jZbRMksbOYq mJoBukywPoTn5aXSQgDu2fQV+f1uTh+UbVLtzb8vVo5quB0xtJqS3bdxBAg= Subject: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.220.198.153; envelope-from=phs@lmf.cnrs.fr; helo=mx.lmf.cnrs.fr X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The following example code has been put in my ~/foo.el (defun check-value (v) ;; Let's demonstrate different treament of formats by elisp compiler (cond (v (print (format "Congratulations! v=%S is non-NIL.")) ;; oops, we forgot to pass v in `format's &rest args t) (t ;; otherwise (user-error "Try again. v=%S is null") ;; same error, here when calling `user-error' nil))) When I byte-compile it with M-x byte-compile-file I get the following warning message: In check-value: foo.el:4:18: Warning: ‘format’ called with 0 args to fill 1 format field(s) which is very useful. But why don't I get a similar error message for my call to user-error ? It would be useful too. Note that when I evaluate (check-value nil) I get an error with the following *Backtrace*, showing that my call to `user-error' fails for exactly the same reason that evaluating `(check-value t)' fails. Debugger entered--Lisp error: (error "Not enough arguments for format string") format-message("Try again. v=%S is null") apply(format-message "Try again. v=%S is null" nil) user-error("Try again. v=%S is null") (if v (print (format "Congratulations! v=%S is non-NIL.")) (user-error "Try again. v=%S is null")) check-value(nil) (progn (check-value nil)) eval((progn (check-value nil)) t) elisp--eval-last-sexp(t) eval-last-sexp(t) eval-print-last-sexp(nil) funcall-interactively(eval-print-last-sexp nil) call-interactively(eval-print-last-sexp nil nil) I thought you'd like to know. Thanks for your time and dedication in developing GNU Emacs ! --philippe In GNU Emacs 29.3 (build 1, aarch64-apple-darwin21.6.0, NS appkit-2113.60 Version 12.6.6 (Build 21G646)) of 2024-03-24 built on armbob.lan Windowing system distributor 'Apple', version 10.3.2487 System Description: macOS 14.5 Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules 'CFLAGS=-DFD_SETSIZE=10000 -DDARWIN_UNLIMITED_SELECT' --with-x-toolkit=no' From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 05 12:58:17 2024 Received: (at 71379) by debbugs.gnu.org; 5 Jun 2024 16:58:17 +0000 Received: from localhost ([127.0.0.1]:48852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEtxo-0002C7-7e for submit@debbugs.gnu.org; Wed, 05 Jun 2024 12:58:17 -0400 Received: from mail-lj1-f175.google.com ([209.85.208.175]:57709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEtxm-0002Bf-2Z for 71379@debbugs.gnu.org; Wed, 05 Jun 2024 12:58:14 -0400 Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2eacd7e7ad7so446751fa.3 for <71379@debbugs.gnu.org>; Wed, 05 Jun 2024 09:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717606614; x=1718211414; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=P7zAbSz5GvfFOe5UKf8ANhOD0EsWoQGfMTCcZy7wZCE=; b=OQZxHpJyPUKmW3XdB6wE+jh9XR5jLgFqHfhxCg4O3Sf8tI3cVF8AixNjhJKx1Xhqrq xukOldgmryWo7lu38xyXqTbaHhdCN9hjdJtrcsri3T9fkXeBa1kjmUd9OtPXv9iDeaeV ZPNe0/WvT3t75MANz/jxgNmCB4gUzPk4zHjUf8bV8YNdrhKg4sIS2Dk+yuH0yYRNHd85 PLjrzVBxqrNs+a8SbxciZVkEuhuRfh6chzzjZXXsyShhbgoZBsWp6Qryx0dzqRQAvti/ qgMPUfQX/R25Q0iuR77kvnNj3aaT2duWD9P+Zxdx3x2qkeqznpIyRvRu0F+pOVJkE6lt dCgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717606614; x=1718211414; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P7zAbSz5GvfFOe5UKf8ANhOD0EsWoQGfMTCcZy7wZCE=; b=Y8D4lpoGZEU667EunFEUH8f5T72XPOK/L34YDr7v4II6yxd+Uz/K+YSlRRKiHR+Ilf JFN5DFlQqQXJ6ez4PPXJbe48lxTgLWN6QrxzmPW+w1k8xxkbWsIhtYlK9jZSXfpTlqg4 4nkKR6OsurQMjuHhRXTZwGZHcqe+62cf8U68/ScIkx2y5bsFLwzhUaLO0OAMT1ltj5eO zoAcGTkke6QOIvL4tKwWHKMnQ8PPhT1l8ZQUzLEQKmJBVJXGqRd0ZA+XRyrDJ9A61Agx SOvGRGLTEDMaBpTYD+Td1B1ZhvJIAqlBflnas+EUfmjLKJjz3ArQjPfL45yeAKz0iaqL 0Xpg== X-Gm-Message-State: AOJu0YzaG9jB9zHxuJDrDU3+gBGo7DQo/RrjVmlo1zB8qtTJNF/ne75T 1XH2mp9ZamzIX/+XAF5ZaVyxck8cvsNjqZevZVhv1az9OQUzLOW1 X-Google-Smtp-Source: AGHT+IG+GPd1EjlmTVVWn7VFaJ0tT9Xpagy4NoVyIxtrPqUag+usYFlwSrWYtiGGzsCFUYA+iCzlYA== X-Received: by 2002:a2e:86c6:0:b0:2e6:f5f5:f97 with SMTP id 38308e7fff4ca-2eac79c3ba1mr19977431fa.6.1717606613791; Wed, 05 Jun 2024 09:56:53 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2eace7c33b3sm874431fa.131.2024.06.05.09.56.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jun 2024 09:56:53 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments Message-Id: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> Date: Wed, 5 Jun 2024 18:56:52 +0200 To: philippe schnoebelen X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I stumbled on this report by accident: > But why don't I get a similar error message for my call to user-error = ? That's a clear oversight, thank you for reporting it. Will fix. Should be trivial enough for master (and I have made a full bootstrap) = but I'm asking Eli for confirmation just in case. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 05 13:48:52 2024 Received: (at 71379) by debbugs.gnu.org; 5 Jun 2024 17:48:52 +0000 Received: from localhost ([127.0.0.1]:52635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEukl-0007RD-NM for submit@debbugs.gnu.org; Wed, 05 Jun 2024 13:48:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEukj-0007Qu-Hy for 71379@debbugs.gnu.org; Wed, 05 Jun 2024 13:48:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEukP-00020F-U4; Wed, 05 Jun 2024 13:48:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=S97LT4otIgzcpr1C31RjY/zLVKDbvrTumpY7F102G2U=; b=UJ2HAvoVGLD4/f8bBz8v xy1tDtBqy72lP+YpiDqwl1Ycf6aDdyHP/SLALPfi1qu5rG7F4RpV4l8LHNCdAoMG6Hsc3jpXI7OPH Rv+jFPrgjt3mDOF+jvxnBNpI1HrY0Vtt/lCZ0j6J2FhTKEbpt1rGnHjBR3jpT0nWXklBkm1bK3q1Z jgo68HvVFTZgFAfFkdyDoK3yP6Zml+oFPd60KSPdvI8R939ulgaYElgpuWfDTOPHE4n9hhcz2CuqF AjuwOMWYab4DWMzJKjKueq3ZumyXO9gQThtGEfJ1aYdSr7nlYFhXiaOr9KS85gW8zzuTTbZKZ17k/ 1lDYFLyA2NAnNQ==; Date: Wed, 05 Jun 2024 20:48:25 +0300 Message-Id: <861q5bjn6e.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Wed, 5 Jun 2024 18:56:52 +0200) Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, schnoebelen.ph@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Wed, 5 Jun 2024 18:56:52 +0200 > Cc: 71379@debbugs.gnu.org, > Eli Zaretskii > > I stumbled on this report by accident: > > > But why don't I get a similar error message for my call to user-error ? > > That's a clear oversight, thank you for reporting it. Will fix. > > Should be trivial enough for master (and I have made a full bootstrap) but I'm asking Eli for confirmation just in case. Thanks, I'd like to see the changes before making up my mind about that. The problem is definitely not serious, so the fix should be safe enough to qualify. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 05 15:22:17 2024 Received: (at 71379) by debbugs.gnu.org; 5 Jun 2024 19:22:17 +0000 Received: from localhost ([127.0.0.1]:59304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEwDB-0003FP-AZ for submit@debbugs.gnu.org; Wed, 05 Jun 2024 15:22:17 -0400 Received: from mail-lj1-f170.google.com ([209.85.208.170]:42092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEwD9-0003Et-G6 for 71379@debbugs.gnu.org; Wed, 05 Jun 2024 15:22:16 -0400 Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2eab0bc74caso1231881fa.0 for <71379@debbugs.gnu.org>; Wed, 05 Jun 2024 12:22:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717615255; x=1718220055; darn=debbugs.gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=P/kTizWarLGHaCuz/7Kj2PGOSuooAI9JQ/G7jJgyMnU=; b=Hc/raMgc27Ch6Gd8BR5wGWsY+ruB7XzxGkNKyKsNiZr02QbFjFMgVFXwVTTVvB0CcE xO9k5Igr+keDar2TkwPqXhWr8N79zCmy8uJucZkjZQeC3G1yOo6XyYs7szFtkErzqbr+ Me+QqUv0zQ/dMtc2XrEbFJElekfq/nar/kafId/xjT77OTkPJqO2OqJZY5G4nId8+XUV CPtdxsH1RqhTN6g2r7xOztQXEEQ2dR72QMeikoZPbOZMub1GcFBPDSgzRYBoEuQt0wyQ FTI6pRo3bjueao3csA+CDTcxgSUXHuQwkyIG0cqcVVTGp7fkB8SEicmTm4NgrWc3Blv8 L/SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717615255; x=1718220055; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P/kTizWarLGHaCuz/7Kj2PGOSuooAI9JQ/G7jJgyMnU=; b=YzfExHMQyq0yIT4qLW8Z2lC/abkJ7BJffm/NTj16CU61g7Pjc8PJY2e8LHtwFvsB61 GRCOvM9GzvPlUuWwExhxUAd5BjT7eJuCUnolD+7SQviA4GCZmn/K838jMNuqJs0IC8Nh c6f3+Mcy9YMo4KErleLsdA0Tn+470KNZh3xNyvfhnfr8coxWvjaBxaOyi0TG2Q5lRY4O sCcVguyoc4dKxSwgU1+ZTdIYvH3h5rtPNl/uP5FS0bPPLDa0VAe+mDwGldHCZRF8s8KC buzfPsGQk3Zf82d+nDk7+XhkI0bM3a5J/S0/x+OcDOwtPmht1zvJA8QpnmMhq/NhqMeZ gQdQ== X-Forwarded-Encrypted: i=1; AJvYcCXPS5lM2DRG2dZiMzf1zlmIPYHBLdcJJVN2h7v9GPLTuwpDvofuVgQXWH6ITykE1txgVJdN11Oy1WbZycRw+BjbyIyySH4= X-Gm-Message-State: AOJu0Yw237a7sITwXRjo39zi//7P61NTn9o6akEU5mKAZsmUBrbinrN/ krQjEHgh36KksDe0Il7L/UV1JT70UXsVTgxOyl0o6QWwPtupGaic X-Google-Smtp-Source: AGHT+IG9W8Aj5W8B3xycEaTiorzenfQvJDiY3wblSDJkd0MGa/fYihN8EsZTmc4rOYZgtTqXA3OsQQ== X-Received: by 2002:a2e:9646:0:b0:2ea:ae2f:9303 with SMTP id 38308e7fff4ca-2ead00b88e4mr1583061fa.12.1717615254631; Wed, 05 Jun 2024 12:20:54 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ea91bb4aedsm19534191fa.33.2024.06.05.12.20.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jun 2024 12:20:54 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Message-Id: <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_DCA52575-5FA5-43DE-95EB-EDF69CC5AD8F" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments Date: Wed, 5 Jun 2024 21:20:53 +0200 In-Reply-To: <861q5bjn6e.fsf@gnu.org> To: Eli Zaretskii References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, schnoebelen.ph@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_DCA52575-5FA5-43DE-95EB-EDF69CC5AD8F Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii 5 juni 2024 kl. 19.48 skrev Eli Zaretskii : > Thanks, I'd like to see the changes before making up my mind about > that. The problem is definitely not serious, so the fix should be > safe enough to qualify. Sorry, meant to attach the patch. --Apple-Mail=_DCA52575-5FA5-43DE-95EB-EDF69CC5AD8F Content-Disposition: attachment; filename=0001-Format-string-warnings-for-more-functions-bug-71379.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Format-string-warnings-for-more-functions-bug-71379.patch" Content-Transfer-Encoding: quoted-printable =46rom=206f758e82a37a6b62abc71459c8878de7217834ae=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Wed,=205=20Jun=202024=2018:28:59=20+0200=0A= Subject:=20[PATCH]=20Format=20string=20warnings=20for=20more=20functions=20= (bug#71379)=0A=0A*=20lisp/emacs-lisp/bytecomp.el=20= (byte-compile-format-like):=0AAdd=20message-box,=20message-or-box,=20= warn=20and=20user-error.=0A---=0A=20lisp/emacs-lisp/bytecomp.el=20|=203=20= ++-=0A=201=20file=20changed,=202=20insertions(+),=201=20deletion(-)=0A=0A= diff=20--git=20a/lisp/emacs-lisp/bytecomp.el=20= b/lisp/emacs-lisp/bytecomp.el=0Aindex=2003cfbe6f4c9..d59e89bd7de=20= 100644=0A---=20a/lisp/emacs-lisp/bytecomp.el=0A+++=20= b/lisp/emacs-lisp/bytecomp.el=0A@@=20-1643,7=20+1643,8=20@@=20= byte-compile-format-warn=0A=20=20=20=20=20=20=20=20=20=20nargs=20(if=20= (=3D=20nargs=201)=20""=20"s")=0A=20=20=20=20=20=20=20=20=20=20nfields=20= (if=20(=3D=20nfields=201)=20""=20"s"))))))=0A=20=0A-(dolist=20(elt=20= '(format=20message=20format-message=20error))=0A+(dolist=20(elt=20'(=20= format=20message=20format-message=20message-box=20message-or-box=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20warn=20error=20user-error))=0A=20= =20=20(put=20elt=20'byte-compile-format-like=20t))=0A=20=0A=20;;=20Warn=20= if=20the=20function=20or=20macro=20is=20being=20redefined=20with=20a=20= different=0A--=20=0A2.32.0=20(Apple=20Git-132)=0A=0A= --Apple-Mail=_DCA52575-5FA5-43DE-95EB-EDF69CC5AD8F-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 06 01:22:20 2024 Received: (at 71379) by debbugs.gnu.org; 6 Jun 2024 05:22:20 +0000 Received: from localhost ([127.0.0.1]:38919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF5Zr-0006yF-NX for submit@debbugs.gnu.org; Thu, 06 Jun 2024 01:22:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF5Zq-0006xi-4Y for 71379@debbugs.gnu.org; Thu, 06 Jun 2024 01:22:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sF4tr-0007c5-MP; Thu, 06 Jun 2024 00:38:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ueXTKxTWDyaLBjiOvr7wmAiIgUl+BzFYfjHBEIm2kok=; b=OJniUo8d//eUAY0KuCgs vbJXBlQibY5PIc5hud/4TXs6cy9weqpYXUNQxyBHMlylNbbCDUPvZVLiHl5rM2a2Z1BhZA0lyg+T7 07jhodAQkMGuMG5ZQW2CCF7HdKqCGod83gkfg75lQvPJ4UwAOVOr51ytAuLjonHpN1F5DsYko5Rr0 GNH8/2l/6wwmw0AvRm6stMJWa9fADOXclXfzXk/JKDHeKHcCfA6E3ij/NVfVzzMV1G5dBRv81cGu/ rdZopUP7gt2FbDTZKSS3sH5Dch7pCt82gk8QpuwXzSY3y1UF03fFhg+MIy+F50r+rVRlOjqmgTv7d TQkJmCs8iLra8Q==; Date: Thu, 06 Jun 2024 07:38:53 +0300 Message-Id: <86sexqit2a.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Wed, 5 Jun 2024 21:20:53 +0200) Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, schnoebelen.ph@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Wed, 5 Jun 2024 21:20:53 +0200 > Cc: schnoebelen.ph@gmail.com, > 71379@debbugs.gnu.org > > 5 juni 2024 kl. 19.48 skrev Eli Zaretskii : > > > Thanks, I'd like to see the changes before making up my mind about > > that. The problem is definitely not serious, so the fix should be > > safe enough to qualify. > > Sorry, meant to attach the patch. On second thought, this is still fine to go in now, but I wonder whether we should move these to the places where the corresponding functions are defined, and leave in bytecomp.c only those which are primitives defined in C? That would mean 'warn' and 'user-error' should be moved to their respective Lisp files. WDYT? From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 06 04:50:32 2024 Received: (at 71379-done) by debbugs.gnu.org; 6 Jun 2024 08:50:32 +0000 Received: from localhost ([127.0.0.1]:52263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF8pM-00083v-9x for submit@debbugs.gnu.org; Thu, 06 Jun 2024 04:50:32 -0400 Received: from mail-lf1-f52.google.com ([209.85.167.52]:49436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF8pK-00083a-10 for 71379-done@debbugs.gnu.org; Thu, 06 Jun 2024 04:50:31 -0400 Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52b840cfecdso816390e87.3 for <71379-done@debbugs.gnu.org>; Thu, 06 Jun 2024 01:50:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717663749; x=1718268549; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=8ime/ih0Ev9LpJSgWk94RVwXamb/YVm7OvOqYGmEUpw=; b=OrWgDBDKZu75zBrfXGKrr8nu09gMhpZ2Mpzrq9ig+GHtIRlUNodLFeNTubOKuPDs59 VJy7RO3KHNvxiw0lVCoElVD91mCf/orGdQxppdD7wawhmRKn54pPDs2ENZ+eR8ZpXhEi muHHSy9pFDDdYhw9/wvPuz2/C9dAm9U4dxX2gACZ32jjlqiwk5ejiBB153JXIwVKcxIu eAdRDCRv0+L7DkMbqZfalTgkG5ibnrHGDlBjmeXGNtjlI3lyOSNLgvXrh38v71PD+XTI ralSOgR1gdxPyBohyExEKZQnVoN9pPG7Yd+95QvlW3VFY+eKnqqefi+K1ci+fR98rrPq OQuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717663749; x=1718268549; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8ime/ih0Ev9LpJSgWk94RVwXamb/YVm7OvOqYGmEUpw=; b=aY2qRmZwWBtoOtkuOMBKGeupEzGAdVrj+UO58449CpMfkt8HDaFJGdbbgMCYZpI1Rc BeiETOcmSpxAwxT/44xTEUGUrBJKrtBYyDZfjhv6yyG7sccFqmdWJ5GXJaZCLnExDr9e YcCmWksBe3DIWNfYyojJP9Dzw0P0utvCe7ShY/1wSEeRnjsNOwOKlcss4i0S+bptzpw+ 1YjfqheubnLSMHfkXWj295hcEU7bwid3zLMbFElTC9bWJXClRXqwpNc5lDAq1JC2hb6p LZoCQ9fsgMgNAzSYElFkoxCFcLVxRSScITdVW9epaPsNXJVqSytXJRp/JBL3i4Mq3q16 DN/Q== X-Forwarded-Encrypted: i=1; AJvYcCWkJidz4DMD3F7vQnv20j7SZX64CfZZsGgTwRgGP5htz8LpF4WSwI1jPimMGCM5cpG6KTFtz5lHtOFHQJXdxqqs7JprpURK3Jcpfw== X-Gm-Message-State: AOJu0Yz1cJ0w+X4yqLUUFntMt1wz4FaJVoXgX1Yk3xcKfZEwSsfac2Lp vK1eBHAoepxIVgINJ/HXT0UUIajYLtg1BzoP3fwkrzgAcvIuGBpP X-Google-Smtp-Source: AGHT+IGoKRnRGAAdKOp/RQDzkAzALqs4lTbBHrNL4vqFRemt+h+R0pd6JwmWTADEhxs7j+gqDZ0Jtw== X-Received: by 2002:a2e:8303:0:b0:2e9:4a5b:b6c2 with SMTP id 38308e7fff4ca-2eac7a95369mr28967121fa.41.1717663749281; Thu, 06 Jun 2024 01:49:09 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ead41bfd29sm1240901fa.116.2024.06.06.01.49.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jun 2024 01:49:08 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <86sexqit2a.fsf@gnu.org> Date: Thu, 6 Jun 2024 10:49:07 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <03B10D9E-2A0A-4E18-B706-730BB2189CED@gmail.com> References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> <86sexqit2a.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71379-done Cc: 71379-done@debbugs.gnu.org, philippe schnoebelen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 6 juni 2024 kl. 06.38 skrev Eli Zaretskii : > On second thought, this is still fine to go in now, but I wonder > whether we should move these to the places where the corresponding > functions are defined, and leave in bytecomp.c only those which are > primitives defined in C? That would mean 'warn' and 'user-error' > should be moved to their respective Lisp files. Indeed it's a question I always ask myself every so often, and sometimes = we distribute properties to definitions.=20 However, in this case it seems better to keep them in one place: it's = only a small handful of functions, and this way the properties are kept = local to the byte-compiler. Thank you, the change is now on master. Closing. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 06 19:32:32 2024 Received: (at 71379) by debbugs.gnu.org; 6 Jun 2024 23:32:32 +0000 Received: from localhost ([127.0.0.1]:51317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFMat-0005K8-S8 for submit@debbugs.gnu.org; Thu, 06 Jun 2024 19:32:32 -0400 Received: from mail-ej1-f43.google.com ([209.85.218.43]:43510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFMar-0005JP-AS for 71379@debbugs.gnu.org; Thu, 06 Jun 2024 19:32:30 -0400 Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a6269885572so470672266b.1 for <71379@debbugs.gnu.org>; Thu, 06 Jun 2024 16:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717716668; x=1718321468; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=lYQpq50/3Tsf4f864q9GJqOd88d2++SdxSPfG2EecdA=; b=A65slhr/fzkHvr85fqEPXaHZGiBD2O3IvHW/RVUM4zcsdMD7qNCuOVbuOwh8cefdtt CnyDwYrDRlIb0Qb6mKl/q79W3Mf8AXOQlkrr+3yC5iUwMn24VTzc4MAEjdAKmPq+Kkzy Vz6eVUE2bHyEYZ9W/m7tCrxGl4sKSxuhrozcPdVBYKqJFCVu8zUoz678Y5aiEAD45Fsg 3nAu5LY6I3dn9K/afS/bTXB8/brFWx/iyLcXLOcguhDkwUvrwJ4TRSyiqjQsQcsj5lb0 xZdQD/th4ReBkOU/8wVpZQ+2T0acBc1hpxTrKLL2D0HDGraCSdsrSKmVDjK6WhPI0r7T aNfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717716668; x=1718321468; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lYQpq50/3Tsf4f864q9GJqOd88d2++SdxSPfG2EecdA=; b=NbvAm6DcVc/24mg22Zkt8LuvG7Pqk5PAITD6Mn9FehhJHMHZExQWCAjTQQHLvyw7Bo 6g1XQjNdm3DYuzF29ehQHlytjrma3GDREHgKM21Gf/hBQ8qxUnTkBbz3Hb7V35sRS/AG 5bcRuBYKj6hKia9l8YMcXhiBDnYxvWSjAqLe9JTvIchG8fiMYDgFjzcn3hRTt3t0fvtd BtWa1G4qaWEg9Rb8MfnH1/sjHG/BdVhmsaA+wrkaYOo9OvJnLmB+huacgVCairm5ZVNE +aPplJTirlq+iD9v1A6RXjdHSmtG5ku5mK/8crd6a32zqt1iWB6hKdV6Kr0uUjSx0Pqf xhrQ== X-Gm-Message-State: AOJu0Yznb8GuJDaZ0Rh53lOhB6CR7df0NmSJ94CvciwfGBP+A72QJY/R h9Lsp7X5bSGu7p7oWHpOOeWsykC7bimtL/D4CDFSVDfrvNpuhxBw1VlED63jkKGLG4pkj6YcP0n KVnGL8FBuKsOwv7VL6kpMbBNAMNfQPDdxJ2Y= X-Google-Smtp-Source: AGHT+IGdMCpl5clSexE20c68SgLTDX/8ekg+Uv8ktdWWYdle9Pu7O4QlEqtpjPtM01ZjXH7Y43tR99/cN61zGNtFZeM= X-Received: by 2002:a50:f607:0:b0:578:635d:67ba with SMTP id 4fb4d7f45d1cf-57c4e409c19mr873619a12.18.1717716169415; Thu, 06 Jun 2024 16:22:49 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 7 Jun 2024 01:22:49 +0200 From: Stefan Kangas In-Reply-To: <03B10D9E-2A0A-4E18-B706-730BB2189CED@gmail.com> References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> <86sexqit2a.fsf@gnu.org> <03B10D9E-2A0A-4E18-B706-730BB2189CED@gmail.com> MIME-Version: 1.0 Date: Fri, 7 Jun 2024 01:22:49 +0200 Message-ID: Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, philippe schnoebelen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd writes: > 6 juni 2024 kl. 06.38 skrev Eli Zaretskii : > >> On second thought, this is still fine to go in now, but I wonder >> whether we should move these to the places where the corresponding >> functions are defined, and leave in bytecomp.c only those which are >> primitives defined in C? That would mean 'warn' and 'user-error' >> should be moved to their respective Lisp files. > > Indeed it's a question I always ask myself every so often, and sometimes = we distribute properties to definitions. > However, in this case it seems better to keep them in one place: it's onl= y a small handful of functions, and this way the properties are kept local = to the byte-compiler. No strong opinion, but I think this cuts both ways: keeping it local to the definition of the functions themselves makes it clear to anyone looking there for inspiration how to add such warnings to their own `format` functions. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 07 02:38:55 2024 Received: (at 71379) by debbugs.gnu.org; 7 Jun 2024 06:38:56 +0000 Received: from localhost ([127.0.0.1]:54727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFTFX-0000c5-EH for submit@debbugs.gnu.org; Fri, 07 Jun 2024 02:38:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFTFV-0000b7-JE for 71379@debbugs.gnu.org; Fri, 07 Jun 2024 02:38:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFSz7-00085N-Rp; Fri, 07 Jun 2024 02:21:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=eg5UAXcqk8VJMCxuFwoQOVAYG6tg+WIMDZWSiJ99FIk=; b=PtTxSJ9pOkeyIWzxbLTO jljALdwqZUeUlD+btt8j6w7ntC5/J+EZjJmRT1OpOlwEw1YwQX+z8VAQfZWlcWOAd2z+SYMCYQlWf D/Qfh01Al10n/2VYwrg5tEsqgOHC7tH9L0lrufrgWANFWV0+v7UiVK41pDHup/Oyh6oWSdJCx0LNH lNgGSXIs3j2nV3dF/Zly/EctL4Q2PN7usNDHS1vsxdg9yqegQo7jhwLN6a+JX39c2/3/5IcUPXBxs 9E8lRfB6CufYLvRbmmwGu/uB1K+eM7scVDJbOtUPwHoKHeUBYwx4VSDFrf5EtnT1y3eBQmuSdFR6O Jr7W3ACWqgWCCA==; Date: Fri, 07 Jun 2024 09:21:56 +0300 Message-Id: <86r0d9ff23.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Fri, 7 Jun 2024 01:22:49 +0200) Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> <86sexqit2a.fsf@gnu.org> <03B10D9E-2A0A-4E18-B706-730BB2189CED@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, schnoebelen.ph@gmail.com, mattias.engdegard@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Fri, 7 Jun 2024 01:22:49 +0200 > Cc: 71379@debbugs.gnu.org, philippe schnoebelen > > Mattias Engdegård writes: > > > 6 juni 2024 kl. 06.38 skrev Eli Zaretskii : > > > >> On second thought, this is still fine to go in now, but I wonder > >> whether we should move these to the places where the corresponding > >> functions are defined, and leave in bytecomp.c only those which are > >> primitives defined in C? That would mean 'warn' and 'user-error' > >> should be moved to their respective Lisp files. > > > > Indeed it's a question I always ask myself every so often, and sometimes we distribute properties to definitions. > > However, in this case it seems better to keep them in one place: it's only a small handful of functions, and this way the properties are kept local to the byte-compiler. > > No strong opinion, but I think this cuts both ways: keeping it local to > the definition of the functions themselves makes it clear to anyone > looking there for inspiration how to add such warnings to their own > `format` functions. Indeed. In addition, some functions marked with this property already do that in their own files. Which was why I asked that question in the first place. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 07 05:34:17 2024 Received: (at 71379) by debbugs.gnu.org; 7 Jun 2024 09:34:17 +0000 Received: from localhost ([127.0.0.1]:40123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFVzF-00014T-JX for submit@debbugs.gnu.org; Fri, 07 Jun 2024 05:34:17 -0400 Received: from mail-lf1-f51.google.com ([209.85.167.51]:60684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFVzD-000142-F4 for 71379@debbugs.gnu.org; Fri, 07 Jun 2024 05:34:16 -0400 Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-52b976b5d22so2688747e87.1 for <71379@debbugs.gnu.org>; Fri, 07 Jun 2024 02:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717752774; x=1718357574; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=2j6gJYRunH7a/KXLcCsEj/TrI9qcK4T+ALSTdwD7oos=; b=YDK0ycUjyAxyM31gh+VVr7+Ps/qbSuYGhTfE6H4oh3cQWrcF80eTJz5Dau0jfdP5kZ 777wC8UImDRSbkiw/oO8oMazZ4vVleLBokt/ORfuqnP3S27NS7/NilNk7onMwo9TtBKM H332TY6Dv0ak9+dZydXdwEof4/Mp1MwtDANahzfQoOeWEDXG8ka5eQYJn3r7oHhBTh4U VyYIZ8AUpcCh8c5r6c5+mP0y8GDz3g+sS07Ze4dBg3X0FchwSvgXNS5hYxb2hx+SwkPm MxCIKujOgWYdLLHhZwuytBtzbaMX+DfXpztg48pj66krBuBWM667tVH+cE0TOdGq/v5+ 9JUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717752774; x=1718357574; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2j6gJYRunH7a/KXLcCsEj/TrI9qcK4T+ALSTdwD7oos=; b=rGNKO6n0EeDavojWfpH1iHtFcLCKhR/WWh9uz3dFkJLs7ojmvsZDqJjhXVuOP7ppgw 6zR1Ba6RwFa9t8SIkWBSl5Ym3f2sVej8H1zA8/5RI7yh7ZM66VjsKR4MDVnypYolghNt l1dGBY+Un5WUvAMoE4uqyOfX09dNxKq6YZAy7YXdDRutgVk//fF3n2k8e9F8b+9Cyfv0 43SIPcobK+z61KlAeITxYG5Tq+VUgblQKauPUAcKfQxDwvJgrVjPtKfxH/4ti8XFYKps pCYjZu5OExceHfA47IpGctcMXuX1nVUu1/nvA6n/lT7uyO/3RgKLyA9EzZSuaCOHntEm cMWg== X-Forwarded-Encrypted: i=1; AJvYcCWKduntncl35jEYbZMRizib8DjoeNdJGAyes2faQJV+uMUd0BPDLcF0n9YlstmT2lH4iVdctpXd9KtuFBCbCaIHyenC7cI= X-Gm-Message-State: AOJu0YwoZUQrKa7aaa/+667J0vYlqlBD9Y4YVvJmXpnm1NkRrcTDdGC/ y5NBMRm2N5vx8aBBB0TAK7Z2XfxeKjjY7n8gkPo8xuCWZK7xT/9i X-Google-Smtp-Source: AGHT+IGl3vQ5+iLuO2pNa+vYuj7oIqSN7Aj6odazvEO1Y8nu3BqVE8/Ca+VtgxmABlir8q32JMqaug== X-Received: by 2002:a05:6512:2242:b0:51e:bc4f:ed2a with SMTP id 2adb3069b0e04-52bb9f84d6emr1655976e87.37.1717752774006; Fri, 07 Jun 2024 02:32:54 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52bb423d776sm469413e87.208.2024.06.07.02.32.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Jun 2024 02:32:53 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Fri, 7 Jun 2024 11:32:52 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <070944BD-B0E0-43A9-B729-3532D635491A@gmail.com> References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> <86sexqit2a.fsf@gnu.org> <03B10D9E-2A0A-4E18-B706-730BB2189CED@gmail.com> To: Stefan Kangas X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, philippe schnoebelen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 7 juni 2024 kl. 01.22 skrev Stefan Kangas : > No strong opinion, but I think this cuts both ways: keeping it local = to > the definition of the functions themselves makes it clear to anyone > looking there for inspiration how to add such warnings to their own > `format` functions. Yes, it's a matter of judgement which has to be reconsidered from time = to time. I see no reason for doing anything about this right now, but = this may change in the future. The reasons for not distributing function = properties can be quite strong as well. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 07 10:10:17 2024 Received: (at 71379) by debbugs.gnu.org; 7 Jun 2024 14:10:17 +0000 Received: from localhost ([127.0.0.1]:33008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFaIK-0000Zr-VJ for submit@debbugs.gnu.org; Fri, 07 Jun 2024 10:10:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFa43-00080r-0W for 71379@debbugs.gnu.org; Fri, 07 Jun 2024 09:55:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFa3h-0008Qs-Uk; Fri, 07 Jun 2024 09:55:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=QHKOH7DJdfcPfEcpGyVfwaQx5uaX6O7PCUqBr9GkdJQ=; b=Fvp1wpYR2i6xDaAnRAHT NEXuVP09UfSkgE4ummpt2T7Xmz3E8Gr+cbRITiDU4Aeqm32gOgkmWrKO0/EoT0CFUqBiAqOY9KrlO SHd53/FVCXdBguiZk+cMF/qQZRiooOgQogPsDO5GIiob4bfBuXuXhnEcxCqPXA3MOcxM69erEaP3l //teP/LQ18QnLi2mt2o+0w9MrExgHhlqSZnO+Ik8hjD+gzHoTxgWBhsqYwbCaHTTubZfqzULB6ru3 KkcFfFEpPkUH3wj9mFnMLwNVL5WyYJEbus82NssrZ6z0ZoD6a/yjZ0eT16Ffho4ygen17sFAuD1eI dnMEhduuvUe18Q==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sFa3g-0003si-Nk; Fri, 07 Jun 2024 09:55:08 -0400 From: Andrea Corallo To: Eli Zaretskii Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments In-Reply-To: <86r0d9ff23.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 07 Jun 2024 09:21:56 +0300") References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> <86sexqit2a.fsf@gnu.org> <03B10D9E-2A0A-4E18-B706-730BB2189CED@gmail.com> <86r0d9ff23.fsf@gnu.org> Date: Fri, 07 Jun 2024 09:55:08 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, schnoebelen.ph@gmail.com, mattias.engdegard@gmail.com, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Fri, 7 Jun 2024 01:22:49 +0200 >> Cc: 71379@debbugs.gnu.org, philippe schnoebelen >>=20 >> Mattias Engdeg=C3=A5rd writes: >>=20 >> > 6 juni 2024 kl. 06.38 skrev Eli Zaretskii : >> > >> >> On second thought, this is still fine to go in now, but I wonder >> >> whether we should move these to the places where the corresponding >> >> functions are defined, and leave in bytecomp.c only those which are >> >> primitives defined in C? That would mean 'warn' and 'user-error' >> >> should be moved to their respective Lisp files. >> > >> > Indeed it's a question I always ask myself every so often, and >> > sometimes we distribute properties to definitions. >> > However, in this case it seems better to keep them in one place: >> > it's only a small handful of functions, and this way the >> > properties are kept local to the byte-compiler. >>=20 >> No strong opinion, but I think this cuts both ways: keeping it local to >> the definition of the functions themselves makes it clear to anyone >> looking there for inspiration how to add such warnings to their own >> `format` functions. > > Indeed. In addition, some functions marked with this property already > do that in their own files. Which was why I asked that question in > the first place. Agreed. Maybe in the future even worth having a declare for it? We have them already for things like ex 'important-return-value'. Andrea From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 07 11:51:01 2024 Received: (at 71379) by debbugs.gnu.org; 7 Jun 2024 15:51:01 +0000 Received: from localhost ([127.0.0.1]:38515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFbro-0004pr-U8 for submit@debbugs.gnu.org; Fri, 07 Jun 2024 11:51:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFbrj-0004pY-Nw for 71379@debbugs.gnu.org; Fri, 07 Jun 2024 11:50:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFbrO-0008J1-Q1; Fri, 07 Jun 2024 11:50:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LX/HtM0wjSVEe2k6Opu8/6DObOJ89izFVsrc1pBbSNk=; b=iq6XrnKhGyfO X5TvmNmD17E8YxM6oYfQDAkEUg+KuybzI+kFgNfFtlGxvKMVZ3omoTR1//8gYqXSjzzucuEfpjaAu MrG7lsIFItV5Y+4XYEbMXhLZ4lvSBOETW3gEG1oOGd/qVXkuk/aDqpQEZ4/79qQRT93xJqOoLcfNd ZPyACE+wYZHDzZCHcuku2oECQ3rYkNj3q8T5hJWtFjBwwY52ltkY/LZHou/AO/64SeQ+gkcpjnyPL Nlp7Bc3grw2rCEBn3XrhYn7jchUItYAlpnFMvWDmKlZPOzVZMbkmzjTXlzhvWk1ebu1xeUhR3CpIn R+XeXd9VKR0JobtYms3xIg==; Date: Fri, 07 Jun 2024 18:50:31 +0300 Message-Id: <86zfrweoqg.fsf@gnu.org> From: Eli Zaretskii To: Andrea Corallo In-Reply-To: (message from Andrea Corallo on Fri, 07 Jun 2024 09:55:08 -0400) Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> <86sexqit2a.fsf@gnu.org> <03B10D9E-2A0A-4E18-B706-730BB2189CED@gmail.com> <86r0d9ff23.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, schnoebelen.ph@gmail.com, mattias.engdegard@gmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrea Corallo > Cc: Stefan Kangas , 71379@debbugs.gnu.org, > schnoebelen.ph@gmail.com, mattias.engdegard@gmail.com > Date: Fri, 07 Jun 2024 09:55:08 -0400 > > Eli Zaretskii writes: > > >> No strong opinion, but I think this cuts both ways: keeping it local to > >> the definition of the functions themselves makes it clear to anyone > >> looking there for inspiration how to add such warnings to their own > >> `format` functions. > > > > Indeed. In addition, some functions marked with this property already > > do that in their own files. Which was why I asked that question in > > the first place. > > Agreed. Maybe in the future even worth having a declare for it? We > have them already for things like ex 'important-return-value'. Yes, could be a good idea. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 14:15:41 2024 Received: (at 71379) by debbugs.gnu.org; 8 Jun 2024 18:15:41 +0000 Received: from localhost ([127.0.0.1]:39428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sG0bM-0005d5-Tw for submit@debbugs.gnu.org; Sat, 08 Jun 2024 14:15:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sG0bK-0005cp-Mp for 71379@debbugs.gnu.org; Sat, 08 Jun 2024 14:15:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sG0ay-00032J-QL; Sat, 08 Jun 2024 14:15:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=TAq27ZAFnlcMLhqdP0q98PDQnJeD4g/yicncbbOmApk=; b=G8lXTWkt4a00E1HST5DJ fCf/KdH8CbmpV55lqH4xzs7y3HQ9uG0ZR/l5BkdRbsop88efSCwppTK4evnb6SVFzqZPGYFxDnkfK c/xt8C17O7tUGvPxyXXimKSK4BwOduoqlK/UcxB6EhmEmkoZjKalG1jPSuacGHZ8W3kZn8RTw3JP+ zoysv4LcV9tiCr2nfUP671TL393XN6wqMOlfRw3f9rIshloFRZPE2uyQf9FWYz+7PCAV6kGBZis8m cn6Qh3zsfHa+E0UBwZc8Hdb1zNzgs4oAjjoCkitPKHe8jQtlEm0Bx8jbN6dad0bgQP9mKSOOw0htq vMowdiZ813Wo2g==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sG0aw-0005Xr-JN; Sat, 08 Jun 2024 14:15:15 -0400 From: Andrea Corallo To: Eli Zaretskii Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments In-Reply-To: <86zfrweoqg.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 07 Jun 2024 18:50:31 +0300") References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> <86sexqit2a.fsf@gnu.org> <03B10D9E-2A0A-4E18-B706-730BB2189CED@gmail.com> <86r0d9ff23.fsf@gnu.org> <86zfrweoqg.fsf@gnu.org> Date: Sat, 08 Jun 2024 14:15:14 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, schnoebelen.ph@gmail.com, mattias.engdegard@gmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: Stefan Kangas , 71379@debbugs.gnu.org, >> schnoebelen.ph@gmail.com, mattias.engdegard@gmail.com >> Date: Fri, 07 Jun 2024 09:55:08 -0400 >> >> Eli Zaretskii writes: >> >> >> No strong opinion, but I think this cuts both ways: keeping it local to >> >> the definition of the functions themselves makes it clear to anyone >> >> looking there for inspiration how to add such warnings to their own >> >> `format` functions. >> > >> > Indeed. In addition, some functions marked with this property already >> > do that in their own files. Which was why I asked that question in >> > the first place. >> >> Agreed. Maybe in the future even worth having a declare for it? We >> have them already for things like ex 'important-return-value'. > > Yes, could be a good idea. Okay, will do after we branch emacs30. Andrea From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 14:19:36 2024 Received: (at 71379) by debbugs.gnu.org; 8 Jun 2024 18:19:37 +0000 Received: from localhost ([127.0.0.1]:39432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sG0fA-0005ia-Km for submit@debbugs.gnu.org; Sat, 08 Jun 2024 14:19:36 -0400 Received: from mail-lj1-f170.google.com ([209.85.208.170]:50450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sG0f7-0005iM-9p for 71379@debbugs.gnu.org; Sat, 08 Jun 2024 14:19:34 -0400 Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2eabd22d3f4so37521481fa.1 for <71379@debbugs.gnu.org>; Sat, 08 Jun 2024 11:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717870691; x=1718475491; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=Jb961P3vOJzrPgQt5YDu69glqsJf37yVdZNneNi2NVk=; b=glys0f0YFinmnWiXz+emWmM2v2QyOSv1klCNbG3b1wFBBdp/U2HBu9IARAT7ePqFL9 GgCOGpvx11nHuu3Exe5QsMTPGEuUjct0Wp3pZvvwdKuBWvHGP6zXLpFX6swL9UB1XEiv JdVDNOYH3TBJ1JeG6dj5p+NWXVM8vhmKKIyC9FM2QL5sctug7Rb/aRhBi9mGxhs3UA97 Mi7V3GgpD3ZGDuiWt5Lwotx6moCbK4VOstmvqPtje28L8aH6qLWZ62Corx9x3dKv//Lz 27uR1GUDuG8i8w1fULTzUeEZ4+DhNVqFMKtUg/dXprFlo0lcLJbZL65c8i/EtFdB1Mrn Gh9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717870691; x=1718475491; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Jb961P3vOJzrPgQt5YDu69glqsJf37yVdZNneNi2NVk=; b=XzxsQPqotjAHfcOQEczFYoYggdZdvu76L6qmHCfOwuP7Th9UnSJDxGmDih16m70lg2 E1PY7yCHWhaWJ549SVqb3/eGaKF5eiQ9vxvElzGcu6d3+F7RzbcDKww1pTpAiRXYRbP1 blt5v4t+7CnDUxZNNb5Zr0K6hIsmhJpVQsIkzaqpWmHm8+3ilHERkBzO77jGrGSPBKWs QPdvgIh/tibc9WRRVIqelbOUcVn8OSB0W/5aE786JJ1aBC/bn9nYG1EspMR7hn/Lg5dj aqIFFt5R8pqB159PqCrmKVf1fEeS8P0LQiye3vYLZ0Ooyn8g6fLD73bdXTbNQoWX262z sAwQ== X-Forwarded-Encrypted: i=1; AJvYcCVZqc+Mt619r0OF5RzzDwQSn1DMqSCcgbzNrnlU20lsqhFwX+qjZU5iVJVNtfXVikTnrnig5GCFBCcQosC6MW7S7l2+SIQ= X-Gm-Message-State: AOJu0Ywid+8I4mtVOtQZMz1cc6UcHapinnmJS5LQBsKWw0xCCcszIo6n +BTmPX+t/hOK8D0WIWvt1gPfK2Ob32YWWzywqo0oJ2txnMWgcAMV X-Google-Smtp-Source: AGHT+IECGI/eIiUfe2CQYoLqdQlX2OZVQlQ0bhtjhM2pkVlVXB7C2lL4KGV1FMIi6w+QaRHXg/YD4g== X-Received: by 2002:a19:7604:0:b0:520:dc1c:3c5d with SMTP id 2adb3069b0e04-52bb9fc9845mr3389912e87.42.1717870690938; Sat, 08 Jun 2024 11:18:10 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52c59353fd4sm300687e87.68.2024.06.08.11.18.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Jun 2024 11:18:10 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Sat, 8 Jun 2024 20:18:09 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <5A609262-9A22-42A9-9016-C3A38284C9A4@gmail.com> References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> <86sexqit2a.fsf@gnu.org> <03B10D9E-2A0A-4E18-B706-730BB2189CED@gmail.com> <86r0d9ff23.fsf@gnu.org> <86zfrweoqg.fsf@gnu.org> To: Andrea Corallo X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, schnoebelen.ph@gmail.com, Eli Zaretskii , stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 8 juni 2024 kl. 20.15 skrev Andrea Corallo : >>> Agreed. Maybe in the future even worth having a declare for it? We >>> have them already for things like ex 'important-return-value'. >>=20 >> Yes, could be a good idea. >=20 > Okay, will do after we branch emacs30. Again, I'm not very fond of the idea (or I would have done it long ago = myself). From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 14:32:40 2024 Received: (at 71379) by debbugs.gnu.org; 8 Jun 2024 18:32:40 +0000 Received: from localhost ([127.0.0.1]:39438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sG0ro-00064J-02 for submit@debbugs.gnu.org; Sat, 08 Jun 2024 14:32:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sG0rk-00063z-6t for 71379@debbugs.gnu.org; Sat, 08 Jun 2024 14:32:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sG0rO-0005S4-8o; Sat, 08 Jun 2024 14:32:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=9GhnC5eR772Vs2PTAE+6k3YhnwiiCy1bBy00QVhCB1o=; b=MFa+g7hjflBAI7orgZsn f5ubEDrH1HY3f5ZKFbXGIFboU9r8UEL+/rD2MEs0AphVH8d5wQWSCLpZm75XAZqcJPf6FQdLy76uV Tf9Ull8T+Wlcv2GqA5qvIJqdwPkHEuMiBhc9zd/Qx+oanFNL0l59709Kv9zPd5YLnQ3aZASkMZgoC OSPF1wuL8orysz+gdW9OV+upskFlgShFqCZRQ2mqO71zfgzaJL2W9zwlx9WEcLW+nzAS3RCqIEguo WK1uyhPChx9v8+RTV+PUpkZpJHag5NIA8YKWGf4xMRTyuU9ovgB3XNh+e0a+Bmzo7FZfK4V8RF/H4 9gL4dxjrB4K8Xw==; Date: Sat, 08 Jun 2024 21:32:11 +0300 Message-Id: <86jzizb80k.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <5A609262-9A22-42A9-9016-C3A38284C9A4@gmail.com> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Sat, 8 Jun 2024 20:18:09 +0200) Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> <86sexqit2a.fsf@gnu.org> <03B10D9E-2A0A-4E18-B706-730BB2189CED@gmail.com> <86r0d9ff23.fsf@gnu.org> <86zfrweoqg.fsf@gnu.org> <5A609262-9A22-42A9-9016-C3A38284C9A4@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, schnoebelen.ph@gmail.com, acorallo@gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Sat, 8 Jun 2024 20:18:09 +0200 > Cc: Eli Zaretskii , > stefankangas@gmail.com, > 71379@debbugs.gnu.org, > schnoebelen.ph@gmail.com > > 8 juni 2024 kl. 20.15 skrev Andrea Corallo : > > >>> Agreed. Maybe in the future even worth having a declare for it? We > >>> have them already for things like ex 'important-return-value'. > >> > >> Yes, could be a good idea. > > > > Okay, will do after we branch emacs30. > > Again, I'm not very fond of the idea (or I would have done it long ago myself). Why not? Without a rationale, how can we discuss this? From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 09 11:25:18 2024 Received: (at 71379) by debbugs.gnu.org; 9 Jun 2024 15:25:18 +0000 Received: from localhost ([127.0.0.1]:44333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGKQ2-0002Em-3A for submit@debbugs.gnu.org; Sun, 09 Jun 2024 11:25:18 -0400 Received: from mail-lf1-f49.google.com ([209.85.167.49]:44455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGJ4L-0006SL-5M for 71379@debbugs.gnu.org; Sun, 09 Jun 2024 09:58:50 -0400 Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-52c84a21c62so671792e87.1 for <71379@debbugs.gnu.org>; Sun, 09 Jun 2024 06:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717941447; x=1718546247; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=2uTs33i47rh8/r9mhd2hTI+tK0NIcOthq8tyzeHOhGw=; b=DHCNGrPIF9ARQNvzuYMK7zJxmFJuTa/qCdEjfJBEU6/dsca5qQeyOFAcaRduIKtUxC wttArxsHi3otkPxY2ET+LiJF9aRBxCXIwC4f37RsALbrR6dqZ/JR1M4tu3suGuGY4skJ vAUtoi9mvscUpVPNgwK3xmwT3ONzvWGGbm6xOSrJ/m6sPa6ZYsZ1aQuu5OKZZG1JVWpI xLLaafqZPFYcNerYzbI6slO/+N+RQzjtJWXRHJE7j7mlWcNwUfdcRz3o6CJ+SydmICD6 0KdEuaWFDBEJH8XUPxC2ZIbL0gfSiAdia96s90AaeFjEfpttsY3ndHCSRWbyghNz5M7y itfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717941447; x=1718546247; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2uTs33i47rh8/r9mhd2hTI+tK0NIcOthq8tyzeHOhGw=; b=dQBTSB3Ad2KkZWzwwVOgli++rfut3d9XfhOTHkbjVb+FSND0v1VaQakmpBCWvBZeWc txM5BcDToPK3+UjcMTi8kpxlia0atoqRhcw3l4yPW0W+zpfnO8dDQAYuzk+kez/l5q1R PWP3XSDye+sbxKFGSTUqtS91juAkKOkJiYlA6IHpATUNF52NrsjGlicriMyIkoqvQ5Ei 8kDBF3eISnrq6RAkAhmExL/RaoXqf3h6U2grqYGcA4DjR9ibRU/CZYCJKYMbbbMjCNPG mk5abky5kjdhmyj/SfxWc2bnfnTGzfEYa4Wji5P3u02c5Vk1ihN2oUdNYiU2n9Oaji/R S11w== X-Forwarded-Encrypted: i=1; AJvYcCXnY21JRNrVXps5Pbopug6URk7CYfVXOrNdKIigHunudB2wnhd3/EcIU4t2a2zEYVq9Gmf0V0Gknco3kXlbWFB/0/iO8N0= X-Gm-Message-State: AOJu0YzeOHIqm9YfZPwdSObeVJ3kIyEcnTqVkFGLgCN8yXvPR2YXcdrw mDmEbai9ydyqRg39H3tE84iiEsCeoA2pYwsPiwXymKQYvis2WHqj X-Google-Smtp-Source: AGHT+IEd3I0+moRKehQRJyRzHptP09pspdvZM30jLSbrj4PM4McJ8RA3nLXHfqMRQke8d4go5KeMBQ== X-Received: by 2002:a05:6512:3f21:b0:524:43b2:d326 with SMTP id 2adb3069b0e04-52bb9f83689mr5766521e87.37.1717941446402; Sun, 09 Jun 2024 06:57:26 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52bb41e1e08sm1156592e87.4.2024.06.09.06.57.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Jun 2024 06:57:25 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <86jzizb80k.fsf@gnu.org> Date: Sun, 9 Jun 2024 15:57:25 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> <86sexqit2a.fsf@gnu.org> <03B10D9E-2A0A-4E18-B706-730BB2189CED@gmail.com> <86r0d9ff23.fsf@gnu.org> <86zfrweoqg.fsf@gnu.org> <5A609262-9A22-42A9-9016-C3A38284C9A4@gmail.com> <86jzizb80k.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, schnoebelen.ph@gmail.com, acorallo@gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 8 juni 2024 kl. 20.32 skrev Eli Zaretskii : > Why not? As I said, I think the drawbacks outweigh the advantages right now. It's much easier to keep track of the functions that are subject to the = warning when they are gathered in a single place, and there is an = advantage in keeping the mechanism local. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 04:14:30 2024 Received: (at 71379) by debbugs.gnu.org; 10 Jun 2024 08:14:31 +0000 Received: from localhost ([127.0.0.1]:43879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGaAg-0008C2-JK for submit@debbugs.gnu.org; Mon, 10 Jun 2024 04:14:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGaAe-0008Bb-Hi for 71379@debbugs.gnu.org; Mon, 10 Jun 2024 04:14:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGa8B-0007yF-Gy; Mon, 10 Jun 2024 04:11:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=D5BXfXs1fklFPakKwOK4j4Mu0lJDXZWm5G7DJwUT5Wg=; b=p7jFGA0r5TYxvb1hpyQQ nPo6smAxWj1myn788AIShVCH5oGUDtJjLdMe/ndmDe36hTXjPyf6iJlrCNGSkmllBsv6Hy/tTH4LO WUgY3fTqIW3jbpRFz6lRcwXuP9FtB/hCMEKTO9Rke15ZlMEq3CTq2baph/qorw2oan3pRMSZEmqQe q2AlsDinREXX+WVnscpfc9lSBqIHUZEH+oU7omkeFUOiZ1mayCGPrs7gjM8XhYl2XYTVADzoIbLro VmIFcApWRETJS4hvWcDo92RY/YGhgjAjM5yaIKu3yz6fgK4oP8bfvto+tepjJ6EOhIwieC0K1YwGQ FpC/zx5yLg1rUA==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sGa8B-00034y-1G; Mon, 10 Jun 2024 04:11:55 -0400 From: Andrea Corallo To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Sun, 9 Jun 2024 15:57:25 +0200") References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> <86sexqit2a.fsf@gnu.org> <03B10D9E-2A0A-4E18-B706-730BB2189CED@gmail.com> <86r0d9ff23.fsf@gnu.org> <86zfrweoqg.fsf@gnu.org> <5A609262-9A22-42A9-9016-C3A38284C9A4@gmail.com> <86jzizb80k.fsf@gnu.org> Date: Mon, 10 Jun 2024 04:11:54 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, schnoebelen.ph@gmail.com, Eli Zaretskii , stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mattias Engdeg=C3=A5rd writes: > 8 juni 2024 kl. 20.32 skrev Eli Zaretskii : > >> Why not? > > As I said, I think the drawbacks outweigh the advantages right now. > It's much easier to keep track of the functions that are subject to the w= arning when they are gathered in a single place, and there is an advantage = in keeping the mechanism local. But this is not local only already, see 'info-xref-output' and 'info-xref-output-error'. There might be other occurencies outside emacs.git as well. Andrea From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 11:25:33 2024 Received: (at 71379) by debbugs.gnu.org; 10 Jun 2024 15:25:33 +0000 Received: from localhost ([127.0.0.1]:41796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGgto-000788-MG for submit@debbugs.gnu.org; Mon, 10 Jun 2024 11:25:33 -0400 Received: from mail-lf1-f52.google.com ([209.85.167.52]:53560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGg1O-0001UX-Ev for 71379@debbugs.gnu.org; Mon, 10 Jun 2024 10:29:19 -0400 Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52c82101407so2947981e87.3 for <71379@debbugs.gnu.org>; Mon, 10 Jun 2024 07:29:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718029675; x=1718634475; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=qUcPwAmwJt++CvlGViuoz7Q5FskB9r8NZyO+mhet3fc=; b=LGW2zUFrBiQw9joqNTa8Kkvsh0v8eQIL9xLdR7OOiUQDKsNeYV/IlNWRN2ZHrckPwe FPDkodCB2aQbcnyCuN/Xue92Z66o1yt7fhQqLidD6HpPUajN3LK3IXES6eRgq6q+vRoq hFQGvFHUrrsF+2ieXxgQ7uO2+ZpXxYWaQTraRLDemfwRZNhxax8Trqo3vkUznVhbWbkq vwgBtYDI5KHywZ/ybrjjk+3jeWEbmtZcOo+8J+he0T5Xu/XT9Pktlv6VLFfPFfydAwYm rSVo7GtXkgH9jQvkmKsWlr/yzXSGJKRWpLWrC6CTT7pmbXvYz68G13O2ag4BOSIkCldl caYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718029675; x=1718634475; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qUcPwAmwJt++CvlGViuoz7Q5FskB9r8NZyO+mhet3fc=; b=LoXYEf2MxwvjjtaIsxPd6eIWmytHplk65D6fLnkubcKYxWEylssT9nkao0YHC9KvCY G7Rn2JcdKn3zgZDcaneZCxqIcv8qxKPKx8dobSxbXx7U/57yV75fPpjqlTYy3JKaXAx6 a53OyXyUtfpvZNYS5MHCOF58tenO4rC0FTRRW8uNbZxURa5v0EVxvlO3rjg4sWFuMthy sr0eyL5b60lSAnzh2gcXQmZ/kX9F5kjOIC/bVn+5OjkGJH4OeMMQ6H2Mxfh9ltU+PYun 7HX8oqpRmA5dlMb1ZHDMMGDgwiBLHGQaJ5DR7k5+0tmnshsSf2a4pYXARteORDc43r4T vPxw== X-Forwarded-Encrypted: i=1; AJvYcCVVGAdemw83axqCZlB4afdIaOzdqKgY3Ea4wrtWYMSd8hn/uek2Yc/Om2ybi/eDevfUkDrfA7Wi6YFNWcpd1nWk7ylyewU= X-Gm-Message-State: AOJu0YzKYqBf8uG3toanspe20c1CdvQi2kKcwcOipzH+Hfa1LkDBh+hT vqdA9Ess9x/4E85UyBT0fG02FYR9Ept6apIhFZ4YKdFUkJGkd01O X-Google-Smtp-Source: AGHT+IExnvoGLeC6hjVbz7C4JSMwGK/POCbazoa4mJdhKgNihl8wV9S1rze32D3f+pQPbgCRTfa4YQ== X-Received: by 2002:a05:6512:238a:b0:52b:c2e8:6aa1 with SMTP id 2adb3069b0e04-52bc2e86edbmr8438372e87.29.1718029674858; Mon, 10 Jun 2024 07:27:54 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52c8946708asm656747e87.217.2024.06.10.07.27.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Jun 2024 07:27:54 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Mon, 10 Jun 2024 16:27:53 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> <86sexqit2a.fsf@gnu.org> <03B10D9E-2A0A-4E18-B706-730BB2189CED@gmail.com> <86r0d9ff23.fsf@gnu.org> <86zfrweoqg.fsf@gnu.org> <5A609262-9A22-42A9-9016-C3A38284C9A4@gmail.com> <86jzizb80k.fsf@gnu.org> To: Andrea Corallo X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, schnoebelen.ph@gmail.com, Eli Zaretskii , stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 10 juni 2024 kl. 10.11 skrev Andrea Corallo : > But this is not local only already, see 'info-xref-output' and > 'info-xref-output-error'. Very much aware of that, and don't think it's worth doing anything = about. > There might be other occurencies outside > emacs.git as well. Already checked that as well, and there were almost none -- all I could = find was a single occurrence in one package. Not that we really care = since it's an internal and undocumented interface. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 12:24:18 2024 Received: (at 71379) by debbugs.gnu.org; 11 Jun 2024 16:24:18 +0000 Received: from localhost ([127.0.0.1]:35980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH4IE-0001gg-FM for submit@debbugs.gnu.org; Tue, 11 Jun 2024 12:24:18 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:53355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH4ID-0001gS-6Y for 71379@debbugs.gnu.org; Tue, 11 Jun 2024 12:24:17 -0400 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-42189d3c7efso24585235e9.2 for <71379@debbugs.gnu.org>; Tue, 11 Jun 2024 09:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718122993; x=1718727793; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=9xFcvgl0rX41b1JEwCdWWNqLnCN2XrLWoGsYnzxHzS4=; b=eY6RGiK9R39q5IWHlSkxKE+/N2zCBbLWMiI6ZdwN/pLBDc+JKQ8Qo/KExDz0iJzE9+ v2fnP0XJNZxmHUV80WmJ0nFB2ISQcSMtmMcD+Rpu663sCqjJcrpVF3ouy6v2DEWtMUOk 5XXoT8wTJJJ1SIfil7MuohhhasiDe5GIjmG1lzTyfsZCVw9915Nkww0MZFJvlKKefIyK Fuluu65Y1j3sRygcT5I2ytaC7zc/96D5x9fH2oBQ9v8TgtmFXNUlmwMsC4FwmmKi8Pxc W3EkS8yzbVTTlunvfeQjsK7kD8eYBxq4MNgCLHjZ7glXShAZdgnOS0oowv2Mmx0U4NuZ OwWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718122993; x=1718727793; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9xFcvgl0rX41b1JEwCdWWNqLnCN2XrLWoGsYnzxHzS4=; b=Y3pjHkEDgy9SLN5vkMilO/NIanJlyUDJuhqv9+KVOkeLYN0k8yEtJ7KJ/lUHINtbLG 0r5UXPqhZXyYRYaDeh/sUCZANnfC7WeqImv78KFasITST+ksI5k/V6ntIJPaqEj8lOWS FQVTHnw7WZWJPZBTqserOQSUmQlMpMyU6rEykB8jB+pb9nVjoIbCQOg1eztKr2313fwH iIMm9nDYtR35Z/dFJylpfo77PMRla994SWBGIKIFO82E1T3W4csV/UuGyKNkUZzl5W47 zIlTyANBAhHenhcR59OcWULtpm0XZdRFnLs06Hut/u+L6SZQKxp5sztwcKqDEWBycY9x uPWA== X-Forwarded-Encrypted: i=1; AJvYcCVJoWrCxiAqjNzwdpMhttZw0NVg9N8UifW2C+rpxqatr7xeQHUiT3s3LOKxpHZWIwVyYicX42pRP11umoptWw8RmRB2NY8= X-Gm-Message-State: AOJu0Yw/2VjeqjssAjy5A9e7fUIfrAnmFaeICp6L2prgO/NAGwknBEzV /QHAKD3ciag7DJaR+RH8ZYu/hHIyOapuyFPxCQNzdZVabYACaTECYq5Z/g== X-Google-Smtp-Source: AGHT+IEea1yxQ9WVWBBO5tzOMUTkdMUJ0Bj9ENGbfouDpnLlQT8WYt76WbbQ43FcTNU8xe161aBt+Q== X-Received: by 2002:a19:8c42:0:b0:52c:7fbf:39f6 with SMTP id 2adb3069b0e04-52c7fbf3b15mr6567568e87.26.1718116235781; Tue, 11 Jun 2024 07:30:35 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52c8f5a5c1bsm753573e87.258.2024.06.11.07.30.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jun 2024 07:30:34 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Tue, 11 Jun 2024 16:30:34 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <3B38FAB8-F2B6-4E3D-92F0-283FE36BFAE4@gmail.com> References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> <86sexqit2a.fsf@gnu.org> <03B10D9E-2A0A-4E18-B706-730BB2189CED@gmail.com> <86r0d9ff23.fsf@gnu.org> <86zfrweoqg.fsf@gnu.org> <5A609262-9A22-42A9-9016-C3A38284C9A4@gmail.com> <86jzizb80k.fsf@gnu.org> To: Andrea Corallo X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, schnoebelen.ph@gmail.com, Eli Zaretskii , stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 10 juni 2024 kl. 23.14 skrev Andrea Corallo : > You can indeed have your opinions, but again this shows that the > mechanism is not local only already, and that it's already in use > outside as there was probably need for it. No it doesn't. I don't know what is special about this warning, enough for you to argue = strongly about it, but maybe you don't either -- once we take a strong = position about something, even by accident, it's difficult to stop, and = to admit that it's perhaps not that important after all. So let's give it a rest. I will keep revisiting this again, as I have = many times before, and of course so may you. If we do something, let's = make sure we know why, not just because we have made up our minds about = it. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 16:24:30 2024 Received: (at 71379) by debbugs.gnu.org; 11 Jun 2024 20:24:30 +0000 Received: from localhost ([127.0.0.1]:36400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH82f-0002l2-Q1 for submit@debbugs.gnu.org; Tue, 11 Jun 2024 16:24:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH82e-0002kn-9K for 71379@debbugs.gnu.org; Tue, 11 Jun 2024 16:24:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGmLl-0008V9-4X; Mon, 10 Jun 2024 17:14:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=vgeUyXMmEQQMIlJ+gRN4yst2vUxb233RNdp77av6bkY=; b=e13li6uoL0D1j0KkxPEx E1QPuE4r63kfsICDAxHJ5WqKMg2GimgzPF2ytb4NsdmNmcllc5Gr+UM4LbcmSsrdL4kSuU8JpcvKZ 0fovAWJpFmwP6x9mVEsBCwDv0BH8r9FDBGpShJysNgX5bT2I/vdThN6HlUXeuaXBTsw0+Bb5iVQNF Cvn4shZ/+sck6zlFO9godIxfE6MraJOr4EDNdmc3BqxWAVf4oJvowA3A6TRSGvrDkDHdaPp9cX3+O R7DT7YasB39KbtDRougI0A/lhJVTBZzymi6K2rbEZrZo7SfnxLutT33GbYxO6KB2Xhio+iNRixOPY 2lIFVItL8ZO5hA==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sGmLj-0005vb-Dr; Mon, 10 Jun 2024 17:14:44 -0400 From: Andrea Corallo To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#71379: 29.3; Elisp compiler: warnings for formats given insufficiently many arguments In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Mon, 10 Jun 2024 16:27:53 +0200") References: <4BAD9800-BCDA-42FD-B1AC-9E6C69B62B12@gmail.com> <861q5bjn6e.fsf@gnu.org> <4C5F14A4-EE39-4DDE-9E25-C311F2DA8BC7@gmail.com> <86sexqit2a.fsf@gnu.org> <03B10D9E-2A0A-4E18-B706-730BB2189CED@gmail.com> <86r0d9ff23.fsf@gnu.org> <86zfrweoqg.fsf@gnu.org> <5A609262-9A22-42A9-9016-C3A38284C9A4@gmail.com> <86jzizb80k.fsf@gnu.org> Date: Mon, 10 Jun 2024 17:14:43 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71379 Cc: 71379@debbugs.gnu.org, schnoebelen.ph@gmail.com, Eli Zaretskii , stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mattias Engdeg=C3=A5rd writes: > 10 juni 2024 kl. 10.11 skrev Andrea Corallo : > >> But this is not local only already, see 'info-xref-output' and >> 'info-xref-output-error'. > > Very much aware of that, and don't think it's worth doing anything about. > >> There might be other occurencies outside >> emacs.git as well. > > Already checked that as well, and there were almost none -- all I > could find was a single occurrence in one package. Not that we really > care since it's an internal and undocumented interface. You can indeed have your opinions, but again this shows that the mechanism is not local only already, and that it's already in use outside as there was probably need for it. From unknown Mon Aug 18 09:06:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 10 Jul 2024 11:24:21 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator