GNU bug report logs - #71374
[PATCH] Simplify 'help-enable-variable-value-editing' using

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philip Kaludercic <philipk <at> posteo.net>
Subject: bug#71374: closed (Re: bug#71374: [PATCH] Simplify
 'help-enable-variable-value-editing' using)
Date: Sun, 28 Jul 2024 12:05:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#71374: [PATCH] Simplify 'help-enable-variable-value-editing' using

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 71374 <at> debbugs.gnu.org.

-- 
71374: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71374
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: Jeremy Bryant <jb <at> jeremybryant.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Stefan Kangas <stefankangas <at> gmail.com>,
 71374-done <at> debbugs.gnu.org
Subject: Re: bug#71374: [PATCH] Simplify
 'help-enable-variable-value-editing' using
Date: Sun, 28 Jul 2024 12:04:28 +0000

Jeremy Bryant <jb <at> jeremybryant.net> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> Philip Kaludercic <philipk <at> posteo.net> writes:
>>
>>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>>
>>>>> From: Philip Kaludercic <philipk <at> posteo.net>
>>>>> Date: Wed, 05 Jun 2024 06:55:46 +0000
>>>>>
>>>>> The main issue with this patch is that it drops the syntax highlighting
>>>>> in the *string edit* buffer, but we could fix that in a second patch by
>>>>> adding support to specify a major mode to inherit from when editing a
>>>>> string.
>>>>
>>>> Thanks.  This is basically a cleanup, yes?  IOW, there's nothing wrong
>>>> with the current implementation, right?  If so, I'd prefer to wait
>>>> with this until after the emacs-30 branch is cut.
>>>
>>> Right, it just seemed like the kind of thing where it would be natural
>>> to demonstrate string-edit.
>>
>> Feel free to install on master now, thanks.
>
> Philip, has this been installed on master?  Can the bug be closed?

I hadn't pushed the change, have done so now.  Closing the report.
Thanks for the reminder.

-- 
	Philip Kaludercic on peregrine

[Message part 3 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Simplify 'help-enable-variable-value-editing' using
Date: Wed, 05 Jun 2024 06:55:46 +0000

[Message part 4 (text/plain, inline)]

The main issue with this patch is that it drops the syntax highlighting
in the *string edit* buffer, but we could fix that in a second patch by
adding support to specify a major mode to inherit from when editing a
string.

[0001-Simplify-'help-enable-variable-value-editing'-usin.patch (text/x-patch, attachment)]

[Message part 6 (text/plain, inline)]

-- 
	Philip Kaludercic on peregrine

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.