GNU bug report logs - #71371
[PATCH] gnu: svn-fetch: Make revision field optional.

Previous Next

Full log

Message #23 received at 71371 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 71371 <at> debbugs.gnu.org, Josselin Poiret <dev <at> jpoiret.xyz>,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Ludovic Courtès <ludo <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>,
 Florian Pelz <pelzflorian <at> pelzflorian.de>,
 Christopher Baines <guix <at> cbaines.net>, Matthew Trzcinski <matt <at> excalamus.com>
Subject: Re: [bug#71371] [PATCH v2] gnu: svn-fetch: Allow specifying
 revisions as strings.
Date: Tue, 18 Jun 2024 08:11:06 -0400

Hello,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> * guix/svn-download.scm (<svn-reference>):
> (svn-fetch):
> (svn-multi-fetch):
> * guix/build/svn.scm (svn-fetch): Revision can also be a string, not only
> a number.
> * doc/guix.texi (origin Reference): Document changes about REVISION field.
>
> Change-Id: Ibb17b539575fdf3daf895bd1ce39a40dd9b495cb
> ---
> v2: No longer ignore "-r" argument. Instead, allow strings, such as "HEAD". Yes, in practice, it means this relies on the tag being stable, which is the same assumption as for, e.g., tarballs. WDYT?

While it may be useful to point to volatile references such as HEAD for
internal projects (like I believe is also possible for our git fetcher)
or the likes (with a hash of #f for example), I wouldn't like to see
this used in the Guix tree (I'd consider it a bad practice).  I'm not
against merging this, but I think we should add a 'guix lint' rule
that'd warn that some SVN reference should be specified if it wasn't.

Does that sound reasonable?

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.