GNU bug report logs - #71362
[PATCH] gnu: rust-nix-0.28: fix package test.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71362 in the body.
You can then email your comments to 71362 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: picnoir <at> alternativebit.fr
To: guix-patches <at> gnu.org
Cc: Picnoir <picnoir <at> alternativebit.fr>
Subject: [PATCH] gnu: rust-nix-0.28: fix package test.
Date: Tue,  4 Jun 2024 14:34:05 +0200

From: Picnoir <picnoir <at> alternativebit.fr>

This package was introduced as a dependency for Nsncd. The package
test suite is not run when building Nsncd, we did not realize it was
failing.

* gnu/packages/crates-io.scm (rust-nix-0.28): Fix test phase, enable all crate
for cargo test, disable failing tests.

Change-Id: Ice72d93b3a3f5f02640d2c1f90d745dc4b1a6550
---
 gnu/packages/crates-io.scm | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 5c9bc4c525..80d851a4cc 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -41048,7 +41048,30 @@ (define-public rust-nix-0.28
         (base32 "1r0rylax4ycx3iqakwjvaa178jrrwiiwghcw95ndzy72zk25c8db"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:cargo-inputs (("rust-bitflags" ,rust-bitflags-2)
+     `(#:cargo-test-flags
+       '("--all-features"
+         "--"
+         ; The following tests do not seem to terminate
+         "--skip=test_unistd::test_execveat_empty::test_cstr_ref"
+         "--skip=test_unistd::test_execveat_empty::test_cstring"
+         "--skip=test_unistd::test_execveat_relative::test_cstr_ref"
+         "--skip=test_unistd::test_execveat_relative::test_cstring"
+         "--skip=test_unistd::test_fexecve::test_cstr_ref"
+         "--skip=test_unistd::test_fexecve::test_cstring"
+         ; The following tests are failing
+         "--skip=test_unistd::test_execve::test_cstr_ref"
+         "--skip=test_unistd::test_execve::test_cstring"
+         "--skip=test_unistd::test_execveat_absolute::test_cstr_ref"
+         "--skip=test_unistd::test_execveat_absolute::test_cstring"
+         ; The following tests are panicking
+         "--skip=sys::personality::set"
+         "--skip=sys::socket::sendmsg"
+         "--skip=unistd::Group::from_gid"
+         "--skip=unistd::Group::from_name"
+         "--skip=unistd::User::from_name"
+         "--skip=unistd::User::from_uid"
+         )
+       #:cargo-inputs (("rust-bitflags" ,rust-bitflags-2)
                        ("rust-cfg-if" ,rust-cfg-if-1)
                        ("rust-cfg-aliases" ,rust-cfg-aliases-0.1)
                        ("rust-libc" ,rust-libc-0.2.153)

base-commit: 5d3edff1a604414a3c42b89fcbc007e9d573993d
prerequisite-patch-id: 6e77bad801c8584f6478c9c59038597dee857cde
--
2.41.0

Message #10 received at 71362-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: picnoir <at> alternativebit.fr
Cc: 71362-done <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#71362] [PATCH] gnu: rust-nix-0.28: fix package test.
Date: Thu, 06 Jun 2024 20:53:02 +0100

[Message part 1 (text/plain, inline)]

picnoir <at> alternativebit.fr writes:

> From: Picnoir <picnoir <at> alternativebit.fr>
>
> This package was introduced as a dependency for Nsncd. The package
> test suite is not run when building Nsncd, we did not realize it was
> failing.
>
> * gnu/packages/crates-io.scm (rust-nix-0.28): Fix test phase, enable all crate
> for cargo test, disable failing tests.
>
> Change-Id: Ice72d93b3a3f5f02640d2c1f90d745dc4b1a6550
> ---
>  gnu/packages/crates-io.scm | 25 ++++++++++++++++++++++++-
>  1 file changed, 24 insertions(+), 1 deletion(-)

Thanks for the patch, I've pushed this to master as
f430a1938818b8bb8cb575b575bf3f52b4413d0a.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.