Subject: bug#71361: closed (Re: [bug#71361] [PATCH] gnu: rust-dns-lookup-2: fix package test.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 10 Jun 2024 20:16:03 +0000

Your bug report

#71361: [PATCH] gnu: rust-dns-lookup-2: fix package test.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
71361: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71361
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#71361] [PATCH] gnu: rust-dns-lookup-2: fix package test.
From: Christopher Baines <[email-masked]>
To: [email-masked]
Cc: [email-masked], Efraim Flashner <[email-masked]>
Date: Mon, 10 Jun 2024 11:10:20 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

[email-masked] writes:

> From: Picnoir <[email-masked]>
>
> * gnu/packages/crates-io.scm (rust-dns-lookup-2): this package was introduced
> in abfef465b2b2353610cbff2caefee679566978f7 as a dependency for Nsncd. We can
> build Nsncd just fine, but building explicitely this package is failing. The
> issue comes from two tests making assumption about domain name resolution. The
> Guix build sandbox breaks these assumptions, preventing the test suite to
> succeed. Fixing this by disabling the faulty tests.
>
> Change-Id: Idc42822d8cd72e83e9ea973820b5073ff87ad4d4
> ---
>  gnu/packages/crates-io.scm | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Thanks! I've pushed this to master as
7b0970fb4386726519204b74230b563ad060741b.

Chris

Subject: [PATCH] gnu: rust-dns-lookup-2: fix package test.
From: [email-masked]
To: [email-masked]
Cc: Picnoir <[email-masked]>
Date: Tue, 4 Jun 2024 14:06:56 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

From: Picnoir <[email-masked]>

* gnu/packages/crates-io.scm (rust-dns-lookup-2): this package was introduced
in abfef465b2b2353610cbff2caefee679566978f7 as a dependency for Nsncd. We can
build Nsncd just fine, but building explicitely this package is failing. The
issue comes from two tests making assumption about domain name resolution. The
Guix build sandbox breaks these assumptions, preventing the test suite to
succeed. Fixing this by disabling the faulty tests.

Change-Id: Idc42822d8cd72e83e9ea973820b5073ff87ad4d4
---
 gnu/packages/crates-io.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 47c280e79f..5c9bc4c525 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -19955,7 +19955,12 @@ (define-public rust-dns-lookup-2
         (base32 "1z74n2zij2gahycabm0gkmkyx574h76gwk7sz93yqpr3qa3n0xp5"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:cargo-inputs (("rust-cfg-if" ,rust-cfg-if-1)
+     `(#:cargo-test-flags
+       '("--"
+         ;; the builder sandbox breaks getaddrinfo, failing two tests.
+         "--skip=nameinfo::test_getnameinfo"
+         "--skip=src/lib.rs")
+       #:cargo-inputs (("rust-cfg-if" ,rust-cfg-if-1)
                        ("rust-libc" ,rust-libc-0.2)
                        ("rust-socket2" ,rust-socket2-0.5)
                        ("rust-windows-sys" ,rust-windows-sys-0.48))))

base-commit: 5d3edff1a604414a3c42b89fcbc007e9d573993d
-- 
2.41.0