GNU bug report logs - #71355
30.0.50; [PATCH] Improve performance of buffered output in Eshell

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Subject: bug#71355: closed (Re: bug#71355: 30.0.50; [PATCH] Improve
 performance of buffered output in Eshell)
Date: Sat, 08 Jun 2024 19:45:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#71355: 30.0.50; [PATCH] Improve performance of buffered output in Eshell

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 71355 <at> debbugs.gnu.org.

-- 
71355: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71355
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 71355-done <at> debbugs.gnu.org
Subject: Re: bug#71355: 30.0.50; [PATCH] Improve performance of buffered
 output in Eshell
Date: Sat, 8 Jun 2024 12:43:18 -0700

On 6/8/2024 12:33 AM, Stefan Kangas wrote:
> Jim Porter <jporterbugs <at> gmail.com> writes:
> 
>> Since it sounds like all the other concerns have been addressed, I'll
>> probably merge this in the next day or so. (This is the last non-bugfix
>> change I'd like to land for Eshell in Emacs 30.)
> 
> Sounds good to me.

I took one last look after sleeping on it, and everything seems correct 
to me, so I've now merged this to the master branch as 15f515c7a37.

[Message part 3 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Improve performance of buffered output in Eshell
Date: Mon, 3 Jun 2024 22:36:29 -0700

[Message part 4 (text/plain, inline)]

In Eshell, if I run "time cat config.log" from my Emacs build directory, 
it reports that it takes about 7.5s. It also doesn't show *any* output 
until it's completely finished. With my attached patches, it now takes 
about 0.6s and also shows the output iteratively, redisplaying 
periodically so users can see that something is happening.

The other command most likely to be impacted by this is the built-in 
version of "ls". When I run "ls -Al /usr/bin" on my system, I go from 
2.1s before my patch to 1.2s after. Not as big an improvement, but still 
noticeable, and it *feels* a lot faster too with the iterative redisplay.

I don't usually add a NEWS entry for perf improvements, but this one 
seemed notable enough that I figured it was worth tooting my own horn. :)

[0001-Be-more-efficient-when-buffering-output-in-Eshell.patch (text/plain, attachment)]

[0002-Improve-implementations-of-some-Eshell-output-filter.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.